Re: Review Board Ticket #4488: Discarding a draft will lose the diff

2016-11-22 Thread Christian Hammond
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4488/
--

New update by samsun387
For Beanbag, Inc. > Review Board > Ticket #4488


Reply:

This is by design. The diff is part of the draft, and discarding the draft 
will discard all parts of it.

We _do_ copy over _some_ (not all) information when discarding the 
_initial_ draft, so you can locate it again, but the diff is not one of these 
things. If you've discarded a draft, you rarely want to keep the code around, 
as it's often a duplicate of another review request or contains something 
(sensitive information, perhaps) that you don't want to retain. So if you've 
discarded, and you want to reopen it, it's your responsibility to make a 
determination on what diff you want attached to it again.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Review Board Ticket #4488: Discarding a draft will lose the diff

2016-11-22 Thread Kevin Yu
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4488/
--

New ticket #4488 by samsun387
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Discarding a draft will lose the diff
==

# What version are you running?
2.5.6.1

# What's the URL of the page containing the problem?
draft

# What steps will reproduce the problem?
1. Use rbt post to create a draft
2. Don't publish it. Discard it 
3. Reopen the draft


# What is the expected output? What do you see instead?
Expected: Diff should still be there. 
Actual: Diff is gone. the tab for showing diff is gone too.

# What operating system are you using? What browser?
Ubuntu 14.04 Chrome Version 54.0.2840.100 (64-bit)

# Please provide any additional information below.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Review Board Ticket #4487: Duplicate entry 'admin' for key 'username'

2016-11-22 Thread Bruno Meneguello
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4487/
--

New ticket #4487 by bkmeneguello
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * stack.log
   



--
Duplicate entry 'admin' for key 'username'
==

# What version are you running?
2.5.7

# What's the URL of the page containing the problem?


# What steps will reproduce the problem?
1. Perform a full instalation of Review Board
2. Delete the site directory
3. Try to install again using the populated database


# What is the expected output? What do you see instead?
Is expected to work cleanly, detecting the current database installation and 
only creating the site archives. Instead an error occurs when there is an user 
with de admin provided username. I expect that installation process verify the 
user exists and is an admin and ignore this step.

# What operating system are you using? What browser?


# Please provide any additional information below.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: RBTools Ticket #4409: rbt patch deletes folder even though the folder deletion is not in the diff!

2016-11-22 Thread Kevin Yu
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4409/
--

New update by samsun387
For Beanbag, Inc. > RBTools > Ticket #4409


Summary:
- rbt patch deletes folder even though the folder deletion is not in the 
diff
+ rbt patch deletes folder even though the folder deletion is not in the 
diff!

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.