Re: Review Board Ticket #3988: Differ doesn't align lines properly and displays diff based off of the misaligned lines

2017-01-15 Thread Sean McCarthy
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/3988/
--

New update by scmccarthy
For Beanbag, Inc. > Review Board > Ticket #3988


Reply:

Yes, the initial heuristics used to find the diff are typical and fine. The 
problem, like I said, is that the display code is screwing it up afterwards.

Gotta admit I'm a bit miffed that the effort I put in to figure out what 
you're screwing up that other diff utilities aren't is completely ignored in 
your response. I understand not wanting to fix the bug (after all, no one else 
seems to have complained about it in over a year, and I'm not currently using 
reviewboard now either), just wish it seemed like you'd read the description I 
put together. Regardless, thanks for taking a look.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #3971: SSL: CERTIFICATE_VERIFY_FAILED error when adding GitHub repository

2017-01-15 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/3971/
--

New update by freastro
For Beanbag, Inc. > Review Board > Ticket #3971


Reply:

This is a problem with Bitnami's installer, not Review Board.


Status:
- New
+ ThirdParty

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: RBTools Ticket #3997: Unable to post a review request

2017-01-15 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/3997/
--

New update by alblinov
For Beanbag, Inc. > RBTools > Ticket #3997


Reply:

This should be much improved with the upstream branch detection currently 
in rbtools master.


Status:
- New
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #3988: Differ doesn't align lines properly and displays diff based off of the misaligned lines

2017-01-15 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/3988/
--

New update by scmccarthy
For Beanbag, Inc. > Review Board > Ticket #3988


Reply:

I think you've just managed to find a case where our algorithm performs 
particularly badly. The heuristics we use are the same that GNU diff does, for 
better or worse. If you think you can improve it, we'd be happy to look at a 
patch.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4084: Users without editing rights on a review request do not see the onbeforeunload dialog

2017-01-15 Thread Barret Rennie
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4084/
--

New update by mconley
For Beanbag, Inc. > Review Board > Ticket #4084


Assigned to:
+ khp

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: RBTools Ticket #4470: UnicodeDecodeError: 'ascii' codec can't decode byte 0xb0 in position 1: ordinal not in range(128)

2017-01-15 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4470/
--

New update by kone
For Beanbag, Inc. > RBTools > Ticket #4470


Reply:

This seems like a bug deep inside python trying to read the windows 
registry. I don't see anything that we can do about this.


Status:
- New
+ ThirdParty

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4457: Ubuntu: SSL: CERTIFICATE_VERIFY_FAILED

2017-01-15 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4457/
--

New update by cantrianbear
For Beanbag, Inc. > Review Board > Ticket #4457


Reply:

What version control system? Looks like SVN? If so, are you using the PySVN 
or Subvertpy backend?


Status:
- New
+ NeedInfo

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: RBTools Ticket #4424: CRITICAL: 'ascii' codec can't decode byte 0xe9 in position 3: ordinal not in range(128)

2017-01-15 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4424/
--

New update by sdompierre
For Beanbag, Inc. > RBTools > Ticket #4424


Reply:

RBTools 0.7.8 ships with a modern version of python.


Status:
- Confirmed
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4194: Include real line numbers for diff comments in API, webhook payloads

2017-01-15 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4194/
--

New update by pawolf
For Beanbag, Inc. > Review Board > Ticket #4194


Reply:

That refers to the "row number" within the side-by-side diff table. We 
should include the real line numbers in the webhook payload and API, though


Tags:
- Type:Defect
+ Component:API
+ Component:Webhooks
+ Type:Enhancement


Summary:
- First line for diff comment not as expected
+ Include real line numbers for diff comments in API, webhook payloads

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4487: Duplicate entry 'admin' for key 'username'

2017-01-15 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4487/
--

New update by bkmeneguello
For Beanbag, Inc. > Review Board > Ticket #4487


Status:
- New
+ PendingReview


Assigned to:
+ david

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.