Re: Review Board Ticket #4988: Fail to post diff with perforce repo: 'Value to convert is unexpected type %s',
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4988/ -- New update by benjackson For Beanbag, Inc. > Review Board > Ticket #4988 Reply: Fixed in release-4.0.x (99b1e7e). This will ship in the upcoming 5.0.2 and (at a later point), 4.0.12 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20230206213937.1291.57705%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4988: Fail to post diff with perforce repo: 'Value to convert is unexpected type %s',
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4988/ -- New update by benjackson For Beanbag, Inc. > Review Board > Ticket #4988 Reply: Found a regression with the fix, but we'll get reworked version in for 5.0.2 (which is going out tonight/tomorrow). `force_text()`/`force_str()` will assume an encoding if the object is a `bytes` or converts to a `bytes`. The problem with this is that we can't assume at this particular stage. We instead need to use the configured encoding list. This matters particularly for people working with some Chinese encodings. `convert_to_unicode()` is responsible for trying the configured encodings, but since the fix was passing in the forced-encode, it never got a chance. That's not a problem for `Revision` instances, but is for raw revisions. Probably not even a problem there (revisions are generally effectively ASCII in most SCMs), but it's more of a problem when forcing the encoding for filenames (which are completely at the whim of the developers committing code). Making a change to specifically check for and cast the `Revision` before storing it instead, which should be a bit safer. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20230207032257.30335.48780%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4990: use p4 fstat to capture 'headType' (file type) so that it can be displayed in ReviewBoard diffs
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4990/ -- New update by shubhar For Beanbag, Inc. > RBTools > Ticket #4990 Reply: We agree, and have begun baking in some ability to capture data like that. The limiting factor is that diff formats generally don't include metadata like this, and Perforce diffs certainly don't. The long-term plan is to move our Perforce diff implementation over to [DiffX](https://diffx.org), which later Review Board 4.0.x versions support. That'll allow us to capture data like that in RBTools. We still need to add UI for this in Review Board, and we're looking at that for Review Board 6 (in development) or 7. Status: - New + Confirmed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20230207044118.30335.14469%40ip-10-1-54-209.ec2.internal.
