Re: Review Board Ticket #4389: Using lots of

[glob]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4389/
--

New update by bzbarsky
For Beanbag, Inc. > Review Board > Ticket #4389


Reply:

here's the change we're using at mozilla, which addresses this issue.
https://hg.mozilla.org/webtools/reviewboard/rev/c4124cae0efd

christian has indicated this isn't his preferred solution, so i won't 
attach this as a patch for review.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4444: Diff Logic Misses Completely Changed Line

[glob]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets//
--

New update by davidwalsh
For Beanbag, Inc. > Review Board > Ticket #


Reply:

github's side-by-side view makes these sorts of changes crystal clear, imho 
without making the overall experience worse.


Files:
- Screenshot 2016-07-26 15.45.50.png
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4444: Diff Logic Misses Completely Changed Line

[glob]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets//
--

New update by davidwalsh
For Beanbag, Inc. > Review Board > Ticket #


Reply:

another option would be to not highlight an entire line unless the entire 
line has changed.
ie. "few character" changes would have a while background, with just the 
modified characters highlighted with a yellow background.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4420: Bugzilla info panel contains python unicode objects. eg. Status: (u'ASSIGNED', )

[glob]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4420/
--

New ticket #4420 by glob
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Bugzilla info panel contains python unicode objects.  eg. Status: (u'ASSIGNED',)
==

# What version are you running?
2.5.4

# What's the URL of the page containing the problem?
https://reviewboard.mozilla.org/r/6863/

# What steps will reproduce the problem?
1. visit https://reviewboard.mozilla.org/r/6863/ (or any other review request)
2. hover over bug number

# What is broken?

the bug info panel contains:

1153053: (u'Implement command to submit reviews to MozReview using 
git-cinnabar',)
Status: (u'ASSIGNED',)
etc..

# Please provide any additional information below.

the fix for this involves casting the response from bugzilla to a string.  
pretty straight forward.

note: the rest request can be improved by requesting just the fields that 
review board requires (the default is to return all fields, which can be 
expensive).

i have a work around for our instance in 
https://reviewboard.mozilla.org/r/56588/diff/1 most of which i plan on 
providing as a patch for review board itself once i find some time.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.