Issue 1072 in reviewboard: SVN --config-dir support
Comment #15 on issue 1072 by yunshan.di: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 I enabled the review board logging setting, create request again, it seems that diff is working background, but the review request is failed to be created with the 403 Forbidden error. The apache log: 2009-09-27 19:20:57,858 - WARNING - Could not open logfile /logs/reviewboard.log. Logging to stderr 2009-09-27 19:20:57,858 - INFO - Logging to /logs/reviewboard.log with a minimum level of DEBUG 2009-09-27 19:20:57,858 - INFO - Log file for Review Board v1.0rc3 2009-09-27 19:21:07,342 - DEBUG - DiffParser.parse: Beginning parse of diff, size = 6082 2009-09-27 19:21:07,342 - DEBUG - DiffParser.parse: Finished parsing diff. 2009-09-28 13:50:05,924 - DEBUG - DiffParser.parse: Beginning parse of diff, size = 8538 2009-09-28 13:50:05,924 - DEBUG - DiffParser.parse: Finished parsing diff. 2009-09-28 13:50:24,596 - DEBUG - DiffParser.parse: Beginning parse of diff, size = 8538 2009-09-28 13:50:24,596 - DEBUG - DiffParser.parse: Finished parsing diff. 2009-09-28 13:50:32,721 - DEBUG - DiffParser.parse: Beginning parse of diff, size = 8538 2009-09-28 13:50:32,737 - DEBUG - DiffParser.parse: Finished parsing diff. 2009-09-28 13:50:42,815 - DEBUG - DiffParser.parse: Beginning parse of diff, size = 8538 2009-09-28 13:50:42,815 - DEBUG - DiffParser.parse: Finished parsing diff. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: SVN --config-dir support
Comment #12 on issue 1072 by yunshan.di: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 dear sharrell, I have add the patch you provided, after compile the svn.py and restart apache server, the following error rises when i create a new review request: The message is copied from apache log=== 'Repository' object has no attribute 'allow_all_certs' Traceback (most recent call last): File c:\python25\lib\site-packages\django-1.0.3- py2.5.egg\django\core\handlers\base.py, line 91, in get_response response = callback(request, *callback_args, **callback_kwargs) File C:\Python25\lib\site-packages\djblets-0.5.3-py2.5.egg\djblets\auth\util.py, line 46, in _checklogin return view_func(request, *args, **kwargs) File c:\python25\lib\site-packages\ReviewBoard-1.0rc3- py2.5.egg\reviewboard\reviews\views.py, line 84, in new_review_request fields[repo.id] = repo.get_scmtool().get_fields() File c:\python25\lib\site-packages\ReviewBoard-1.0rc3- py2.5.egg\reviewboard\scmtools\models.py, line 40, in get_scmtool return cls(self) File C:\Python25\lib\site-packages\reviewboard-1.0rc3- py2.5.egg\reviewboard\scmtools\svn.py, line 81, in __init__ if repository.allow_all_certs is True: AttributeError: 'Repository' object has no attribute 'allow_all_certs' please help, thanks again! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: SVN --config-dir support
Comment #13 on issue 1072 by sharrell.purdue: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 If you remove the if repository.allow_all_certs is True: line and unident the line after it four spaces that should probably work fine. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: SVN --config-dir support
Comment #14 on issue 1072 by yunshan.di: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 yes, i did it, and the 500 error gone; but when i create a request, error prompt saying: Server sent unexpected return value (403 Forbidden) in response to OPTIONS request for URL i hava configed the svn repository with the username and password which can pass the authentication. and i have tried in commandline, with svn list --username name --passowrd pass URL it works. so i'm sure why the 403 error came out. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: SVN --config-dir support
Updates: Labels: -Milestone-Release1.5 Milestone-Release1.1 Comment #9 on issue 1072 by chipx86: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 Just an update on this. We are working on a way to verify, store and manage certificates for 1.1. This will work for SVN and other revision control systems. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: SVN --config-dir support
Comment #7 on issue 1072 by yunshan.di: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 I'm running on windows with Apache2, rise the same error. how to fix it, any ideas? thanks! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: SVN --config-dir support
Comment #6 on issue 1072 by mathieuk: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 I ran into a similar issue. Our SVN setup uses client certificates. When trying to use ReviewBoard I'd always end up with an error message saying 'callback_ssl_client_cert_prompt required': PySVN detected it needs a client certificate but there is no code to ask for it. I worked around this by giving PySVN.Client a config dir for the current -effective- user (working around the issue vlysenkov reported in comment #5). Patch attached. Probably not the cleanest, as I'm no python developer, but this solves the issue for me. Attachments: reviewboard-patch-issue-1072-2 550 bytes -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: SVN --config-dir support
Comment #4 on issue 1072 by pinkj9: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 I'm running on Debian with Apache2, by default the web server runs as www-data with homedir /var/www/. I've changed the ownership and group of this folder to www-data and if I run svn commands as this user, I was prompted the first time to accept the certificate. I can therefore confirm that .subversion/auth/... exists but I still get the problem. Any ideas? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: SVN --config-dir support
Comment #5 on issue 1072 by vlysenkov: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 I've tried it with apache2, too. The problem was that despite of running reviewboard scripts as www-data, HOME environment variable was set to /home/vlysenkov, not /home/www-data. Very strange, surely, and it occurs when I restart apache2 by sudo /usr/local/etc/rc.d/apache2 restart. It seems that apache2 inherits HOME envvar value. The possible solution is to tune apache2 to set HOME variable when starting reviewboard. And my intention in this issue is to leave apache2 HOME var intact. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: SVN --config-dir support
Comment #3 on issue 1072 by sharrell.purdue: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 Here is half of a patch to fix this the SSL problem. This doesn't allow the --config-dir support however it does bypass the ssl problem. I added an if with an imaginary variable repository.allow_all_certs that would turn it on or off. I am not sure how to hook this in, but I have tested the actual code and it seems to accept the ssl certs just fine. Attachments: reviewboard-patch-issue-1072 856 bytes -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1072 in reviewboard: SVN --config-dir support
Updates: Labels: -Type-Defect Type-Enhancement Comment #2 on issue 1072 by chipx86: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
