Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Updates: Status: Fixed Comment #9 on issue 1113 by trowb...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 Fixed in master (f226c46). Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #7 on issue 1113 by jhuffa...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 I ran into this problem recently. I understand that you have an established workflow but this is a nasty bug that cost more than a few of us time. I don't know your code base, but was successfully (easily) able to port the files from above (0.2 to 0.3.4). I'm going to attach my diff from 0.3.4, if you really need me to apply it to reviews.reviewboard.org I can, but it seems like you should be able to do it more quickly. I really hope this gets incorporated into future versions as it is quite annoying. Attachments: postreview.py.diff 3.1 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #6 on issue 1113 by trowb...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 We need fixes submitted to reviews.reviewboard.org, not posted here (especially in the format that it was). The code in post-review has also diverged a lot since 0.2. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #5 on issue 1113 by underpl...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 This is an issue for us as well. Seeing as a fix has been sumbitted and it looks reasonably simple, could we please get a fix for this? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #4 on issue 1113 by rix0...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 Still not fixed in 0.3.2. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #3 on issue 1113 by bobafeth2000: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 I added a workaround for that issue on my local installation. I hope it can help anybody having the same problem until an official fix come out. Attached are two files: - postreview.org is the original one upon which the fix is based (RBTools-0.2) - postreview.py is the modified one that handles the case of deleted files. Attachments: postreview.py 104 KB postreview.org 104 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #2 on issue 1113 by trowbrds: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 Issue 1738 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1113 by mdelagra: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 *NOTE: Do not post confidential information in this bug report.* What version are you running? RBTools 0.2beta1 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. svn delete some_file 2. svn commit -m 'deleting a file' 3. post-review --revision-range=revision-1:revision What is the expected output? What do you see instead? Expected: login prompt Actual: Failed to execute command: ['svn', 'info', 'path/deleted_file'] [svn: 'path/deleted_file' is not under version control\n] What operating system are you using? What browser? OS X Please provide any additional information below. Manually posting a diff to a ReviewBoard website that includes a deleted file works fine in the latest version, but the post-review tool does not work. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
