Re: Issue 1166 in reviewboard: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
Updates: Status: WontFix Comment #11 on issue 1166 by trowb...@gmail.com: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client http://code.google.com/p/reviewboard/issues/detail?id=1166 Having investigated this a little more, there's really nothing we can do. Having mixed/partial line endings is fatal for almost any tool that needs to try to parse the file, and especially for something as complicated as review board. You'll find that everything works much, much better if you just fix the files in source control. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1166 in reviewboard: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
Comment #10 on issue 1166 by trowb...@gmail.com: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client http://code.google.com/p/reviewboard/issues/detail?id=1166 Issue 1743 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1166 in reviewboard: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
Updates: Labels: Component-RBTools Comment #9 on issue 1166 by trowbrds: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client http://code.google.com/p/reviewboard/issues/detail?id=1166 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1166 in reviewboard: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
Comment #8 on issue 1166 by lonico: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client http://code.google.com/p/reviewboard/issues/detail?id=1166 Using the following file as an example (all termination characters are CR (or \r)): Sample file. Should contain only CR (\r) as line termination. (I used scite editor to convert an examine the line termination.) $ post-review -d -n default Processing add of //depot/prod/code-quality/code-review/rbtools/sample.cronly p4 -G where //depot/prod/code-quality/code-review/rbtools/sample.cronly diff -urNp /tmp/tmpFhtK-S /u/laurentn/p4/code-review/rbtools/sample.cronly --- //depot/prod/code-quality/code-review/rbtools/sample.cronly //depot/prod/code-quality/code-review/rbtools/sample.cronly#1 +++ //depot/prod/code-quality/code-review/rbtools/sample.cronly 2010-03-10 21:39:27 @@ -0,0 +1 @@ the line termination.)o convert an examine \ No newline at end of file Note that the issue really comes from the underlying diff utility. This is with rbtools 0.2RC2 on linux, but the same issue is seen on Windows as well, the whole file is seen as a single line by diff (though I only change scite to SciTE: C:\Python25\Scripts..\diff.exe sample.cronly sample2.cronly 1c1 the line termination.)o convert an examine \ No newline at end of file --- the line termination.)o convert an examine \ No newline at end of file C:\Python25\Scripts Attachments: sample_cronly.png 5.1 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1166 in reviewboard: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
Comment #3 on issue 1166 by f...@datasynapse.com: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client http://code.google.com/p/reviewboard/issues/detail?id=1166 I couldn't figure out how to apply nightly ReviewBoard and RBTools plugins. Is there any FAQ? Thanks for the fix. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1166 in reviewboard: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
Updates: Status: NeedInfo Comment #2 on issue 1166 by chipx86: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client http://code.google.com/p/reviewboard/issues/detail?id=1166 Would you mind upgrading to the nightly of RBTools? This should be fixed. There will be a release in a few days, if you want to wait until then. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1166 in reviewboard: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
Comment #1 on issue 1166 by f...@datasynapse.com: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client http://code.google.com/p/reviewboard/issues/detail?id=1166 my xml file contains only \r in some part. it's stored in SVN. also upload the corrupted diff file, wireshark shows that it's already corrupted on the post-review side. Attachments: pom.win32-vc6.xml 960 bytes pom.win32-vc6.xml.diff 1.5 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
