Re: Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #21 on issue 1348 by mate.szalay: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Having the same problem. It was a clean install, rb-site upgrade does nothing (and odes not fix it). What version are you running? 1.5beta1 What steps will reproduce the problem? 1. open a review request with a diff (not covering all the lines of a file) 2. view the diff 3. click on the Expand link next to a Hidden lines bar inside the diff What is the expected output? What do you see instead? The hidden lines should show up. Instead, I have Loading... for a while, then nothing happens. What operating system are you using? What browser? Host: Debian Sarge, python 2.4 Client: Windows XP + Firefox 3.5, Windows 7 + Firefox 3.6, Windows 7 + Chrome, works in none of these. Please provide any additional information below. Debian Sarge, python 2.4, apache2, everything stock, clean install, 100% reproducible. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #10 on issue 1348 by premek.paska: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Unfortunately, I can't confirm the fix. The issue is still present in version 1.0.5 in our installation (tested with Chromium 4.0.222.4, Firefox 3 and 3.5; all in Linux). The link Expand behaves still the same way as in 1.0.4. It is sending wrong requests as described in comments #2 and #5 above. I don't see our configuration obscure in any way; it is the following: Response Headers DateFri, 23 Oct 2009 22:31:23 GMT Server Apache/2.2.9 (Debian) DAV/2 SVN/1.5.1 mod_jk/1.2.26 PHP/5.2.6-1+lenny3 with Suhosin-Patch mod_python/3.3.1 Python/2.5.2 mod_ssl/2.2.9 OpenSSL/0.9.8g mod_perl/2.0.4 Perl/v5.10.0 Content-Length 232 Content-Languageen-us Content-Encodinggzip VaryCookie,Accept-Language,Accept-Encoding Content-Typetext/html; charset=utf-8 Keep-Alive timeout=15, max=100 Connection Keep-Alive Request Headers Host... User-Agent Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 Accept text/html, */* Accept-Language en,en-us;q=0.8,fr;q=0.5,fr-fr;q=0.3 Accept-Encoding gzip,deflate Accept-Charset UTF-8,* Keep-Alive 300 Connection keep-alive X-Requested-WithXMLHttpRequest Referer https://.../rb/r/171/diff/ Cookie rbsessionid=ae1bc5f72f8e0af9e9f8de5d857676be; ... -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #12 on issue 1348 by premek.paska: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Yes, I restarted both apache and memcached (and tried also disabling memcached), reloaded the page multiple times, cleared the browser cache and tested it also in Chromium's incognito mode.. ..just to be sure. And I think there is not a problem with any cache, because it works immediately after downgrading to 1.0.1. What about checking changes in the diff viewer between 1.0.1 and 1.0.3? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Updates: Status: Confirmed Owner: chipx86 Comment #8 on issue 1348 by chipx86: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #5 on issue 1348 by premek.paska: Expanding hidden lines broken by
the 1.0.3 update
http://code.google.com/p/reviewboard/issues/detail?id=1348
There are no JS errors reported by Firebug.
The strange thing is that all Expand links within one file use the same
HTTP request:
javascript:expandChunk('file1', '1147', '1', null, '12', this); return
false;
.../rb/r/139/diff/1/fragment/1147/chunk/1/
javascript:expandChunk('file1', '1147', '1', null, '19', this); return
false;
.../rb/r/139/diff/1/fragment/1147/chunk/1/
The next file:
.../rb/r/139/diff/1/fragment/1148/chunk/1/
.../rb/r/139/diff/1/fragment/1148/chunk/1/
.../rb/r/139/diff/1/fragment/1148/chunk/1/
etc.
And consequently, all responses for different links within the file are the
same:
One of them starts with this html code:
tbody id=chunk0.1
tr line=26
th26/th
tdprespan class=p{/span/pre/td
th26/th
tdprespan class=p{/span/pre/td
/tr
tr line=27
th27/th
...
I compared the responses and realized that they always return the first
five lines of
the file that are already displayed (first lines of the file's diff). So
never the
correct lines.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #6 on issue 1348 by chipx86: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Sounds like this would be the cause, though it's still not happening here. I'll try to repro it some more. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Updates: Status: NeedInfo Comment #1 on issue 1348 by chipx86: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 This was certainly broken in 1.0.3, but it should definitely be fixed in 1.0.4. I can't reproduce this at all. Can you make sure to clear your server-side cache? And can you make sure the web server was restarted since the upgrade to 1.0.4? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #3 on issue 1348 by premek.paska: Expanding hidden lines broken by
the 1.0.3 update
http://code.google.com/p/reviewboard/issues/detail?id=1348
I'll add some more info, just for clarity. When I tested 1.0.4 for the
first time, I
restarted our Apache server for sure. Since yesterday we had used 1.0.1
(where the
expanding works) and now we tried 1.0.4 again. Expanding doesn't work in
FF3.5,
Chrome, nor Opera 10 (after cleaning all caches).
My colleague provided some more specific info above.
I've noticed a suspicious null argument in the call, is ti ok?
a onclick=javascript:expandChunk('file5', '1151', '1', null, '4', this);
return
false; href=#Expand/a
Is there anything other we should try to investigate the problem?
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #4 on issue 1348 by chipx86: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Yep, that null should be there. That would be the interdiff ID for interdiffs, or null for normal diffs. Can you install Firebug and click the Expand link? See if there's any JavaScript error output, and see what the HTTP response is from the action (if there is one). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
