Re: Issue 1735 in reviewboard: Perforce clients not adding the charset
Comment #5 on issue 1735 by steven...@gmail.com: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 Hi, I got this error in version 1.6.4.1. According to workaround, I modified perforce.py which is under ~/reviewboard/scmtools folder. Then the system show below info: Please correct the error below. global name 'repository' is not defined Modified content: import P4 self.p4 = P4.P4() self.p4.port = str(repository.mirror_path or repository.path) self.p4.user = str(repository.username) self.p4.password = str(repository.password) if (str(repository.encoding)): self.p4.charset = str(repository.encoding) self.p4.exception_level = 1 cmdline = ['p4', '-p', self.p4.port] if self.p4.user: cmdline.extend(['-u', self.p4.user]) if self.p4.password: cmdline.extend(['-P', self.p4.password]) if self.p4.charset: cmdline.extend(['-C', self.p4.charset]) cmdline.extend(['print', '-q', file]) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1735 in reviewboard: Perforce clients not adding the charset
Comment #6 on issue 1735 by steven...@gmail.com: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 Does anyone can tell me how to define repository as global name ? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1735 in reviewboard: Perforce clients not adding the charset
Comment #7 on issue 1735 by carodo...@gmail.com: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 The only lines I added on the top portion were: if (str(repository.encoding)): self.p4.charset = str(repository.encoding) so, you should look at the other lines to see how they were accessing the repository configuration on your version. You should not define repository as a global name yourself. You have to use whatever is being used already. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1735 in reviewboard: Perforce clients not adding the charset
Updates: Status: Fixed Comment #4 on issue 1735 by trowb...@gmail.com: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 Fixed in master (5ed25c2). Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1735 in reviewboard: Perforce clients not adding the charset
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #3 on issue 1735 by trowb...@gmail.com: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1735 in reviewboard: Perforce clients not adding the charset
Updates: Labels: Component-SCMTools Comment #2 on issue 1735 by trowb...@gmail.com: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1735 in reviewboard: Perforce clients not adding the charset
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1735 by carodolan: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 *NOTE: Do not post confidential information in this bug report.* What version are you running? Applies both to 1.0 and 1.5RC1 What's the URL of the page containing the problem? It's an issue on the reviewboard/scmtools/perforce.py file What steps will reproduce the problem? 1. Add a perforce repository whose server is unicode 2. try to upload a review 3. The log will say: Unicode servers permits only unicode enabled clients What is the expected output? What do you see instead? You should be able to post reviews, you get an error message. What operating system are you using? What browser? Doesn't apply. Please provide any additional information below. One could solve it by adding the environment variable P4CHARSET, but if you want to use different repositories, some unicode, some not, that won't work. I have fixed it temporarily by adding on perforce.py: import P4 self.p4 = P4.P4() self.p4.port = str(repository.mirror_path or repository.path) self.p4.user = str(repository.username) self.p4.password = str(repository.password) if (str(repository.encoding)): self.p4.charset = str(repository.encoding) self.p4.exception_level = 1 And cmdline = ['p4', '-p', self.p4.port] if self.p4.user: cmdline.extend(['-u', self.p4.user]) if self.p4.password: cmdline.extend(['-P', self.p4.password]) if self.p4.charset: cmdline.extend(['-C', self.p4.charset]) cmdline.extend(['print', '-q', file]) But that's just a temporary fix, since I don't know the real meaning of the encoding attribute. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1735 in reviewboard: Perforce clients not adding the charset
Comment #1 on issue 1735 by trowbrds: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 Issue 1736 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
