Re: Issue 1874 in reviewboard: post-review does not properly parse diffs between commits in a branch on a git-svn repository
Updates: Status: Fixed Comment #8 on issue 1874 by trowb...@gmail.com: post-review does not properly parse diffs between commits in a branch on a git-svn repository http://code.google.com/p/reviewboard/issues/detail?id=1874 Fixed in rbtools master (dc0b739). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1874 in reviewboard: post-review does not properly parse diffs between commits in a branch on a git-svn repository
Comment #7 on issue 1874 by fr...@thefoundry.co.uk: post-review does not properly parse diffs between commits in a branch on a git-svn repository http://code.google.com/p/reviewboard/issues/detail?id=1874 kognate's patch fixes my issues (exactly as described by Jordan) when trying to commit each atomic commit on a branch to reviewboard in git-svn land. applied over a8f4db54db3fe1058423c7280c5b825016edeeff (after tag release-0.5) Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1874 in reviewboard: post-review does not properly parse diffs between commits in a branch on a git-svn repository
Updates: Status: New Comment #4 on issue 1874 by trowbrds: post-review does not properly parse diffs between commits in a branch on a git-svn repository http://code.google.com/p/reviewboard/issues/detail?id=1874 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1874 in reviewboard: post-review does not properly parse diffs between commits in a branch on a git-svn repository
Updates: Status: NeedInfo Labels: Component-RBTools Comment #1 on issue 1874 by trowbrds: post-review does not properly parse diffs between commits in a branch on a git-svn repository http://code.google.com/p/reviewboard/issues/detail?id=1874 Can you run with --debug and give us the output? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1874 in reviewboard: post-review does not properly parse diffs between commits in a branch on a git-svn repository
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1874 by jormon: post-review does not properly parse diffs between commits in a branch on a git-svn repository http://code.google.com/p/reviewboard/issues/detail?id=1874 *NOTE: Do not post confidential information in this bug report.* What version are you running? RBTools 0.2 What's the URL of the page containing the problem? n/a What steps will reproduce the problem? on a git-svn repository, do the following 1. git checkout -b new_feature git-svn 2. touch foo.txt 3. git add foo.txt 4. git commit -a -m change 1 5. echo hi foo.txt 6. git commit -a -m change 2 7. post-review -n --parent=HEAD^ What is the expected output? What do you see instead? Expected is the same as git diff --full-index HEAD^ diff --git a/foo.txt b/foo.txt index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..45b983be36b73c0788dc9cbcb76cbb80 --- a/foo.txt +++ b/foo.txt @@ -0,0 +1 @@ +hi Instead, this happens: post-review -n --parent=HEAD^ None What operating system are you using? What browser? OS: Ubuntu 10.04 Desktop / Linux 2.6.32-25-generic Browser: n/a -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
