Re: Issue 2043 in reviewboard: Using reviewboard without a repository - only upload a diff file
Comment #8 on issue 2043 by ranford@gmail.com: Using reviewboard without a repository - only upload a diff file https://code.google.com/p/reviewboard/issues/detail?id=2043 Reviewing attached text files is insufficient because you do not get the ability to comment on specific lines of the text file. I think this would be a great feature for content that does not belong to any scm system at all. The content would not be evolving over time, yet you want an initial review prior to going live. The use case I have right now is a blog post. I'd like to develop the post, and then perhaps send it around to a few people for review, and then once we are good post it. It doesn't really make sense to me to put this into source control because once we post it we have the record and it is for the most part unchanging over time. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2043 in reviewboard: Using reviewboard without a repository - only upload a diff file
Comment #9 on issue 2043 by trowb...@gmail.com: Using reviewboard without a repository - only upload a diff file https://code.google.com/p/reviewboard/issues/detail?id=2043 As of 2.0.x, you do have the ability to comment on specific lines of the text file. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2043 in reviewboard: Using reviewboard without a repository - only upload a diff file
Updates: Labels: Component-DiffViewer Comment #6 on issue 2043 by trowb...@gmail.com: Using reviewboard without a repository - only upload a diff file http://code.google.com/p/reviewboard/issues/detail?id=2043 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2043 in reviewboard: Using reviewboard without a repository - only upload a diff file
Comment #5 on issue 2043 by trowb...@gmail.com: Using reviewboard without a repository - only upload a diff file http://code.google.com/p/reviewboard/issues/detail?id=2043 Issue 2799 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2043 in reviewboard: Using reviewboard without a repository - only upload a diff file
Comment #4 on issue 2043 by trowb...@gmail.com: Using reviewboard without a repository - only upload a diff file http://code.google.com/p/reviewboard/issues/detail?id=2043 Showing diffs without a backing repository is not a high priority for us. In theory, using the parent diff could solve the problem, but it happened a few times when the changes and merges made it too complicated for some of the end users to generate the parent patch. Improving DVCS support in post-review is really the best way to solve this. Since there are simultaneous check ins by other developers, the diff I had taken, may not be in sync with the trunk because of intermediate check ins by other members. The diffs posted to reviewboard include revision information, so the fact that other people have committed code doesn't matter. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2043 in reviewboard: Using reviewboard without a repository - only upload a diff file
Comment #1 on issue 2043 by vijaira...@gmail.com: Using reviewboard without a repository - only upload a diff file http://code.google.com/p/reviewboard/issues/detail?id=2043 I guess this feature will be great when using SCM not supported by Review Board. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2043 in reviewboard: Using reviewboard without a repository - only upload a diff file
Comment #2 on issue 2043 by huhu...@gmail.com: Using reviewboard without a repository - only upload a diff file http://code.google.com/p/reviewboard/issues/detail?id=2043 vote +1. Considering we only need to review the diff and don't care which repository it belongs to. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2043 in reviewboard: Using reviewboard without a repository - only upload a diff file
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2043 by nicolas@gmail.com: Using reviewboard without a repository - only upload a diff file http://code.google.com/p/reviewboard/issues/detail?id=2043 What version are you running? 1.5.2 What's the URL of the page this enhancement relates to, if any? Describe the enhancement and the motivation for it. We currently use mercurial and SVN (legacy) as our reposirories. Most of the time, this works 100%. There are some cases with mercurial when we would like to review a patch (diff) but the parents are not on the server. In theory, using the parent diff could solve the problem, but it happened a few times when the changes and merges made it too complicated for some of the end users to generate the parent patch. Therefore, in those case, even if we lose a few features (like the code expansion over the 3 lines given in the diff), we would like to be able to create a review with only the patch file, and no link to the repository behind. What operating system are you using? What browser? Windows, Chrome (and others, depending on our users). Please provide any additional information below. We are open to alternative solutions, among others, if we could serve our local repo for a few moments, while the review is being created, this would help go around the problem. Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
