Re: Issue 2044 in reviewboard: Add support in post-review for perforce shelved changelist
Updates: Status: Fixed Comment #3 on issue 2044 by trowb...@gmail.com: Add support in post-review for perforce shelved changelist http://code.google.com/p/reviewboard/issues/detail?id=2044 This is now implemented in rbtools master (2c6abfc). If a changeset has shelved changes and there are no opened files in the client for that changeset, the shelved changes will be used instead. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2044 in reviewboard: Add support in post-review for perforce shelved changelist
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #2 on issue 2044 by trowb...@gmail.com: Add support in post-review for perforce shelved changelist http://code.google.com/p/reviewboard/issues/detail?id=2044 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2044 in reviewboard: Add support in post-review for perforce shelved changelist
Updates: Labels: Component-RBTools Comment #1 on issue 2044 by trowb...@gmail.com: Add support in post-review for perforce shelved changelist http://code.google.com/p/reviewboard/issues/detail?id=2044 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2044 in reviewboard: Add support in post-review for perforce shelved changelist
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2044 by cyril.bo...@koinzmedia.com: Add support in post-review for perforce shelved changelist http://code.google.com/p/reviewboard/issues/detail?id=2044 Perforce has a new feature to shelve open changelists on the server side for review. See http://www.perforce.com/perforce/doc.current/manuals/cmdref/shelve.html Unfortunately, RB v1.5.4 post-review does not seem able to pull diffs from such changelists until they're committed. It'd be really useful if RB added support to diff shelved files in pending changelists, so reviews could be performed before the code is checked-in the shared repository. Files that have been shelved can be accessed with the p4 diff, p4 diff2, p4 files, and p4 print commands, using the revision specifier @=change, where change is the pending changelist number, so this may be a fairly small enhancement? Thank you for the great work on this project! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
