Re: Issue 2407 in reviewboard: Diff view issue when loading existing file diffs from mercurial

2012-02-07 Thread reviewboard

Updates:
Status: Incomplete

Comment #3 on issue 2407 by trowb...@gmail.com: Diff view issue when  
loading existing file diffs from mercurial

http://code.google.com/p/reviewboard/issues/detail?id=2407

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2407 in reviewboard: Diff view issue when loading existing file diffs from mercurial

2012-01-06 Thread reviewboard

Updates:
Status: NeedInfo

Comment #2 on issue 2407 by trowb...@gmail.com: Diff view issue when  
loading existing file diffs from mercurial

http://code.google.com/p/reviewboard/issues/detail?id=2407

Do you know what was being returned from the bitbucket server? Maybe the  
contents of the file that it was trying to patch?


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2407 in reviewboard: Diff view issue when loading existing file diffs from mercurial

2011-12-05 Thread reviewboard


Comment #1 on issue 2407 by venterpi...@gmail.com: Diff view issue when  
loading existing file diffs from mercurial

http://code.google.com/p/reviewboard/issues/detail?id=2407

This was a issue with a slow connection to bit-bucket that caused this  
issue, might want to investigate friendly error messages, if connection fail


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2407 in reviewboard: Diff view issue when loading existing file diffs from mercurial

2011-12-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2407 by venterpi...@gmail.com: Diff view issue when loading  
existing file diffs from mercurial

http://code.google.com/p/reviewboard/issues/detail?id=2407

This issue only seems to happen with files that is not new to the  
repository.


New files seem to work fine.

I generated this diff with programs:
mecurial post-review extension
and mecurial diff
i'm having issues with the normal post-review and mecurial but i did log  
the issue in another ticket


The error log when clicking view diff:

The patch to '{my app}/models.py' didn't apply cleanly. The temporary files  
have been left in '/tmp/reviewboard.gugJOg' for debugging purposes. `patch`  
returned: patching file /tmp/reviewboard.gugJOg/tmp2SOZMr Hunk #1 FAILED at  
2. 1 out of 1 hunk FAILED -- saving rejects to file  
/tmp/reviewboard.gugJOg/tmp2SOZMr-new.rej


Traceback (most recent call last):
   
File "/home/reviewboard/reviewboard-env/lib/python2.6/site-packages/reviewboard/diffviewer/views.py",  
line 151, in view_diff

interdiffset, highlighting, True)
   
File "/home/reviewboard/reviewboard-env/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",  
line 1071, in get_diff_files

large_data=True)
   
File "/home/reviewboard/reviewboard-env/lib/python2.6/site-packages/djblets/util/misc.py",  
line 156, in cache_memoize

data = lookup_callable()
   
File "/home/reviewboard/reviewboard-env/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",  
line 1070, in 

enable_syntax_highlighting)),
   
File "/home/reviewboard/reviewboard-env/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",  
line 552, in get_chunks

new = get_patched_file(old, filediff)
   
File "/home/reviewboard/reviewboard-env/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",  
line 374, in get_patched_file

return patch(filediff.diff, buffer, filediff.dest_file)
   
File "/home/reviewboard/reviewboard-env/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",  
line 242, in patch

(filename, tempdir, patch_output))
Exception: The patch to '{my app}/models.py' didn't apply cleanly. The  
temporary files have been left in '/tmp/reviewboard.gugJOg' for debugging  
purposes.

`patch` returned: patching file /tmp/reviewboard.gugJOg/tmp2SOZMr
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file  
/tmp/reviewboard.gugJOg/tmp2SOZMr-new.re


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.