Issue 2456 in reviewboard: RB API doesn't allow updating changenum field for Git

2012-01-19 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2456 by eyuw...@gmail.com: RB API doesn't allow updating  
changenum field for Git

http://code.google.com/p/reviewboard/issues/detail?id=2456

*NOTE: If you have a patch, please submit it to
http://reviews.reviewboard.org/


What version are you running?
1.6.1

What's the URL of the page this enhancement relates to, if any?
https://myserver/r/{review_id}

Describe the enhancement and the motivation for it.
I'm using API 2.0 to write a script to update the changenum field of a  
review. The URL is api/review-requests/{review_id}/draft/. It seems only a  
few fields (such as description, summary, etc) can be updated via HTTP.



What operating system are you using? What browser?
Centos 6

Please provide any additional information below.
I'd like to add the commit SHA1 string associated with the review to  
the 'Change Number' field so that I can keep track of the commit later on.  
Because I'm not able to use API to PUT the changenum field, I had to put  
that info in the description field guarded by a special string as a  
workaround. I'd love to see API is updated to support updating that field.



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2456 in reviewboard: RB API doesn't allow updating changenum field for Git

2012-01-19 Thread reviewboard

Updates:
Status: NotABug

Comment #1 on issue 2456 by chip...@gmail.com: RB API doesn't allow  
updating changenum field for Git

http://code.google.com/p/reviewboard/issues/detail?id=2456

The changenum field is only for Perforce. It represents server-side  
changeset numbers, which is different than a revision.


Best to put this as part of a close message when submitting.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2456 in reviewboard: RB API doesn't allow updating changenum field for Git

2012-01-19 Thread reviewboard


Comment #2 on issue 2456 by eyuw...@gmail.com: RB API doesn't allow  
updating changenum field for Git

http://code.google.com/p/reviewboard/issues/detail?id=2456

Thanks for your quick response! Yes, I understand RB currently only  
supports change number if the backend SCM supports such concept natively.  
But wouldn't it be nice if the web service API provides the ability to  
update the field? Right now that field always shows 'None' if the  
underlying SCM is not Perforce. As an administrator/developer/user, I'd  
like to be able to overload that field to do meaningful task, such as use  
it to store the commit SHA1 string associated with the change, rather than  
be wasted? From there, I can do a lot more work build on top of it...


Would you consider providing such functionality in the API? I mean people  
who use the API probably know what they are doing, isn't it?


Thanks!

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.