Re: Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool
Updates: Status: Fixed Comment #4 on issue 2465 by trowb...@gmail.com: For non owned review - fix error message in Review Board post-review tool http://code.google.com/p/reviewboard/issues/detail?id=2465 Thanks! Fixed in master (7570943). -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool
Comment #3 on issue 2465 by sudhir.s...@gmail.com: For non owned review - fix error message in Review Board post-review tool http://code.google.com/p/reviewboard/issues/detail?id=2465 Hi David post-review -r ID (where ID is not owned). FYI, we use subversion and I don't feel this issue is related to SCM. Regards Sudhir -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool
Updates: Status: NeedInfo Comment #2 on issue 2465 by trowb...@gmail.com: For non owned review - fix error message in Review Board post-review tool http://code.google.com/p/reviewboard/issues/detail?id=2465 How are you invoking post-review? Is this with perforce? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool
Comment #1 on issue 2465 by sudhir.s...@gmail.com: For non owned review -
fix error message in Review Board post-review tool
http://code.google.com/p/reviewboard/issues/detail?id=2465
Better diagnostic for non owned review update is as below:
if not server.info.supports_changesets or not options.change_only:
try:
server.upload_diff(review_request, diff_content,
parent_diff_content)
except APIError, e:
sys.stderr.write('\n')
sys.stderr.write('Error uploading diff\n')
sys.stderr.write('\n')
if e.error_code == 101 and e.http_status == 403:
sys.stderr.write('Error: You are not the owner of this
ReviewBoard review.\n')
sys.stderr.write('\n')
die()
if e.error_code == 105:
sys.stderr.write('The generated diff file was empty. This '
'usually means no files were\n')
sys.stderr.write('modified in this change.\n')
sys.stderr.write('\n')
sys.stderr.write('Try running with --output-diff and
--debug '
'for more information.\n')
sys.stderr.write('\n')
die("Your review request still exists, but the diff is not " +
"attached.")
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2465 by sudhir.s...@gmail.com: For non owned review - fix error message in Review Board post-review tool http://code.google.com/p/reviewboard/issues/detail?id=2465 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? RBTools 0.3.4 What's the URL of the page containing the problem? NO URL - post-review tool What steps will reproduce the problem? 1. post-review to an existing NON owned review. 2. 3. What is the expected output? What do you see instead? "you don't own the RB". I see below output instead "Error uploading diff. Your review request still exists, but the diff is not attached." What operating system are you using? What browser? RHEL 5.0 Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
