Issue 2477 in reviewboard: Review comments and "Ship It!" state are lost in some circumstances

2012-02-03 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2477 by phil.hin...@gmail.com: Review comments and "Ship It!"  
state are lost in some circumstances

http://code.google.com/p/reviewboard/issues/detail?id=2477

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.5.5

What's the URL of the page containing the problem?
http:///r//diff/#index_header

What steps will reproduce the problem?
It seems to require a review that has multiple revisions published.  There  
are several ways to reproduce the problem, but the pertinent step seems to  
be #2


1. Click the "Review" graphic, type in some review text (or just  
click "Ship It!") then click "Save"
2. Choose a different revision of the code under review (either "Jump to  
revision" or "Changes between rX and"

3. Click "Publish" in the green bar at the top of the page.

Following these steps, the published review will not contain the review  
text or the "Ship It!" state.  Any inline comments that had been entered  
from the Diff page seem to be preserved.


What is the expected output? What do you see instead?

I expect to see the review comments and "Ship It!" state in the published  
review comments.  I get the expected output if I replace Step 3 with:

3. Click "Edit Review" in the green bar at the top of the page.
4. Click "Publish Review"

What operating system are you using? What browser?
Windows 7 64-bit, Chrome 16.0.912.75 m

Please provide any additional information below.

This sounds similar to Issue #2018, but it is hard to tell based on that  
description.  Hopefully these steps to reproduce will help.



--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2477 in reviewboard: Review comments and "Ship It!" state are lost in some circumstances

2012-12-23 Thread reviewboard

Updates:
Labels: Component-Reviews

Comment #1 on issue 2477 by trowb...@gmail.com: Review comments and "Ship  
It!" state are lost in some circumstances

http://code.google.com/p/reviewboard/issues/detail?id=2477

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2477 in reviewboard: Review comments and "Ship It!" state are lost in some circumstances

2014-01-03 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 2477 by trowb...@gmail.com: Review comments and "Ship  
It!" state are lost in some circumstances

http://code.google.com/p/reviewboard/issues/detail?id=2477

I hadn't noticed the version in this report. 1.5.5 is very, very old.  
Please try again with the latest 1.7.x release and re-report it if it's  
still an issue.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.