Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword
Comment #5 on issue 2878 by sudhir.s...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 Agreed. Thanks for looking into this. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword
Updates: Status: SetupIssue Comment #6 on issue 2878 by trowb...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword
Comment #3 on issue 2878 by chip...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 The code for handling keywords in diffs is the same between 1.6.13 and 1.7.x, and none of our unit tests have broken. I also reproed your exact case, except with the propset entry being Id and not id. Perhaps that makes a difference. But otherwise, it does work as expected as far as I can tell. Can you try with Id just to see? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword
Comment #4 on issue 2878 by chip...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 According to the SVN documentation, svn:keywords is intended now to be case-sensitive, though for now, some (Id being one) is treated as case-insensitive, but that may not be the case in the future. That means in your setup, id is not technically valid, even though svn works with it. It needs to be Id. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword
Updates: Status: NeedInfo Comment #1 on issue 2878 by chip...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 Hi Sudhir, We have unit tests that should cover this exact case, and I tried your example and it works. We can only expand keywords if you have those keywords set to expand by listing them in svn:keywords. In your case, is that actually listed? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword
Comment #2 on issue 2878 by sudhir.s...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 Hi Christian, I think below is what you are asking. Yes it is listed. $ svn propget svn:keywords hello_world.c id FYI, I don't see below code change in RB 1.7.1/1.7.2 . I think this change was in RB Beta release. http://reviews.reviewboard.org/r/2441/ Regards Sudhir -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
