Re: Issue 3352 in reviewboard: The publish change dialog doesn't show up when a field is edited

2014-06-05 Thread reviewboard

Updates:
Status: Fixed

Comment #6 on issue 3352 by chip...@gmail.com: The publish change dialog  
doesn't show up when a field is edited

http://code.google.com/p/reviewboard/issues/detail?id=3352

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3352 in reviewboard: The publish change dialog doesn't show up when a field is edited

2014-05-20 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3352 by pvals...@gmail.com: The publish change dialog doesn't  
show up when a field is edited

http://code.google.com/p/reviewboard/issues/detail?id=3352

What version are you running?
2.0

What's the URL of the page containing the problem?
/r/304

What steps will reproduce the problem?
1. Open an existing review
2. Edit the description (for example)
3. Click the OK button bellow the description

What is the expected output? What do you see instead?
The This review request is a draft dialog should show up at the top of  
the page but it doesn't.
For it to show up, you have to go to another page like View diff for  
example.


What operating system are you using? What browser?
Linux Ubuntu 14.04 with Chrome 34.0.1847.137

Please provide any additional information below.
That was working fine with 1.7.24

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3352 in reviewboard: The publish change dialog doesn't show up when a field is edited

2014-05-20 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3352 by trowb...@gmail.com: The publish change dialog  
doesn't show up when a field is edited

http://code.google.com/p/reviewboard/issues/detail?id=3352

Can you clear your browser cache and try again?

If that still fails, can you check the browser console (Tools  JavaScript  
Console) and see if there are any errors when you change a field?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3352 in reviewboard: The publish change dialog doesn't show up when a field is edited

2014-05-20 Thread reviewboard


Comment #2 on issue 3352 by christop...@delphix.com: The publish change  
dialog doesn't show up when a field is edited

http://code.google.com/p/reviewboard/issues/detail?id=3352

I see this issue as well in Firefox 29.0.1 on Linux and IE11 on Windows.  
Clearing my browser cache does not help. Any time I update a field on a  
review request I get an error similar to the following in my javascript  
console (this error is from chrome):


GET http://ip  
removed/api/review-requests/16265/draft/?api_format=jsonexpand=depends_on%2Ctarget_people%2Ctarget_groups  
404 (NOT FOUND)

jquery-1.8.2.min.cfa9051cc0b0.js:2
send jquery-1.8.2.min.cfa9051cc0b0.js:2
p.extend.ajax jquery-1.8.2.min.cfa9051cc0b0.js:2
doCall base.min.221a1f3c7761.js:1
RB.apiCall base.min.221a1f3c7761.js:1
Backbone.ajax base.min.221a1f3c7761.js:1
a.sync 3rdparty.min.787bbc6b4fd2.js:4
RB.BaseResource.Backbone.Model.extend.sync base.min.221a1f3c7761.js:1
h.extend.fetch 3rdparty.min.787bbc6b4fd2.js:3
RB.DraftResourceModelMixin._retrieveDraft base.min.221a1f3c7761.js:1
sup.ready.call._.defaults.ready base.min.221a1f3c7761.js:1
RB.BaseResource.Backbone.Model.extend.ready base.min.221a1f3c7761.js:1
RB.BaseResource.Backbone.Model.extend.ready base.min.221a1f3c7761.js:1
RB.DraftResourceModelMixin.ready base.min.221a1f3c7761.js:1
RB.BaseResource.Backbone.Model.extend.save base.min.221a1f3c7761.js:1
RB.ReviewRequestEditor.Backbone.Model.extend.setDraftField  
reviews.min.2f31eb11f43f.js:1

(anonymous function) reviews.min.2f31eb11f43f.js:4
p.event.dispatch jquery-1.8.2.min.cfa9051cc0b0.js:2
g.handle.h jquery-1.8.2.min.cfa9051cc0b0.js:2
p.event.trigger jquery-1.8.2.min.cfa9051cc0b0.js:2
p.fn.extend.triggerHandler jquery-1.8.2.min.cfa9051cc0b0.js:2
$.widget.save jquery.gravy.min.1dec384a75c9.js:1
$.widget.submit jquery.gravy.min.1dec384a75c9.js:1
(anonymous function) jquery.gravy.min.1dec384a75c9.js:1
p.event.dispatch jquery-1.8.2.min.cfa9051cc0b0.js:2
g.handle.h jquery-1.8.2.min.cfa9051cc0b0.js:2

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3352 in reviewboard: The publish change dialog doesn't show up when a field is edited

2014-05-20 Thread reviewboard

Updates:
Status: Confirmed
Owner: chip...@gmail.com
Labels: Milestone-Release2.0

Comment #3 on issue 3352 by chip...@gmail.com: The publish change dialog  
doesn't show up when a field is edited

http://code.google.com/p/reviewboard/issues/detail?id=3352

I can reproduce this. Looking into it.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3352 in reviewboard: The publish change dialog doesn't show up when a field is edited

2014-05-20 Thread reviewboard

Updates:
Status: PendingReview

Comment #5 on issue 3352 by chip...@gmail.com: The publish change dialog  
doesn't show up when a field is edited

http://code.google.com/p/reviewboard/issues/detail?id=3352

Fix pending at https://reviews.reviewboard.org/r/5848/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.