Re: Issue 3949 in reviewboard: Diffs: Distinguish between light yellow "nothing changed/whitespace changes" and light yellow "completely different lines"
Comment #1 on issue 3949 by alextfish: Diffs: Distinguish between light yellow "nothing changed/whitespace changes" and light yellow "completely different lines" https://code.google.com/p/reviewboard/issues/detail?id=3949 Second attachment (my mocked-up example of how this might look) is attached here. Attachments: rb_yellows_mine.png 20.8 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3949 in reviewboard: Diffs: Distinguish between light yellow "nothing changed/whitespace changes" and light yellow "completely different lines"
Comment #2 on issue 3949 by alextfish: Diffs: Distinguish between light yellow "nothing changed/whitespace changes" and light yellow "completely different lines" https://code.google.com/p/reviewboard/issues/detail?id=3949 Second screenshot (my mocked-up example of what this might look like) is attached here. Attachments: rb_yellows_mine.png 20.6 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3949 in reviewboard: Diffs: Distinguish between light yellow "nothing changed/whitespace changes" and light yellow "completely different lines"
Comment #3 on issue 3949 by alextfish: Diffs: Distinguish between light yellow "nothing changed/whitespace changes" and light yellow "completely different lines" https://code.google.com/p/reviewboard/issues/detail?id=3949 Second screenshot (my mocked-up example of what this might look like) is attached here. Attachments: rb_yellows_mine.png 20.1 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3949 in reviewboard: Diffs: Distinguish between light yellow "nothing changed/whitespace changes" and light yellow "completely different lines"
Comment #4 on issue 3949 by alextfish: Diffs: Distinguish between light yellow "nothing changed/whitespace changes" and light yellow "completely different lines" https://code.google.com/p/reviewboard/issues/detail?id=3949 Another example of the current confusing behaviour to demonstrate my point further. If I'm trying to follow the code flow on the right, reading the new code, I can see that although some of the lines are in light yellow, the only changes are adding the string 'NotSupported' to the contents of a string and a variable name. I therefore know that the basic functional flow of the code is unchanged. However, then I get to lines 245-246, which are also in light yellow, but this does *NOT* indicate the basic functional flow is unchanged; in fact it indicates the code is *completely different*. Once again, it's not clear for any given line whether light yellow means "unchanged text" or "very changed text". Attachments: rb_yellows_2.png 50.8 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
