Re: Review Board Ticket #4553: REST API fails when updating an existing default reviewers rule with >1 group/user/repository to 0 group/user/repository.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4553/ -- New update by kkelly For Beanbag, Inc. > Review Board > Ticket #4553 Reply: Fixed in release-2.5.x (50e0fa4) Status: - PendingReview + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4553: REST API fails when updating an existing default reviewers rule with >1 group/user/repository to 0 group/user/repository.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4553/ -- New update by kkelly For Beanbag, Inc. > Review Board > Ticket #4553 Reply: A fix for this issue is up for review at https://reviews.reviewboard.org/r/8952/. Status: - Confirmed + PendingReview -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4553: REST API fails when updating an existing default reviewers rule with >1 group/user/repository to 0 group/user/repository.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4553/ -- New update by kkelly For Beanbag, Inc. > Review Board > Ticket #4553 Assigned to: + brennie -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4553: REST API fails when updating an existing default reviewers rule with >1 group/user/repository to 0 group/user/repository.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4553/ -- New update by kkelly For Beanbag, Inc. > Review Board > Ticket #4553 Status: - New + Confirmed Milestones: + Release-2.5.x Tags: + Component:API -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Review Board Ticket #4553: REST API fails when updating an existing default reviewers rule with >1 group/user/repository to 0 group/user/repository.
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4553/
--
New ticket #4553 by kkelly
For Beanbag, Inc. > Review Board
Status: New
Tags: Priority:Medium, Type:Defect
--
REST API fails when updating an existing default reviewers rule with >1
group/user/repository to 0 group/user/repository.
==
# What version are you running?
2.5.7
# What's the URL of the page containing the problem?
PUT on http://reviewboard.example/api/default-reviewers/$ID/ with data:
```
{
users: '',
groups: '',
repositories: '',
}
```
# What steps will reproduce the problem?
1. Create a default-reviewer rule with >1 user OR group OR repository
2. PUT to default-reviewer resource web api to set field to have no entries
# What is the expected output? What do you see instead?
I expect the PUT to update the default reviewer rule to have no users, groups,
or repositories.
# What operating system are you using? What browser?
Server on ubuntu 14.04. Web browser Chrome 59 + macOS
# Please provide any additional information below.
The issue appears to be the `.split(',')` calls on these fields here:
https://github.com/reviewboard/reviewboard/blob/master/reviewboard/webapi/resources/default_reviewer.py#L258
That will return `['']`, which will then be used for model lookup and fail.
--
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
