date:20160330

Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService

2016-03-30 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126277
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 (line 123)


Rename to oozie_create_hive_tez_configs instead?


- Jayush Luniya


On March 31, 2016, 2:50 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> ---
> 
> (Updated March 31, 2016, 2:50 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Oozie Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  54fbb8e 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  ac2dbd9 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 4cbf2d7 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  90851c8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  3b01802 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  4fc50d2 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e9da71b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  2db3672 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  ce44d5c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
>  a08ae3a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  974ddd7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  1c80663 
> 
> Diff: https://reviews.apache.org/r/45522/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] 
> 
> [root@localhost ambari]#
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService

2016-03-30 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
---




ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
 


Let me check if this restriction for 2.2.1.0 is Oozie specific.



ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 (line 130)


Lets just use stack_name.upper() to set this for now and remove the HDP 
hardcoding.



ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
(line 194)


This path isnt valid. For Oozie the directory is /usr/share/HDP-oozie. Lets 
not set this to /usr/share/HDP as it does not exist. 

Also I dont think we should add a stack_share_dir in this case until we 
have a constructive plan on how the stack_shared_dir will be used.

Using for just /usr/share/HDP-oozie doesnt look correct.


- Jayush Luniya


On March 31, 2016, 2:50 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> ---
> 
> (Updated March 31, 2016, 2:50 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Oozie Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  54fbb8e 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  ac2dbd9 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 4cbf2d7 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  90851c8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  3b01802 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  4fc50d2 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e9da71b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  2db3672 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  ce44d5c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
>  a08ae3a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  974ddd7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  1c80663 
> 
> Diff: https://reviews.apache.org/r/45522/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] 
> 
> [root@localhost ambari]#
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45516: AMBARI-15639. Expose MariaDB option for Hive, Oozie and Ranger

2016-03-30 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45516/#review126272
---


Ship it!




Ship It!

- Jayush Luniya


On March 31, 2016, 1:32 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45516/
> ---
> 
> (Updated March 31, 2016, 1:32 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15639
> https://issues.apache.org/jira/browse/AMBARI-15639
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> MariaDB related label changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml
>  07eb7c4 
>   ambari-web/app/data/HDP2/site_properties.js 40676df 
> 
> Diff: https://reviews.apache.org/r/45516/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster. All unit tests passed.
>   25625 tests complete (25 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 45519: AMBARI-15637. BRANCH-2.2 If RU/EU is paused, services are restarted on the older version. EU is more complex since stopping services should use the original version.

2016-03-30 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45519/#review126271
---




ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 (line 1220)


This essentially enforces non-rolling upgrade packs to have the following. 
Can we make it a bit less restrictive, atleast not limit based on title text? 


  


  


 Also I see few non-rolling upgrade packs used in test that don't conform 
to this 
 

ambari/ambari-funtest/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_nonrolling.xml

  


  



ambari/ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_nonrolling.xml

  


  



- Jayush Luniya


On March 31, 2016, 2:07 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45519/
> ---
> 
> (Updated March 31, 2016, 2:07 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15637
> https://issues.apache.org/jira/browse/AMBARI-15637
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, if RU/EU is paused, then restarting services manually will use the 
> version whose state is CURRENT. This means that services may be restarted on 
> the wrong version, preventing Ambari from correctly Finalizing the upgrade.
> Instead, the logic should be as follows during Upgrade:
> RU: always use to_version
> EU: if haven't completed the action "UPDATE_DESIRED_STACK_ID", then use the 
> from_version, otherwise, use the to_version.
> 
> During Downgrade, both should use the original version, which is actually the 
> to_version column in the upgrade table.
> 
> THIS CODE REVIEW IS FOR BRANCH-2.2, I WILL CREATE A DIFFERENT ONE FOR TRUNK.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  1767b02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  dd66dcc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  ec49364 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  ef8a8d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  5c8b7f3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 
> 06f6ac1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  a12b204 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  fd866a1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> b49f566 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  3493508 
> 
> Diff: https://reviews.apache.org/r/45519/diff/
> 
> 
> Testing
> ---
> 
> Verified it worked
> 
> Assertions:
> A: restart a service (should have version parameter,
> B: run a service check (no version needed)
> C: run HDFS Rebalance (should have version parameter).
> 
> Test Cases:
> 1. Before stack upgrade, run A, B, and C, which should all use the current 
> version
> 2. EU, immediately click pause. Run A, B, and C, which should use the 
> original version if it exists
> 3. EU, after the services have been stopped and the stack has been upgraded. 
> Run A, B, and C, which should use the new version since the services are now 
> to be started.
> 4. EU, click downgrade and pause. Run A, B, C, which should use the original 
> version.
> 5. RU, click pause whenever a manual task occurs. Run A, B, and C, which 
> should use the destination version.
> 6. RU, click downgrade. Run A, B, and C, which should use the original 
> version.
> 
> Unit Tests passed,
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:10 h
> [INFO] Finished at: 2016-03-30T19:07:04-07:00
> [INFO] Final Memory: 130M/4052M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 45522: AMBARI-14472: Stack Featurize OozieService

2016-03-30 Thread Juanjo Marron


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/
---

Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-14472
https://issues.apache.org/jira/browse/AMBARI-14472


Repository: ambari


Description
---

Stack Featurize Oozie Service


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 54fbb8e 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 ac2dbd9 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
4cbf2d7 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
 90851c8 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 3b01802 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
 4fc50d2 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 e9da71b 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
 2db3672 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 ce44d5c 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
 a08ae3a 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
974ddd7 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 1c80663 

Diff: https://reviews.apache.org/r/45522/diff/


Testing
---

mvn clean test -DskipSurefireTests 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 3:58.802s
[INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
[INFO] Final Memory: 110M/796M
[INFO] 
[root@localhost ambari]#


Thanks,

Juanjo  Marron

Re: Review Request 45519: AMBARI-15637. BRANCH-2.2 If RU/EU is paused, services are restarted on the older version. EU is more complex since stopping services should use the original version.

2016-03-30 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45519/
---

(Updated March 31, 2016, 2:07 a.m.)

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan
Hurley, Jayush Luniya, and Nate Cole.

Bugs: AMBARI-15637
https://issues.apache.org/jira/browse/AMBARI-15637

Repository: ambari

Description
---

Currently, if RU/EU is paused, then restarting services manually will use the
version whose state is CURRENT. This means that services may be restarted on
the wrong version, preventing Ambari from correctly Finalizing the upgrade.
Instead, the logic should be as follows during Upgrade:
RU: always use to_version
EU: if haven't completed the action "UPDATE_DESIRED_STACK_ID", then use the
from_version, otherwise, use the to_version.

During Downgrade, both should use the original version, which is actually the
to_version column in the upgrade table.

THIS CODE REVIEW IS FOR BRANCH-2.2, I WILL CREATE A DIFFERENT ONE FOR TRUNK.

Diffs
-

ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
1767b02

ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
dd66dcc

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
ec49364

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
ef8a8d4

ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
5c8b7f3
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java
06f6ac1

ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
a12b204

ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
fd866a1
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
b49f566

ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
3493508

Diff: https://reviews.apache.org/r/45519/diff/

Testing (updated)
---

Verified it worked

Assertions:
A: restart a service (should have version parameter,
B: run a service check (no version needed)
C: run HDFS Rebalance (should have version parameter).

Test Cases:
1. Before stack upgrade, run A, B, and C, which should all use the current
version
2. EU, immediately click pause. Run A, B, and C, which should use the original
version if it exists
3. EU, after the services have been stopped and the stack has been upgraded.
Run A, B, and C, which should use the new version since the services are now to
be started.
4. EU, click downgrade and pause. Run A, B, C, which should use the original
version.
5. RU, click pause whenever a manual task occurs. Run A, B, and C, which should
use the destination version.
6. RU, click downgrade. Run A, B, and C, which should use the original version.

Unit Tests passed,
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 01:10 h
[INFO] Finished at: 2016-03-30T19:07:04-07:00
[INFO] Final Memory: 130M/4052M
[INFO]

Thanks,

Alejandro Fernandez

Re: Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-30 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45054/#review126240
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/BulkCommandDefinition.java
 (line 70)


May want to check these these are not null.


- Alejandro Fernandez


On March 29, 2016, 5:03 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45054/
> ---
> 
> (Updated March 29, 2016, 5:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15443
> https://issues.apache.org/jira/browse/AMBARI-15443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The items described here are the ones on the Hosts tab, in the Actions 
> drop-down list where the UI shows entries such as All Hosts. If user mouses 
> over the All Hosts, it shows a sub-list including Hosts and slave components.
> 
> The slave component items are hardcoded in hosts_table_menu_view.js as shown 
> below. This jira is to put this info into each service's metainfo.xml so that 
> the slave component items can be stack driven.
> 
> components: function () {
> var serviceNames = App.Service.find().mapProperty('serviceName');
> var menuItems = [
> O.create(
> { serviceName: 'HDFS', componentName: 'DATANODE', masterComponentName: 
> 'NAMENODE', componentNameFormatted: 
> Em.I18n.t('dashboard.services.hdfs.datanodes') }
> 
> ),
> O.create(
> { serviceName: 'YARN', componentName: 'NODEMANAGER', masterComponentName: 
> 'RESOURCEMANAGER', componentNameFormatted: 
> Em.I18n.t('dashboard.services.yarn.nodeManagers') }
> 
> ),
> O.create(
> { serviceName: 'HBASE', componentName: 'HBASE_REGIONSERVER', 
> masterComponentName: 'HBASE_MASTER', componentNameFormatted: 
> Em.I18n.t('dashboard.services.hbase.regionServers') }
> 
> ),
> O.create(
> { serviceName: 'STORM', componentName: 'SUPERVISOR', masterComponentName: 
> 'SUPERVISOR', componentNameFormatted: 
> Em.I18n.t('dashboard.services.storm.supervisors') }
> 
> )];
> 
> return menuItems.filter(function (item)
> { return serviceNames.contains(item.serviceName); }
> 
> );
> }.property(),
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
>  cfd4e7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
>  70945ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  a122dc6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/BulkCommandDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 770ee5c 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 
> e35b7d8 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml
>  057e126 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 75d3bea 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml 
> afe27ec 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/metainfo.xml 
> 804374a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
> 0f71585 
>   ambari-server/src/main/resources/properties.json 01c15f2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  ca062c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  2f84f04 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HBASE/metainfo.xml 
> 0942428 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metainfo.xml 
> 7c0dc74 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 
> 3043b1e 
>   ambari-web/app/mappers/stack_service_mapper.js 8a65055 
>   ambari-web/app/models/stack_service_component.js 26ff1b8 
>   ambari-web/app/views/main/host/hosts_table_menu_view.js e75b643 
>   ambari-web/test/mappers/stack_service_mapper_test.js 4bc36fe 
> 
> Diff: https://reviews.apache.org/r/45054/diff/
> 
> 
> Testing
> ---
> 
> unit test
> patch a trunk cluster with code change, verify the host bulk command list 
> shown for DataNode, HBase Region server, storm supervisor, etc.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 45516: AMBARI-15639. Expose MariaDB option for Hive, Oozie and Ranger

2016-03-30 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45516/#review126237
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 31, 2016, 1:32 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45516/
> ---
> 
> (Updated March 31, 2016, 1:32 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15639
> https://issues.apache.org/jira/browse/AMBARI-15639
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> MariaDB related label changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml
>  07eb7c4 
>   ambari-web/app/data/HDP2/site_properties.js 40676df 
> 
> Diff: https://reviews.apache.org/r/45516/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster. All unit tests passed.
>   25625 tests complete (25 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 45519: AMBARI-15637. BRANCH-2.2 If RU/EU is paused, services are restarted on the older version. EU is more complex since stopping services should use the original version.

2016-03-30 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45519/#review126236
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 (line 429)


This is the actual fix.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (line 2012)


This is the actual fix.



ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 (line 1173)


Notice how this queries the DB to find the upgrade in progress and then 
determines which version to use.
In trunk, I will use the setUpgradeEntity and getUpgradeEntity methods that 
cache the UpgradeEntity currently in progress. For branch-2.2, I wanted to keep 
it simple.



ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 (line 1218)


This relies on these string constants, which I think is ok. Ideally, we 
would have added a marker to the upgrade table for which version to use, but 
this approach works just as well.


- Alejandro Fernandez


On March 31, 2016, 1:37 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45519/
> ---
> 
> (Updated March 31, 2016, 1:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15637
> https://issues.apache.org/jira/browse/AMBARI-15637
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, if RU/EU is paused, then restarting services manually will use the 
> version whose state is CURRENT. This means that services may be restarted on 
> the wrong version, preventing Ambari from correctly Finalizing the upgrade.
> Instead, the logic should be as follows during Upgrade:
> RU: always use to_version
> EU: if haven't completed the action "UPDATE_DESIRED_STACK_ID", then use the 
> from_version, otherwise, use the to_version.
> 
> During Downgrade, both should use the original version, which is actually the 
> to_version column in the upgrade table.
> 
> THIS CODE REVIEW IS FOR BRANCH-2.2, I WILL CREATE A DIFFERENT ONE FOR TRUNK.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  1767b02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  dd66dcc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  ec49364 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  ef8a8d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  5c8b7f3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 
> 06f6ac1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  a12b204 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  fd866a1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> b49f566 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  3493508 
> 
> Diff: https://reviews.apache.org/r/45519/diff/
> 
> 
> Testing
> ---
> 
> Verified it worked, still waiting for unit test results.
> 
> Assertions:
> A: restart a service (should have version parameter,
> B: run a service check (no version needed)
> C: run HDFS Rebalance (should have version parameter).
> 
> Test Cases:
> 1. Before stack upgrade, run A, B, and C, which should all use the current 
> version
> 2. EU, immediately click pause. Run A, B, and C, which should use the 
> original version if it exists
> 3. EU, after the services have been stopped and the stack has been upgraded. 
> Run A, B, and C, which should use the new version since the services are now 
> to be started.
> 4. EU, click downgrade and pause. Run A, B, C, which should use the original 
> version.
> 5. RU, click pause whenever a manual task occurs. Run A, B, and C, which 
> should use the destination version.
> 6. RU, click downgrade. Run A, B, and C, which should use the original 
> version.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 45519: AMBARI-15637. BRANCH-2.2 If RU/EU is paused, services are restarted on the older version. EU is more complex since stopping services should use the original version.