date:20160613

Re: Review Request 48634: File browser : File preview show first character only when ssl is enabled.

2016-06-13 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48634/#review137452
---


Ship it!




Ship It!

- Nitiraj Rathore


On June 13, 2016, 1:18 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48634/
> ---
> 
> (Updated June 13, 2016, 1:18 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17194
> https://issues.apache.org/jira/browse/AMBARI-17194
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Using IOUtils.read to read from file.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FilePreviewService.java
>  3585516 
> 
> Diff: https://reviews.apache.org/r/48634/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 48308: [AMBARI-17078] Make Spark2-ThriftServer and Livy Server as optional by default

2016-06-13 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48308/#review137449
---


Ship it!




Ship It!

- Sumit Mohanty


On June 14, 2016, 4:10 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48308/
> ---
> 
> (Updated June 14, 2016, 4:10 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17078
> https://issues.apache.org/jira/browse/AMBARI-17078
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2-ThriftServer and Livy Server are not being selected by default, but 
> should be unselected by default.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> db2986b 
> 
> Diff: https://reviews.apache.org/r/48308/diff/
> 
> 
> Testing
> ---
> 
> Manullay verified
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 48308: [AMBARI-17078] Make Spark2-ThriftServer and Livy Server as optional by default

2016-06-13 Thread Jeff Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48308/
---

(Updated June 14, 2016, 4:10 a.m.)


Review request for Ambari, Jayush Luniya and Sumit Mohanty.


Changes
---

Move the change to HDP 2.5


Bugs: AMBARI-17078
https://issues.apache.org/jira/browse/AMBARI-17078


Repository: ambari


Description
---

Spark2-ThriftServer and Livy Server are not being selected by default, but 
should be unselected by default.


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
db2986b 

Diff: https://reviews.apache.org/r/48308/diff/


Testing
---

Manullay verified


Thanks,

Jeff Zhang

Re: Review Request 48308: [AMBARI-17078] Make Spark2-ThriftServer and Livy Server as optional by default

2016-06-13 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48308/#review137445
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
910)


The new components should be in HDP/2.5 stack advisor as they are added in 
that version.


- Sumit Mohanty


On June 7, 2016, 2:59 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48308/
> ---
> 
> (Updated June 7, 2016, 2:59 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17078
> https://issues.apache.org/jira/browse/AMBARI-17078
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2-ThriftServer and Livy Server are not being selected by default, but 
> should be unselected by default.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 36fe066b65b12326a128fdb5e8caf9ad56a8211c 
> 
> Diff: https://reviews.apache.org/r/48308/diff/
> 
> 
> Testing
> ---
> 
> Manullay verified
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Review Request 48670: Return well formatted error response while deleting host with clients installed.

2016-06-13 Thread Ajit Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48670/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-17210
https://issues.apache.org/jira/browse/AMBARI-17210


Repository: ambari


Description
---

Return well formatted error response while deleting host with clients installed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 46fc65295f72bae39c534cd9684f2d76d1e30224 

Diff: https://reviews.apache.org/r/48670/diff/


Testing
---

Manual testing

delete 
http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6403.ambari.apache.org
{
  "status" : 500,
  "message" : "org.apache.ambari.server.controller.spi.SystemException: An 
internal system exception occurred: Cannot remove host c6403.ambari.apache.org 
from c1.  The following roles exist, and these components must be stopped if 
running, and then deleted: HDFS_CLIENT, MAPREDUCE2_CLIENT, YARN_CLIENT, 
ZOOKEEPER_CLIENT"
}


Thanks,

Ajit Kumar

Re: Review Request 48664: Add logging for the command executed during PXF service check

2016-06-13 Thread Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48664/#review137415
---


Ship it!




Ship It!

- Matt


On June 13, 2016, 3:30 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48664/
> ---
> 
> (Updated June 13, 2016, 3:30 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Matt.
> 
> 
> Bugs: AMBARI-17208
> https://issues.apache.org/jira/browse/AMBARI-17208
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add logging for the command executed during PXF service check
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
>  c39a85e 
> 
> Diff: https://reviews.apache.org/r/48664/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 48663: Export PGHOST before any HAWQ Master or Standby custom command is executed

2016-06-13 Thread bhuvnesh chaudhary


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48663/#review137412
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On June 13, 2016, 10:25 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48663/
> ---
> 
> (Updated June 13, 2016, 10:25 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-17207
> https://issues.apache.org/jira/browse/AMBARI-17207
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Export PGHOST before any HAWQ Master or Standby custom command is executed
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  1804f11 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  dc9bb12 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  119f2c7 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  12d3511 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py aa63004 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 185bde8 
> 
> Diff: https://reviews.apache.org/r/48663/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> Updated unit tests:
> ```
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service PXF was loaded
> ServiceAdvisor implementation for service PXF was loaded
> ServiceAdvisor implementation for service PXF was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service PXF was loaded
> ServiceAdvisor implementation for service PXF was loaded
> ServiceAdvisor implementation for service PXF was loaded
> ServiceAdvisor implementation for service PXF was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove

Review Request 48664: Add logging for the command executed during PXF service check

2016-06-13 Thread bhuvnesh chaudhary


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48664/
---

Review request for Ambari, Alexander Denissov and Matt.


Bugs: AMBARI-17208
https://issues.apache.org/jira/browse/AMBARI-17208


Repository: ambari


Description
---

Add logging for the command executed during PXF service check


Diffs
-

  
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
 c39a85e 

Diff: https://reviews.apache.org/r/48664/diff/


Testing
---

yes


Thanks,

bhuvnesh chaudhary

Review Request 48663: Export PGHOST before any HAWQ Master or Standby custom command is executed

2016-06-13 Thread Matt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48663/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.

Bugs: AMBARI-17207
https://issues.apache.org/jira/browse/AMBARI-17207

Repository: ambari

Description
---

Export PGHOST before any HAWQ Master or Standby custom command is executed

Diffs
-

ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
1804f11

ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
dc9bb12

ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
119f2c7

ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
12d3511
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py aa63004
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 185bde8

Diff: https://reviews.apache.org/r/48663/diff/

Testing
---

Manually tested.

Updated unit tests:
```
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
test_hawq_master_critical
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ...
ok
test_hawq_segment_critical
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ...
ok
test_hawq_standby_critical
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ...
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ...
ok
test_exception_registration_status
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 2016-06-13 15:24:28,647 - Removing
HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-06-13 15:24:28,652 - HAWQ
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not
Kerberized ... 2016-06-13 15:24:28,656 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource

95 matches

Mail list logo