Re: Review Request 49235: AMBARI-17390: Need to create field "text" in history collection

2016-06-26 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49235/#review139493
---


Ship it!




Ship It!

- Miklos Gergely


On June 26, 2016, 3:05 a.m., Don Bosco Durai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49235/
> ---
> 
> (Updated June 26, 2016, 3:05 a.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, 
> Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17390
> https://issues.apache.org/jira/browse/AMBARI-17390
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added additional field called "text.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/history/conf/managed-schema
>  fed5cd9 
> 
> Diff: https://reviews.apache.org/r/49235/diff/
> 
> 
> Testing
> ---
> 
> Tested creating 3 node hadoop cluster
> 
> 
> Thanks,
> 
> Don Bosco Durai
> 
>

Re: Review Request 49233: Remove superfluous Logfeeder codes

2016-06-26 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49233/#review139497
---


Ship it!




Ship It!

- Oliver Szabo


On June 25, 2016, 11:49 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49233/
> ---
> 
> (Updated June 25, 2016, 11:49 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Hayat Behlim, Dharmesh Makwana, 
> Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17347
> https://issues.apache.org/jira/browse/AMBARI-17347
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove
> - unnecessary imports
> - unused functions
> - unused variables
> - empty comments
> - meaningless comments
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/AliasUtil.java
>  3836c76 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/ConfigBlock.java
>  521319e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java
>  4359c78 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  d00ed67 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
>  6f29fde 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
>  7a68b4d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricCount.java
>  c715881 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricsMgr.java
>  be7594a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/OutputMgr.java
>  f84457e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  aa1edea 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  9b2a717 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  c4da3cb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/JSONFilterCode.java
>  5c4d30e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  18e2184 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  7107a69 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
>  6196068 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  d68ab96 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
>  9c46c4e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
>  a231807 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
>  5b9fe8f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederConstants.java
>  f177e49 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java
>  f223207 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java
>  a064663 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java
>  5b89d4b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
>  107e7e4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java
>  99c33ed 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldValue.java
>  9810ceb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java
>  99a2909 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputData.java
>  8df1d29 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputDevNull.java
>  7cfcb98 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputFile.java

Re: Review Request 49235: AMBARI-17390: Need to create field "text" in history collection

2016-06-26 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49235/#review139498
---


Ship it!




Ship It!

- Oliver Szabo


On June 26, 2016, 3:05 a.m., Don Bosco Durai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49235/
> ---
> 
> (Updated June 26, 2016, 3:05 a.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, 
> Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17390
> https://issues.apache.org/jira/browse/AMBARI-17390
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added additional field called "text.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/history/conf/managed-schema
>  fed5cd9 
> 
> Diff: https://reviews.apache.org/r/49235/diff/
> 
> 
> Testing
> ---
> 
> Tested creating 3 node hadoop cluster
> 
> 
> Thanks,
> 
> Don Bosco Durai
> 
>

Review Request 49237: Make solr-client log writeabe for others in Hadoop Services group

2016-06-26 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49237/
---

Review request for Ambari and Miklos Gergely.


Bugs: AMBARI-17441
https://issues.apache.org/jira/browse/AMBARI-17441


Repository: ambari


Description
---

ranger/atlas should be able to write solr-client logs


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 36b4863 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
ad531de 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py fe6dd31 

Diff: https://reviews.apache.org/r/49237/diff/


Testing
---

Total run:1073
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 49237: Make solr-client log writeabe for others in Hadoop Services group

2016-06-26 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49237/#review139499
---


Ship it!




Ship It!

- Miklos Gergely


On June 26, 2016, 12:48 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49237/
> ---
> 
> (Updated June 26, 2016, 12:48 p.m.)
> 
> 
> Review request for Ambari and Miklos Gergely.
> 
> 
> Bugs: AMBARI-17441
> https://issues.apache.org/jira/browse/AMBARI-17441
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ranger/atlas should be able to write solr-client logs
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  36b4863 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> ad531de 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py fe6dd31 
> 
> Diff: https://reviews.apache.org/r/49237/diff/
> 
> 
> Testing
> ---
> 
> Total run:1073
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 49238: Fix erroneous input configs

2016-06-26 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49238/
---

Review request for Ambari and Oliver Szabo.


Bugs: AMBARI-17442
https://issues.apache.org/jira/browse/AMBARI-17442


Repository: ambari


Description
---

Also fixed the level of a log message.


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java
 4359c78 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
 874c59d 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
 b1b413d 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
 3dbe6b2 

Diff: https://reviews.apache.org/r/49238/diff/


Testing
---

Tested on local cluster.

ambari-server:
OK
--
Total run:1073
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Re: Review Request 49238: Fix erroneous input configs

2016-06-26 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49238/#review139500
---


Ship it!




Ship It!

- Oliver Szabo


On June 26, 2016, 1:35 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49238/
> ---
> 
> (Updated June 26, 2016, 1:35 p.m.)
> 
> 
> Review request for Ambari and Oliver Szabo.
> 
> 
> Bugs: AMBARI-17442
> https://issues.apache.org/jira/browse/AMBARI-17442
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Also fixed the level of a log message.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java
>  4359c78 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
>  874c59d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
>  b1b413d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
>  3dbe6b2 
> 
> Diff: https://reviews.apache.org/r/49238/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> ambari-server:
> OK
> --
> Total run:1073
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 49233: Remove superfluous Logfeeder codes

2016-06-26 Thread Don Bosco Durai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49233/#review139504
---


Ship it!




Ship It!

- Don Bosco Durai


On June 25, 2016, 11:49 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49233/
> ---
> 
> (Updated June 25, 2016, 11:49 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Hayat Behlim, Dharmesh Makwana, 
> Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17347
> https://issues.apache.org/jira/browse/AMBARI-17347
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove
> - unnecessary imports
> - unused functions
> - unused variables
> - empty comments
> - meaningless comments
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/AliasUtil.java
>  3836c76 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/ConfigBlock.java
>  521319e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java
>  4359c78 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  d00ed67 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
>  6f29fde 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
>  7a68b4d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricCount.java
>  c715881 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricsMgr.java
>  be7594a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/OutputMgr.java
>  f84457e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  aa1edea 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  9b2a717 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  c4da3cb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/JSONFilterCode.java
>  5c4d30e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  18e2184 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  7107a69 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
>  6196068 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  d68ab96 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
>  9c46c4e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
>  a231807 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
>  5b9fe8f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederConstants.java
>  f177e49 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java
>  f223207 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java
>  a064663 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java
>  5b89d4b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
>  107e7e4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java
>  99c33ed 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldValue.java
>  9810ceb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java
>  99a2909 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputData.java
>  8df1d29 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputDevNull.java
>  7cfcb98 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputFile.ja

Review Request 49241: Allow commands to specify if they should be auto-retried upon failure

2016-06-26 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49241/
---

Review request for Ambari, Alejandro Fernandez and Sid Wagle.


Bugs: AMBARI-17443
https://issues.apache.org/jira/browse/AMBARI-17443


Repository: ambari


Description
---

Added support for two new request properties that are being honored by RESTART 
commands.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b60592d 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
4feba62 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 fd70df5 

Diff: https://reviews.apache.org/r/49241/diff/


Testing
---

New unit tests and test runs through hadoop-qa in the JIRA 
(https://issues.apache.org/jira/browse/AMBARI-17443).


Thanks,

Sumit Mohanty

Re: Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available

2016-06-26 Thread Jungtaek Lim 


> On 6 24, 2016, 4:54 오후, Prajwal Rao wrote:
> > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js, lines 
> > 128-133
> > 
> >
> > All graphs on HBase-Users have legend hidden.
> > 
> > We do need to handle this on aggregate level dashboards and graphs, and 
> > I already have a separate fix for that.

Prajwal Rao
I'm sorry but I don't get your feedback.
I just would like to show alias instead of raw metric name since it could be 
too long and not beauty to show when we introduce series aggregation ('%' will 
be used to metric name). But I may miss some spots in patch since I understand 
this javascript partially.

If you already have a patch to cover this issue, please let me know. I'd be 
happy to close the review. You can also close issue AMBARI-17416 as duplicated 
or take over.


- Jungtaek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49173/#review139384
---


On 6 24, 2016, 1:42 오전, Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49173/
> ---
> 
> (Updated 6 24, 2016, 1:42 오전)
> 
> 
> Review request for Ambari, Prajwal Rao, Sriharsha Chintalapani, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-17416
> https://issues.apache.org/jira/browse/AMBARI-17416
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When there's no datapoint available, AMS Grafana plugin just ignores alias 
> and shows metric name instead. It seems to be not consistent in point of 
> view, and not good UX I think.
> 
> It'd be great AMS Grafana shows alias whenever there're datapoints available 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 6a4f01b 
> 
> Diff: https://reviews.apache.org/r/49173/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. Actually this is tiny fix so we can imagine how it will make 
> change.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 49241: Allow commands to specify if they should be auto-retried upon failure

2016-06-26 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49241/#review139519
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 (line 985)


syntax issue : commandRetryDurationInt


- Sid Wagle


On June 27, 2016, 3:30 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49241/
> ---
> 
> (Updated June 27, 2016, 3:30 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sid Wagle.
> 
> 
> Bugs: AMBARI-17443
> https://issues.apache.org/jira/browse/AMBARI-17443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added support for two new request properties that are being honored by 
> RESTART commands.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b60592d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 4feba62 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  fd70df5 
> 
> Diff: https://reviews.apache.org/r/49241/diff/
> 
> 
> Testing
> ---
> 
> New unit tests and test runs through hadoop-qa in the JIRA 
> (https://issues.apache.org/jira/browse/AMBARI-17443).
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 49233: Remove superfluous Logfeeder codes

2016-06-26 Thread Dharmesh Makwana 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49233/#review139521
---


Ship it!




Ship It!

- Dharmesh Makwana


On June 25, 2016, 11:49 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49233/
> ---
> 
> (Updated June 25, 2016, 11:49 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Hayat Behlim, Dharmesh Makwana, 
> Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17347
> https://issues.apache.org/jira/browse/AMBARI-17347
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove
> - unnecessary imports
> - unused functions
> - unused variables
> - empty comments
> - meaningless comments
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/AliasUtil.java
>  3836c76 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/ConfigBlock.java
>  521319e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java
>  4359c78 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  d00ed67 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
>  6f29fde 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
>  7a68b4d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricCount.java
>  c715881 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricsMgr.java
>  be7594a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/OutputMgr.java
>  f84457e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  aa1edea 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  9b2a717 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  c4da3cb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/JSONFilterCode.java
>  5c4d30e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  18e2184 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  7107a69 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
>  6196068 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  d68ab96 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
>  9c46c4e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
>  a231807 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
>  5b9fe8f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederConstants.java
>  f177e49 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java
>  f223207 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java
>  a064663 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java
>  5b89d4b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
>  107e7e4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java
>  99c33ed 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldValue.java
>  9810ceb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java
>  99a2909 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputData.java
>  8df1d29 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputDevNull.java
>  7cfcb98 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputFile.j

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-26 Thread Akhil PB 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/
---

(Updated June 27, 2016, 5:36 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath 
Somarajapuram.


Changes
---

Patch updated with review comments.


Bugs: AMBARI-17137
https://issues.apache.org/jira/browse/AMBARI-17137


Repository: ambari


Description
---

Capacity Scheduler View - Node label to queue mappings and save integration for 
all tabs


Diffs (updated)
-

  contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
7f7bc3b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 bbf0cab 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 113ad13 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
 7af45bb 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 1ee7a6b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 518b677 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 93f6645 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
 c0c56b6 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
3dfe363 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
45146ef 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js a32e02c 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
7fef4be 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 9952045 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
17b279a 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 1eead4b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
 e54e14b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
 55910ee 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 ee9616b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 b81474e 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 aad16c2 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
 f11b786 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 24f6938 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 759c0f3 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/saveConfigDialog.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 f252005 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
 b2ae1d5 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
0dde62b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js 
5cef8e5 

Diff:

Re: Review Request 49233: Remove superfluous Logfeeder codes

2016-06-26 Thread Hayat Behlim 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49233/#review139526
---


Ship it!




Ship It!

- Hayat Behlim


On June 25, 2016, 11:49 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49233/
> ---
> 
> (Updated June 25, 2016, 11:49 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Hayat Behlim, Dharmesh Makwana, 
> Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17347
> https://issues.apache.org/jira/browse/AMBARI-17347
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove
> - unnecessary imports
> - unused functions
> - unused variables
> - empty comments
> - meaningless comments
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/AliasUtil.java
>  3836c76 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/ConfigBlock.java
>  521319e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java
>  4359c78 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  d00ed67 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
>  6f29fde 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
>  7a68b4d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricCount.java
>  c715881 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricsMgr.java
>  be7594a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/OutputMgr.java
>  f84457e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  aa1edea 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  9b2a717 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  c4da3cb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/JSONFilterCode.java
>  5c4d30e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  18e2184 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  7107a69 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
>  6196068 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  d68ab96 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
>  9c46c4e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
>  a231807 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
>  5b9fe8f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederConstants.java
>  f177e49 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java
>  f223207 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java
>  a064663 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java
>  5b89d4b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
>  107e7e4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java
>  99c33ed 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldValue.java
>  9810ceb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java
>  99a2909 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputData.java
>  8df1d29 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputDevNull.java
>  7cfcb98 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputFile.java