Re: Review Request 51599: AMBARI-18292 Support dispatching notifications of assigned alert states for script-based alert dispatcher

2016-09-02 Thread yao lei 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51599/
---

(Updated 九月 3, 2016, 12:03 a.m.)


Review request for Ambari.


Summary (updated)
-

AMBARI-18292 Support dispatching notifications of assigned alert states for 
script-based alert dispatcher


Bugs: AMBARI-18292
https://issues.apache.org/jira/browse/AMBARI-18292


Repository: ambari


Description (updated)
---

By default, Ambari allow all notifications of all kinds of alert states 
(OK,WARNING,CRITICAL,UNKNOWN) to dispatch in script-based alert dispatcher.
However, sometimes we hope to filter notification of some alert states 
This patch will resolve this by setting 
'notification.dispatch.alert.script.states' in ambari.properties as following:

#Only dispatch WARNING and CRITICAL state notification 
notification.dispatch.alert.script.states=WARNING,CRITICAL

If you don't set this property that means all notifications will be dispatched


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
 907588d 
  
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcherTest.java
 9e0e406 

Diff: https://reviews.apache.org/r/51599/diff/


Testing
---

Tested

Running 
org.apache.ambari.server.notifications.dispatchers.AlertScriptDispatcherTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.096 sec - in


Thanks,

yao lei

Re: Review Request 51587: View for Apache HAWQ

2016-09-02 Thread Matt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51587/#review147706
---


Ship it!




Ship It!

- Matt


On Sept. 1, 2016, 3:45 p.m., Stuart Pollock wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51587/
> ---
> 
> (Updated Sept. 1, 2016, 3:45 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-18297
> https://issues.apache.org/jira/browse/AMBARI-18297
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> View for Apache HAWQ
> 
> 
> Diffs
> -
> 
>   contrib/views/hawq/.gitignore PRE-CREATION 
>   contrib/views/hawq/README.md PRE-CREATION 
>   contrib/views/hawq/pom.xml PRE-CREATION 
>   
> contrib/views/hawq/src/main/java/org/apache/ambari/view/hawq/HAWQViewServlet.java
>  PRE-CREATION 
>   contrib/views/hawq/src/main/resources/WEB-INF/web.xml PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/.bowerrc PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/.editorconfig PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/.ember-cli PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/.jshintrc PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/adapters/query.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/components/query-table.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/controllers/.gitkeep 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/helpers/.gitkeep PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/index.html PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/models/query.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/resolver.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/routes/application.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/routes/main.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/serializers/query.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/styles/app.scss PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/templates/application.hbs 
> PRE-CREATION 
>   
> contrib/views/hawq/src/main/resources/ui/app/templates/components/query-table.hbs
>  PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/templates/main.hbs 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/utils/utils.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/config/environment.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/ember-cli-build.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/public/assets/logo-hawq.png 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/testem.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/.jshintrc PRE-CREATION 
>   
> contrib/views/hawq/src/main/resources/ui/tests/acceptance/application-test.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/helpers/destroy-app.js 
> PRE-CREATION 
>   
> contrib/views/hawq/src/main/resources/ui/tests/helpers/module-for-acceptance.js
>  PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/helpers/resolver.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/helpers/start-app.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/helpers/test-helper.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/index.html PRE-CREATION 
>   
> contrib/views/hawq/src/main/resources/ui/tests/integration/components/query-table-test.js
>  PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/test-helper.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/adapters/query-test.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/models/query-test.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/routes/main-test.js 
> PRE-CREATION 
>   
> contrib/views/hawq/src/main/resources/ui/tests/unit/serializers/query-test.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/utils/utils-test.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/vendor/.gitkeep PRE-CREATION 
>   contrib/views/hawq/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51587/diff/
> 
> 
> Testing
> ---
> 
> Manually

Re: Review Request 51616: Add sqlline capability to AMS collector to help debugging

2016-09-02 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51616/#review147704
---


Ship it!




Ship It!

- Aravindan Vijayan


On Sept. 2, 2016, 10:06 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51616/
> ---
> 
> (Updated Sept. 2, 2016, 10:06 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18307
> https://issues.apache.org/jira/browse/AMBARI-18307
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Collector packages the jar file to facilitate sqlline command line 
> functionality, the missing piece is the binaries to launch the shell.
> 
> This Jira packages the binaries to use sqlline out of the box with AMS
> 
> *Note to reviewers:* Only sqlline.py has been edited from the Phoenix 4.4 
> distro, log4j and phoenix_utils are ditto.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 6efd508 
>   
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/sqlline/log4j.properties
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/sqlline/phoenix_utils.py
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/sqlline/sqlline.py 
> PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 44d559b 
> 
> Diff: https://reviews.apache.org/r/51616/diff/
> 
> 
> Testing
> ---
> 
> Verified manually and also by building rpm for script layouts:
> 
> /usr/lib/ambari-metrics-collector/bin/sqlline.py
> /usr/lib/ambari-metrics-collector/bin/log4j.properties
> /usr/lib/ambari-metrics-collector/bin/phoenix_utlis.py
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Review Request 51616: Add sqlline capability to AMS collector to help debugging

2016-09-02 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51616/
---

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-18307
https://issues.apache.org/jira/browse/AMBARI-18307


Repository: ambari


Description
---

Collector packages the jar file to facilitate sqlline command line 
functionality, the missing piece is the binaries to launch the shell.

This Jira packages the binaries to use sqlline out of the box with AMS


Diffs
-

  ambari-metrics/ambari-metrics-assembly/pom.xml 6efd508 
  
ambari-metrics/ambari-metrics-timelineservice/conf/unix/sqlline/log4j.properties
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/conf/unix/sqlline/phoenix_utils.py
 PRE-CREATION 
  ambari-metrics/ambari-metrics-timelineservice/conf/unix/sqlline/sqlline.py 
PRE-CREATION 
  ambari-metrics/ambari-metrics-timelineservice/pom.xml 44d559b 

Diff: https://reviews.apache.org/r/51616/diff/


Testing
---

Verified manually and also by building rpm for script layouts:

/usr/lib/ambari-metrics-collector/bin/sqlline.py
/usr/lib/ambari-metrics-collector/bin/log4j.properties
/usr/lib/ambari-metrics-collector/bin/phoenix_utlis.py


Thanks,

Sid Wagle

Re: Review Request 51579: Database Consistency Check Fails With NPE With Missing Service From Stack

2016-09-02 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51579/#review147690
---


Ship it!




Ship It!

- Sumit Mohanty


On Sept. 2, 2016, 4:24 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51579/
> ---
> 
> (Updated Sept. 2, 2016, 4:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18296
> https://issues.apache.org/jira/browse/AMBARI-18296
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The database consistency checker can fail if a service configuration exists 
> for a service which is no longer on the current stack:
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  36a2d99 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  a7c77e1 
> 
> Diff: https://reviews.apache.org/r/51579/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51583: Add ability to add custom grok filters and custom grok patterns with Ambari

2016-09-02 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51583/#review147689
---


Ship it!




Ship It!

- Oliver Szabo


On Sept. 1, 2016, 9:34 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51583/
> ---
> 
> (Updated Sept. 1, 2016, 9:34 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18298
> https://issues.apache.org/jira/browse/AMBARI-18298
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow the operators to view the logsearch grok patterns and add new patterns 
> to them
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-grok.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
>  81e17d8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> e0280b4 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  5c3954f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  d3851d3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
>  49aa357 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-default_grok_patterns.j2
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> f4dbd63 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json a016ce0 
>   ambari-web/app/data/HDP2/site_properties.js 1fad1d6 
> 
> Diff: https://reviews.apache.org/r/51583/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 51587: View for Apache HAWQ

2016-09-02 Thread Lav Jain 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51587/#review147680
---


Ship it!




Please include @mithmatt in the review.

- Lav Jain


On Sept. 1, 2016, 10:45 p.m., Stuart Pollock wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51587/
> ---
> 
> (Updated Sept. 1, 2016, 10:45 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-18297
> https://issues.apache.org/jira/browse/AMBARI-18297
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> View for Apache HAWQ
> 
> 
> Diffs
> -
> 
>   contrib/views/hawq/.gitignore PRE-CREATION 
>   contrib/views/hawq/README.md PRE-CREATION 
>   contrib/views/hawq/pom.xml PRE-CREATION 
>   
> contrib/views/hawq/src/main/java/org/apache/ambari/view/hawq/HAWQViewServlet.java
>  PRE-CREATION 
>   contrib/views/hawq/src/main/resources/WEB-INF/web.xml PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/.bowerrc PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/.editorconfig PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/.ember-cli PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/.jshintrc PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/adapters/query.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/components/query-table.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/controllers/.gitkeep 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/helpers/.gitkeep PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/index.html PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/models/query.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/resolver.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/routes/application.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/routes/main.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/serializers/query.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/styles/app.scss PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/templates/application.hbs 
> PRE-CREATION 
>   
> contrib/views/hawq/src/main/resources/ui/app/templates/components/query-table.hbs
>  PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/templates/main.hbs 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/app/utils/utils.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/config/environment.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/ember-cli-build.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/public/assets/logo-hawq.png 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/testem.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/.jshintrc PRE-CREATION 
>   
> contrib/views/hawq/src/main/resources/ui/tests/acceptance/application-test.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/helpers/destroy-app.js 
> PRE-CREATION 
>   
> contrib/views/hawq/src/main/resources/ui/tests/helpers/module-for-acceptance.js
>  PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/helpers/resolver.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/helpers/start-app.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/helpers/test-helper.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/index.html PRE-CREATION 
>   
> contrib/views/hawq/src/main/resources/ui/tests/integration/components/query-table-test.js
>  PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/test-helper.js PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/adapters/query-test.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/models/query-test.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/routes/main-test.js 
> PRE-CREATION 
>   
> contrib/views/hawq/src/main/resources/ui/tests/unit/serializers/query-test.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/utils/utils-test.js 
> PRE-CREATION 
>   contrib/views/hawq/src/main/resources/ui/vendor/.gitkeep PRE-CREATION 
>   contrib/views/hawq/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51587/diff/
> 
> 
>

Re: Review Request 51579: Database Consistency Check Fails With NPE With Missing Service From Stack

2016-09-02 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51579/#review147676
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 543)


Does it cover both the scenarios:
* service missing in definiton
* orphaned row in serviceconfig table


- Sumit Mohanty


On Sept. 2, 2016, 4:24 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51579/
> ---
> 
> (Updated Sept. 2, 2016, 4:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18296
> https://issues.apache.org/jira/browse/AMBARI-18296
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The database consistency checker can fail if a service configuration exists 
> for a service which is no longer on the current stack:
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  36a2d99 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  a7c77e1 
> 
> Diff: https://reviews.apache.org/r/51579/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51604: AMBARI-11639: Ambari Admin View URL does not get properly parsed for custom versions

2016-09-02 Thread Jesus Alvarez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51604/#review147675
---


Ship it!




Ship It!

- Jesus Alvarez


On Sept. 2, 2016, 3:26 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51604/
> ---
> 
> (Updated Sept. 2, 2016, 3:26 p.m.)
> 
> 
> Review request for Ambari, Jesus Alvarez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-11639
> https://issues.apache.org/jira/browse/AMBARI-11639
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When building a custom version of ADMIN VIEW jar with new version such as 
> "2.1.0_custom", the UI returns a 404 message upon redirect.
> 
> Upon loading ambari-server (http://node1.bigdata:8080) for the first time, 
> the URL is redirected to:
> http://node1.bigdata:8080/views/ADMIN_VIEW/2.1.0_custom/INSTANCE/# , which 
> returns a 404 missing page.
> 
> If the URL is manually changed to 
> http://node1.bigdata:8080/views/ADMIN_VIEW/2.1.0/INSTANCE/# , the UI loads – 
> though links in ambari UI remain broken.
> 
> This appears to be caused by
> latestVersion = sortedMappedVersions[sortedMappedVersions.length-1];
> and ambari.service.load_server_version ; each parsing version string 
> differently.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/router.js d367ce3 
>   ambari-web/app/views/main/admin/stack_upgrade/versions_view.js 59baf07 
>   ambari-web/test/router_test.js e17c9e2 
>   ambari-web/test/views/main/admin/stack_upgrade/version_view_test.js b7df818 
> 
> Diff: https://reviews.apache.org/r/51604/diff/
> 
> 
> Testing
> ---
> 
> existing unit test
> added new unit test
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 51579: Database Consistency Check Fails With NPE With Missing Service From Stack

2016-09-02 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51579/
---

(Updated Вер. 2, 2016, 4:24 після полудня)


Review request for Ambari, Jonathan Hurley and Sumit Mohanty.


Bugs: AMBARI-18296
https://issues.apache.org/jira/browse/AMBARI-18296


Repository: ambari


Description
---

The database consistency checker can fail if a service configuration exists for 
a service which is no longer on the current stack:


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 36a2d99 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 a7c77e1 

Diff: https://reviews.apache.org/r/51579/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 51604: AMBARI-11639: Ambari Admin View URL does not get properly parsed for custom versions

2016-09-02 Thread Tim Thorpe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51604/#review147668
---


Ship it!




Ship It!

- Tim Thorpe


On Sept. 2, 2016, 3:26 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51604/
> ---
> 
> (Updated Sept. 2, 2016, 3:26 p.m.)
> 
> 
> Review request for Ambari, Jesus Alvarez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-11639
> https://issues.apache.org/jira/browse/AMBARI-11639
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When building a custom version of ADMIN VIEW jar with new version such as 
> "2.1.0_custom", the UI returns a 404 message upon redirect.
> 
> Upon loading ambari-server (http://node1.bigdata:8080) for the first time, 
> the URL is redirected to:
> http://node1.bigdata:8080/views/ADMIN_VIEW/2.1.0_custom/INSTANCE/# , which 
> returns a 404 missing page.
> 
> If the URL is manually changed to 
> http://node1.bigdata:8080/views/ADMIN_VIEW/2.1.0/INSTANCE/# , the UI loads – 
> though links in ambari UI remain broken.
> 
> This appears to be caused by
> latestVersion = sortedMappedVersions[sortedMappedVersions.length-1];
> and ambari.service.load_server_version ; each parsing version string 
> differently.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/router.js d367ce3 
>   ambari-web/app/views/main/admin/stack_upgrade/versions_view.js 59baf07 
>   ambari-web/test/router_test.js e17c9e2 
>   ambari-web/test/views/main/admin/stack_upgrade/version_view_test.js b7df818 
> 
> Diff: https://reviews.apache.org/r/51604/diff/
> 
> 
> Testing
> ---
> 
> existing unit test
> added new unit test
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 51604: AMBARI-11639: Ambari Admin View URL does not get properly parsed for custom versions

2016-09-02 Thread Di Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51604/
---

Review request for Ambari, Jesus Alvarez and Tim Thorpe.


Bugs: AMBARI-11639
https://issues.apache.org/jira/browse/AMBARI-11639


Repository: ambari


Description
---

When building a custom version of ADMIN VIEW jar with new version such as 
"2.1.0_custom", the UI returns a 404 message upon redirect.

Upon loading ambari-server (http://node1.bigdata:8080) for the first time, the 
URL is redirected to:
http://node1.bigdata:8080/views/ADMIN_VIEW/2.1.0_custom/INSTANCE/# , which 
returns a 404 missing page.

If the URL is manually changed to 
http://node1.bigdata:8080/views/ADMIN_VIEW/2.1.0/INSTANCE/# , the UI loads – 
though links in ambari UI remain broken.

This appears to be caused by
latestVersion = sortedMappedVersions[sortedMappedVersions.length-1];
and ambari.service.load_server_version ; each parsing version string 
differently.


Diffs
-

  ambari-web/app/router.js d367ce3 
  ambari-web/app/views/main/admin/stack_upgrade/versions_view.js 59baf07 
  ambari-web/test/router_test.js e17c9e2 
  ambari-web/test/views/main/admin/stack_upgrade/version_view_test.js b7df818 

Diff: https://reviews.apache.org/r/51604/diff/


Testing
---

existing unit test
added new unit test


Thanks,

Di Li

Re: Review Request 51017: Error message displays mesage key instead of actual message

2016-09-02 Thread Di Li 


> On Aug. 12, 2016, 7:53 p.m., Di Li wrote:
> > Ship It!
> 
> Sangeeta Ravindran wrote:
> Thanks Di.

Hello Sangeeta, please close this one if it has been committed.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51017/#review145653
---


On Aug. 12, 2016, 3:19 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51017/
> ---
> 
> (Updated Aug. 12, 2016, 3:19 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18133
> https://issues.apache.org/jira/browse/AMBARI-18133
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When an non-existing group name is entered under Local Membership, the error 
> message returns the message key instead of the actual message.
> 
> This is because of a typo in the message key used i.e. 
> users.alert.cannotAddUser is used instead of users.alerts.cannotAddUser
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js
>  3beb42a 
> 
> Diff: https://reviews.apache.org/r/51017/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> mvn test ran clean.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 51583: Add ability to add custom grok filters and custom grok patterns with Ambari

2016-09-02 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51583/#review147664
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 1, 2016, 9:34 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51583/
> ---
> 
> (Updated Sept. 1, 2016, 9:34 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18298
> https://issues.apache.org/jira/browse/AMBARI-18298
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow the operators to view the logsearch grok patterns and add new patterns 
> to them
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-grok.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
>  81e17d8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> e0280b4 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  5c3954f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  d3851d3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
>  49aa357 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-default_grok_patterns.j2
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> f4dbd63 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json a016ce0 
>   ambari-web/app/data/HDP2/site_properties.js 1fad1d6 
> 
> Diff: https://reviews.apache.org/r/51583/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 51601: (2.5.0 fix) Ambari server upgrade script deletes all .pyc files

2016-09-02 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51601/#review147663
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Вер. 2, 2016, 2:42 після полудня, Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51601/
> ---
> 
> (Updated Вер. 2, 2016, 2:42 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-18305
> https://issues.apache.org/jira/browse/AMBARI-18305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From customer case:
> 
> We are trying upgrade Ambari from 2.2.2 to Ambari 2.4 with the latest 
> packages (1226).
> 
> https://issues.apache.org/jira/browse/AMBARI-15947 - "Upgrading Ambari should 
> delete any pyc files"
> 
> The patch contains the following two lines
> {code}
> AMBARI_SERVER="${ROOT}/usr/lib/python2.6/site-packages/ambari_server"
> find $AMBARI_SEVER/ -name *.pyc -exec rm {} \;
> {code}
> 
> The AMBARI_SEVER typo basically executes "find / -name *.pyc -exec rm {} \;"
> on the root directory and deletes ALL pyc files from the ambari server 
> machine.
> 
> This looks like a bug in the latest Ambari package we released yesterday.
> 
> Considering the command has both "rm" and "*" in the same line, lets see if 
> we can use a safer strategy such as changing the CWD and then deleting files.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/install-helper.sh 3614659 
>   ambari-server/conf/unix/install-helper.sh 369a56a 
> 
> Diff: https://reviews.apache.org/r/51601/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 51601: (2.5.0 fix) Ambari server upgrade script deletes all .pyc files

2016-09-02 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51601/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-18305
https://issues.apache.org/jira/browse/AMBARI-18305


Repository: ambari


Description
---

>From customer case:

We are trying upgrade Ambari from 2.2.2 to Ambari 2.4 with the latest packages 
(1226).

https://issues.apache.org/jira/browse/AMBARI-15947 - "Upgrading Ambari should 
delete any pyc files"

The patch contains the following two lines
{code}
AMBARI_SERVER="${ROOT}/usr/lib/python2.6/site-packages/ambari_server"
find $AMBARI_SEVER/ -name *.pyc -exec rm {} \;
{code}

The AMBARI_SEVER typo basically executes "find / -name *.pyc -exec rm {} \;"
on the root directory and deletes ALL pyc files from the ambari server machine.

This looks like a bug in the latest Ambari package we released yesterday.

Considering the command has both "rm" and "*" in the same line, lets see if we 
can use a safer strategy such as changing the CWD and then deleting files.


Diffs
-

  ambari-agent/conf/unix/install-helper.sh 3614659 
  ambari-server/conf/unix/install-helper.sh 369a56a 

Diff: https://reviews.apache.org/r/51601/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 51600: WebHCat service check should not depend on Pig

2016-09-02 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51600/#review147661
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 2, 2016, 5:23 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51600/
> ---
> 
> (Updated Sept. 2, 2016, 5:23 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18304
> https://issues.apache.org/jira/browse/AMBARI-18304
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently WebHCat service check fails on a cluster where Pig is not installed.
> We should eliminate the WebHCat dependency over Pig.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd61631 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  71f930e 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 273bd96 
> 
> Diff: https://reviews.apache.org/r/51600/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 51600: WebHCat service check should not depend on Pig

2016-09-02 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51600/
---

(Updated Sept. 2, 2016, 2:23 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18304
https://issues.apache.org/jira/browse/AMBARI-18304


Repository: ambari


Description
---

Currently WebHCat service check fails on a cluster where Pig is not installed.
We should eliminate the WebHCat dependency over Pig.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 dd61631 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 5e3e233 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
 71f930e 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
273bd96 

Diff: https://reviews.apache.org/r/51600/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 51597: Desired state of client component should not be changed in case configuration changes are applied through a "Restart"

2016-09-02 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51597/#review147660
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 (lines 472 - 477)


I'm curious if we should also try to catch this in the 
ServiceComponentHost; don't let it's state move to STARTED if it knows it's a 
client.


- Jonathan Hurley


On Sept. 2, 2016, 8:11 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51597/
> ---
> 
> (Updated Sept. 2, 2016, 8:11 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18302
> https://issues.apache.org/jira/browse/AMBARI-18302
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configuration changes are propagated to host components by issuing a restart 
> of the affected components.
> In case of master components this action will start the affected components 
> (regardless it is in INSTALLED or STARTED state) and the desired state will 
> be set to STARTED.
> In Ambari client components are always expected to be in INSTALLED state. 
> However upon configuration changes, the desired state of these components are 
> also set to STARTED. This may be misleading for ambari API users that 
> determine component states by checking the desired state and actual state. 
> (The actual state in case of client components will always be INSTALLED)
> This issue addresses this problem by not updating the desired state when 
> client components are restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  8c8ae10 
> 
> Diff: https://reviews.apache.org/r/51597/diff/
> 
> 
> Testing
> ---
> 
> Unit tests running.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Review Request 51600: WebHCat service check should not depend on Pig

2016-09-02 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51600/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18304
https://issues.apache.org/jira/browse/AMBARI-18304


Repository: ambari


Description
---

Currently WebHCat service check fails on a cluster where Pig is not installed.
We should eliminate the WebHCat dependency over Pig.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 dd61631 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 5e3e233 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
 71f930e 
  
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/files/templetonSmoke.sh
 e26148b 
  
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/params.py
 1159491 
  
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/webhcat_service_check.py
 8d15e47 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
273bd96 

Diff: https://reviews.apache.org/r/51600/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 51579: Database Consistency Check Fails With NPE With Missing Service From Stack

2016-09-02 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51579/#review147659
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 549)


I don't think that this situation should prevent Ambari from starting up, 
however I do think we should at least log it.


- Jonathan Hurley


On Sept. 1, 2016, 3:05 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51579/
> ---
> 
> (Updated Sept. 1, 2016, 3:05 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18296
> https://issues.apache.org/jira/browse/AMBARI-18296
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The database consistency checker can fail if a service configuration exists 
> for a service which is no longer on the current stack:
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  9f7419c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  d8f538e 
> 
> Diff: https://reviews.apache.org/r/51579/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-02 Thread Balázs Bence Sári 


> On Aug. 29, 2016, 5:54 p.m., Jayush Luniya wrote:
> > contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml,
> >  line 24
> > 
> >
> > A management pack can have one than one custom services. For example 
> > for HAWQ and PXF release artifacts for both the services are in the same 
> > repo.

Service name is removed


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51238/#review147167
---


On Aug. 26, 2016, 9:25 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51238/
> ---
> 
> (Updated Aug. 26, 2016, 9:25 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-15538
> https://issues.apache.org/jira/browse/AMBARI-15538
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Implementation contains the following things:
> - On startup, add-on service repos are loaded into the stack model
> - On startup, add-on service repos are merged into the VDF's downloaded by 
> LatestRepoCallable
> - On startup, if the is an existing cluster, it's repository version entity 
> is potentially updated with new add-on service repos.
> - Repository definitions contain two new optional fields: service_name and 
> service_version. (null for stack repositories) 
> - Small changes on the Mictrosoft-R mpack (supoorts HDP-2.4 and 2.5)
> - New unit tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  92d47df 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  36a2d99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  63c99c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  097f01c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  30bd0db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  3b5b0a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  02fc2ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  49d53a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  25aa62b 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  bfba021 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 0606f2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  7bcd08b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  29776ed 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 14ff9de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  3c7c001 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  4a0ae3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  50d6028 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  3b5ed28 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java
>  d806dde 
>   ambari-server/src/main/resources/version_definition.xsd bd49028 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/RepoUtilTest.java 
> PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerCommonServicesTest.java
>  1d73ff3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackModuleTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java
>  8d82d09 
>   
>

Re: Review Request 51599: AMBARI-18292 Support dispatching notification of assigned alert states for script-based alert dispatcher

2016-09-02 Thread yao lei 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51599/
---

(Updated 九月 2, 2016, 1:27 p.m.)


Review request for Ambari.


Summary (updated)
-

AMBARI-18292 Support dispatching notification of assigned alert states for 
script-based alert dispatcher


Bugs: AMBARI-18292
https://issues.apache.org/jira/browse/AMBARI-18292


Repository: ambari


Description
---

By default, Ambari allow all notification of all kinds of alert states 
(OK,WARNING,CRITICAL,UNKNOWN) to dispatch in script-based alert dispatcher.
However, sometimes we hope to filter notification of some alert states 
This patch will resolve this by setting 
'notification.dispatch.alert.script.states' in ambari.properties as following:

#Only dispatch WARNING and CRITICAL state notification 
notification.dispatch.alert.script.states=WARNING,CRITICAL

If you don't set this property that means all notification will be dispatched


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
 907588d 
  
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcherTest.java
 9e0e406 

Diff: https://reviews.apache.org/r/51599/diff/


Testing
---

Tested

Running 
org.apache.ambari.server.notifications.dispatchers.AlertScriptDispatcherTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.096 sec - in


Thanks,

yao lei

Review Request 51599: Support dispatching notification of assigned alert states for script-based alert dispatcher

2016-09-02 Thread yao lei 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51599/
---

Review request for Ambari.


Bugs: AMBARI-18292
https://issues.apache.org/jira/browse/AMBARI-18292


Repository: ambari


Description
---

By default, Ambari allow all notification of all kinds of alert states 
(OK,WARNING,CRITICAL,UNKNOWN) to dispatch in script-based alert dispatcher.
However, sometimes we hope to filter notification of some alert states 
This patch will resolve this by setting 
'notification.dispatch.alert.script.states' in ambari.properties as following:

#Only dispatch WARNING and CRITICAL state notification 
notification.dispatch.alert.script.states=WARNING,CRITICAL

If you don't set this property that means all notification will be dispatched


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
 907588d 
  
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcherTest.java
 9e0e406 

Diff: https://reviews.apache.org/r/51599/diff/


Testing
---

Tested

Running 
org.apache.ambari.server.notifications.dispatchers.AlertScriptDispatcherTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.096 sec - in


Thanks,

yao lei

Re: Review Request 51597: Desired state of client component should not be changed in case configuration changes are applied through a "Restart"

2016-09-02 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51597/
---

(Updated Sept. 2, 2016, 12:08 p.m.)


Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
Toader.


Bugs: AMBARI-18302
https://issues.apache.org/jira/browse/AMBARI-18302


Repository: ambari


Description
---

Configuration changes are propagated to host components by issuing a restart of 
the affected components.
In case of master components this action will start the affected components 
(regardless it is in INSTALLED or STARTED state) and the desired state will be 
set to STARTED.
In Ambari client components are always expected to be in INSTALLED state. 
However upon configuration changes, the desired state of these components are 
also set to STARTED. This may be misleading for ambari API users that determine 
component states by checking the desired state and actual state. (The actual 
state in case of client components will always be INSTALLED)
This issue addresses this problem by not updating the desired state when client 
components are restarted.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 8c8ae10 

Diff: https://reviews.apache.org/r/51597/diff/


Testing
---

Unit tests running.


Thanks,

Laszlo Puskas

Review Request 51597: Desired state of client component should not be changed in case configuration changes are applied through a "Restart"

2016-09-02 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51597/
---

Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
Toader.


Bugs: AMBARI-18302
https://issues.apache.org/jira/browse/AMBARI-18302


Repository: ambari


Description
---

Configuration changes are propagated to host components by issuing a restart of 
the affected components.
In case of master components this action will start the affected components 
(regardless it is in INSTALLED or STARTED state) and the desired state will be 
set to STARTED.
In Ambari client components are always expected to be in INSTALLED state. 
However upon configuration changes, the desired state of these components are 
also set to STARTED. This may be misleading for ambari API users that determine 
component states by checking the desired state and actual state. (The actual 
state in case of client components will always be INSTALLED)
This issue addresses this problem by not updating the desired state when client 
components are restarted.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 8c8ae10 

Diff: https://reviews.apache.org/r/51597/diff/


Testing
---

Unit tests running.


Thanks,

Laszlo Puskas

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

2016-09-02 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51575/#review147644
---


Ship it!




Ship It!

- Oliver Szabo


On Sept. 1, 2016, 1:36 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51575/
> ---
> 
> (Updated Sept. 1, 2016, 1:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17891
> https://issues.apache.org/jira/browse/AMBARI-17891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update existing service_advisor.py for Microsoft-R service to conform to the 
> updated interface (changed in AMBARI-16663).  Also fix leftover comment.
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  554be2d 
> 
> Diff: https://reviews.apache.org/r/51575/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on local cluster (created cluster with HDFS, YARN, and 
> ZooKeeper; added Microsoft-R service via web UI; verified that service 
> advisor is invoked in both recommend-component-layout and 
> validate-component-layout requests, and that it correctly 
> recommends/validates service colocation).
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

2016-09-02 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51575/#review147643
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 1, 2016, 3:36 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51575/
> ---
> 
> (Updated Sept. 1, 2016, 3:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17891
> https://issues.apache.org/jira/browse/AMBARI-17891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update existing service_advisor.py for Microsoft-R service to conform to the 
> updated interface (changed in AMBARI-16663).  Also fix leftover comment.
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  554be2d 
> 
> Diff: https://reviews.apache.org/r/51575/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on local cluster (created cluster with HDFS, YARN, and 
> ZooKeeper; added Microsoft-R service via web UI; verified that service 
> advisor is invoked in both recommend-component-layout and 
> validate-component-layout requests, and that it correctly 
> recommends/validates service colocation).
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-09-02 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/#review147642
---


Ship it!




Ship It!

- Dmytro Sen


On Сен. 1, 2016, 6:11 п.п., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51562/
> ---
> 
> (Updated Сен. 1, 2016, 6:11 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18289
> https://issues.apache.org/jira/browse/AMBARI-18289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Negative values are being reported for IOPS in the "system servers" dashboard
> 
> BUG
> This was a dockerized environment. Negative rate values were seen because 
> read/write counters were dropping below the previous values at random times. 
> On further investigation, it revealed that this was due to the docker volume 
> groups present on the host. It is expected of docker containers to add/remove 
> the volume groups during the lifecyle of a container. So, when a volume group 
> goes away, the read/write counters do not contribute to the total counter 
> values, thus making the value go below the last seen value.
> 
> FIX
> Have a provision to discard such "special" disk partitions through a skip 
> pattern. If skipped, they will not contribute to the global counter metric. 
> Individual disk counter metrics can be used to get disk specific counter 
> values.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py
>  845b270 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4135d32 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  2503c43 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51562/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 51452: AMBARI-18261: CapSched View: Showing warning icons to refresh or restart capsched once after configs are saved

2016-09-02 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51452/#review147640
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Sept. 1, 2016, 1:28 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51452/
> ---
> 
> (Updated Sept. 1, 2016, 1:28 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18261
> https://issues.apache.org/jira/browse/AMBARI-18261
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Showing warning icons to refresh or restart capsched once after configs are 
> saved
> Bug fixes
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> f300b5b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b86719f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  ed22c2b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  b244097 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  89e7cac 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  8118805 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  c15f100 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  ea5262d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  edd8a3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  dd46b2c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  a68a2aa 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  6638b4c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> acf6465 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> 0b13a8a 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 01a7d6a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  195b55d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  a9ef778 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  1f6fbda 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  9073910 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  73a9e21 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  7b25af3 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  262f380 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  1bc3380 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  7649512 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  a7901b8 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  fa35518 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  9c3ffd0 
> 
> Diff: https://reviews.apache.org/r/51452/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

2016-09-02 Thread Attila Doroszlai 


> On Sept. 1, 2016, 1:57 p.m., Sebastian Toader wrote:
> > contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py,
> >  line 37
> > 
> >
> > Is there any unit test framework for m-pack? If so please add unit 
> > tests for this class.

There is no unit test framework for mpacks.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51575/#review147556
---


On Sept. 1, 2016, 1:36 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51575/
> ---
> 
> (Updated Sept. 1, 2016, 1:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17891
> https://issues.apache.org/jira/browse/AMBARI-17891
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update existing service_advisor.py for Microsoft-R service to conform to the 
> updated interface (changed in AMBARI-16663).  Also fix leftover comment.
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  554be2d 
> 
> Diff: https://reviews.apache.org/r/51575/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on local cluster (created cluster with HDFS, YARN, and 
> ZooKeeper; added Microsoft-R service via web UI; verified that service 
> advisor is invoked in both recommend-component-layout and 
> validate-component-layout requests, and that it correctly 
> recommends/validates service colocation).
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>