Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

[Mugdha Varadkar]

> On Oct. 5, 2016, 5:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java,
> >  line 171
> > 
> >
> > You can set this to null and use StringUtils.isBlank() check

Updated in latest patch


> On Oct. 5, 2016, 5:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java,
> >  line 186
> > 
> >
> > StringUtils.isBlank()

Updated in latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52504/#review151518
---


On Oct. 6, 2016, 5:57 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52504/
> ---
> 
> (Updated Oct. 6, 2016, 5:57 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18521
> https://issues.apache.org/jira/browse/AMBARI-18521
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack changes required while upgrading to stack 2.5 in secure env
> - Remove adding spnego principal value to 
> ranger-admin-site/ranger.spnego.kerberos.principal
> - Get storm principal bare name and update it accordingly to 
> ranger-admin-site.xml/ranger.plugins.storm.serviceuser
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
>  c3d71c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java
>  133a9e3 
> 
> Diff: https://reviews.apache.org/r/52504/diff/
> 
> 
> Testing
> ---
> 
> mvn -DskipPythonTests -Dtest=RangerKerberosConfigCalculationTest test
> ---
>  T E S T S
> ---
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
> support was removed in 8.0
> Running 
> org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec - 
> in 
> org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
> 
> Results :
> 
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 47.998 s
> [INFO] Finished at: 2016-10-04T06:15:35+00:00
> [INFO] Final Memory: 67M/1203M
> [INFO] 
> 
> 
> 
> Tested Ranger EU from 2.4 to 2.5 stack in secure env on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52504/
---

(Updated Oct. 6, 2016, 5:57 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
and Velmurugan Periasamy.


Bugs: AMBARI-18521
https://issues.apache.org/jira/browse/AMBARI-18521


Repository: ambari


Description
---

Stack changes required while upgrading to stack 2.5 in secure env
- Remove adding spnego principal value to 
ranger-admin-site/ranger.spnego.kerberos.principal
- Get storm principal bare name and update it accordingly to 
ranger-admin-site.xml/ranger.plugins.storm.serviceuser


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
 c3d71c0 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java
 133a9e3 

Diff: https://reviews.apache.org/r/52504/diff/


Testing
---

mvn -DskipPythonTests -Dtest=RangerKerberosConfigCalculationTest test
---
 T E S T S
---
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
support was removed in 8.0
Running 
org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec - in 
org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 47.998 s
[INFO] Finished at: 2016-10-04T06:15:35+00:00
[INFO] Final Memory: 67M/1203M
[INFO] 


Tested Ranger EU from 2.4 to 2.5 stack in secure env on centos6


Thanks,

Mugdha Varadkar

Review Request 52586: AMBARI-18540: Unit test cases required for verifying Ambari username case sensitivity

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52586/
---

Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Robert Levas, 
and Sumit Mohanty.


Bugs: AMBARI-18540
https://issues.apache.org/jira/browse/AMBARI-18540


Repository: ambari


Description
---

AMBARI-18540: Unit test cases required for verifying Ambari username case 
sensitivity


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/52586/diff/


Testing
---

Unit tests to get DB coverage on User creation, retrieval and deletion APIs.


Thanks,

Nahappan Somasundaram

Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52495/#review151604
---


Ship it!




Ship It!

- Richard Zang


On Oct. 4, 2016, 12:51 a.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52495/
> ---
> 
> (Updated Oct. 4, 2016, 12:51 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18245
> https://issues.apache.org/jira/browse/AMBARI-18245
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We are currently using 0.10, which is very old and going EOL 2016-10-01: 
> https://github.com/nodejs/LTS
> We should upgrade to Node 4.x:
> Upgrade Node on Ambari Web
> Upgrade Node on Ambari Admin
> Upgrade Node on contrib/views/* modules
> 
> 
> Diffs
> -
> 
>   .gitignore d9f23de 
>   ambari-admin/pom.xml e057178 
>   ambari-web/app/styles/common.less bc11d4d 
>   ambari-web/package.json 6702471 
>   ambari-web/pom.xml 759b63e 
>   contrib/views/capacity-scheduler/pom.xml cd97dcf 
>   contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 
>   contrib/views/files/pom.xml 383d90d 
>   contrib/views/hawq/pom.xml 9a563f6 
>   contrib/views/hive-next/pom.xml 921990a 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 
>   contrib/views/hive/pom.xml 20b23f6 
>   contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 
>   contrib/views/hueambarimigration/pom.xml 3b28276 
>   contrib/views/jobs/pom.xml bd01753 
>   contrib/views/pig/pom.xml 595537a 
>   contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 
>   contrib/views/wfmanager/pom.xml 389dc6c 
> 
> Diff: https://reviews.apache.org/r/52495/diff/
> 
> 
> Testing
> ---
> 
> Ran "mvn clean package", Ambari Server failed, which is irralevant to this 
> patch.
> Then run "mvn clean install" individually:
> 
> Ambari Web:
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 3:08.144s
> [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016
> [INFO] Final Memory: 16M/407M
> [INFO] 
> 
> 
> 30366 tests complete (27 seconds)
> 151 tests pending
> 
> Ambari Admin:
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 14.924s
> [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016
> [INFO] Final Memory: 20M/284M
> [INFO] 
> 
> 
> PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 
> secs)
> 
> contrib/views/ modules:
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s]
> [INFO] Ambari View Utils . SUCCESS [4.714s]
> [INFO] Ambari View Commons ... SUCCESS [0.286s]
> [INFO] Files . SUCCESS [52.631s]
> [INFO] Jobs .. SUCCESS [6.712s]
> [INFO] Pig ... SUCCESS [1:07.799s]
> [INFO] Slider  SUCCESS [36.043s]
> [INFO] Capacity Scheduler  SUCCESS [53.446s]
> [INFO] Tez ... SUCCESS [3.659s]
> [INFO] HAWQ .. SUCCESS [2:24.060s]
> [INFO] Storm_Monitoring .. SUCCESS [0.432s]
> [INFO] Zeppelin .. SUCCESS [2.080s]
> [INFO] hueambarimigration  SUCCESS [20.801s]
> [INFO] Hive Jdbc . SUCCESS [1:00.664s]
> [INFO] WF Manager View ... SUCCESS [32.911s]
> [INFO] Hive .. SUCCESS [51.542s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 9:58.964s
> [INFO] Finished at: Mon Oct 03 17:22:59 PDT 2016
> [INFO] Final Memory: 90M/404M
> [INFO] 
> 
> 
> 
> 

Re: Review Request 52583: Request/access log feature in Ambari-server

[Amarnath reddy pappu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52583/
---

(Updated Oct. 5, 2016, 11:51 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and 
Sid Wagle.


Bugs: AMBARI-18543
https://issues.apache.org/jira/browse/AMBARI-18543


Repository: ambari


Description (updated)
---

Request/access log feature in Ambari-server


1. Have provided option in ambari.properties to configure the path - 
"server.requestlogs.path"
By default has given it as 
server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log
2. If some customers does not want this to enable then removing 
"server.requestlogs.path" property will not create any file. 
3. currently have set the number of reatin days as 15
4. if somebody wants to reduce/increase that value then add that property in 
ambari.properties file

5. log content should look alike below,
 
 192.168.65.1 -  -  [05/Oct/2016:23:45:18 +] "GET / HTTP/1.1" 404 618 "-" 
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 
Firefox/48.0"

Please review and provide your comments.


Diffs
-

  ambari-server/conf/unix/ambari.properties 4dcbe99 
  ambari-server/conf/windows/ambari.properties 64cce3b 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2e850ef 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5e498f0 

Diff: https://reviews.apache.org/r/52583/diff/


Testing
---

1. install and start  Ambari-server, access the UI. 
Expected Result: server should create ambari-server-access-_mm_dd.log
Result: PASS

2. access few links in ambari server UI
Expected Result: server should log URL and response code
Result: PASS

3. Remove entry server.requestlogs.path from ambari.properties 
Expected Result: server should not create any request log
Result: PASS

4. change the log path server.requestlogs.path in ambari.properties and restart 
server
Expected Result: it should create request log in new path
Result: PASS


Thanks,

Amarnath reddy pappu

Re: Review Request 52583: Request/access log feature in Ambari-server

[Amarnath reddy pappu]

> On Oct. 5, 2016, 11:45 p.m., Alejandro Fernandez wrote:
> > ambari-server/conf/unix/ambari.properties, line 78
> > 
> >
> > What is the content of this log?
> > 
> > Please add a branch and Jira to the code review.
> 
> Amarnath reddy pappu wrote:
> Have updated JIRA. have taken out the code from trunk.
> 
> sample log line would be like below,
> 
> 192.168.65.1 -  -  [05/Oct/2016:23:45:18 +] "GET / HTTP/1.1" 404 618 
> "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 
> Firefox/48.0"

AMBARI-18543


- Amarnath reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52583/#review151593
---


On Oct. 5, 2016, 11:38 p.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52583/
> ---
> 
> (Updated Oct. 5, 2016, 11:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Request/access log feature in Ambari-server
> 
> 
> 1. Have provided option in ambari.properties to configure the path - 
> "server.requestlogs.path"
> By default has given it as 
> server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log
> 2. If some customers does not want this to enable then removing 
> "server.requestlogs.path" property will not create any file. 
> 3. currently have set the number of reatin days as 15
> 4. if somebody wants to reduce/increase that value then add that property in 
> ambari.properties file
> 
> Please review and provide your comments.
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/ambari.properties 4dcbe99 
>   ambari-server/conf/windows/ambari.properties 64cce3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
> 
> Diff: https://reviews.apache.org/r/52583/diff/
> 
> 
> Testing
> ---
> 
> 1. install and start  Ambari-server, access the UI. 
> Expected Result: server should create ambari-server-access-_mm_dd.log
> Result: PASS
> 
> 2. access few links in ambari server UI
> Expected Result: server should log URL and response code
> Result: PASS
> 
> 3. Remove entry server.requestlogs.path from ambari.properties 
> Expected Result: server should not create any request log
> Result: PASS
> 
> 4. change the log path server.requestlogs.path in ambari.properties and 
> restart server
> Expected Result: it should create request log in new path
> Result: PASS
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Re: Review Request 52583: Request/access log feature in Ambari-server

[Amarnath reddy pappu]

> On Oct. 5, 2016, 11:45 p.m., Alejandro Fernandez wrote:
> > ambari-server/conf/unix/ambari.properties, line 78
> > 
> >
> > What is the content of this log?
> > 
> > Please add a branch and Jira to the code review.

Have updated JIRA. have taken out the code from trunk.

sample log line would be like below,

192.168.65.1 -  -  [05/Oct/2016:23:45:18 +] "GET / HTTP/1.1" 404 618 "-" 
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 
Firefox/48.0"


- Amarnath reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52583/#review151593
---


On Oct. 5, 2016, 11:38 p.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52583/
> ---
> 
> (Updated Oct. 5, 2016, 11:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Request/access log feature in Ambari-server
> 
> 
> 1. Have provided option in ambari.properties to configure the path - 
> "server.requestlogs.path"
> By default has given it as 
> server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log
> 2. If some customers does not want this to enable then removing 
> "server.requestlogs.path" property will not create any file. 
> 3. currently have set the number of reatin days as 15
> 4. if somebody wants to reduce/increase that value then add that property in 
> ambari.properties file
> 
> Please review and provide your comments.
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/ambari.properties 4dcbe99 
>   ambari-server/conf/windows/ambari.properties 64cce3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
> 
> Diff: https://reviews.apache.org/r/52583/diff/
> 
> 
> Testing
> ---
> 
> 1. install and start  Ambari-server, access the UI. 
> Expected Result: server should create ambari-server-access-_mm_dd.log
> Result: PASS
> 
> 2. access few links in ambari server UI
> Expected Result: server should log URL and response code
> Result: PASS
> 
> 3. Remove entry server.requestlogs.path from ambari.properties 
> Expected Result: server should not create any request log
> Result: PASS
> 
> 4. change the log path server.requestlogs.path in ambari.properties and 
> restart server
> Expected Result: it should create request log in new path
> Result: PASS
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Re: Review Request 52583: Request/access log feature in Ambari-server

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52583/#review151593
---




ambari-server/conf/unix/ambari.properties (line 78)


What is the content of this log?

Please add a branch and Jira to the code review.


- Alejandro Fernandez


On Oct. 5, 2016, 11:38 p.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52583/
> ---
> 
> (Updated Oct. 5, 2016, 11:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Request/access log feature in Ambari-server
> 
> 
> 1. Have provided option in ambari.properties to configure the path - 
> "server.requestlogs.path"
> By default has given it as 
> server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log
> 2. If some customers does not want this to enable then removing 
> "server.requestlogs.path" property will not create any file. 
> 3. currently have set the number of reatin days as 15
> 4. if somebody wants to reduce/increase that value then add that property in 
> ambari.properties file
> 
> Please review and provide your comments.
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/ambari.properties 4dcbe99 
>   ambari-server/conf/windows/ambari.properties 64cce3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
> 
> Diff: https://reviews.apache.org/r/52583/diff/
> 
> 
> Testing
> ---
> 
> 1. install and start  Ambari-server, access the UI. 
> Expected Result: server should create ambari-server-access-_mm_dd.log
> Result: PASS
> 
> 2. access few links in ambari server UI
> Expected Result: server should log URL and response code
> Result: PASS
> 
> 3. Remove entry server.requestlogs.path from ambari.properties 
> Expected Result: server should not create any request log
> Result: PASS
> 
> 4. change the log path server.requestlogs.path in ambari.properties and 
> restart server
> Expected Result: it should create request log in new path
> Result: PASS
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Review Request 52583: Request/access log feature in Ambari-server

[Amarnath reddy pappu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52583/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and 
Sid Wagle.


Repository: ambari


Description
---

Request/access log feature in Ambari-server


1. Have provided option in ambari.properties to configure the path - 
"server.requestlogs.path"
By default has given it as 
server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log
2. If some customers does not want this to enable then removing 
"server.requestlogs.path" property will not create any file. 
3. currently have set the number of reatin days as 15
4. if somebody wants to reduce/increase that value then add that property in 
ambari.properties file

Please review and provide your comments.


Diffs
-

  ambari-server/conf/unix/ambari.properties 4dcbe99 
  ambari-server/conf/windows/ambari.properties 64cce3b 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2e850ef 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5e498f0 

Diff: https://reviews.apache.org/r/52583/diff/


Testing
---

1. install and start  Ambari-server, access the UI. 
Expected Result: server should create ambari-server-access-_mm_dd.log
Result: PASS

2. access few links in ambari server UI
Expected Result: server should log URL and response code
Result: PASS

3. Remove entry server.requestlogs.path from ambari.properties 
Expected Result: server should not create any request log
Result: PASS

4. change the log path server.requestlogs.path in ambari.properties and restart 
server
Expected Result: it should create request log in new path
Result: PASS


Thanks,

Amarnath reddy pappu

Re: Review Request 52566: Remove Unnecessary Locks Inside Of Host Business Object Implementations

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52566/#review151554
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 5, 2016, 8:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52566/
> ---
> 
> (Updated Oct. 5, 2016, 8:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-18539
> https://issues.apache.org/jira/browse/AMBARI-18539
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of AMBARI-18456, removing unnecessary locks in Host business objects. 
> 
> The reason that the locks were being used is because we were storing the 
> state (HostEntity and HostStateEntity) in memory. There are even comments 
> about why this is bad to do (yet we were doing it).
> 
> - Removed most locks
> - Removed state
> - Constructor persists new entities
> - No longer need to call persist() externally
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ConfigGroupHostMappingDAO.java
>  71d93cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> bd3f8bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  7b119f2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostFactory.java
>  5cfbbef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 91b6360 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  b3e3941 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
>  b212e93 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
>  bf9d0db 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java
>  fa51f91 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
>  6e3f2e0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatTestHelper.java
>  e813e66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
>  d121fcb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/InstallPackagesCheckTest.java
>  080ca3a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  e82900d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  197b925 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java
>  73b5b75 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java
>  2512bb3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  9f610f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java
>  2721731 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
>  139702c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  63892cf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
>  eccc1ed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedStateTest.java
>  0d7fc67 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/FlumeServiceCalculatedStateTest.java
>  1bc4214 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedStateTest.java
>  35a7b67 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedStateTest.java
>  a562962 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedStateTest.java
>  ddf1503 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedStateTest.java
>  7e1595e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/YarnServiceCalculatedStateTest.java
>  b5cce0e 
>   ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 
> ce86f83 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
>  9135732 
>   

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52485/#review151553
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 4, 2016, 12:43 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52485/
> ---
> 
> (Updated Oct. 4, 2016, 12:43 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jayush Luniya, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18516
> https://issues.apache.org/jira/browse/AMBARI-18516
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a service is added to a stack, it should be identified as:
> default/regular - service is optional on the cluster, UI usually shows it as
> tech-preview - service may be deployed, UI will not auto-select these 
> services and mark them as TechPreview
> mandatory - service need to be deployed and all deployment should fail is the 
> service is not selected during deployment
> Lets create a proposal of what changes are needed in the services' 
> metainfo.xml? Note that a service can change its attribute between stack 
> versions - e.g. move from "tech-preview" to "mandatory".
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  5865e20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  16713dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> 34e65c3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> b0d81c3 
>   ambari-server/src/main/resources/properties.json eb27878 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java
>  a9a8fdb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java
>  1754cbb 
> 
> Diff: https://reviews.apache.org/r/52485/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/#review151552
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 5, 2016, 4:38 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52532/
> ---
> 
> (Updated Oct. 5, 2016, 4:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Robert 
> Levas, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18532
> https://issues.apache.org/jira/browse/AMBARI-18532
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ERROR 1071 (42000): Specified key was too long; max key length is 1000 bytes
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569 
> 
> Diff: https://reviews.apache.org/r/52532/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52535: Advanced storm-atlas-application.properties panel is not opened by default upon filtering

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52535/#review151551
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On Oct. 4, 2016, 11:46 p.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52535/
> ---
> 
> (Updated Oct. 4, 2016, 11:46 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi 
> Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18534
> https://issues.apache.org/jira/browse/AMBARI-18534
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Navigate to Storm configs page
> - Type "hook" in the property filter
> - Its expected that Advanced storm-atlas-application.properties panel opens 
> up by default
> - Actual: its still closed. please see the screenshot attached
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/configs/service_configs_by_category_view.js 
> 3eebfea 
> 
> Diff: https://reviews.apache.org/r/52535/diff/
> 
> 
> Testing
> ---
> 
> Verified manually.
> Ambari-web unit test pass.
> 30374 tests complete (27 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 52566: Remove Unnecessary Locks Inside Of Host Business Object Implementations

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52566/
---

(Updated Oct. 5, 2016, 4:17 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and 
Sid Wagle.


Changes
---

Uploaded wrong patch


Bugs: AMBARI-18539
https://issues.apache.org/jira/browse/AMBARI-18539


Repository: ambari


Description
---

As part of AMBARI-18456, removing unnecessary locks in Host business objects. 

The reason that the locks were being used is because we were storing the state 
(HostEntity and HostStateEntity) in memory. There are even comments about why 
this is bad to do (yet we were doing it).

- Removed most locks
- Removed state
- Constructor persists new entities
- No longer need to call persist() externally


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ConfigGroupHostMappingDAO.java
 71d93cc 
  ambari-server/src/main/java/org/apache/ambari/server/state/Host.java bd3f8bf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 7b119f2 
  
ambari-server/src/main/java/org/apache/ambari/server/state/host/HostFactory.java
 5cfbbef 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
91b6360 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 b3e3941 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
 b212e93 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
 bf9d0db 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java
 fa51f91 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
 6e3f2e0 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatTestHelper.java
 e813e66 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
 d121fcb 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/InstallPackagesCheckTest.java
 080ca3a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 e82900d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 197b925 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java
 73b5b75 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java
 2512bb3 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
 9f610f9 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java
 2721731 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
 139702c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 63892cf 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
 eccc1ed 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedStateTest.java
 0d7fc67 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/FlumeServiceCalculatedStateTest.java
 1bc4214 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedStateTest.java
 35a7b67 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedStateTest.java
 a562962 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedStateTest.java
 ddf1503 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedStateTest.java
 7e1595e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/YarnServiceCalculatedStateTest.java
 b5cce0e 
  ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 
ce86f83 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
 9135732 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
f605276 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
 207b4c7 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
 5462f7b 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 50ce7b4 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java 
d8b6a83 
  

Re: Review Request 52551: Update Mirosoft R version in mpack

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52551/#review151549
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 5, 2016, 12:31 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52551/
> ---
> 
> (Updated Oct. 5, 2016, 12:31 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18537
> https://issues.apache.org/jira/browse/AMBARI-18537
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Microsoft R Server version to 8.0.5 and correct repo version to 8.0
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/kerberos.json
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/metainfo.xml
>  709929e 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/files/microsoft_r_serviceCheck.r
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/microsoft_r.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params_linux.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params_windows.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  58f0dbe 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/metainfo.xml
>  0c69b61 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml
>  687643b 
>   contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json 
> 52363d1 
> 
> Diff: https://reviews.apache.org/r/52551/diff/
> 
> 
> Testing
> ---
> 
> Manually tested installing the mpack
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/#review151547
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 30, 2016, 12:39 a.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51815/
> ---
> 
> (Updated Sept. 30, 2016, 12:39 a.m.)
> 
> 
> Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo  
> Marron, Laszlo Puskas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18355
> https://issues.apache.org/jira/browse/AMBARI-18355
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently stack definitions do not list conditional dependencies, adding 
> those to the stack definitions would make it easy to validate errors in case 
> of blueprint deployment. Please refer to document attached to Jira
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java
>  e3db662 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  a5f33ff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 65d166a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  b1de8ef 
> 
> Diff: https://reviews.apache.org/r/51815/diff/
> 
> 
> Testing
> ---
> 
> Written Junit test cases. Perfomred manual testing to check the Namenode HA 
> component dependency. Was able to proceed with the installation for valid 
> blueprint. and got validation error message while registering blueprint when 
> the Blueprint did not satisfy the conditional dependencies.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52485/#review151548
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 4, 2016, 12:43 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52485/
> ---
> 
> (Updated Oct. 4, 2016, 12:43 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jayush Luniya, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18516
> https://issues.apache.org/jira/browse/AMBARI-18516
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a service is added to a stack, it should be identified as:
> default/regular - service is optional on the cluster, UI usually shows it as
> tech-preview - service may be deployed, UI will not auto-select these 
> services and mark them as TechPreview
> mandatory - service need to be deployed and all deployment should fail is the 
> service is not selected during deployment
> Lets create a proposal of what changes are needed in the services' 
> metainfo.xml? Note that a service can change its attribute between stack 
> versions - e.g. move from "tech-preview" to "mandatory".
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  5865e20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  16713dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> 34e65c3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> b0d81c3 
>   ambari-server/src/main/resources/properties.json eb27878 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java
>  a9a8fdb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java
>  1754cbb 
> 
> Diff: https://reviews.apache.org/r/52485/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 52566: Remove Unnecessary Locks Inside Of Host Business Object Implementations

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52566/
---

Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and 
Sid Wagle.


Bugs: AMBARI-18539
https://issues.apache.org/jira/browse/AMBARI-18539


Repository: ambari


Description
---

As part of AMBARI-18456, removing unnecessary locks in Host business objects. 

The reason that the locks were being used is because we were storing the state 
(HostEntity and HostStateEntity) in memory. There are even comments about why 
this is bad to do (yet we were doing it).

- Removed most locks
- Removed state
- Constructor persists new entities
- No longer need to call persist() externally


Diffs
-

  ambari-project/pom.xml 4f045fe 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5e498f0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 d37e32b 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
d141df8 
  ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
2d859b3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 a6f0a3b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 6318545 
  ambari-server/src/main/java/org/apache/ambari/server/utils/RetryHelper.java 
877e84d 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java
 dd741e9 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
 299002b 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatTestHelper.java
 6fc6892 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 aa7ef20 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterServiceTest.java
 c36f5fe 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java
 93d261b 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 7e6a056 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
 c7261ea 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
de2d292 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java
 4edfdcb 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ConfigGroupDAOTest.java
 33e2636 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java
 9d390a9 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/SettingDAOTest.java
 77f87be 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetDAOTest.java 
080558a 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAOTest.java
 5b9ea6a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java 
02ce9fb 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
 37a48f0 
  
ambari-server/src/test/java/org/apache/ambari/server/state/RequestExecutionTest.java
 a5b0e5a5 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
 ec01b80 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java
 2aaa2cf 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 b99277d 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java 
5d39841 

Diff: https://reviews.apache.org/r/52566/diff/


Testing
---

PENDING


Thanks,

Jonathan Hurley

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/#review151543
---


Ship it!




Ship It!

- Robert Levas


On Oct. 5, 2016, 12:38 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52532/
> ---
> 
> (Updated Oct. 5, 2016, 12:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Robert 
> Levas, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18532
> https://issues.apache.org/jira/browse/AMBARI-18532
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ERROR 1071 (42000): Specified key was too long; max key length is 1000 bytes
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569 
> 
> Diff: https://reviews.apache.org/r/52532/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52562: ADDENDUM. Categorize unit tests so can run mvn test -P $PROFILE

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52562/#review151538
---


Ship it!




Ship It!

- Aravindan Vijayan


On Oct. 5, 2016, 6:12 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52562/
> ---
> 
> (Updated Oct. 5, 2016, 6:12 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14439
> https://issues.apache.org/jira/browse/AMBARI-14439
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Categorize the unit tests so we that "mvn test -P $PROFILE" command can run 
> only the desired category in order to run the tests faster.
> 
> This addendum patch is so that we can compile Ambari Metrics independently, 
> which has a dependency on the utility project.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/pom.xml 02dd5e7 
>   pom.xml 219943a 
>   utility/pom.xml c98e2ed 
> 
> Diff: https://reviews.apache.org/r/52562/diff/
> 
> 
> Testing
> ---
> 
> cd ambari-metrics
> mvn clean package -DskipTests
> mvn clean test
> cd ..
> mvn clean package -DskipTests
> mvn clean test -P $PROFILE_NAME
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

[Vitalyi Brodetskyi]

> On Жов. 5, 2016, 5:30 після полудня, Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 39
> > 
> >
> > Fundamenetally, if we can't create varchar longer than 1000 bytes 
> > that's a big problem.
> > 
> > What's the root cause? Which environment was this seen on?
> 
> Alejandro Fernandez wrote:
> Fundamentally*

This problem was discovered a long time ago. Mysql has limitation for 
PK,FK,indexes for 1000bytes. So, for example, if you will use two varchar(255) 
fields in PK and charset for db is UTF8 then you will get limit error. It's 
default mysql configuration and it's not so easy to change it. We already fixed 
this issues some time ago.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/#review151520
---


On Жов. 5, 2016, 4:38 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52532/
> ---
> 
> (Updated Жов. 5, 2016, 4:38 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Robert 
> Levas, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18532
> https://issues.apache.org/jira/browse/AMBARI-18532
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ERROR 1071 (42000): Specified key was too long; max key length is 1000 bytes
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569 
> 
> Diff: https://reviews.apache.org/r/52532/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 52562: ADDENDUM. Categorize unit tests so can run mvn test -P $PROFILE

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52562/
---

Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-14439
https://issues.apache.org/jira/browse/AMBARI-14439


Repository: ambari


Description
---

Categorize the unit tests so we that "mvn test -P $PROFILE" command can run 
only the desired category in order to run the tests faster.

This addendum patch is so that we can compile Ambari Metrics independently, 
which has a dependency on the utility project.


Diffs
-

  ambari-metrics/pom.xml 02dd5e7 
  pom.xml 219943a 
  utility/pom.xml c98e2ed 

Diff: https://reviews.apache.org/r/52562/diff/


Testing
---

cd ambari-metrics
mvn clean package -DskipTests
mvn clean test
cd ..
mvn clean package -DskipTests
mvn clean test -P $PROFILE_NAME


Thanks,

Alejandro Fernandez

Re: Review Request 52482: Optimize ClustersDeadlockTest

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52482/#review151522
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 5, 2016, 7:26 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52482/
> ---
> 
> (Updated Oct. 5, 2016, 7:26 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18513
> https://issues.apache.org/jira/browse/AMBARI-18513
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Test Count Time (s)
> 
> org.apache.ambari.server.agent.TestHeartbeatHandler
> 
> 24
> 
> 63.327
> 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest
> 
> 17
> 
> 48.005
> 
> org.apache.ambari.server.controller.internal.JMXHostProviderTest
> 
> 10
> 
> 35.514
> 
> org.apache.ambari.server.configuration.RecoveryConfigHelperTest
> 
> 8
> 
> 30.128
> 
> org.apache.ambari.server.state.cluster.ClustersDeadlockTest
> 
> 3
> 
> 68.167
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java
>  a0a6444 
> 
> Diff: https://reviews.apache.org/r/52482/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

[Alejandro Fernandez]

> On Oct. 5, 2016, 5:30 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 39
> > 
> >
> > Fundamenetally, if we can't create varchar longer than 1000 bytes 
> > that's a big problem.
> > 
> > What's the root cause? Which environment was this seen on?

Fundamentally*


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/#review151520
---


On Oct. 5, 2016, 4:38 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52532/
> ---
> 
> (Updated Oct. 5, 2016, 4:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Robert 
> Levas, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18532
> https://issues.apache.org/jira/browse/AMBARI-18532
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ERROR 1071 (42000): Specified key was too long; max key length is 1000 bytes
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569 
> 
> Diff: https://reviews.apache.org/r/52532/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/#review151520
---




ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql (line 39)


Fundamenetally, if we can't create varchar longer than 1000 bytes that's a 
big problem.

What's the root cause? Which environment was this seen on?


- Alejandro Fernandez


On Oct. 5, 2016, 4:38 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52532/
> ---
> 
> (Updated Oct. 5, 2016, 4:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Robert 
> Levas, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18532
> https://issues.apache.org/jira/browse/AMBARI-18532
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ERROR 1071 (42000): Specified key was too long; max key length is 1000 bytes
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569 
> 
> Diff: https://reviews.apache.org/r/52532/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52504/#review151518
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
 (line 170)


You can set this to null and use StringUtils.isBlank() check



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
 (line 185)


StringUtils.isBlank()


- Jonathan Hurley


On Oct. 4, 2016, 4:38 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52504/
> ---
> 
> (Updated Oct. 4, 2016, 4:38 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18521
> https://issues.apache.org/jira/browse/AMBARI-18521
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack changes required while upgrading to stack 2.5 in secure env
> - Remove adding spnego principal value to 
> ranger-admin-site/ranger.spnego.kerberos.principal
> - Get storm principal bare name and update it accordingly to 
> ranger-admin-site.xml/ranger.plugins.storm.serviceuser
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
>  c3d71c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java
>  133a9e3 
> 
> Diff: https://reviews.apache.org/r/52504/diff/
> 
> 
> Testing
> ---
> 
> mvn -DskipPythonTests -Dtest=RangerKerberosConfigCalculationTest test
> ---
>  T E S T S
> ---
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
> support was removed in 8.0
> Running 
> org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec - 
> in 
> org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
> 
> Results :
> 
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 47.998 s
> [INFO] Finished at: 2016-10-04T06:15:35+00:00
> [INFO] Final Memory: 67M/1203M
> [INFO] 
> 
> 
> 
> Tested Ranger EU from 2.4 to 2.5 stack in secure env on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/
---

(Updated Жов. 5, 2016, 4:38 після полудня)


Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Robert 
Levas, Sumit Mohanty, and Sid Wagle.


Summary (updated)
-

Getting errors with max length 1000byte, when using Mysql db with charset UTF8


Bugs: AMBARI-18532
https://issues.apache.org/jira/browse/AMBARI-18532


Repository: ambari


Description (updated)
---

ERROR 1071 (42000): Specified key was too long; max key length is 1000 bytes


Diffs
-

  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569 

Diff: https://reviews.apache.org/r/52532/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/#review151507
---



That happened to the change to the `blueprint_setting` table?  Was the latest 
revision (3) a mistake?

- Robert Levas


On Oct. 5, 2016, 11:29 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52532/
> ---
> 
> (Updated Oct. 5, 2016, 11:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Robert 
> Levas, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18532
> https://issues.apache.org/jira/browse/AMBARI-18532
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> blueprint_setting table incorrectly defines blueprint_name column in DDL for 
> MySQL:
> 
> {code:title=Current Definition}
> CREATE TABLE blueprint_setting (
>   id BIGINT NOT NULL,
>   blueprint_name VARCHAR(100) NOT NULL,
>   setting_name VARCHAR(100) NOT NULL,
>   setting_data MEDIUMTEXT NOT NULL,
>   CONSTRAINT PK_blueprint_setting PRIMARY KEY (id),
>   CONSTRAINT UQ_blueprint_setting_name UNIQUE(blueprint_name,setting_name),
>   CONSTRAINT FK_blueprint_setting_name FOREIGN KEY (blueprint_name) 
> REFERENCES blueprint(blueprint_name));
> {code}
> 
> {code:title=Correct Definition}
> CREATE TABLE blueprint_setting (
>   id BIGINT NOT NULL,
>   blueprint_name VARCHAR(255) NOT NULL,
>   setting_name VARCHAR(100) NOT NULL,
>   setting_data MEDIUMTEXT NOT NULL,
>   CONSTRAINT PK_blueprint_setting PRIMARY KEY (id),
>   CONSTRAINT UQ_blueprint_setting_name UNIQUE(blueprint_name,setting_name),
>   CONSTRAINT FK_blueprint_setting_name FOREIGN KEY (blueprint_name) 
> REFERENCES blueprint(blueprint_name));
> {code}
> 
> This will cause errors when creating the table while MySQL sets up the 
> foreign key constraint due to the column mismatch.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569 
> 
> Diff: https://reviews.apache.org/r/52532/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/
---

(Updated Жов. 5, 2016, 3:28 після полудня)


Review request for Ambari, Alejandro Fernandez, Robert Levas, Sumit Mohanty, 
and Sid Wagle.


Bugs: AMBARI-18532
https://issues.apache.org/jira/browse/AMBARI-18532


Repository: ambari


Description
---

blueprint_setting table incorrectly defines blueprint_name column in DDL for 
MySQL:

{code:title=Current Definition}
CREATE TABLE blueprint_setting (
  id BIGINT NOT NULL,
  blueprint_name VARCHAR(100) NOT NULL,
  setting_name VARCHAR(100) NOT NULL,
  setting_data MEDIUMTEXT NOT NULL,
  CONSTRAINT PK_blueprint_setting PRIMARY KEY (id),
  CONSTRAINT UQ_blueprint_setting_name UNIQUE(blueprint_name,setting_name),
  CONSTRAINT FK_blueprint_setting_name FOREIGN KEY (blueprint_name) REFERENCES 
blueprint(blueprint_name));
{code}

{code:title=Correct Definition}
CREATE TABLE blueprint_setting (
  id BIGINT NOT NULL,
  blueprint_name VARCHAR(255) NOT NULL,
  setting_name VARCHAR(100) NOT NULL,
  setting_data MEDIUMTEXT NOT NULL,
  CONSTRAINT PK_blueprint_setting PRIMARY KEY (id),
  CONSTRAINT UQ_blueprint_setting_name UNIQUE(blueprint_name,setting_name),
  CONSTRAINT FK_blueprint_setting_name FOREIGN KEY (blueprint_name) REFERENCES 
blueprint(blueprint_name));
{code}

This will cause errors when creating the table while MySQL sets up the foreign 
key constraint due to the column mismatch.


Diffs (updated)
-

  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569 

Diff: https://reviews.apache.org/r/52532/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 52554: AMBARI-18527 HostCleanup.py to be able to resolve wildcards in a dir or file path to a list of dirs and files

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52554/#review151506
---


Ship it!




Ship It!

- Tim Thorpe


On Oct. 5, 2016, 2:46 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52554/
> ---
> 
> (Updated Oct. 5, 2016, 2:46 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18527
> https://issues.apache.org/jira/browse/AMBARI-18527
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HostCleanup.py to be able to resolve wildcards in a dir or file path to a 
> list of dirs and files
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py a3c72e6 
> 
> Diff: https://reviews.apache.org/r/52554/diff/
> 
> 
> Testing
> ---
> 
> existing unit test
> patch a trunk cluster, install the cluster, then run HostCleanup.py while 
> feeding it with two .ini file for basic host clean up.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 52555: AMBARI-18535 Ambari is not picking up the latest repo for HDP-2.4

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52555/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-18535
https://issues.apache.org/jira/browse/AMBARI-18535


Repository: ambari


Description
---

During fresh deployment, if HDP-2.4 is chosen then Ambari does not default to 
the latest 2.4 release, HDP-2.4.2. This is likely because VDF files do not 
exist for HDP-2.4 release and the older mechanism of picking the latest repo 
URL form the hdp_urlinfo.json does not work. HDP-2.4.0 is chosen where as the 
latest is HDP-2.4.2


Diffs
-

  ambari-web/app/controllers/installer.js f8f70a0 

Diff: https://reviews.apache.org/r/52555/diff/


Testing
---

Local ambari-web test passed.
30374 tests complete (27 seconds)
151 tests pending
Manual testing done


Thanks,

Zhe (Joe) Wang

Review Request 52554: AMBARI-18527 HostCleanup.py to be able to resolve wildcards in a dir or file path to a list of dirs and files

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52554/
---

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-18527
https://issues.apache.org/jira/browse/AMBARI-18527


Repository: ambari


Description
---

HostCleanup.py to be able to resolve wildcards in a dir or file path to a list 
of dirs and files


Diffs
-

  ambari-agent/src/main/python/ambari_agent/HostCleanup.py a3c72e6 

Diff: https://reviews.apache.org/r/52554/diff/


Testing
---

existing unit test
patch a trunk cluster, install the cluster, then run HostCleanup.py while 
feeding it with two .ini file for basic host clean up.


Thanks,

Di Li

Re: Review Request 52340: Refactor solr layer in logsearch

[Oliver Szabo]

> On Oct. 4, 2016, 9:36 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractConverterAware.java,
> >  line 42
> > 
> >
> > A cast like this seems to imply that the ConversionService interface 
> > should handle this "addConverter" method, since the else condition 
> > indicates that it is a failure if the type doesn't support the registry's 
> > interface.
> 
> Oliver Szabo wrote:
> ConversionServiceFactoryBean creates a ConversionService, actually it 
> will be DefaultConversionService which will have the addConverter method, 
> injecting DefaultConversionService can work here as well, but honestly its 
> more clear for me to use the interfaces anywhere I can. Inside 
> ApplicationConfig.java, i can add the converters manually with 
> ConversionServiceFactoryBean, but that is a more dynamic workaround (if we 
> add a new converter, that will be added to the conversionService without 
> change that in the configuration as well)

i will fix the first issue in https://reviews.apache.org/r/52553


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52340/#review151225
---


On Oct. 3, 2016, 9:58 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52340/
> ---
> 
> (Updated Oct. 3, 2016, 9:58 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18310
> https://issues.apache.org/jira/browse/AMBARI-18310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - remove more unused endpoints + code
> - introduce freemarker (using for download files)
> - remove @Component and @Qualifier annotations
> - remove Criteria (+ Criteria converter) layer
> - convert request directly to solr queries
> - get rid of QueryGeneration + QueryGenerationBase classes (keep 
> GraphGenerator class , that is the response converter layer now)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml a1d1bfc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  9682a3d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  d9d3b86 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogType.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageData.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
>  786cf99 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/VResponse.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  b279a83 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
>  7508fb1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractAuditLogRequestQueryConverter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractConverterAware.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractDateRangeFacetQueryConverter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestQueryConverter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractOperationHolderConverter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractServiceLogRequestQueryConverter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditBarGraphRequestQueryConverter.java
>  PRE-CREATION 
>   
> 

Review Request 52553: Fix regression issues for logsearch refactor

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52553/
---

Review request for Ambari, Miklos Gergely and Robert Nettleton.


Bugs: AMBARI-18310
https://issues.apache.org/jira/browse/AMBARI-18310


Repository: ambari


Description
---

- fix escaping issues for searches (spring solr data related)
- do not include iMessage query in all UI request
- handle unknown json properties on ambari server side in logsearch response
- fix null pointer when no log level selected on the UI


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractAuditLogRequestQueryConverter.java
 e4bce01 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/BaseServiceLogRequestQueryConverter.java
 4894bfb 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 d9a9464 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 6e319da 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
 d6ceca5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
 51a0dda 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditTabLayoutView.js
 371edd2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/HierarchyTabLayoutView.js
 c504afa 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
 2d39e36 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/BaseServiceLogRequestQueryConverterTest.java
 1ade3c0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogLevelQueryResponse.java
 1280877 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogQueryResponse.java
 9bde7a5 

Diff: https://reviews.apache.org/r/52553/diff/


Testing
---

testing done.


Thanks,

Oliver Szabo

Re: Review Request 52551: Update Mirosoft R version in mpack

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52551/#review151497
---


Ship it!




Ship It!

- Attila Doroszlai


On Oct. 5, 2016, 2:31 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52551/
> ---
> 
> (Updated Oct. 5, 2016, 2:31 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18537
> https://issues.apache.org/jira/browse/AMBARI-18537
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Microsoft R Server version to 8.0.5 and correct repo version to 8.0
> 
> 
> Diffs
> -
> 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/kerberos.json
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/metainfo.xml
>  709929e 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/files/microsoft_r_serviceCheck.r
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/microsoft_r.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params_linux.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params_windows.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  58f0dbe 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/metainfo.xml
>  0c69b61 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml
>  687643b 
>   contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json 
> 52363d1 
> 
> Diff: https://reviews.apache.org/r/52551/diff/
> 
> 
> Testing
> ---
> 
> Manually tested installing the mpack
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 52551: Update Mirosoft R version in mpack

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52551/
---

Review request for Ambari, Attila Doroszlai, Jayush Luniya, and Sebastian 
Toader.


Bugs: AMBARI-18537
https://issues.apache.org/jira/browse/AMBARI-18537


Repository: ambari


Description
---

Update Microsoft R Server version to 8.0.5 and correct repo version to 8.0


Diffs
-

  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/kerberos.json
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/metainfo.xml
 709929e 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/files/microsoft_r_serviceCheck.r
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/microsoft_r.py
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params.py
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params_linux.py
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params_windows.py
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
 58f0dbe 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/metainfo.xml
 0c69b61 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml
 687643b 
  contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json 
52363d1 

Diff: https://reviews.apache.org/r/52551/diff/


Testing
---

Manually tested installing the mpack


Thanks,

Balázs Bence Sári

Re: Review Request 52482: Optimize ClustersDeadlockTest

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52482/
---

(Updated Oct. 5, 2016, 11:26 a.m.)


Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi.


Summary (updated)
-

Optimize ClustersDeadlockTest


Bugs: AMBARI-18513
https://issues.apache.org/jira/browse/AMBARI-18513


Repository: ambari


Description
---

Test Count Time (s)

org.apache.ambari.server.agent.TestHeartbeatHandler

24

63.327

org.apache.ambari.server.state.alerts.AlertReceivedListenerTest

17

48.005

org.apache.ambari.server.controller.internal.JMXHostProviderTest

10

35.514

org.apache.ambari.server.configuration.RecoveryConfigHelperTest

8

30.128

org.apache.ambari.server.state.cluster.ClustersDeadlockTest

3

68.167


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java
 a0a6444 

Diff: https://reviews.apache.org/r/52482/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/#review151487
---



Please test changes with different default encodings for MySQL. Theres limit 
for complex key size in bytes, but in varchar length depends on encoding.

- Myroslav Papirkovskyy


On Жов. 5, 2016, 1:40 до полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52532/
> ---
> 
> (Updated Жов. 5, 2016, 1:40 до полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sumit Mohanty, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18532
> https://issues.apache.org/jira/browse/AMBARI-18532
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> blueprint_setting table incorrectly defines blueprint_name column in DDL for 
> MySQL:
> 
> {code:title=Current Definition}
> CREATE TABLE blueprint_setting (
>   id BIGINT NOT NULL,
>   blueprint_name VARCHAR(100) NOT NULL,
>   setting_name VARCHAR(100) NOT NULL,
>   setting_data MEDIUMTEXT NOT NULL,
>   CONSTRAINT PK_blueprint_setting PRIMARY KEY (id),
>   CONSTRAINT UQ_blueprint_setting_name UNIQUE(blueprint_name,setting_name),
>   CONSTRAINT FK_blueprint_setting_name FOREIGN KEY (blueprint_name) 
> REFERENCES blueprint(blueprint_name));
> {code}
> 
> {code:title=Correct Definition}
> CREATE TABLE blueprint_setting (
>   id BIGINT NOT NULL,
>   blueprint_name VARCHAR(255) NOT NULL,
>   setting_name VARCHAR(100) NOT NULL,
>   setting_data MEDIUMTEXT NOT NULL,
>   CONSTRAINT PK_blueprint_setting PRIMARY KEY (id),
>   CONSTRAINT UQ_blueprint_setting_name UNIQUE(blueprint_name,setting_name),
>   CONSTRAINT FK_blueprint_setting_name FOREIGN KEY (blueprint_name) 
> REFERENCES blueprint(blueprint_name));
> {code}
> 
> This will cause errors when creating the table while MySQL sets up the 
> foreign key constraint due to the column mismatch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  ebfb267 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
>  PRE-CREATION 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52532/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52549: Components can't be started because of failed webhdfs request

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52549/#review151484
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 5, 2016, 10:03 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52549/
> ---
> 
> (Updated Жов. 5, 2016, 10:03 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18536
> https://issues.apache.org/jira/browse/AMBARI-18536
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Different components fail to start, for instance:
> 
> 
> 
> 
> Traceback (most recent call last):\n  File 
> \"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py\",
>  line 182, in \nHistoryServer().execute()\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
>  line 219, in execute\nmethod(env)\n  File 
> \"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py\",
>  line 100, in start\nhost_sys_prepped=params.host_sys_prepped)\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py\",
>  line 204, in copy_to_hdfs\n
> replace_existing_files=replace_existing_files,\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/base.py\", line 
> 154, in __init__\nself.env.run()\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
> line 160, in run\nself.run_action(resource, action)\n  File 
> \"/usr/lib/python2.6/site-packages/resource_ma
 nagement/core/environment.py\", line 124, in run_action\n
provider_action()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 463, in action_create_on_execute\nself.action_delayed(\"create\")\n  
File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 460, in action_delayed\n
self.get_hdfs_resource_executor().action_delayed(action_name, self)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 258, in action_delayed\nself._create_resource()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 272, in _create_resource\n
self._create_file(self.main_resource.resource.target, 
source=self.main_resource.resource.source, mode=self.mode)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 325, in _create_f
 ile\nself.util.run_command(target, 'CREATE', method='PUT', overwrite=True, 
assertable_result=False, file_to_put=source, **kwargs)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 182, in run_command\n_, out, err = get_user_call_output(cmd, 
user=self.run_user, logoutput=self.logoutput, quiet=False)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/get_user_call_output.py\",
 line 61, in get_user_call_output\nraise 
Fail(err_msg)\nresource_management.core.exceptions.Fail: Execution of 'curl -sS 
-L -w '%{http_code}' -X PUT --data-binary 
@/usr/hdp/2.4.3.0-227/hadoop/mapreduce.tar.gz --negotiate -u : 
'http://nat-r6-tzrs-ambari-alerts-1.openstacklocal:50070/webhdfs/v1/hdp/apps/2.4.3.0-227/mapreduce/mapreduce.tar.gz?op=CREATE=cstm-hdfs=True=444'
 1>/tmp/tmpNxSlRa 2>/tmp/tmpXlLRgB' returned 52. curl: (52) Empty reply from 
server\n100
> 
> 
> 
> Traceback (most recent call last):\n  File 
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py\",
>  line 165, in \nFalconServer().execute()\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
>  line 219, in execute\nmethod(env)\n  File 
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py\",
>  line 46, in start\nself.configure(env, upgrade_type=upgrade_type)\n  
> File 
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py\",
>  line 41, in configure\nfalcon('server', action='config', 
> upgrade_type=upgrade_type)\n  File 
> \"/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py\", line 
> 89, in thunk\nreturn fn(*args, **kwargs)\n  File 
> \"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py\",
>  line 127, in falcon\nmode = 0777)\n  File \"/usr/lib/python2.6
 /site-packages/resource_management/core/base.py\", line 

Review Request 52549: Components can't be started because of failed webhdfs request

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52549/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-18536
https://issues.apache.org/jira/browse/AMBARI-18536


Repository: ambari


Description
---

Different components fail to start, for instance:




Traceback (most recent call last):\n  File 
\"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py\",
 line 182, in \nHistoryServer().execute()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
 line 219, in execute\nmethod(env)\n  File 
\"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py\",
 line 100, in start\nhost_sys_prepped=params.host_sys_prepped)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py\",
 line 204, in copy_to_hdfs\n
replace_existing_files=replace_existing_files,\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/base.py\", line 
154, in __init__\nself.env.run()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 160, in run\nself.run_action(resource, action)\n  File 
\"/usr/lib/python2.6/site-packages/resource_mana
 gement/core/environment.py\", line 124, in run_action\nprovider_action()\n 
 File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 463, in action_create_on_execute\nself.action_delayed(\"create\")\n  
File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 460, in action_delayed\n
self.get_hdfs_resource_executor().action_delayed(action_name, self)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 258, in action_delayed\nself._create_resource()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 272, in _create_resource\n
self._create_file(self.main_resource.resource.target, 
source=self.main_resource.resource.source, mode=self.mode)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 325, in _create_fil
 e\nself.util.run_command(target, 'CREATE', method='PUT', overwrite=True, 
assertable_result=False, file_to_put=source, **kwargs)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 182, in run_command\n_, out, err = get_user_call_output(cmd, 
user=self.run_user, logoutput=self.logoutput, quiet=False)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/get_user_call_output.py\",
 line 61, in get_user_call_output\nraise 
Fail(err_msg)\nresource_management.core.exceptions.Fail: Execution of 'curl -sS 
-L -w '%{http_code}' -X PUT --data-binary 
@/usr/hdp/2.4.3.0-227/hadoop/mapreduce.tar.gz --negotiate -u : 
'http://nat-r6-tzrs-ambari-alerts-1.openstacklocal:50070/webhdfs/v1/hdp/apps/2.4.3.0-227/mapreduce/mapreduce.tar.gz?op=CREATE=cstm-hdfs=True=444'
 1>/tmp/tmpNxSlRa 2>/tmp/tmpXlLRgB' returned 52. curl: (52) Empty reply from 
server\n100



Traceback (most recent call last):\n  File 
\"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py\",
 line 165, in \nFalconServer().execute()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
 line 219, in execute\nmethod(env)\n  File 
\"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py\",
 line 46, in start\nself.configure(env, upgrade_type=upgrade_type)\n  File 
\"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py\",
 line 41, in configure\nfalcon('server', action='config', 
upgrade_type=upgrade_type)\n  File 
\"/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py\", line 89, 
in thunk\nreturn fn(*args, **kwargs)\n  File 
\"/var/lib/ambari-agent/cache/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py\",
 line 127, in falcon\nmode = 0777)\n  File \"/usr/lib/python2.6/s
 ite-packages/resource_management/core/base.py\", line 154, in __init__\n
self.env.run()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 160, in run\nself.run_action(resource, action)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 124, in run_action\nprovider_action()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\",
 line 463, in action_create_on_execute\nself.action_delayed(\"create\")\n