Re: Review Request 53506: AMBARI-18761 NTP check fails even if chrony is working on CentOS7

2016-11-05 Thread Masahiro Tanaka 


> On Nov. 5, 2016, 12:51 p.m., Sid Wagle wrote:
> > ambari-agent/src/main/python/ambari_agent/HostInfo.py, line 120
> > 
> >
> > This should return a ('chronyd', 'ntp') since both are valid. Need to 
> > chnage the caller to do a OR.

Thank you for reviewing Sid Wagle! I updated the patch.


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53506/#review155046
---


On Nov. 6, 2016, 10:23 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53506/
> ---
> 
> (Updated Nov. 6, 2016, 10:23 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18761
> https://issues.apache.org/jira/browse/AMBARI-18761
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I use CentOS 7 as a host OS. When the host check runs, it shows warning. The 
> warning says "The following services should be up: Service ntpd."
> I think "chrony" is a default NTP client and server on CentOS7. So We should 
> check if there are ntpd or chronyd on a host.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 3871e72 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 0c0a3b3 
> 
> Diff: https://reviews.apache.org/r/53506/diff/
> 
> 
> Testing
> ---
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12837535/AMBARI-18761.3.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/9154//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/9154//console
> This message is automatically generated.
> ```
> 
> Manual test: Installed Ambari2.4.1 on centos7, replaced HostInfo.py and 
> recheck host.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 51339: AMBARI-18196: Swagger part 2: upgrade to jersey2.x from jersey1.x

2016-11-05 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51339/
---

(Updated Nov. 5, 2016, 6:07 p.m.)


Review request for Ambari, Dharmesh Makwana, Miklos Gergely, and Robert 
Nettleton.


Changes
---

add branch-2.5


Bugs: AMBARI-18196
https://issues.apache.org/jira/browse/AMBARI-18196


Repository: ambari


Description
---

- upgrade jersey 1.x from jersey 2.x
- the goal is to use @BeanParam annotation in the endpoints, and with that i 
can get rid from the @ApiImplicitParams annotations, and use request objects 
with query fields
- refactor ExternalServerClient class (it was needed anyway, jersey 1.x classes 
were used there)


Diffs
-

  ambari-logsearch/ambari-logsearch-portal/pom.xml 8d345d9 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/ExternalServerClient.java
 32e547e 
  ambari-logsearch/ambari-logsearch-portal/src/main/webapp/WEB-INF/web.xml 
aee16bf 

Diff: https://reviews.apache.org/r/51339/diff/


Testing
---

done.


Thanks,

Oliver Szabo

Re: Review Request 51242: Restify logsearch endpoints

2016-11-05 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51242/
---

(Updated Nov. 5, 2016, 6:01 p.m.)


Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Robert Nettleton, 
and Sumit Mohanty.


Changes
---

add branch-2.5


Bugs: AMBARI-18214
https://issues.apache.org/jira/browse/AMBARI-18214


Repository: ambari


Description
---

- restify endpoints as possible
- rename dashboard to service
- there are still some endpoints what is not too resty, but that is the "vol 1" 
for refactoring. in some cases, some of the endpoints can be merged into one, 
and call a same method with just different params. for now, i kept them, i did 
not want to do any changes in the business code part. (after Miklos is ready 
with the refactoring, we can do some changes there too, and get rid some weird 
names in the API ... like verbs e.g.: /service/logs/aggregated -> it can be 
also in /service/logs endpoint and add aggregated as a query param etc.)


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 672507a 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 c1572b7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
 d4f2986 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
 b03a643 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsREST.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditREST.java
 5ed49fd 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/DashboardREST.java
 0144edc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/LogFileREST.java
 d53cff9 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/PublicREST.java
 af48acd 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsREST.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/UserConfigREST.java
 4b1675f 
  ambari-logsearch/ambari-logsearch-portal/src/main/webapp/login.html 44f1aeb 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collection_bases/VAuditLogListBase.js
 12f7c31 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collection_bases/VEventHistoryListBase.js
 f6f720d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collection_bases/VGroupListBase.js
 a34aaa3 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collection_bases/VLogLevelListBase.js
 59b5ae8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collection_bases/VLogListBase.js
 7b102d5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collection_bases/VNameValueListBase.js
 d59eaa2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collection_bases/VNodeListBase.js
 7c7dcf8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/model_bases/VAuditLogBase.js
 1283875 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/model_bases/VCommonModelBase.js
 4723e3e 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/model_bases/VEventHistoryBase.js
 c237ade 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/model_bases/VGraphInfoBase.js
 a707629 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/model_bases/VLogLevelBase.js
 0384bc2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/model_bases/VUserFilterBase.js
 35171aa 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js
 331ffd6 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditAggregatedView.js
 c04aaf9 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditTabLayoutView.js
 0b570ac 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/BubbleGraphTableLayoutView.js
 42b94d5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/ComponentListView.js
 abd3740 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/ComponentsView.js
 66cc277 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/DashboardView.js
 c3fd9c2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/GridTableLayoutView.js
 1cbdef8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/HostsView.js
 dd82130

Re: Review Request 52958: Fix Log Search User Config bug

2016-11-05 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52958/#review155056
---


Ship it!




Ship It!

- Oliver Szabo


On Oct. 18, 2016, 12:48 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52958/
> ---
> 
> (Updated Oct. 18, 2016, 12:48 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18616
> https://issues.apache.org/jira/browse/AMBARI-18616
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search User Config UI screen does not offer the chance to modify the 
> filter settings for those logs which don't have any log entries loaded so 
> far. For these logs the initial settings will be in effect until the first 
> modification of the filters when all of these settings will be erased, and 
> thus every log will be loaded for them without filtering.
> 
> The User Config UI should always show all the logs, first those which already 
> have some log entries in the solr, then the rest.
> 
> Also some minor refactoring for cleaner code.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/HadoopServiceConfigHelper.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  58337f7 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
>  45d66cf 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
>  d276769 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java
>  b09610c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/filter/CreateLogfeederFilterView.js
>  9bdf0fa 
> 
> Diff: https://reviews.apache.org/r/52958/diff/
> 
> 
> Testing
> ---
> 
> Done
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>