date:20170117

Re: Review Request 55664: AMBARI-19602:Input logic tags are missing in the coordinator xml

2017-01-17 Thread belliraj hb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55664/#review162039
---


Ship it!




Ship It!

- belliraj hb


On Jan. 18, 2017, 7:15 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55664/
> ---
> 
> (Updated Jan. 18, 2017, 7:15 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19602
> https://issues.apache.org/jira/browse/AMBARI-19602
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 'Input-logic' tags are missing in the coordinator xml.
> Steps to reproduce :
> 1) Import a coordinator xml with input logic
> 2) Preview the xml.
> 3) Check that 'input-logic' tags which are available in original xml are 
> missing in the preview xml.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> eb0d585 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
> 0979c25 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
>  9b54495 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  f906fd5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
>  b33420a 
> 
> Diff: https://reviews.apache.org/r/55664/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55664: AMBARI-19602:Input logic tags are missing in the coordinator xml

2017-01-17 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55664/#review162037
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 18, 2017, 7:15 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55664/
> ---
> 
> (Updated Jan. 18, 2017, 7:15 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19602
> https://issues.apache.org/jira/browse/AMBARI-19602
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 'Input-logic' tags are missing in the coordinator xml.
> Steps to reproduce :
> 1) Import a coordinator xml with input logic
> 2) Preview the xml.
> 3) Check that 'input-logic' tags which are available in original xml are 
> missing in the preview xml.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> eb0d585 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
> 0979c25 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
>  9b54495 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  f906fd5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
>  b33420a 
> 
> Diff: https://reviews.apache.org/r/55664/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55627: Hive view 2.0 REST and backend support for enabling and fetching table and column stats

2017-01-17 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55627/#review162036
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 17, 2017, 4:18 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55627/
> ---
> 
> (Updated Jan. 17, 2017, 4:18 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19584
> https://issues.apache.org/jira/browse/AMBARI-19584
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Info can be found at : 
> https://cwiki.apache.org/confluence/display/Hive/StatsDev#StatsDev-ColumnStatistics
> Requirements:
> 1. REST endpoint to enable statistics for a table with support for stats for 
> all columns -- done
> 2. REST endpoint to fetch table stats -- done : table stats will come with 
> table info itself
> 3. REST endpoint to fetch column stats -- done
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java
>  2876348 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableMeta.java
>  f47e76c 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java
>  5cae34a 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
>  8d995dd 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
>  e142baf 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java
>  675ea37 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/ResultsPaginationController.java
>  6efa2a9 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/viewJobs/JobImpl.java
>  85ffaf2 
>   contrib/views/hive20/src/test/rest/postman/hive20.postman_collection.json 
> d674944 
> 
> Diff: https://reviews.apache.org/r/55627/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 55664: AMBARI-19602:Input logic tags are missing in the coordinator xml

2017-01-17 Thread Padma Priya N


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55664/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19602
https://issues.apache.org/jira/browse/AMBARI-19602


Repository: ambari


Description
---

'Input-logic' tags are missing in the coordinator xml.
Steps to reproduce :
1) Import a coordinator xml with input logic
2) Preview the xml.
3) Check that 'input-logic' tags which are available in original xml are 
missing in the preview xml.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
eb0d585 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
0979c25 
  
contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
 9b54495 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
 f906fd5 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
 b33420a 

Diff: https://reviews.apache.org/r/55664/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 55614: AMBARI-19581. Need to show proper error message in scenarios of failures with asset import

2017-01-17 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55614/#review162033
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 17, 2017, 12:02 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55614/
> ---
> 
> (Updated Jan. 17, 2017, 12:02 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19581
> https://issues.apache.org/jira/browse/AMBARI-19581
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to show proper error message in scenarios of failures with asset import.
> While importing the asset for a given action node, its better to show only 
> assets belonging to that particular type.
> Steps to reproduce :
> 1) Save hive node settings as an asset.
> 2) Now try to import that setting for hive2 or node other than hive.
> 3) user is shown with the message 'Invalid asset settings'. 
> Either user should be shown only the assets of that particular type or 
> appropriate error message should be displayed as why import setting has 
> failed.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 
> 2ea82b0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> d0c05d6 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less bc0e419 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs
>  4ee6d05 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs
>  d377d2c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs
>  0fa86b0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  80af968 
> 
> Diff: https://reviews.apache.org/r/55614/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 55627: Hive view 2.0 REST and backend support for enabling and fetching table and column stats

2017-01-17 Thread DIPAYAN BHOWMICK


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55627/#review162030
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 17, 2017, 4:18 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55627/
> ---
> 
> (Updated Jan. 17, 2017, 4:18 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19584
> https://issues.apache.org/jira/browse/AMBARI-19584
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Info can be found at : 
> https://cwiki.apache.org/confluence/display/Hive/StatsDev#StatsDev-ColumnStatistics
> Requirements:
> 1. REST endpoint to enable statistics for a table with support for stats for 
> all columns -- done
> 2. REST endpoint to fetch table stats -- done : table stats will come with 
> table info itself
> 3. REST endpoint to fetch column stats -- done
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java
>  2876348 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableMeta.java
>  f47e76c 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java
>  5cae34a 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
>  8d995dd 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
>  e142baf 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java
>  675ea37 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/ResultsPaginationController.java
>  6efa2a9 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/viewJobs/JobImpl.java
>  85ffaf2 
>   contrib/views/hive20/src/test/rest/postman/hive20.postman_collection.json 
> d674944 
> 
> Diff: https://reviews.apache.org/r/55627/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling mistakes in YARN proxyuser properties in many places.

2017-01-17 Thread Sumit Mohanty



> On Jan. 17, 2017, 8:45 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json,
> >  line 26
> > 
> >
> > This is essentially changing the config name.
> > What should happen to existing clusters already Kerberized?
> > Should the propery be renamed?
> 
> Jay SenSharma wrote:
> If the property name itself is wrong in an existing cluster then i guess 
> it might not be working as expected earlier as well, because the YARN will 
> ignore those properties which are incorrect (non existing). So i think for 
> the existing clusters it needs to be corrected.
> 
> Please correct me if above statement is incorrect.

Lets open a separate JIRA to fix the properties during HDP upgrade. Chances are 
high that these clusters are fixed by the users as without the fixes they will 
see access issued.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review161941
---


On Jan. 3, 2017, 8:41 a.m., Jay SenSharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> ---
> 
> (Updated Jan. 3, 2017, 8:41 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> YARN proxyusers properties has spelling mistake. For a long time the property 
> has ".proxyusers." where as it is supposed to be ".proxyuser." Even though 
> the incorrect properties will be ignored by YARN however it should be good to 
> correct the spelling mistake on these properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
> a8379ee 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> 4cb18a9 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
> 784589c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json
>  74b5746 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
> c20bd23 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> 4cb18a9 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json 
> f33c07d 
>   
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json
>  0d0c6f5 
>   
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json 
> a9e0bcd 
>   ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24 
>   ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8 
> 
> Diff: https://reviews.apache.org/r/55129/diff/
> 
> 
> Testing
> ---
> 
> Existing testcases does not directly address this. So test not performed.
> 
> 
> Thanks,
> 
> Jay SenSharma
> 
>

Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host

2017-01-17 Thread alice alice


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/
---

(Updated 一月 18, 2017, 6:01 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, 
Zhe (Joe) Wang, Richard Zang, Sumit Mohanty, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-19557
https://issues.apache.org/jira/browse/AMBARI-19557


Repository: ambari


Description
---

http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_Install_Guide/content/ch03s01.html??
The Ranger Admin and Ranger Usersync services must be installed on the same 
cluster node.
so we'd betted install ranger_admin and ranger_usersync in same cluster node in 
instaling at managing master hostcomponent


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml 
92527c3 

Diff: https://reviews.apache.org/r/6/diff/


Testing
---

done it


Thanks,

alice alice

Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host

2017-01-17 Thread alice alice



> On 一月 17, 2017, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-web/app/models/stack_service_component.js, line 200
> > 
> >
> > The standard is to provide that information in the metainfo file for 
> > several good reasons.
> > * Support multiple stacks which may have differences in behavior
> > * Support multiple versions of the same stack which may have 
> > differences in behavior
> > * Abstract knowledge of the web-layer having to know about Hadoop
> > 
> > I think the 2nd approach is more consistent with the rest of Ambari.
> 
> Jayush Luniya wrote:
> +1 we need to do away with UI hacks
> 
> alice zhangxiaolu wrote:
> Thanks for your reply.
> But I find the fronted javascript code can not be deleted which will 
> cause the RANGER_USERSYNC still can be assigned to the other host.
> So I will keep them .
> Besides,I will add the configuration in the 2nd approach to my patch too.
> what do you think about it?
> 
> Alejandro Fernandez wrote:
> We appreciate your contribution, but we should avoid the practice of 
> hardcoding component names in the UI; that's why the metainfo.xml file exists 
> for each component and for each version.

Thanks for your reply.
Very well, you are quite right, I will apply the second method in my patch. 
  
Centainly we will consider this feature later, which can control the display of 
front-end by adding tag to metainfo.


- alice


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/#review161910
---


On 一月 17, 2017, 2:12 a.m., alice alice wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6/
> ---
> 
> (Updated 一月 17, 2017, 2:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, 
> Zhe (Joe) Wang, Richard Zang, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19557
> https://issues.apache.org/jira/browse/AMBARI-19557
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_Install_Guide/content/ch03s01.html??
> The Ranger Admin and Ranger Usersync services must be installed on the same 
> cluster node.
> so we'd betted install ranger_admin and ranger_usersync in same cluster node 
> in instaling at managing master hostcomponent
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/stack_service_component.js 17c2aa1 
> 
> Diff: https://reviews.apache.org/r/6/diff/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> Thanks,
> 
> alice alice
> 
>

Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host

2017-01-17 Thread alice alice



> On 一月 16, 2017, 7:05 p.m., Alejandro Fernandez wrote:
> > ambari-web/app/models/stack_service_component.js, line 200
> > 
> >
> > Can this come from metainfo instead of being hardcoded on the UI?
> > 
> > Please add Jaimin Jetly for input.
> 
> alice zhangxiaolu wrote:
> As we all know, there are two ways installing relative components in same 
> host;
> 
> (1)fisrt method is as above, configs relative components in 
> stack_service_component.js.
> (2)second method is in metainfo,but cannot be shown in web. The method is 
> as follows:
> 
> 
>   true
>   RANGER/RANGER_ADMIN
> 
> 
> so suggest we can select one.
> thanks for your reply.
> 
> alice zhangxiaolu wrote:
> Please ignore my above reply : )
> 
> 
> Thanks for your reply.
> As I know, there are two ways making one component install with other in 
> same host automaticlly
> 
> The first one is to code in stack_service_component.js as I did in my 
> patch.
> The second one is to add following configuration to section  RANGER_ADMIN 
> component in metainfo.xml:
>
>   true
>   RANGER/RANGER_USERSYNC
>
> 
> The advantage of firs way is that we can see the relation in web page 
> clearly  which the second one lacks

As we know,there are two ways installing components in same host.
1.one is in stack_service_component as above;
2.two is in metainfo, but cannot show in web.as follow?
3.

  true
  RANGER/RANGER_ADMIN


so in this case,I recommend that we can select first method.
thanks for your reply.


- alice


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/#review161773
---


On 一月 17, 2017, 2:12 a.m., alice alice wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6/
> ---
> 
> (Updated 一月 17, 2017, 2:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, 
> Zhe (Joe) Wang, Richard Zang, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19557
> https://issues.apache.org/jira/browse/AMBARI-19557
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_Install_Guide/content/ch03s01.html??
> The Ranger Admin and Ranger Usersync services must be installed on the same 
> cluster node.
> so we'd betted install ranger_admin and ranger_usersync in same cluster node 
> in instaling at managing master hostcomponent
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/stack_service_component.js 17c2aa1 
> 
> Diff: https://reviews.apache.org/r/6/diff/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> Thanks,
> 
> alice alice
> 
>

Review Request 55663: Add support for call context to the stack advisor

2017-01-17 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55663/
---

Review request for Ambari, Jayush Luniya, Swapan Shridhar, and Sid Wagle.

Bugs: AMBARI-19546
https://issues.apache.org/jira/browse/AMBARI-19546

Repository: ambari

Description
---

Add support for call context to the stack advisor. This is a limited
enhancements to differentiate between basic contenxts. Most importantly cluster
create vs config edit vs add service and calls to get only the attributes.

Two key changes:
Differentiate between recommendComponentLayout, validateComponentLayout,
recommendConfigurations, recommendConfigurationDependencies, and
validateConfigurations. The key ones to differentiate are
recommendConfigurations and recommendConfigurationDependencies. This change is
committed already.

Second is to distinguish between, clusterCreate, addService, and
computeAttribute. All three are recommendConfigurations calls. Why it matters?
During clusterCreate, stack advisor is free to compute any config properties it
can. However, during addService and computeAttributes it should use supplied
configs and then compute only what is needed.

The patch has changes for blueprint deployments and the infra for UI to add the
context as needed.

Diffs
-

ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
67dfded

ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
b804c7e

ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
6f612af

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java
0ad9126
ambari-server/src/main/resources/properties.json b7e0988
ambari-server/src/main/resources/scripts/stack_advisor.py 56bd34a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
968a94f
ambari-server/src/main/resources/stacks/stack_advisor.py 6b29bc3

ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
e3b89b8
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py
f39703c

1 2 >

1 - 100 of 101 matches

Mail list logo