Review Request 56068: AMBARI-19772. Job XML tag is not coming as part of FS action node

2017-01-29 Thread Madhan Reddy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56068/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19772
https://issues.apache.org/jira/browse/AMBARI-19772


Repository: ambari


Description
---

Added job-xml mapping to fs action node


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
c9d9887 

Diff: https://reviews.apache.org/r/56068/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 56010: AMBARI-19709:XML generated for bundle's is not as per oozie xsd

2017-01-29 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56010/#review163475
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 27, 2017, 9:43 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56010/
> ---
> 
> (Updated Jan. 27, 2017, 9:43 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-19709
> https://issues.apache.org/jira/browse/AMBARI-19709
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified the tag control to controls as per the bundle xsd
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> e29935c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-generator.js
>  7dc05a9 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js
>  a2053c9 
> 
> Diff: https://reviews.apache.org/r/56010/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56031: Hive2 View - Switching tabs after executing query loses state

2017-01-29 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56031/#review163473
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 27, 2017, 6:42 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56031/
> ---
> 
> (Updated Jan. 27, 2017, 6:42 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19753
> https://issues.apache.org/jira/browse/AMBARI-19753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added a model parameter to save isQueryRunning state.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 23f16b0 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 2ecf967 
> 
> Diff: https://reviews.apache.org/r/56031/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56051: Workflow Manager View : Separate log file into its own directory similar to other views

2017-01-29 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56051/#review163469
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 28, 2017, 8:32 a.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56051/
> ---
> 
> (Updated Jan. 28, 2017, 8:32 a.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore.
> 
> 
> Bugs: AMBARI-19763
> https://issues.apache.org/jira/browse/AMBARI-19763
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Workflow manager view logs entries are currently in the ambari-server.log.
> It should be separated into its own folder under /var/log/ambari-server 
> similar to the other views.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/pom.xml 8016d7b 
>   contrib/views/wfmanager/src/main/resources/view.log4j.properties 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56051/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> Verified that the Workflow Manager view logs are written to 
> wfmanager-view.log under /var/log/ambari-server/wfmanager-view
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 55923: AMBARI-19604:Need to perform sanity checks before starting the oozie view

2017-01-29 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55923/#review163467
---




contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js (line 99)


X-Requested-By is generally set to 'ambari'. is there any specific reason 
to set it to 'workflow-designer'



contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs (line 21)


Extract constants to make it i18n compliant


- Nitiraj Rathore


On Jan. 25, 2017, 11:08 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55923/
> ---
> 
> (Updated Jan. 25, 2017, 11:08 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19604
> https://issues.apache.org/jira/browse/AMBARI-19604
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added sanity checks for oozie, hdfs and user home directory
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js 
> PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 23609e9 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/design-loading.hbs
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs 
> PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/loading.hbs 
> 9f4fc79 
> 
> Diff: https://reviews.apache.org/r/55923/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56030: Hive View 2.0 execute button needs some feedback

2017-01-29 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56030/#review163466
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 27, 2017, 6:20 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56030/
> ---
> 
> (Updated Jan. 27, 2017, 6:20 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19752
> https://issues.apache.org/jira/browse/AMBARI-19752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added fontawesome animation while query is in progress.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5d7ce77 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss e178222 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 9e9e542 
> 
> Diff: https://reviews.apache.org/r/56030/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56039: Add common log rotation settings to hive log4j2

2017-01-29 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56039/#review163464
---


Ship it!




Ship It!

- Jayush Luniya


On Jan. 27, 2017, 9:51 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56039/
> ---
> 
> (Updated Jan. 27, 2017, 9:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19756
> https://issues.apache.org/jira/browse/AMBARI-19756
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add common log rotation settings to hive log4j2
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  1314a1e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  6d3455c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 1974acb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  619fa5d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  2aedfa8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  dafe8e3 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 41a3eda 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> df54835 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 981947f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> e6817f6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  34e56d3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  065c265 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 774448d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 0a0c757 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
>  abf307a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
>  67f5830 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> ddffc79 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  abb5428 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 790e50c 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 2bc28e5 
> 
> Diff: https://reviews.apache.org/r/56039/diff/
> 
> 
> Testing
> ---
> 
> Fresh install testing - API, DB, Filesystem
> Upgrade testing - 2.5->2.6
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55921: AMBARI-19610:User is not able to import the draft version for a coordinator

2017-01-29 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55921/#review163462
---




contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
 (line 100)


returning null here does not help, it will cover up some bugs somewhere 
else. throw an exception.



contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
 (line 112)


same here as well. returning null here does not help, it will cover up some 
bugs somewhere else. throw an exception.



contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
(line 356)


I don't get the idea of generating X-XSRF-HEADER on client side. CSRF 
tokens are generated on serverside and clients resend it. Also as far as I know 
ambari does not checks for this token. 
Please explain its use or remove if not required.



contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
(line 962)


there is no 'else' part to this 'if'. it may stuck the code execution.



contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
 (line 131)


extract this constant into a constants file to conform with i18n specs.



contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
 (line 346)


extract this constant into a constants file to conform with i18n specs.



contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 (line 316)


extract this constant into a constants file to conform with i18n specs.


- Nitiraj Rathore


On Jan. 25, 2017, 10:45 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55921/
> ---
> 
> (Updated Jan. 25, 2017, 10:45 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19610
> https://issues.apache.org/jira/browse/AMBARI-19610
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified backend to support import of draft versions and added methods in 
> front end to parse the imported draft version.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java
>  f7c1936 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  d029c39 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFileInfo.java
>  6dbf30e 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
>  289e68b 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java
>  7ce6081 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 2e0dadb 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> bba7793 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  422253d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> c682ea9 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 
> c6c0421 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js
>  f5eb6e7 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
>  8b42447 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  296463d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  1758946 
> 
> Diff: https://reviews.apache.org/r/55921/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56059: Preview: Package Installation fails due to error in Berkeley DB library

2017-01-29 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review163443
---




ambari-common/src/main/python/ambari_commons/shell.py (lines 116 - 117)


Will this change work when running as non-root?



ambari-common/src/main/python/ambari_commons/shell.py (lines 130 - 131)


Seems awfully specific.  Would be more flexible if we could pass in the 
kill delay as an argument whose default is 5 (the graceful_kill_delay).


- Nate Cole


On Jan. 29, 2017, 7:27 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56059/
> ---
> 
> (Updated Jan. 29, 2017, 7:27 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-19768
> https://issues.apache.org/jira/browse/AMBARI-19768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Steps*
> # Deploy HDP-2.5.0.0 with Ambari 2.4.1.0
> # Upgrade ambari to 2.5.0.0-481 (I did not register Falcon library, as the 
> jar was already present in /var/lib/ambari-server/resources/je-5.0.73.jar on 
> Ambari server node)
> # Register HDP-2.6.0.0-216
> # Start package installation
> 
> *Result:*
> Got below errors:
> {code}
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
> open failed
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|Traceback 
> (most recent call last):
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 166, in actionexecute
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|ret_code = 
> self.install_packages(package_list)
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 400, in install_packages
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|if not 
> verifyDependencies():
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
>  line 311, in verifyDependencies
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|code, out = 
> rmf_shell.checked_call(cmd, sudo=True)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|result = 
> function(command, **kwargs)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|tries=tries, 
> try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|result = 
> _call(command, **kwargs_copy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|raise 
> ExecutionFailed(err_msg, code, out, err)
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - 
> run()|ExecutionFailed: Execution of '/usr/bin/yum -d 0 -e 0 check 
> dependencies' returned 1. error: rpmdb: BDB0113 Thread/process 
> 16016/139791567193920 failed: BDB1507 Thread died in Berkeley DB library
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: db5 
> error(-30973) from dbenv->failchk: BDB0087 DB_RUNRECOVERY: Fatal error, run 
> database recovery
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
> open Packages index using db5 -  (-30973)
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
> open Packages database in /var/lib/rpm
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
> open failed
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145

Review Request 56064: Format ZKFC commands failing while enabling NameNode HA

2017-01-29 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56064/
---

Review request for Ambari, Attila Magyar, Laszlo Puskas, and Robert Levas.


Bugs: AMBARI-19736
https://issues.apache.org/jira/browse/AMBARI-19736


Repository: ambari


Description
---

Format ZKFC commands failing while enabling NameNode HA at Initializa Metadata 
step.

```
Caused by: org.apache.zookeeper.KeeperException$NoAuthException: 
KeeperErrorCode = NoAuth for /hadoop-ha/nameservice
at org.apache.zookeeper.KeeperException.create(KeeperException.java:113)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:783)
at 
org.apache.hadoop.ha.ActiveStandbyElector$3.run(ActiveStandbyElector.java:1000)
at 
org.apache.hadoop.ha.ActiveStandbyElector$3.run(ActiveStandbyElector.java:997)
at 
org.apache.hadoop.ha.ActiveStandbyElector.zkDoWithRetries(ActiveStandbyElector.java:1041)
at 
org.apache.hadoop.ha.ActiveStandbyElector.createWithRetries(ActiveStandbyElector.java:997)
at 
org.apache.hadoop.ha.ActiveStandbyElector.ensureParentZNode(ActiveStandbyElector.java:344)
... 11 more
```
 
The reason for the failure is that the `hdfs_jaas.conf` file is generated 
during ZKFC component configuration. When NN HA is enabled via UI the ZKFC is 
not added yet to the cluster thus the `hdfs_jaas.conf` file is not generated 
yet, this leading the format ZKFC commands to fail as this require the jaas 
file.

The solution is to move the creation of `hdfs_jaas.conf` file into the NN 
configuration.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 a2edf38 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
 03aba7b 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 bfc9429 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
 7fae57f 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/utils.py
 9eebe63 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
 f2ea6ad 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 8e0e783 
  
ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py
 8e5d210 

Diff: https://reviews.apache.org/r/56064/diff/


Testing
---

Manual testing using both wizzard and blueprints.

Unit tests:
```
mvn test -DskipSurefireTests -am -pl ambari-server


[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [11.634s]
[INFO] Apache Ambari Project POM . SUCCESS [0.045s]
[INFO] Ambari Views .. SUCCESS [2.086s]
[INFO] utility ... SUCCESS [1.175s]
[INFO] ambari-metrics  SUCCESS [0.608s]
[INFO] Ambari Metrics Common . SUCCESS [0.352s]
[INFO] Ambari Server . SUCCESS [2:25.628s]
[INFO] 
[INFO] BUILD SUCCESS
```


Thanks,

Sebastian Toader

Re: Review Request 55953: CS queue refresh happens before the user clicks on the restart button

2017-01-29 Thread Vivek Ratnavel Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55953/
---

(Updated Jan. 29, 2017, 5:11 p.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Changes
---

Modified the messages for consistency. Verified Manually.
Ambari-web unit tests pass.
30311 passing (20s)
157 pending


Bugs: AMBARI-19716
https://issues.apache.org/jira/browse/AMBARI-19716


Repository: ambari


Description
---

Build 2.6.0.0-644.

When the llap sliders are moved, and configuration is saved - a queue refresh 
happens immediately if the CS config was affected.

It does not wait for the user to click the Restart Services button.
This can cause problems when the num nodes is being reduced, since the app is 
still running - and the queue size is too small for it.


Diffs (updated)
-

  ambari-web/app/messages.js bf3de62 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
ebfc2c7 

Diff: https://reviews.apache.org/r/55953/diff/


Testing
---

Verified Manually.
Ambari-web unit tests pass

30309 passing (19s)
157 pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 55986: Extend security.json of Infra Solr as a configuration property in Ambari

2017-01-29 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55986/
---

(Updated Jan. 29, 2017, 3:37 p.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

small fixes


Bugs: AMBARI-19727
https://issues.apache.org/jira/browse/AMBARI-19727


Repository: ambari


Description
---

Authorization is missing from ambari-infra whcih can cause issues with other 
services. (like if ranger uses solr, if a user could kinit, the user can 
CREATE/UPDATE/DELETE docs in collections)

I think here we cannot use ranger solr plugin, its like a chicken egg problem 
because we need a running solr to create collection with ranger and start 
ranger admin, but if solr uses ranger plugin for authorization, it needs to go 
to ranger. (which is not running yet) 

at least what we can do: we can make sercurity.json editable, in that case it 
can be modified with authorization data if needed.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 3e076b8 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 94e43e4 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 6bb5a77 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 590485f 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/EnableKerberosPluginSolrZkCommand.java
 fe97994 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/metainfo.xml
 b94812b 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 c2b8a44 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 46535cd 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
6af463c 
  ambari-server/src/test/python/stacks/2.4/configs/default.json dd8a096 

Diff: https://reviews.apache.org/r/55986/diff/


Testing
---

in progress...


Thanks,

Oliver Szabo

Re: Review Request 56054: Inconsistent auth-to-local rules processing during Kerberos authentication

2017-01-29 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56054/#review163430
---


Ship it!




Ship It!

- Laszlo Puskas


On Jan. 29, 2017, 12:50 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56054/
> ---
> 
> (Updated Jan. 29, 2017, 12:50 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19767
> https://issues.apache.org/jira/browse/AMBARI-19767
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Facing issue with local to auth rules. 
> ambari-qa-...@example.com is getting converted to ambari-qa-cl1 as well as 
> ambari-qa with same ambari configuration ie 
> authentication.kerberos.auth_to_local.rules=DEFAULT.
> 
> 1st translation : 
> ```
> 28 Jan 2017 11:44:45,529  INFO [ambari-client-thread-3298] 
> AmbariAuthToLocalUserDetailsService:102 - Translated 
> ambari-qa-...@example.com to ambari-qa-cl1 using auth-to-local rules during 
> Kerberos authentication.
> ```
> 
> 2nd translation :
> ```
> 28 Jan 2017 11:47:36,425  INFO [ambari-client-thread-3172] 
> AmbariAuthToLocalUserDetailsService:102 - Translated 
> ambari-qa-...@example.com to ambari-qa using auth-to-local rules during 
> Kerberos authentication.
> 28 Jan 2017 11:47:36,428  WARN [ambari-client-thread-3172] 
> AmbariAuthToLocalUserDetailsService:136 - Failed find user account for user 
> with username of ambari-qa during Kerberos authentication.
> 28
> ```
> 
> Since authentication.kerberos.auth_to_local.rules=DEFAULT ,  
> 'ambari-qa-...@example.com' should have been translated to 'ambari-qa-cl1'.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
>  c85503c 
> 
> Diff: https://reviews.apache.org/r/56054/diff/
> 
> 
> Testing
> ---
> 
> # Local test results: 
> 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 35:42.972s
> [INFO] Finished at: Sat Jan 28 17:37:32 EST 2017
> [INFO] Final Memory: 66M/1180M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 56059: Preview: Package Installation fails due to error in Berkeley DB library

2017-01-29 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review163429
---




ambari-common/src/main/python/ambari_commons/process_utils.py (line 51)


will double-check that this condition works


- Dmitro Lisnichenko


On Jan. 29, 2017, 2:27 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56059/
> ---
> 
> (Updated Jan. 29, 2017, 2:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-19768
> https://issues.apache.org/jira/browse/AMBARI-19768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Steps*
> # Deploy HDP-2.5.0.0 with Ambari 2.4.1.0
> # Upgrade ambari to 2.5.0.0-481 (I did not register Falcon library, as the 
> jar was already present in /var/lib/ambari-server/resources/je-5.0.73.jar on 
> Ambari server node)
> # Register HDP-2.6.0.0-216
> # Start package installation
> 
> *Result:*
> Got below errors:
> {code}
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
> open failed
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|Traceback 
> (most recent call last):
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 166, in actionexecute
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|ret_code = 
> self.install_packages(package_list)
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 400, in install_packages
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|if not 
> verifyDependencies():
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
>  line 311, in verifyDependencies
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|code, out = 
> rmf_shell.checked_call(cmd, sudo=True)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|result = 
> function(command, **kwargs)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|tries=tries, 
> try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|result = 
> _call(command, **kwargs_copy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|raise 
> ExecutionFailed(err_msg, code, out, err)
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - 
> run()|ExecutionFailed: Execution of '/usr/bin/yum -d 0 -e 0 check 
> dependencies' returned 1. error: rpmdb: BDB0113 Thread/process 
> 16016/139791567193920 failed: BDB1507 Thread died in Berkeley DB library
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: db5 
> error(-30973) from dbenv->failchk: BDB0087 DB_RUNRECOVERY: Fatal error, run 
> database recovery
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
> open Packages index using db5 -  (-30973)
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
> open Packages database in /var/lib/rpm
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
> open failed
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Traceback 
> (most recent call last):
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 469, in 
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - 
>

Review Request 56059: Preview: Package Installation fails due to error in Berkeley DB library

2017-01-29 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/
---

Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
Hurley, and Nate Cole.


Bugs: AMBARI-19768
https://issues.apache.org/jira/browse/AMBARI-19768


Repository: ambari


Description
---

*Steps*
# Deploy HDP-2.5.0.0 with Ambari 2.4.1.0
# Upgrade ambari to 2.5.0.0-481 (I did not register Falcon library, as the jar 
was already present in /var/lib/ambari-server/resources/je-5.0.73.jar on Ambari 
server node)
# Register HDP-2.6.0.0-216
# Start package installation

*Result:*
Got below errors:
{code}
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - 
run()|CRITICAL:yum.main:
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
open failed
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|Traceback (most 
recent call last):
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
166, in actionexecute
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|ret_code = 
self.install_packages(package_list)
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
400, in install_packages
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|if not 
verifyDependencies():
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
 line 311, in verifyDependencies
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|code, out = 
rmf_shell.checked_call(cmd, sudo=True)
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|result = 
function(command, **kwargs)
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|tries=tries, 
try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy)
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 150, 
in _call_wrapper
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|result = 
_call(command, **kwargs_copy)
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 303, 
in _call
2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|raise 
ExecutionFailed(err_msg, code, out, err)
2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|ExecutionFailed: 
Execution of '/usr/bin/yum -d 0 -e 0 check dependencies' returned 1. error: 
rpmdb: BDB0113 Thread/process 16016/139791567193920 failed: BDB1507 Thread died 
in Berkeley DB library
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: db5 
error(-30973) from dbenv->failchk: BDB0087 DB_RUNRECOVERY: Fatal error, run 
database recovery
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
open Packages index using db5 -  (-30973)
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
open Packages database in /var/lib/rpm
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - 
run()|CRITICAL:yum.main:
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
open failed
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Traceback (most 
recent call last):
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
469, in 
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - 
run()|InstallPackages().execute()
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 287, in execute
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|method(env)
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
179, in actionexecute
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|raise 
Fail("Failed to distribute repositories/install packages")
{code}


Diffs
-

  ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION 
  ambari-common/src/main/python/ambari_

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-29 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55987/
---

(Updated Jan. 29, 2017, 9:13 a.m.)


Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian 
Toader.


Bugs: AMBARI-19726
https://issues.apache.org/jira/browse/AMBARI-19726


Repository: ambari


Description
---

The post user creation hook had wired the **hdfs** user, user homes were 
created in the name of this user.
In case of customized clusters this didn;t work due to permssion issues.

The solution is to get the proper hdfs_user from the configureation and access 
the dfs as this user.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/hooks/users/UserHookParams.java
 6970dcc 
  
ambari-server/src/main/java/org/apache/ambari/server/hooks/users/UserHookService.java
 c4ff1e4 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterService.java
 fe6bf35 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/users/PostUserCreationHookServerAction.java
 e713128 
  ambari-server/src/main/resources/scripts/post-user-creation-hook.sh ee8d2d1 
  
ambari-server/src/test/java/org/apache/ambari/server/hooks/users/UserHookServiceTest.java
 293b22a 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/PostUserCreationHookServerActionTest.java
 f5cdf48 

Diff: https://reviews.apache.org/r/55987/diff/


Testing (updated)
---

Unit tests succeeded.

Manually tested changes.


Thanks,

Laszlo Puskas