Re: Review Request 56133: AMBARI-19802. Debug: agent randomly losing heartbeat with the server

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56133/#review163789
---




ambari-agent/src/main/python/ambari_agent/Controller.py (line 303)


This looks to be outside of the scope of ```if current_time - 
heartbeat_running_msg_timestamp > state_interval:``` thus would log on every 
heartbeat (every second). We don't want to flood the log file. This should be 
logged at ```state_intervals```



ambari-agent/src/main/python/ambari_agent/Controller.py (line 310)


This will log on every heartbeat which is fine for DEBUG log level but not 
for INFO level.



ambari-agent/src/main/python/ambari_agent/Controller.py (line 319)


This will log with every heartbeat which is fine for DEBUG logging level 
but not INFO.



ambari-agent/src/main/python/ambari_agent/Controller.py (line 331)


This will log with every heartbeat which is fine for DEBUG logging level 
but not INFO.



ambari-agent/src/main/python/ambari_agent/Controller.py (line 340)


This will log with every heartbeat which is fine for DEBUG logging level 
but not INFO.



ambari-agent/src/main/python/ambari_agent/Controller.py (line 376)


This will log with every heartbeat which is fine for DEBUG logging level 
but not INFO.



ambari-agent/src/main/python/ambari_agent/Controller.py (line 410)


How often will this be logged at INFO level?



ambari-agent/src/main/python/ambari_agent/Controller.py (line 414)


How often will this be logged at INFO level?



ambari-agent/src/main/python/ambari_agent/Controller.py (line 428)


How often will this be logged at INFO level?



ambari-agent/src/main/python/ambari_agent/Controller.py (line 470)


How often will this log at INFO level?



ambari-agent/src/main/python/ambari_agent/Controller.py (line 477)


How often will this log on INFO level?


- Sebastian Toader


On Jan. 31, 2017, 7:49 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56133/
> ---
> 
> (Updated Jan. 31, 2017, 7:49 p.m.)
> 
> 
> Review request for Ambari, Sandor Magyari, Sumit Mohanty, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19802
> https://issues.apache.org/jira/browse/AMBARI-19802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add more logging in heartbeat cycle.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 
> 63707159f00a3b6ef885849acf8233bd83cc4749 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 
> fbb29f4fe59e34e33242f81b783d39a9921c777a 
> 
> Diff: https://reviews.apache.org/r/56133/diff/
> 
> 
> Testing
> ---
> 
> Checked agent log at both INFO and DEBUG log level.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 56141: Add precheck for Auto-Start being disabled

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/
---

(Updated Jan. 31, 2017, 9:32 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor 
Magyari.


Bugs: AMBARI-19800
https://issues.apache.org/jira/browse/AMBARI-19800


Repository: ambari


Description
---

A new precheck is required to make sure that auto-start is disabled before 
starting an upgrade. This JIRA covers the backend requirements. The UI changes 
will be linked to this one.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 a204ada 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56141/diff/


Testing (updated)
---

Manual.  Automated:

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 40:57.215s
[INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
[INFO] Final Memory: 45M/694M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 56145: HDP 3.0 TP - failed to deploy YARN configs because yarn-site creates conflicts since should not belong to MAPREDUCE2

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56145/#review163752
---




ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/metainfo.xml 
(line 61)


This is the actual bug fix.


- Alejandro Fernandez


On Feb. 1, 2017, 12:22 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56145/
> ---
> 
> (Updated Feb. 1, 2017, 12:22 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19809
> https://issues.apache.org/jira/browse/AMBARI-19809
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> * Install Ambari trunk
> * Install HDP 3.0, e.g., centos6: 
> http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/3.x/BUILDS/3.0.0.0-30
> * Select ZK, HDFS, YARN
> * During deployment, will see the following error in the ambari-server log
> 
> ```
> 26 Jan 2017 20:01:48,119 ERROR [ambari-client-thread-26] ClusterImpl:2662 - 
> Updating configs for multiple services by a single API request isn't 
> supported. Conflicting services YARN and MAPREDUCE2 for yarn-site, config 
> version not created for YARN
> ```
> 
> This is because yarn-site is marked right now as belonging to both YARN and 
> MAPREDUCE2, which is incorrect since it should not belong to MAPREDUCE2.
> 
> The fix update the HDP 3.0 service definition for MAPREDUCE2 to use the 
> correct configuration directory.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 
> a094cba 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
>  cd35b68 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/metainfo.xml 
> 41fe13d 
> 
> Diff: https://reviews.apache.org/r/56145/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 56145: HDP 3.0 TP - failed to deploy YARN configs because yarn-site creates conflicts since should not belong to MAPREDUCE2

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56145/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-19809
https://issues.apache.org/jira/browse/AMBARI-19809


Repository: ambari


Description
---

STR:

* Install Ambari trunk
* Install HDP 3.0, e.g., centos6: 
http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/3.x/BUILDS/3.0.0.0-30
* Select ZK, HDFS, YARN
* During deployment, will see the following error in the ambari-server log

```
26 Jan 2017 20:01:48,119 ERROR [ambari-client-thread-26] ClusterImpl:2662 - 
Updating configs for multiple services by a single API request isn't supported. 
Conflicting services YARN and MAPREDUCE2 for yarn-site, config version not 
created for YARN
```

This is because yarn-site is marked right now as belonging to both YARN and 
MAPREDUCE2, which is incorrect since it should not belong to MAPREDUCE2.

The fix update the HDP 3.0 service definition for MAPREDUCE2 to use the correct 
configuration directory.


Diffs
-

  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 
a094cba 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 cd35b68 
  ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/metainfo.xml 
41fe13d 

Diff: https://reviews.apache.org/r/56145/diff/


Testing
---

Verified on live cluster.


Thanks,

Alejandro Fernandez

Review Request 56142: AMBARI-19806: After setting up hadoop credential, cannot start Hive Metastore

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56142/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and Sumit 
Mohanty.


Bugs: AMBARI-19806
https://issues.apache.org/jira/browse/AMBARI-19806


Repository: ambari


Description
---

AMBARI-19806: After setting up hadoop credential, cannot start Hive Metastore

** Issue **
After setting up hadoop credential, the clear text password is no longer 
available in the command JSON. The password is required by schematool, 
DBConnectionVerification and sql (add/remove user) when executing the hive 
stack scripts. This causes Hive Metastore to fail.

** Fix **
Using a new CLI over the hadoop credential store, get the clear text password 
from the JCEKS provider when credential store is enabled and use it where 
required.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8f1848cb7c212b5613bc6923a6b81c3748c66f06 
  ambari-server/pom.xml af9bf7ae483776723fc90a3e2571d268d808c751 
  
ambari-server/src/main/java/org/apache/ambari/server/credentialapi/CredentialUtil.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 91a337f5ba1574877bce7757f1e53e0d0355d19b 
  
ambari-server/src/test/java/org/apache/ambari/server/credentialapi/CredentialUtilTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56142/diff/


Testing
---

** 1. mvn clean install -DskipTests **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [9.787s]
[INFO] Apache Ambari Project POM . SUCCESS [0.038s]
[INFO] Ambari Web  SUCCESS [1:11.600s]
[INFO] Ambari Views .. SUCCESS [1.212s]
[INFO] Ambari Admin View . SUCCESS [9.521s]
[INFO] utility ... SUCCESS [0.281s]
[INFO] ambari-metrics  SUCCESS [0.829s]
[INFO] Ambari Metrics Common . SUCCESS [8.550s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [4.207s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.587s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.436s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [3.319s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.613s]
[INFO] Ambari Metrics Collector .. SUCCESS [12.426s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.481s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.990s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:21.512s]
[INFO] Ambari Server . SUCCESS [5:05.744s]
[INFO] Ambari Functional Tests ... SUCCESS [7.163s]
[INFO] Ambari Agent .. SUCCESS [52.341s]
[INFO] Ambari Client . SUCCESS [0.091s]
[INFO] Ambari Python Client .. SUCCESS [1.031s]
[INFO] Ambari Groovy Client .. SUCCESS [2.829s]
[INFO] Ambari Shell .. SUCCESS [0.050s]
[INFO] Ambari Python Shell ... SUCCESS [0.746s]
[INFO] Ambari Groovy Shell ... SUCCESS [1.342s]
[INFO] ambari-logsearch .. SUCCESS [0.684s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.342s]
[INFO] Ambari Logsearch Portal ... SUCCESS [13.636s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [6.913s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [2.166s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.186s]
[INFO] Ambari Logsearch Integration Test . SUCCESS [0.503s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 10:21.649s
[INFO] Finished at: Tue Jan 31 15:05:49 PST 2017
[INFO] Final Memory: 338M/1123M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=CredentialUtilTest **

[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 5320 licence.
[INFO]
[INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
[INFO] skipping execute as per configuraion
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server

Re: Review Request 56143: Perf: start/stop all actions works much slower after few days of testing

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56143/#review163737
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Лют. 1, 2017, 1:32 до полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56143/
> ---
> 
> (Updated Лют. 1, 2017, 1:32 до полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-19755
> https://issues.apache.org/jira/browse/AMBARI-19755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for "get non existing component from service" fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  5da8012 
> 
> Diff: https://reviews.apache.org/r/56143/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 56143: Perf: start/stop all actions works much slower after few days of testing

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56143/
---

Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-19755
https://issues.apache.org/jira/browse/AMBARI-19755


Repository: ambari


Description
---

Fix for "get non existing component from service" fail.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 5da8012 

Diff: https://reviews.apache.org/r/56143/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 56141: Add precheck for Auto-Start being disabled

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/
---

Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor 
Magyari.


Bugs: AMBARI-19800
https://issues.apache.org/jira/browse/AMBARI-19800


Repository: ambari


Description
---

A new precheck is required to make sure that auto-start is disabled before 
starting an upgrade. This JIRA covers the backend requirements. The UI changes 
will be linked to this one.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 a204ada 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56141/diff/


Testing
---

Manual.  Automated pending


Thanks,

Nate Cole

Re: Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs

[Jaimin Jetly]

> On Jan. 31, 2017, 6:46 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml,
> >  line 293
> > 
> >
> > This is also needed in cluster-env for HDP 3.0

Thanks for letting me know.
Fixed it as part of addendum patch


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56097/#review163691
---


On Jan. 30, 2017, 9:30 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56097/
> ---
> 
> (Updated Jan. 30, 2017, 9:30 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19785
> https://issues.apache.org/jira/browse/AMBARI-19785
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI changes are required to show/hide ranger plugin configs under component 
> config tab.
> 
> If Ranger is not installed on same cluster but is setup on external cluster 
> then cluster-env/enable_external_ranger can be set to true to expose ranger 
> plugin related properties for all services
> 
> This Flag *cluster-env/enable_external_range* should show ranger plugin 
> config-types for all services:
> ranger--plugin-properties.xml
> ranger--audit.xml
> ranger--security.xml
> ranger--policymgr-ssl.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  93680bf 
>   ambari-web/app/controllers/main/service/info/configs.js d946ea0 
>   ambari-web/app/controllers/wizard/step7_controller.js 7dcc2ad 
> 
> Diff: https://reviews.apache.org/r/56097/diff/
> 
> 
> Testing
> ---
> 
> Verified on manual cluster
> verified that all ambari-web unit tests passes:
> 
> 20325 passing (24s)
> 153 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 56130: Hive LLAP and Hive2 log4j changes should be removed from upgrade packs hdp 2.3 and hdp 2.4

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56130/#review163706
---


Ship it!




Ship It!

- Jayush Luniya


On Jan. 31, 2017, 6:39 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56130/
> ---
> 
> (Updated Jan. 31, 2017, 6:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19789
> https://issues.apache.org/jira/browse/AMBARI-19789
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive LLAP and Hive2 log4j changes should be removed from upgrade packs hdp 
> 2.3 and hdp 2.4
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> cf7ae72 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9e13036 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  875b74e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  9cb6b56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 34027ae 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 220c358 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> a65b32c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 189d94a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  96dc65b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  710119f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> f172209 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> b1c1c22 
> 
> Diff: https://reviews.apache.org/r/56130/diff/
> 
> 
> Testing
> ---
> 
> Run build tests.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 56022: Content of yarn-env.sh on host is not same as in the downloaded config file from Ambari UI

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163694
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
 (line 21)


Does this file differ from the one used for HDP 3.0? If so, they need to be 
identical for now, until we figure out what will change in HDP 3.0.


- Alejandro Fernandez


On Jan. 31, 2017, 1:43 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> ---
> 
> (Updated Jan. 31, 2017, 1:43 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exported YARN configuration was different than the stored configuration. I 
> replaced the Python logic that assembled yarn security opt with jinja 
> template logic.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  aed8abc 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml
>  d8531b1 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
>  4d47925 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/metainfo.xml 
> ad457b2 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 62a4d46 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
> 774f3c6 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 5ebfb45 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1 
> 
> Diff: https://reviews.apache.org/r/56022/diff/
> 
> 
> Testing
> ---
> 
> Tested manually:
>  - created a cluster with YARN
>  - enabled kerberos
>  - exported configuration
>  - checked that yarn security opts are presented in the exported config
>  - disablde kerberos
>  - checked that yarn security opts are not presented in the exported config
> 
> existing unittests ran successfully
> one irrelevant failure:
> 
> java.lang.AssertionError
> org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 56133: AMBARI-19802. Debug: agent randomly losing heartbeat with the server

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56133/
---

Review request for Ambari, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-19802
https://issues.apache.org/jira/browse/AMBARI-19802


Repository: ambari


Description
---

Add more logging in heartbeat cycle.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/Controller.py 
63707159f00a3b6ef885849acf8233bd83cc4749 
  ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 
fbb29f4fe59e34e33242f81b783d39a9921c777a 

Diff: https://reviews.apache.org/r/56133/diff/


Testing
---

Checked agent log at both INFO and DEBUG log level.


Thanks,

Attila Doroszlai

Re: Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56097/#review163691
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
(line 293)


This is also needed in cluster-env for HDP 3.0


- Alejandro Fernandez


On Jan. 30, 2017, 9:30 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56097/
> ---
> 
> (Updated Jan. 30, 2017, 9:30 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19785
> https://issues.apache.org/jira/browse/AMBARI-19785
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI changes are required to show/hide ranger plugin configs under component 
> config tab.
> 
> If Ranger is not installed on same cluster but is setup on external cluster 
> then cluster-env/enable_external_ranger can be set to true to expose ranger 
> plugin related properties for all services
> 
> This Flag *cluster-env/enable_external_range* should show ranger plugin 
> config-types for all services:
> ranger--plugin-properties.xml
> ranger--audit.xml
> ranger--security.xml
> ranger--policymgr-ssl.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  93680bf 
>   ambari-web/app/controllers/main/service/info/configs.js d946ea0 
>   ambari-web/app/controllers/wizard/step7_controller.js 7dcc2ad 
> 
> Diff: https://reviews.apache.org/r/56097/diff/
> 
> 
> Testing
> ---
> 
> Verified on manual cluster
> verified that all ambari-web unit tests passes:
> 
> 20325 passing (24s)
> 153 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 56130: Hive LLAP and Hive2 log4j changes should be removed from upgrade packs hdp 2.3 and hdp 2.4

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56130/#review163690
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 31, 2017, 6:39 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56130/
> ---
> 
> (Updated Jan. 31, 2017, 6:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19789
> https://issues.apache.org/jira/browse/AMBARI-19789
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive LLAP and Hive2 log4j changes should be removed from upgrade packs hdp 
> 2.3 and hdp 2.4
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> cf7ae72 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9e13036 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  875b74e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  9cb6b56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 34027ae 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 220c358 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> a65b32c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 189d94a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  96dc65b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  710119f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> f172209 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> b1c1c22 
> 
> Diff: https://reviews.apache.org/r/56130/diff/
> 
> 
> Testing
> ---
> 
> Run build tests.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 56130: Hive LLAP and Hive2 log4j changes should be removed from upgrade packs hdp 2.3 and hdp 2.4

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56130/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-19789
https://issues.apache.org/jira/browse/AMBARI-19789


Repository: ambari


Description
---

Hive LLAP and Hive2 log4j changes should be removed from upgrade packs hdp 2.3 
and hdp 2.4


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
cf7ae72 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 9e13036 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 875b74e 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 9cb6b56 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
34027ae 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
220c358 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
a65b32c 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
189d94a 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 96dc65b 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 710119f 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
f172209 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
b1c1c22 

Diff: https://reviews.apache.org/r/56130/diff/


Testing
---

Run build tests.


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56097/#review163685
---


Ship it!




Ship It!

- Yusaku Sako


On Jan. 30, 2017, 9:30 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56097/
> ---
> 
> (Updated Jan. 30, 2017, 9:30 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19785
> https://issues.apache.org/jira/browse/AMBARI-19785
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI changes are required to show/hide ranger plugin configs under component 
> config tab.
> 
> If Ranger is not installed on same cluster but is setup on external cluster 
> then cluster-env/enable_external_ranger can be set to true to expose ranger 
> plugin related properties for all services
> 
> This Flag *cluster-env/enable_external_range* should show ranger plugin 
> config-types for all services:
> ranger--plugin-properties.xml
> ranger--audit.xml
> ranger--security.xml
> ranger--policymgr-ssl.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  93680bf 
>   ambari-web/app/controllers/main/service/info/configs.js d946ea0 
>   ambari-web/app/controllers/wizard/step7_controller.js 7dcc2ad 
> 
> Diff: https://reviews.apache.org/r/56097/diff/
> 
> 
> Testing
> ---
> 
> Verified on manual cluster
> verified that all ambari-web unit tests passes:
> 
> 20325 passing (24s)
> 153 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163663
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Січ. 31, 2017, 2:45 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Січ. 31, 2017, 2:45 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 56125: ambari-server SuSE11 init script not working in certain environments

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56125/#review163661
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 31, 2017, 4:45 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56125/
> ---
> 
> (Updated Jan. 31, 2017, 4:45 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19797
> https://issues.apache.org/jira/browse/AMBARI-19797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On SuSE11, the same sysvinit script as used for RHEL6 is being installed.  
> On RHEL6, this contains the chkconfig header specifying that ambari-server and
> ambari-agent services should start as late as possible:  
> head -2 /etc/init.d/ambari-server  
> #!/usr/bin/env bash  
> chkconfig: 345 95 20  
> head -2 /etc/init.d/ambari-agent  
> #!/usr/bin/env bash  
> chkconfig: 345 95 20  
> However, these instructions are not honored by Suse, leading to the init
> scrips being scheduled as the first ones to start, before networking and other
> essentials:  
> ls -l /etc/init.d/rc3.d/|grep ambari  
> lrwxrwxrwx 1 root root 15 Jan 23 20:57 K01ambari-agent -> ../ambari-agent  
> lrwxrwxrwx 1 root root 16 Jan 23 20:57 K01ambari-server -> ../ambari-server  
> lrwxrwxrwx 1 root root 15 Jan 23 20:09 S01ambari-agent -> ../ambari-agent  
> lrwxrwxrwx 1 root root 16 Jan 23 20:57 S01ambari-server -> ../ambari-server  
> 
> 
> The ambari-server fails to automatically start after reboot on an Suse11
> system due to the service starting before the network (with the following
> error, also attached in the logs):  
> 1) Error injecting constructor, java.net.UnknownHostException:
> ip-172-31-23-241: ip-172-31-23-241: unknown error  
> This especially happens on system where DNS is being used for resolve
> hostnames (such as on AWS or many users).  
> 
> 
> STR:
> Install a SuSE11 SP4, preferably on AWS or remove any references from
> /etc/hosts.  
> Install the Ambari repo, the packages and run the setup:  
> wget -nv  repo-1.hortonworks.com/ambari/suse11/2.x/updates/2.4.2.0/ambari.repo> -O
> /etc/zypp/repos.d/ambari.repo  
> zypper -n install ambari-agent ambari-server  
> ambari-server setup  
> /etc/init.d/ambari-server start  
> reboot  
> Notice the ambari-server does not come up after reboot.  
> How to fix:  
> As per , the solution is
> to set # Required-Start: $ALL in the script headers.
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server b63f128 
> 
> Diff: https://reviews.apache.org/r/56125/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 56125: ambari-server SuSE11 init script not working in certain environments

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56125/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19797
https://issues.apache.org/jira/browse/AMBARI-19797


Repository: ambari


Description
---

On SuSE11, the same sysvinit script as used for RHEL6 is being installed.  
On RHEL6, this contains the chkconfig header specifying that ambari-server and
ambari-agent services should start as late as possible:  
head -2 /etc/init.d/ambari-server  
#!/usr/bin/env bash  
chkconfig: 345 95 20  
head -2 /etc/init.d/ambari-agent  
#!/usr/bin/env bash  
chkconfig: 345 95 20  
However, these instructions are not honored by Suse, leading to the init
scrips being scheduled as the first ones to start, before networking and other
essentials:  
ls -l /etc/init.d/rc3.d/|grep ambari  
lrwxrwxrwx 1 root root 15 Jan 23 20:57 K01ambari-agent -> ../ambari-agent  
lrwxrwxrwx 1 root root 16 Jan 23 20:57 K01ambari-server -> ../ambari-server  
lrwxrwxrwx 1 root root 15 Jan 23 20:09 S01ambari-agent -> ../ambari-agent  
lrwxrwxrwx 1 root root 16 Jan 23 20:57 S01ambari-server -> ../ambari-server  


The ambari-server fails to automatically start after reboot on an Suse11
system due to the service starting before the network (with the following
error, also attached in the logs):  
1) Error injecting constructor, java.net.UnknownHostException:
ip-172-31-23-241: ip-172-31-23-241: unknown error  
This especially happens on system where DNS is being used for resolve
hostnames (such as on AWS or many users).  


STR:
Install a SuSE11 SP4, preferably on AWS or remove any references from
/etc/hosts.  
Install the Ambari repo, the packages and run the setup:  
wget -nv  -O
/etc/zypp/repos.d/ambari.repo  
zypper -n install ambari-agent ambari-server  
ambari-server setup  
/etc/init.d/ambari-server start  
reboot  
Notice the ambari-server does not come up after reboot.  
How to fix:  
As per , the solution is
to set # Required-Start: $ALL in the script headers.


Diffs
-

  ambari-server/sbin/ambari-server b63f128 

Diff: https://reviews.apache.org/r/56125/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 56114: Log Search "Preview" should have a "Select for Copy" button

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56114/#review163659
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 31, 2017, 9:19 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56114/
> ---
> 
> (Updated Jan. 31, 2017, 9:19 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19791
> https://issues.apache.org/jira/browse/AMBARI-19791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the log message context menu that contains the "Preview" feature, we need 
> to add a "Select for Copy" button that will allow copying the log message to 
> the clipboard
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
>  57d4acd 
> 
> Diff: https://reviews.apache.org/r/56114/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 56123: Log Search portal date range picker - fix minor issues

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56123/#review163658
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 31, 2017, 1:39 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56123/
> ---
> 
> (Updated Jan. 31, 2017, 1:39 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19796
> https://issues.apache.org/jira/browse/AMBARI-19796
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - all the dates are selected and "Invalid Date" caption appears if the first 
> day of the month is Sunday
> - the date of the loading of the page appears as both start and end time if 
> the mouse is moved over any range button
> - the initial value still starts at 1 second after midnight
> 
> also removed some unused codes
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js
>  dc571e8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js
>  6d587cd 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/DatePickerLayout.js
>  3beb776 
> 
> Diff: https://reviews.apache.org/r/56123/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 56022: Content of yarn-env.sh on host is not same as in the downloaded config file from Ambari UI

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/#review163656
---


Ship it!




Ship It!

- Sebastian Toader


On Jan. 31, 2017, 2:43 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56022/
> ---
> 
> (Updated Jan. 31, 2017, 2:43 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19683
> https://issues.apache.org/jira/browse/AMBARI-19683
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exported YARN configuration was different than the stored configuration. I 
> replaced the Python logic that assembled yarn security opt with jinja 
> template logic.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  aed8abc 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml
>  d8531b1 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
>  4d47925 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/metainfo.xml 
> ad457b2 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 62a4d46 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
> 774f3c6 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 5ebfb45 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1 
> 
> Diff: https://reviews.apache.org/r/56022/diff/
> 
> 
> Testing
> ---
> 
> Tested manually:
>  - created a cluster with YARN
>  - enabled kerberos
>  - exported configuration
>  - checked that yarn security opts are presented in the exported config
>  - disablde kerberos
>  - checked that yarn security opts are not presented in the exported config
> 
> existing unittests ran successfully
> one irrelevant failure:
> 
> java.lang.AssertionError
> org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 56124: AMBARI-19795 Ambari upgrade to not add ranger plugin configs under ranger plugin supported services

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56124/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-19795
https://issues.apache.org/jira/browse/AMBARI-19795


Repository: ambari


Description
---

Need to revert the changes done as a part of AMBARI-19044 for adding ranger 
plugin configs during ambari upgrade.
Need to add below properties introduced for support cloud under stack 2.6 only.

-external_admin_username
-external_admin_password
-external_ranger_admin_username
-external_ranger_admin_password


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml
 5257549 
  
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml
 7f594a0 
  
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml
 f0fc160 
  
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml
 a9f84a4 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
 7f85667 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml
 b7cf4c5 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml
 9592914 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml
 84e394b4 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-plugin-properties.xml
 3450970 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
 0de538d 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
 7460d26 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml
 0db5565 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml
 ad2b1e4 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml
 f670d7e 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-policymgr-ssl.xml
 79370bc 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml
 0ad5e60 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-policymgr-ssl.xml
 e14a9e8 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-security.xml
 b2b8edb 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml
 874d0d5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-policymgr-ssl.xml
 14e7b16 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
 a07972a 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-policymgr-ssl.xml
 2f4c121 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml
 abdf2bd 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-policymgr-ssl.xml
 6cc2351 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-security.xml
 0f0d3a7 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml
 21658e7 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml
 8a3dd2e 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml
 8237f1c 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-plugin-properties.xml
 1899d44 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-policymgr-ssl.xml
 6ad6e62 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-security.xml
 3c0b29f 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml
 efeea5f 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml
 977127c 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-policymgr-ssl.xml
 349c829 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml
 c5588d1 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/configuration/ranger-hba

Re: Review Request 56022: Content of yarn-env.sh on host is not same as in the downloaded config file from Ambari UI

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/
---

(Updated Jan. 31, 2017, 1:43 p.m.)


Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.


Changes
---

- Moved template logic from HDP2.3/YARN to HDP2.6/YARN
- Modified HDP3.0/YARN same way as 2.6


Bugs: AMBARI-19683
https://issues.apache.org/jira/browse/AMBARI-19683


Repository: ambari


Description
---

Exported YARN configuration was different than the stored configuration. I 
replaced the Python logic that assembled yarn security opt with jinja template 
logic.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 aed8abc 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml
 d8531b1 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
 4d47925 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/metainfo.xml 
ad457b2 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 62a4d46 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
774f3c6 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
5ebfb45 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1 

Diff: https://reviews.apache.org/r/56022/diff/


Testing
---

Tested manually:
 - created a cluster with YARN
 - enabled kerberos
 - exported configuration
 - checked that yarn security opts are presented in the exported config
 - disablde kerberos
 - checked that yarn security opts are not presented in the exported config

existing unittests ran successfully
one irrelevant failure:

java.lang.AssertionError
org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC


Thanks,

Attila Magyar

Re: Review Request 56123: Log Search portal date range picker - fix minor issues

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56123/#review163655
---


Ship it!




Ship It!

- Oliver Szabo


On Jan. 31, 2017, 1:39 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56123/
> ---
> 
> (Updated Jan. 31, 2017, 1:39 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19796
> https://issues.apache.org/jira/browse/AMBARI-19796
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - all the dates are selected and "Invalid Date" caption appears if the first 
> day of the month is Sunday
> - the date of the loading of the page appears as both start and end time if 
> the mouse is moved over any range button
> - the initial value still starts at 1 second after midnight
> 
> also removed some unused codes
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js
>  dc571e8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js
>  6d587cd 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/DatePickerLayout.js
>  3beb776 
> 
> Diff: https://reviews.apache.org/r/56123/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 56123: Log Search portal date range picker - fix minor issues

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56123/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-19796
https://issues.apache.org/jira/browse/AMBARI-19796


Repository: ambari


Description
---

- all the dates are selected and "Invalid Date" caption appears if the first 
day of the month is Sunday
- the date of the loading of the page appears as both start and end time if the 
mouse is moved over any range button
- the initial value still starts at 1 second after midnight

also removed some unused codes


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js
 dc571e8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js
 6d587cd 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/DatePickerLayout.js
 3beb776 

Diff: https://reviews.apache.org/r/56123/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163653
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 31, 2017, 2:45 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Jan. 31, 2017, 2:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/
---

(Updated Січ. 31, 2017, 12:45 після полудня)


Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Repository: ambari


Description
---

I've deployed cluster with 3000 agents and started my little test script on it. 
Script is doing only three actions in loop: 1) Stop All services 2) Start All 
services 3) Update zk config.
After few days of work these actions need much more time to be executed. For 
example before stop/start all actions took near 7-8 minutes.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 c53a73d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 93f4a8f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 0fce72b 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
d304bb3 
  ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 04b2104 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 0381e38 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
3c7b040 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 1bcffe4 

Diff: https://reviews.apache.org/r/55989/diff/


Testing
---


Thanks,

Vitalyi Brodetskyi

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

[Vitalyi Brodetskyi]

> On Січ. 31, 2017, 10:19 до полудня, Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java,
> >  line 759
> > 
> >
> > is not this issue critical - maybe rethrow exception?

There was no exception before for a long time and i'm not sure it's good idea 
to add it.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163644
---


On Січ. 30, 2017, 11:12 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Січ. 30, 2017, 11:12 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 56084: Hive2: Results are not cleared on "execute"

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56084/
---

(Updated Jan. 31, 2017, 12:44 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19782
https://issues.apache.org/jira/browse/AMBARI-19782


Repository: ambari


Description
---

UI changes.


Diffs (updated)
-

  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 180c43d 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
22838a4 

Diff: https://reviews.apache.org/r/56084/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56084: Hive2: Results are not cleared on "execute"

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56084/
---

(Updated Jan. 31, 2017, 12:03 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19782
https://issues.apache.org/jira/browse/AMBARI-19782


Repository: ambari


Description
---

UI changes.


Diffs (updated)
-

  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 4fe6f43 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5cdc9b3 

Diff: https://reviews.apache.org/r/56084/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56077: Update slider tarball before uploading to DFS

[Andrew Onischuk]

> On Jan. 30, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/scripts/Ambaripreupload.py, line 141
> > 
> >
> > Remove the hardcoding of "/usr/hdp".
> > Use stack_root instead.

stack_root is get from /configurations/cluster-env/stack_root or script.py. 

Neither Ambaripreupload.py uses script.py nor any configuration. This is a 
simple script for for pre-creation which has all the configs hardcoded in it.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/#review163538
---


On Jan. 30, 2017, 1:24 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56077/
> ---
> 
> (Updated Jan. 30, 2017, 1:24 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19776
> https://issues.apache.org/jira/browse/AMBARI-19776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a 
> 
> Diff: https://reviews.apache.org/r/56077/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163647
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 


Please don't move imports unnecessarily.


- Attila Doroszlai


On Jan. 31, 2017, 12:12 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Jan. 31, 2017, 12:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 56082: Hive View : Logs are not complete for hive view

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56082/#review163646
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 30, 2017, 3:37 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56082/
> ---
> 
> (Updated Jan. 30, 2017, 3:37 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19780
> https://issues.apache.org/jira/browse/AMBARI-19780
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes for saving full query logs with multiple statement to file.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/LogAggregator.java
>  9412f81 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/StatementExecutor.java
>  d7b4f54 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/message/StartLogAggregation.java
>  b56da08 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/LogAggregator.java
>  f9c21b4 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java
>  03332d9 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/StartLogAggregation.java
>  922ad1d 
> 
> Diff: https://reviews.apache.org/r/56082/diff/
> 
> 
> Testing
> ---
> 
> Manuall tested.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163645
---


Ship it!




Ship It!

- Dmytro Sen


On Янв. 30, 2017, 11:12 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Янв. 30, 2017, 11:12 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163644
---




ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
(line 759)


is not this issue critical - maybe rethrow exception?


- Dmitro Lisnichenko


On Jan. 31, 2017, 1:12 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Jan. 31, 2017, 1:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 56059: Preview: Package Installation fails due to error in Berkeley DB library

[Dmitro Lisnichenko]

> On Jan. 30, 2017, 8:50 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/ambari_commons/shell.py, lines 141-142
> > 
> >
> > What about the installers for other OSes?
> > Can we have a dictionary/config with the installer for the current OS?

As of now, we are only aware of issues with yum/rpm. On the other hand, we 
already agreed with Nate to have additional argument with dictionary of process 
name-graceful delay for it (for now, it will be only populated with yum and rpm 
entries)


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review163543
---


On Jan. 29, 2017, 2:27 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56059/
> ---
> 
> (Updated Jan. 29, 2017, 2:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-19768
> https://issues.apache.org/jira/browse/AMBARI-19768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Steps*
> # Deploy HDP-2.5.0.0 with Ambari 2.4.1.0
> # Upgrade ambari to 2.5.0.0-481 (I did not register Falcon library, as the 
> jar was already present in /var/lib/ambari-server/resources/je-5.0.73.jar on 
> Ambari server node)
> # Register HDP-2.6.0.0-216
> # Start package installation
> 
> *Result:*
> Got below errors:
> {code}
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
> open failed
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|Traceback 
> (most recent call last):
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 166, in actionexecute
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|ret_code = 
> self.install_packages(package_list)
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 400, in install_packages
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|if not 
> verifyDependencies():
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
>  line 311, in verifyDependencies
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|code, out = 
> rmf_shell.checked_call(cmd, sudo=True)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|result = 
> function(command, **kwargs)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|tries=tries, 
> try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|result = 
> _call(command, **kwargs_copy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|raise 
> ExecutionFailed(err_msg, code, out, err)
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - 
> run()|ExecutionFailed: Execution of '/usr/bin/yum -d 0 -e 0 check 
> dependencies' returned 1. error: rpmdb: BDB0113 Thread/process 
> 16016/139791567193920 failed: BDB1507 Thread died in Berkeley DB library
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: db5 
> error(-30973) from dbenv->failchk: BDB0087 DB_RUNRECOVERY: Fatal error, run 
> database recovery
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
> open Packages index using db5 -  (-30973)
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
> open Packages database in /var/lib/rpm
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13

Re: Review Request 56114: Log Search "Preview" should have a "Select for Copy" button

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56114/#review163640
---


Ship it!




Ship It!

- Oliver Szabo


On Jan. 31, 2017, 9:19 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56114/
> ---
> 
> (Updated Jan. 31, 2017, 9:19 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19791
> https://issues.apache.org/jira/browse/AMBARI-19791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the log message context menu that contains the "Preview" feature, we need 
> to add a "Select for Copy" button that will allow copying the log message to 
> the clipboard
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
>  57d4acd 
> 
> Diff: https://reviews.apache.org/r/56114/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 56114: Log Search "Preview" should have a "Select for Copy" button

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56114/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-19791
https://issues.apache.org/jira/browse/AMBARI-19791


Repository: ambari


Description
---

In the log message context menu that contains the "Preview" feature, we need to 
add a "Select for Copy" button that will allow copying the log message to the 
clipboard


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
 57d4acd 

Diff: https://reviews.apache.org/r/56114/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 56115: Hive2: Unreasonable response time from query exeuction in hive view

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56115/
---

(Updated Jan. 31, 2017, 9:10 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19793
https://issues.apache.org/jira/browse/AMBARI-19793


Repository: ambari


Description
---

- Change the interval to 2 seconds.
- disable button when query is in progress.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
753b7f7 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5cdc9b3 

Diff: https://reviews.apache.org/r/56115/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 56115: Hive2: Unreasonable response time from query exeuction in hive view

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56115/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19793
https://issues.apache.org/jira/browse/AMBARI-19793


Repository: ambari


Description
---

- Change the interval to 2 seconds.
- disable button when query is in progress.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
753b7f7 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5cdc9b3 

Diff: https://reviews.apache.org/r/56115/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56082: Hive View : Logs are not complete for hive view

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56082/#review163638
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 30, 2017, 3:37 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56082/
> ---
> 
> (Updated Jan. 30, 2017, 3:37 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19780
> https://issues.apache.org/jira/browse/AMBARI-19780
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes for saving full query logs with multiple statement to file.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/LogAggregator.java
>  9412f81 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/StatementExecutor.java
>  d7b4f54 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/message/StartLogAggregation.java
>  b56da08 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/LogAggregator.java
>  f9c21b4 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java
>  03332d9 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/StartLogAggregation.java
>  922ad1d 
> 
> Diff: https://reviews.apache.org/r/56082/diff/
> 
> 
> Testing
> ---
> 
> Manuall tested.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56075/#review163637
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 30, 2017, 11:47 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56075/
> ---
> 
> (Updated Jan. 30, 2017, 11:47 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19765
> https://issues.apache.org/jira/browse/AMBARI-19765
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI changes
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 6a77633 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 753b7f7 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5db22d0 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 17abb65 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
>  4fe6f43 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5cdc9b3 
> 
> Diff: https://reviews.apache.org/r/56075/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>