Re: Review Request 56345: Hive2 view UDF tab is blank always

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56345/
---

(Updated Feb. 7, 2017, 7:38 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19883
https://issues.apache.org/jira/browse/AMBARI-19883


Repository: ambari


Description
---

UDF fearure


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/components/udf-edit.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/controllers/udfs/new.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/file-resource.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/udf.js PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/router.js 34f1a66 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
b6434c0 
  contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 8719170 
  contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/services/file-resource.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/services/udf.js PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2f63854 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/fileresource-item.hbs
 PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-edit.hbs
 PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs
 PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-new.hbs 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
62c97a2 
  contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs b776fd2 
  contrib/views/hive20/src/main/resources/ui/app/templates/udfs/new.hbs 
PRE-CREATION 

Diff: https://reviews.apache.org/r/56345/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56307: HiveView2.0 : Upload CSV, JSON, XML to create table feature is missing in the new view

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56307/#review164465
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 4, 2017, 1:54 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56307/
> ---
> 
> (Updated Feb. 4, 2017, 1:54 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19872
> https://issues.apache.org/jira/browse/AMBARI-19872
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added the feature to upload file and create a table
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java
>  44c82a0 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java
>  71cedd1 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/CSVParams.java
>  355ed6a 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableDataReader.java
>  ee148b8 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableInput.java
>  4f15c57 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadFromHdfsInput.java
>  c755c02 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadService.java
>  835626d 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/Parser.java
>  a012463 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/PreviewData.java
>  50af529 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java
>  027baff 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/QueryGenerator.java
>  dda178d 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/RowFormat.java
>  4c1cb2b 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/TableInfo.java
>  bb39271 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/file-uploader.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js 
> PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/simple-table.js 
> PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/upload-table-source.js
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 
> PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/configs/helpers.js 025caa6 
>   contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/models/column.js b1fa99c 
>   contrib/views/hive20/src/main/resources/ui/app/router.js bc9bfa5 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js
>  6dfdf29 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 453eb12 
>   contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 
> 264e617 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/radio-button.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/simple-table.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table-source.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/validated-text-field.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs
>  39b7a9e 
>   
> 

Re: Review Request 56343: Search in recent projects should also search in path and search should be case insensitive

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56343/#review164463
---


Ship it!




Ship It!

- belliraj hb


On Feb. 6, 2017, 8:53 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56343/
> ---
> 
> (Updated Feb. 6, 2017, 8:53 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19882
> https://issues.apache.org/jira/browse/AMBARI-19882
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Search in recent projects should be case insensitive and should search in 
> path also.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 
> 33533db 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs
>  802a8bc 
> 
> Diff: https://reviews.apache.org/r/56343/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56357: AMBARI-19887:Add AMS and Grafana to PERF cluster

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56357/#review164443
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 7, 2017, 1:01 a.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56357/
> ---
> 
> (Updated Feb. 7, 2017, 1:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Sumit 
> Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19887
> https://issues.apache.org/jira/browse/AMBARI-19887
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The PERF cluster needs AMS + Grafana so we can triage ambari server 
> performance issues by analyzing the metrics.
> 
> Sub-Tasks
> 1. Added AMS to PERF stack (inherited from common-services)
> 2. Modified FAKEZOOKEEPER metainfo.xml due to AMS dependency. Only service 
> and component names are changed. No Zk install is done.
> 2. Modified before-ANY hook to support ams user and java.
> 3. Added metrics collector vip host & port support in Ambari Server metrics 
> sink, since AMS may not be on an "actual" FQDN host.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_not_managed_resources.py
>  5f8bc67 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  58d36c3 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py
>  90e0266 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/shared_initialization.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-START/scripts/hook.py
>  c5600a3 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/configuration/ams-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/alerts.json
>  c30a53b1 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/kerberos.json
>  c8c55b7 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/metainfo.xml
>  366ff6e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/package/scripts/zookeeper_client.py
>  78cee4d 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/package/scripts/zookeeper_server.py
>  4373205 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/stack_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56357/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 56357: AMBARI-19887:Add AMS and Grafana to PERF cluster

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56357/
---

Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Sumit 
Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19887
https://issues.apache.org/jira/browse/AMBARI-19887


Repository: ambari


Description
---

The PERF cluster needs AMS + Grafana so we can triage ambari server performance 
issues by analyzing the metrics.

Sub-Tasks
1. Added AMS to PERF stack (inherited from common-services)
2. Modified FAKEZOOKEEPER metainfo.xml due to AMS dependency. Only service and 
component names are changed. No Zk install is done.
2. Modified before-ANY hook to support ams user and java.
3. Added metrics collector vip host & port support in Ambari Server metrics 
sink, since AMS may not be on an "actual" FQDN host.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/get_not_managed_resources.py
 5f8bc67 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 58d36c3 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py
 90e0266 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/shared_initialization.py
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-START/scripts/hook.py
 c5600a3 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/configuration/ams-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/alerts.json
 c30a53b1 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/kerberos.json
 c8c55b7 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/metainfo.xml
 366ff6e 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/package/scripts/zookeeper_client.py
 78cee4d 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/package/scripts/zookeeper_server.py
 4373205 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/stack_advisor.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/56357/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan

Re: Review Request 53686: Stage and Request status should be persisted in the database

[Jaimin Jetly]

> On Feb. 2, 2017, 10:08 p.m., Nate Cole wrote:
> > Have you tried this patch on a large cluster with success?

Yes. 
Verified on 1000 node cluster that the patch does not regress big operations. 
Executed Stop Services and Start Services API call which gernerated around 9000 
tasks and compared request completion time for these operations.

I have also mentioned this in "Testing Done" section.


> On Feb. 2, 2017, 10:08 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java,
> >  line 186
> > 
> >
> > See other comment, either make this non-static on the status enum or 
> > just use !isCompletedState() directly.

Fixed with new revision of the patch


> On Feb. 2, 2017, 10:08 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java,
> >  line 310
> > 
> >
> > nit: Can remove redundant types here, and a lot of other places in this 
> > patch:
> > 
> > Map> counters = new 
> > HashMap<>();
> > List list = new ArrayList<>
> > 
> > etc etc

Fixed with new revision of the patch


> On Feb. 2, 2017, 10:08 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java,
> >  lines 215-216
> > 
> >
> > Potentially doing db work to multiple stages.  What are the 
> > implications of failure here?  Should it be @Transactional (if yes, 
> > remember the method cannot be public).
> > 
> > Also, if some of them can be updated, and others not, can they be 
> > reconciled to "try again"?

Patch is genrally marking entire workflow of updating tasks, updating multiple 
stage and updating multiple requests as transactional.
This is with an intention that we want hostrolecommand status and its 
corresponding stage and request status to be always consistent in the database.

I believe we don't require this method to be marked as transactional because 
status for one stage should be independent of status of another stage. 

If some of them are updated and others are not then on subsequent reporting of 
task status, the ones which did not get updated will be correctly updated


> On Feb. 2, 2017, 10:08 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java,
> >  lines 260-262
> > 
> >
> > Same as other comment.  Transactional?  Partial updates?

As Answered above, status of a request should be independent of status of any 
other request. 
If some of them are updated and others are not then on subsequent reporting of 
task status, the ones which did not get updated will be correctly updated


> On Feb. 2, 2017, 10:08 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java,
> >  lines 35-38
> > 
> >
> > This means that task events will happen on the same thread they came in 
> > on.  Is that ok?  We can still make this an async bus with one thread so it 
> > won't hold up processing of large amounts of Stages and HostRoleCommands.

Yes. This is intentional. we don't want hostrolecommand status to be updated on 
one thread and respective stage/request status to be updated on another thread. 
This can lead to DB inconsistency in terms of partial failures. 

With this patch workflow is:

function() {
  1. update hostrolecommand status using HostRoleCommadDAO#merge function. This 
function is marked as Transactional
  2. HostRoleCommadDAO#merge calls merge function for HRC entity and also 
publishes an event to update stage/request status
}

Thus the entire flow from merging status for HostRoleCommand Entity (before 
event is published) to merging status for corresponding RequestEntity(called by 
event subscriber method) is under a single transactional boundary. 
The transactional boundary extending from publisher method to subscriber 
methods is possible because we are using synchronous event bus.

On the other hand we are using hashmaps (activeTasksMap, activeStageMap and 
activeRequestMap) for storing status of non-completed request, it's stages and 
it's hostrolecommands. I belive that should be fast and not cause any 
performance regression even on large clusters.


> On Feb. 2, 2017, 10:08 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java,
> >  lines 647-650
> > 
> >
> > Since you're deferring to 

Re: Review Request 53686: Stage and Request status should be persisted in the database

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53686/
---

(Updated Feb. 6, 2017, 11:09 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
Wagle.


Bugs: AMBARI-18868
https://issues.apache.org/jira/browse/AMBARI-18868


Repository: ambari


Description
---

Stage and Request status should be persisted in the database.

upgrading to ambari-3.0.0 should add status for all present stages and request 
for the cluster.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
 7837a7b 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 dabcb98 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 
31e11c1 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
4a05b32 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
 3c415df 
  
ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
 02c4091 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
1c4d0a3 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
d2f899f 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
 74271b9 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
 7944d21 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
 f9c8810 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java
 9ca0470 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
 4f90ef3 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
 177ac70 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
 ade625a 
  
ambari-server/src/test/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnableTest.java
 7b1a5a2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 a0701b6 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
 619e367 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListenerTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
 b1c10f5 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java
 9d339e2 
  
ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java
 ed95b0b 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
 d7979e8 

Diff: https://reviews.apache.org/r/53686/diff/


Testing
---

Verified manually on a cluster by making api requests and upgrading ambari.
Add unit tests.
Verified that the patch does not break any existing unit tests on dev box. 
Jenkins job overall unit test result pending..
Verified on 1000 node cluster that the patch does not regress big operations. 
Executed Stop Services and Start Services API call which gernerated around 9000 
tasks and compared  request completion time for these operations. There was a 
minor performance gain with the patch. As part of 
https://issues.apache.org/jira/browse/AMBARI-18889, I will look if we can use 
the request status and stage status to further enhance performance.


Thanks,

Jaimin Jetly

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56179/#review164416
---


Ship it!




Ship It!

- Robert Nettleton


On Feb. 6, 2017, 8:32 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56179/
> ---
> 
> (Updated Feb. 6, 2017, 8:32 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19822
> https://issues.apache.org/jira/browse/AMBARI-19822
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> If an ambari cluster is secured and kerberos authentication is used for Solr, 
> we need (default) authorizations as well to make sure only the specific 
> service users (ranger, atlas, logsearch) can access their collections (and 
> solr user as well)
> 
> Solution:
> Although RuleBasedAuthorizationPlugin seems to be a good solution here, to 
> map default users to default permissions, unfortunately, permissions and 
> roles using principal name for mapping (not username) from the authentication 
> tokens. Also Solr name rules applied on the username and not on the 
> principal, therefore we need the fully qualified hostname as well in the 
> role-permission mapping. In order to avoid that issue, I added an own plugin 
> (org.apache.ambari.infra.security.InfraRuleBasedAuthorizationPlugin), to map 
> users with @ format.
> 
> to problem is in here in RuleBasedAuthorizationPlugin.java:
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/5.5.2/solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPlugin.java#L153
> 
> notice that InfraRuleBasedAuthorizationPlugin is only a copy of that file 
> (InfraUserRolesLookupStrategy class which I added and included in the new 
> plugin class)
> 
> In case of we need strict host validations i added 2 new json properties for 
> that:
> 1. { "user-host" : {"" : []} }
> 2. {"user-host-regex" : {"" : "hostname-regex"} }
> 
> {{user-host-regex}} has higher precedence then {{user-host}}
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-infra-solr-plugin/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraKerberosHostValidatorTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraUserRolesLookupStrategyTest.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml c486050 
>   ambari-logsearch/pom.xml 7aeb4a7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  ed623df 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  526baea 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  d8aea24 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 7a940d3 
> 
> Diff: https://reviews.apache.org/r/56179/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, behavior validated with unit tests. FT: validated with 
> logsearch and atlas as well.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 56345: Hive2 view UDF tab is blank always

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56345/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19883
https://issues.apache.org/jira/browse/AMBARI-19883


Repository: ambari


Description
---

UDF fearure


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/components/udf-edit.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/controllers/udfs/new.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/file-resource.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/udf.js PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/router.js 34f1a66 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
b6434c0 
  contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 8719170 
  contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/services/file-resource.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/services/udf.js PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2f63854 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/fileresource-item.hbs
 PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-edit.hbs
 PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs
 PRE-CREATION 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-new.hbs 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
62c97a2 
  contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs b776fd2 
  contrib/views/hive20/src/main/resources/ui/app/templates/udfs/new.hbs 
PRE-CREATION 

Diff: https://reviews.apache.org/r/56345/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 56343: Search in recent projects should also search in path and search should be case insensitive

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56343/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-19882
https://issues.apache.org/jira/browse/AMBARI-19882


Repository: ambari


Description
---

Search in recent projects should be case insensitive and should search in path 
also.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 
33533db 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs
 802a8bc 

Diff: https://reviews.apache.org/r/56343/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56179/
---

(Updated Feb. 6, 2017, 8:32 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian 
Toader.


Changes
---

use kerberos-env instead of cluster-env to get the realm (in cluster-env its 
using EXAMPLE.COM even if a custom one is used)


Bugs: AMBARI-19822
https://issues.apache.org/jira/browse/AMBARI-19822


Repository: ambari


Description
---

Problem:
If an ambari cluster is secured and kerberos authentication is used for Solr, 
we need (default) authorizations as well to make sure only the specific service 
users (ranger, atlas, logsearch) can access their collections (and solr user as 
well)

Solution:
Although RuleBasedAuthorizationPlugin seems to be a good solution here, to map 
default users to default permissions, unfortunately, permissions and roles 
using principal name for mapping (not username) from the authentication tokens. 
Also Solr name rules applied on the username and not on the principal, 
therefore we need the fully qualified hostname as well in the role-permission 
mapping. In order to avoid that issue, I added an own plugin 
(org.apache.ambari.infra.security.InfraRuleBasedAuthorizationPlugin), to map 
users with @ format.

to problem is in here in RuleBasedAuthorizationPlugin.java:
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/5.5.2/solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPlugin.java#L153

notice that InfraRuleBasedAuthorizationPlugin is only a copy of that file 
(InfraUserRolesLookupStrategy class which I added and included in the new 
plugin class)

In case of we need strict host validations i added 2 new json properties for 
that:
1. { "user-host" : {"" : []} }
2. {"user-host-regex" : {"" : "hostname-regex"} }

{{user-host-regex}} has higher precedence then {{user-host}}


Diffs (updated)
-

  ambari-logsearch/ambari-infra-solr-plugin/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraKerberosHostValidatorTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraUserRolesLookupStrategyTest.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/pom.xml c486050 
  ambari-logsearch/pom.xml 7aeb4a7 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 ed623df 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 526baea 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 d8aea24 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 7a940d3 

Diff: https://reviews.apache.org/r/56179/diff/


Testing
---

unit tests done, behavior validated with unit tests. FT: validated with 
logsearch and atlas as well.


Thanks,

Oliver Szabo

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56179/
---

(Updated Feb. 6, 2017, 8:18 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian 
Toader.


Changes
---

more small fixes


Bugs: AMBARI-19822
https://issues.apache.org/jira/browse/AMBARI-19822


Repository: ambari


Description
---

Problem:
If an ambari cluster is secured and kerberos authentication is used for Solr, 
we need (default) authorizations as well to make sure only the specific service 
users (ranger, atlas, logsearch) can access their collections (and solr user as 
well)

Solution:
Although RuleBasedAuthorizationPlugin seems to be a good solution here, to map 
default users to default permissions, unfortunately, permissions and roles 
using principal name for mapping (not username) from the authentication tokens. 
Also Solr name rules applied on the username and not on the principal, 
therefore we need the fully qualified hostname as well in the role-permission 
mapping. In order to avoid that issue, I added an own plugin 
(org.apache.ambari.infra.security.InfraRuleBasedAuthorizationPlugin), to map 
users with @ format.

to problem is in here in RuleBasedAuthorizationPlugin.java:
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/5.5.2/solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPlugin.java#L153

notice that InfraRuleBasedAuthorizationPlugin is only a copy of that file 
(InfraUserRolesLookupStrategy class which I added and included in the new 
plugin class)

In case of we need strict host validations i added 2 new json properties for 
that:
1. { "user-host" : {"" : []} }
2. {"user-host-regex" : {"" : "hostname-regex"} }

{{user-host-regex}} has higher precedence then {{user-host}}


Diffs (updated)
-

  ambari-logsearch/ambari-infra-solr-plugin/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraKerberosHostValidatorTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraUserRolesLookupStrategyTest.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/pom.xml c486050 
  ambari-logsearch/pom.xml 7aeb4a7 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 ed623df 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 526baea 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 d8aea24 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 7a940d3 

Diff: https://reviews.apache.org/r/56179/diff/


Testing
---

unit tests done, behavior validated with unit tests. FT: validated with 
logsearch and atlas as well.


Thanks,

Oliver Szabo

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56179/
---

(Updated Feb. 6, 2017, 8:02 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian 
Toader.


Changes
---

some small fixes


Bugs: AMBARI-19822
https://issues.apache.org/jira/browse/AMBARI-19822


Repository: ambari


Description
---

Problem:
If an ambari cluster is secured and kerberos authentication is used for Solr, 
we need (default) authorizations as well to make sure only the specific service 
users (ranger, atlas, logsearch) can access their collections (and solr user as 
well)

Solution:
Although RuleBasedAuthorizationPlugin seems to be a good solution here, to map 
default users to default permissions, unfortunately, permissions and roles 
using principal name for mapping (not username) from the authentication tokens. 
Also Solr name rules applied on the username and not on the principal, 
therefore we need the fully qualified hostname as well in the role-permission 
mapping. In order to avoid that issue, I added an own plugin 
(org.apache.ambari.infra.security.InfraRuleBasedAuthorizationPlugin), to map 
users with @ format.

to problem is in here in RuleBasedAuthorizationPlugin.java:
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/5.5.2/solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPlugin.java#L153

notice that InfraRuleBasedAuthorizationPlugin is only a copy of that file 
(InfraUserRolesLookupStrategy class which I added and included in the new 
plugin class)

In case of we need strict host validations i added 2 new json properties for 
that:
1. { "user-host" : {"" : []} }
2. {"user-host-regex" : {"" : "hostname-regex"} }

{{user-host-regex}} has higher precedence then {{user-host}}


Diffs (updated)
-

  ambari-logsearch/ambari-infra-solr-plugin/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraKerberosHostValidatorTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraUserRolesLookupStrategyTest.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/pom.xml c486050 
  ambari-logsearch/pom.xml 7aeb4a7 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 ed623df 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 526baea 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 d8aea24 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 7a940d3 

Diff: https://reviews.apache.org/r/56179/diff/


Testing
---

unit tests done, behavior validated with unit tests. FT: validated with 
logsearch and atlas as well.


Thanks,

Oliver Szabo

Re: Review Request 56337: Ambari Web UI is unusably irresponsive on a 1000-node perf cluster after adding AMS (restart indicator loading is too heavy)

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56337/#review164397
---


Ship it!




Ship It!

- Jaimin Jetly


On Feb. 6, 2017, 7:24 p.m., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56337/
> ---
> 
> (Updated Feb. 6, 2017, 7:24 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-19881
> https://issues.apache.org/jira/browse/AMBARI-19881
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After adding AMS, the cluster became unusably irresponsive. The browser is 
> hanging for the most part.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service.js 6e68ec5 
>   ambari-web/app/mappers/component_config_mapper.js 866f811 
>   ambari-web/app/mappers/components_state_mapper.js b86aee5 
>   ambari-web/app/mappers/server_data_mapper.js da25212 
>   ambari-web/app/models/client_component.js 50a3bb6 
>   ambari-web/app/models/host_component.js d408bfd 
>   ambari-web/app/models/service.js e9dc327 
>   ambari-web/app/views/main/service/menu.js aad718d 
>   ambari-web/test/controllers/main/service_test.js 0421a43 
>   ambari-web/test/models/service_test.js e527e1e 
> 
> Diff: https://reviews.apache.org/r/56337/diff/
> 
> 
> Testing
> ---
> 
> 20326 passing (36s)
> 153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Review Request 56337: Ambari Web UI is unusably irresponsive on a 1000-node perf cluster after adding AMS (restart indicator loading is too heavy)

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56337/
---

Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.


Bugs: AMBARI-19881
https://issues.apache.org/jira/browse/AMBARI-19881


Repository: ambari


Description
---

After adding AMS, the cluster became unusably irresponsive. The browser is 
hanging for the most part.


Diffs
-

  ambari-web/app/controllers/main/service.js 6e68ec5 
  ambari-web/app/mappers/component_config_mapper.js 866f811 
  ambari-web/app/mappers/components_state_mapper.js b86aee5 
  ambari-web/app/mappers/server_data_mapper.js da25212 
  ambari-web/app/models/client_component.js 50a3bb6 
  ambari-web/app/models/host_component.js d408bfd 
  ambari-web/app/models/service.js e9dc327 
  ambari-web/app/views/main/service/menu.js aad718d 
  ambari-web/test/controllers/main/service_test.js 0421a43 
  ambari-web/test/models/service_test.js e527e1e 

Diff: https://reviews.apache.org/r/56337/diff/


Testing
---

20326 passing (36s)
153 pending


Thanks,

Andrii Tkach

Re: Review Request 56329: Log Search Portal time zone selection bug

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/#review164392
---


Ship it!




Ship It!

- Oliver Szabo


On Feb. 6, 2017, 6:21 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56329/
> ---
> 
> (Updated Feb. 6, 2017, 6:21 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19878
> https://issues.apache.org/jira/browse/AMBARI-19878
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the time zone selection box the two CST time zones collide: "Central 
> Standard Time" and "China Standard Time" are both abbreviated as CST, and due 
> to this if the user clicks on the CST button, or moves the mouse over any of 
> these regions, then both of them are highlighted.
> 
> Also removed an unused file
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/src/main/webapp/index.html 2d9ae01 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/css/daterangepicker.css
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/js/daterangepicker.js
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/WorldMapGenerator.js
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/jstz-1.0.4.min.js
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/css/daterangepicker.css
>  7f1ef54 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js
>  e88b45f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js
>  3462ce8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/jstz-1.0.4.min.js
>  96e3dd8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/mapdata.json
>  9d88d40 
>   ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/Init.js 
> cc16129 
> 
> Diff: https://reviews.apache.org/r/56329/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/#review164390
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 (lines 289 - 291)


As these are public-facing, let's make them a little less brief. Perhaps:

Adding HDFS ZKFC Security ACLs

Any place below which has "opts" as well - no need to abbreviate here.


- Jonathan Hurley


On Feb. 6, 2017, 11:26 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56331/
> ---
> 
> (Updated Feb. 6, 2017, 11:26 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19879
> https://issues.apache.org/jira/browse/AMBARI-19879
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older 
> version of HDP then Ambari should update yarn-env and hadoop-env templates 
> with the secure ACL related options.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  c2ff457 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
>  6a0d71f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> f96b246 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  2bb2a72 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 290d3c5 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 4c17177 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  ea3de50 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 5371d3e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 188e6f4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  b975eba 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 291397a 
> 
> Diff: https://reviews.apache.org/r/56331/diff/
> 
> 
> Testing
> ---
> 
> Tested manually:
> 1.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - performed an express upgrade to 2.6
>   - enabled kerberos
>   - disabled kerberos
> 
> 2.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - enabled kerberos
>   - performed an express upgrade to 2.6
>   - disabled kerberos
>   
>   
> Running unit tests...
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56329: Log Search Portal time zone selection bug

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/#review164380
---


Ship it!




Ship It!

- Robert Nettleton


On Feb. 6, 2017, 6:21 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56329/
> ---
> 
> (Updated Feb. 6, 2017, 6:21 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19878
> https://issues.apache.org/jira/browse/AMBARI-19878
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the time zone selection box the two CST time zones collide: "Central 
> Standard Time" and "China Standard Time" are both abbreviated as CST, and due 
> to this if the user clicks on the CST button, or moves the mouse over any of 
> these regions, then both of them are highlighted.
> 
> Also removed an unused file
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/src/main/webapp/index.html 2d9ae01 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/css/daterangepicker.css
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/js/daterangepicker.js
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/WorldMapGenerator.js
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/jstz-1.0.4.min.js
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/css/daterangepicker.css
>  7f1ef54 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js
>  e88b45f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js
>  3462ce8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/jstz-1.0.4.min.js
>  96e3dd8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/mapdata.json
>  9d88d40 
>   ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/Init.js 
> cc16129 
> 
> Diff: https://reviews.apache.org/r/56329/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 56336: WFM: "Workflow Designer" title should be changed to "Workflow Manager" and Minor UI fixes

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56336/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-19880
https://issues.apache.org/jira/browse/AMBARI-19880


Repository: ambari


Description
---

"Workflow Designer" title should be changed to "Workflow Manager"
Width and height of modal popups need to be responsive according to resolution.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3707280 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
 0bd7195 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/help-icon.hbs
 61893e2 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/dashboard.hbs 
41a23b1 

Diff: https://reviews.apache.org/r/56336/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56329: Log Search Portal time zone selection bug

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/
---

(Updated Feb. 6, 2017, 6:21 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

Moved modified third party libraries to custom


Bugs: AMBARI-19878
https://issues.apache.org/jira/browse/AMBARI-19878


Repository: ambari


Description
---

In the time zone selection box the two CST time zones collide: "Central 
Standard Time" and "China Standard Time" are both abbreviated as CST, and due 
to this if the user clicks on the CST button, or moves the mouse over any of 
these regions, then both of them are highlighted.

Also removed an unused file


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-portal/src/main/webapp/index.html 2d9ae01 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/css/daterangepicker.css
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/js/daterangepicker.js
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/WorldMapGenerator.js
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/jstz-1.0.4.min.js
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/css/daterangepicker.css
 7f1ef54 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js
 e88b45f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js
 3462ce8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/jstz-1.0.4.min.js
 96e3dd8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/mapdata.json
 9d88d40 
  ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/Init.js 
cc16129 

Diff: https://reviews.apache.org/r/56329/diff/


Testing
---

Tested on local cluster.


Thanks,

Miklos Gergely

Re: Review Request 56059: Package Installation fails due to error in Berkeley DB library

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review164372
---




ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py (line 38)


We're no longer supporting Windows so I would actually leave those 
annotations out.


- Alejandro Fernandez


On Feb. 6, 2017, 12:46 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56059/
> ---
> 
> (Updated Feb. 6, 2017, 12:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-19768
> https://issues.apache.org/jira/browse/AMBARI-19768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Steps*
> # Deploy HDP-2.5.0.0 with Ambari 2.4.1.0
> # Upgrade ambari to 2.5.0.0-481 (I did not register Falcon library, as the 
> jar was already present in /var/lib/ambari-server/resources/je-5.0.73.jar on 
> Ambari server node)
> # Register HDP-2.6.0.0-216
> # Start package installation
> 
> *Result:*
> Got below errors:
> {code}
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
> open failed
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|Traceback 
> (most recent call last):
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 166, in actionexecute
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|ret_code = 
> self.install_packages(package_list)
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 400, in install_packages
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|if not 
> verifyDependencies():
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
>  line 311, in verifyDependencies
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|code, out = 
> rmf_shell.checked_call(cmd, sudo=True)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|result = 
> function(command, **kwargs)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|tries=tries, 
> try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|result = 
> _call(command, **kwargs_copy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|raise 
> ExecutionFailed(err_msg, code, out, err)
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - 
> run()|ExecutionFailed: Execution of '/usr/bin/yum -d 0 -e 0 check 
> dependencies' returned 1. error: rpmdb: BDB0113 Thread/process 
> 16016/139791567193920 failed: BDB1507 Thread died in Berkeley DB library
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: db5 
> error(-30973) from dbenv->failchk: BDB0087 DB_RUNRECOVERY: Fatal error, run 
> database recovery
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
> open Packages index using db5 -  (-30973)
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
> open Packages database in /var/lib/rpm
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
> open failed
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Traceback 
> (most recent call last):
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 469, in 
> 2016-12-16 

Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/#review164368
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 (line 291)


HDFS and ZKFC in all caps.


- Alejandro Fernandez


On Feb. 6, 2017, 4:26 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56331/
> ---
> 
> (Updated Feb. 6, 2017, 4:26 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19879
> https://issues.apache.org/jira/browse/AMBARI-19879
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older 
> version of HDP then Ambari should update yarn-env and hadoop-env templates 
> with the secure ACL related options.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  c2ff457 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
>  6a0d71f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> f96b246 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  2bb2a72 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 290d3c5 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 4c17177 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  ea3de50 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 5371d3e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 188e6f4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  b975eba 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 291397a 
> 
> Diff: https://reviews.apache.org/r/56331/diff/
> 
> 
> Testing
> ---
> 
> Tested manually:
> 1.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - performed an express upgrade to 2.6
>   - enabled kerberos
>   - disabled kerberos
> 
> 2.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - enabled kerberos
>   - performed an express upgrade to 2.6
>   - disabled kerberos
>   
>   
> Running unit tests...
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/
---

(Updated Feb. 6, 2017, 4:26 p.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.


Changes
---

fixed version in testing description


Bugs: AMBARI-19879
https://issues.apache.org/jira/browse/AMBARI-19879


Repository: ambari


Description
---

Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older 
version of HDP then Ambari should update yarn-env and hadoop-env templates with 
the secure ACL related options.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 c2ff457 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
 6a0d71f 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
f96b246 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 2bb2a72 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
290d3c5 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
4c17177 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 ea3de50 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
5371d3e 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
188e6f4 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 b975eba 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
291397a 

Diff: https://reviews.apache.org/r/56331/diff/


Testing (updated)
---

Tested manually:
1.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - performed an express upgrade to 2.6
  - enabled kerberos
  - disabled kerberos

2.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - enabled kerberos
  - performed an express upgrade to 2.6
  - disabled kerberos
  
  
Running unit tests...


Thanks,

Attila Magyar

Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/
---

Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.


Bugs: AMBARI-19879
https://issues.apache.org/jira/browse/AMBARI-19879


Repository: ambari


Description
---

Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older 
version of HDP then Ambari should update yarn-env and hadoop-env templates with 
the secure ACL related options.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 c2ff457 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
 6a0d71f 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
f96b246 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 2bb2a72 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
290d3c5 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
4c17177 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 ea3de50 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
5371d3e 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
188e6f4 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 b975eba 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
291397a 

Diff: https://reviews.apache.org/r/56331/diff/


Testing
---

Tested manually:
1.
  - created 2.4 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - performed an express upgrade to 2.5
  - enabled kerberos
  - disabled kerberos

2.
  - created 2.4 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - enabled kerberos
  - performed an express upgrade to 2.5  
  - disabled kerberos
  
  
Running unit tests...


Thanks,

Attila Magyar

Re: Review Request 56274: Fix Log Search User Config bugs

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56274/#review164354
---


Ship it!




Ship It!

- Robert Nettleton


On Feb. 6, 2017, 11:35 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56274/
> ---
> 
> (Updated Feb. 6, 2017, 11:35 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19863
> https://issues.apache.org/jira/browse/AMBARI-19863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are several bugs relating to the user configs:
> 
> - due to a bug saving filters do not work
> - saving / viewing / deleting filters uses the user name received, instead of 
> the logged in user
> - deleting filter button is not visible
> 
> also removed some unused code
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  1e46ae9 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/UserConfigRequestQueryConverter.java
>  082f45c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  caf0636 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java
>  03535b1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/request/UserConfigParamDefinition.java
>  23b350a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/request/impl/UserConfigRequest.java
>  c99ea75 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/response/UserConfigData.java
>  1fca3ba 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java
>  31f584d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/SolrConstants.java
>  85554bc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/DashboardLayout.js
>  7adfeb8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/EventHistoryLayout.js
>  89914ea 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/DashboardLayoutView.js
>  6358eb2 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/MainLayoutView.js
>  2333c53 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dialog/ApplySearchFilterView.js
>  16a37ad 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/EventHistoryLayoutView.js
>  b30dd50 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/dashboard/DashboardLayoutView_tmpl.html
>  e00896f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/UserConfigRequestQueryConverterTest.java
>  66c172a 
> 
> Diff: https://reviews.apache.org/r/56274/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56179/#review164352
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 6, 2017, 3:59 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56179/
> ---
> 
> (Updated Feb. 6, 2017, 3:59 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19822
> https://issues.apache.org/jira/browse/AMBARI-19822
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> If an ambari cluster is secured and kerberos authentication is used for Solr, 
> we need (default) authorizations as well to make sure only the specific 
> service users (ranger, atlas, logsearch) can access their collections (and 
> solr user as well)
> 
> Solution:
> Although RuleBasedAuthorizationPlugin seems to be a good solution here, to 
> map default users to default permissions, unfortunately, permissions and 
> roles using principal name for mapping (not username) from the authentication 
> tokens. Also Solr name rules applied on the username and not on the 
> principal, therefore we need the fully qualified hostname as well in the 
> role-permission mapping. In order to avoid that issue, I added an own plugin 
> (org.apache.ambari.infra.security.InfraRuleBasedAuthorizationPlugin), to map 
> users with @ format.
> 
> to problem is in here in RuleBasedAuthorizationPlugin.java:
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/5.5.2/solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPlugin.java#L153
> 
> notice that InfraRuleBasedAuthorizationPlugin is only a copy of that file 
> (InfraUserRolesLookupStrategy class which I added and included in the new 
> plugin class)
> 
> In case of we need strict host validations i added 2 new json properties for 
> that:
> 1. { "user-host" : {"" : []} }
> 2. {"user-host-regex" : {"" : "hostname-regex"} }
> 
> {{user-host-regex}} has higher precedence then {{user-host}}
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-infra-solr-plugin/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraKerberosHostValidatorTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraUserRolesLookupStrategyTest.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml c486050 
>   ambari-logsearch/pom.xml 7aeb4a7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  ed623df 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  526baea 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  d8aea24 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 7a940d3 
> 
> Diff: https://reviews.apache.org/r/56179/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, behavior validated with unit tests. FT: validated with 
> logsearch and atlas as well.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56179/
---

(Updated Feb. 6, 2017, 2:59 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian 
Toader.


Changes
---

use default usernames from configurations


Bugs: AMBARI-19822
https://issues.apache.org/jira/browse/AMBARI-19822


Repository: ambari


Description
---

Problem:
If an ambari cluster is secured and kerberos authentication is used for Solr, 
we need (default) authorizations as well to make sure only the specific service 
users (ranger, atlas, logsearch) can access their collections (and solr user as 
well)

Solution:
Although RuleBasedAuthorizationPlugin seems to be a good solution here, to map 
default users to default permissions, unfortunately, permissions and roles 
using principal name for mapping (not username) from the authentication tokens. 
Also Solr name rules applied on the username and not on the principal, 
therefore we need the fully qualified hostname as well in the role-permission 
mapping. In order to avoid that issue, I added an own plugin 
(org.apache.ambari.infra.security.InfraRuleBasedAuthorizationPlugin), to map 
users with @ format.

to problem is in here in RuleBasedAuthorizationPlugin.java:
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/5.5.2/solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPlugin.java#L153

notice that InfraRuleBasedAuthorizationPlugin is only a copy of that file 
(InfraUserRolesLookupStrategy class which I added and included in the new 
plugin class)

In case of we need strict host validations i added 2 new json properties for 
that:
1. { "user-host" : {"" : []} }
2. {"user-host-regex" : {"" : "hostname-regex"} }

{{user-host-regex}} has higher precedence then {{user-host}}


Diffs (updated)
-

  ambari-logsearch/ambari-infra-solr-plugin/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraKerberosHostValidatorTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraUserRolesLookupStrategyTest.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/pom.xml c486050 
  ambari-logsearch/pom.xml 7aeb4a7 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 ed623df 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 526baea 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 d8aea24 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 7a940d3 

Diff: https://reviews.apache.org/r/56179/diff/


Testing
---

unit tests done, behavior validated with unit tests. FT: validated with 
logsearch and atlas as well.


Thanks,

Oliver Szabo

Re: Review Request 56329: Log Search Portal time zone selection bug

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/#review164350
---




ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js
 (line 140)


as this is a 3rd party code (inside the lib), we should put that js code, 
somewhere else, (e.g.: libs/custom), or maybe you can investigate this more, 
maybe its already fixed in a newer version (then you will need only to replace 
that file with the newer one)


- Oliver Szabo


On Feb. 6, 2017, 2:38 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56329/
> ---
> 
> (Updated Feb. 6, 2017, 2:38 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19878
> https://issues.apache.org/jira/browse/AMBARI-19878
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the time zone selection box the two CST time zones collide: "Central 
> Standard Time" and "China Standard Time" are both abbreviated as CST, and due 
> to this if the user clicks on the CST button, or moves the mouse over any of 
> these regions, then both of them are highlighted.
> 
> Also removed an unused file
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js
>  3462ce8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/mapdata.json
>  9d88d40 
> 
> Diff: https://reviews.apache.org/r/56329/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 56329: Log Search Portal time zone selection bug

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-19878
https://issues.apache.org/jira/browse/AMBARI-19878


Repository: ambari


Description
---

In the time zone selection box the two CST time zones collide: "Central 
Standard Time" and "China Standard Time" are both abbreviated as CST, and due 
to this if the user clicks on the CST button, or moves the mouse over any of 
these regions, then both of them are highlighted.

Also removed an unused file


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js
 3462ce8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/mapdata.json
 9d88d40 

Diff: https://reviews.apache.org/r/56329/diff/


Testing
---

Tested on local cluster.


Thanks,

Miklos Gergely

Re: Review Request 56059: Package Installation fails due to error in Berkeley DB library

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/
---

(Updated Feb. 6, 2017, 2:46 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
Hurley, and Nate Cole.


Bugs: AMBARI-19768
https://issues.apache.org/jira/browse/AMBARI-19768


Repository: ambari


Description
---

*Steps*
# Deploy HDP-2.5.0.0 with Ambari 2.4.1.0
# Upgrade ambari to 2.5.0.0-481 (I did not register Falcon library, as the jar 
was already present in /var/lib/ambari-server/resources/je-5.0.73.jar on Ambari 
server node)
# Register HDP-2.6.0.0-216
# Start package installation

*Result:*
Got below errors:
{code}
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - 
run()|CRITICAL:yum.main:
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
open failed
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|Traceback (most 
recent call last):
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
166, in actionexecute
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|ret_code = 
self.install_packages(package_list)
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
400, in install_packages
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|if not 
verifyDependencies():
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
 line 311, in verifyDependencies
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|code, out = 
rmf_shell.checked_call(cmd, sudo=True)
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|result = 
function(command, **kwargs)
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|tries=tries, 
try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy)
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 150, 
in _call_wrapper
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|result = 
_call(command, **kwargs_copy)
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 303, 
in _call
2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|raise 
ExecutionFailed(err_msg, code, out, err)
2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|ExecutionFailed: 
Execution of '/usr/bin/yum -d 0 -e 0 check dependencies' returned 1. error: 
rpmdb: BDB0113 Thread/process 16016/139791567193920 failed: BDB1507 Thread died 
in Berkeley DB library
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: db5 
error(-30973) from dbenv->failchk: BDB0087 DB_RUNRECOVERY: Fatal error, run 
database recovery
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
open Packages index using db5 -  (-30973)
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
open Packages database in /var/lib/rpm
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - 
run()|CRITICAL:yum.main:
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
open failed
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Traceback (most 
recent call last):
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
469, in 
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - 
run()|InstallPackages().execute()
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 287, in execute
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|method(env)
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
179, in actionexecute
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|raise 
Fail("Failed to distribute repositories/install packages")
{code}


Diffs
-

  ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py PRE-CREATION 
  

Re: Review Request 56059: Package Installation fails due to error in Berkeley DB library

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/
---

(Updated Feb. 6, 2017, 2:41 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
Hurley, and Nate Cole.


Summary (updated)
-

Package Installation fails due to error in Berkeley DB library


Bugs: AMBARI-19768
https://issues.apache.org/jira/browse/AMBARI-19768


Repository: ambari


Description
---

*Steps*
# Deploy HDP-2.5.0.0 with Ambari 2.4.1.0
# Upgrade ambari to 2.5.0.0-481 (I did not register Falcon library, as the jar 
was already present in /var/lib/ambari-server/resources/je-5.0.73.jar on Ambari 
server node)
# Register HDP-2.6.0.0-216
# Start package installation

*Result:*
Got below errors:
{code}
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - 
run()|CRITICAL:yum.main:
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
open failed
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|Traceback (most 
recent call last):
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
166, in actionexecute
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|ret_code = 
self.install_packages(package_list)
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
400, in install_packages
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|if not 
verifyDependencies():
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
 line 311, in verifyDependencies
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|code, out = 
rmf_shell.checked_call(cmd, sudo=True)
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|result = 
function(command, **kwargs)
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|tries=tries, 
try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy)
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 150, 
in _call_wrapper
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|result = 
_call(command, **kwargs_copy)
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 303, 
in _call
2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|raise 
ExecutionFailed(err_msg, code, out, err)
2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|ExecutionFailed: 
Execution of '/usr/bin/yum -d 0 -e 0 check dependencies' returned 1. error: 
rpmdb: BDB0113 Thread/process 16016/139791567193920 failed: BDB1507 Thread died 
in Berkeley DB library
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: db5 
error(-30973) from dbenv->failchk: BDB0087 DB_RUNRECOVERY: Fatal error, run 
database recovery
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
open Packages index using db5 -  (-30973)
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
open Packages database in /var/lib/rpm
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - 
run()|CRITICAL:yum.main:
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
open failed
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Traceback (most 
recent call last):
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
469, in 
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - 
run()|InstallPackages().execute()
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 287, in execute
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|method(env)
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
179, in actionexecute
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|raise 
Fail("Failed to distribute repositories/install packages")

Re: Review Request 56059: Preview: Package Installation fails due to error in Berkeley DB library

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/
---

(Updated Feb. 6, 2017, 2:40 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
Hurley, and Nate Cole.


Changes
---

Added unit tests and fixes some existing ones


Bugs: AMBARI-19768
https://issues.apache.org/jira/browse/AMBARI-19768


Repository: ambari


Description
---

*Steps*
# Deploy HDP-2.5.0.0 with Ambari 2.4.1.0
# Upgrade ambari to 2.5.0.0-481 (I did not register Falcon library, as the jar 
was already present in /var/lib/ambari-server/resources/je-5.0.73.jar on Ambari 
server node)
# Register HDP-2.6.0.0-216
# Start package installation

*Result:*
Got below errors:
{code}
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - 
run()|CRITICAL:yum.main:
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|
2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
open failed
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|Traceback (most 
recent call last):
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
166, in actionexecute
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|ret_code = 
self.install_packages(package_list)
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
400, in install_packages
2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|if not 
verifyDependencies():
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
 line 311, in verifyDependencies
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|code, out = 
rmf_shell.checked_call(cmd, sudo=True)
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|result = 
function(command, **kwargs)
2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|tries=tries, 
try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy)
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 150, 
in _call_wrapper
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|result = 
_call(command, **kwargs_copy)
2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 303, 
in _call
2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|raise 
ExecutionFailed(err_msg, code, out, err)
2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|ExecutionFailed: 
Execution of '/usr/bin/yum -d 0 -e 0 check dependencies' returned 1. error: 
rpmdb: BDB0113 Thread/process 16016/139791567193920 failed: BDB1507 Thread died 
in Berkeley DB library
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: db5 
error(-30973) from dbenv->failchk: BDB0087 DB_RUNRECOVERY: Fatal error, run 
database recovery
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
open Packages index using db5 -  (-30973)
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
open Packages database in /var/lib/rpm
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - 
run()|CRITICAL:yum.main:
2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
open failed
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Traceback (most 
recent call last):
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
469, in 
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - 
run()|InstallPackages().execute()
2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 287, in execute
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|method(env)
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|File 
"/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", line 
179, in actionexecute
2016-12-16 13:47:10,426|INFO|MainThread|machine.py:145 - run()|raise 
Fail("Failed to distribute repositories/install packages")
{code}


Diffs (updated)
-

  

Re: Review Request 56325: Confirmation for deleting services show serviceName and not displayName

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56325/#review164344
---


Ship it!




Ship It!

- Denys Buzhor


On Feb. 6, 2017, 12:16 p.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56325/
> ---
> 
> (Updated Feb. 6, 2017, 12:16 p.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-19877
> https://issues.apache.org/jira/browse/ambari-19877
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Example:
> 
> Shown: "Service LOGSEARCH was successfully deleted" 
> Should be: "Service Log Search was successfully deleted"
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/item.js 9758ac3 
>   ambari-web/test/controllers/main/service/item_test.js b582e86 
> 
> Diff: https://reviews.apache.org/r/56325/diff/
> 
> 
> Testing
> ---
> 
> 20327 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 56325: Confirmation for deleting services show serviceName and not displayName

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56325/
---

Review request for Ambari and Denys Buzhor.


Bugs: ambari-19877
https://issues.apache.org/jira/browse/ambari-19877


Repository: ambari


Description
---

Example:

Shown: "Service LOGSEARCH was successfully deleted" 
Should be: "Service Log Search was successfully deleted"


Diffs
-

  ambari-web/app/controllers/main/service/item.js 9758ac3 
  ambari-web/test/controllers/main/service/item_test.js b582e86 

Diff: https://reviews.apache.org/r/56325/diff/


Testing
---

20327 passing (21s)
  153 pending


Thanks,

Oleg Nechiporenko

Re: Review Request 56307: HiveView2.0 : Upload CSV, JSON, XML to create table feature is missing in the new view

[Rohit Choudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56307/#review164343
---


Ship it!




Ship It!

- Rohit Choudhary


On Feb. 4, 2017, 1:54 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56307/
> ---
> 
> (Updated Feb. 4, 2017, 1:54 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19872
> https://issues.apache.org/jira/browse/AMBARI-19872
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added the feature to upload file and create a table
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java
>  44c82a0 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java
>  71cedd1 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/CSVParams.java
>  355ed6a 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableDataReader.java
>  ee148b8 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableInput.java
>  4f15c57 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadFromHdfsInput.java
>  c755c02 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadService.java
>  835626d 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/Parser.java
>  a012463 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/PreviewData.java
>  50af529 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java
>  027baff 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/QueryGenerator.java
>  dda178d 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/RowFormat.java
>  4c1cb2b 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/TableInfo.java
>  bb39271 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/file-uploader.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js 
> PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/simple-table.js 
> PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/upload-table-source.js
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 
> PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/configs/helpers.js 025caa6 
>   contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/models/column.js b1fa99c 
>   contrib/views/hive20/src/main/resources/ui/app/router.js bc9bfa5 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js
>  6dfdf29 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 453eb12 
>   contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 
> 264e617 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/radio-button.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/simple-table.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table-source.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/validated-text-field.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs
>  39b7a9e 
>   
> 

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

[Oliver Szabo]

> On Feb. 6, 2017, 7:51 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml,
> >  line 27
> > 
> >
> > Instead of using a hardcoded list of users wouldn't it be better to 
> > reference a variable which is populated dynamically based on the configs of 
> > the various HDP components. For example the principals can be overriden 
> > through custom kerberos descriptors thus this hard coded user list would 
> > not apply anymore.

that would meen we will need to restart solr in case of any service added 
instead of using pre defined roles, (what can be changed manually if needed)


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56179/#review164319
---


On Feb. 4, 2017, 5:31 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56179/
> ---
> 
> (Updated Feb. 4, 2017, 5:31 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19822
> https://issues.apache.org/jira/browse/AMBARI-19822
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> If an ambari cluster is secured and kerberos authentication is used for Solr, 
> we need (default) authorizations as well to make sure only the specific 
> service users (ranger, atlas, logsearch) can access their collections (and 
> solr user as well)
> 
> Solution:
> Although RuleBasedAuthorizationPlugin seems to be a good solution here, to 
> map default users to default permissions, unfortunately, permissions and 
> roles using principal name for mapping (not username) from the authentication 
> tokens. Also Solr name rules applied on the username and not on the 
> principal, therefore we need the fully qualified hostname as well in the 
> role-permission mapping. In order to avoid that issue, I added an own plugin 
> (org.apache.ambari.infra.security.InfraRuleBasedAuthorizationPlugin), to map 
> users with @ format.
> 
> to problem is in here in RuleBasedAuthorizationPlugin.java:
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/5.5.2/solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPlugin.java#L153
> 
> notice that InfraRuleBasedAuthorizationPlugin is only a copy of that file 
> (InfraUserRolesLookupStrategy class which I added and included in the new 
> plugin class)
> 
> In case of we need strict host validations i added 2 new json properties for 
> that:
> 1. { "user-host" : {"" : []} }
> 2. {"user-host-regex" : {"" : "hostname-regex"} }
> 
> {{user-host-regex}} has higher precedence then {{user-host}}
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-infra-solr-plugin/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraKerberosHostValidatorTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraUserRolesLookupStrategyTest.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml c486050 
>   ambari-logsearch/pom.xml 7aeb4a7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  ed623df 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  526baea 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  d8aea24 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 7a940d3 
> 
> Diff: https://reviews.apache.org/r/56179/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, behavior validated with unit tests. FT: validated with 
> logsearch and atlas as well.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56274: Fix Log Search User Config bugs

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56274/
---

(Updated Feb. 6, 2017, 11:35 a.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

user filtering is done outside of the converter


Bugs: AMBARI-19863
https://issues.apache.org/jira/browse/AMBARI-19863


Repository: ambari


Description
---

There are several bugs relating to the user configs:

- due to a bug saving filters do not work
- saving / viewing / deleting filters uses the user name received, instead of 
the logged in user
- deleting filter button is not visible

also removed some unused code


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
 1e46ae9 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/UserConfigRequestQueryConverter.java
 082f45c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 caf0636 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java
 03535b1 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/request/UserConfigParamDefinition.java
 23b350a 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/request/impl/UserConfigRequest.java
 c99ea75 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/response/UserConfigData.java
 1fca3ba 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java
 31f584d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/SolrConstants.java
 85554bc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/DashboardLayout.js
 7adfeb8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/EventHistoryLayout.js
 89914ea 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/DashboardLayoutView.js
 6358eb2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/MainLayoutView.js
 2333c53 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dialog/ApplySearchFilterView.js
 16a37ad 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/EventHistoryLayoutView.js
 b30dd50 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/dashboard/DashboardLayoutView_tmpl.html
 e00896f 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/UserConfigRequestQueryConverterTest.java
 66c172a 

Diff: https://reviews.apache.org/r/56274/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 56278: AMBARI-19864 : Zookeeper namespace for Hive service should be taken from hive-interactive-site, when only Hive-server Interactive is installed.

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56278/#review164339
---


Ship it!




Ship It!

- Mugdha Varadkar


On Feb. 6, 2017, 6:31 a.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56278/
> ---
> 
> (Updated Feb. 6, 2017, 6:31 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19864
> https://issues.apache.org/jira/browse/AMBARI-19864
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If only Hive-Server Interactive is installed, then zoo-keeper name space for 
> hive service configured for Ranger should be taken from hive-interactive-site 
> and not from hive-site.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  211fe0a 
> 
> Diff: https://reviews.apache.org/r/56278/diff/
> 
> 
> Testing
> ---
> 
> Verified installation on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 56298: AMBARI-19871 - Config version switch/compare/revert doesn't work

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56298/#review164337
---


Ship it!




Ship It!

- Andrii Tkach


On Feb. 4, 2017, 3:32 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56298/
> ---
> 
> (Updated Feb. 4, 2017, 3:32 a.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19871
> https://issues.apache.org/jira/browse/AMBARI-19871
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix version state variable usage.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/configs/config_history_flow.js c216890 
> 
> Diff: https://reviews.apache.org/r/56298/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20325 passing (23s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 56298: AMBARI-19871 - Config version switch/compare/revert doesn't work

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56298/#review164336
---




ambari-web/app/views/common/configs/config_history_flow.js (line 52)


Please remove hoveredServiceVersion completely since we don't use it


- Andrii Tkach


On Feb. 4, 2017, 3:32 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56298/
> ---
> 
> (Updated Feb. 4, 2017, 3:32 a.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19871
> https://issues.apache.org/jira/browse/AMBARI-19871
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix version state variable usage.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/configs/config_history_flow.js c216890 
> 
> Diff: https://reviews.apache.org/r/56298/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20325 passing (23s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 56321: Popup with alerts on the Service summary doesn't have arrows for alerts with state "None"

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56321/#review164328
---


Ship it!




Ship It!

- Denys Buzhor


On Feb. 6, 2017, 9:34 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56321/
> ---
> 
> (Updated Feb. 6, 2017, 9:34 a.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-19876
> https://issues.apache.org/jira/browse/ambari-19876
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> See screenshot attached to issue
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/info/summary.js 9bdf83a 
> 
> Diff: https://reviews.apache.org/r/56321/diff/
> 
> 
> Testing
> ---
> 
> 20325 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 56321: Popup with alerts on the Service summary doesn't have arrows for alerts with state "None"

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56321/
---

Review request for Ambari and Denys Buzhor.


Bugs: ambari-19876
https://issues.apache.org/jira/browse/ambari-19876


Repository: ambari


Description
---

See screenshot attached to issue


Diffs
-

  ambari-web/app/controllers/main/service/info/summary.js 9bdf83a 

Diff: https://reviews.apache.org/r/56321/diff/


Testing
---

20325 passing (22s)
  153 pending


Thanks,

Oleg Nechiporenko