Re: Review Request 56482: AMBARI-19887 : Add AMS and Grafana to PERF cluster (Addendum patch)

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56482/
---

(Updated Feb. 9, 2017, 7:55 a.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, Sid 
Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19887
https://issues.apache.org/jira/browse/AMBARI-19887


Repository: ambari


Description (updated)
---

Fixed issues in Metric Monitor install.
Modified PERF stack hooks such that only on AMS component hosts, users & Java 
(Metrics Collector only) will be set up.
Fixed params.py such that Grafana picks up metrics collector VIP host.


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 c547bd4 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py
 ef409e2 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py
 dee9d07 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
 f030cfc 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-RESTART/scripts/hook.py
 a366129 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/metainfo.xml
 03a5ab5 

Diff: https://reviews.apache.org/r/56482/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan

Review Request 56483: HiveView2.0: DB panel shows up on Query result full screen

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56483/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19931
https://issues.apache.org/jira/browse/AMBARI-19931


Repository: ambari


Description
---

Minor JS issue


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
dcf27b4 
  contrib/views/hive20/src/main/resources/ui/app/services/query.js b484c74 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4f73ef8 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
8ee8e87 

Diff: https://reviews.apache.org/r/56483/diff/


Testing
---

manuualy tested


Thanks,

Pallav Kulshreshtha

Review Request 56482: AMBARI-19887 : Add AMS and Grafana to PERF cluster (Addendum patch)

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56482/
---

Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, Sid 
Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19887
https://issues.apache.org/jira/browse/AMBARI-19887


Repository: ambari


Description
---

Fixed issues in Metric Monitor install.
Modified PERF stack hooks such that only on AMS components hosts, uses & Java 
(Metrics Collector only) will be set up.
Fixed params.py such that Grafana picks up metrics collector VIP host.


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 c547bd4 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py
 ef409e2 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py
 dee9d07 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
 f030cfc 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-RESTART/scripts/hook.py
 a366129 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/metainfo.xml
 03a5ab5 

Diff: https://reviews.apache.org/r/56482/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan

Re: Review Request 56439: spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/#review164869
---


Ship it!




Ship It!

- Renjith Kamath


On Feb. 8, 2017, 5:04 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56439/
> ---
> 
> (Updated Feb. 8, 2017, 5:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19919
> https://issues.apache.org/jira/browse/AMBARI-19919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> spark/livy (1.x) should not be configured in Zeppelin's interpreter if they 
> are not installed.
> Also, if Spark2 and/or livy2 is available that should be configured by 
> default as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  9af48e5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  97e93fe 
> 
> Diff: https://reviews.apache.org/r/56439/diff/
> 
> 
> Testing
> ---
> 
> tested manually on Centos6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 56430: incorrect imports in hive-next view

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56430/#review164854
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 8, 2017, 6:52 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56430/
> ---
> 
> (Updated Feb. 8, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19913
> https://issues.apache.org/jira/browse/AMBARI-19913
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the imports and packages.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java
>  355ed6a 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  0826945 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java
>  72f3b7a 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java
>  4c1cb2b 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java
>  a440e51 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java
>  1613b05 
> 
> Diff: https://reviews.apache.org/r/56430/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/#review164853
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 8, 2017, 4:22 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56443/
> ---
> 
> (Updated Feb. 8, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19922
> https://issues.apache.org/jira/browse/AMBARI-19922
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding CSS class to deal such isssues.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
>  291def6 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
>  4fbd86b 
>   contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
> 0ab6cfd 
> 
> Diff: https://reviews.apache.org/r/56443/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56430: incorrect imports in hive-next view

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56430/#review164850
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 8, 2017, 6:52 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56430/
> ---
> 
> (Updated Feb. 8, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19913
> https://issues.apache.org/jira/browse/AMBARI-19913
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the imports and packages.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java
>  355ed6a 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  0826945 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java
>  72f3b7a 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java
>  4c1cb2b 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java
>  a440e51 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java
>  1613b05 
> 
> Diff: https://reviews.apache.org/r/56430/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 56430: incorrect imports in hive-next view

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56430/#review164849
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 8, 2017, 6:52 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56430/
> ---
> 
> (Updated Feb. 8, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19913
> https://issues.apache.org/jira/browse/AMBARI-19913
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the imports and packages.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java
>  355ed6a 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  0826945 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java
>  72f3b7a 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java
>  4c1cb2b 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java
>  a440e51 
>   
> contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java
>  1613b05 
> 
> Diff: https://reviews.apache.org/r/56430/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/#review164847
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 8, 2017, 4:22 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56443/
> ---
> 
> (Updated Feb. 8, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19922
> https://issues.apache.org/jira/browse/AMBARI-19922
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding CSS class to deal such isssues.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
>  291def6 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
>  4fbd86b 
>   contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
> 0ab6cfd 
> 
> Diff: https://reviews.apache.org/r/56443/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56276: AMBARI-19845 Secure Ranger passwords in Ambari Stacks

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56276/
---

(Updated Feb. 9, 2017, 5:38 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-19845
https://issues.apache.org/jira/browse/AMBARI-19845


Repository: ambari


Description
---

Make sure plain-text password is not persisted in XML and always stored in jceks


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 8fd5c8d 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 a12116d 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 0b4532b 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 3cb225f 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
 0067520 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-admin-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 742cb93 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 05e8881 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 0fd1766 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py b01e7da 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 
22e84fc 
  ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
57f9f34 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 8dda363 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 
bf5128e 
  ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json 
2c4815b 

Diff: https://reviews.apache.org/r/56276/diff/


Testing
---

Unit test result:

Ran 270 tests in 11.685s

OK
--
Total run:1172
Total errors:0
Total failures:0
OK


Thanks,

Mugdha Varadkar

Re: Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/#review164841
---


Ship it!




Ship It!

- Sid Wagle


On Feb. 9, 2017, 1:29 a.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56453/
> ---
> 
> (Updated Feb. 9, 2017, 1:29 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19758
> https://issues.apache.org/jira/browse/AMBARI-19758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services 
> are marked with restart required.
> 
> FIX
> Removed hadoop-metrics2.properties.xml from common-services and moved it to 
> the stack.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
>  6b45e84 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> b1db696 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  642b63e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  cf958f0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 
> 1fc7f51 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml
>  14f15fc 
> 
> Diff: https://reviews.apache.org/r/56453/diff/
> 
> 
> Testing
> ---
> 
> Manually tested Ambari upgrade from 2.4.0 to 2.5.0.
> Manually tested HDP upgrade from 2.5.3 to 2.6
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

[Jayush Luniya]

> On Feb. 9, 2017, 3:29 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java,
> >  line 136
> > 
> >
> > Madhu,
> > As we discussed, it looks like getting the entire ServiceComponentInfo 
> > is expensive. If I query 
> > /api/v1/clusters//services//components/
> >  it takes a long time. When exporting blueprint since we will be loading 
> > all service components we will have significant perf impact. Lets add 
> > filters to only get required fields for ServiceComponent
> > 
> > 
> > serviceComponentNode.getObject().add("ServiceComponentInfo/cluster_name");
> > 
> > serviceComponentNode.getObject().add("ServiceComponentInfo/service_name");
> > 
> > serviceComponentNode.getObject().add("ServiceComponentInfo/component_name");
> > 
> > serviceComponentNode.getObject().add("ServiceComponentInfo/recovery_enabled");

My suspicion is that the metrics node is taking a long time to load. Will 
follow up on that with Sid.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56418/#review164829
---


On Feb. 8, 2017, 12:52 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56418/
> ---
> 
> (Updated Feb. 8, 2017, 12:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert 
> Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19909
> https://issues.apache.org/jira/browse/AMBARI-19909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Export Blueprints does not contain the settings object and hence the 
> credential store values
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
>  1a9ea91 
> 
> Diff: https://reviews.apache.org/r/56418/diff/
> 
> 
> Testing
> ---
> 
> Issued 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/credential?format=blueprint
>  command to ensure that the settings object is present.
> Resultant blueprint has the following object added:
> "settings" : [
> {
>   "recovery_settings" : [
> {
>   "recovery_enabled" : "true"
> }
>   ]
> },
> {
>   "service_settings" : [
> {
>   "name" : "OOZIE",
>   "credential_store_enabled" : "true"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "HIVE",
>   "credential_store_enabled" : "true"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "HDFS"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "AMBARI_METRICS"
> }
>   ]
> },
> {
>   "component_settings" : [
> {
>   "recovery_enabled" : "true",
>   "name" : "METRICS_COLLECTOR"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "SECONDARY_NAMENODE"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "WEBHCAT_SERVER"
> }
>   ]
> }
>   ]
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56418/#review164829
---




ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
 (line 136)


Madhu,
As we discussed, it looks like getting the entire ServiceComponentInfo is 
expensive. If I query 
/api/v1/clusters//services//components/
 it takes a long time. When exporting blueprint since we will be loading all 
service components we will have significant perf impact. Lets add filters to 
only get required fields for ServiceComponent


serviceComponentNode.getObject().add("ServiceComponentInfo/cluster_name");

serviceComponentNode.getObject().add("ServiceComponentInfo/service_name");

serviceComponentNode.getObject().add("ServiceComponentInfo/component_name");

serviceComponentNode.getObject().add("ServiceComponentInfo/recovery_enabled");


- Jayush Luniya


On Feb. 8, 2017, 12:52 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56418/
> ---
> 
> (Updated Feb. 8, 2017, 12:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert 
> Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19909
> https://issues.apache.org/jira/browse/AMBARI-19909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Export Blueprints does not contain the settings object and hence the 
> credential store values
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
>  1a9ea91 
> 
> Diff: https://reviews.apache.org/r/56418/diff/
> 
> 
> Testing
> ---
> 
> Issued 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/credential?format=blueprint
>  command to ensure that the settings object is present.
> Resultant blueprint has the following object added:
> "settings" : [
> {
>   "recovery_settings" : [
> {
>   "recovery_enabled" : "true"
> }
>   ]
> },
> {
>   "service_settings" : [
> {
>   "name" : "OOZIE",
>   "credential_store_enabled" : "true"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "HIVE",
>   "credential_store_enabled" : "true"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "HDFS"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "AMBARI_METRICS"
> }
>   ]
> },
> {
>   "component_settings" : [
> {
>   "recovery_enabled" : "true",
>   "name" : "METRICS_COLLECTOR"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "SECONDARY_NAMENODE"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "WEBHCAT_SERVER"
> }
>   ]
> }
>   ]
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 56420: On certain actions, there's no feedback from the UI when API takes a long time to respond - not reassuring and the user is encouraged to keep triggering the same heavy action

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56420/
---

(Updated Feb. 9, 2017, 2:52 a.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Changes
---

Added a latency of 200ms before Loading popup shows up.


Bugs: AMBARI-19907
https://issues.apache.org/jira/browse/AMBARI-19907


Repository: ambari


Description
---

On a big cluster, it takes the server a long time to process the API request 
for certain operations, like "Stop All", "Start All", etc. 
On a small cluster, the "background operations" popup appears within a few 
seconds to acknowledge to the user that the server is working on handling the 
request.
However, when the cluster gets bigger and the request API takes the server much 
longer (e.g., on a 1000-node cluster, it took ~35 seconds), there's no 
indication on the UI that the server received the request.  This is not 
reassuring to the user and the user is tempted to keep re-triggering the action 
and overwhelming the server.

This problem is not just for "Start All", "Stop All".  This problem actually 
happens for "Stop" and "Start" of a single service as well (and likely other 
places, like Hosts / Host Detail pages.)  On the 1000-node cluster, this takes 
about 6-7 seconds, enough to make the user wonder if the request got to the 
server or not.


Diffs (updated)
-

  ambari-web/app/controllers/main/host/bulk_operations_controller.js 0e73c0c 
  ambari-web/app/controllers/main/host/details.js f040db5 
  ambari-web/app/controllers/main/service.js e434d41 
  ambari-web/app/controllers/main/service/item.js 6f1efd8 
  ambari-web/app/utils/ajax/ajax.js 2ea6113 
  ambari-web/app/utils/batch_scheduled_requests.js b8ae955 
  ambari-web/test/controllers/main/service_test.js d8c3365 

Diff: https://reviews.apache.org/r/56420/diff/


Testing
---

Verified Manually.
Ambari-web unit tests pass.
30312 passing (19s)
157 pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/
---

(Updated Feb. 9, 2017, 1:29 a.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19758
https://issues.apache.org/jira/browse/AMBARI-19758


Repository: ambari


Description
---

Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services are 
marked with restart required.

FIX
Removed hadoop-metrics2.properties.xml from common-services and moved it to the 
stack.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
 6b45e84 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
b1db696 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 642b63e 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 cf958f0 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 
1fc7f51 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml 
14f15fc 

Diff: https://reviews.apache.org/r/56453/diff/


Testing (updated)
---

Manually tested Ambari upgrade from 2.4.0 to 2.5.0.
Manually tested HDP upgrade from 2.5.3 to 2.6


Thanks,

Aravindan Vijayan

Re: Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/
---

(Updated Feb. 9, 2017, 1:27 a.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Changes
---

Added hadoop-metrics2.properties config type as a config-dependency to HDFS in 
stack so that Ambari triggers restart needed for HDFS whenever a change is made 
to that template.


Bugs: AMBARI-19758
https://issues.apache.org/jira/browse/AMBARI-19758


Repository: ambari


Description
---

Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services are 
marked with restart required.

FIX
Removed hadoop-metrics2.properties.xml from common-services and moved it to the 
stack.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
 6b45e84 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
b1db696 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 642b63e 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 cf958f0 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 
1fc7f51 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml 
14f15fc 

Diff: https://reviews.apache.org/r/56453/diff/


Testing
---

Manually tested Ambari upgrade from 2.4.0 to 2.5.0.


Thanks,

Aravindan Vijayan

Re: Review Request 56189: AMBARI-19827. HiveServer2 Interactive won't start in clusters with less memory.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56189/#review164811
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 8, 2017, 11:57 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56189/
> ---
> 
> (Updated Feb. 8, 2017, 11:57 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19827
> https://issues.apache.org/jira/browse/AMBARI-19827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HSI caluclations fails on cluster with small memory. Fixed the calulations 
> for that.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 22d50e3 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 9029dbb 
> 
> Diff: https://reviews.apache.org/r/56189/diff/
> 
> 
> Testing
> ---
> 
> Python UT tests fixed and Passes.
> Tested on cluster.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 56189: AMBARI-19827. HiveServer2 Interactive won't start in clusters with less memory.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56189/
---

(Updated Feb. 8, 2017, 11:57 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Fixed the following issue:

=
Error occured in stack advisor.
Error details: invalid literal for float(): SET_ON_FIRST_INVOCATION
08 Feb 2017 02:24:19,299  INFO [pool-18-thread-1] StackAdvisorRunner:71 - 
advisor script stderr: Traceback (most recent call last):
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 166, 
in 
main(sys.argv)
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 116, 
in main
result = stackAdvisor.recommendConfigurations(services, hosts)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 775, in recommendConfigurations
calculation(configurations, clusterSummary, services, hosts)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.5/services/stack_advisor.py",
 line 687, in recommendHIVEConfigurations
super(HDP25StackAdvisor, self).recommendHIVEConfigurations(configurations, 
clusterData, services, hosts)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.3/services/stack_advisor.py",
 line 222, in recommendHIVEConfigurations
super(HDP23StackAdvisor, self).recommendHIVEConfigurations(configurations, 
clusterData, services, hosts)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.2/services/stack_advisor.py",
 line 375, in recommendHIVEConfigurations
self.recommendYARNConfigurations(configurations, clusterData, services, 
hosts)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.5/services/stack_advisor.py",
 line 734, in recommendYARNConfigurations
self.updateLlapConfigs(configurations, services, hosts, LLAP_QUEUE_NAME)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.5/services/stack_advisor.py",
 line 910, in updateLlapConfigs
mem_per_thread_for_llap = self.calculate_mem_per_thread_for_llap(services, 
yarn_nm_mem_in_mb_normalized, cpu_per_nm_host)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.5/services/stack_advisor.py",
 line 1320, in calculate_mem_per_thread_for_llap
hive_tez_container_size = self.get_hive_tez_container_size(services)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.5/services/stack_advisor.py",
 line 1347, in get_hive_tez_container_size
hive_container_size = float(hsi_site['hive.tez.container.size'])
ValueError: invalid literal for float(): SET_ON_FIRST_INVOCATION

=


Bugs: AMBARI-19827
https://issues.apache.org/jira/browse/AMBARI-19827


Repository: ambari


Description
---

HSI caluclations fails on cluster with small memory. Fixed the calulations for 
that.


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
22d50e3 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 9029dbb 

Diff: https://reviews.apache.org/r/56189/diff/


Testing
---

Python UT tests fixed and Passes.
Tested on cluster.


Thanks,

Swapan Shridhar

Re: Review Request 56426: AMBARI-19912 - Manage Config Group host list is not sorted

[Richard Zang]

> On Feb. 8, 2017, 7:28 p.m., Jaimin Jetly wrote:
> > ambari-web/app/mappers/configs/config_groups_mapper.js, line 71
> > 
> >
> > sorting a list might not be very expensive on client side. But if there 
> > are multiple config groups with considerable hosts in each then it can have 
> > some performace impact.
> > 
> > I don't see this to be significant. so I am ok with commiting this 
> > patch. But good to track this as a future requirement for ambari-server to 
> > expose an API that gives sorted hostnames for a configgroup by default or 
> > via sortBy predicate.

Yes, sorting will cause noticable time when list is big, so when we have API 
provide sorted list of hosts, we can remove this from mapper.


> On Feb. 8, 2017, 7:28 p.m., Jaimin Jetly wrote:
> > ambari-web/app/controllers/main/service/manage_config_groups_controller.js, 
> > line 569
> > 
> >
> > parentconfiggroup should already be sorted to beging with as we are 
> > sorting all config groups in config group mapper. rmoving a host should 
> > keep the list sorted
> > 
> > is again sorting required over here ?

fixed in v2


> On Feb. 8, 2017, 7:28 p.m., Jaimin Jetly wrote:
> > ambari-web/app/controllers/main/service/manage_config_groups_controller.js, 
> > line 590
> > 
> >
> > same as above. if a host is being emoved from a sorted list, again 
> > sorting the list may not be required.

fixed in v2


- Richard


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56426/#review164745
---


On Feb. 8, 2017, 8:18 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56426/
> ---
> 
> (Updated Feb. 8, 2017, 8:18 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Xi Wang.
> 
> 
> Bugs: AMBARI-19912
> https://issues.apache.org/jira/browse/AMBARI-19912
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Keep host list sorted on initial loading as well as after any operation.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 07756f0 
>   ambari-web/app/mappers/configs/config_groups_mapper.js 8700135 
> 
> Diff: https://reviews.apache.org/r/56426/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20327 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 56439: spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/#review164769
---


Ship it!




Ship It!

- Jayush Luniya


On Feb. 8, 2017, 5:04 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56439/
> ---
> 
> (Updated Feb. 8, 2017, 5:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19919
> https://issues.apache.org/jira/browse/AMBARI-19919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> spark/livy (1.x) should not be configured in Zeppelin's interpreter if they 
> are not installed.
> Also, if Spark2 and/or livy2 is available that should be configured by 
> default as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  9af48e5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  97e93fe 
> 
> Diff: https://reviews.apache.org/r/56439/diff/
> 
> 
> Testing
> ---
> 
> tested manually on Centos6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 56426: AMBARI-19912 - Manage Config Group host list is not sorted

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56426/#review164761
---


Ship it!




Ship It!

- Jaimin Jetly


On Feb. 8, 2017, 8:18 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56426/
> ---
> 
> (Updated Feb. 8, 2017, 8:18 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Xi Wang.
> 
> 
> Bugs: AMBARI-19912
> https://issues.apache.org/jira/browse/AMBARI-19912
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Keep host list sorted on initial loading as well as after any operation.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 07756f0 
>   ambari-web/app/mappers/configs/config_groups_mapper.js 8700135 
> 
> Diff: https://reviews.apache.org/r/56426/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20327 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 56426: AMBARI-19912 - Manage Config Group host list is not sorted

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56426/
---

(Updated Feb. 8, 2017, 8:18 p.m.)


Review request for Ambari, Jaimin Jetly and Xi Wang.


Changes
---

Only sort the list with new entries.


Bugs: AMBARI-19912
https://issues.apache.org/jira/browse/AMBARI-19912


Repository: ambari


Description
---

Keep host list sorted on initial loading as well as after any operation.


Diffs (updated)
-

  ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
07756f0 
  ambari-web/app/mappers/configs/config_groups_mapper.js 8700135 

Diff: https://reviews.apache.org/r/56426/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  20327 passing (21s)
  153 pending


Thanks,

Richard Zang

Re: Review Request 56426: AMBARI-19912 - Manage Config Group host list is not sorted

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56426/#review164745
---




ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
(line 569)


parentconfiggroup should already be sorted to beging with as we are sorting 
all config groups in config group mapper. rmoving a host should keep the list 
sorted

is again sorting required over here ?



ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
(line 590)


same as above. if a host is being emoved from a sorted list, again sorting 
the list may not be required.



ambari-web/app/mappers/configs/config_groups_mapper.js (line 71)


sorting a list might not be very expensive on client side. But if there are 
multiple config groups with considerable hosts in each then it can have some 
performace impact.

I don't see this to be significant. so I am ok with commiting this patch. 
But good to track this as a future requirement for ambari-server to expose an 
API that gives sorted hostnames for a configgroup by default or via sortBy 
predicate.


- Jaimin Jetly


On Feb. 8, 2017, 3:34 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56426/
> ---
> 
> (Updated Feb. 8, 2017, 3:34 a.m.)
> 
> 
> Review request for Ambari and Xi Wang.
> 
> 
> Bugs: AMBARI-19912
> https://issues.apache.org/jira/browse/AMBARI-19912
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Keep host list sorted on initial loading as well as after any operation.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 07756f0 
>   ambari-web/app/mappers/configs/config_groups_mapper.js 8700135 
> 
> Diff: https://reviews.apache.org/r/56426/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20327 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 56402: Ambari scripts have 777 permission which is a major security concern (change came from 2.4.x)

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56402/#review164747
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 7, 2017, 8:40 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56402/
> ---
> 
> (Updated Feb. 7, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-19902
> https://issues.apache.org/jira/browse/AMBARI-19902
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If we look at the below output these files have 777 perms : 
> {code}
> [root@h1 ~]# ll /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> -rwxrwxrwx. 1 root root 22471 Nov 23 07:40 
> /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> 
> [root@h1 ~]# ll /var/lib/ambari-server/resources/scripts/configs.sh 
> -rwxrwxrwx. 1 root root 9801 Nov 23 07:27 
> /var/lib/ambari-server/resources/scripts/configs.sh 
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 79fa32c 
>   ambari-server/src/main/assemblies/server.xml d65232c 
> 
> Diff: https://reviews.apache.org/r/56402/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 56451: Storm REST metrics are not available when Storm UI is running in HTTPS

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56451/#review164746
---


Fix it, then Ship it!





ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 (line 50)


use named imports


- Alejandro Fernandez


On Feb. 8, 2017, 6:40 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56451/
> ---
> 
> (Updated Feb. 8, 2017, 6:40 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19345
> https://issues.apache.org/jira/browse/AMBARI-19345
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enable storm ui for https as per below document.
> http://storm.apache.org/releases/1.0.1/SECURITY.html
> Storm UI works fine and connect successfully using https.
> However ambari alert for storm UI breaks, also ambari server keeps trying to 
> fetch REST metrics using http instead of https.
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json
>  7c149bb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
>  8c23fe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  8f0d218 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/metrics.json 
> b2b0404 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/alerts.json 
> 842538d 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/metrics.json 
> 43ed608 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/quicklinks/quicklinks.json
>  492f0a0 
>   ambari-server/src/main/resources/common-services/STORM/0.9.3/metrics.json 
> d9a11b2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java
>  8455484 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  4dffea8 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json 
> 7c149bb 
> 
> Diff: https://reviews.apache.org/r/56451/diff/
> 
> 
> Testing
> ---
> 
> Unit and manual tests passed.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 56402: Ambari scripts have 777 permission which is a major security concern (change came from 2.4.x)

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56402/#review164744
---


Ship it!




Ship It!

- Swapan Shridhar


On Feb. 7, 2017, 8:40 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56402/
> ---
> 
> (Updated Feb. 7, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-19902
> https://issues.apache.org/jira/browse/AMBARI-19902
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If we look at the below output these files have 777 perms : 
> {code}
> [root@h1 ~]# ll /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> -rwxrwxrwx. 1 root root 22471 Nov 23 07:40 
> /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> 
> [root@h1 ~]# ll /var/lib/ambari-server/resources/scripts/configs.sh 
> -rwxrwxrwx. 1 root root 9801 Nov 23 07:27 
> /var/lib/ambari-server/resources/scripts/configs.sh 
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 79fa32c 
>   ambari-server/src/main/assemblies/server.xml d65232c 
> 
> Diff: https://reviews.apache.org/r/56402/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/#review164738
---


Ship it!




Ship It!

- Sid Wagle


On Feb. 8, 2017, 5:32 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56453/
> ---
> 
> (Updated Feb. 8, 2017, 5:32 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19758
> https://issues.apache.org/jira/browse/AMBARI-19758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services 
> are marked with restart required.
> 
> FIX
> Removed hadoop-metrics2.properties.xml from common-services and moved it to 
> the stack.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
>  6b45e84 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> b1db696 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  642b63e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  cf958f0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml
>  14f15fc 
> 
> Diff: https://reviews.apache.org/r/56453/diff/
> 
> 
> Testing
> ---
> 
> Manually tested Ambari upgrade from 2.4.0 to 2.5.0.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 56451: Storm REST metrics are not available when Storm UI is running in HTTPS

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56451/
---

(Updated Фев. 8, 2017, 6:40 п.п.)


Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-19345
https://issues.apache.org/jira/browse/AMBARI-19345


Repository: ambari


Description
---

Enable storm ui for https as per below document.
http://storm.apache.org/releases/1.0.1/SECURITY.html
Storm UI works fine and connect successfully using https.
However ambari alert for storm UI breaks, also ambari server keeps trying to 
fetch REST metrics using http instead of https.


Diffs (updated)
-

  
ambari-funtest/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json 
7c149bb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
 8c23fe0 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 8f0d218 
  ambari-server/src/main/resources/common-services/STORM/0.10.0/metrics.json 
b2b0404 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/alerts.json 
842538d 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/metrics.json 
43ed608 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/quicklinks/quicklinks.json
 492f0a0 
  ambari-server/src/main/resources/common-services/STORM/0.9.3/metrics.json 
d9a11b2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java
 8455484 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 4dffea8 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json 
7c149bb 

Diff: https://reviews.apache.org/r/56451/diff/


Testing
---

Unit and manual tests passed.


Thanks,

Dmytro Sen

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56418/#review164728
---


Fix it, then Ship it!




The code changes in this patch look fine to me, but I'd like to request two 
things:

1. Unit tests for this change be added to the patch
2. Some additional manual testing, mentioned below, to verify that the exported 
Blueprint will deploy properly. 

Thanks for providing this patch!


ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
 (line 75)


Overall, the changes look fine to me, but could you please add some unit 
tests for this change?  

If you could add some tests to the following:

org.apache.ambari.server.api.query.render.ClusterBlueprintRendererTest

that would be great.  

Thanks.



ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
 (line 76)


Could you also please try out some manual tests to use the exported 
Blueprint to create a new cluster? 

When changes to the export renderer are made, its always a good thing to 
try to make sure that the exported Blueprint is valid, and can be used for a 
successful cluster creation. 

Thanks.


- Robert Nettleton


On Feb. 8, 2017, 12:52 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56418/
> ---
> 
> (Updated Feb. 8, 2017, 12:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert 
> Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19909
> https://issues.apache.org/jira/browse/AMBARI-19909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Export Blueprints does not contain the settings object and hence the 
> credential store values
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
>  1a9ea91 
> 
> Diff: https://reviews.apache.org/r/56418/diff/
> 
> 
> Testing
> ---
> 
> Issued 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/credential?format=blueprint
>  command to ensure that the settings object is present.
> Resultant blueprint has the following object added:
> "settings" : [
> {
>   "recovery_settings" : [
> {
>   "recovery_enabled" : "true"
> }
>   ]
> },
> {
>   "service_settings" : [
> {
>   "name" : "OOZIE",
>   "credential_store_enabled" : "true"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "HIVE",
>   "credential_store_enabled" : "true"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "HDFS"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "AMBARI_METRICS"
> }
>   ]
> },
> {
>   "component_settings" : [
> {
>   "recovery_enabled" : "true",
>   "name" : "METRICS_COLLECTOR"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "SECONDARY_NAMENODE"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "WEBHCAT_SERVER"
> }
>   ]
> }
>   ]
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 56452: Some services weren't started after adding in Kerberize cluster

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56452/#review164719
---


Ship it!




Ship It!

- Robert Levas


On Feb. 8, 2017, 12:28 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56452/
> ---
> 
> (Updated Feb. 8, 2017, 12:28 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19927
> https://issues.apache.org/jira/browse/AMBARI-19927
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem consist in breaking proxyuser hosts properties with placeholders from 
> kerberos.json during "Add service" wizard.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py d4b9ab7 
> 
> Diff: https://reviews.apache.org/r/56452/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56452: Some services weren't started after adding in Kerberize cluster

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56452/#review164720
---




ambari-server/src/main/resources/stacks/stack_advisor.py (line 2243)


This can probably be simplified since we only really care the the pattern 
is something like:

```
${...}
```

What is in the middle of the curly brackets is irrelevant since the entire 
string is replaced and restored in its entirety.


- Robert Levas


On Feb. 8, 2017, 12:28 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56452/
> ---
> 
> (Updated Feb. 8, 2017, 12:28 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19927
> https://issues.apache.org/jira/browse/AMBARI-19927
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem consist in breaking proxyuser hosts properties with placeholders from 
> kerberos.json during "Add service" wizard.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py d4b9ab7 
> 
> Diff: https://reviews.apache.org/r/56452/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56276: AMBARI-19845 Secure Ranger passwords in Ambari Stacks

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56276/#review164717
---


Ship it!




Ship It!

- Jayush Luniya


On Feb. 7, 2017, 1:14 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56276/
> ---
> 
> (Updated Feb. 7, 2017, 1:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19845
> https://issues.apache.org/jira/browse/AMBARI-19845
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make sure plain-text password is not persisted in XML and always stored in 
> jceks
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  8fd5c8d 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  a12116d 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  0b4532b 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  3cb225f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
>  0067520 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-admin-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  742cb93 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  05e8881 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  0fd1766 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 
> b01e7da 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 
> 22e84fc 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> 57f9f34 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 
> 8dda363 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 
> bf5128e 
>   ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json 
> 2c4815b 
> 
> Diff: https://reviews.apache.org/r/56276/diff/
> 
> 
> Testing
> ---
> 
> Unit test result:
> 
> Ran 270 tests in 11.685s
> 
> OK
> --
> Total run:1172
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 56377: Log Search should use Credential Store API to store keystore/truststore passwords - ambari side

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56377/#review164715
---


Ship it!




Ship It!

- Jayush Luniya


On Feb. 7, 2017, 4:12 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56377/
> ---
> 
> (Updated Feb. 7, 2017, 4:12 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, Oliver Szabo, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19645
> https://issues.apache.org/jira/browse/AMBARI-19645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari modifications to enforce Log Search + Log Feeder to use the Credential 
> Store API to store keystore/truststore passwords.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  508ef4e 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  10b21be 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 2b95b78 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  08c0a7b 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  a04618f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  08d3d9d 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> 1c79c5c 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> f63cd42 
> 
> Diff: https://reviews.apache.org/r/56377/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 56453: AMBARI-19758 : Post Ambari upgrade AMS config properties changes are marking HDFS/YARN/Hive/HBase with restart required

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19758
https://issues.apache.org/jira/browse/AMBARI-19758


Repository: ambari


Description
---

Deploy Ambari-2.4 and upgrade to Ambari-2.5. Noticed that all core services are 
marked with restart required.

FIX
Removed hadoop-metrics2.properties.xml from common-services and moved it to the 
stack.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
 6b45e84 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
b1db696 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 642b63e 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 cf958f0 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/metainfo.xml 
14f15fc 

Diff: https://reviews.apache.org/r/56453/diff/


Testing
---

Manually tested Ambari upgrade from 2.4.0 to 2.5.0.


Thanks,

Aravindan Vijayan

Review Request 56452: Some services weren't started after adding in Kerberize cluster

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56452/
---

Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-19927
https://issues.apache.org/jira/browse/AMBARI-19927


Repository: ambari


Description
---

Problem consist in breaking proxyuser hosts properties with placeholders from 
kerberos.json during "Add service" wizard.


Diffs
-

  ambari-server/src/main/resources/stacks/stack_advisor.py d4b9ab7 

Diff: https://reviews.apache.org/r/56452/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/#review164705
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 8, 2017, 4:22 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56443/
> ---
> 
> (Updated Feb. 8, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19922
> https://issues.apache.org/jira/browse/AMBARI-19922
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding CSS class to deal such isssues.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
>  291def6 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
>  4fbd86b 
>   contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
> 0ab6cfd 
> 
> Diff: https://reviews.apache.org/r/56443/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 56451: Storm REST metrics are not available when Storm UI is running in HTTPS

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56451/
---

Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19345
https://issues.apache.org/jira/browse/AMBARI-19345


Repository: ambari


Description
---

Enable storm ui for https as per below document.
http://storm.apache.org/releases/1.0.1/SECURITY.html
Storm UI works fine and connect successfully using https.
However ambari alert for storm UI breaks, also ambari server keeps trying to 
fetch REST metrics using http instead of https.


Diffs
-

  
ambari-funtest/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json 
7c149bb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
 8c23fe0 
  ambari-server/src/main/resources/common-services/STORM/0.10.0/metrics.json 
b2b0404 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/alerts.json 
842538d 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/metrics.json 
43ed608 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/quicklinks/quicklinks.json
 492f0a0 
  ambari-server/src/main/resources/common-services/STORM/0.9.3/metrics.json 
d9a11b2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java
 8455484 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json 
7c149bb 

Diff: https://reviews.apache.org/r/56451/diff/


Testing
---

Unit and manual tests passed.


Thanks,

Dmytro Sen

Re: Review Request 56439: spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed

[Prabhjyot Singh]

> On Feb. 8, 2017, 3:30 p.m., Renjith Kamath wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py,
> >  line 336
> > 
> >
> > Livy is not always present, need a check for livy host.
> > 
> > error when livy is not installed:
> > ```
> > File 
> > "/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py",
> >  line 339, in update_zeppelin_interpreter
> > ":" + params.livy_livyserver_port
> > TypeError: cannot concatenate 'str' and 'NoneType' objects
> > ```

Sure, have update the diff.


- Prabhjyot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/#review164694
---


On Feb. 8, 2017, 5:04 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56439/
> ---
> 
> (Updated Feb. 8, 2017, 5:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19919
> https://issues.apache.org/jira/browse/AMBARI-19919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> spark/livy (1.x) should not be configured in Zeppelin's interpreter if they 
> are not installed.
> Also, if Spark2 and/or livy2 is available that should be configured by 
> default as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  9af48e5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  97e93fe 
> 
> Diff: https://reviews.apache.org/r/56439/diff/
> 
> 
> Testing
> ---
> 
> tested manually on Centos6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 56439: spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/
---

(Updated Feb. 8, 2017, 5:04 p.m.)


Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, 
Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit 
Mohanty.


Bugs: AMBARI-19919
https://issues.apache.org/jira/browse/AMBARI-19919


Repository: ambari


Description
---

spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are 
not installed.
Also, if Spark2 and/or livy2 is available that should be configured by default 
as well.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 9af48e5 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 97e93fe 

Diff: https://reviews.apache.org/r/56439/diff/


Testing
---

tested manually on Centos6.4


Thanks,

Prabhjyot Singh

Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/
---

(Updated Feb. 8, 2017, 4:22 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19922
https://issues.apache.org/jira/browse/AMBARI-19922


Repository: ambari


Description (updated)
---

Adding CSS class to deal such isssues.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
 291def6 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
 4fbd86b 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
0ab6cfd 

Diff: https://reviews.apache.org/r/56443/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/
---

(Updated Feb. 8, 2017, 4:22 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19922
https://issues.apache.org/jira/browse/AMBARI-19922


Repository: ambari


Description
---

Adding a helper to deal such isssues.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
 291def6 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
 4fbd86b 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
0ab6cfd 

Diff: https://reviews.apache.org/r/56443/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56407: Upgrade: Package Install stuck in "Installing" state forever

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56407/#review164697
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Лют. 8, 2017, 12:08 після полудня, Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56407/
> ---
> 
> (Updated Лют. 8, 2017, 12:08 після полудня)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sandor 
> Magyari, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19904
> https://issues.apache.org/jira/browse/AMBARI-19904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a command fails the all the other pending commands that belong to the 
> same request are aborted. In order the cluster state to be correctly 
> reflected the cluster state has to be recalculated for each aborted command 
> from all stages of the request.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
>  8aef70d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  7837a7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  dabcb98 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
>  ade625a 
> 
> Diff: https://reviews.apache.org/r/56407/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" 
> command failing on at least one agent.
> 
> Unit testing:
> mvn test -DskipPythonTests -am -pl ambari-server
> 
> Results :
> 
> Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 56444: Hive metastore restart failed after enabling credential store

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56444/#review164695
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 8, 2017, 1:41 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56444/
> ---
> 
> (Updated Feb. 8, 2017, 1:41 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19923
> https://issues.apache.org/jira/browse/AMBARI-19923
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent 0f791ca 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 9baaf08 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  e28cff8 
> 
> Diff: https://reviews.apache.org/r/56444/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56439: spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/#review164694
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 336)


Livy is not always present, need a check for livy host.

error when livy is not installed:
```
File 
"/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py",
 line 339, in update_zeppelin_interpreter
":" + params.livy_livyserver_port
TypeError: cannot concatenate 'str' and 'NoneType' objects
```


- Renjith Kamath


On Feb. 8, 2017, 11:40 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56439/
> ---
> 
> (Updated Feb. 8, 2017, 11:40 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19919
> https://issues.apache.org/jira/browse/AMBARI-19919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> spark/livy (1.x) should not be configured in Zeppelin's interpreter if they 
> are not installed.
> Also, if Spark2 and/or livy2 is available that should be configured by 
> default as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  9af48e5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  97e93fe 
> 
> Diff: https://reviews.apache.org/r/56439/diff/
> 
> 
> Testing
> ---
> 
> tested manually on Centos6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 56059: Broken kill_process_with_children shell single liner

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review164687
---




ambari-common/src/main/python/ambari_commons/process_utils.py (line 30)


Can we check the return code of every command which we run here. And give 
an informative exception in case it is non-zero. 
Saying which command failed with which output and which return code.



ambari-common/src/main/python/ambari_commons/process_utils.py (line 48)


Was this tested in non-root?
Should we maybe call it with ambari-sudo.sh to be able to kill 
sub-processes started as service users hdfs etc. when running in non-root


- Andrew Onischuk


On Feb. 8, 2017, 2:50 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56059/
> ---
> 
> (Updated Feb. 8, 2017, 2:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Dmytro 
> Grinenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-19768
> https://issues.apache.org/jira/browse/AMBARI-19768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This single liner does not work correctly in some cases
> {code}CMD = """ps xf | awk -v PID=""" + str(pid) + \
>   """ ' $1 == PID { P = $1; next } P && /_/ { P = P " " $1;""" + \
>   """K=P } P && !/_/ { P="" }  END { print "kill -""" \
>   + str(signal) + """ "K }' | sh """
> {code}
>   
> *Example*
> {code}((sleep 3141592) & ((sleep 3141592) & (sleep 3141592))
> 
> ps xf
> 
>  3231 ?Ss 0:01  \_ sshd: root@pts/0 
>  3233 pts/0Ss 0:00  |   \_ -bash
> 17984 pts/0S+ 0:00  |   \_ -bash
> 17985 pts/0S+ 0:00  |   \_ sleep 3141592
> 17986 pts/0S+ 0:00  |   \_ -bash
> 17987 pts/0S+ 0:00  |   \_ sleep 3141592
> 17988 pts/0S+ 0:00  |   \_ sleep 3141592
> 17738 ?Ss 0:00  \_ sshd: root@pts/1 
> 17740 pts/1Ss 0:00  \_ -bash
> 17989 pts/1R+ 0:00  \_ ps xf
> 
> ps xf | awk -v PID=17987 ' $1 == PID { P = $1; next } P && /_/ { P = P " " 
> $1;K=P } P && !/_/ { P="" }  END { print "kill "K }'
> 
> (PID=17987)
> result : "kill 17987 17988 17738 17740 18083 18084"
> but right will only "kill 17987"
> 
> (PID=17985)
> result : "kill 17985 17986 17987 17988 17738 17740 18697 18698"
> right : "kill 17985"
> 
> (PID=17986)
> result : "kill 17986 17987 17988 17738 17740 18980 18981"
> right : "kill 17986 17987 17988"
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py PRE-CREATION 
>   ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3 
>   ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION 
>   ambari-common/src/main/python/ambari_commons/shell.py 8d26599 
> 
> Diff: https://reviews.apache.org/r/56059/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 56059: Broken kill_process_with_children shell single liner

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/
---

(Updated Feb. 8, 2017, 4:50 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Dmytro 
Grinenko, Jonathan Hurley, and Nate Cole.


Changes
---

Removed yum staff, left only python implementation


Summary (updated)
-

Broken kill_process_with_children shell single liner


Bugs: AMBARI-19768
https://issues.apache.org/jira/browse/AMBARI-19768


Repository: ambari


Description (updated)
---

This single liner does not work correctly in some cases
{code}CMD = """ps xf | awk -v PID=""" + str(pid) + \
  """ ' $1 == PID { P = $1; next } P && /_/ { P = P " " $1;""" + \
  """K=P } P && !/_/ { P="" }  END { print "kill -""" \
  + str(signal) + """ "K }' | sh """
{code}
  
*Example*
{code}((sleep 3141592) & ((sleep 3141592) & (sleep 3141592))

ps xf

 3231 ?Ss 0:01  \_ sshd: root@pts/0 
 3233 pts/0Ss 0:00  |   \_ -bash
17984 pts/0S+ 0:00  |   \_ -bash
17985 pts/0S+ 0:00  |   \_ sleep 3141592
17986 pts/0S+ 0:00  |   \_ -bash
17987 pts/0S+ 0:00  |   \_ sleep 3141592
17988 pts/0S+ 0:00  |   \_ sleep 3141592
17738 ?Ss 0:00  \_ sshd: root@pts/1 
17740 pts/1Ss 0:00  \_ -bash
17989 pts/1R+ 0:00  \_ ps xf

ps xf | awk -v PID=17987 ' $1 == PID { P = $1; next } P && /_/ { P = P " " 
$1;K=P } P && !/_/ { P="" }  END { print "kill "K }'

(PID=17987)
result : "kill 17987 17988 17738 17740 18083 18084"
but right will only "kill 17987"

(PID=17985)
result : "kill 17985 17986 17987 17988 17738 17740 18697 18698"
right : "kill 17985"

(PID=17986)
result : "kill 17986 17987 17988 17738 17740 18980 18981"
right : "kill 17986 17987 17988"
{code}


Diffs (updated)
-

  ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py PRE-CREATION 
  ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3 
  ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION 
  ambari-common/src/main/python/ambari_commons/shell.py 8d26599 

Diff: https://reviews.apache.org/r/56059/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 56445: Ranger Admin HA Wizard should show all configuration changes on Review step

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56445/#review164680
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Feb. 8, 2017, 1:41 p.m., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56445/
> ---
> 
> (Updated Feb. 8, 2017, 1:41 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-19924
> https://issues.apache.org/jira/browse/AMBARI-19924
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Set of configuration changes to be made by Ranger Admin HA Wizard was added 
> in scope of AMBARI-19924. None of them are displayed on Review step as of now.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step3_controller.js
>  ea77d24 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js
>  c03c680 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/wizard_controller.js
>  fbb0692 
>   ambari-web/app/messages.js cb88fda 
>   ambari-web/app/routes/ra_high_availability_routes.js dbf653b 
>   
> ambari-web/test/controllers/main/admin/highAvailability/rangerAdmin/step3_controller_test.js
>  649bcbc 
> 
> Diff: https://reviews.apache.org/r/56445/diff/
> 
> 
> Testing
> ---
> 
> 20326 passing (19s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Re: Review Request 56444: Hive metastore restart failed after enabling credential store

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56444/
---

(Updated Feb. 8, 2017, 1:41 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19923
https://issues.apache.org/jira/browse/AMBARI-19923


Repository: ambari


Description (updated)
---

.


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent 0f791ca 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
9baaf08 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 e28cff8 

Diff: https://reviews.apache.org/r/56444/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 56445: Ranger Admin HA Wizard should show all configuration changes on Review step

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56445/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-19924
https://issues.apache.org/jira/browse/AMBARI-19924


Repository: ambari


Description
---

Set of configuration changes to be made by Ranger Admin HA Wizard was added in 
scope of AMBARI-19924. None of them are displayed on Review step as of now.


Diffs
-

  
ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step3_controller.js
 ea77d24 
  
ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js
 c03c680 
  
ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/wizard_controller.js
 fbb0692 
  ambari-web/app/messages.js cb88fda 
  ambari-web/app/routes/ra_high_availability_routes.js dbf653b 
  
ambari-web/test/controllers/main/admin/highAvailability/rangerAdmin/step3_controller_test.js
 649bcbc 

Diff: https://reviews.apache.org/r/56445/diff/


Testing
---

20326 passing (19s)
  153 pending


Thanks,

Andriy Babiichuk

Re: Review Request 56444: Hive metastore restart failed after enabling credential store

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56444/#review164678
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 8, 2017, 3:26 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56444/
> ---
> 
> (Updated Feb. 8, 2017, 3:26 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19923
> https://issues.apache.org/jira/browse/AMBARI-19923
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 9baaf08 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  e28cff8 
> 
> Diff: https://reviews.apache.org/r/56444/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 56444: Hive metastore restart failed after enabling credential store

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56444/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19923
https://issues.apache.org/jira/browse/AMBARI-19923


Repository: ambari


Description
---


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
9baaf08 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 e28cff8 

Diff: https://reviews.apache.org/r/56444/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/
---

(Updated Feb. 8, 2017, 1:11 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19922
https://issues.apache.org/jira/browse/AMBARI-19922


Repository: ambari


Description
---

Adding a helper to deal such isssues.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/helpers/truncate-text.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js fdb2cad 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
 291def6 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
 4fbd86b 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
0ab6cfd 

Diff: https://reviews.apache.org/r/56443/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 56443: HiveView2.0: Long table name spills out of table panel

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56443/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19922
https://issues.apache.org/jira/browse/AMBARI-19922


Repository: ambari


Description
---

Adding a helper to deal such isssues.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/helpers/truncate-text.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js fdb2cad 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
 291def6 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs
 4fbd86b 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
0ab6cfd 

Diff: https://reviews.apache.org/r/56443/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56438: Reset Workflow on newly created workflow blocks UI

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56438/#review164672
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 8, 2017, 11:37 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56438/
> ---
> 
> (Updated Feb. 8, 2017, 11:37 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19918
> https://issues.apache.org/jira/browse/AMBARI-19918
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reset Workflow on newly created workflow blocks UI.
> Steps.
> create new worklow. 
> create a node.
> click reset workflow.
> Observe that UI is blocked by some modal.
> 
> Expected behaviour-: the workflow should become empty workflow with only  
> start and end node.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 445b86e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> b045798 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  0b689b0 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 
> 86c8dc9 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 90fba0d 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 93ce758 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
>  b29ae21 
> 
> Diff: https://reviews.apache.org/r/56438/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56437: AMBARI-19917:Error to tag is not coming for the action node upon copying

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56437/#review164671
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 8, 2017, 11:30 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56437/
> ---
> 
> (Updated Feb. 8, 2017, 11:30 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19917
> https://issues.apache.org/jira/browse/AMBARI-19917
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a default error transition when creating a node.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 3ca20d2 
> 
> Diff: https://reviews.apache.org/r/56437/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56440: AMBARI-19920. Workfow Manger- Issue in flow graph active transitions in case of decision and fork.

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56440/#review164669
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 8, 2017, 12:13 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56440/
> ---
> 
> (Updated Feb. 8, 2017, 12:13 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19920
> https://issues.apache.org/jira/browse/AMBARI-19920
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Made all the transitions visited to green and not visited to grey
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> d0c5d11 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> e410262 
> 
> Diff: https://reviews.apache.org/r/56440/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 56440: AMBARI-19920. Workfow Manger- Issue in flow graph active transitions in case of decision and fork.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56440/#review164670
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 8, 2017, 12:13 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56440/
> ---
> 
> (Updated Feb. 8, 2017, 12:13 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19920
> https://issues.apache.org/jira/browse/AMBARI-19920
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Made all the transitions visited to green and not visited to grey
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> d0c5d11 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> e410262 
> 
> Diff: https://reviews.apache.org/r/56440/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 56441: Js errors appear when user try to delete widgets from dashboard

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56441/#review164668
---


Ship it!




Ship It!

- Andrii Tkach


On Feb. 8, 2017, 12:15 p.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56441/
> ---
> 
> (Updated Feb. 8, 2017, 12:15 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-19921
> https://issues.apache.org/jira/browse/AMBARI-19921
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Open Dashboard
> * Click on "Delete widget links" as fast as you can
> * JS-errors appears:
> 
> {noformat}
> Uncaught Error:  could not respond to event 
> didChangeData in state rootState.loaded.updated.uncommitted.
> {noformat}
> 
> {noformat}
> Uncaught TypeError: Cannot read property 'get' of null
> {noformat}
> 
> 
> Diffs
> -
> 
>   ambari-web/app/templates/main/dashboard/widgets.hbs 8e04f1c 
>   ambari-web/app/views/main/dashboard/widget.js cacac1a 
>   ambari-web/app/views/main/dashboard/widgets.js 0c6b7aa 
>   ambari-web/test/views/main/dashboard/widget_test.js 8582ad0 
>   ambari-web/test/views/main/dashboard/widgets_test.js b2d154b 
> 
> Diff: https://reviews.apache.org/r/56441/diff/
> 
> 
> Testing
> ---
> 
> 20338 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Re: Review Request 56440: AMBARI-19920. Workfow Manger- Issue in flow graph active transitions in case of decision and fork.

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56440/#review164667
---


Ship it!




Ship It!

- belliraj hb


On Feb. 8, 2017, 12:13 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56440/
> ---
> 
> (Updated Feb. 8, 2017, 12:13 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19920
> https://issues.apache.org/jira/browse/AMBARI-19920
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Made all the transitions visited to green and not visited to grey
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> d0c5d11 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> e410262 
> 
> Diff: https://reviews.apache.org/r/56440/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 56441: Js errors appear when user try to delete widgets from dashboard

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56441/
---

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-19921
https://issues.apache.org/jira/browse/AMBARI-19921


Repository: ambari


Description
---

* Open Dashboard
* Click on "Delete widget links" as fast as you can
* JS-errors appears:

{noformat}
Uncaught Error:  could not respond to event 
didChangeData in state rootState.loaded.updated.uncommitted.
{noformat}

{noformat}
Uncaught TypeError: Cannot read property 'get' of null
{noformat}


Diffs
-

  ambari-web/app/templates/main/dashboard/widgets.hbs 8e04f1c 
  ambari-web/app/views/main/dashboard/widget.js cacac1a 
  ambari-web/app/views/main/dashboard/widgets.js 0c6b7aa 
  ambari-web/test/views/main/dashboard/widget_test.js 8582ad0 
  ambari-web/test/views/main/dashboard/widgets_test.js b2d154b 

Diff: https://reviews.apache.org/r/56441/diff/


Testing
---

20338 passing (22s)
  153 pending


Thanks,

Oleg Nechiporenko

Re: Review Request 56437: AMBARI-19917:Error to tag is not coming for the action node upon copying

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56437/#review164666
---


Ship it!




Ship It!

- belliraj hb


On Feb. 8, 2017, 11:30 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56437/
> ---
> 
> (Updated Feb. 8, 2017, 11:30 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19917
> https://issues.apache.org/jira/browse/AMBARI-19917
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a default error transition when creating a node.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 3ca20d2 
> 
> Diff: https://reviews.apache.org/r/56437/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Review Request 56440: AMBARI-19920. Workfow Manger- Issue in flow graph active transitions in case of decision and fork.

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56440/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19920
https://issues.apache.org/jira/browse/AMBARI-19920


Repository: ambari


Description
---

Made all the transitions visited to green and not visited to grey


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
d0c5d11 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js e410262 

Diff: https://reviews.apache.org/r/56440/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 56438: Reset Workflow on newly created workflow blocks UI

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56438/#review164665
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 8, 2017, 11:37 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56438/
> ---
> 
> (Updated Feb. 8, 2017, 11:37 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19918
> https://issues.apache.org/jira/browse/AMBARI-19918
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reset Workflow on newly created workflow blocks UI.
> Steps.
> create new worklow. 
> create a node.
> click reset workflow.
> Observe that UI is blocked by some modal.
> 
> Expected behaviour-: the workflow should become empty workflow with only  
> start and end node.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 445b86e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> b045798 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  0b689b0 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 
> 86c8dc9 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 90fba0d 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 93ce758 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
>  b29ae21 
> 
> Diff: https://reviews.apache.org/r/56438/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 56439: spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, 
Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit 
Mohanty.


Bugs: AMBARI-19919
https://issues.apache.org/jira/browse/AMBARI-19919


Repository: ambari


Description
---

spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are 
not installed.
Also, if Spark2 and/or livy2 is available that should be configured by default 
as well.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 9af48e5 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 97e93fe 

Diff: https://reviews.apache.org/r/56439/diff/


Testing
---

tested manually on Centos6.4


Thanks,

Prabhjyot Singh

Review Request 56438: Reset Workflow on newly created workflow blocks UI

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56438/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19918
https://issues.apache.org/jira/browse/AMBARI-19918


Repository: ambari


Description
---

Reset Workflow on newly created workflow blocks UI.
Steps.
create new worklow. 
create a node.
click reset workflow.
Observe that UI is blocked by some modal.

Expected behaviour-: the workflow should become empty workflow with only  start 
and end node.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
445b86e 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
b045798 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
 0b689b0 
  contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 
86c8dc9 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
90fba0d 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 93ce758 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
 b29ae21 

Diff: https://reviews.apache.org/r/56438/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Review Request 56437: AMBARI-19917:Error to tag is not coming for the action node upon copying

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56437/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-19917
https://issues.apache.org/jira/browse/AMBARI-19917


Repository: ambari


Description
---

Added a default error transition when creating a node.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 3ca20d2 

Diff: https://reviews.apache.org/r/56437/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 56383: AMBARI-19889:Workflow Manager Should be able to handle fork with single path.

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56383/#review164663
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 7, 2017, 11:55 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56383/
> ---
> 
> (Updated Feb. 7, 2017, 11:55 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19889
> https://issues.apache.org/jira/browse/AMBARI-19889
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The fix was to make changes to find node for fork. Also if the import is a 
> simple object instead of array, we convert to array.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/findnode-mixin.js 
> c770fb023b 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 
> 28ea5278a1 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js db5bf1e996 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 900d692fac 
> 
> Diff: https://reviews.apache.org/r/56383/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Re: Review Request 56407: Upgrade: Package Install stuck in "Installing" state forever

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56407/#review164660
---


Ship it!




Ship It!

- Sandor Magyari


On Feb. 8, 2017, 10:08 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56407/
> ---
> 
> (Updated Feb. 8, 2017, 10:08 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sandor 
> Magyari, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19904
> https://issues.apache.org/jira/browse/AMBARI-19904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a command fails the all the other pending commands that belong to the 
> same request are aborted. In order the cluster state to be correctly 
> reflected the cluster state has to be recalculated for each aborted command 
> from all stages of the request.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
>  8aef70d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  7837a7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  dabcb98 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
>  ade625a 
> 
> Diff: https://reviews.apache.org/r/56407/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" 
> command failing on at least one agent.
> 
> Unit testing:
> mvn test -DskipPythonTests -am -pl ambari-server
> 
> Results :
> 
> Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 56407: Upgrade: Package Install stuck in "Installing" state forever

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56407/
---

(Updated Feb. 8, 2017, 11:08 a.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sandor 
Magyari, and Sid Wagle.


Bugs: AMBARI-19904
https://issues.apache.org/jira/browse/AMBARI-19904


Repository: ambari


Description
---

When a command fails the all the other pending commands that belong to the same 
request are aborted. In order the cluster state to be correctly reflected the 
cluster state has to be recalculated for each aborted command from all stages 
of the request.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
 8aef70d 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
 7837a7b 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 dabcb98 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
 ade625a 

Diff: https://reviews.apache.org/r/56407/diff/


Testing
---

Manually tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" 
command failing on at least one agent.

Unit testing:
mvn test -DskipPythonTests -am -pl ambari-server

Results :

Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39


Thanks,

Sebastian Toader

Re: Review Request 56115: Hive2: Unreasonable response time from query exeuction in hive view

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56115/#review164653
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 31, 2017, 9:10 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56115/
> ---
> 
> (Updated Jan. 31, 2017, 9:10 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19793
> https://issues.apache.org/jira/browse/AMBARI-19793
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Change the interval to 2 seconds.
> - disable button when query is in progress.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 753b7f7 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5cdc9b3 
> 
> Diff: https://reviews.apache.org/r/56115/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56384: Hive2: Query Runtime Prediction: Compact Visual Explain Plan

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56384/#review164652
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 7, 2017, 12:02 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56384/
> ---
> 
> (Updated Feb. 7, 2017, 12:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19890
> https://issues.apache.org/jira/browse/AMBARI-19890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Visual Explain Plan Feature.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/query.js ccda9d4 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js
>  919127f 
>   contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> b6434c0 
>   contrib/views/hive20/src/main/resources/ui/app/services/query.js 1799f71 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2f63854 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 62c97a2 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/bower.json a4ce788 
>   contrib/views/hive20/src/main/resources/ui/ember-cli-build.js e41c8e8 
> 
> Diff: https://reviews.apache.org/r/56384/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56115: Hive2: Unreasonable response time from query exeuction in hive view

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56115/#review164650
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 31, 2017, 9:10 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56115/
> ---
> 
> (Updated Jan. 31, 2017, 9:10 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19793
> https://issues.apache.org/jira/browse/AMBARI-19793
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Change the interval to 2 seconds.
> - disable button when query is in progress.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 753b7f7 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5cdc9b3 
> 
> Diff: https://reviews.apache.org/r/56115/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56384: Hive2: Query Runtime Prediction: Compact Visual Explain Plan

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56384/#review164649
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 7, 2017, 12:02 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56384/
> ---
> 
> (Updated Feb. 7, 2017, 12:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19890
> https://issues.apache.org/jira/browse/AMBARI-19890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Visual Explain Plan Feature.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/query.js ccda9d4 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js
>  919127f 
>   contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> b6434c0 
>   contrib/views/hive20/src/main/resources/ui/app/services/query.js 1799f71 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2f63854 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 62c97a2 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/bower.json a4ce788 
>   contrib/views/hive20/src/main/resources/ui/ember-cli-build.js e41c8e8 
> 
> Diff: https://reviews.apache.org/r/56384/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56345: Hive2 view UDF tab is blank always

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56345/#review164648
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 8, 2017, 7:04 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56345/
> ---
> 
> (Updated Feb. 8, 2017, 7:04 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19883
> https://issues.apache.org/jira/browse/AMBARI-19883
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UDF fearure
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/udf-edit.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/controllers/udfs/new.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/models/file-resource.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/models/udf.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/router.js 52361ff 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> b6434c0 
>   contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 8719170 
>   contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/services/file-resource.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/services/udf.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2f63854 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/fileresource-item.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-edit.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-new.hbs
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 62c97a2 
>   contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs b776fd2 
>   contrib/views/hive20/src/main/resources/ui/app/templates/udfs/new.hbs 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56345/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56402: Ambari scripts have 777 permission which is a major security concern (change came from 2.4.x)

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56402/#review164647
---


Ship it!




Ship It!

- Dmytro Sen


On Фев. 7, 2017, 8:40 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56402/
> ---
> 
> (Updated Фев. 7, 2017, 8:40 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-19902
> https://issues.apache.org/jira/browse/AMBARI-19902
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If we look at the below output these files have 777 perms : 
> {code}
> [root@h1 ~]# ll /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> -rwxrwxrwx. 1 root root 22471 Nov 23 07:40 
> /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py 
> 
> [root@h1 ~]# ll /var/lib/ambari-server/resources/scripts/configs.sh 
> -rwxrwxrwx. 1 root root 9801 Nov 23 07:27 
> /var/lib/ambari-server/resources/scripts/configs.sh 
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 79fa32c 
>   ambari-server/src/main/assemblies/server.xml d65232c 
> 
> Diff: https://reviews.apache.org/r/56402/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 56345: Hive2 view UDF tab is blank always

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56345/#review164645
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 8, 2017, 7:04 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56345/
> ---
> 
> (Updated Feb. 8, 2017, 7:04 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19883
> https://issues.apache.org/jira/browse/AMBARI-19883
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UDF fearure
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/udf-edit.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/controllers/udfs/new.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/models/file-resource.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/models/udf.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/router.js 52361ff 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> b6434c0 
>   contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 8719170 
>   contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/services/file-resource.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/services/udf.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2f63854 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/fileresource-item.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-edit.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-new.hbs
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 62c97a2 
>   contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs b776fd2 
>   contrib/views/hive20/src/main/resources/ui/app/templates/udfs/new.hbs 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56345/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>