Re: Review Request 56604: Zeppelin UI to support proxy access via Knox in Ambari

[Prabhjyot Singh]

> On Feb. 13, 2017, 6:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml,
> >  line 146
> > 
> >
> > What should the behavior be during a stack upgrade, say from HDP 2.5 to 
> > 2.6?
> > 
> > Should this config be changed only if the user hasn't modified it from 
> > its original value, or should it be forcibly changed to this new value?
> 
> Prabhjyot Singh wrote:
> Should I add "" here as well ? I thought 
> line:172 had it, hence not required.

Also, this feature was not there in HDP-2.5, so IMO upgrade wont apply for this.


- Prabhjyot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review165363
---


On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> ---
> 
> (Updated Feb. 13, 2017, 5:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin UI to support proxy access via Knox should get configured with 
> Ambari out-of-the-box.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml
>  3837019 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  febede3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  6862e4d 
> 
> Diff: https://reviews.apache.org/r/56604/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 56598: AMBARI-19985. Workflow Manager Styling changes

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56598/#review165458
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 13, 2017, 12:41 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56598/
> ---
> 
> (Updated Feb. 13, 2017, 12:41 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19985
> https://issues.apache.org/jira/browse/AMBARI-19985
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed the styling changes ie, changing action items to blue color
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 83a1b27 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> d1343b0 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 750ba62 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
>  623f2e0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  00e8b76 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
>  bca8dfa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs
>  044e053 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs
>  aafae4a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  80f3b14 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
>  33e3d56 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs
>  265da9f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
>  8865663 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> ef0758a 
> 
> Diff: https://reviews.apache.org/r/56598/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 56643: Hive View 2.0 upload table issues : char support, endline support and temp file deletion

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56643/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
and Rohit Choudhary.


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

following bugs in upload table feature have been resolved in this patch:
1. does not support to specify endlines in input file's fields
2. if column datatype is char or varchar it gives error.
3. temporary table does not get deleted if error occurs in table upload.
Options


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js 
066168c 
  contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 
29e9891 
  contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js 
b550dbe 
  contrib/views/hive20/src/main/resources/ui/app/models/column.js 73a9824 
  
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
 0e61905 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs
 c63f502 
  
contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs
 4f3b98a 

Diff: https://reviews.apache.org/r/56643/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 56622: AMBARI-19993 : Update atlas log-4j.xml configurations in ambari

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56622/#review165454
---


Ship it!




Ship It!

- Mugdha Varadkar


On Feb. 13, 2017, 10:37 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56622/
> ---
> 
> (Updated Feb. 13, 2017, 10:37 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19993
> https://issues.apache.org/jira/browse/AMBARI-19993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to update atlas-log4j configurations in ambari to reflect latest in 
> atlas.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml
>  95bc0ea 
> 
> Diff: https://reviews.apache.org/r/56622/diff/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-os 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Review Request 56641: Change Livy recovery folder permission to 0700

[Saisai Shao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56641/
---

Review request for Ambari, Jayush Luniya and Sumit Mohanty.


Bugs: AMBARI-17
https://issues.apache.org/jira/browse/AMBARI-17


Repository: ambari


Description
---

Change Livy recovery folder permission to 0700


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 32615c3 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
 2e92509 
  ambari-server/src/test/python/stacks/2.5/SPARK/test_spark_livy.py b9199c7 
  ambari-server/src/test/python/stacks/2.6/SPARK2/test_spark_livy2.py 75aec84 

Diff: https://reviews.apache.org/r/56641/diff/


Testing
---

Manual verification.


Thanks,

Saisai Shao

Re: Review Request 56603: AMBARI-19953: AMS HBase RegionServer process is still alive after switching AMS to embedded mode

[Qin Liu]

> On Feb. 13, 2017, 7:39 p.m., Aravindan Vijayan wrote:
> > Ship It!

Thank you very much Aravindan!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56603/#review165382
---


On Feb. 13, 2017, 7:22 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56603/
> ---
> 
> (Updated Feb. 13, 2017, 7:22 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19953
> https://issues.apache.org/jira/browse/AMBARI-19953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After switching AMS to embedded mode, AMS HBase region server process from 
> previous AMS configs is still alive.
> 
> Steps to reproduce:
> 1. install a cluster with AMS distributed mode
> 2. ps -elf | grep ams
> 3. switch AMS to embedded mode
> 4. restart AMS
> 5. ps -elf | grep ams and will see AMS HBase regionserver process from 
> previous AMS distributed configs is still alive
> 
> The fix is when AMS is in embedded mode, make sure no residual region server 
> process is running at collector stop.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  f423165 
>   
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py
>  7df74bf 
> 
> Diff: https://reviews.apache.org/r/56603/diff/
> 
> 
> Testing
> ---
> 
> The fix has been tested via HDP UI.
> The unit testcase test_metrics_collector.py has been updated to reflect the 
> change.
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 56488: Hive2: Invalid query execution not handled properly

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/
---

(Updated Feb. 14, 2017, 4:56 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Summary (updated)
-

Hive2: Invalid query execution not handled properly


Bugs: AMBARI-19938
https://issues.apache.org/jira/browse/AMBARI-19938


Repository: ambari


Description
---

- Showing notification on getting error. 
- Other code re-factor


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
  contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 1787cc7 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
88202ff 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 4d8524e 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs
 e0ceaa2 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5b2b5c2 

Diff: https://reviews.apache.org/r/56488/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 56638: Unable to stop service when master components is down

[Wang Jie]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56638/
---

Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-19998
https://issues.apache.org/jira/browse/AMBARI-19998


Repository: ambari


Description
---

Unable to stop service when master components is down


Diffs
-

  ambari-web/app/controllers/main/service/item.js a7ed493 
  ambari-web/test/controllers/main/service/item_test.js 6430ab6 

Diff: https://reviews.apache.org/r/56638/diff/


Testing
---

Done


Thanks,

Wang Jie

Re: Review Request 56598: AMBARI-19985. Workflow Manager Styling changes

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56598/#review165436
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 13, 2017, 12:41 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56598/
> ---
> 
> (Updated Feb. 13, 2017, 12:41 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19985
> https://issues.apache.org/jira/browse/AMBARI-19985
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed the styling changes ie, changing action items to blue color
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 83a1b27 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> d1343b0 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 750ba62 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
>  623f2e0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  00e8b76 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
>  bca8dfa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs
>  044e053 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs
>  aafae4a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  80f3b14 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
>  33e3d56 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs
>  265da9f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
>  8865663 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> ef0758a 
> 
> Diff: https://reviews.apache.org/r/56598/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 55817: AMBARI-19618 Make cohosted components configurable in metainfo.xml instead of hardcoding in UI

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55817/#review165432
---



I'm curious whether this feature allow cohosting of another service's 
components?

Eg:
Service A has components A1 and A2
Service B has components B1, B2 and B3
Can A1 be coHosted with B2, using this feature?


ambari-web/app/models/stack_service_component.js (line 189)


Should this still be a computed property on ```componentName```?
It should be changed to ```coHost```. Please double check Ember computed 
properties, before making this change.



ambari-web/test/mappers/stack_service_mapper_test.js (line 169)


Can we have a test case where ```coHost```s are defined both ways?

```
{
  "StackServiceComponents" : {
"component_name": "WEBHCAT_SERVER",
"co_host": "HIVE_SERVER"
   },
   "StackServiceComponents" : {
"component_name": "HIVE_SERVER",
"co_host": "WEBHCAT_SERVER"
   }
}
```

The above case should work without errors - even though it has duplicate 
information. Having this test case would make the UI more resilient to 
potential errors.

Is this already handled by the backend code?


- Matt


On Feb. 13, 2017, 5:20 p.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55817/
> ---
> 
> (Updated Feb. 13, 2017, 5:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, 
> and Matt.
> 
> 
> Bugs: AMBARI-19618
> https://issues.apache.org/jira/browse/AMBARI-19618
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cohosted components information now is hardcoded in 
> stack_service_component.js as following:
> 
> App.StackServiceComponent.coHost =
>{ 'WEBHCAT_SERVER': 'HIVE_SERVER' };
> 
> It's better to move them from javascript to metainfom.xml by adding tag 
> in stack like following:
> 
> //HIVE
> 
> WEBHCAT_SERVER
> WebHCat Server
> MASTER
> 1
> true
> true
> HIVE_SERVER
> 
> 
> //RANGER https://issues.apache.org/jira/browse/AMBARI-19557
> 
> RANGER_USERSYNC
> Ranger Usersync
> MASTER
> 1
> true
> RANGER_ADMIN
> 
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
>  2f42313 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
>  c731641 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  51d9847 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 409bcae 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml 
> 4ba3cf1 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml 
> a9db470 
>   ambari-server/src/main/resources/properties.json 72104a9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  af67f05 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  6e37ded 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  87a1fc7 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/metainfo.xml 
> 3224eac 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/RANGER/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml 
> edc5dfb 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/RANGER/metainfo.xml
>  PRE-CREATION 
>   ambari-web/app/mappers/stack_service_mapper.js 21c4db9 
>   ambari-web/app/models/stack_service_component.js eb6f2db 
>   ambari-web/test/mappers/stack_service_mapper_test.js 9da8b24 
>   ambari-web/test/service_components.js bcc4a29 
> 
> Diff: https://reviews.apache.org/r/55817/diff/
> 
> 
> Testing
> ---
> 
> 1.Ambari Web Unit Tests:
>   20307 passing (35s)
>   153 pending
> 
> 2.Ambari Server Unit Tests:
>   Failed tests:
>   ViewRegistryTest.testReadViewArchives:239->testReadViewArchives:466 
> expected: but was:
>   
> ViewRegistryTest.testReadViewArchives_removeUndeployed:244->testReadViewArchives:466
>  expected: but was:
>   
> ViewRegistryTest.testReadViewArchives_viewAutoInstanceCreation:254->testReadViewArchives:466
>  expected: but was:
>   Tests run: 4417, Failures: 3, Errors: 0, Skipped: 30
> 
> 3.Installed a cluster using RPM based on latest trunk codes and screenshots 
> attached in https://issues.apache.org/jira/browse/AMBARI-19618 show the 
> expected result.
> 
> 
> Thanks,
> 
> yao lei
> 

Re: Review Request 56604: Zeppelin UI to support proxy access via Knox in Ambari

[Prabhjyot Singh]

> On Feb. 13, 2017, 6:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml,
> >  line 146
> > 
> >
> > What should the behavior be during a stack upgrade, say from HDP 2.5 to 
> > 2.6?
> > 
> > Should this config be changed only if the user hasn't modified it from 
> > its original value, or should it be forcibly changed to this new value?

Should I add "" here as well ? I thought 
line:172 had it, hence not required.


- Prabhjyot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review165363
---


On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> ---
> 
> (Updated Feb. 13, 2017, 5:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin UI to support proxy access via Knox should get configured with 
> Ambari out-of-the-box.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml
>  3837019 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  febede3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  6862e4d 
> 
> Diff: https://reviews.apache.org/r/56604/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 56636: When yarn-site.xml is changed, MapReduce related components should be required to restart

[Yuanbo Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/
---

(Updated Feb. 14, 2017, 3 a.m.)


Review request for Ambari and Di Li.


Repository: ambari


Description
---

Some properties in yarn-site.xml are used by MR components, such as 
"yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml is 
modified.


Diffs
-

  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
25e242b 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 
14eae07 

Diff: https://reviews.apache.org/r/56636/diff/


Testing (updated)
---

The test failure in https://issues.apache.org/jira/browse/AMBARI-19911 is not 
related.


Thanks,

Yuanbo Liu

Review Request 56636: When yarn-site.xml is changed, MapReduce related components should be required to restart

[Yuanbo Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/
---

Review request for Ambari and Di Li.


Repository: ambari


Description
---

Some properties in yarn-site.xml are used by MR components, such as 
"yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml is 
modified.


Diffs
-

  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
25e242b 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 
14eae07 

Diff: https://reviews.apache.org/r/56636/diff/


Testing
---

The test failure in https://issues.apache.org/jira/browse/AMBARI-19911.


Thanks,

Yuanbo Liu

Re: Review Request 55817: AMBARI-19618 Make cohosted components configurable in metainfo.xml instead of hardcoding in UI

[yao lei]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55817/
---

(Updated 二月 14, 2017, 1:20 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, 
and Matt.


Bugs: AMBARI-19618
https://issues.apache.org/jira/browse/AMBARI-19618


Repository: ambari


Description
---

Cohosted components information now is hardcoded in stack_service_component.js 
as following:

App.StackServiceComponent.coHost =
   { 'WEBHCAT_SERVER': 'HIVE_SERVER' };

It's better to move them from javascript to metainfom.xml by adding tag 
in stack like following:

//HIVE

WEBHCAT_SERVER
WebHCat Server
MASTER
1
true
true
HIVE_SERVER


//RANGER https://issues.apache.org/jira/browse/AMBARI-19557

RANGER_USERSYNC
Ranger Usersync
MASTER
1
true
RANGER_ADMIN



Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
 2f42313 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
 c731641 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
51d9847 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
409bcae 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml 
4ba3cf1 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml 
a9db470 
  ambari-server/src/main/resources/properties.json 72104a9 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 af67f05 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 6e37ded 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
 87a1fc7 
  ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/metainfo.xml 
3224eac 
  
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/RANGER/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml 
edc5dfb 
  
ambari-server/src/test/resources/stacks/HDP/2.0.6/services/RANGER/metainfo.xml 
PRE-CREATION 
  ambari-web/app/mappers/stack_service_mapper.js 21c4db9 
  ambari-web/app/models/stack_service_component.js eb6f2db 
  ambari-web/test/mappers/stack_service_mapper_test.js 9da8b24 
  ambari-web/test/service_components.js bcc4a29 

Diff: https://reviews.apache.org/r/55817/diff/


Testing
---

1.Ambari Web Unit Tests:
  20307 passing (35s)
  153 pending

2.Ambari Server Unit Tests:
  Failed tests:
  ViewRegistryTest.testReadViewArchives:239->testReadViewArchives:466 
expected: but was:
  
ViewRegistryTest.testReadViewArchives_removeUndeployed:244->testReadViewArchives:466
 expected: but was:
  
ViewRegistryTest.testReadViewArchives_viewAutoInstanceCreation:254->testReadViewArchives:466
 expected: but was:
  Tests run: 4417, Failures: 3, Errors: 0, Skipped: 30

3.Installed a cluster using RPM based on latest trunk codes and screenshots 
attached in https://issues.apache.org/jira/browse/AMBARI-19618 show the 
expected result.


Thanks,

yao lei

Review Request 56627: Cluster deployment fails if cluster template has fewer host_groups than that in blueprint

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56627/
---

Review request for Ambari, Di Li and Robert Nettleton.


Bugs: AMBARI-19991
https://issues.apache.org/jira/browse/AMBARI-19991


Repository: ambari


Description
---

Cluster creation REST API request gets accepted when, cluster template does not 
list all the host_groups mentioned in the blueprint. But cluster deployment 
fails showing error message in the logs
Caused by: java.lang.IllegalArgumentException: 
TopologyManager.ConfigureClusterTask - prerequisites for config request 
processing not yet satisfied
at 
org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:908)
at 
org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:889)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
 d0a4df9 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
 1f31d05 

Diff: https://reviews.apache.org/r/56627/diff/


Testing
---

Tested manually, updated test cases


Thanks,

Amruta Borkar

Re: Review Request 56231: AMBARI-19829: Several HDFS/YARN widgets on Heatmaps show N/A

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56231/#review165406
---


Ship it!




Ship It!

- Aravindan Vijayan


On Feb. 2, 2017, 8:02 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56231/
> ---
> 
> (Updated Feb. 2, 2017, 8:02 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach and Dmytro Sen.
> 
> 
> Bugs: AMBARI-19829
> https://issues.apache.org/jira/browse/AMBARI-19829
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The following HDFS/YARN widgets on Heatmaps show N/A:
> 1. HDFS - HDFS Bytes Written, HDFS Bytes Read, DataNode Process Disk I/O 
> Utilization, and DataNode Process Network I/O Utilization
> 2. YARN - Container Failures
> 
> The issue was introduced by AMBARI-15835 "Rate metrics requesting widgets do 
> not show up on Ambari" which introduced rate metrics and applied rate metrics 
> to several HBASE/HDFS/YARN widgets on Summary pages as well as Heatmap pages. 
> Rate metrics work fine on Summary pages but they don't work on Heatmap pages 
> because current Heatmap design can only show point-in-time metrics and rate 
> metrics need a time range.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> bcfb2cc 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/widgets.json 
> 4a645b0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/YARN_widgets.json
>  4b76a17 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/YARN_widgets.json
>  782f21d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> 4a645b0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/YARN_widgets.json
>  782f21d 
> 
> Diff: https://reviews.apache.org/r/56231/diff/
> 
> 
> Testing
> ---
> 
> Manually tested in UI.
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Review Request 56625: Add PowerPC architecture support to contrib views

[Vi On]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56625/
---

Review request for Ambari.


Bugs: AMBARI-19994
https://issues.apache.org/jira/browse/AMBARI-19994


Repository: ambari


Description
---

Ambari builds currently fails on building hive, hive-jdbc, files, and hue views 
for powerpc.  The build tries to download an x86 version of nodejs.   The 
latest frontend-maven-plugin 1.3 supports powerpc architecture so we should 
update to version 1.3.


Diffs
-

  contrib/views/files/pom.xml 2e742df 
  contrib/views/files/src/main/resources/ui/package.json d15c5c9 
  contrib/views/hive-next/pom.xml 19f55ee 
  contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 6fe68e2 
  contrib/views/hive20/pom.xml cf5fdde 
  contrib/views/hive20/src/main/resources/ui/package.json a066bfd 
  contrib/views/hueambarimigration/pom.xml 891876d 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
 64b3270 

Diff: https://reviews.apache.org/r/56625/diff/


Testing
---

I'm able to compile successfully in x86 and powerpc architecture with this patch


Thanks,

Vi On

Review Request 56622: AMBARI-19993 : Update atlas log-4j.xml configurations in ambari

[Vishal Suvagia]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56622/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar, 
Oliver Szabo, Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-19993
https://issues.apache.org/jira/browse/AMBARI-19993


Repository: ambari


Description
---

Need to update atlas-log4j configurations in ambari to reflect latest in atlas.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml
 95bc0ea 

Diff: https://reviews.apache.org/r/56622/diff/


Testing
---

Verified fresh install on Cent-os 6.


Thanks,

Vishal Suvagia

Re: Review Request 56488: Hive2: xxx; never returns

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/#review165390
---




contrib/views/hive20/src/main/resources/ui/app/adapters/query.js (line 32)


Not using dateSubmitted anymore. Why keep it?



contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js (line 19)


What is the use of this controller?



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
130)


Why not set model as an empty worksheet?



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
233)


Seems to be that you forgot to handle this error situation.


- DIPAYAN BHOWMICK


On Feb. 13, 2017, 7:35 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56488/
> ---
> 
> (Updated Feb. 13, 2017, 7:35 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19938
> https://issues.apache.org/jira/browse/AMBARI-19938
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Showing notification on getting error. 
> - Other code re-factor
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
>   contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 1787cc7 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 88202ff 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
>  4d8524e 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs
>  e0ceaa2 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5b2b5c2 
> 
> Diff: https://reviews.apache.org/r/56488/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56603: AMBARI-19953: AMS HBase RegionServer process is still alive after switching AMS to embedded mode

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56603/#review165382
---


Ship it!




Ship It!

- Aravindan Vijayan


On Feb. 13, 2017, 7:22 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56603/
> ---
> 
> (Updated Feb. 13, 2017, 7:22 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19953
> https://issues.apache.org/jira/browse/AMBARI-19953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After switching AMS to embedded mode, AMS HBase region server process from 
> previous AMS configs is still alive.
> 
> Steps to reproduce:
> 1. install a cluster with AMS distributed mode
> 2. ps -elf | grep ams
> 3. switch AMS to embedded mode
> 4. restart AMS
> 5. ps -elf | grep ams and will see AMS HBase regionserver process from 
> previous AMS distributed configs is still alive
> 
> The fix is when AMS is in embedded mode, make sure no residual region server 
> process is running at collector stop.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  f423165 
>   
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py
>  7df74bf 
> 
> Diff: https://reviews.apache.org/r/56603/diff/
> 
> 
> Testing
> ---
> 
> The fix has been tested via HDP UI.
> The unit testcase test_metrics_collector.py has been updated to reflect the 
> change.
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 56488: Hive2: xxx; never returns

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/
---

(Updated Feb. 13, 2017, 7:35 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19938
https://issues.apache.org/jira/browse/AMBARI-19938


Repository: ambari


Description (updated)
---

- Showing notification on getting error. 
- Other code re-factor


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
  contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 1787cc7 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
88202ff 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 4d8524e 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs
 e0ceaa2 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5b2b5c2 

Diff: https://reviews.apache.org/r/56488/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56488: Hive2: xxx; never returns

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/
---

(Updated Feb. 13, 2017, 7:33 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19938
https://issues.apache.org/jira/browse/AMBARI-19938


Repository: ambari


Description
---

Added a modal for error.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
  contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 1787cc7 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
88202ff 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 4d8524e 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs
 e0ceaa2 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5b2b5c2 

Diff: https://reviews.apache.org/r/56488/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56605: Stop All services call failed to stop flume agent

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56605/#review165381
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 13, 2017, 5:22 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56605/
> ---
> 
> (Updated Feb. 13, 2017, 5:22 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19972
> https://issues.apache.org/jira/browse/AMBARI-19972
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario:
> * Install a cluster with Hadoop, Hive, Flume, Hbase, Spark
> * Enable Wire encryption
> ** While enabling wire encryption, script makes a rest call to stop all 
> services. In this instance the WE stop all service failed to stop flume agent 
> on one of the hosts 
> 
> As per cluster state, Ambari failed to stop a2 agent on Host4. However stderr 
> stack trace says it failed to stop a1 agent.
> {code:title=stderr}
> stderr:   /var/lib/ambari-agent/data/errors-203.txt
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py",
>  line 126, in 
> FlumeHandler().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 313, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py",
>  line 60, in stop
> flume(action='stop')
>   File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
> line 89, in thunk
> return fn(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py",
>  line 226, in flume
> raise Fail("Can't stop flume agent: {0}".format(agent))
> resource_management.core.exceptions.Fail: Can't stop flume agent: a1{code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
>  81b077f 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 4cf43c1 
> 
> Diff: https://reviews.apache.org/r/56605/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 56603: AMBARI-19953: AMS HBase RegionServer process is still alive after switching AMS to embedded mode

[Qin Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56603/
---

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.


Bugs: AMBARI-19953
https://issues.apache.org/jira/browse/AMBARI-19953


Repository: ambari


Description
---

After switching AMS to embedded mode, AMS HBase region server process from 
previous AMS configs is still alive.

Steps to reproduce:
1. install a cluster with AMS distributed mode
2. ps -elf | grep ams
3. switch AMS to embedded mode
4. restart AMS
5. ps -elf | grep ams and will see AMS HBase regionserver process from previous 
AMS distributed configs is still alive

The fix is when AMS is in embedded mode, make sure no residual region server 
process is running at collector stop.


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
 f423165 
  
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py
 7df74bf 

Diff: https://reviews.apache.org/r/56603/diff/


Testing
---

The fix has been tested via HDP UI.
The unit testcase test_metrics_collector.py has been updated to reflect the 
change.


Thanks,

Qin Liu

Re: Review Request 53686: Stage and Request status should be persisted in the database

[Jaimin Jetly]

> On Dec. 15, 2016, 4:49 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java,
> >  lines 445-447
> > 
> >
> > This could be problematic if the merge fails when the transaction 
> > commits. You've already fired the event.
> 
> Jaimin Jetly wrote:
> persistAction method has been annotated with @Transactional and 
> @TransactionalLock.
> I believe if the publisher method is marked to be transactional then the 
> event listener will also fall in that transactional boundary considering that 
> the eventbus being used over here is default which I believe is synchronous. 
> 
> I will verify this myself by checking that publsiher method, eventbus and 
> subscriber method are running on same thread.
> 
> Jaimin Jetly wrote:
> I verified that the publisher and subscriber code runs on same thread and 
> so transactional boundary will extend for the entire logic making sure that 
> tasks and respective stage/request are consistent in their status
> 
> Jonathan Hurley wrote:
> Although it may be true that the event bus is synchronous here, the point 
> is that the merge() which comes before it doesn't necessarily count until the 
> entire transaction is committed. By firing the event in this code, you're 
> assuming that the merge() will succeed once the batches operations are 
> flushed and the transaction is commited. If the listener modifies any sort of 
> in-memory state, then this causes a data integrity problem.

Thats true. 
The in-memory state can become inconsistent in that case. Meaning in-memory 
state of the listener can have most updated status data but DB that failed to 
merge can have stale status data. Although all data in the DB even though stale 
is consistent even at this point of time.

Now listener will again try to update DB on next heratbeat and will get 
consistent with DB when merge happens next time.


> On Dec. 15, 2016, 4:49 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java,
> >  lines 282-287
> > 
> >
> > Would this count states like FAILED / TIMEDOUT twice?
> 
> Jaimin Jetly wrote:
> yes. It will increment the FAILED counter and also increment COMPLETED 
> counter which is desired.
> 
> Jonathan Hurley wrote:
> Why is this desired? Double counting them doesn't seem right.

The COMPLETED key is represents any completed state 
hrc.getStatus().isCompletedState() and thats how it's used in subsequent 
function.
So on getting FAILED state we are incrementing both completed and Failed

This code is a copy of existing code logic: 
https://github.com/apache/ambari/blob/release-2.4.2/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java#L235-L240


On Dec. 15, 2016, 4:49 p.m., Jaimin Jetly wrote:
> > One thing I don't quite see here (and it could be due to the size of the 
> > patch) is what happens in these two cases:
> > - Something goes wrong when trying to store a task's status. How does the 
> > system recover and mark it completed?
> > - What about waiting until a request is HOLDING and then restarting Ambari 
> > - will the relevent maps get re-populated?
> 
> Jaimin Jetly wrote:
> >> - Something goes wrong when trying to store a task's status. How does 
> the system recover and mark it completed?
> 
> This work only adds logic to add/update stage and request status. The way 
> task status is being updated or the logic for system to recover from anything 
> that goes wrong when storing task status is not changed.
> This work ensures that task status update, respective stage status update 
> and respective request status update happens inside same transactional 
> boundary. Thus all three entities remains consistent in the status they show. 
> This work does not add any recovery logic and piggybacks on existing 
> failure recovery mechanism for updating task status. Thus if something goes 
> wrong storing task status then stage/request status will also be not store 
> and vice-versa. Next time when ambari-agent sends command reports again then 
> task update and respective stage/request status update should also also get 
> updated successfully. 
> 
> >> -  What about waiting until a request is HOLDING and then restarting 
> Ambari - will the relevent maps get re-populated?
> 
> Yes, everytime ambari-server starts, we check for all stages in 
> HostRoleStatus.IN_PROGRESS_STATUSES and publish an event with the tasks. 
> these will repopulate the maps. The patch adds that logic with 
> "publishInProgressTasks(stages)" method in ActionScheduler.java
> 
> I have tested that scenario of restarting ambari-server when a request is 
> ongoing with in progress tasks and validat

Re: Review Request 56607: AMBARI-19915 Add Ranger KMS SSL properties in ambari stack

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56607/#review165378
---




ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 (line 148)


Today, we have symlinks from /etc/$comp/conf -> /usr/hdp/current/$comp/conf 
so that configs still work during stack upgrades (RU/EU). This seems to be a 
flat directory.

How is it going to be used?
What will happen during stack upgrades or downgrades?


- Alejandro Fernandez


On Feb. 13, 2017, 7:14 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56607/
> ---
> 
> (Updated Feb. 13, 2017, 7:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19915
> https://issues.apache.org/jira/browse/AMBARI-19915
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Below SSL properties needs to be added in Ambari for Ranger KMS service
> - ranger.service.https.attrib.keystore.file
> - ranger.service.https.attrib.client.auth
> - ranger.service.https.attrib.keystore.keyalias  
> - ranger.service.https.attrib.keystore.pass
> - ranger.credential.provider.path
> - ranger.service.https.attrib.keystore.credential.alias
> 
> Along with addition of these properties, need to secure password property.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  8fd5c8d 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml
>  7dea07f 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  742cb93 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  05e8881 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  0fd1766 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 54072ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  c64d6ed 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 58db4a9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 44a9b7c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  92c5902 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 30b5d13 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 23564ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  75515a5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> b83525a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER_KMS/configuration/ranger-kms-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 969c3dd 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> 57f9f34 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> b7f8cbb 
> 
> Diff: https://reviews.apache.org/r/56607/diff/
> 
> 
> Testing
> ---
> 
> Test Case:
> 
> Running tests for stack:2.5 service:RANGER_KMS
> test_configure_default (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,451 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-777, current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
> 2017-02-13 19:08:27,467 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> ok
> test_configure_secured (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,502 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> 2017-02-13 19:08:27,518 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> ok
> test_start_default (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,533 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-777, current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
> 2017-02-13 19:08:27,550 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> 2017-02-13 19:08:27,555 - Rangeradmin: Skip ranger admin if it's down !
> ok
> test_start_secured (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,568 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> 2017-02-13 19:08:27,597 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> 2017-02-13 19:08:27,602 - RangeradminV2: Skip range

Re: Review Request 56606: Allow user to view Tez View after executing query

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/#review165373
---




contrib/views/hive20/src/main/resources/ui/app/adapters/query.js (line 51)


Please check, seems like typo.



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 24)


spelling?



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 30)


Move these to the service or function as constants as described in the 
other comment



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
125)


Too much of tez related logic inside a route, can you move this to a 
stateless service or utility functions.



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
236)


In a pure ember way routes should not contain view logic. Please fix this.



contrib/views/hive20/src/main/resources/ui/app/services/job-data.js (line 21)


Why is this service required?



contrib/views/hive20/src/main/resources/ui/app/services/jobs.js (line 39)


Why are you sending job model object when _fetchDummyResult() expects the 
job id.


- DIPAYAN BHOWMICK


On Feb. 13, 2017, 6:52 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56606/
> ---
> 
> (Updated Feb. 13, 2017, 6:52 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19989
> https://issues.apache.org/jira/browse/AMBARI-19989
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As per the parity with Hive View 1.5, allow user to traverse to tez view from 
> the query page after executing a query.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js 
> a25adc7 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
>   contrib/views/hive20/src/main/resources/ui/app/components/tez-ui.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 88202ff 
>   contrib/views/hive20/src/main/resources/ui/app/services/job-data.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 8503715 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/tez-ui.hbs
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5b2b5c2 
> 
> Diff: https://reviews.apache.org/r/56606/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 56607: AMBARI-19915 Add Ranger KMS SSL properties in ambari stack

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56607/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
and Velmurugan Periasamy.


Bugs: AMBARI-19915
https://issues.apache.org/jira/browse/AMBARI-19915


Repository: ambari


Description
---

Below SSL properties needs to be added in Ambari for Ranger KMS service
- ranger.service.https.attrib.keystore.file
- ranger.service.https.attrib.client.auth
- ranger.service.https.attrib.keystore.keyalias  
- ranger.service.https.attrib.keystore.pass
- ranger.credential.provider.path
- ranger.service.https.attrib.keystore.credential.alias

Along with addition of these properties, need to secure password property.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 8fd5c8d 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml
 7dea07f 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 742cb93 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 05e8881 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 0fd1766 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
54072ad 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 c64d6ed 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
58db4a9 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
44a9b7c 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 92c5902 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
30b5d13 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
23564ad 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 75515a5 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
b83525a 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER_KMS/configuration/ranger-kms-site.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
969c3dd 
  ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
57f9f34 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py b7f8cbb 

Diff: https://reviews.apache.org/r/56607/diff/


Testing
---

Test Case:

Running tests for stack:2.5 service:RANGER_KMS
test_configure_default (test_kms_server.TestRangerKMS) ... 2017-02-13 
19:08:27,451 - Stack Feature Version Info: stack_version=2.5, 
version=2.5.0.0-777, current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
2017-02-13 19:08:27,467 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
ok
test_configure_secured (test_kms_server.TestRangerKMS) ... 2017-02-13 
19:08:27,502 - Stack Feature Version Info: stack_version=2.5, 
version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
2017-02-13 19:08:27,518 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
ok
test_start_default (test_kms_server.TestRangerKMS) ... 2017-02-13 19:08:27,533 
- Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-777, 
current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
2017-02-13 19:08:27,550 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
2017-02-13 19:08:27,555 - Rangeradmin: Skip ranger admin if it's down !
ok
test_start_secured (test_kms_server.TestRangerKMS) ... 2017-02-13 19:08:27,568 
- Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-801, 
current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
2017-02-13 19:08:27,597 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
2017-02-13 19:08:27,602 - RangeradminV2: Skip ranger admin if it's down !
2017-02-13 19:08:27,602 - KMS repository c1_kms exist
ok
test_stop_default (test_kms_server.TestRangerKMS) ... 2017-02-13 19:08:27,618 - 
Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-777, 
current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
2017-02-13 19:08:27,639 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
ok

--
Ran 5 tests in 0.277s

OK

test_recommendRangerKMSConfigurations 
(test_stack_advisor.TestHDP26StackAdvisor) ... ok


Thanks,

Mugdha Varadkar

Re: Review Request 56573: Increase default timeout for RM

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56573/#review165377
---




ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
 (line 130)


Please also make this change in YARN 3.0.0.3.0 in common-services.


- Alejandro Fernandez


On Feb. 11, 2017, 3:38 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56573/
> ---
> 
> (Updated Feb. 11, 2017, 3:38 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19977
> https://issues.apache.org/jira/browse/AMBARI-19977
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
>  fcd9380 
> 
> Diff: https://reviews.apache.org/r/56573/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56606: Allow user to view Tez View after executing query

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/#review165368
---




contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js (line 
24)


Looks like this is by mistake. pls check.



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
306)


remove un-necessary blank lines.



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
536)


space


- Pallav Kulshreshtha


On Feb. 13, 2017, 6:52 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56606/
> ---
> 
> (Updated Feb. 13, 2017, 6:52 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19989
> https://issues.apache.org/jira/browse/AMBARI-19989
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As per the parity with Hive View 1.5, allow user to traverse to tez view from 
> the query page after executing a query.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js 
> a25adc7 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
>   contrib/views/hive20/src/main/resources/ui/app/components/tez-ui.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 88202ff 
>   contrib/views/hive20/src/main/resources/ui/app/services/job-data.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 8503715 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/tez-ui.hbs
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5b2b5c2 
> 
> Diff: https://reviews.apache.org/r/56606/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56394: Provide user-warning while upgrading clusters to move certificates/keystores/truststores out of conf folder

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56394/#review165366
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 10, 2017, 12:07 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56394/
> ---
> 
> (Updated Feb. 10, 2017, 12:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19897
> https://issues.apache.org/jira/browse/AMBARI-19897
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As certificates/ keystores/ truststores present in /etc/ranger/*/conf path, 
> this may affect the upgrade scenarios, where user needs to manually move the 
> files to new conf directories.
> Hence users upgrading to new stacks should be warned on prior basis to do the 
> same manually (i.e move certificates/keystores/truststores out of conf 
> folder).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  8d8f540 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerSSLConfigCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  8da11ff 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 01fc102 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  046904b 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 70bb2ca 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  5b8351b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 2f07c97 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RangerSSLConfigCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56394/diff/
> 
> 
> Testing
> ---
> 
> Verified upgrade process after fresh install on Cent-os 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Review Request 56606: Allow user to view Tez View after executing query

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19989
https://issues.apache.org/jira/browse/AMBARI-19989


Repository: ambari


Description
---

As per the parity with Hive View 1.5, allow user to traverse to tez view from 
the query page after executing a query.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js 
a25adc7 
  contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
  contrib/views/hive20/src/main/resources/ui/app/components/tez-ui.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
88202ff 
  contrib/views/hive20/src/main/resources/ui/app/services/job-data.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 8503715 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/tez-ui.hbs 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5b2b5c2 

Diff: https://reviews.apache.org/r/56606/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56599: ambari-server upgrade is not idempotent

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165364
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 13, 2017, 1:48 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56604: Zeppelin UI to support proxy access via Knox in Ambari

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/#review165363
---




ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
 (line 146)


What should the behavior be during a stack upgrade, say from HDP 2.5 to 2.6?

Should this config be changed only if the user hasn't modified it from its 
original value, or should it be forcibly changed to this new value?


- Alejandro Fernandez


On Feb. 13, 2017, 5:13 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56604/
> ---
> 
> (Updated Feb. 13, 2017, 5:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19988
> https://issues.apache.org/jira/browse/AMBARI-19988
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin UI to support proxy access via Knox should get configured with 
> Ambari out-of-the-box.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml
>  3837019 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  febede3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  6862e4d 
> 
> Diff: https://reviews.apache.org/r/56604/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 56545: AMBARI-19959. Allow skipping view extraction in ambari-server setup

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56545/#review165360
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 10, 2017, 2:21 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56545/
> ---
> 
> (Updated Feb. 10, 2017, 2:21 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19959
> https://issues.apache.org/jira/browse/AMBARI-19959
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added `--skip-view-extraction` flag, defaults to false.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari-server.py 
> 5d4f5d7b66f1e34061a3b5d1eddfe3cf931bd23f 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 
> 8a06034933b44cc9070b2d031dddad3505280c98 
>   ambari-server/src/test/python/TestAmbariServer.py 
> 7dae7c0af5211d180294a867743445aba2f105ac 
> 
> Diff: https://reviews.apache.org/r/56545/diff/
> 
> 
> Testing
> ---
> 
> Manual tested:
> 
> ```
> # ambari-server setup --silent
> [...]
> Creating tables...
> done.
> Extracting system views...
> ...ambari-admin-3.0.0.0.255.jar
> ..
> Adjusting ambari-server permissions and ownership...
> Ambari Server 'setup' completed successfully.
> 
> # ambari-server setup --silent --skip-view-extraction
> [...]
> Creating tables...
> done.
> Adjusting ambari-server permissions and ownership...
> Ambari Server 'setup' completed successfully.
> ```
> 
> 
> Unit tests:
> 
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests -DfailIfNoTests=false clean 
> test
> ...
> Total run:1183
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] Ambari Server . SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 56605: Stop All services call failed to stop flume agent

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56605/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Sumit Mohanty, 
and Sid Wagle.


Bugs: AMBARI-19972
https://issues.apache.org/jira/browse/AMBARI-19972


Repository: ambari


Description
---

Scenario:
* Install a cluster with Hadoop, Hive, Flume, Hbase, Spark
* Enable Wire encryption
** While enabling wire encryption, script makes a rest call to stop all 
services. In this instance the WE stop all service failed to stop flume agent 
on one of the hosts 

As per cluster state, Ambari failed to stop a2 agent on Host4. However stderr 
stack trace says it failed to stop a1 agent.
{code:title=stderr}
stderr:   /var/lib/ambari-agent/data/errors-203.txt

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py",
 line 126, in 
FlumeHandler().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 313, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py",
 line 60, in stop
flume(action='stop')
  File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
line 89, in thunk
return fn(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py",
 line 226, in flume
raise Fail("Can't stop flume agent: {0}".format(agent))
resource_management.core.exceptions.Fail: Can't stop flume agent: a1{code}


Diffs
-

  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
 81b077f 
  ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 4cf43c1 

Diff: https://reviews.apache.org/r/56605/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 56604: Zeppelin UI to support proxy access via Knox in Ambari

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56604/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, 
Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit 
Mohanty.


Bugs: AMBARI-19988
https://issues.apache.org/jira/browse/AMBARI-19988


Repository: ambari


Description
---

Zeppelin UI to support proxy access via Knox should get configured with Ambari 
out-of-the-box.


Diffs
-

  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml
 3837019 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 febede3 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
 6862e4d 

Diff: https://reviews.apache.org/r/56604/diff/


Testing
---

Manually tested on CentOS


Thanks,

Prabhjyot Singh

Re: Review Request 56602: Oozie start failed after enabling credential store

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56602/#review165346
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 13, 2017, 3:58 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56602/
> ---
> 
> (Updated Feb. 13, 2017, 3:58 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-19987
> https://issues.apache.org/jira/browse/AMBARI-19987
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Oozie server start failed after enabling credential store.
> 
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
>  line 222, in 
> OozieServer().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 313, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
>  line 91, in start
> oozie_service(action='start', upgrade_type=upgrade_type)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
> line 89, in thunk
> return fn(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py",
>  line 109, in oozie_service
> user=params.oozie_user,
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
> line 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 262, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 72, in inner
> result = function(command, **kwargs)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 102, in checked_call
> tries=tries, try_sleep=try_sleep, 
> timeout_kill_strategy=timeout_kill_strategy)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 150, in _call_wrapper
> result = _call(command, **kwargs_copy)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 303, in _call
> raise ExecutionFailed(err_msg, code, out, err)
> resource_management.core.exceptions.ExecutionFailed: Execution of 
> '/base/tools/jdk1.8.0_112/bin/java -cp 
> /usr/lib/ambari-agent/DBConnectionVerification.jar:/usr/hdp/current/oozie-server/libext/mysql-connector-java.jar
>  org.apache.ambari.server.DBConnectionVerification 
> 'jdbc:mysql://172.27.15.193/ooziedb' oozieuser [PROTECTED] 
> com.mysql.jdbc.Driver' returned 1.  Hortonworks #
> This is MOTD message, added for testing in qe infra
> ERROR: Unable to connect to the DB. Please check DB connection properties.
> java.sql.SQLException: Access denied for user 
> 'oozieuser'@'ctr-e127-1486658464320-0864-01-04.hwx.site' (using password: 
> NO)
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> bacda46 
>   ambari-common/src/main/python/ambari_commons/credential_store_helper.py 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
>  4091ee8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  0d5c174 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
>  e4401a1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> cf36a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> e223eed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  2082048 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/p

Review Request 56602: Oozie start failed after enabling credential store

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56602/
---

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-19987
https://issues.apache.org/jira/browse/AMBARI-19987


Repository: ambari


Description
---

Oozie server start failed after enabling credential store.


Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
 line 222, in 
OozieServer().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 313, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
 line 91, in start
oozie_service(action='start', upgrade_type=upgrade_type)
  File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
line 89, in thunk
return fn(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py",
 line 109, in oozie_service
user=params.oozie_user,
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 262, in action_run
tries=self.resource.tries, try_sleep=self.resource.try_sleep)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
line 72, in inner
result = function(command, **kwargs)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
line 102, in checked_call
tries=tries, try_sleep=try_sleep, 
timeout_kill_strategy=timeout_kill_strategy)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
line 150, in _call_wrapper
result = _call(command, **kwargs_copy)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
line 303, in _call
raise ExecutionFailed(err_msg, code, out, err)
resource_management.core.exceptions.ExecutionFailed: Execution of 
'/base/tools/jdk1.8.0_112/bin/java -cp 
/usr/lib/ambari-agent/DBConnectionVerification.jar:/usr/hdp/current/oozie-server/libext/mysql-connector-java.jar
 org.apache.ambari.server.DBConnectionVerification 
'jdbc:mysql://172.27.15.193/ooziedb' oozieuser [PROTECTED] 
com.mysql.jdbc.Driver' returned 1.  Hortonworks #
This is MOTD message, added for testing in qe infra
ERROR: Unable to connect to the DB. Please check DB connection properties.
java.sql.SQLException: Access denied for user 
'oozieuser'@'ctr-e127-1486658464320-0864-01-04.hwx.site' (using password: 
NO)


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
bacda46 
  ambari-common/src/main/python/ambari_commons/credential_store_helper.py 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
 4091ee8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 0d5c174 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
 e4401a1 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
cf36a8b 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
e223eed 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 2082048 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 a32fbfb 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 eb438e7 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 1c742ef 

Diff: https://reviews.apache.org/r/56602/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 56599: ambari-server upgrade is not idempotent

[Attila Magyar]

> On Feb. 13, 2017, 3:49 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java,
> >  lines 243-251
> > 
> >
> > Any reason you didn't use a Set here (especially since the contract 
> > only defines a Collection)?

The existing code uses ArrayList. I'm not sure if it will break anything if I 
change it to Set.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165341
---


On Feb. 13, 2017, 1:48 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56599: ambari-server upgrade is not idempotent

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165341
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
 (lines 243 - 251)


Any reason you didn't use a Set here (especially since the contract only 
defines a Collection)?


- Jonathan Hurley


On Feb. 13, 2017, 8:48 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 8:48 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56552: Ambari Server Unit Test Failures

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56552/#review165339
---


Ship it!




Ship It!

- Robert Levas


On Feb. 10, 2017, 12:41 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56552/
> ---
> 
> (Updated Feb. 10, 2017, 12:41 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-19967
> https://issues.apache.org/jira/browse/AMBARI-19967
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The `AlertDataManagerTest` is exposing a problem with concurrent creation of 
> alert groups where an exception is thrown during concurrent UT creation due 
> to a UNIQUE violation:
> 
> javax.persistence.PersistenceException:
> Exception [EclipseLink-4002] (Eclipse Persistence Services - 
> 2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
> Internal Exception: org.h2.jdbc.JdbcSQLException: Unique index or primary key 
> violation: "UNQ_ALERT_GROUP_0_INDEX_9 ON AMBARI.ALERT_GROUP(CLUSTER_ID, 
> GROUP_NAME) VALUES (1, 'HDFS', 2)"; SQL statement:
> INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
> service_name) VALUES (?, ?, ?, ?, ?) [23505-193]
> Error Code: 23505
> Call: INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
> service_name) VALUES (?, ?, ?, ?, ?)
>   bind => [5 parameters bound]
>   at 
> org.apache.ambari.server.state.cluster.AlertDataManagerTest.setup(AlertDataManagerTest.java:149)
> 
> This is actually a problem both in the tests and the code for Ambari. We can 
> replace one of the locks and also synchronize the event publishing.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
>  703ff58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
>  3b9c97a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
>  b660631 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
>  1ec6d40 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
>  4ad93e6 
> 
> Diff: https://reviews.apache.org/r/56552/diff/
> 
> 
> Testing
> ---
> 
> Results :
> 
> Tests run: 4912, Failures: 0, Errors: 0, Skipped: 39
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 17:10 min
> [INFO] Finished at: 2017-02-10T11:42:49-05:00
> [INFO] Final Memory: 62M/662M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 56599: ambari-server upgrade is not idempotent

[Laszlo Puskas]

> On Feb. 13, 2017, 3:08 p.m., Laszlo Puskas wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java,
> >  line 1672
> > 
> >
> > Instead mocking tehe injector itself, add a module where instances are 
> > bound to mocks.
> 
> Attila Magyar wrote:
> Tried it but didn't work, there are other dependencies that should be 
> initialized.
> 
> Laszlo Puskas wrote:
> Dropped as binding classes to instances cause the framework to interpret

annotations and tries to inject all dependencies.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165330
---


On Feb. 13, 2017, 1:48 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56599: ambari-server upgrade is not idempotent

[Laszlo Puskas]

> On Feb. 13, 2017, 3:08 p.m., Laszlo Puskas wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java,
> >  line 1672
> > 
> >
> > Instead mocking tehe injector itself, add a module where instances are 
> > bound to mocks.
> 
> Attila Magyar wrote:
> Tried it but didn't work, there are other dependencies that should be 
> initialized.

Dropped as binding classes to instances cause the framework to interpret


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165330
---


On Feb. 13, 2017, 1:48 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56599: ambari-server upgrade is not idempotent

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165337
---


Ship it!




Ship It!

- Robert Levas


On Feb. 13, 2017, 8:48 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 8:48 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56599: ambari-server upgrade is not idempotent

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165335
---


Ship it!




Ship It!

- Nate Cole


On Feb. 13, 2017, 8:48 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 8:48 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56599: ambari-server upgrade is not idempotent

[Attila Magyar]

> On Feb. 13, 2017, 3:08 p.m., Laszlo Puskas wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java,
> >  line 1672
> > 
> >
> > Instead mocking tehe injector itself, add a module where instances are 
> > bound to mocks.

Tried it but didn't work, there are other dependencies that should be 
initialized.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165330
---


On Feb. 13, 2017, 1:48 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56599: ambari-server upgrade is not idempotent

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165330
---




ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 (line 1666)


Instead mocking tehe injector itself, add a module where instances are 
bound to mocks.


- Laszlo Puskas


On Feb. 13, 2017, 1:48 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56600: Default group permissions for the user home directories created by the post user creation script should be 'hdfs' instead of 'hadoop'

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56600/#review165324
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 13, 2017, 2:24 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56600/
> ---
> 
> (Updated Feb. 13, 2017, 2:24 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19986
> https://issues.apache.org/jira/browse/AMBARI-19986
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default group permissions for the user home directories created by the post 
> user creation script should be 'hdfs' instead of 'hadoop'
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/post-user-creation-hook.sh 91511a0 
> 
> Diff: https://reviews.apache.org/r/56600/diff/
> 
> 
> Testing
> ---
> 
> Manually, underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 56600: Default group permissions for the user home directories created by the post user creation script should be 'hdfs' instead of 'hadoop'

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56600/#review165323
---


Ship it!




Ship It!

- Attila Magyar


On Feb. 13, 2017, 1:24 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56600/
> ---
> 
> (Updated Feb. 13, 2017, 1:24 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19986
> https://issues.apache.org/jira/browse/AMBARI-19986
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default group permissions for the user home directories created by the post 
> user creation script should be 'hdfs' instead of 'hadoop'
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/post-user-creation-hook.sh 91511a0 
> 
> Diff: https://reviews.apache.org/r/56600/diff/
> 
> 
> Testing
> ---
> 
> Manually, underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 56600: Default group permissions for the user home directories created by the post user creation script should be 'hdfs' instead of 'hadoop'

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56600/#review165322
---


Ship it!




Ship It!

- Attila Doroszlai


On Feb. 13, 2017, 2:24 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56600/
> ---
> 
> (Updated Feb. 13, 2017, 2:24 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19986
> https://issues.apache.org/jira/browse/AMBARI-19986
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default group permissions for the user home directories created by the post 
> user creation script should be 'hdfs' instead of 'hadoop'
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/post-user-creation-hook.sh 91511a0 
> 
> Diff: https://reviews.apache.org/r/56600/diff/
> 
> 
> Testing
> ---
> 
> Manually, underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Review Request 56599: ambari-server upgrade is not idempotent

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/
---

Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
Levas, and Sebastian Toader.


Bugs: AMBARI-19984
https://issues.apache.org/jira/browse/AMBARI-19984


Repository: ambari


Description
---

Running ambari-upgrade multiple times cause an exception due to violation of 
unique database constraint (the same RoleAuthorization can be added multiple 
times to admin permissions).


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
 fb01cca 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 4b33bcd 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
 0cd4f12f 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 1c742ef 

Diff: https://reviews.apache.org/r/56599/diff/


Testing
---

Added new unittest that checks if adding RoleAuthorization is idempotent.

Tested manually:
 - installed ambari 2.4
 - upgraded to ambari 2.5
 - set version back to 2.4 by running: update metainfo set metainfo_value = 
'2.4.0' where metainfo_key = 'version';
 - upgraded to ambari 2.5 again
 - started ambari-server checked the UI


Existing tests ran clealy

--
Ran 465 tests in 15.977s

Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39


Thanks,

Attila Magyar

Re: Review Request 56552: Ambari Server Unit Test Failures

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56552/#review165321
---


Ship it!




Ship It!

- Nate Cole


On Feb. 10, 2017, 12:41 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56552/
> ---
> 
> (Updated Feb. 10, 2017, 12:41 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-19967
> https://issues.apache.org/jira/browse/AMBARI-19967
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The `AlertDataManagerTest` is exposing a problem with concurrent creation of 
> alert groups where an exception is thrown during concurrent UT creation due 
> to a UNIQUE violation:
> 
> javax.persistence.PersistenceException:
> Exception [EclipseLink-4002] (Eclipse Persistence Services - 
> 2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
> Internal Exception: org.h2.jdbc.JdbcSQLException: Unique index or primary key 
> violation: "UNQ_ALERT_GROUP_0_INDEX_9 ON AMBARI.ALERT_GROUP(CLUSTER_ID, 
> GROUP_NAME) VALUES (1, 'HDFS', 2)"; SQL statement:
> INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
> service_name) VALUES (?, ?, ?, ?, ?) [23505-193]
> Error Code: 23505
> Call: INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
> service_name) VALUES (?, ?, ?, ?, ?)
>   bind => [5 parameters bound]
>   at 
> org.apache.ambari.server.state.cluster.AlertDataManagerTest.setup(AlertDataManagerTest.java:149)
> 
> This is actually a problem both in the tests and the code for Ambari. We can 
> replace one of the locks and also synchronize the event publishing.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
>  703ff58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
>  3b9c97a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
>  b660631 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
>  1ec6d40 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
>  4ad93e6 
> 
> Diff: https://reviews.apache.org/r/56552/diff/
> 
> 
> Testing
> ---
> 
> Results :
> 
> Tests run: 4912, Failures: 0, Errors: 0, Skipped: 39
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 17:10 min
> [INFO] Finished at: 2017-02-10T11:42:49-05:00
> [INFO] Final Memory: 62M/662M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 56600: Default group permissions for the user home directories created by the post user creation script should be 'hdfs' instead of 'hadoop'

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56600/
---

Review request for Ambari, Attila Doroszlai, Attila Magyar, and Sebastian 
Toader.


Bugs: AMBARI-19986
https://issues.apache.org/jira/browse/AMBARI-19986


Repository: ambari


Description
---

Default group permissions for the user home directories created by the post 
user creation script should be 'hdfs' instead of 'hadoop'


Diffs
-

  ambari-server/src/main/resources/scripts/post-user-creation-hook.sh 91511a0 

Diff: https://reviews.apache.org/r/56600/diff/


Testing
---

Manually, underway.


Thanks,

Laszlo Puskas

Re: Review Request 56598: AMBARI-19985. Workflow Manager Styling changes

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56598/#review165318
---


Ship it!




Ship It!

- belliraj hb


On Feb. 13, 2017, 12:41 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56598/
> ---
> 
> (Updated Feb. 13, 2017, 12:41 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19985
> https://issues.apache.org/jira/browse/AMBARI-19985
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed the styling changes ie, changing action items to blue color
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 83a1b27 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> d1343b0 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 750ba62 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
>  623f2e0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  00e8b76 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
>  bca8dfa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs
>  044e053 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs
>  aafae4a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  80f3b14 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
>  33e3d56 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs
>  265da9f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
>  8865663 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> ef0758a 
> 
> Diff: https://reviews.apache.org/r/56598/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 56598: AMBARI-19985. Workflow Manager Styling changes

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56598/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19985
https://issues.apache.org/jira/browse/AMBARI-19985


Repository: ambari


Description
---

Fixed the styling changes ie, changing action items to blue color


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
83a1b27 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
d1343b0 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 750ba62 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
 623f2e0 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 00e8b76 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
 bca8dfa 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs
 044e053 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs
 aafae4a 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
 80f3b14 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
 33e3d56 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs
 265da9f 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
 8865663 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js ef0758a 

Diff: https://reviews.apache.org/r/56598/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 56596: Admin View: issues with Users/Groups table filters

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56596/#review165312
---


Ship it!




Ship It!

- Andrii Tkach


On Feb. 13, 2017, 11:49 a.m., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56596/
> ---
> 
> (Updated Feb. 13, 2017, 11:49 a.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-19982
> https://issues.apache.org/jira/browse/AMBARI-19982
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. 'Clear filters' link for Users and Groups tables in Admin View is 
> displayed even if no filter is enabled.
> 2. Clearing filters on Groups table results in displaying Users table.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
>  3737414 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js
>  42fb453 
> 
> Diff: https://reviews.apache.org/r/56596/diff/
> 
> 
> Testing
> ---
> 
> Executed 80 of 80 SUCCESS (0.413 secs / 0.408 secs)
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Re: Review Request 56574: Perf: Deploy 3000 Agent cluster and find perf bugs. Part 5

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56574/#review165311
---


Ship it!




Ship It!

- Dmytro Sen


On Фев. 11, 2017, 10:51 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56574/
> ---
> 
> (Updated Фев. 11, 2017, 10:51 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19058
> https://issues.apache.org/jira/browse/AMBARI-19058
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed component dependency issue during BP deploy
> Fixed "select limit" issue for db during deploy via BP.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHBASE/metainfo.xml
>  4dbd2bb 
>   contrib/utils/perf/deploy-gce-perf-cluster.py 6364122 
> 
> Diff: https://reviews.apache.org/r/56574/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 56589: Hive1 View in Ambari shows wrong status

[Rohit Choudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56589/#review165310
---


Ship it!




Ship It!

- Rohit Choudhary


On Feb. 13, 2017, 7:42 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56589/
> ---
> 
> (Updated Feb. 13, 2017, 7:42 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19980
> https://issues.apache.org/jira/browse/AMBARI-19980
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Setting job status to Error if job call fail.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index/history-query/logs.js
>  2b5fd26 
> 
> Diff: https://reviews.apache.org/r/56589/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 56597: Externalize the logic for making navigation bar interactive

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56597/
---

Review request for Ambari and Jaimin Jetly.


Bugs: AMBARI-19983
https://issues.apache.org/jira/browse/AMBARI-19983


Repository: ambari


Description
---

Externalize the logic for making navigation bar interactive


Diffs
-

  ambari-web/app/assets/data/clusters/info.json PRE-CREATION 
  ambari-web/app/styles/side_navigation.less 48b8699 
  ambari-web/app/styles/theme/bootstrap-ambari.css adbddcd 
  ambari-web/app/templates/application.hbs f18d314 
  ambari-web/app/templates/main/side-menu-item.hbs 27739c8 
  ambari-web/app/views/application.js f79aad9 
  ambari-web/app/views/main/menu.js d82d56a 
  ambari-web/brunch-config.js d646fdc 
  ambari-web/vendor/scripts/theme/bootstrap-ambari.js PRE-CREATION 

Diff: https://reviews.apache.org/r/56597/diff/


Testing
---

20325 passing (22s)
  153 pending


Thanks,

Oleg Nechiporenko

Review Request 56596: Admin View: issues with Users/Groups table filters

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56596/
---

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-19982
https://issues.apache.org/jira/browse/AMBARI-19982


Repository: ambari


Description
---

1. 'Clear filters' link for Users and Groups tables in Admin View is displayed 
even if no filter is enabled.
2. Clearing filters on Groups table results in displaying Users table.


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
 3737414 
  
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js
 42fb453 

Diff: https://reviews.apache.org/r/56596/diff/


Testing
---

Executed 80 of 80 SUCCESS (0.413 secs / 0.408 secs)


Thanks,

Andriy Babiichuk

Re: Review Request 56589: Hive1 View in Ambari shows wrong status

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56589/#review165306
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 13, 2017, 7:42 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56589/
> ---
> 
> (Updated Feb. 13, 2017, 7:42 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19980
> https://issues.apache.org/jira/browse/AMBARI-19980
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Setting job status to Error if job call fail.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index/history-query/logs.js
>  2b5fd26 
> 
> Diff: https://reviews.apache.org/r/56589/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>