Re: Review Request 57019: HiveView2.0: No notifications for successful query which yields no output.

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57019/
---

(Updated Feb. 24, 2017, 7:35 a.m.)


Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20162
https://issues.apache.org/jira/browse/AMBARI-20162


Repository: ambari


Description
---

- Added successful message for query
- Clean up visual explain code.
- Fix intermittent results null issue.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
16103b7 
  
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js
 ff3832d 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 273cd90 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs 
db1cea2 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs
 370e3ef 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs
 9bf2b2a 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs
 ef441b5 

Diff: https://reviews.apache.org/r/57019/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 57019: HiveView2.0: No notifications for successful query which yields no output.

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57019/
---

Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20162
https://issues.apache.org/jira/browse/AMBARI-20162


Repository: ambari


Description
---

- Added successful message for query
- Clean up visual explain code.
- Fix intermittent results null issue.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
16103b7 
  
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js
 ff3832d 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 273cd90 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs 
db1cea2 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs
 370e3ef 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs
 9bf2b2a 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs
 ef441b5 

Diff: https://reviews.apache.org/r/57019/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 57004: AMBARI-20158 - Host filter is missing for admin user after upgrading to ambari 2.4.2 or above

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/
---

(Updated Feb. 24, 2017, 2:27 a.m.)


Review request for Ambari and Jaimin Jetly.


Bugs: AMBARI-20158
https://issues.apache.org/jira/browse/AMBARI-20158


Repository: ambari


Description
---

Always show host combo search.
Merge instead of overwrite support list after loading user-pref.


Diffs
-

  ambari-web/app/config.js 6afa810 
  ambari-web/app/controllers/experimental.js 8b93761 
  ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df 

Diff: https://reviews.apache.org/r/57004/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  20375 passing (23s)
  153 pending


File Attachments (updated)


AMBARI-20158-fix1.patch
  
https://reviews.apache.org/media/uploaded/files/2017/02/24/67d30316-bcff-4d49-80b7-afeffe9d703a__AMBARI-20158-fix1.patch


Thanks,

Richard Zang

Re: Review Request 57004: AMBARI-20158 - Host filter is missing for admin user after upgrading to ambari 2.4.2 or above

[Richard Zang]

> On Feb. 24, 2017, 1:38 a.m., Jaimin Jetly wrote:
> > ambari-web/app/controllers/experimental.js, line 38
> > 
> >
> > $.merge(response, App.get('supports')) returns back the first argument 
> > passed. As a result the application behavior remains the same as it was 
> > before this patch
> > 
> > Please use $.extend instead of $.merge.

$.merge is for array, will adjust to $.extend


- Richard


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/#review166629
---


On Feb. 23, 2017, 11:52 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57004/
> ---
> 
> (Updated Feb. 23, 2017, 11:52 p.m.)
> 
> 
> Review request for Ambari and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-20158
> https://issues.apache.org/jira/browse/AMBARI-20158
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Always show host combo search.
> Merge instead of overwrite support list after loading user-pref.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 6afa810 
>   ambari-web/app/controllers/experimental.js 8b93761 
>   ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df 
> 
> Diff: https://reviews.apache.org/r/57004/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20375 passing (23s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 57000: EU: Manual Step without any context after "All Service Checks" fail

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57000/
---

(Updated Feb. 23, 2017, 8:47 p.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-20155
https://issues.apache.org/jira/browse/AMBARI-20155


Repository: ambari


Description
---

During EU from 2.5.3.0-2.6.0.0, a manual step popped up that didn't make sense.
It says "Manual steps required [] I have performed the manual steps above." 
without telling the user what the manual steps are.

The BE is not providing a message for display.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
 cfe4a78 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
 b9e27be 

Diff: https://reviews.apache.org/r/57000/diff/


Testing (updated)
---

Manual.  Automated:

Results :

Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39


Thanks,

Nate Cole

Re: Review Request 57004: AMBARI-20158 - Host filter is missing for admin user after upgrading to ambari 2.4.2 or above

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/#review166629
---




ambari-web/app/controllers/experimental.js (line 38)


$.merge(response, App.get('supports')) returns back the first argument 
passed. As a result the application behavior remains the same as it was before 
this patch

Please use $.extend instead of $.merge.


- Jaimin Jetly


On Feb. 23, 2017, 11:52 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57004/
> ---
> 
> (Updated Feb. 23, 2017, 11:52 p.m.)
> 
> 
> Review request for Ambari and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-20158
> https://issues.apache.org/jira/browse/AMBARI-20158
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Always show host combo search.
> Merge instead of overwrite support list after loading user-pref.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 6afa810 
>   ambari-web/app/controllers/experimental.js 8b93761 
>   ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df 
> 
> Diff: https://reviews.apache.org/r/57004/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20375 passing (23s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 57008: Side Nav: multiple fixes after integrated to trunk

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57008/#review166628
---


Ship it!




Ship It!

- Richard Zang


On Feb. 24, 2017, 12:35 a.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57008/
> ---
> 
> (Updated Feb. 24, 2017, 12:35 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20160
> https://issues.apache.org/jira/browse/AMBARI-20160
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to fix the following issues after integrated the Side Navi Bar and Top 
> Bar to trunk:
> 1. Service actions dropdown might positioned incorrectly sometimes.
> 2. If the scrollbar shows up, sometimes it is on top of the actions dropdown 
> menu.
> 3. Alerts Panel: change alert definition name into 14px in #333
> 4. Remove menu on Admin page, it is duplicated 
> 5. Alerts Panel: red alerts cnt circle should be able to display large 
> numbers. eg 99, 999,  .etc
> 6. FireFox issue: alert description not limited. should be limited to 3 lines
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less cb94a54 
>   ambari-web/app/styles/theme/bootstrap-ambari.css d88a1ed 
>   ambari-web/app/styles/top-nav.less 8c373ce 
>   ambari-web/app/templates/main/admin.hbs d1dfe74 
>   ambari-web/vendor/scripts/theme/bootstrap-ambari.js 1c81aeb 
> 
> Diff: https://reviews.apache.org/r/57008/diff/
> 
> 
> Testing
> ---
> 
> 20375 passing (37s)
> 153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Review Request 57008: Side Nav: multiple fixes after integrated to trunk

[Xi Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57008/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-20160
https://issues.apache.org/jira/browse/AMBARI-20160


Repository: ambari


Description
---

Need to fix the following issues after integrated the Side Navi Bar and Top Bar 
to trunk:
1. Service actions dropdown might positioned incorrectly sometimes.
2. If the scrollbar shows up, sometimes it is on top of the actions dropdown 
menu.
3. Alerts Panel: change alert definition name into 14px in #333
4. Remove menu on Admin page, it is duplicated 
5. Alerts Panel: red alerts cnt circle should be able to display large numbers. 
eg 99, 999,  .etc
6. FireFox issue: alert description not limited. should be limited to 3 lines


Diffs
-

  ambari-web/app/styles/application.less cb94a54 
  ambari-web/app/styles/theme/bootstrap-ambari.css d88a1ed 
  ambari-web/app/styles/top-nav.less 8c373ce 
  ambari-web/app/templates/main/admin.hbs d1dfe74 
  ambari-web/vendor/scripts/theme/bootstrap-ambari.js 1c81aeb 

Diff: https://reviews.apache.org/r/57008/diff/


Testing
---

20375 passing (37s)
153 pending


Thanks,

Xi Wang

Re: Review Request 57004: AMBARI-20158 - Host filter is missing for admin user after upgrading to ambari 2.4.2 or above

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/#review166613
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 23, 2017, 11:52 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57004/
> ---
> 
> (Updated Feb. 23, 2017, 11:52 p.m.)
> 
> 
> Review request for Ambari and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-20158
> https://issues.apache.org/jira/browse/AMBARI-20158
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Always show host combo search.
> Merge instead of overwrite support list after loading user-pref.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 6afa810 
>   ambari-web/app/controllers/experimental.js 8b93761 
>   ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df 
> 
> Diff: https://reviews.apache.org/r/57004/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20375 passing (23s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 57004: AMBARI-20158 - Host filter is missing for admin user after upgrading to ambari 2.4.2 or above

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/
---

Review request for Ambari and Jaimin Jetly.


Bugs: AMBARI-20158
https://issues.apache.org/jira/browse/AMBARI-20158


Repository: ambari


Description
---

Always show host combo search.
Merge instead of overwrite support list after loading user-pref.


Diffs
-

  ambari-web/app/config.js 6afa810 
  ambari-web/app/controllers/experimental.js 8b93761 
  ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df 

Diff: https://reviews.apache.org/r/57004/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  20375 passing (23s)
  153 pending


Thanks,

Richard Zang

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/#review166606
---


Ship it!




Ship It!

- Jayush Luniya


On Feb. 23, 2017, 11:24 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56727/
> ---
> 
> (Updated Feb. 23, 2017, 11:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20034
> https://issues.apache.org/jira/browse/AMBARI-20034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  5c4f08e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b601893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  3b88ac9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  8a35c98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 978ecd7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 34c2941 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 56fcd74 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  30a1533 
>   ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  a748b33 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  19df802 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  63a9e9c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  c40ff64 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  8fad94e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  87a1fc7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
>   
> ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/configuration/hadoop-env.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56727/diff/
> 
> 
> Testing
> ---
> 
> Unit Tests
> ===
> --
> Total run:1174
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:35 min
> [INFO] Finished at: 2017-02-23T09:50:38-08:00
> [INFO] Final Memory: 64M/634M
> [INFO] 
> 
> 
> 
> Manual Testing for Zeppelin.
> ===
> Steps:
> 1. Make changes to 
> /resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
> /resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
> ```xml
> 
>   zeppelin_user
>   zeppelin
> USER
>   User zeppelin daemon runs as
> 
>   user
>   false
>   
>   
>   zeppelin-env
>   zeppelin_group
>   
>   
>   hadoop-env
>   proxyuser_group
>   
>   
> 
> 
> 
> ```
> 
> 2. Deploy a cluster with Zeppelin
> 
> 3. Check commands-json for addition of user_group in hostLevelParams for 
> following scenarios
>   a. Start Zeppelin - AmbariManagementControllerImpl code path
>   b. Restart Zeppelin - AmbariCustomCommandExecutionHelper code path
>   c. ClientConfigResourceProviderTest - ClientConfigResourceProvider code 
> path
> 
> [root@mradha22-1 data]# grep user_group command-552.json
> "user_group": "{\"zeppelin\":[\"zeppelin\",\"users\"]}",
> 
> 4. Verify if the user_group map is getting appended to the existing 
> user_group_dict
>   Comment the hard-coded logic for zeppelin user and group in 
> 

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/
---

(Updated Feb. 23, 2017, 11:24 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

Added some docs


Bugs: AMBARI-20034
https://issues.apache.org/jira/browse/AMBARI-20034


Repository: ambari


Description
---

USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 5c4f08e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b601893 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 3b88ac9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 8a35c98 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
978ecd7 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
34c2941 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
56fcd74 
  ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 30a1533 
  ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 a748b33 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 19df802 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 63a9e9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 c40ff64 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 8fad94e 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
 87a1fc7 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
  
ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/configuration/hadoop-env.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56727/diff/


Testing
---

Unit Tests
===
--
Total run:1174
Total errors:0
Total failures:0
OK
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 21:35 min
[INFO] Finished at: 2017-02-23T09:50:38-08:00
[INFO] Final Memory: 64M/634M
[INFO] 


Manual Testing for Zeppelin.
===
Steps:
1. Make changes to 
/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
/resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
```xml

zeppelin_user
zeppelin
USER
User zeppelin daemon runs as

user
false


zeppelin-env
zeppelin_group


hadoop-env
proxyuser_group





```

2. Deploy a cluster with Zeppelin

3. Check commands-json for addition of user_group in hostLevelParams for 
following scenarios
a. Start Zeppelin - AmbariManagementControllerImpl code path
b. Restart Zeppelin - AmbariCustomCommandExecutionHelper code path
c. ClientConfigResourceProviderTest - ClientConfigResourceProvider code 
path

[root@mradha22-1 data]# grep user_group command-552.json
"user_group": "{\"zeppelin\":[\"zeppelin\",\"users\"]}",

4. Verify if the user_group map is getting appended to the existing 
user_group_dict
Comment the hard-coded logic for zeppelin user and group in 
stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
#if has_zeppelin_master:
#user_to_groups_dict[zeppelin_user] = [zeppelin_group, user_group]
#zeppelin_user = 
config['configurations']['zeppelin-env']["zeppelin_user"]
#zeppelin_group = 
config['configurations']['zeppelin-env']["zeppelin_group"]

[root@mradha22-1 data]# grep Madhu output-*.txt
output-502.txt\:Madhu defaultdict( at 0x13880c8>, 
{'ambari-qa': ['users'], 'zeppelin': ['zeppelin', 'users']})
2017-02-15 22:21:48,575 - User['hdfs'] {'gid': 'hadoop', 
'fetch_nonlocal_groups': True, 'groups': ['hadoop']}

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/#review166603
---




ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 565)


Can you add documentation to the new methods


- Jayush Luniya


On Feb. 23, 2017, 10:42 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56727/
> ---
> 
> (Updated Feb. 23, 2017, 10:42 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20034
> https://issues.apache.org/jira/browse/AMBARI-20034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  5c4f08e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b601893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  3b88ac9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  8a35c98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 978ecd7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 34c2941 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 56fcd74 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  30a1533 
>   ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  a748b33 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  19df802 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  63a9e9c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  c40ff64 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  8fad94e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  87a1fc7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
>   
> ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/configuration/hadoop-env.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56727/diff/
> 
> 
> Testing
> ---
> 
> Unit Tests
> ===
> --
> Total run:1174
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:35 min
> [INFO] Finished at: 2017-02-23T09:50:38-08:00
> [INFO] Final Memory: 64M/634M
> [INFO] 
> 
> 
> 
> Manual Testing for Zeppelin.
> ===
> Steps:
> 1. Make changes to 
> /resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
> /resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
> ```xml
> 
>   zeppelin_user
>   zeppelin
> USER
>   User zeppelin daemon runs as
> 
>   user
>   false
>   
>   
>   zeppelin-env
>   zeppelin_group
>   
>   
>   hadoop-env
>   proxyuser_group
>   
>   
> 
> 
> 
> ```
> 
> 2. Deploy a cluster with Zeppelin
> 
> 3. Check commands-json for addition of user_group in hostLevelParams for 
> following scenarios
>   a. Start Zeppelin - AmbariManagementControllerImpl code path
>   b. Restart Zeppelin - AmbariCustomCommandExecutionHelper code path
>   c. ClientConfigResourceProviderTest - ClientConfigResourceProvider code 
> path
> 
> [root@mradha22-1 data]# grep user_group command-552.json
> "user_group": "{\"zeppelin\":[\"zeppelin\",\"users\"]}",
> 
> 4. Verify if the 

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/#review166602
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (line 42)


USER_GROUP should be removed


- Jayush Luniya


On Feb. 23, 2017, 10:42 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56727/
> ---
> 
> (Updated Feb. 23, 2017, 10:42 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20034
> https://issues.apache.org/jira/browse/AMBARI-20034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  5c4f08e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b601893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  3b88ac9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  8a35c98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 978ecd7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 34c2941 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 56fcd74 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  30a1533 
>   ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  a748b33 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  19df802 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  63a9e9c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  c40ff64 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  8fad94e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  87a1fc7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
>   
> ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/configuration/hadoop-env.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56727/diff/
> 
> 
> Testing
> ---
> 
> Unit Tests
> ===
> --
> Total run:1174
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:35 min
> [INFO] Finished at: 2017-02-23T09:50:38-08:00
> [INFO] Final Memory: 64M/634M
> [INFO] 
> 
> 
> 
> Manual Testing for Zeppelin.
> ===
> Steps:
> 1. Make changes to 
> /resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
> /resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
> ```xml
> 
>   zeppelin_user
>   zeppelin
> USER
>   User zeppelin daemon runs as
> 
>   user
>   false
>   
>   
>   zeppelin-env
>   zeppelin_group
>   
>   
>   hadoop-env
>   proxyuser_group
>   
>   
> 
> 
> 
> ```
> 
> 2. Deploy a cluster with Zeppelin
> 
> 3. Check commands-json for addition of user_group in hostLevelParams for 
> following scenarios
>   a. Start Zeppelin - AmbariManagementControllerImpl code path
>   b. Restart Zeppelin - AmbariCustomCommandExecutionHelper code path
>   c. ClientConfigResourceProviderTest - ClientConfigResourceProvider code 
> path
> 
> [root@mradha22-1 data]# grep user_group command-552.json
> "user_group": "{\"zeppelin\":[\"zeppelin\",\"users\"]}",
> 
> 4. Verify if 

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/
---

(Updated Feb. 23, 2017, 10:42 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

Addressed review comments


Bugs: AMBARI-20034
https://issues.apache.org/jira/browse/AMBARI-20034


Repository: ambari


Description
---

USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 5c4f08e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b601893 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 3b88ac9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 8a35c98 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
978ecd7 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
34c2941 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
56fcd74 
  ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 30a1533 
  ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 a748b33 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 19df802 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 63a9e9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 c40ff64 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 8fad94e 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
 87a1fc7 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
  
ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/configuration/hadoop-env.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56727/diff/


Testing
---

Unit Tests
===
--
Total run:1174
Total errors:0
Total failures:0
OK
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 21:35 min
[INFO] Finished at: 2017-02-23T09:50:38-08:00
[INFO] Final Memory: 64M/634M
[INFO] 


Manual Testing for Zeppelin.
===
Steps:
1. Make changes to 
/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
/resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
```xml

zeppelin_user
zeppelin
USER
User zeppelin daemon runs as

user
false


zeppelin-env
zeppelin_group


hadoop-env
proxyuser_group





```

2. Deploy a cluster with Zeppelin

3. Check commands-json for addition of user_group in hostLevelParams for 
following scenarios
a. Start Zeppelin - AmbariManagementControllerImpl code path
b. Restart Zeppelin - AmbariCustomCommandExecutionHelper code path
c. ClientConfigResourceProviderTest - ClientConfigResourceProvider code 
path

[root@mradha22-1 data]# grep user_group command-552.json
"user_group": "{\"zeppelin\":[\"zeppelin\",\"users\"]}",

4. Verify if the user_group map is getting appended to the existing 
user_group_dict
Comment the hard-coded logic for zeppelin user and group in 
stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
#if has_zeppelin_master:
#user_to_groups_dict[zeppelin_user] = [zeppelin_group, user_group]
#zeppelin_user = 
config['configurations']['zeppelin-env']["zeppelin_user"]
#zeppelin_group = 
config['configurations']['zeppelin-env']["zeppelin_group"]

[root@mradha22-1 data]# grep Madhu output-*.txt
output-502.txt\:Madhu defaultdict( at 0x13880c8>, 
{'ambari-qa': ['users'], 'zeppelin': ['zeppelin', 'users']})
2017-02-15 22:21:48,575 - User['hdfs'] {'gid': 'hadoop', 
'fetch_nonlocal_groups': True, 'groups': 

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/#review166569
---




ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 (line 432)


Nit! Rename to USER_GROUPS = "user_groups"



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 (line 420)


Nit! Rename to userGroups



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (line 2411)


Nit! Rename to userGroups



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 (line 403)


Nit! Rename to userGroups



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 181)


Diamond notation is better coding style especially when you have 
declarations like these :)



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 547)


Add Java docs



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 565)


Add Java docs



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 605)


Log both userGroupInfo.getType() and userGroupInfo.getName() 

Example:

"User group mapping property {hadoop-env/hdfs_group} is missing for user 
property {hadoop-env/hdfs_user} (username = hdfs)"



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 617)


Add Java docs



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 634)


Add Java docs



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 1055)


doesnt look like this change is required to createConfig(). We are removing 
java doc here. Probably a bad merge?



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 1284)


You don't need to change from new HashMap<>() to new HashMap 

Explicit type arguments is redundant and can be replaced with diamond type 
<> in JDK 1.7+.  

Ambari is supported with JDK 1.7+ 

http://docs.hortonworks.com/HDPDocuments/Ambari-2.4.2.0/bk_ambari-installation/content/jdk_requirements.html

https://docs.oracle.com/javase/tutorial/java/generics/types.html


- Jayush Luniya


On Feb. 23, 2017, 7:39 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56727/
> ---
> 
> (Updated Feb. 23, 2017, 7:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20034
> https://issues.apache.org/jira/browse/AMBARI-20034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  5c4f08e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b601893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  3b88ac9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  8a35c98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 978ecd7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 34c2941 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 56fcd74 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  30a1533 
>   ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  a748b33 
>   
> 

Re: Review Request 56994: "Set Version on All Hosts" Fails For Hosts Without Any Stack Components

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56994/#review166583
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 23, 2017, 8:04 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56994/
> ---
> 
> (Updated Feb. 23, 2017, 8:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-20148
> https://issues.apache.org/jira/browse/AMBARI-20148
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During an upgrade, `hdp-select set all ` is sent to all hosts, even 
> those which do not have any versionable components (metrics only, for 
> example). This is done for two reason:
> - Simplicity - we don't need to figure out which hosts to include
> - Coverage - many clusters have clients not under our control, so invoking it 
> on all hosts covers our bases
> 
> We need to ensure that if the stack-select tool doesn't exist or reports no 
> versions, that we skip calling it.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> b7fcc51 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py b018605 
> 
> Diff: https://reviews.apache.org/r/56994/diff/
> 
> 
> Testing
> ---
> 
> --
> Total run:1185
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.155 s
> [INFO] Finished at: 2017-02-23T14:49:03-05:00
> [INFO] Final Memory: 18M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 57000: EU: Manual Step without any context after "All Service Checks" fail

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57000/#review166582
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 23, 2017, 9:27 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57000/
> ---
> 
> (Updated Feb. 23, 2017, 9:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20155
> https://issues.apache.org/jira/browse/AMBARI-20155
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During EU from 2.5.3.0-2.6.0.0, a manual step popped up that didn't make 
> sense.
> It says "Manual steps required [] I have performed the manual steps above." 
> without telling the user what the manual steps are.
> 
> The BE is not providing a message for display.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  cfe4a78 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
>  b9e27be 
> 
> Diff: https://reviews.apache.org/r/57000/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 56994: "Set Version on All Hosts" Fails For Hosts Without Any Stack Components

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56994/#review166580
---


Ship it!




Ship It!

- Nate Cole


On Feb. 23, 2017, 3:04 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56994/
> ---
> 
> (Updated Feb. 23, 2017, 3:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-20148
> https://issues.apache.org/jira/browse/AMBARI-20148
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During an upgrade, `hdp-select set all ` is sent to all hosts, even 
> those which do not have any versionable components (metrics only, for 
> example). This is done for two reason:
> - Simplicity - we don't need to figure out which hosts to include
> - Coverage - many clusters have clients not under our control, so invoking it 
> on all hosts covers our bases
> 
> We need to ensure that if the stack-select tool doesn't exist or reports no 
> versions, that we skip calling it.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> b7fcc51 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py b018605 
> 
> Diff: https://reviews.apache.org/r/56994/diff/
> 
> 
> Testing
> ---
> 
> --
> Total run:1185
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.155 s
> [INFO] Finished at: 2017-02-23T14:49:03-05:00
> [INFO] Final Memory: 18M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 57000: EU: Manual Step without any context after "All Service Checks" fail

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57000/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-20155
https://issues.apache.org/jira/browse/AMBARI-20155


Repository: ambari


Description
---

During EU from 2.5.3.0-2.6.0.0, a manual step popped up that didn't make sense.
It says "Manual steps required [] I have performed the manual steps above." 
without telling the user what the manual steps are.

The BE is not providing a message for display.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
 cfe4a78 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
 b9e27be 

Diff: https://reviews.apache.org/r/57000/diff/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 56998: Fix AMBARI-15754 in Ambari 2.5, potentially modifying configs.sh

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56998/#review166575
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 23, 2017, 8:58 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56998/
> ---
> 
> (Updated Feb. 23, 2017, 8:58 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20153
> https://issues.apache.org/jira/browse/AMBARI-20153
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix AMBARI-15754 in Ambari 2.5, potentially modifying configs.sh
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/configs.sh 8fcffd5 
> 
> Diff: https://reviews.apache.org/r/56998/diff/
> 
> 
> Testing
> ---
> 
> HW11769:scripts $ ./configs.sh -u <> -p <> -port 8080 get  cl1 pig-log4j
> USERID=admin
> PASSWORD=admin
> PORT=:8080
> ## Performing 'GET' on (Site:pig-log4j, Tag:version1)
> "properties" : {
> "content" : "\n#\n#\n# Licensed to the Apache Software Foundation (ASF) under 
> one\n# or more contributor license agreements.  See the NOTICE file\n# 
> distributed with this work for additional information\n# regarding copyright 
> ownership.  The ASF licenses this file\n# to you under the Apache License, 
> Version 2.0 (the\n# \"License\"); you may not use this file except in 
> compliance\n# with the License.  You may obtain a copy of the License 
> at\n#\n#   http://www.apache.org/licenses/LICENSE-2.0\n#\n# Unless required 
> by applicable law or agreed to in writing,\n# software distributed under the 
> License is distributed on an\n# \"AS IS\" BASIS, WITHOUT WARRANTIES OR 
> CONDITIONS OF ANY\n# KIND, either express or implied.  See the License for 
> the\n# specific language governing permissions and limitations\n# under the 
> License.\n#\n#\n#\n\n# * Set root logger level to DEBUG and its only 
> appender to A.\nlog4j.logger.org.apache.pig=info, A\n\n# * A is set to be 
> a ConsoleAppender.\nlog4j.app
 ender.A=org.apache.log4j.ConsoleAppender\n# * A uses 
PatternLayout.\nlog4j.appender.A.layout=org.apache.log4j.PatternLayout\nlog4j.appender.A.layout.ConversionPattern=%-4r
 [%t] %-5p %c %x - %m%n"
> }
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review166574
---


Ship it!




Ship It!

- Robert Nettleton


On Feb. 23, 2017, 8:49 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 23, 2017, 8:49 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 56998: Fix AMBARI-15754 in Ambari 2.5, potentially modifying configs.sh

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56998/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-20153
https://issues.apache.org/jira/browse/AMBARI-20153


Repository: ambari


Description
---

Fix AMBARI-15754 in Ambari 2.5, potentially modifying configs.sh


Diffs
-

  ambari-server/src/main/resources/scripts/configs.sh 8fcffd5 

Diff: https://reviews.apache.org/r/56998/diff/


Testing
---

HW11769:scripts $ ./configs.sh -u <> -p <> -port 8080 get  cl1 pig-log4j
USERID=admin
PASSWORD=admin
PORT=:8080
## Performing 'GET' on (Site:pig-log4j, Tag:version1)
"properties" : {
"content" : "\n#\n#\n# Licensed to the Apache Software Foundation (ASF) under 
one\n# or more contributor license agreements.  See the NOTICE file\n# 
distributed with this work for additional information\n# regarding copyright 
ownership.  The ASF licenses this file\n# to you under the Apache License, 
Version 2.0 (the\n# \"License\"); you may not use this file except in 
compliance\n# with the License.  You may obtain a copy of the License at\n#\n#  
 http://www.apache.org/licenses/LICENSE-2.0\n#\n# Unless required by applicable 
law or agreed to in writing,\n# software distributed under the License is 
distributed on an\n# \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY\n# KIND, either express or implied.  See the License for the\n# specific 
language governing permissions and limitations\n# under the 
License.\n#\n#\n#\n\n# * Set root logger level to DEBUG and its only 
appender to A.\nlog4j.logger.org.apache.pig=info, A\n\n# * A is set to be a 
ConsoleAppender.\nlog4j.appen
 der.A=org.apache.log4j.ConsoleAppender\n# * A uses 
PatternLayout.\nlog4j.appender.A.layout=org.apache.log4j.PatternLayout\nlog4j.appender.A.layout.ConversionPattern=%-4r
 [%t] %-5p %c %x - %m%n"
}


Thanks,

Madhuvanthi Radhakrishnan

Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/
---

Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
Robert Nettleton.


Bugs: AMBARI-20152
https://issues.apache.org/jira/browse/AMBARI-20152


Repository: ambari


Description
---

Use storm principal and keytab for ranger plugin instead of nimbus ones.
In storm code, storm user will be used globally anyway, ranger plugin will use 
that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
authorization is supported, that can cause if storm is authenticated with the 
worng user, it wont be able to access the ranger audit collection.


Diffs
-

  ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
fecef7c 

Diff: https://reviews.apache.org/r/56997/diff/


Testing
---

done.


Thanks,

Oliver Szabo

Review Request 56994: "Set Version on All Hosts" Fails For Hosts Without Any Stack Components

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56994/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
Cole.


Bugs: AMBARI-20148
https://issues.apache.org/jira/browse/AMBARI-20148


Repository: ambari


Description
---

During an upgrade, `hdp-select set all ` is sent to all hosts, even 
those which do not have any versionable components (metrics only, for example). 
This is done for two reason:
- Simplicity - we don't need to figure out which hosts to include
- Coverage - many clusters have clients not under our control, so invoking it 
on all hosts covers our bases

We need to ensure that if the stack-select tool doesn't exist or reports no 
versions, that we skip calling it.


Diffs
-

  ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py b7fcc51 
  ambari-server/src/test/python/custom_actions/test_ru_set_all.py b018605 

Diff: https://reviews.apache.org/r/56994/diff/


Testing
---

--
Total run:1185
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 58.155 s
[INFO] Finished at: 2017-02-23T14:49:03-05:00
[INFO] Final Memory: 18M/310M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/
---

(Updated Feb. 23, 2017, 7:39 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

Addressed review comments


Bugs: AMBARI-20034
https://issues.apache.org/jira/browse/AMBARI-20034


Repository: ambari


Description
---

USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 5c4f08e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b601893 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 3b88ac9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 8a35c98 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
978ecd7 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
34c2941 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
56fcd74 
  ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 30a1533 
  ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 a748b33 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 19df802 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 63a9e9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 c40ff64 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 8fad94e 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
 87a1fc7 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
  
ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/configuration/hadoop-env.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56727/diff/


Testing
---

Unit Tests
===
--
Total run:1174
Total errors:0
Total failures:0
OK
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 21:35 min
[INFO] Finished at: 2017-02-23T09:50:38-08:00
[INFO] Final Memory: 64M/634M
[INFO] 


Manual Testing for Zeppelin.
===
Steps:
1. Make changes to 
/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
/resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
```xml

zeppelin_user
zeppelin
USER
User zeppelin daemon runs as

user
false


zeppelin-env
zeppelin_group


hadoop-env
proxyuser_group





```

2. Deploy a cluster with Zeppelin

3. Check commands-json for addition of user_group in hostLevelParams for 
following scenarios
a. Start Zeppelin - AmbariManagementControllerImpl code path
b. Restart Zeppelin - AmbariCustomCommandExecutionHelper code path
c. ClientConfigResourceProviderTest - ClientConfigResourceProvider code 
path

[root@mradha22-1 data]# grep user_group command-552.json
"user_group": "{\"zeppelin\":[\"zeppelin\",\"users\"]}",

4. Verify if the user_group map is getting appended to the existing 
user_group_dict
Comment the hard-coded logic for zeppelin user and group in 
stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
#if has_zeppelin_master:
#user_to_groups_dict[zeppelin_user] = [zeppelin_group, user_group]
#zeppelin_user = 
config['configurations']['zeppelin-env']["zeppelin_user"]
#zeppelin_group = 
config['configurations']['zeppelin-env']["zeppelin_group"]

[root@mradha22-1 data]# grep Madhu output-*.txt
output-502.txt\:Madhu defaultdict( at 0x13880c8>, 
{'ambari-qa': ['users'], 'zeppelin': ['zeppelin', 'users']})
2017-02-15 22:21:48,575 - User['hdfs'] {'gid': 'hadoop', 
'fetch_nonlocal_groups': True, 'groups': 

Re: Review Request 56927: AMBARI-20116 : Stack Recommendation for Atlas not working on change of Kafka broker port.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56927/#review166551
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 22, 2017, 3:34 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56927/
> ---
> 
> (Updated Feb. 22, 2017, 3:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20116
> https://issues.apache.org/jira/browse/AMBARI-20116
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Kafka-broker port is changed, appropriate change should be made for 
> Atlas Kafla broker servers, this does not happen as stack-dependency for the 
> same is missing.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  36702e8 
> 
> Diff: https://reviews.apache.org/r/56927/diff/
> 
> 
> Testing
> ---
> 
> Verified with a fresh install on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 56926: Ambari reports grafana service is down when its running causing other services to not start

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56926/#review166550
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 23, 2017, 1:14 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56926/
> ---
> 
> (Updated Feb. 23, 2017, 1:14 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20115
> https://issues.apache.org/jira/browse/AMBARI-20115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the node grafana is running.
> 
> # cat /var/run/ambari-metrics-grafana/grafana-server.pid
> 26593
>  # ps aux | grep 26593
> root 20057  0.0  0.0   5712   824 pts/0R+   16:12   0:00 grep 26593
> ams  26593  0.0  0.0 102032 12904 ?Sl   01:19   0:11 
> /usr/lib/ambari-metrics-grafana/bin/grafana-server 
> --pidfile=/var/run/ambari-metrics-grafana/grafana-server.pid 
> --config=/etc/ambari-metrics-grafana/conf/ams-grafana.ini 
> cfg:default.paths.data=/var/lib/ambari-metrics-grafana 
> cfg:default.paths.logs=/var/log/ambari-metrics-grafana
> 
> 
> How ever after enabling WE when we tried to start all services ambari reported
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 77, in 
> AmsGrafana().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 313, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 58, in start
> create_ams_datasource()
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
>  line 239, in create_ams_datasource
> response = perform_grafana_get_call(GRAFANA_DATASOURCE_URL, server)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
>  line 72, in perform_grafana_get_call
> raise Fail("Ambari Metrics Grafana update failed due to: %s" % str(ex))
> resource_management.core.exceptions.Fail: Ambari Metrics Grafana update 
> failed due to: [Errno 1] _ssl.c:491: error:1407742E:SSL 
> routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/network.py b5b1cd6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
>  a751330 
> 
> Diff: https://reviews.apache.org/r/56926/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/#review166549
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 (line 252)


Why does it have to be sorted?



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 (line 255)


we can log the error.



ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 (line 112)


Small nitpick, put a space after comma here and in rest of the files.


- Alejandro Fernandez


On Feb. 23, 2017, 6:08 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56727/
> ---
> 
> (Updated Feb. 23, 2017, 6:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20034
> https://issues.apache.org/jira/browse/AMBARI-20034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  5c4f08e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b601893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  3b88ac9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  8a35c98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13d0993 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 34c2941 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 56fcd74 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  30a1533 
>   ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  a748b33 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  19df802 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  63a9e9c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  c40ff64 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  8fad94e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  87a1fc7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
>   
> ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/configuration/hadoop-env.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56727/diff/
> 
> 
> Testing
> ---
> 
> Unit Tests
> ===
> --
> Total run:1174
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:35 min
> [INFO] Finished at: 2017-02-23T09:50:38-08:00
> [INFO] Final Memory: 64M/634M
> [INFO] 
> 
> 
> 
> Manual Testing for Zeppelin.
> ===
> Steps:
> 1. Make changes to 
> /resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
> /resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
> ```xml
> 
>   zeppelin_user
>   zeppelin
> USER
>   User zeppelin daemon runs as
> 
>   user
>   false
>   
>   
>   zeppelin-env
>   zeppelin_group
>   
>   
>   hadoop-env
>   proxyuser_group
>   
>   
> 
> 
> 
> ```
> 
> 2. Deploy a cluster with Zeppelin
> 
> 3. Check commands-json for addition of 

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/
---

(Updated Feb. 23, 2017, 6:08 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-20034
https://issues.apache.org/jira/browse/AMBARI-20034


Repository: ambari


Description
---

USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 5c4f08e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b601893 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 3b88ac9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 8a35c98 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
13d0993 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
34c2941 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
56fcd74 
  ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 30a1533 
  ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 a748b33 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 19df802 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 63a9e9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 c40ff64 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 8fad94e 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
 87a1fc7 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
  
ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/configuration/hadoop-env.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56727/diff/


Testing (updated)
---

Unit Tests
===
--
Total run:1174
Total errors:0
Total failures:0
OK
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 21:35 min
[INFO] Finished at: 2017-02-23T09:50:38-08:00
[INFO] Final Memory: 64M/634M
[INFO] 


Manual Testing for Zeppelin.
===
Steps:
1. Make changes to 
/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
/resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
```xml

zeppelin_user
zeppelin
USER
User zeppelin daemon runs as

user
false


zeppelin-env
zeppelin_group


hadoop-env
proxyuser_group





```

2. Deploy a cluster with Zeppelin

3. Check commands-json for addition of user_group in hostLevelParams for 
following scenarios
a. Start Zeppelin - AmbariManagementControllerImpl code path
b. Restart Zeppelin - AmbariCustomCommandExecutionHelper code path
c. ClientConfigResourceProviderTest - ClientConfigResourceProvider code 
path

[root@mradha22-1 data]# grep user_group command-552.json
"user_group": "{\"zeppelin\":[\"zeppelin\",\"users\"]}",

4. Verify if the user_group map is getting appended to the existing 
user_group_dict
Comment the hard-coded logic for zeppelin user and group in 
stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
#if has_zeppelin_master:
#user_to_groups_dict[zeppelin_user] = [zeppelin_group, user_group]
#zeppelin_user = 
config['configurations']['zeppelin-env']["zeppelin_user"]
#zeppelin_group = 
config['configurations']['zeppelin-env']["zeppelin_group"]

[root@mradha22-1 data]# grep Madhu output-*.txt
output-502.txt\:Madhu defaultdict( at 0x13880c8>, 
{'ambari-qa': ['users'], 'zeppelin': ['zeppelin', 'users']})
2017-02-15 22:21:48,575 - User['hdfs'] {'gid': 'hadoop', 
'fetch_nonlocal_groups': True, 'groups': ['hadoop']}
2017-02-15 22:21:48,576 - 

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/
---

(Updated Feb. 23, 2017, 6:06 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

AmbariManagementControllerImpl, AmbariCustomCommandExecutionHelper, 
ClientConfigResourceProvider - Code refactoring and naming conventions(Review 
comments)
ConfigHelper - Code refactoring and naming conventions(review comments)
ClientConfigResourceProviderTest, AmbariManagementControllerTest, 
AmbariCustomCommandExecutionHelperTest, hadoop-env.xml, default.json - Unit 
tests for the fix
AmbariMetaInfoTest, StackManagerTest - A new config file hadoop-env was added 
to the test/resources/stack/HDP/0.1/services/HDFS/configuration/ directory and 
some tests had a property count of 62 which has to be set to 64 due to the 
addition.
ServicesInfo, PropertiesInfo - Setter for unit tests


Bugs: AMBARI-20034
https://issues.apache.org/jira/browse/AMBARI-20034


Repository: ambari


Description
---

USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 5c4f08e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b601893 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 3b88ac9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 8a35c98 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
13d0993 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
34c2941 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
56fcd74 
  ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 30a1533 
  ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 a748b33 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 19df802 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 63a9e9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 c40ff64 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 8fad94e 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
 87a1fc7 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
  
ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/configuration/hadoop-env.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56727/diff/


Testing
---

Manual Testing for Zeppelin.
===
Steps:
1. Make changes to 
/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
/resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
```xml

zeppelin_user
zeppelin
USER
User zeppelin daemon runs as

user
false


zeppelin-env
zeppelin_group


hadoop-env
proxyuser_group





```

2. Deploy a cluster with Zeppelin

3. Check commands-json for addition of user_group in hostLevelParams for 
following scenarios
a. Start Zeppelin - AmbariManagementControllerImpl code path
b. Restart Zeppelin - AmbariCustomCommandExecutionHelper code path
c. ClientConfigResourceProviderTest - ClientConfigResourceProvider code 
path

[root@mradha22-1 data]# grep user_group command-552.json
"user_group": "{\"zeppelin\":[\"zeppelin\",\"users\"]}",

4. Verify if the user_group map is getting appended to the existing 
user_group_dict
Comment the hard-coded logic for zeppelin user and group in 
stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
#if has_zeppelin_master:
#user_to_groups_dict[zeppelin_user] = [zeppelin_group, user_group]
#zeppelin_user = 
config['configurations']['zeppelin-env']["zeppelin_user"]
#zeppelin_group = 
config['configurations']['zeppelin-env']["zeppelin_group"]

[root@mradha22-1 data]# grep Madhu output-*.txt
output-502.txt\:Madhu defaultdict( at 0x13880c8>, 
{'ambari-qa': ['users'], 'zeppelin': ['zeppelin', 'users']})
2017-02-15 22:21:48,575 - User['hdfs'] {'gid': 'hadoop', 
'fetch_nonlocal_groups': True, 

Re: Review Request 56926: Ambari reports grafana service is down when its running causing other services to not start

[Sid Wagle]

> On Feb. 22, 2017, 6:03 p.m., Sid Wagle wrote:
> > ambari-common/src/main/python/ambari_commons/network.py, line 45
> > 
> >
> > Why is this harcoded to tlsv1? Is there a best practice guidance here?
> 
> Dmytro Sen wrote:
> TLSv1 is more secure than SSLv23, so we're trying TLS and fallback to 
> SSL. TLSv1 works for CentOS and Suse, before the patch it was always SSLv23.
> 
> Dmytro Sen wrote:
> This would guarantee that we are providing secure protocol where it's 
> possible and use old implementation if necessary.

Thanks for that info.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56926/#review166383
---


On Feb. 23, 2017, 1:14 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56926/
> ---
> 
> (Updated Feb. 23, 2017, 1:14 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20115
> https://issues.apache.org/jira/browse/AMBARI-20115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the node grafana is running.
> 
> # cat /var/run/ambari-metrics-grafana/grafana-server.pid
> 26593
>  # ps aux | grep 26593
> root 20057  0.0  0.0   5712   824 pts/0R+   16:12   0:00 grep 26593
> ams  26593  0.0  0.0 102032 12904 ?Sl   01:19   0:11 
> /usr/lib/ambari-metrics-grafana/bin/grafana-server 
> --pidfile=/var/run/ambari-metrics-grafana/grafana-server.pid 
> --config=/etc/ambari-metrics-grafana/conf/ams-grafana.ini 
> cfg:default.paths.data=/var/lib/ambari-metrics-grafana 
> cfg:default.paths.logs=/var/log/ambari-metrics-grafana
> 
> 
> How ever after enabling WE when we tried to start all services ambari reported
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 77, in 
> AmsGrafana().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 313, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 58, in start
> create_ams_datasource()
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
>  line 239, in create_ams_datasource
> response = perform_grafana_get_call(GRAFANA_DATASOURCE_URL, server)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
>  line 72, in perform_grafana_get_call
> raise Fail("Ambari Metrics Grafana update failed due to: %s" % str(ex))
> resource_management.core.exceptions.Fail: Ambari Metrics Grafana update 
> failed due to: [Errno 1] _ssl.c:491: error:1407742E:SSL 
> routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/network.py b5b1cd6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
>  a751330 
> 
> Diff: https://reviews.apache.org/r/56926/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56987/
---

Review request for Ambari, Attila Doroszlai, Robert Levas, and Sandor Magyari.


Bugs: AMBARI-19929
https://issues.apache.org/jira/browse/AMBARI-19929


Repository: ambari


Description
---

Move the persisting of 
TopologyRequest/TopologyLogicalRequest/TopologyHostRequest records into a 
single transaction to esnure consistency accross these records.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
9ef32b5 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 ab56844 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 a26624e 

Diff: https://reviews.apache.org/r/56987/diff/


Testing
---

Performed manual testing covering cluster creation using Blueprint and than 
cluster upscaling.

Unit tests: Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39


Thanks,

Sebastian Toader

Re: Review Request 56985: Ambari logo is not displayed

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56985/#review166534
---


Ship it!




Ship It!

- Alexandr Antonenko


On Feb. 23, 2017, 4 p.m., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56985/
> ---
> 
> (Updated Feb. 23, 2017, 4 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-20144
> https://issues.apache.org/jira/browse/AMBARI-20144
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Logo isn't displayed in both Ambari Web and Ambari Admin because of incorrect 
> URL.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/img/ambari-Logo.png 07d31ee 
>   ambari-web/app/assets/img/ambari-logo.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56985/diff/
> 
> 
> Testing
> ---
> 
> 20375 passing (18s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Review Request 56985: Ambari logo is not displayed

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56985/
---

Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-20144
https://issues.apache.org/jira/browse/AMBARI-20144


Repository: ambari


Description
---

Logo isn't displayed in both Ambari Web and Ambari Admin because of incorrect 
URL.


Diffs
-

  ambari-web/app/assets/img/ambari-Logo.png 07d31ee 
  ambari-web/app/assets/img/ambari-logo.png PRE-CREATION 

Diff: https://reviews.apache.org/r/56985/diff/


Testing
---

20375 passing (18s)
  153 pending


Thanks,

Andriy Babiichuk

Re: Review Request 56759: AMBARI-20047 : Repository config user needs to set customized service user in Ranger when service plugin is enabled.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56759/#review166530
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 22, 2017, 3:02 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56759/
> ---
> 
> (Updated Feb. 22, 2017, 3:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha 
> Varadkar, Oliver Szabo, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20047
> https://issues.apache.org/jira/browse/AMBARI-20047
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The property REPOSITORY_CONFIG_USERNAME in Advanced 
> ranger-*-plugin-properties is not updated to the custom user-name when 
> services are using custom users.
> This causes issues especially in cases of Test connection, and policy user 
> which is given default permissions in Ranger.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  56c46dd 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/ranger-hdfs-plugin-properties.xml
>  eb7e0bb 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
>  2291c94 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/ranger-yarn-plugin-properties.xml
>  97867cc 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
>  6e4e55f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml
>  d8885e5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
>  d8885e5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
>  6e93879 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/ranger-hive-plugin-properties.xml
>  d8885e5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml
>  d8885e5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/ranger-yarn-plugin-properties.xml
>  d8885e5 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 3dd1bdd 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  d64598a 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> c15eaf1 
> 
> Diff: https://reviews.apache.org/r/56759/diff/
> 
> 
> Testing
> ---
> 
> Verified with a fresh installation on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 56927: AMBARI-20116 : Stack Recommendation for Atlas not working on change of Kafka broker port.

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56927/#review166529
---


Ship it!




Ship It!

- Oliver Szabo


On Feb. 22, 2017, 3:34 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56927/
> ---
> 
> (Updated Feb. 22, 2017, 3:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20116
> https://issues.apache.org/jira/browse/AMBARI-20116
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Kafka-broker port is changed, appropriate change should be made for 
> Atlas Kafla broker servers, this does not happen as stack-dependency for the 
> same is missing.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  36702e8 
> 
> Diff: https://reviews.apache.org/r/56927/diff/
> 
> 
> Testing
> ---
> 
> Verified with a fresh install on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 56927: AMBARI-20116 : Stack Recommendation for Atlas not working on change of Kafka broker port.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56927/#review166528
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 22, 2017, 3:34 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56927/
> ---
> 
> (Updated Feb. 22, 2017, 3:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20116
> https://issues.apache.org/jira/browse/AMBARI-20116
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Kafka-broker port is changed, appropriate change should be made for 
> Atlas Kafla broker servers, this does not happen as stack-dependency for the 
> same is missing.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  36702e8 
> 
> Diff: https://reviews.apache.org/r/56927/diff/
> 
> 
> Testing
> ---
> 
> Verified with a fresh install on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/#review166524
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 23, 2017, 1:11 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56980/
> ---
> 
> (Updated Feb. 23, 2017, 1:11 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20140
> https://issues.apache.org/jira/browse/AMBARI-20140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2 and Spark1 shares the same principal name. This casuses a problem when 
> adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
> keytab to Spark2 because it thinks it already exists.
> 
> I extended the existing conditional to take the existence of the destination 
> keytab file into consideration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  5d6ccc0 
> 
> Diff: https://reviews.apache.org/r/56980/diff/
> 
> 
> Testing
> ---
> 
> - Created a cluster with Spark
> - Enabled Kerberos
> - Added Spark2
> - Checked if Spark2 started successfully and the exitence of 
> /etc/security/keytabs/spark2.headless.keytab
> 
> 
> Existing tests ran without failure.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/#review166522
---


Ship it!




Ship It!

- Robert Levas


On Feb. 23, 2017, 7:11 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56980/
> ---
> 
> (Updated Feb. 23, 2017, 7:11 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20140
> https://issues.apache.org/jira/browse/AMBARI-20140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2 and Spark1 shares the same principal name. This casuses a problem when 
> adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
> keytab to Spark2 because it thinks it already exists.
> 
> I extended the existing conditional to take the existence of the destination 
> keytab file into consideration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  5d6ccc0 
> 
> Diff: https://reviews.apache.org/r/56980/diff/
> 
> 
> Testing
> ---
> 
> - Created a cluster with Spark
> - Enabled Kerberos
> - Added Spark2
> - Checked if Spark2 started successfully and the exitence of 
> /etc/security/keytabs/spark2.headless.keytab
> 
> 
> Existing tests ran without failure.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/#review166520
---


Ship it!




Ship It!

- Balázs Bence Sári


On Feb. 23, 2017, 12:11 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56980/
> ---
> 
> (Updated Feb. 23, 2017, 12:11 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20140
> https://issues.apache.org/jira/browse/AMBARI-20140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2 and Spark1 shares the same principal name. This casuses a problem when 
> adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
> keytab to Spark2 because it thinks it already exists.
> 
> I extended the existing conditional to take the existence of the destination 
> keytab file into consideration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  5d6ccc0 
> 
> Diff: https://reviews.apache.org/r/56980/diff/
> 
> 
> Testing
> ---
> 
> - Created a cluster with Spark
> - Enabled Kerberos
> - Added Spark2
> - Checked if Spark2 started successfully and the exitence of 
> /etc/security/keytabs/spark2.headless.keytab
> 
> 
> Existing tests ran without failure.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56981: AMBARI-20141.Command text lost when toggling from Command to Args on sqoop in Workflow manager.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56981/#review166519
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 23, 2017, 12:42 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56981/
> ---
> 
> (Updated Feb. 23, 2017, 12:42 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20141
> https://issues.apache.org/jira/browse/AMBARI-20141
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by retaining both command and args and deleting the unused one on 
> destroy of the component.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action.js 
> ac85a9a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action.js 
> f23cca7 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js 
> 18a3702 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js 
> 2756700 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/ssh-action.js 
> 8da7eef 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive-action.hbs
>  3d59e23 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive2-action.hbs
>  8adf64c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs
>  3de5677 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
>  db69864 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs
>  a29a2ec 
>   contrib/views/wfmanager/src/main/resources/ui/app/validators/arg-length.js 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56981/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56979: AMBARI-20050. Issue while importing workflow with insufficient permissions

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56979/#review166518
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 23, 2017, 12:04 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56979/
> ---
> 
> (Updated Feb. 23, 2017, 12:04 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20050
> https://issues.apache.org/jira/browse/AMBARI-20050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exception handling properly
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java
>  55c4312 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  6603a9c 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
>  ef3b508 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/ErrorCode.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmException.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
>  a0aa234 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 3ccbc07 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> bbd619d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js
>  7a7c38d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> f97add8 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/stack-trace-dialog.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less e98d182 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
>  ca58431 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  7b607ca 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs
>  8438255 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  1a73421 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/stack-trace-dialog.hbs
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/stack-trace-dialog-test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56979/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 56981: AMBARI-20141.Command text lost when toggling from Command to Args on sqoop in Workflow manager.

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56981/#review166517
---


Ship it!




Ship It!

- belliraj hb


On Feb. 23, 2017, 12:42 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56981/
> ---
> 
> (Updated Feb. 23, 2017, 12:42 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20141
> https://issues.apache.org/jira/browse/AMBARI-20141
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by retaining both command and args and deleting the unused one on 
> destroy of the component.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action.js 
> ac85a9a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action.js 
> f23cca7 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js 
> 18a3702 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js 
> 2756700 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/ssh-action.js 
> 8da7eef 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive-action.hbs
>  3d59e23 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive2-action.hbs
>  8adf64c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs
>  3de5677 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
>  db69864 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs
>  a29a2ec 
>   contrib/views/wfmanager/src/main/resources/ui/app/validators/arg-length.js 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56981/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56950: Error during EU while updating Ranger Log4J service configs

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56950/#review166516
---


Ship it!




Ship It!

- Dmytro Grinenko


On Feb. 22, 2017, 9:11 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56950/
> ---
> 
> (Updated Feb. 22, 2017, 9:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-20120
> https://issues.apache.org/jira/browse/AMBARI-20120
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Perform an HDP upgrade from 2.3 to 2.4 where Ranger is an installed service.
> 
> *Result*
> Observed errors while updating below Ranger service configs:
> Updating configuration usersync-log4j
> Updating configuration admin-log4j
> 
> {code}
> Server action failed
> Could not find desired config type with name admin-log4j
> {code}
> 
> - Both {{usersync-log4j}} and {{admin-log4j}} appear in Ranger 0.6.0 which is 
> first used by HDP 2.5. Therefore, the configuration changes should simply be 
> removed from upgrades on stacks before HDP 2.5
> 
> - Additionally, I found {{RANGER_TAGSYNC}} references in HDP 2.3 and HDP 2.4. 
> This component also first appeared in Ranger 0.6.0, so it should also be 
> removed from earlier upgrade packs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  13a6c36 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 6572bbb 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 8589e2d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  52421d9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  28d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  d675986 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> b662b28 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> b53ff23 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 9917ee1 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 14feab6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  f093cb1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  e856288 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 2a3e6b2 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> f736796 
> 
> Diff: https://reviews.apache.org/r/56950/diff/
> 
> 
> Testing
> ---
> 
> Performed upgrades from HDP 2.3 to 2.4 and then to 2.5. Observed the new 
> configurations were created in Ambari 2.5 and no errors were seen during 
> upgrade.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 56926: Ambari reports grafana service is down when its running causing other services to not start

[Dmytro Sen]

> On Фев. 22, 2017, 6:03 п.п., Sid Wagle wrote:
> > ambari-common/src/main/python/ambari_commons/network.py, line 45
> > 
> >
> > Why is this harcoded to tlsv1? Is there a best practice guidance here?
> 
> Dmytro Sen wrote:
> TLSv1 is more secure than SSLv23, so we're trying TLS and fallback to 
> SSL. TLSv1 works for CentOS and Suse, before the patch it was always SSLv23.

This would guarantee that we are providing secure protocol where it's possible 
and use old implementation if necessary.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56926/#review166383
---


On Фев. 23, 2017, 1:14 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56926/
> ---
> 
> (Updated Фев. 23, 2017, 1:14 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20115
> https://issues.apache.org/jira/browse/AMBARI-20115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the node grafana is running.
> 
> # cat /var/run/ambari-metrics-grafana/grafana-server.pid
> 26593
>  # ps aux | grep 26593
> root 20057  0.0  0.0   5712   824 pts/0R+   16:12   0:00 grep 26593
> ams  26593  0.0  0.0 102032 12904 ?Sl   01:19   0:11 
> /usr/lib/ambari-metrics-grafana/bin/grafana-server 
> --pidfile=/var/run/ambari-metrics-grafana/grafana-server.pid 
> --config=/etc/ambari-metrics-grafana/conf/ams-grafana.ini 
> cfg:default.paths.data=/var/lib/ambari-metrics-grafana 
> cfg:default.paths.logs=/var/log/ambari-metrics-grafana
> 
> 
> How ever after enabling WE when we tried to start all services ambari reported
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 77, in 
> AmsGrafana().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 313, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 58, in start
> create_ams_datasource()
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
>  line 239, in create_ams_datasource
> response = perform_grafana_get_call(GRAFANA_DATASOURCE_URL, server)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
>  line 72, in perform_grafana_get_call
> raise Fail("Ambari Metrics Grafana update failed due to: %s" % str(ex))
> resource_management.core.exceptions.Fail: Ambari Metrics Grafana update 
> failed due to: [Errno 1] _ssl.c:491: error:1407742E:SSL 
> routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/network.py b5b1cd6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
>  a751330 
> 
> Diff: https://reviews.apache.org/r/56926/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 56926: Ambari reports grafana service is down when its running causing other services to not start

[Dmytro Sen]

> On Фев. 22, 2017, 6:03 п.п., Sid Wagle wrote:
> > ambari-common/src/main/python/ambari_commons/network.py, line 45
> > 
> >
> > Why is this harcoded to tlsv1? Is there a best practice guidance here?

TLSv1 is more secure than SSLv23, so we're trying TLS and fallback to SSL. 
TLSv1 works for CentOS and Suse, before the patch it was always SSLv23.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56926/#review166383
---


On Фев. 23, 2017, 1:14 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56926/
> ---
> 
> (Updated Фев. 23, 2017, 1:14 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20115
> https://issues.apache.org/jira/browse/AMBARI-20115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the node grafana is running.
> 
> # cat /var/run/ambari-metrics-grafana/grafana-server.pid
> 26593
>  # ps aux | grep 26593
> root 20057  0.0  0.0   5712   824 pts/0R+   16:12   0:00 grep 26593
> ams  26593  0.0  0.0 102032 12904 ?Sl   01:19   0:11 
> /usr/lib/ambari-metrics-grafana/bin/grafana-server 
> --pidfile=/var/run/ambari-metrics-grafana/grafana-server.pid 
> --config=/etc/ambari-metrics-grafana/conf/ams-grafana.ini 
> cfg:default.paths.data=/var/lib/ambari-metrics-grafana 
> cfg:default.paths.logs=/var/log/ambari-metrics-grafana
> 
> 
> How ever after enabling WE when we tried to start all services ambari reported
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 77, in 
> AmsGrafana().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 313, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 58, in start
> create_ams_datasource()
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
>  line 239, in create_ams_datasource
> response = perform_grafana_get_call(GRAFANA_DATASOURCE_URL, server)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
>  line 72, in perform_grafana_get_call
> raise Fail("Ambari Metrics Grafana update failed due to: %s" % str(ex))
> resource_management.core.exceptions.Fail: Ambari Metrics Grafana update 
> failed due to: [Errno 1] _ssl.c:491: error:1407742E:SSL 
> routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/network.py b5b1cd6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
>  a751330 
> 
> Diff: https://reviews.apache.org/r/56926/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 56926: Ambari reports grafana service is down when its running causing other services to not start

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56926/
---

(Updated Фев. 23, 2017, 1:14 п.п.)


Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-20115
https://issues.apache.org/jira/browse/AMBARI-20115


Repository: ambari


Description
---

On the node grafana is running.

# cat /var/run/ambari-metrics-grafana/grafana-server.pid
26593
 # ps aux | grep 26593
root 20057  0.0  0.0   5712   824 pts/0R+   16:12   0:00 grep 26593
ams  26593  0.0  0.0 102032 12904 ?Sl   01:19   0:11 
/usr/lib/ambari-metrics-grafana/bin/grafana-server 
--pidfile=/var/run/ambari-metrics-grafana/grafana-server.pid 
--config=/etc/ambari-metrics-grafana/conf/ams-grafana.ini 
cfg:default.paths.data=/var/lib/ambari-metrics-grafana 
cfg:default.paths.logs=/var/log/ambari-metrics-grafana


How ever after enabling WE when we tried to start all services ambari reported

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
 line 77, in 
AmsGrafana().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 313, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
 line 58, in start
create_ams_datasource()
  File 
"/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
 line 239, in create_ams_datasource
response = perform_grafana_get_call(GRAFANA_DATASOURCE_URL, server)
  File 
"/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
 line 72, in perform_grafana_get_call
raise Fail("Ambari Metrics Grafana update failed due to: %s" % str(ex))
resource_management.core.exceptions.Fail: Ambari Metrics Grafana update failed 
due to: [Errno 1] _ssl.c:491: error:1407742E:SSL 
routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version


Diffs (updated)
-

  ambari-common/src/main/python/ambari_commons/network.py b5b1cd6 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
 a751330 

Diff: https://reviews.apache.org/r/56926/diff/


Testing
---

Manual testing


Thanks,

Dmytro Sen

Re: Review Request 56982: Merge Preview Configuration changes to branch-2.5

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56982/#review166513
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Фев. 23, 2017, 1:08 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56982/
> ---
> 
> (Updated Фев. 23, 2017, 1:08 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20143
> https://issues.apache.org/jira/browse/AMBARI-20143
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Merge the following to branch-2.5:
> AMBARI-19048
> AMBARI-19189
> AMBARI-19572
> AMBARI-19231
> AMBARI-19308
> AMBARI-19678
> AMBARI-19281
> AMBARI-19318
> AMBARI-19387
> AMBARI-19447
> AMBARI-19586
> AMBARI-19644
> AMBARI-19590
> AMBARI-19713
> AMBARI-19924
> AMBARI-19896
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/test/tests.js 7440819 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step3_controller.js
>  475cc52 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js
>  b241707 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/wizard_controller.js
>  2bc6e37 
>   ambari-web/app/controllers/main/host/details.js f040db5 
>   ambari-web/app/controllers/main/service/info/configs.js 32062e8 
>   ambari-web/app/controllers/main/service/item.js 11df45a 
>   ambari-web/app/controllers/main/service/reassign/step1_controller.js 
> 9f30bb7 
>   ambari-web/app/controllers/main/service/reassign/step3_controller.js 
> d717dea 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> e14cb2a 
>   ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c 
>   ambari-web/app/controllers/wizard/step7_controller.js 66ea208 
>   ambari-web/app/messages.js 33195e0 
>   ambari-web/app/mixins/common/configs/enhanced_configs.js f7cc4cf 
>   ambari-web/app/mixins/common/track_request_mixin.js c665253 
>   ambari-web/app/mixins/main/service/groups_mapping.js 40cd0cb 
>   ambari-web/app/routes/ra_high_availability_routes.js 9995937 
>   ambari-web/app/routes/reassign_master_routes.js 35bd96f 
>   ambari-web/app/styles/application.less f7cab50 
>   ambari-web/app/templates/common/modal_popups/dependent_configs_table.hbs 
> b6fff84 
>   ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs 
> 456e9ed 
>   ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step3.hbs 
> 32ea830 
>   ambari-web/app/templates/main/host/details/addComponentPopup.hbs ff69b9e 
>   ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 
> PRE-CREATION 
>   ambari-web/app/templates/main/host/details/deleteComponentPopup.hbs 10b24fd 
>   ambari-web/app/templates/main/service/add_host_popup.hbs 7431080 
>   ambari-web/app/templates/main/service/info/delete_service_warning_popup.hbs 
> PRE-CREATION 
>   ambari-web/app/templates/main/service/reassign/step3.hbs 1ffe989 
>   ambari-web/app/views/main/admin/highAvailability/rangerAdmin/step3_view.js 
> 8aa0125 
>   ambari-web/app/views/main/host/summary.js 80c4890 
>   ambari-web/app/views/main/service/reassign/step3_view.js 003fcb6 
>   ambari-web/app/views/main/service/reassign/step5_view.js c5fc3c8 
>   
> ambari-web/test/controllers/main/admin/highAvailability/rangerAdmin/step3_controller_test.js
>  PRE-CREATION 
>   ambari-web/test/controllers/main/host/details_test.js 9efece0 
>   ambari-web/test/controllers/main/service/info/config_test.js 09772ff 
>   ambari-web/test/controllers/main/service/item_test.js 1b21b78 
>   ambari-web/test/controllers/main/service/reassign/step1_controller_test.js 
> a43d91f 
>   ambari-web/test/controllers/main/service/reassign/step3_controller_test.js 
> e433f47 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 362153a 
>   ambari-web/test/controllers/wizard/step7_test.js cd6b21c 
> 
> Diff: https://reviews.apache.org/r/56982/diff/
> 
> 
> Testing
> ---
> 
> 30331 passing (23s)
>   157 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Review Request 56982: Merge Preview Configuration changes to branch-2.5

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56982/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20143
https://issues.apache.org/jira/browse/AMBARI-20143


Repository: ambari


Description
---

Merge the following to branch-2.5:
AMBARI-19048
AMBARI-19189
AMBARI-19572
AMBARI-19231
AMBARI-19308
AMBARI-19678
AMBARI-19281
AMBARI-19318
AMBARI-19387
AMBARI-19447
AMBARI-19586
AMBARI-19644
AMBARI-19590
AMBARI-19713
AMBARI-19924
AMBARI-19896


Diffs
-

  ambari-web/app/assets/test/tests.js 7440819 
  
ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step3_controller.js
 475cc52 
  
ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js
 b241707 
  
ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/wizard_controller.js
 2bc6e37 
  ambari-web/app/controllers/main/host/details.js f040db5 
  ambari-web/app/controllers/main/service/info/configs.js 32062e8 
  ambari-web/app/controllers/main/service/item.js 11df45a 
  ambari-web/app/controllers/main/service/reassign/step1_controller.js 9f30bb7 
  ambari-web/app/controllers/main/service/reassign/step3_controller.js d717dea 
  ambari-web/app/controllers/main/service/reassign/step4_controller.js e14cb2a 
  ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c 
  ambari-web/app/controllers/wizard/step7_controller.js 66ea208 
  ambari-web/app/messages.js 33195e0 
  ambari-web/app/mixins/common/configs/enhanced_configs.js f7cc4cf 
  ambari-web/app/mixins/common/track_request_mixin.js c665253 
  ambari-web/app/mixins/main/service/groups_mapping.js 40cd0cb 
  ambari-web/app/routes/ra_high_availability_routes.js 9995937 
  ambari-web/app/routes/reassign_master_routes.js 35bd96f 
  ambari-web/app/styles/application.less f7cab50 
  ambari-web/app/templates/common/modal_popups/dependent_configs_table.hbs 
b6fff84 
  ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs 
456e9ed 
  ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step3.hbs 
32ea830 
  ambari-web/app/templates/main/host/details/addComponentPopup.hbs ff69b9e 
  ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 
PRE-CREATION 
  ambari-web/app/templates/main/host/details/deleteComponentPopup.hbs 10b24fd 
  ambari-web/app/templates/main/service/add_host_popup.hbs 7431080 
  ambari-web/app/templates/main/service/info/delete_service_warning_popup.hbs 
PRE-CREATION 
  ambari-web/app/templates/main/service/reassign/step3.hbs 1ffe989 
  ambari-web/app/views/main/admin/highAvailability/rangerAdmin/step3_view.js 
8aa0125 
  ambari-web/app/views/main/host/summary.js 80c4890 
  ambari-web/app/views/main/service/reassign/step3_view.js 003fcb6 
  ambari-web/app/views/main/service/reassign/step5_view.js c5fc3c8 
  
ambari-web/test/controllers/main/admin/highAvailability/rangerAdmin/step3_controller_test.js
 PRE-CREATION 
  ambari-web/test/controllers/main/host/details_test.js 9efece0 
  ambari-web/test/controllers/main/service/info/config_test.js 09772ff 
  ambari-web/test/controllers/main/service/item_test.js 1b21b78 
  ambari-web/test/controllers/main/service/reassign/step1_controller_test.js 
a43d91f 
  ambari-web/test/controllers/main/service/reassign/step3_controller_test.js 
e433f47 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
362153a 
  ambari-web/test/controllers/wizard/step7_test.js cd6b21c 

Diff: https://reviews.apache.org/r/56982/diff/


Testing
---

30331 passing (23s)
  157 pending


Thanks,

Andriy Babiichuk

Review Request 56981: AMBARI-20141.Command text lost when toggling from Command to Args on sqoop in Workflow manager.

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56981/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20141
https://issues.apache.org/jira/browse/AMBARI-20141


Repository: ambari


Description
---

Fixed by retaining both command and args and deleting the unused one on destroy 
of the component.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action.js 
ac85a9a 
  contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action.js 
f23cca7 
  contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js 
18a3702 
  contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js 
2756700 
  contrib/views/wfmanager/src/main/resources/ui/app/components/ssh-action.js 
8da7eef 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive-action.hbs
 3d59e23 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive2-action.hbs
 8adf64c 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs
 3de5677 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
 db69864 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs
 a29a2ec 
  contrib/views/wfmanager/src/main/resources/ui/app/validators/arg-length.js 
PRE-CREATION 

Diff: https://reviews.apache.org/r/56981/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 56975: File upload from Ambari File View does not work in Chrome 56.0.2924.87 and IE 11

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56975/#review166511
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 23, 2017, 8:59 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56975/
> ---
> 
> (Updated Feb. 23, 2017, 8:59 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20137
> https://issues.apache.org/jira/browse/AMBARI-20137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Fixed Cannot add directory issue in chrome
> 2. Disable cache for ajax 
> 3. Handle filename in UTF-8
> 
> 
> Diffs
> -
> 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UploadService.java
>  26a4873 
>   contrib/views/files/src/main/resources/ui/app/adapters/application.js 
> 4042851 
>   contrib/views/files/src/main/resources/ui/app/components/upload-file.js 
> 96686db 
> 
> Diff: https://reviews.apache.org/r/56975/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 56977: Not able to compute the table statistics for partitioned table

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56977/#review166510
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 23, 2017, 9:30 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56977/
> ---
> 
> (Updated Feb. 23, 2017, 9:30 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20113
> https://issues.apache.org/jira/browse/AMBARI-20113
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the case of partitioned table in analyze query generation.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  902d959 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
>  e433dc4 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
>  89b9d84 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56977/diff/
> 
> 
> Testing
> ---
> 
> AnalyzeTableQueryGeneratorSpecTest unit test case added.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/
---

Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
and Sebastian Toader.


Bugs: AMBARI-20140
https://issues.apache.org/jira/browse/AMBARI-20140


Repository: ambari


Description
---

Spark2 and Spark1 shares the same principal name. This casuses a problem when 
adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
keytab to Spark2 because it thinks it already exists.

I extended the existing conditional to take the existence of the destination 
keytab file into consideration.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 5d6ccc0 

Diff: https://reviews.apache.org/r/56980/diff/


Testing
---

- Created a cluster with Spark
- Enabled Kerberos
- Added Spark2
- Checked if Spark2 started successfully and the exitence of 
/etc/security/keytabs/spark2.headless.keytab


Existing tests ran without failure.


Thanks,

Attila Magyar

Re: Review Request 56979: AMBARI-20050. Issue while importing workflow with insufficient permissions

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56979/#review166508
---


Ship it!




Ship It!

- belliraj hb


On Feb. 23, 2017, 12:04 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56979/
> ---
> 
> (Updated Feb. 23, 2017, 12:04 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20050
> https://issues.apache.org/jira/browse/AMBARI-20050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exception handling properly
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java
>  55c4312 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  6603a9c 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
>  ef3b508 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/ErrorCode.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmException.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
>  a0aa234 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 3ccbc07 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> bbd619d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js
>  7a7c38d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> f97add8 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/stack-trace-dialog.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less e98d182 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
>  ca58431 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  7b607ca 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs
>  8438255 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  1a73421 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/stack-trace-dialog.hbs
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/stack-trace-dialog-test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56979/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 56125: ambari-server SuSE11 init script not working in certain environments

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56125/#review166507
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 23, 2017, 1:31 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56125/
> ---
> 
> (Updated Feb. 23, 2017, 1:31 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19797
> https://issues.apache.org/jira/browse/AMBARI-19797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On SuSE11, the same sysvinit script as used for RHEL6 is being installed.  
> On RHEL6, this contains the chkconfig header specifying that ambari-server and
> ambari-agent services should start as late as possible:  
> head -2 /etc/init.d/ambari-server  
> #!/usr/bin/env bash  
> chkconfig: 345 95 20  
> head -2 /etc/init.d/ambari-agent  
> #!/usr/bin/env bash  
> chkconfig: 345 95 20  
> However, these instructions are not honored by Suse, leading to the init
> scrips being scheduled as the first ones to start, before networking and other
> essentials:  
> ls -l /etc/init.d/rc3.d/|grep ambari  
> lrwxrwxrwx 1 root root 15 Jan 23 20:57 K01ambari-agent -> ../ambari-agent  
> lrwxrwxrwx 1 root root 16 Jan 23 20:57 K01ambari-server -> ../ambari-server  
> lrwxrwxrwx 1 root root 15 Jan 23 20:09 S01ambari-agent -> ../ambari-agent  
> lrwxrwxrwx 1 root root 16 Jan 23 20:57 S01ambari-server -> ../ambari-server  
> 
> 
> The ambari-server fails to automatically start after reboot on an Suse11
> system due to the service starting before the network (with the following
> error, also attached in the logs):  
> 1) Error injecting constructor, java.net.UnknownHostException:
> ip-172-31-23-241: ip-172-31-23-241: unknown error  
> This especially happens on system where DNS is being used for resolve
> hostnames (such as on AWS or many users).  
> 
> 
> STR:
> Install a SuSE11 SP4, preferably on AWS or remove any references from
> /etc/hosts.  
> Install the Ambari repo, the packages and run the setup:  
> wget -nv  repo-1.hortonworks.com/ambari/suse11/2.x/updates/2.4.2.0/ambari.repo> -O
> /etc/zypp/repos.d/ambari.repo  
> zypper -n install ambari-agent ambari-server  
> ambari-server setup  
> /etc/init.d/ambari-server start  
> reboot  
> Notice the ambari-server does not come up after reboot.  
> How to fix:  
> As per , the solution is
> to set # Required-Start: $ALL in the script headers.
> 
> 
> Diffs
> -
> 
>   ambari-agent/etc/init.d/ambari-agent 2d597a9 
>   ambari-server/sbin/ambari-server 88d503d 
> 
> Diff: https://reviews.apache.org/r/56125/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 56979: AMBARI-20050. Issue while importing workflow with insufficient permissions

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56979/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20050
https://issues.apache.org/jira/browse/AMBARI-20050


Repository: ambari


Description
---

Exception handling properly


Diffs
-

  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java
 55c4312 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
 6603a9c 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
 ef3b508 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/ErrorCode.java
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmException.java
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
 a0aa234 
  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
3ccbc07 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
bbd619d 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js 
7a7c38d 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
f97add8 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/stack-trace-dialog.js
 PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less e98d182 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
 ca58431 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
 7b607ca 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs
 8438255 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 1a73421 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/stack-trace-dialog.hbs
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/stack-trace-dialog-test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56979/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 56125: ambari-server SuSE11 init script not working in certain environments

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56125/#review166505
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лют. 23, 2017, 11:31 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56125/
> ---
> 
> (Updated Лют. 23, 2017, 11:31 до полудня)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19797
> https://issues.apache.org/jira/browse/AMBARI-19797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On SuSE11, the same sysvinit script as used for RHEL6 is being installed.  
> On RHEL6, this contains the chkconfig header specifying that ambari-server and
> ambari-agent services should start as late as possible:  
> head -2 /etc/init.d/ambari-server  
> #!/usr/bin/env bash  
> chkconfig: 345 95 20  
> head -2 /etc/init.d/ambari-agent  
> #!/usr/bin/env bash  
> chkconfig: 345 95 20  
> However, these instructions are not honored by Suse, leading to the init
> scrips being scheduled as the first ones to start, before networking and other
> essentials:  
> ls -l /etc/init.d/rc3.d/|grep ambari  
> lrwxrwxrwx 1 root root 15 Jan 23 20:57 K01ambari-agent -> ../ambari-agent  
> lrwxrwxrwx 1 root root 16 Jan 23 20:57 K01ambari-server -> ../ambari-server  
> lrwxrwxrwx 1 root root 15 Jan 23 20:09 S01ambari-agent -> ../ambari-agent  
> lrwxrwxrwx 1 root root 16 Jan 23 20:57 S01ambari-server -> ../ambari-server  
> 
> 
> The ambari-server fails to automatically start after reboot on an Suse11
> system due to the service starting before the network (with the following
> error, also attached in the logs):  
> 1) Error injecting constructor, java.net.UnknownHostException:
> ip-172-31-23-241: ip-172-31-23-241: unknown error  
> This especially happens on system where DNS is being used for resolve
> hostnames (such as on AWS or many users).  
> 
> 
> STR:
> Install a SuSE11 SP4, preferably on AWS or remove any references from
> /etc/hosts.  
> Install the Ambari repo, the packages and run the setup:  
> wget -nv  repo-1.hortonworks.com/ambari/suse11/2.x/updates/2.4.2.0/ambari.repo> -O
> /etc/zypp/repos.d/ambari.repo  
> zypper -n install ambari-agent ambari-server  
> ambari-server setup  
> /etc/init.d/ambari-server start  
> reboot  
> Notice the ambari-server does not come up after reboot.  
> How to fix:  
> As per , the solution is
> to set # Required-Start: $ALL in the script headers.
> 
> 
> Diffs
> -
> 
>   ambari-agent/etc/init.d/ambari-agent 2d597a9 
>   ambari-server/sbin/ambari-server 88d503d 
> 
> Diff: https://reviews.apache.org/r/56125/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56125: ambari-server SuSE11 init script not working in certain environments

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56125/
---

(Updated Feb. 23, 2017, 11:31 a.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19797
https://issues.apache.org/jira/browse/AMBARI-19797


Repository: ambari


Description
---

On SuSE11, the same sysvinit script as used for RHEL6 is being installed.  
On RHEL6, this contains the chkconfig header specifying that ambari-server and
ambari-agent services should start as late as possible:  
head -2 /etc/init.d/ambari-server  
#!/usr/bin/env bash  
chkconfig: 345 95 20  
head -2 /etc/init.d/ambari-agent  
#!/usr/bin/env bash  
chkconfig: 345 95 20  
However, these instructions are not honored by Suse, leading to the init
scrips being scheduled as the first ones to start, before networking and other
essentials:  
ls -l /etc/init.d/rc3.d/|grep ambari  
lrwxrwxrwx 1 root root 15 Jan 23 20:57 K01ambari-agent -> ../ambari-agent  
lrwxrwxrwx 1 root root 16 Jan 23 20:57 K01ambari-server -> ../ambari-server  
lrwxrwxrwx 1 root root 15 Jan 23 20:09 S01ambari-agent -> ../ambari-agent  
lrwxrwxrwx 1 root root 16 Jan 23 20:57 S01ambari-server -> ../ambari-server  


The ambari-server fails to automatically start after reboot on an Suse11
system due to the service starting before the network (with the following
error, also attached in the logs):  
1) Error injecting constructor, java.net.UnknownHostException:
ip-172-31-23-241: ip-172-31-23-241: unknown error  
This especially happens on system where DNS is being used for resolve
hostnames (such as on AWS or many users).  


STR:
Install a SuSE11 SP4, preferably on AWS or remove any references from
/etc/hosts.  
Install the Ambari repo, the packages and run the setup:  
wget -nv  -O
/etc/zypp/repos.d/ambari.repo  
zypper -n install ambari-agent ambari-server  
ambari-server setup  
/etc/init.d/ambari-server start  
reboot  
Notice the ambari-server does not come up after reboot.  
How to fix:  
As per , the solution is
to set # Required-Start: $ALL in the script headers.


Diffs (updated)
-

  ambari-agent/etc/init.d/ambari-agent 2d597a9 
  ambari-server/sbin/ambari-server 88d503d 

Diff: https://reviews.apache.org/r/56125/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 56977: Not able to compute the table statistics for partitioned table

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56977/#review166504
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 23, 2017, 9:30 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56977/
> ---
> 
> (Updated Feb. 23, 2017, 9:30 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20113
> https://issues.apache.org/jira/browse/AMBARI-20113
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the case of partitioned table in analyze query generation.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  902d959 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
>  e433dc4 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
>  89b9d84 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56977/diff/
> 
> 
> Testing
> ---
> 
> AnalyzeTableQueryGeneratorSpecTest unit test case added.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 56977: Not able to compute the table statistics for partitioned table

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56977/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20113
https://issues.apache.org/jira/browse/AMBARI-20113


Repository: ambari


Description
---

corrected the case of partitioned table in analyze query generation.


Diffs
-

  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
 902d959 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
 e433dc4 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
 89b9d84 
  
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56977/diff/


Testing
---

AnalyzeTableQueryGeneratorSpecTest unit test case added.


Thanks,

Nitiraj Rathore

Re: Review Request 56975: File upload from Ambari File View does not work in Chrome 56.0.2924.87 and IE 11

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56975/#review166498
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 23, 2017, 8:59 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56975/
> ---
> 
> (Updated Feb. 23, 2017, 8:59 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20137
> https://issues.apache.org/jira/browse/AMBARI-20137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Fixed Cannot add directory issue in chrome
> 2. Disable cache for ajax 
> 3. Handle filename in UTF-8
> 
> 
> Diffs
> -
> 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UploadService.java
>  26a4873 
>   contrib/views/files/src/main/resources/ui/app/adapters/application.js 
> 4042851 
>   contrib/views/files/src/main/resources/ui/app/components/upload-file.js 
> 96686db 
> 
> Diff: https://reviews.apache.org/r/56975/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 56975: File upload from Ambari File View does not work in Chrome 56.0.2924.87 and IE 11

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56975/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20137
https://issues.apache.org/jira/browse/AMBARI-20137


Repository: ambari


Description
---

1. Fixed Cannot add directory issue in chrome
2. Disable cache for ajax 
3. Handle filename in UTF-8


Diffs
-

  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UploadService.java
 26a4873 
  contrib/views/files/src/main/resources/ui/app/adapters/application.js 4042851 
  contrib/views/files/src/main/resources/ui/app/components/upload-file.js 
96686db 

Diff: https://reviews.apache.org/r/56975/diff/


Testing
---

Manually Tested.


Thanks,

Gaurav Nagar

Re: Review Request 56957: Click feedback/disable toggle is missing for transition buttons in Kerberos Wizard - prone to various failures

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56957/#review166494
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Feb. 23, 2017, 8:50 a.m., Denys Buzhor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56957/
> ---
> 
> (Updated Feb. 23, 2017, 8:50 a.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-20123
> https://issues.apache.org/jira/browse/AMBARI-20123
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following items should be fixed:
> 
> * After the user clicks on "Next", need to disable the button right away and 
> show the spin animation in the button like we already do for Install Wizard
> * While a step is still loading, do not allow the user to click Next (the 
> button should be disabled until the step has completed loading)
> * Download CSV request can take some time, need to show spin animation and 
> prevent additional clicks during data loading
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js c0decfc 
>   ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 992fd34 
>   ambari-web/app/controllers/main/admin/kerberos/step4_controller.js 8e5abd5 
>   ambari-web/app/controllers/main/admin/kerberos/step5_controller.js 9cb75e0 
>   ambari-web/app/mixins/wizard/wizardProgressPageController.js d426eda 
>   ambari-web/app/routes/add_kerberos_routes.js fe21dae 
>   ambari-web/app/styles/common.less 94a5cd3 
>   ambari-web/app/templates/common/button_progress.hbs PRE-CREATION 
>   ambari-web/app/templates/common/progress.hbs fce5641 
>   ambari-web/app/templates/main/admin/kerberos/step1.hbs 19e5596 
>   ambari-web/app/templates/main/admin/kerberos/step2.hbs c17347c 
>   ambari-web/app/templates/main/admin/kerberos/step3.hbs 6e2ea57 
>   ambari-web/app/templates/main/admin/kerberos/step4.hbs 1e6f956 
>   ambari-web/app/templates/main/admin/kerberos/step5.hbs c0cdc00 
>   ambari-web/app/views.js 9addd91 
>   ambari-web/app/views/common/buttons/button_progress_view.js PRE-CREATION 
>   ambari-web/app/views/common/buttons/wizard_buttons.js PRE-CREATION 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> 3181fda 
>   ambari-web/test/controllers/main/admin/kerberos/step2_controller_test.js 
> 2e603da 
> 
> Diff: https://reviews.apache.org/r/56957/diff/
> 
> 
> Testing
> ---
> 
> 20375 passing (25s)
>   153 pending
> 
> 
> Thanks,
> 
> Denys Buzhor
> 
>

Re: Review Request 56880: Zeppelin should configure hadoop.proxyuser in HDFS core-site.xml

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56880/
---

(Updated Feb. 23, 2017, 8:40 a.m.)


Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, 
Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit 
Mohanty.


Changes
---

remove realm name


Bugs: AMBARI-20094
https://issues.apache.org/jira/browse/AMBARI-20094


Repository: ambari


Description
---

Zeppelin should configure hadoop.proxyuser.zeppelin.groups and 
hadoop.proxyuser.zeppelin.hosts in HDFS core-site.xml


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
 5625681 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/kerberos.json 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/kerberos.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/56880/diff/


Testing
---

Manually tested on CentOS6.4


Thanks,

Prabhjyot Singh