Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/#review166805
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 24, 2017, 10 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57039/
> ---
> 
> (Updated Feb. 24, 2017, 10 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20145
> https://issues.apache.org/jira/browse/AMBARI-20145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
> plugin is enabled (plugin exists as of HDP 2.3)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
> e1e6461 
> 
> Diff: https://reviews.apache.org/r/57039/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the fix.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 57060: HostCleaup.py throws exception and exits when hostcheck_custom_actions.result not present

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57060/
---

Review request for Ambari, Di Li and Jonathan Hurley.


Bugs: AMBARI-20192
https://issues.apache.org/jira/browse/AMBARI-20192


Repository: ambari


Description
---

HostCleanup script throws following exception and exits when 
hostcheck_custom_actions.result not present
[root@tsar1 ~]# /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py
You have elected to remove all users as well. If it is not intended then use 
option --skip "users". Do you want to continue [y/n] (y)y
Host Check results not found. There is no 
/var/lib/ambari-agent/data/hostcheck_custom_actions.result. Do you want to run 
host checks [y/n] (y)n
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py", line 705, 
in 
main()
File "/usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py", line 689, 
in main
with open(hostcheckfileca, "rb") as f2:
IOError: [Errno 2] No such file or directory: 
'/var/lib/ambari-agent/data/hostcheck_custom_actions.result'


Diffs
-

  ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7ee3b1c 

Diff: https://reviews.apache.org/r/57060/diff/


Testing
---

Manually tested. Cleanup completed successfully when no 
hostcheck_custom_actions.result file was present


Thanks,

Amruta Borkar

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/
---

(Updated Feb. 25, 2017, 2:59 a.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
Robert Nettleton.


Changes
---

- added UpgradeCatalog tests
- small fixes


Bugs: AMBARI-20152
https://issues.apache.org/jira/browse/AMBARI-20152


Repository: ambari


Description
---

Use storm principal and keytab for ranger plugin instead of nimbus ones.
In storm code, storm user will be used globally anyway, ranger plugin will use 
that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
authorization is supported, that can cause if storm is authenticated with the 
worng user, it wont be able to access the ranger audit collection.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 bfab0fe 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json 
0c25c95 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
d024146 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
60c8afb 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
c5b3201 
  ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
fecef7c 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 a08b38b 
  
ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_5_infra_solr.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56997/diff/


Testing
---

done.


Thanks,

Oliver Szabo

Re: Review Request 56974: Services should be able to specify that credential store is always enabled

[Sumit Mohanty]

> On Feb. 24, 2017, 7:04 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java,
> >  line 481
> > 
> >
> > Minor nit: Null check not needed since it is primitive type, default 
> > would be false.

credentialStoreInfo.isRequired() returns a Boolean and that can be null. It did 
throw NPE possibly while doing the conversion. So left the code as is.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56974/#review166745
---


On Feb. 25, 2017, 1:29 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56974/
> ---
> 
> (Updated Feb. 25, 2017, 1:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Mugdha Varadkar, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20136
> https://issues.apache.org/jira/browse/AMBARI-20136
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Details in the JIRA
> 
> Removed credential store sections from Ranger as Ranger does not use the 
> Ambari feature.
> 
> Once this feature is in, LogSearch will be modified to make CS as a required 
> capability.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
>  ec45a85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  a6dd31f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  a1c53a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  504da49 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java
>  43f6690 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> 0f425a4 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 713c189 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> a38af29 
>   ambari-server/src/main/resources/properties.json 698b6c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 
> f2002e1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/RANGER/metainfo.xml 
> 97bc19f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 
> 7afbfb7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 
> cc25d44 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  8859d7f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java
>  3b963a8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java
>  3034459 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/HDFS/metainfo.xml 
> 281c77e 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/STORM/metainfo.xml 
> 6075ba3 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/ZOOKEEPER/metainfo.xml
>  ed0a132 
> 
> Diff: https://reviews.apache.org/r/56974/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit tests locally - 
> 
> i-server-2.0.0.0-SNAPSHOT-dist.tar.gz
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [3.673s]
> [INFO] utility ... SUCCESS [1.361s]
> [INFO] Ambari Metrics Common . SUCCESS [7.726s]
> [INFO] Ambari Server . SUCCESS 
> [26:48.326s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 27:01.578s
> [INFO] Finished at: Wed Feb 22 23:43:51 PST 2017
> [INFO] Final Memory: 96M/658M
> [INFO] 
> 
> [smohanty@HW12158 asf-ambari (trunk)]$
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 56974: Services should be able to specify that credential store is always enabled

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56974/
---

(Updated Feb. 25, 2017, 1:29 a.m.)


Review request for Ambari, Alejandro Fernandez, Mugdha Varadkar, and Sid Wagle.


Bugs: AMBARI-20136
https://issues.apache.org/jira/browse/AMBARI-20136


Repository: ambari


Description
---

Details in the JIRA

Removed credential store sections from Ranger as Ranger does not use the Ambari 
feature.

Once this feature is in, LogSearch will be modified to make CS as a required 
capability.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
 ec45a85 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
 a6dd31f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 a1c53a7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
 504da49 
  
ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java
 43f6690 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
0f425a4 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
713c189 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
a38af29 
  ambari-server/src/main/resources/properties.json 698b6c5 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 
f2002e1 
  ambari-server/src/main/resources/stacks/HDP/2.4/services/RANGER/metainfo.xml 
97bc19f 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 
7afbfb7 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 
cc25d44 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 8859d7f 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java
 3b963a8 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java 
3034459 
  ambari-server/src/test/resources/stacks/HDP/2.2.0/services/HDFS/metainfo.xml 
281c77e 
  ambari-server/src/test/resources/stacks/HDP/2.2.0/services/STORM/metainfo.xml 
6075ba3 
  
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/ZOOKEEPER/metainfo.xml
 ed0a132 

Diff: https://reviews.apache.org/r/56974/diff/


Testing
---

Ran all unit tests locally - 

i-server-2.0.0.0-SNAPSHOT-dist.tar.gz
[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views .. SUCCESS [3.673s]
[INFO] utility ... SUCCESS [1.361s]
[INFO] Ambari Metrics Common . SUCCESS [7.726s]
[INFO] Ambari Server . SUCCESS [26:48.326s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 27:01.578s
[INFO] Finished at: Wed Feb 22 23:43:51 PST 2017
[INFO] Final Memory: 96M/658M
[INFO] 
[smohanty@HW12158 asf-ambari (trunk)]$


Thanks,

Sumit Mohanty

Re: Review Request 57056: Log Search Portal is not working with HTTPS with it's own created Key Store

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57056/#review166796
---


Ship it!




Ship It!

- Robert Nettleton


On Feb. 25, 2017, 1:06 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57056/
> ---
> 
> (Updated Feb. 25, 2017, 1:06 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20193
> https://issues.apache.org/jira/browse/AMBARI-20193
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If "Advanced logsearch-env / Log Search UI Protocol" is set to https and we 
> let Log Search to create it's own Key Store than it's not working fine, the 
> service starts but the portal is unavailable.al.
> 
> Also made the docker test environment configurable if we want it to create a 
> key store, or let the Log Search Portal do it due to it's abscence.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
>  ea3474f 
>   ambari-logsearch/docker/bin/start.sh 4c60981 
>   ambari-logsearch/docker/logsearch-docker.sh 76994ee 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 8d92e20 
> 
> Diff: https://reviews.apache.org/r/57056/diff/
> 
> 
> Testing
> ---
> 
> Tested in the docker test environment.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 57053: LogSearch Integration for HostComponent resource errors should be logged at the DEBUG level

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57053/
---

(Updated Feb. 25, 2017, 1:11 a.m.)


Review request for Ambari, Miklos Gergely and Oliver Szabo.


Bugs: AMBARI-20190
https://issues.apache.org/jira/browse/AMBARI-20190


Repository: ambari


Description
---

This patch resolves AMBARI-20190. 

During some larger cluster testing with LogSearch, it was discovered that a 
debugging message was logged at the ERROR level, and was logged repeatedly 
(thousands of times in an 800-node cluster). 

This patch resolves this problem by implementing the following:

1. The ERROR message in question was moved to the DEBUG level, since it is only 
generally useful in debugging situations for the integration layer. 
2. The message was also updated to include the host and component name for the 
resource associated with the failure, as this could be useful in future 
debugging sessions when certain components aren't available via LogSearch.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 36c485a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/Utils.java
 969d442 

Diff: https://reviews.apache.org/r/57053/diff/


Testing (updated)
---

1. Tested manually with a 3-node vagrant cluster, to verify that the updated 
log message is only available at the DEBUG level, and also that the message not 
includes the host and component names when DEBUG-level logging is turned on. 
2. The ambari-server "mvn clean test" run passed on both the trunk and 
branch-2.5 branches with this patch applied.


Thanks,

Robert Nettleton

Re: Review Request 57056: Log Search Portal is not working with HTTPS with it's own created Key Store

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57056/
---

(Updated Feb. 25, 2017, 1:06 a.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

Fix description


Bugs: AMBARI-20193
https://issues.apache.org/jira/browse/AMBARI-20193


Repository: ambari


Description (updated)
---

If "Advanced logsearch-env / Log Search UI Protocol" is set to https and we let 
Log Search to create it's own Key Store than it's not working fine, the service 
starts but the portal is unavailable.al.

Also made the docker test environment configurable if we want it to create a 
key store, or let the Log Search Portal do it due to it's abscence.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
 ea3474f 
  ambari-logsearch/docker/bin/start.sh 4c60981 
  ambari-logsearch/docker/logsearch-docker.sh 76994ee 
  ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 8d92e20 

Diff: https://reviews.apache.org/r/57056/diff/


Testing
---

Tested in the docker test environment.


Thanks,

Miklos Gergely

Review Request 57056: Log Search Portal is not working with HTTPS with it's own created Key Store

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57056/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-20193
https://issues.apache.org/jira/browse/AMBARI-20193


Repository: ambari


Description
---

Allow the choice to install Log Search without a portal, i.e. to install only 
Log Feeders which load the entries into an external solr which are viewable via 
an external portal.

Also made the docker test environment configurable if we want it to create a 
key store, or let the Log Search Portal do it due to it's abscence.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
 ea3474f 
  ambari-logsearch/docker/bin/start.sh 4c60981 
  ambari-logsearch/docker/logsearch-docker.sh 76994ee 
  ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 8d92e20 

Diff: https://reviews.apache.org/r/57056/diff/


Testing
---

Tested in the docker test environment.


Thanks,

Miklos Gergely

Re: Review Request 57051: Move spinner for Next and Back button in Kerberos Wizard

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57051/#review166774
---


Ship it!




Ship It!

- Alexandr Antonenko


On Feb. 24, 2017, 10:27 p.m., Denys Buzhor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57051/
> ---
> 
> (Updated Feb. 24, 2017, 10:27 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-20185
> https://issues.apache.org/jira/browse/AMBARI-20185
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spinner for Next/Back button should be place in the same place as for other 
> wizard e.g. Installer, Add Service etc. Spinner for Next button should be 
> shown on the left side and on the right side for Back button.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/buttons/wizard_buttons.js 3bf89f2c77 
> 
> Diff: https://reviews.apache.org/r/57051/diff/
> 
> 
> Testing
> ---
> 
> 30333 passing (27s)
> 157 pending
> 
> 
> Thanks,
> 
> Denys Buzhor
> 
>

Re: Review Request 57053: LogSearch Integration for HostComponent resource errors should be logged at the DEBUG level

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57053/#review166773
---


Ship it!




Ship It!

- Oliver Szabo


On Feb. 24, 2017, 10:50 p.m., Robert Nettleton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57053/
> ---
> 
> (Updated Feb. 24, 2017, 10:50 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Oliver Szabo.
> 
> 
> Bugs: AMBARI-20190
> https://issues.apache.org/jira/browse/AMBARI-20190
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch resolves AMBARI-20190. 
> 
> During some larger cluster testing with LogSearch, it was discovered that a 
> debugging message was logged at the ERROR level, and was logged repeatedly 
> (thousands of times in an 800-node cluster). 
> 
> This patch resolves this problem by implementing the following:
> 
> 1. The ERROR message in question was moved to the DEBUG level, since it is 
> only generally useful in debugging situations for the integration layer. 
> 2. The message was also updated to include the host and component name for 
> the resource associated with the failure, as this could be useful in future 
> debugging sessions when certain components aren't available via LogSearch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  36c485a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/Utils.java
>  969d442 
> 
> Diff: https://reviews.apache.org/r/57053/diff/
> 
> 
> Testing
> ---
> 
> 1. Tested manually with a 3-node vagrant cluster, to verify that the updated 
> log message is only available at the DEBUG level, and also that the message 
> not includes the host and component names when DEBUG-level logging is turned 
> on. 
> 2. Currently running the ambari-server unit test suite, and will update the 
> review with the results.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>

Review Request 57053: LogSearch Integration for HostComponent resource errors should be logged at the DEBUG level

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57053/
---

Review request for Ambari, Miklos Gergely and Oliver Szabo.


Bugs: AMBARI-20190
https://issues.apache.org/jira/browse/AMBARI-20190


Repository: ambari


Description
---

This patch resolves AMBARI-20190. 

During some larger cluster testing with LogSearch, it was discovered that a 
debugging message was logged at the ERROR level, and was logged repeatedly 
(thousands of times in an 800-node cluster). 

This patch resolves this problem by implementing the following:

1. The ERROR message in question was moved to the DEBUG level, since it is only 
generally useful in debugging situations for the integration layer. 
2. The message was also updated to include the host and component name for the 
resource associated with the failure, as this could be useful in future 
debugging sessions when certain components aren't available via LogSearch.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 36c485a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/Utils.java
 969d442 

Diff: https://reviews.apache.org/r/57053/diff/


Testing
---

1. Tested manually with a 3-node vagrant cluster, to verify that the updated 
log message is only available at the DEBUG level, and also that the message not 
includes the host and component names when DEBUG-level logging is turned on. 
2. Currently running the ambari-server unit test suite, and will update the 
review with the results.


Thanks,

Robert Nettleton

Re: Review Request 57051: Move spinner for Next and Back button in Kerberos Wizard

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57051/#review166767
---


Ship it!




Ship It!

- Yusaku Sako


On Feb. 24, 2017, 10:27 p.m., Denys Buzhor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57051/
> ---
> 
> (Updated Feb. 24, 2017, 10:27 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-20185
> https://issues.apache.org/jira/browse/AMBARI-20185
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spinner for Next/Back button should be place in the same place as for other 
> wizard e.g. Installer, Add Service etc. Spinner for Next button should be 
> shown on the left side and on the right side for Back button.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/buttons/wizard_buttons.js 3bf89f2c77 
> 
> Diff: https://reviews.apache.org/r/57051/diff/
> 
> 
> Testing
> ---
> 
> 30333 passing (27s)
> 157 pending
> 
> 
> Thanks,
> 
> Denys Buzhor
> 
>

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/#review166758
---


Ship it!




Ship It!

- Attila Doroszlai


On Feb. 24, 2017, 10 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57039/
> ---
> 
> (Updated Feb. 24, 2017, 10 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20145
> https://issues.apache.org/jira/browse/AMBARI-20145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
> plugin is enabled (plugin exists as of HDP 2.3)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
> e1e6461 
> 
> Diff: https://reviews.apache.org/r/57039/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the fix.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/#review166757
---


Ship it!




Ship It!

- Robert Levas


On Feb. 24, 2017, 4 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57039/
> ---
> 
> (Updated Feb. 24, 2017, 4 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20145
> https://issues.apache.org/jira/browse/AMBARI-20145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
> plugin is enabled (plugin exists as of HDP 2.3)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
> e1e6461 
> 
> Diff: https://reviews.apache.org/r/57039/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the fix.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/
---

(Updated Feb. 24, 2017, 9 p.m.)


Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
Levas, and Sebastian Toader.


Changes
---

review comments.


Bugs: AMBARI-20145
https://issues.apache.org/jira/browse/AMBARI-20145


Repository: ambari


Description
---

Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
plugin is enabled (plugin exists as of HDP 2.3)


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
2b1c01b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
e1e6461 

Diff: https://reviews.apache.org/r/57039/diff/


Testing
---

Manually tested the fix.


Thanks,

Balázs Bence Sári

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review166753
---


Ship it!




Ship It!

- Robert Levas


On Feb. 24, 2017, 2:28 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 24, 2017, 2:28 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  bfab0fe 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json
>  0c25c95 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  d024146 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  60c8afb 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> c5b3201 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/
---

(Updated Feb. 24, 2017, 7:28 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
Robert Nettleton.


Changes
---

added when conditions for infra-solr service identity references


Bugs: AMBARI-20152
https://issues.apache.org/jira/browse/AMBARI-20152


Repository: ambari


Description
---

Use storm principal and keytab for ranger plugin instead of nimbus ones.
In storm code, storm user will be used globally anyway, ranger plugin will use 
that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
authorization is supported, that can cause if storm is authenticated with the 
worng user, it wont be able to access the ranger audit collection.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 bfab0fe 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json 
0c25c95 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
d024146 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
60c8afb 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
c5b3201 
  ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
fecef7c 

Diff: https://reviews.apache.org/r/56997/diff/


Testing
---

done.


Thanks,

Oliver Szabo

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Robert Levas]

> On Feb. 24, 2017, 1:10 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, 
> > line 10
> > 
> >
> > In Zookeeper + Kafka cluster (no HDFS) this will result in failure 
> > during kerberization:
> > 
> > ```
> > Traceback (most recent call last):
> >   File 
> > "/var/lib/ambari-agent/cache/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py",
> >  line 80, in 
> > KerberosClient().execute()
> > ...
> > resource_management.core.exceptions.Fail: User 
> > '${hadoop-env/hdfs_user}' doesn't exist
> > ```

If Kafka can be installed without HDFS then a "when" clause should be added

```
"when" : {
 "contains" : ["services", "HDFS"]
}
```


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/#review166742
---


On Feb. 24, 2017, 9:19 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57039/
> ---
> 
> (Updated Feb. 24, 2017, 9:19 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20145
> https://issues.apache.org/jira/browse/AMBARI-20145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
> plugin is enabled (plugin exists as of HDP 2.3)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
> e1e6461 
> 
> Diff: https://reviews.apache.org/r/57039/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the fix.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56974: Services should be able to specify that credential store is always enabled

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56974/#review166745
---


Fix it, then Ship it!




In general, patch looks good to me.


ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
(line 481)


Minor nit: Null check not needed since it is primitive type, default would 
be false.



ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 (line 10364)


Can you rename the test to convey more meaning, optinally add comments for 
future ref. Thanks.


- Sid Wagle


On Feb. 23, 2017, 7:53 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56974/
> ---
> 
> (Updated Feb. 23, 2017, 7:53 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Mugdha Varadkar, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20136
> https://issues.apache.org/jira/browse/AMBARI-20136
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Details in the JIRA
> 
> Removed credential store sections from Ranger as Ranger does not use the 
> Ambari feature.
> 
> Once this feature is in, LogSearch will be modified to make CS as a required 
> capability.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  a1c53a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  504da49 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java
>  43f6690 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> 0f425a4 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 713c189 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 56fcd74 
>   ambari-server/src/main/resources/properties.json 698b6c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 
> f2002e1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/RANGER/metainfo.xml 
> 97bc19f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 
> 7afbfb7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 
> cc25d44 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  c40ff64 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java
>  3034459 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/HDFS/metainfo.xml 
> 281c77e 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/STORM/metainfo.xml 
> 6075ba3 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/ZOOKEEPER/metainfo.xml
>  ed0a132 
> 
> Diff: https://reviews.apache.org/r/56974/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit tests locally - 
> 
> i-server-2.0.0.0-SNAPSHOT-dist.tar.gz
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views .. SUCCESS [3.673s]
> [INFO] utility ... SUCCESS [1.361s]
> [INFO] Ambari Metrics Common . SUCCESS [7.726s]
> [INFO] Ambari Server . SUCCESS 
> [26:48.326s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 27:01.578s
> [INFO] Finished at: Wed Feb 22 23:43:51 PST 2017
> [INFO] Final Memory: 96M/658M
> [INFO] 
> 
> [smohanty@HW12158 asf-ambari (trunk)]$
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/#review166742
---




ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
(line 10)


In Zookeeper + Kafka cluster (no HDFS) this will result in failure during 
kerberization:

```
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py",
 line 80, in 
KerberosClient().execute()
...
resource_management.core.exceptions.Fail: User '${hadoop-env/hdfs_user}' 
doesn't exist
```


- Attila Doroszlai


On Feb. 24, 2017, 3:19 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57039/
> ---
> 
> (Updated Feb. 24, 2017, 3:19 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20145
> https://issues.apache.org/jira/browse/AMBARI-20145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
> plugin is enabled (plugin exists as of HDP 2.3)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
> e1e6461 
> 
> Diff: https://reviews.apache.org/r/57039/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the fix.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/#review166740
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
(lines 8 - 10)


This should be in the `identities` block of the `KAFKA_BROKER` component.  
We don't want this to be distributed to all hosts where any Kafka component is 
installed.   Today there is only one component, in the future, there may be 
more.



ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
(lines 8 - 10)


Same as previous comment.


- Robert Levas


On Feb. 24, 2017, 9:19 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57039/
> ---
> 
> (Updated Feb. 24, 2017, 9:19 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20145
> https://issues.apache.org/jira/browse/AMBARI-20145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
> plugin is enabled (plugin exists as of HDP 2.3)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
> e1e6461 
> 
> Diff: https://reviews.apache.org/r/57039/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the fix.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57041: DB selected is not persisted while switching between tabs, SavedQuery tab does not show preview, if the query is not executed before saving

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57041/#review166734
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 24, 2017, 2:31 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57041/
> ---
> 
> (Updated Feb. 24, 2017, 2:31 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20173
> https://issues.apache.org/jira/browse/AMBARI-20173
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1.Create an worksheet and select a database called "Default".
> 2.Create another worksheet and select another database "Sample".
> 3.Switch between the worksheets and the database selection will not be 
> persisted across the worksheets
> SavedQuery tab does not show preview, if the query is not executed before 
> saving:
> If the query is not executed before saving, preview is not being shown.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java
>  ef497ce 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 16103b7 
>   contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 
> 7b18424 
>   contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 
> 80a19f3 
> 
> Diff: https://reviews.apache.org/r/57041/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

[Robert Levas]

On Feb. 24, 2017, 11:27 a.m., Sebastian Toader wrote:
> > Should any unit tests be updated?
> 
> Sebastian Toader wrote:
> Existing unit tests passed fine with the change. Is there already a 
> mechanism in Ambari that can be used to test if certain records are persisted 
> within a transaction or not?

I don't know if there is such a thing... DB-related unit testing isn't in my 
wheelhouse. :|


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56987/#review166716
---


On Feb. 24, 2017, 10:25 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56987/
> ---
> 
> (Updated Feb. 24, 2017, 10:25 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-19929
> https://issues.apache.org/jira/browse/AMBARI-19929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move the persisting of 
> TopologyRequest/TopologyLogicalRequest/TopologyHostRequest records into a 
> single transaction to esnure consistency accross these records.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 9ef32b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  ab56844 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  a26624e 
> 
> Diff: https://reviews.apache.org/r/56987/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing covering cluster creation using Blueprint and than 
> cluster upscaling.
> 
> Unit tests: Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/#review166725
---


Ship it!




Ship It!

- Robert Levas


On Feb. 24, 2017, 11:34 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57040/
> ---
> 
> (Updated Feb. 24, 2017, 11:34 a.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20175
> https://issues.apache.org/jira/browse/AMBARI-20175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The rebalancing operation may take a long time (hours, days) thus when issued 
> from the ambari UI the background operation may time out.
> As it's not possible to dynamically predict how long the rebalancing will 
> last , the approach taken by this solution is to only trigger the operation 
> and not wait to the operation to finish.
> 
> (NOTE: after this change the progress of the rebalance operation won't be 
> tracked anymore in the background operation; also the user won't be notified 
> about the success/failure of the operation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  123486e 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fae500f 
> 
> Diff: https://reviews.apache.org/r/57040/diff/
> 
> 
> Testing
> ---
> 
> Manually.
> Unit tests success.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

[Sebastian Toader]

On Feb. 24, 2017, 5:27 p.m., Sebastian Toader wrote:
> > Should any unit tests be updated?

Existing unit tests passed fine with the change. Is there already a mechanism 
in Ambari that can be used to test if certain records are persisted within a 
transaction or not?


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56987/#review166716
---


On Feb. 24, 2017, 4:25 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56987/
> ---
> 
> (Updated Feb. 24, 2017, 4:25 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-19929
> https://issues.apache.org/jira/browse/AMBARI-19929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move the persisting of 
> TopologyRequest/TopologyLogicalRequest/TopologyHostRequest records into a 
> single transaction to esnure consistency accross these records.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 9ef32b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  ab56844 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  a26624e 
> 
> Diff: https://reviews.apache.org/r/56987/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing covering cluster creation using Blueprint and than 
> cluster upscaling.
> 
> Unit tests: Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Robert Levas]

> On Feb. 24, 2017, 8:25 a.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json, 
> > line 109
> > 
> >
> > Make sure the user-defined (artifacts/kerberos_descriptor) is updated 
> > and any configuration changes are performed using the appropriate 
> > UpgradeCatalog class.
> 
> Robert Levas wrote:
> For example see 
> `org.apache.ambari.server.upgrade.UpgradeCatalog240#updateKerberosDescriptorArtifact`
> 
> Oliver Szabo wrote:
> thanks, somehow we should check as well which HDP is used, because these 
> kerberos descriptor updates only needed if a specific HDP is installed

Your changes in revision 2 look good.  Since /STORM/NIMBUS/nimbus_server is not 
in the older stacks (`common-services/STORM/0.9.1/kerberos.json`), this will 
work ok.  However if you wanted to be really sure, checking that the stack 
would be nice... but that is problematic since we don't really have a good idea 
of all the stacks that could be out there.  Maybe there is a way to identitiy 
which version of STORM is being used instead.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review166699
---


On Feb. 24, 2017, 11:08 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 24, 2017, 11:08 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  bfab0fe 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 57043: Zeppelin Notebook fails to start without HDFS via Ambari service

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57043/#review166722
---


Ship it!




Ship It!

- Attila Doroszlai


On Feb. 24, 2017, 5:11 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57043/
> ---
> 
> (Updated Feb. 24, 2017, 5:11 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20176
> https://issues.apache.org/jira/browse/AMBARI-20176
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> - Create cluster with only ZooKeeper via blueprint
> - Add Zeppelin via Add Service wizard
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  78fbb1b8e6 
> 
> Diff: https://reviews.apache.org/r/57043/diff/
> 
> 
> Testing
> ---
> 
> Tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/
---

(Updated Feb. 24, 2017, 4:34 p.m.)


Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-20175
https://issues.apache.org/jira/browse/AMBARI-20175


Repository: ambari


Description
---

The rebalancing operation may take a long time (hours, days) thus when issued 
from the ambari UI the background operation may time out.
As it's not possible to dynamically predict how long the rebalancing will last 
, the approach taken by this solution is to only trigger the operation and not 
wait to the operation to finish.

(NOTE: after this change the progress of the rebalance operation won't be 
tracked anymore in the background operation; also the user won't be notified 
about the success/failure of the operation)


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 123486e 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fae500f 

Diff: https://reviews.apache.org/r/57040/diff/


Testing (updated)
---

Manually.
Unit tests success.


Thanks,

Laszlo Puskas

Re: Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56987/#review166716
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 (line 450)


There is problably a ?Utils.isEmpty(...) for this.


Should any unit tests be updated?

- Robert Levas


On Feb. 24, 2017, 10:25 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56987/
> ---
> 
> (Updated Feb. 24, 2017, 10:25 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-19929
> https://issues.apache.org/jira/browse/AMBARI-19929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move the persisting of 
> TopologyRequest/TopologyLogicalRequest/TopologyHostRequest records into a 
> single transaction to esnure consistency accross these records.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 9ef32b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  ab56844 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  a26624e 
> 
> Diff: https://reviews.apache.org/r/56987/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing covering cluster creation using Blueprint and than 
> cluster upscaling.
> 
> Unit tests: Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/#review166721
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 24, 2017, 5:18 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57040/
> ---
> 
> (Updated Feb. 24, 2017, 5:18 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20175
> https://issues.apache.org/jira/browse/AMBARI-20175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The rebalancing operation may take a long time (hours, days) thus when issued 
> from the ambari UI the background operation may time out.
> As it's not possible to dynamically predict how long the rebalancing will 
> last , the approach taken by this solution is to only trigger the operation 
> and not wait to the operation to finish.
> 
> (NOTE: after this change the progress of the rebalance operation won't be 
> tracked anymore in the background operation; also the user won't be notified 
> about the success/failure of the operation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  123486e 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fae500f 
> 
> Diff: https://reviews.apache.org/r/57040/diff/
> 
> 
> Testing
> ---
> 
> Manually.
> Unit tests running...
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57043: Zeppelin Notebook fails to start without HDFS via Ambari service

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57043/#review166718
---


Ship it!




Ship It!

- Prabhjyot Singh


On Feb. 24, 2017, 4:11 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57043/
> ---
> 
> (Updated Feb. 24, 2017, 4:11 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20176
> https://issues.apache.org/jira/browse/AMBARI-20176
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> - Create cluster with only ZooKeeper via blueprint
> - Add Zeppelin via Add Service wizard
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  78fbb1b8e6 
> 
> Diff: https://reviews.apache.org/r/57043/diff/
> 
> 
> Testing
> ---
> 
> Tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/
---

(Updated Feb. 24, 2017, 4:18 p.m.)


Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.


Changes
---

Fixed unit tests.


Bugs: AMBARI-20175
https://issues.apache.org/jira/browse/AMBARI-20175


Repository: ambari


Description
---

The rebalancing operation may take a long time (hours, days) thus when issued 
from the ambari UI the background operation may time out.
As it's not possible to dynamically predict how long the rebalancing will last 
, the approach taken by this solution is to only trigger the operation and not 
wait to the operation to finish.

(NOTE: after this change the progress of the rebalance operation won't be 
tracked anymore in the background operation; also the user won't be notified 
about the success/failure of the operation)


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 123486e 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fae500f 

Diff: https://reviews.apache.org/r/57040/diff/


Testing (updated)
---

Manually.
Unit tests running...


Thanks,

Laszlo Puskas

Review Request 57043: Zeppelin Notebook fails to start without HDFS via Ambari service

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57043/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-20176
https://issues.apache.org/jira/browse/AMBARI-20176


Repository: ambari


Description
---

Steps to reproduce:
- Create cluster with only ZooKeeper via blueprint
- Add Zeppelin via Add Service wizard


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 78fbb1b8e6 

Diff: https://reviews.apache.org/r/57043/diff/


Testing
---

Tested on CentOS


Thanks,

Renjith Kamath

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/
---

(Updated Feb. 24, 2017, 4:08 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
Robert Nettleton.


Changes
---

add upgradeCatalog changes.
- added storm identity upgrade
- include adding infra-solr references as well (those were added in an other 
patch for ambari 2.5)
- upgrade catalog test changes will be added later


Bugs: AMBARI-20152
https://issues.apache.org/jira/browse/AMBARI-20152


Repository: ambari


Description
---

Use storm principal and keytab for ranger plugin instead of nimbus ones.
In storm code, storm user will be used globally anyway, ranger plugin will use 
that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
authorization is supported, that can cause if storm is authenticated with the 
worng user, it wont be able to access the ranger audit collection.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 bfab0fe 
  ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
fecef7c 

Diff: https://reviews.apache.org/r/56997/diff/


Testing
---

done.


Thanks,

Oliver Szabo

Review Request 57042: Service Flume failed to start with "cannot open /grid/0/log/flume/a1.out for reading: Permission denied"

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57042/
---

Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19180
https://issues.apache.org/jira/browse/AMBARI-19180


Repository: ambari


Description
---

STR: 
-> Delete the following services on the cluster : Flume, Atlas, Hbase, Sqoop, 
Storm, Knox, AMS
-> Add them back using add service wizard
Flume fails to start with


2016-12-12 03:47:12,640 - Execute['ambari-sudo.sh  -H -E pgrep -o -u cstm-flume 
-f '^/usr/jdk64/jdk1.8.0_77.*a1.*' | ambari-sudo.sh  -H -E tee 
/var/run/flume/a1.pid  && test ${PIPESTATUS[0]} -eq 0'] {'logoutput': True, 
'tries': 20, 'try_sleep': 10}
2016-12-12 03:47:12,667 - Retrying after 10 seconds. Reason: Execution of 
'ambari-sudo.sh  -H -E pgrep -o -u cstm-flume -f 
'^/usr/jdk64/jdk1.8.0_77.*a1.*' | ambari-sudo.sh  -H -E tee 
/var/run/flume/a1.pid  && test ${PIPESTATUS[0]} -eq 0' returned 1. 
2016-12-12 03:47:22,706 - Retrying after 10 seconds. Reason: Execution of 
'ambari-sudo.sh  -H -E pgrep -o -u cstm-flume -f 
'^/usr/jdk64/jdk1.8.0_77.*a1.*' | ambari-sudo.sh  -H -E tee 
/var/run/flume/a1.pid  && test ${PIPESTATUS[0]} -eq 0' returned 1. 
2016-12-12 03:49:23,237 - Retrying after 10 seconds. Reason: Execution of 
'ambari-sudo.sh  -H -E pgrep -o -u cstm-flume -f 
'^/usr/jdk64/jdk1.8.0_77.*a1.*' | ambari-sudo.sh  -H -E tee 
/var/run/flume/a1.pid  && test ${PIPESTATUS[0]} -eq 0' returned 1. 
2016-12-12 03:49:33,277 - Retrying after 10 seconds. Reason: Execution of 
'ambari-sudo.sh  -H -E pgrep -o -u cstm-flume -f 
'^/usr/jdk64/jdk1.8.0_77.*a1.*' | ambari-sudo.sh  -H -E tee 
/var/run/flume/a1.pid  && test ${PIPESTATUS[0]} -eq 0' returned 1. 
2016-12-12 03:49:43,318 - Retrying after 10 seconds. Reason: Execution of 
'ambari-sudo.sh  -H -E pgrep -o -u cstm-flume -f 
'^/usr/jdk64/jdk1.8.0_77.*a1.*' | ambari-sudo.sh  -H -E tee 
/var/run/flume/a1.pid  && test ${PIPESTATUS[0]} -eq 0' returned 1. 
2016-12-12 03:49:53,366 - Retrying after 10 seconds. Reason: Execution of 
'ambari-sudo.sh  -H -E pgrep -o -u cstm-flume -f 
'^/usr/jdk64/jdk1.8.0_77.*a1.*' | ambari-sudo.sh  -H -E tee 
/var/run/flume/a1.pid  && test ${PIPESTATUS[0]} -eq 0' returned 1. 
2016-12-12 03:50:03,401 - Retrying after 10 seconds. Reason: Execution of 
'ambari-sudo.sh  -H -E pgrep -o -u cstm-flume -f 
'^/usr/jdk64/jdk1.8.0_77.*a1.*' | ambari-sudo.sh  -H -E tee 
/var/run/flume/a1.pid  && test ${PIPESTATUS[0]} -eq 0' returned 1. 
2016-12-12 03:50:13,449 - Retrying after 10 seconds. Reason: Execution of 
'ambari-sudo.sh  -H -E pgrep -o -u cstm-flume -f 
'^/usr/jdk64/jdk1.8.0_77.*a1.*' | ambari-sudo.sh  -H -E tee 
/var/run/flume/a1.pid  && test ${PIPESTATUS[0]} -eq 0' returned 1. 
2016-12-12 03:50:23,498 - Execute['find /grid/0/log/flume -maxdepth 1 -type f 
-name '*' -exec echo '==> {} <==' \; -exec tail -n 40 {} \;'] {'logoutput': 
True, 'ignore_failures': True, 'user': None}
==> /grid/0/log/flume/a1.out <==
tail: cannot open `/grid/0/log/flume/a1.out' for reading: Permission denied
==> /grid/0/log/flume/flume-a1.log <==
tail: cannot open `/grid/0/log/flume/flume-a1.log' for reading: Permission 
denied
==> /grid/0/log/flume/a2.out <==
tail: cannot open `/grid/0/log/flume/a2.out' for reading: Permission denied
==> /grid/0/log/flume/flume-a2.log <==
tail: cannot open `/grid/0/log/flume/flume-a2.log' for reading: Permission 
denied

Command failed after 1 tries


Diffs
-

  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
 e1d1874 

Diff: https://reviews.apache.org/r/57042/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56987/
---

(Updated Feb. 24, 2017, 4:25 p.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, and Sandor Magyari.


Bugs: AMBARI-19929
https://issues.apache.org/jira/browse/AMBARI-19929


Repository: ambari


Description
---

Move the persisting of 
TopologyRequest/TopologyLogicalRequest/TopologyHostRequest records into a 
single transaction to esnure consistency accross these records.


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
9ef32b5 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 ab56844 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 a26624e 

Diff: https://reviews.apache.org/r/56987/diff/


Testing
---

Performed manual testing covering cluster creation using Blueprint and than 
cluster upscaling.

Unit tests: Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39


Thanks,

Sebastian Toader

Re: Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56987/#review166712
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 (line 473)


Does each retry really need a new request ID, or should they have a common 
one?



ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 (line 880)


typo: "Registraion"


- Attila Doroszlai


On Feb. 23, 2017, 5:39 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56987/
> ---
> 
> (Updated Feb. 23, 2017, 5:39 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-19929
> https://issues.apache.org/jira/browse/AMBARI-19929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move the persisting of 
> TopologyRequest/TopologyLogicalRequest/TopologyHostRequest records into a 
> single transaction to esnure consistency accross these records.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 9ef32b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  ab56844 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  a26624e 
> 
> Diff: https://reviews.apache.org/r/56987/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing covering cluster creation using Blueprint and than 
> cluster upscaling.
> 
> Unit tests: Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57035/#review166713
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 24, 2017, 2:47 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57035/
> ---
> 
> (Updated Feb. 24, 2017, 2:47 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20170
> https://issues.apache.org/jira/browse/AMBARI-20170
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excluded the aws bundled jar from transitive dependency of hadoop-aws and 
> included explicitly only in files view
> 
> 
> Diffs
> -
> 
>   contrib/views/files/pom.xml 410ed1e 
>   contrib/views/pom.xml dda956f 
>   contrib/views/utils/pom.xml 324fb1a 
> 
> Diff: https://reviews.apache.org/r/57035/diff/
> 
> 
> Testing
> ---
> 
> created build and tested the files sizes. The overall decrease in size would 
> be 300 MB.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57019: HiveView2.0: No notifications for successful query which yields no output.

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57019/
---

(Updated Feb. 24, 2017, 2:54 p.m.)


Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20162
https://issues.apache.org/jira/browse/AMBARI-20162


Repository: ambari


Description
---

- Added successful message for query
- Clean up visual explain code.
- Fix intermittent results null issue.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
16103b7 
  
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js
 ff3832d 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 273cd90 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs 
c7e30f2 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs
 d859b04 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs
 9bf2b2a 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs
 5b7e566 

Diff: https://reviews.apache.org/r/57019/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57035/
---

(Updated Feb. 24, 2017, 2:47 p.m.)


Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

changed jar from dependencyManagement to dependencies.


Bugs: AMBARI-20170
https://issues.apache.org/jira/browse/AMBARI-20170


Repository: ambari


Description
---

excluded the aws bundled jar from transitive dependency of hadoop-aws and 
included explicitly only in files view


Diffs (updated)
-

  contrib/views/files/pom.xml 410ed1e 
  contrib/views/pom.xml dda956f 
  contrib/views/utils/pom.xml 324fb1a 

Diff: https://reviews.apache.org/r/57035/diff/


Testing
---

created build and tested the files sizes. The overall decrease in size would be 
300 MB.


Thanks,

Nitiraj Rathore

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/#review166710
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 24, 2017, 3:19 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57039/
> ---
> 
> (Updated Feb. 24, 2017, 3:19 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20145
> https://issues.apache.org/jira/browse/AMBARI-20145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
> plugin is enabled (plugin exists as of HDP 2.3)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
> e1e6461 
> 
> Diff: https://reviews.apache.org/r/57039/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the fix.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 57041: DB selected is not persisted while switching between tabs, SavedQuery tab does not show preview, if the query is not executed before saving

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57041/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20173
https://issues.apache.org/jira/browse/AMBARI-20173


Repository: ambari


Description
---

1.Create an worksheet and select a database called "Default".
2.Create another worksheet and select another database "Sample".
3.Switch between the worksheets and the database selection will not be 
persisted across the worksheets
SavedQuery tab does not show preview, if the query is not executed before 
saving:
If the query is not executed before saving, preview is not being shown.


Diffs
-

  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java
 ef497ce 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
16103b7 
  contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 7b18424 
  contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 
80a19f3 

Diff: https://reviews.apache.org/r/57041/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 57038: Atlas client install fails with blueprint

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57038/#review166709
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 24, 2017, 4:13 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57038/
> ---
> 
> (Updated Feb. 24, 2017, 4:13 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20174
> https://issues.apache.org/jira/browse/AMBARI-20174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> self.configure(env)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 116, in locking_configure
> original_configure(obj, *args, **kw)
>   File 
> "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py",
>  line 49, in configure
> import params
>   File 
> "/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py",
>  line 264, in 
> kafka_kerberos_enabled = (('security.inter.broker.protocol' in 
> config['configurations']['kafka-broker']) and
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
>  line 73, in __getattr__
> raise Fail("Configuration parameter '" + self.name + "' was not found 
> in configurations dictionary!")
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'kafka-broker' was not found in configurations dictionary!
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
> 9fe8507 
> 
> Diff: https://reviews.apache.org/r/57038/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/#review166707
---


Ship it!




Ship It!

- Attila Magyar


On Feb. 24, 2017, 2:19 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57039/
> ---
> 
> (Updated Feb. 24, 2017, 2:19 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20145
> https://issues.apache.org/jira/browse/AMBARI-20145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
> plugin is enabled (plugin exists as of HDP 2.3)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
> e1e6461 
> 
> Diff: https://reviews.apache.org/r/57039/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the fix.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/
---

Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-20175
https://issues.apache.org/jira/browse/AMBARI-20175


Repository: ambari


Description
---

The rebalancing operation may take a long time (hours, days) thus when issued 
from the ambari UI the background operation may time out.
As it's not possible to dynamically predict how long the rebalancing will last 
, the approach taken by this solution is to only trigger the operation and not 
wait to the operation to finish.

(NOTE: after this change the progress of the rebalance operation won't be 
tracked anymore in the background operation; also the user won't be notified 
about the success/failure of the operation)


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 123486e 

Diff: https://reviews.apache.org/r/57040/diff/


Testing
---

Manually.
Unit tests running.


Thanks,

Laszlo Puskas

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/#review166706
---


Ship it!




Ship It!

- Sandor Magyari


On Feb. 24, 2017, 2:19 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57039/
> ---
> 
> (Updated Feb. 24, 2017, 2:19 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20145
> https://issues.apache.org/jira/browse/AMBARI-20145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
> plugin is enabled (plugin exists as of HDP 2.3)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
> e1e6461 
> 
> Diff: https://reviews.apache.org/r/57039/diff/
> 
> 
> Testing
> ---
> 
> Manually tested the fix.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57039/
---

Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert 
Levas, and Sebastian Toader.


Bugs: AMBARI-20145
https://issues.apache.org/jira/browse/AMBARI-20145


Repository: ambari


Description
---

Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka 
plugin is enabled (plugin exists as of HDP 2.3)


Diffs
-

  ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
2b1c01b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json 
e1e6461 

Diff: https://reviews.apache.org/r/57039/diff/


Testing
---

Manually tested the fix.


Thanks,

Balázs Bence Sári

Review Request 57038: Atlas client install fails with blueprint

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57038/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-20174
https://issues.apache.org/jira/browse/AMBARI-20174


Repository: ambari


Description
---

self.configure(env)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 116, in locking_configure
original_configure(obj, *args, **kw)
  File 
"/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py",
 line 49, in configure
import params
  File 
"/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py",
 line 264, in 
kafka_kerberos_enabled = (('security.inter.broker.protocol' in 
config['configurations']['kafka-broker']) and
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
 line 73, in __getattr__
raise Fail("Configuration parameter '" + self.name + "' was not found 
in configurations dictionary!")
resource_management.core.exceptions.Fail: Configuration parameter 
'kafka-broker' was not found in configurations dictionary!


Diffs
-

  ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
9fe8507 

Diff: https://reviews.apache.org/r/57038/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 57033: Hive 2: Compact Visual Explain Plan is not loading in firefox

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57033/#review166705
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 24, 2017, 11:17 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57033/
> ---
> 
> (Updated Feb. 24, 2017, 11:17 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20168
> https://issues.apache.org/jira/browse/AMBARI-20168
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a new function for handling firefox browser
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs
>  db1cea2 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs
>  370e3ef 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs
>  ef441b5 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  5dbeb2b 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  5fa5d2e 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  70647a8 
> 
> Diff: https://reviews.apache.org/r/57033/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56987/#review166704
---


Ship it!




Ship It!

- Sandor Magyari


On Feb. 23, 2017, 4:39 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56987/
> ---
> 
> (Updated Feb. 23, 2017, 4:39 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-19929
> https://issues.apache.org/jira/browse/AMBARI-19929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move the persisting of 
> TopologyRequest/TopologyLogicalRequest/TopologyHostRequest records into a 
> single transaction to esnure consistency accross these records.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 9ef32b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  ab56844 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  a26624e 
> 
> Diff: https://reviews.apache.org/r/56987/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing covering cluster creation using Blueprint and than 
> cluster upscaling.
> 
> Unit tests: Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 57037: Manage Configuration Group Hosts popup is way too small to be useful when it is needed

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57037/#review166703
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Feb. 24, 2017, 1:49 p.m., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57037/
> ---
> 
> (Updated Feb. 24, 2017, 1:49 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-20172
> https://issues.apache.org/jira/browse/AMBARI-20172
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Configuration Group Hosts popup is really small and showed only 6 hosts 
> at a time.
> There's a filter to show 100 hosts per page, but even with that page size, a 
> max of 6 hosts are shown without having to scroll.
> The popup is unnecessarily small.  We should make it occupy maximum vertical 
> space, just like we do elsewhere.
> This is a major usability issue with a trivial fix.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> ea649b8 
>   ambari-web/app/styles/modal_popups.less e269791 
>   ambari-web/app/utils/hosts.js 3896325 
> 
> Diff: https://reviews.apache.org/r/57037/diff/
> 
> 
> Testing
> ---
> 
> 20490 passing (19s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Oliver Szabo]

> On Feb. 24, 2017, 1:25 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json, 
> > line 109
> > 
> >
> > Make sure the user-defined (artifacts/kerberos_descriptor) is updated 
> > and any configuration changes are performed using the appropriate 
> > UpgradeCatalog class.
> 
> Robert Levas wrote:
> For example see 
> `org.apache.ambari.server.upgrade.UpgradeCatalog240#updateKerberosDescriptorArtifact`

thanks, somehow we should check as well which HDP is used, because these 
kerberos descriptor updates only needed if a specific HDP is installed


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review166699
---


On Feb. 23, 2017, 8:49 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 23, 2017, 8:49 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 57037: Manage Configuration Group Hosts popup is way too small to be useful when it is needed

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57037/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-20172
https://issues.apache.org/jira/browse/AMBARI-20172


Repository: ambari


Description
---

The Configuration Group Hosts popup is really small and showed only 6 hosts at 
a time.
There's a filter to show 100 hosts per page, but even with that page size, a 
max of 6 hosts are shown without having to scroll.
The popup is unnecessarily small.  We should make it occupy maximum vertical 
space, just like we do elsewhere.
This is a major usability issue with a trivial fix.


Diffs
-

  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
ea649b8 
  ambari-web/app/styles/modal_popups.less e269791 
  ambari-web/app/utils/hosts.js 3896325 

Diff: https://reviews.apache.org/r/57037/diff/


Testing
---

20490 passing (19s)
  153 pending


Thanks,

Andriy Babiichuk

Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57035/#review166696
---


Fix it, then Ship it!





contrib/views/files/pom.xml (line 30)


`` is useful only if there are child POMs inheriting 
from this one.  In other cases it's better to merge with `` below.


- Attila Doroszlai


On Feb. 24, 2017, 1:06 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57035/
> ---
> 
> (Updated Feb. 24, 2017, 1:06 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20170
> https://issues.apache.org/jira/browse/AMBARI-20170
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excluded the aws bundled jar from transitive dependency of hadoop-aws and 
> included explicitly only in files view
> 
> 
> Diffs
> -
> 
>   contrib/views/files/pom.xml 410ed1e 
>   contrib/views/pom.xml dda956f 
>   contrib/views/utils/pom.xml 324fb1a 
> 
> Diff: https://reviews.apache.org/r/57035/diff/
> 
> 
> Testing
> ---
> 
> created build and tested the files sizes. The overall decrease in size would 
> be 300 MB.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Robert Levas]

> On Feb. 24, 2017, 8:25 a.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json, 
> > line 109
> > 
> >
> > Make sure the user-defined (artifacts/kerberos_descriptor) is updated 
> > and any configuration changes are performed using the appropriate 
> > UpgradeCatalog class.

For example see 
`org.apache.ambari.server.upgrade.UpgradeCatalog240#updateKerberosDescriptorArtifact`


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review166699
---


On Feb. 23, 2017, 3:49 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 23, 2017, 3:49 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review166699
---




ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
(line 109)


Make sure the user-defined (artifacts/kerberos_descriptor) is updated and 
any configuration changes are performed using the appropriate UpgradeCatalog 
class.


- Robert Levas


On Feb. 23, 2017, 3:49 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 23, 2017, 3:49 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Robert Levas]

> On Feb. 24, 2017, 4:40 a.m., Mugdha Varadkar wrote:
> > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json, 
> > line 109
> > 
> >
> > Will this property be updated after ambari upgrade to use 
> > storm_components principal ?
> 
> Oliver Szabo wrote:
> as in other examples, keytabs should be regenerated after upgrade
> 
> Oliver Szabo wrote:
> also these kerberos metadta will change anyway after ambari restart. as 
> storm used its own user in the past, that means we do not really need to do 
> anything in the future. (of course regenerate keytabs could not harm...that 
> will be a manual post ambari upgrade step in 2.5)

After an Ambari upgrade, the user-defined Kerberos Descriptor will not 
automatically be updated.  Currnetly when the UI is used to enabled Kerberos, 
the entire Kerberos Descriptor is stored as the user-defined value.  This value 
will need to be updated.  If a user-defined Kerberos Descriptor was set a 
different way, it is possible that only the user changes were posted.  In 
anycase, updating the the user-defined Kerberos Descriptor will need to be done 
in the appropriate UpgradeCatalog class.  Nice call @Mugdha. 

Also, after an Ambari upgrade, new principals or keytab files are not created. 
And associated configurations are not created or updated.  The configuration 
updates will need to be done via the approprate UpgradeCatalog and the new 
principals and keytab files will need to be created using Ambari's Regenerate 
Keytabs facility. 

If this were to be done as part of an stack upgrade, the Kerberos Descriptor 
would be automatcially updated.  Any config changes would need to be done via 
the upgrade pack. Missing principals and keytab files need to be created via 
Ambari's Regenerate Keytabs facility - however this will hopefully change in 
the near future.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review15
---


On Feb. 23, 2017, 3:49 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 23, 2017, 3:49 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review166697
---


Ship it!




Ship It!

- Mugdha Varadkar


On Feb. 23, 2017, 8:49 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 23, 2017, 8:49 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review166695
---


Ship it!




Ship It!

- Robert Levas


On Feb. 23, 2017, 3:49 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 23, 2017, 3:49 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 57026: Cover NameNode HA wizard with unit tests

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57026/#review166694
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Фев. 24, 2017, 10:05 д.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57026/
> ---
> 
> (Updated Фев. 24, 2017, 10:05 д.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20165
> https://issues.apache.org/jira/browse/AMBARI-20165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cover NameNode HA wizard with unit tests
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/test/tests.js 05c1657 
>   
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step2_controller.js
>  435fe0f 
>   
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js
>  0a46af7 
>   
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step4_controller.js
>  c0f688e 
>   
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js
>  7b20439 
>   
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step6_controller.js
>  0ef3048 
>   
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js
>  b98c2df 
>   
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step1_controller_test.js
>  PRE-CREATION 
>   
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step2_controller_test.js
>  570f45a 
>   
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js
>  98d71da 
>   
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step4_controller_test.js
>  d5ab8d2 
>   
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step5_controller_test.js
>  PRE-CREATION 
>   
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step6_controller_test.js
>  PRE-CREATION 
>   
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step7_controller_test.js
>  PRE-CREATION 
>   
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step8_controller_test.js
>  PRE-CREATION 
>   
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step9_controller_test.js
>  PRE-CREATION 
>   
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/wizard_controller_test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57026/diff/
> 
> 
> Testing
> ---
> 
> 20490 passing (33s)
> 153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 57033: Hive 2: Compact Visual Explain Plan is not loading in firefox

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57033/#review166690
---


Ship it!




Ship It!

- venkat sairam


On Feb. 24, 2017, 11:17 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57033/
> ---
> 
> (Updated Feb. 24, 2017, 11:17 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20168
> https://issues.apache.org/jira/browse/AMBARI-20168
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a new function for handling firefox browser
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs
>  db1cea2 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs
>  370e3ef 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs
>  ef441b5 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  5dbeb2b 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  5fa5d2e 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  70647a8 
> 
> Diff: https://reviews.apache.org/r/57033/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 57033: Hive 2: Compact Visual Explain Plan is not loading in firefox

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57033/#review166691
---


Ship it!




Ship It!

- venkat sairam


On Feb. 24, 2017, 11:17 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57033/
> ---
> 
> (Updated Feb. 24, 2017, 11:17 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20168
> https://issues.apache.org/jira/browse/AMBARI-20168
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a new function for handling firefox browser
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs
>  db1cea2 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs
>  370e3ef 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs
>  ef441b5 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  5dbeb2b 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  5fa5d2e 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  70647a8 
> 
> Diff: https://reviews.apache.org/r/57033/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 57036: Hive View 2.0: Service checks stopped working.

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57036/#review166688
---


Ship it!




Ship It!

- venkat sairam


On Feb. 24, 2017, 12:07 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57036/
> ---
> 
> (Updated Feb. 24, 2017, 12:07 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20171
> https://issues.apache.org/jira/browse/AMBARI-20171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> change the value to true to make it work.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/config/environment.js c891508 
> 
> Diff: https://reviews.apache.org/r/57036/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57035/#review166687
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 24, 2017, 12:06 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57035/
> ---
> 
> (Updated Feb. 24, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20170
> https://issues.apache.org/jira/browse/AMBARI-20170
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excluded the aws bundled jar from transitive dependency of hadoop-aws and 
> included explicitly only in files view
> 
> 
> Diffs
> -
> 
>   contrib/views/files/pom.xml 410ed1e 
>   contrib/views/pom.xml dda956f 
>   contrib/views/utils/pom.xml 324fb1a 
> 
> Diff: https://reviews.apache.org/r/57035/diff/
> 
> 
> Testing
> ---
> 
> created build and tested the files sizes. The overall decrease in size would 
> be 300 MB.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57036: Hive View 2.0: Service checks stopped working.

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57036/#review166686
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 24, 2017, 12:07 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57036/
> ---
> 
> (Updated Feb. 24, 2017, 12:07 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20171
> https://issues.apache.org/jira/browse/AMBARI-20171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> change the value to true to make it work.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/config/environment.js c891508 
> 
> Diff: https://reviews.apache.org/r/57036/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 57036: Hive View 2.0: Service checks stopped working.

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57036/
---

Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20171
https://issues.apache.org/jira/browse/AMBARI-20171


Repository: ambari


Description
---

change the value to true to make it work.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/config/environment.js c891508 

Diff: https://reviews.apache.org/r/57036/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 57035: ambari-server package size increased from 645MB to 1GB

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57035/
---

Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20170
https://issues.apache.org/jira/browse/AMBARI-20170


Repository: ambari


Description
---

excluded the aws bundled jar from transitive dependency of hadoop-aws and 
included explicitly only in files view


Diffs
-

  contrib/views/files/pom.xml 410ed1e 
  contrib/views/pom.xml dda956f 
  contrib/views/utils/pom.xml 324fb1a 

Diff: https://reviews.apache.org/r/57035/diff/


Testing
---

created build and tested the files sizes. The overall decrease in size would be 
300 MB.


Thanks,

Nitiraj Rathore

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Oliver Szabo]

> On Feb. 24, 2017, 9:40 a.m., Mugdha Varadkar wrote:
> > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json, 
> > line 109
> > 
> >
> > Will this property be updated after ambari upgrade to use 
> > storm_components principal ?
> 
> Oliver Szabo wrote:
> as in other examples, keytabs should be regenerated after upgrade

also these kerberos metadta will change anyway after ambari restart. as storm 
used its own user in the past, that means we do not really need to do anything 
in the future. (of course regenerate keytabs could not harm...that will be a 
manual post ambari upgrade step in 2.5)


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review15
---


On Feb. 23, 2017, 8:49 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 23, 2017, 8:49 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 57019: HiveView2.0: No notifications for successful query which yields no output.

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57019/#review166684
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 24, 2017, 7:35 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57019/
> ---
> 
> (Updated Feb. 24, 2017, 7:35 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20162
> https://issues.apache.org/jira/browse/AMBARI-20162
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added successful message for query
> - Clean up visual explain code.
> - Fix intermittent results null issue.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 16103b7 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/visual-explain.js
>  ff3832d 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 273cd90 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs
>  db1cea2 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs
>  370e3ef 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs
>  9bf2b2a 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs
>  ef441b5 
> 
> Diff: https://reviews.apache.org/r/57019/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Oliver Szabo]

> On Feb. 24, 2017, 9:40 a.m., Mugdha Varadkar wrote:
> > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json, 
> > line 109
> > 
> >
> > Will this property be updated after ambari upgrade to use 
> > storm_components principal ?

as in other examples, keytabs should be regenerated after upgrade


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review15
---


On Feb. 23, 2017, 8:49 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 23, 2017, 8:49 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 57034: Handle on UI error on services API while trying to start all services with atleast one component in INSTALL_FAILED state

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57034/#review166682
---


Ship it!




Ship It!

- Andrii Tkach


On Feb. 24, 2017, 11:31 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57034/
> ---
> 
> (Updated Feb. 24, 2017, 11:31 a.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: ambari-20169
> https://issues.apache.org/jira/browse/ambari-20169
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Handle on UI error on services API while trying to start all services with 
> atleast one component in INSTALL_FAILED state
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step8_controller.js 3e659b9 
>   ambari-web/app/controllers/main/service.js e434d41 
>   ambari-web/app/mixins/wizard/wizardProgressPageController.js 96eb0ae 
>   ambari-web/test/controllers/main/admin/kerberos/step8_controller_test.js 
> 50a705d 
> 
> Diff: https://reviews.apache.org/r/57034/diff/
> 
> 
> Testing
> ---
> 
> 20423 passing (24s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 57034: Handle on UI error on services API while trying to start all services with atleast one component in INSTALL_FAILED state

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57034/
---

Review request for Ambari and Andrii Tkach.


Bugs: ambari-20169
https://issues.apache.org/jira/browse/ambari-20169


Repository: ambari


Description
---

Handle on UI error on services API while trying to start all services with 
atleast one component in INSTALL_FAILED state


Diffs
-

  ambari-web/app/controllers/main/admin/kerberos/step8_controller.js 3e659b9 
  ambari-web/app/controllers/main/service.js e434d41 
  ambari-web/app/mixins/wizard/wizardProgressPageController.js 96eb0ae 
  ambari-web/test/controllers/main/admin/kerberos/step8_controller_test.js 
50a705d 

Diff: https://reviews.apache.org/r/57034/diff/


Testing
---

20423 passing (24s)
  153 pending


Thanks,

Oleg Nechiporenko

Review Request 57033: Hive 2: Compact Visual Explain Plan is not loading in firefox

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57033/
---

Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20168
https://issues.apache.org/jira/browse/AMBARI-20168


Repository: ambari


Description
---

Added a new function for handling firefox browser


Diffs
-

  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs 
db1cea2 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs
 370e3ef 
  
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs
 ef441b5 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
 5dbeb2b 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
5fa5d2e 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
 70647a8 

Diff: https://reviews.apache.org/r/57033/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 56994: "Set Version on All Hosts" Fails For Hosts Without Any Stack Components

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56994/#review166678
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 23, 2017, 10:04 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56994/
> ---
> 
> (Updated Feb. 23, 2017, 10:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-20148
> https://issues.apache.org/jira/browse/AMBARI-20148
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During an upgrade, `hdp-select set all ` is sent to all hosts, even 
> those which do not have any versionable components (metrics only, for 
> example). This is done for two reason:
> - Simplicity - we don't need to figure out which hosts to include
> - Coverage - many clusters have clients not under our control, so invoking it 
> on all hosts covers our bases
> 
> We need to ensure that if the stack-select tool doesn't exist or reports no 
> versions, that we skip calling it.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> b7fcc51 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py b018605 
> 
> Diff: https://reviews.apache.org/r/56994/diff/
> 
> 
> Testing
> ---
> 
> --
> Total run:1185
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.155 s
> [INFO] Finished at: 2017-02-23T14:49:03-05:00
> [INFO] Final Memory: 18M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 57027: AMBARI-20142. Job Link URL not working

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57027/#review166677
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 24, 2017, 10:09 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57027/
> ---
> 
> (Updated Feb. 24, 2017, 10:09 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20142
> https://issues.apache.org/jira/browse/AMBARI-20142
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Showing the Job Url link if it starts with http
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-action.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js
>  7a868fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action.hbs
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
>  b5565c8 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> 309c281 
>   
> contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-action-test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57027/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 57029: AMBARI-20167. importing from workflow from the coordinator setup hangs

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57029/#review166676
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 24, 2017, 10:19 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57029/
> ---
> 
> (Updated Feb. 24, 2017, 10:19 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20167
> https://issues.apache.org/jira/browse/AMBARI-20167
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validating the path before import. Disabling the import if path has variables.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 4a57e37 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  7db5ce2 
> 
> Diff: https://reviews.apache.org/r/57029/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 57028: AMBARI-20166.Workflow Manager. Nominal time should accept variables.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57028/#review166675
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 24, 2017, 10:18 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57028/
> ---
> 
> (Updated Feb. 24, 2017, 10:18 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20166
> https://issues.apache.org/jira/browse/AMBARI-20166
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by using existing date-with-expr component for nominal time instead of 
> date field.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js 
> bcc209b 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 
> 153b538 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js 
> 9d90280 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
>  2ebc259 
> 
> Diff: https://reviews.apache.org/r/57028/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 57025: AMBARI-20164.Kill a workflow jumps to another tab in WFM

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57025/#review166674
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 24, 2017, 9:34 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57025/
> ---
> 
> (Updated Feb. 24, 2017, 9:34 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20164
> https://issues.apache.org/jira/browse/AMBARI-20164
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by handling and updating the affected jobs rather than refreshing the 
> route when bulk action is complete.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 
> 2b40392 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 
> c8df452 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> 691cc26 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
>  d28a497 
> 
> Diff: https://reviews.apache.org/r/57025/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 57024: AMBARI-20161.Workflow Manager-mapred action contains duplicates in editor if user saves and reopens editor

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57024/#review166673
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 24, 2017, 9:18 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57024/
> ---
> 
> (Updated Feb. 24, 2017, 9:18 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20161
> https://issues.apache.org/jira/browse/AMBARI-20161
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by removing duplicate values in the properties array.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> de72c6d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/map-red-action.js
>  3eb8545 
> 
> Diff: https://reviews.apache.org/r/57024/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 57029: AMBARI-20167. importing from workflow from the coordinator setup hangs

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57029/#review166671
---


Ship it!




Ship It!

- belliraj hb


On Feb. 24, 2017, 10:19 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57029/
> ---
> 
> (Updated Feb. 24, 2017, 10:19 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20167
> https://issues.apache.org/jira/browse/AMBARI-20167
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validating the path before import. Disabling the import if path has variables.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 4a57e37 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  7db5ce2 
> 
> Diff: https://reviews.apache.org/r/57029/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 57029: AMBARI-20167. importing from workflow from the coordinator setup hangs

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57029/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20167
https://issues.apache.org/jira/browse/AMBARI-20167


Repository: ambari


Description
---

Validating the path before import. Disabling the import if path has variables.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
4a57e37 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
 7db5ce2 

Diff: https://reviews.apache.org/r/57029/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Review Request 57028: AMBARI-20166.Workflow Manager. Nominal time should accept variables.

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57028/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20166
https://issues.apache.org/jira/browse/AMBARI-20166


Repository: ambari


Description
---

Fixed by using existing date-with-expr component for nominal time instead of 
date field.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js 
bcc209b 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 
153b538 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js 9d90280 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
 2ebc259 

Diff: https://reviews.apache.org/r/57028/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 57027: AMBARI-20142. Job Link URL not working

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57027/#review18
---


Ship it!




Ship It!

- belliraj hb


On Feb. 24, 2017, 10:09 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57027/
> ---
> 
> (Updated Feb. 24, 2017, 10:09 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20142
> https://issues.apache.org/jira/browse/AMBARI-20142
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Showing the Job Url link if it starts with http
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-action.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js
>  7a868fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action.hbs
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
>  b5565c8 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> 309c281 
>   
> contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-action-test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57027/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 57027: AMBARI-20142. Job Link URL not working

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57027/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20142
https://issues.apache.org/jira/browse/AMBARI-20142


Repository: ambari


Description
---

Showing the Job Url link if it starts with http


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-action.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js
 7a868fa 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action.hbs
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
 b5565c8 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
309c281 
  
contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-action-test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/57027/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Review Request 57026: Cover NameNode HA wizard with unit tests

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57026/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20165
https://issues.apache.org/jira/browse/AMBARI-20165


Repository: ambari


Description
---

Cover NameNode HA wizard with unit tests


Diffs
-

  ambari-web/app/assets/test/tests.js 05c1657 
  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step2_controller.js
 435fe0f 
  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js
 0a46af7 
  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step4_controller.js
 c0f688e 
  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js
 7b20439 
  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step6_controller.js
 0ef3048 
  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js
 b98c2df 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step1_controller_test.js
 PRE-CREATION 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step2_controller_test.js
 570f45a 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js
 98d71da 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step4_controller_test.js
 d5ab8d2 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step5_controller_test.js
 PRE-CREATION 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step6_controller_test.js
 PRE-CREATION 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step7_controller_test.js
 PRE-CREATION 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step8_controller_test.js
 PRE-CREATION 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step9_controller_test.js
 PRE-CREATION 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/wizard_controller_test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/57026/diff/


Testing
---

20490 passing (33s)
153 pending


Thanks,

Andrii Tkach

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review15
---




ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
(line 109)


Will this property be updated after ambari upgrade to use storm_components 
principal ?


- Mugdha Varadkar


On Feb. 23, 2017, 8:49 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56997/
> ---
> 
> (Updated Feb. 23, 2017, 8:49 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-20152
> https://issues.apache.org/jira/browse/AMBARI-20152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use storm principal and keytab for ranger plugin instead of nimbus ones.
> In storm code, storm user will be used globally anyway, ranger plugin will 
> use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr 
> authorization is supported, that can cause if storm is authenticated with the 
> worng user, it wont be able to access the ranger audit collection.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> fecef7c 
> 
> Diff: https://reviews.apache.org/r/56997/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 57025: AMBARI-20164.Kill a workflow jumps to another tab in WFM

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57025/#review14
---


Ship it!




Ship It!

- belliraj hb


On Feb. 24, 2017, 9:34 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57025/
> ---
> 
> (Updated Feb. 24, 2017, 9:34 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20164
> https://issues.apache.org/jira/browse/AMBARI-20164
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by handling and updating the affected jobs rather than refreshing the 
> route when bulk action is complete.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 
> 2b40392 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 
> c8df452 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> 691cc26 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
>  d28a497 
> 
> Diff: https://reviews.apache.org/r/57025/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Review Request 57025: AMBARI-20164.Kill a workflow jumps to another tab in WFM

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57025/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20164
https://issues.apache.org/jira/browse/AMBARI-20164


Repository: ambari


Description
---

Fixed by handling and updating the affected jobs rather than refreshing the 
route when bulk action is complete.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 
2b40392 
  contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 
c8df452 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
691cc26 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
 d28a497 

Diff: https://reviews.apache.org/r/57025/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 57024: AMBARI-20161.Workflow Manager-mapred action contains duplicates in editor if user saves and reopens editor

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57024/#review12
---


Ship it!




Ship It!

- belliraj hb


On Feb. 24, 2017, 9:18 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57024/
> ---
> 
> (Updated Feb. 24, 2017, 9:18 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20161
> https://issues.apache.org/jira/browse/AMBARI-20161
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by removing duplicate values in the properties array.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> de72c6d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/map-red-action.js
>  3eb8545 
> 
> Diff: https://reviews.apache.org/r/57024/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Review Request 57024: AMBARI-20161.Workflow Manager-mapred action contains duplicates in editor if user saves and reopens editor

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57024/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20161
https://issues.apache.org/jira/browse/AMBARI-20161


Repository: ambari


Description
---

Fixed by removing duplicate values in the properties array.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
de72c6d 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/map-red-action.js 
3eb8545 

Diff: https://reviews.apache.org/r/57024/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 57022: After disabling security page is not refreshed

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57022/#review11
---


Ship it!




Ship It!

- Denys Buzhor


On Feb. 24, 2017, 8:45 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57022/
> ---
> 
> (Updated Feb. 24, 2017, 8:45 a.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20163
> https://issues.apache.org/jira/browse/ambari-20163
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When "Disable security popup" is closed, page should be refreshed.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/routes/main.js 9730de2 
> 
> Diff: https://reviews.apache.org/r/57022/diff/
> 
> 
> Testing
> ---
> 
> 20423 passing (24s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 57022: After disabling security page is not refreshed

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57022/
---

Review request for Ambari and Denys Buzhor.


Bugs: ambari-20163
https://issues.apache.org/jira/browse/ambari-20163


Repository: ambari


Description
---

When "Disable security popup" is closed, page should be refreshed.


Diffs
-

  ambari-web/app/routes/main.js 9730de2 

Diff: https://reviews.apache.org/r/57022/diff/


Testing
---

20423 passing (24s)
  153 pending


Thanks,

Oleg Nechiporenko