date:20170310

Re: Review Request 57515: Zeppelin: Spark2 and Livy2 interpreter config disappear during stack upgrade

2017-03-10 Thread Prabhjyot Singh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57515/#review168702
---


Ship it!




Ship It!

- Prabhjyot Singh


On March 10, 2017, 11:17 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57515/
> ---
> 
> (Updated March 10, 2017, 11:17 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20397
> https://issues.apache.org/jira/browse/AMBARI-20397
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During stack upgrade spark2 and livy2 interpreters are not present in 
> zeppelin by default. Typically for a fresh install- when spark2 service is 
> detected , those 2 interpreters are by default created for user out-of-the box
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  a460aecad0 
> 
> 
> Diff: https://reviews.apache.org/r/57515/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested the stack upgrade on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 57523: AMBARI-20403 : Yarn Container metrics are not being collected by AMS

2017-03-10 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57523/#review168697
---


Ship it!




Ship It!

- Sid Wagle


On March 10, 2017, 11:51 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57523/
> ---
> 
> (Updated March 10, 2017, 11:51 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20403
> https://issues.apache.org/jira/browse/AMBARI-20403
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exception in NM logs :
> 
> 
> 2017-03-07 19:14:06,143 INFO  timeline.HadoopTimelineMetricsSink 
> (AbstractTimelineMetricsSink.java:emitMetricsJson(197)) - Unable to connect 
> to collector, null
> This exceptions will be ignored for next 100 times
> 
> 2017-03-07 19:14:06,144 WARN  timeline.HadoopTimelineMetricsSink 
> (HadoopTimelineMetricsSink.java:putMetrics(344)) - Unable to send metrics to 
> collector by address:null
> 
> 
> 0jdbc:phoenix:localhost:2181:/ams-hbase-uns> select * from CONTAINER_METRICS 
> order by START_TIME desc limit 10;
> ++--++-++++---+-+--+---+
> |?? APP_ID?? | CONTAINER_ID | START_TIME | FINISH_TIME 
> |??DURATION??|??HOSTNAME??| EXIT_CODE??| LOCALIZATION_DURATION | 
> LAUNCH_DURATION | MEM_REQUESTED_GB | MEM_REQUESTED_GB_ |
> ++--++-++++---+-+--+---+
> ++--++-++++---+-+--+---+
> No rows selected (0.505 seconds)
> 
> 
> PROBLEM
> The collector URI used for yarn container metrics is initially seeded and not 
> refreshed based on collector availability (HA changes). A couple of other 
> places where the Container metrics URL was wrongly invoked.
> 
> FIX
> Changed container metrics path to use collector host HA changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  a1fd008 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  988f15d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  275ad16 
>   
> ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/TestAmbariMetricsSinkImpl.java
>  36d8fee 
> 
> 
> Diff: https://reviews.apache.org/r/57523/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 5 licence.
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Metrics Common . SUCCESS [7.125s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [5.492s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 12.830s
> [INFO] Finished at: Fri Mar 10 14:42:08 PST 2017
> [INFO] Final Memory: 35M/981M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 57521: HOU wizard wrongly shows hosts with only client components at the start of 'Upgrade Hosts' group

2017-03-10 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57521/
---

(Updated March 10, 2017, 8:29 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, and Robert 
Levas.


Bugs: AMBARI-20401
https://issues.apache.org/jira/browse/AMBARI-20401


Repository: ambari


Description (updated)
---

- Deploy HDP-2.5.3 cluster with Ambari-2.5 (cluster topology is: 2 hosts with 
only masters, 2 hosts with only slaves, 1 host with only clients)
- Issued below call to start Host Ordered Upgrade to HDP-2.5.4 (note that host 
named 'bugbash-cluster-2-2.openstacklocal' - third in the list has only client 
components)

In the HOU wizard in Ambari web UI, when the upgrade reaches 'Upgrade All 
Hosts' group, there is already an entry for 'Stop on 
bugbash-cluster-2-2.openstacklocal'

- There is a bug deep in the ambari orchestration logic which causes a request 
to hang in a {{PENDING}} state if the stage numbers are not directly sequential 
(ie 1, 2, 3 vs 1, 3)
- HOU is exposing this bug by trying to schedule a stage with no tasks (which 
is wrong anyway)

It's way to dangerous to fix the first problem. The 2nd problem is now fixed 
and I'm putting it up for review. Therefore, I think this bug should remain 
scoped for 2.5.0.1 and I can open a new bug for 2.5.1 for the deeper issue. 
Sound good?


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
 7734731 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 62e55c4 


Diff: https://reviews.apache.org/r/57521/diff/1/


Testing (updated)
---

Results :

Tests run: 4943, Failures: 0, Errors: 0, Skipped: 39


Thanks,

Jonathan Hurley

Re: Review Request 57526: Side Nav: several issues tested on IE 11

2017-03-10 Thread Jaimin Jetly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57526/#review168695
---


Ship it!




Ship It!

- Jaimin Jetly


On March 11, 2017, 12:48 a.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57526/
> ---
> 
> (Updated March 11, 2017, 12:48 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20405
> https://issues.apache.org/jira/browse/AMBARI-20405
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> CSS:
> 1. Active item should have a green triangle at left. Now there was no active 
> effect for menu items except for Admin's submenu.
> 2. Hovering on Services, service actions icon is invisible. Cannot trigger 
> any service actions.
> 3. The scrollbar was too prominent, should hide scrollbar on every browser.
> 
> JS:
> 4. Click on Services/Admin menu, no collapse effect. And will go to 
> Service/Admin page.
> 5. Click on "<<" at the footer, no collapse effect. Cannot collapse side navi 
> menu.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/theme/bootstrap-ambari.css 3adcbe9 
>   ambari-web/vendor/scripts/theme/bootstrap-ambari.js c193f7f 
> 
> 
> Diff: https://reviews.apache.org/r/57526/diff/1/
> 
> 
> Testing
> ---
> 
> 20559 passing (27s)
> 153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Re: Review Request 57526: Side Nav: several issues tested on IE 11

2017-03-10 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57526/#review168692
---


Ship it!




Ship It!

- Richard Zang


On March 11, 2017, 12:48 a.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57526/
> ---
> 
> (Updated March 11, 2017, 12:48 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20405
> https://issues.apache.org/jira/browse/AMBARI-20405
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> CSS:
> 1. Active item should have a green triangle at left. Now there was no active 
> effect for menu items except for Admin's submenu.
> 2. Hovering on Services, service actions icon is invisible. Cannot trigger 
> any service actions.
> 3. The scrollbar was too prominent, should hide scrollbar on every browser.
> 
> JS:
> 4. Click on Services/Admin menu, no collapse effect. And will go to 
> Service/Admin page.
> 5. Click on "<<" at the footer, no collapse effect. Cannot collapse side navi 
> menu.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/theme/bootstrap-ambari.css 3adcbe9 
>   ambari-web/vendor/scripts/theme/bootstrap-ambari.js c193f7f 
> 
> 
> Diff: https://reviews.apache.org/r/57526/diff/1/
> 
> 
> Testing
> ---
> 
> 20559 passing (27s)
> 153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Review Request 57526: Side Nav: several issues tested on IE 11

2017-03-10 Thread Xi Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57526/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-20405
https://issues.apache.org/jira/browse/AMBARI-20405


Repository: ambari


Description
---

CSS:
1. Active item should have a green triangle at left. Now there was no active 
effect for menu items except for Admin's submenu.
2. Hovering on Services, service actions icon is invisible. Cannot trigger any 
service actions.
3. The scrollbar was too prominent, should hide scrollbar on every browser.

JS:
4. Click on Services/Admin menu, no collapse effect. And will go to 
Service/Admin page.
5. Click on "<<" at the footer, no collapse effect. Cannot collapse side navi 
menu.


Diffs
-

  ambari-web/app/styles/theme/bootstrap-ambari.css 3adcbe9 
  ambari-web/vendor/scripts/theme/bootstrap-ambari.js c193f7f 


Diff: https://reviews.apache.org/r/57526/diff/1/


Testing
---

20559 passing (27s)
153 pending


Thanks,

Xi Wang

Review Request 57525: Assign Slaves and Clients page displays incorrect configuration unless a change is made in Assign Masters page

2017-03-10 Thread Sangeeta Ravindran


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57525/
---

Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-20402
https://issues.apache.org/jira/browse/AMBARI-20402


Repository: ambari


Description
---

Ambari install wizard seems to give recommendations that are not in line with 
best practices by default. Furthermore, if you make any change to the master 
node assignments and then undo it, the recommended configuration seems to 
change and appears correct. This happens because the initial call to get stack 
advisor recommendations is made before UI elements have been fully populated on 
Assign Masters page. As a result, the recommendations returned do not take into 
account the host configuration. Recommendations are fetched again after UI 
elements are fully rendered, but because there are existing recommendations, 
the AJAX call is not made (this check has been put in to avoid repetitive AJAX 
calls while user moves back and forth between Assign Masters and Assign Slaves 
and Clients page). 

Fix is to add a new flag to track the case where user navigates between Step 5 
and 6. Only for that specific case, we will not make the AJAX call. If any 
configuration changes are made however, recommendations are reset and the AJAX 
call is made again as required.

Build failure is unrelated to the patch. I was able to apply the patch 
successfully to latest 2.5 code and build and test successfully.


Diffs
-

  ambari-web/app/mixins/wizard/assign_master_components.js 60c6eeb 


Diff: https://reviews.apache.org/r/57525/diff/1/


Testing
---

Manual Tests.
Ran mvn clean test


30367 passing (41s)
157 pending


Thanks,

Sangeeta Ravindran

Re: Review Request 57521: HOU wizard wrongly shows hosts with only client components at the start of 'Upgrade Hosts' group

2017-03-10 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57521/#review168687
---


Ship it!




Ship It!

- Robert Levas


On March 10, 2017, 5:09 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57521/
> ---
> 
> (Updated March 10, 2017, 5:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-20401
> https://issues.apache.org/jira/browse/AMBARI-20401
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Deploy HDP-2.5.3 cluster with Ambari-2.5.0.1 (cluster topology is: 2 hosts 
> with only masters, 2 hosts with only slaves, 1 host with only clients)
> - Issued below call to start Host Ordered Upgrade to HDP-2.5.4 (note that 
> host named 'bugbash-cluster-2-2.openstacklocal' - third in the list has only 
> client components)
> 
> In the HOU wizard in Ambari web UI, when the upgrade reaches 'Upgrade All 
> Hosts' group, there is already an entry for 'Stop on 
> bugbash-cluster-2-2.openstacklocal'
> 
> - There is a bug deep in the ambari orchestration logic which causes a 
> request to hang in a {{PENDING}} state if the stage numbers are not directly 
> sequential (ie 1, 2, 3 vs 1, 3)
> - HOU is exposing this bug by trying to schedule a stage with no tasks (which 
> is wrong anyway)
> 
> It's way to dangerous to fix the first problem. The 2nd problem is now fixed 
> and I'm putting it up for review. Therefore, I think this bug should remain 
> scoped for 2.5.0.1 and I can open a new bug for 2.5.1 for the deeper issue. 
> Sound good?
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
>  7734731 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  62e55c4 
> 
> 
> Diff: https://reviews.apache.org/r/57521/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 57523: AMBARI-20403 : Yarn Container metrics are not being collected by AMS

2017-03-10 Thread Aravindan Vijayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57523/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-20403
https://issues.apache.org/jira/browse/AMBARI-20403


Repository: ambari


Description
---

Exception in NM logs :


2017-03-07 19:14:06,143 INFO  timeline.HadoopTimelineMetricsSink 
(AbstractTimelineMetricsSink.java:emitMetricsJson(197)) - Unable to connect to 
collector, null
This exceptions will be ignored for next 100 times

2017-03-07 19:14:06,144 WARN  timeline.HadoopTimelineMetricsSink 
(HadoopTimelineMetricsSink.java:putMetrics(344)) - Unable to send metrics to 
collector by address:null


0jdbc:phoenix:localhost:2181:/ams-hbase-uns> select * from CONTAINER_METRICS 
order by START_TIME desc limit 10;
++--++-++++---+-+--+---+
|?? APP_ID?? | CONTAINER_ID | START_TIME | FINISH_TIME 
|??DURATION??|??HOSTNAME??| EXIT_CODE??| LOCALIZATION_DURATION | 
LAUNCH_DURATION | MEM_REQUESTED_GB | MEM_REQUESTED_GB_ |
++--++-++++---+-+--+---+
++--++-++++---+-+--+---+
No rows selected (0.505 seconds)


PROBLEM
The collector URI used for yarn container metrics is initially seeded and not 
refreshed based on collector availability (HA changes). A couple of other 
places where the Container metrics URL was wrongly invoked.

FIX
Changed container metrics path to use collector host HA changes.


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 a1fd008 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 988f15d 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 275ad16 
  
ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/TestAmbariMetricsSinkImpl.java
 36d8fee 


Diff: https://reviews.apache.org/r/57523/diff/1/


Testing
---

Manually tested.

[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 5 licence.
[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Metrics Common . SUCCESS [7.125s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [5.492s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 12.830s
[INFO] Finished at: Fri Mar 10 14:42:08 PST 2017
[INFO] Final Memory: 35M/981M
[INFO] 


Thanks,

Aravindan Vijayan

Re: Review Request 57521: HOU wizard wrongly shows hosts with only client components at the start of 'Upgrade Hosts' group

2017-03-10 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57521/#review168682
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 10, 2017, 10:09 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57521/
> ---
> 
> (Updated March 10, 2017, 10:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-20401
> https://issues.apache.org/jira/browse/AMBARI-20401
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Deploy HDP-2.5.3 cluster with Ambari-2.5.0.1 (cluster topology is: 2 hosts 
> with only masters, 2 hosts with only slaves, 1 host with only clients)
> - Issued below call to start Host Ordered Upgrade to HDP-2.5.4 (note that 
> host named 'bugbash-cluster-2-2.openstacklocal' - third in the list has only 
> client components)
> 
> In the HOU wizard in Ambari web UI, when the upgrade reaches 'Upgrade All 
> Hosts' group, there is already an entry for 'Stop on 
> bugbash-cluster-2-2.openstacklocal'
> 
> - There is a bug deep in the ambari orchestration logic which causes a 
> request to hang in a {{PENDING}} state if the stage numbers are not directly 
> sequential (ie 1, 2, 3 vs 1, 3)
> - HOU is exposing this bug by trying to schedule a stage with no tasks (which 
> is wrong anyway)
> 
> It's way to dangerous to fix the first problem. The 2nd problem is now fixed 
> and I'm putting it up for review. Therefore, I think this bug should remain 
> scoped for 2.5.0.1 and I can open a new bug for 2.5.1 for the deeper issue. 
> Sound good?
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
>  7734731 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  62e55c4 
> 
> 
> Diff: https://reviews.apache.org/r/57521/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 57521: HOU wizard wrongly shows hosts with only client components at the start of 'Upgrade Hosts' group

2017-03-10 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57521/
---

Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, and Robert 
Levas.


Bugs: AMBARI-20401
https://issues.apache.org/jira/browse/AMBARI-20401


Repository: ambari


Description
---

- Deploy HDP-2.5.3 cluster with Ambari-2.5.0.1 (cluster topology is: 2 hosts 
with only masters, 2 hosts with only slaves, 1 host with only clients)
- Issued below call to start Host Ordered Upgrade to HDP-2.5.4 (note that host 
named 'bugbash-cluster-2-2.openstacklocal' - third in the list has only client 
components)

In the HOU wizard in Ambari web UI, when the upgrade reaches 'Upgrade All 
Hosts' group, there is already an entry for 'Stop on 
bugbash-cluster-2-2.openstacklocal'

- There is a bug deep in the ambari orchestration logic which causes a request 
to hang in a {{PENDING}} state if the stage numbers are not directly sequential 
(ie 1, 2, 3 vs 1, 3)
- HOU is exposing this bug by trying to schedule a stage with no tasks (which 
is wrong anyway)

It's way to dangerous to fix the first problem. The 2nd problem is now fixed 
and I'm putting it up for review. Therefore, I think this bug should remain 
scoped for 2.5.0.1 and I can open a new bug for 2.5.1 for the deeper issue. 
Sound good?


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
 7734731 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 62e55c4 


Diff: https://reviews.apache.org/r/57521/diff/1/


Testing
---

PENDING...


Thanks,

Jonathan Hurley

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Jonathan Hurley



> On March 10, 2017, 10:40 a.m., Jonathan Hurley wrote:
> > Ship It!
> 
> Anita Jebaraj wrote:
> Thank you Jonathan for reviewing, I had to update the patch since there 
> was an unnecessarily check lingering around in the patch, 
> +if(propertiesToHideInResponse != null) { 
> this wont be required now since its assigned to an empty set on the 
> invocation of the method. Can you please check this out and help me in 
> pushing the changes to trunk

Done. Please close this review.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review168626
---


On March 10, 2017, 10:34 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 10, 2017, 10:34 a.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr 
> Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md af962e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  df334c5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  8111a39 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/8/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/#review168672
---


Ship it!




Ship It!

- Jonathan Hurley


On March 10, 2017, 2:59 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57517/
> ---
> 
> (Updated March 10, 2017, 2:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20399
> https://issues.apache.org/jira/browse/AMBARI-20399
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ServiceInfo was not being refreshed on stack upgrade
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
>  b1bffef 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> 70efeb5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> d12a8a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
>  2bfd176 
> 
> 
> Diff: https://reviews.apache.org/r/57517/diff/2/
> 
> 
> Testing
> ---
> 
> Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
> Verified that credential_store_supported = true for Oozie, Hive, Logsearch
> 
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:08 min
> [INFO] Finished at: 2017-03-10T11:56:37-08:00
> [INFO] Final Memory: 66M/1105M
> [INFO] 
> 
> mradhakrishnan$ mvn clean test -Drat.skip=true
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Madhuvanthi Radhakrishnan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/
---

(Updated March 10, 2017, 7:59 p.m.)


Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.


Bugs: AMBARI-20399
https://issues.apache.org/jira/browse/AMBARI-20399


Repository: ambari


Description
---

ServiceInfo was not being refreshed on stack upgrade


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 b1bffef 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
70efeb5 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
d12a8a3 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
 2bfd176 


Diff: https://reviews.apache.org/r/57517/diff/2/


Testing (updated)
---

Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
Verified that credential_store_supported = true for Oozie, Hive, Logsearch

[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 23:08 min
[INFO] Finished at: 2017-03-10T11:56:37-08:00
[INFO] Final Memory: 66M/1105M
[INFO] 
mradhakrishnan$ mvn clean test -Drat.skip=true


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Madhuvanthi Radhakrishnan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/
---

(Updated March 10, 2017, 7:58 p.m.)


Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.


Changes
---

Incorporated review comments


Bugs: AMBARI-20399
https://issues.apache.org/jira/browse/AMBARI-20399


Repository: ambari


Description
---

ServiceInfo was not being refreshed on stack upgrade


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 b1bffef 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
70efeb5 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
d12a8a3 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
 2bfd176 


Diff: https://reviews.apache.org/r/57517/diff/2/

Changes: https://reviews.apache.org/r/57517/diff/1-2/


Testing
---

Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
Verified that credential_store_supported = true for Oozie, Hive, Logsearch


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 57461: Logfeeder: add de-duplication support

2017-03-10 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57461/
---

(Updated March 10, 2017, 7:38 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, 
and Sebastian Toader.


Changes
---

- disable lru cache by default
- add global properties (which can be overriden in input jsons)


Bugs: AMBARI-20378
https://issues.apache.org/jira/browse/AMBARI-20378


Repository: ambari


Description
---

Added de-duplication support on log feeder side.

For that I used an custom LRU cache. If it reaches maximum size, the least 
recently element will be removed.
Also because we often get the MRU element of the cache as well (to filter out 
if we want to setup to filter out the last message if that repeated too much), 
we store the MRU element in the cache. Its cheaper then get the name from the 
LinkedMap beause we will need to iterate over the map until the last element in 
the map (every time).


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
 d1e7fba 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
 ba63c61 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 e13d9bd 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/cache/LRUCache.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
 eb3ae01 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputLineFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
 86b5c57 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterJSONTest.java
 06d8db2 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/cache/LRUCacheTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/mapper/MapperDateTest.java
 08680f6 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputLineFilterTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputManagerTest.java
 a080fa8 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 879b786 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
 122a9e1 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
 2acb57e 


Diff: https://reviews.apache.org/r/57461/diff/4/

Changes: https://reviews.apache.org/r/57461/diff/3-4/


Testing
---

unit test added and updated. 
done.

logfeeder test output:
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 13.074s
[INFO] Finished at: Thu Mar 09 14:40:44 CET 2017
[INFO] Final Memory: 28M/324M
[INFO] 


Thanks,

Oliver Szabo

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Jonathan Hurley



> On March 10, 2017, 1:47 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
> > Lines 200-202 (patched)
> > 
> >
> > Shouldn't all metadata be refreshed in this, not just credential store?
> 
> Madhuvanthi Radhakrishnan wrote:
> Here are the metadata for ServiceInfo
> "cluster_name": "",-->Does it require a refresh?
> "credential_store_enabled": "false", --> I believe we dont want this 
> information to come from the stack i.e expectation is that after an upgrade 
> this will still be in disabled state. Please correct me if I am wrong.
> "credential_store_supported": "true", --> refreshed
> "maintenance_state": "OFF", -->Does it require a refresh?
> "service_name": "OOZIE",-->Does it require a refresh?
> "state": "STARTED"-->Does it require a refresh?

OK, so a lot of that doesn't come from the ServiceInfo. These do:

isClientOnlyService = sInfo.isClientOnlyService();
isCredentialStoreSupported = sInfo.isCredentialStoreSupported();
isCredentialStoreRequired = sInfo.isCredentialStoreRequired();

If any of them change between stacks, then I think we should update the 
internal state.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/#review168646
---


On March 10, 2017, 1:39 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57517/
> ---
> 
> (Updated March 10, 2017, 1:39 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20399
> https://issues.apache.org/jira/browse/AMBARI-20399
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ServiceInfo was not being refreshed on stack upgrade
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
>  b1bffef 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> 70efeb5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> d12a8a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
>  2bfd176 
> 
> 
> Diff: https://reviews.apache.org/r/57517/diff/1/
> 
> 
> Testing
> ---
> 
> Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
> Verified that credential_store_supported = true for Oozie, Hive, Logsearch
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Madhuvanthi Radhakrishnan



> On March 10, 2017, 6:47 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
> > Lines 198 (patched)
> > 
> >
> > This log statement isn't very helpful (since the logger itself outputs 
> > the class/method automatically). 
> > 
> > Also, you don't need `this` in `this.getName()`

Sorry , i forgot to remove the log statements after my testing. Will clean it 
up.


> On March 10, 2017, 6:47 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
> > Lines 200-202 (patched)
> > 
> >
> > Shouldn't all metadata be refreshed in this, not just credential store?

Here are the metadata for ServiceInfo
"cluster_name": "",-->Does it require a refresh?
"credential_store_enabled": "false", --> I believe we dont want this 
information to come from the stack i.e expectation is that after an upgrade 
this will still be in disabled state. Please correct me if I am wrong.
"credential_store_supported": "true", --> refreshed
"maintenance_state": "OFF", -->Does it require a refresh?
"service_name": "OOZIE",-->Does it require a refresh?
"state": "STARTED"-->Does it require a refresh?


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/#review168646
---


On March 10, 2017, 6:39 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57517/
> ---
> 
> (Updated March 10, 2017, 6:39 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20399
> https://issues.apache.org/jira/browse/AMBARI-20399
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ServiceInfo was not being refreshed on stack upgrade
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
>  b1bffef 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> 70efeb5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> d12a8a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
>  2bfd176 
> 
> 
> Diff: https://reviews.apache.org/r/57517/diff/1/
> 
> 
> Testing
> ---
> 
> Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
> Verified that credential_store_supported = true for Oozie, Hive, Logsearch
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/#review168646
---




ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
Line 74 (original), 76 (patched)


Formatting here looks off.



ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
Lines 198 (patched)


This log statement isn't very helpful (since the logger itself outputs the 
class/method automatically). 

Also, you don't need `this` in `this.getName()`



ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
Lines 200-202 (patched)


Shouldn't all metadata be refreshed in this, not just credential store?


- Jonathan Hurley


On March 10, 2017, 1:39 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57517/
> ---
> 
> (Updated March 10, 2017, 1:39 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20399
> https://issues.apache.org/jira/browse/AMBARI-20399
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ServiceInfo was not being refreshed on stack upgrade
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
>  b1bffef 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> 70efeb5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> d12a8a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
>  2bfd176 
> 
> 
> Diff: https://reviews.apache.org/r/57517/diff/1/
> 
> 
> Testing
> ---
> 
> Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
> Verified that credential_store_supported = true for Oozie, Hive, Logsearch
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Madhuvanthi Radhakrishnan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/
---

Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.


Bugs: AMBARI-20399
https://issues.apache.org/jira/browse/AMBARI-20399


Repository: ambari


Description
---

ServiceInfo was not being refreshed on stack upgrade


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 b1bffef 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
70efeb5 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
d12a8a3 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
 2bfd176 


Diff: https://reviews.apache.org/r/57517/diff/1/


Testing
---

Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
Verified that credential_store_supported = true for Oozie, Hive, Logsearch


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 57509: Few Ambari Metrics configs don't have `property_value_attributes.type`

2017-03-10 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57509/#review168644
---


Ship it!




Ship It!

- Sumit Mohanty


On March 10, 2017, 4:34 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57509/
> ---
> 
> (Updated March 10, 2017, 4:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20396
> https://issues.apache.org/jira/browse/AMBARI-20396
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ssl.client.truststore.password
> ssl.server.keystore.keypassword
> ssl.server.keystore.password
> ssl.server.truststore.password
> This configs don't have property_value_attributes.type. So, this configs are 
> shown as plaint text-fields and may be updated and overridden on the UI side.
> However metrics_grafana_password has property_value_attributes.type set to 
> password and UI shows it as password-field.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-client.xml
>  9543bbe 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-server.xml
>  9805619 
> 
> 
> Diff: https://reviews.apache.org/r/57509/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed. Only default configs property type changed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup instruction in sections on the manual step during RU

2017-03-10 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57463/#review168639
---


Ship it!




Ship It!

- Tim Thorpe


On March 10, 2017, 4:44 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57463/
> ---
> 
> (Updated March 10, 2017, 4:44 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20365
> https://issues.apache.org/jira/browse/AMBARI-20365
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> current approach is to use multiple  sections. Alejandro also 
> suggested an alternative where a single  section can accept HTML 
> markup for greater flexibility. The alternative approach will be treated as a 
> feature request in a separate JIRA.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 6bf2d4c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 91c8cdf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> fd93829 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> c27b634 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 708c011 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> b1325b9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> cb163e4 
> 
> 
> Diff: https://reviews.apache.org/r/57463/diff/3/
> 
> 
> Testing
> ---
> 
> patched a trunk cluster run RU, verify messages were shown in sections.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 57515: Zeppelin: Spark2 and Livy2 interpreter config disappear during stack upgrade

2017-03-10 Thread Renjith Kamath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57515/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-20397
https://issues.apache.org/jira/browse/AMBARI-20397


Repository: ambari


Description
---

During stack upgrade spark2 and livy2 interpreters are not present in zeppelin 
by default. Typically for a fresh install- when spark2 service is detected , 
those 2 interpreters are by default created for user out-of-the box


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 a460aecad0 


Diff: https://reviews.apache.org/r/57515/diff/1/


Testing
---

Manually tested the stack upgrade on CentOS


Thanks,

Renjith Kamath

Re: Review Request 57509: Few Ambari Metrics configs don't have `property_value_attributes.type`

2017-03-10 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57509/#review168634
---


Ship it!




Ship It!

- Sid Wagle


On March 10, 2017, 4:34 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57509/
> ---
> 
> (Updated March 10, 2017, 4:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20396
> https://issues.apache.org/jira/browse/AMBARI-20396
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ssl.client.truststore.password
> ssl.server.keystore.keypassword
> ssl.server.keystore.password
> ssl.server.truststore.password
> This configs don't have property_value_attributes.type. So, this configs are 
> shown as plaint text-fields and may be updated and overridden on the UI side.
> However metrics_grafana_password has property_value_attributes.type set to 
> password and UI shows it as password-field.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-client.xml
>  9543bbe 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-server.xml
>  9805619 
> 
> 
> Diff: https://reviews.apache.org/r/57509/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed. Only default configs property type changed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup instruction in sections on the manual step during RU

2017-03-10 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57463/
---

(Updated March 10, 2017, 4:44 p.m.)


Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-20365
https://issues.apache.org/jira/browse/AMBARI-20365


Repository: ambari


Description
---

current approach is to use multiple  sections. Alejandro also 
suggested an alternative where a single  section can accept HTML 
markup for greater flexibility. The alternative approach will be treated as a 
feature request in a separate JIRA.


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
6bf2d4c 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
91c8cdf 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
fd93829 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
c27b634 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
708c011 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
b1325b9 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
cb163e4 


Diff: https://reviews.apache.org/r/57463/diff/3/

Changes: https://reviews.apache.org/r/57463/diff/2-3/


Testing
---

patched a trunk cluster run RU, verify messages were shown in sections.


Thanks,

Di Li

Review Request 57509: Few Ambari Metrics configs don't have `property_value_attributes.type`

2017-03-10 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57509/
---

Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-20396
https://issues.apache.org/jira/browse/AMBARI-20396


Repository: ambari


Description
---

ssl.client.truststore.password
ssl.server.keystore.keypassword
ssl.server.keystore.password
ssl.server.truststore.password
This configs don't have property_value_attributes.type. So, this configs are 
shown as plaint text-fields and may be updated and overridden on the UI side.
However metrics_grafana_password has property_value_attributes.type set to 
password and UI shows it as password-field.


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-client.xml
 9543bbe 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-server.xml
 9805619 


Diff: https://reviews.apache.org/r/57509/diff/1/


Testing
---

Unit tests passed. Only default configs property type changed


Thanks,

Dmytro Sen

Re: Review Request 57461: Logfeeder: add de-duplication support

2017-03-10 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57461/#review168628
---


Fix it, then Ship it!




Overall, the patch looks fine to me.

I have created on issue though, since its not clear to me if this feature 
should be enabled by default.  

Thanks.


ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
Lines 43 (patched)


Should this feature be enabled by default?


- Robert Nettleton


On March 10, 2017, 11:16 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57461/
> ---
> 
> (Updated March 10, 2017, 11:16 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20378
> https://issues.apache.org/jira/browse/AMBARI-20378
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added de-duplication support on log feeder side.
> 
> For that I used an custom LRU cache. If it reaches maximum size, the least 
> recently element will be removed.
> Also because we often get the MRU element of the cache as well (to filter out 
> if we want to setup to filter out the last message if that repeated too 
> much), we store the MRU element in the cache. Its cheaper then get the name 
> from the LinkedMap beause we will need to iterate over the map until the last 
> element in the map (every time).
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
>  d1e7fba 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
>  ba63c61 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  e13d9bd 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/cache/LRUCache.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
>  eb3ae01 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputLineFilter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
>  86b5c57 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterJSONTest.java
>  06d8db2 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/cache/LRUCacheTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/mapper/MapperDateTest.java
>  08680f6 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputLineFilterTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputManagerTest.java
>  a080fa8 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
>  122a9e1 
> 
> 
> Diff: https://reviews.apache.org/r/57461/diff/3/
> 
> 
> Testing
> ---
> 
> unit test added and updated. 
> done.
> 
> logfeeder test output:
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 13.074s
> [INFO] Finished at: Thu Mar 09 14:40:44 CET 2017
> [INFO] Final Memory: 28M/324M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Anita Jebaraj



> On March 10, 2017, 3:40 p.m., Jonathan Hurley wrote:
> > Ship It!

Thank you Jonathan for reviewing, I had to update the patch since there was an 
unnecessarily check lingering around in the patch, 
+if(propertiesToHideInResponse != null) { 
this wont be required now since its assigned to an empty set on the invocation 
of the method. Can you please check this out and help me in pushing the changes 
to trunk


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review168626
---


On March 10, 2017, 3:34 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 10, 2017, 3:34 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr 
> Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md af962e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  df334c5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  8111a39 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/8/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review168626
---


Ship it!




Ship It!

- Jonathan Hurley


On March 10, 2017, 10:34 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 10, 2017, 10:34 a.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr 
> Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md af962e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  df334c5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  8111a39 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/7/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Anita Jebaraj



> On March 8, 2017, 6:44 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 4314-4336 (patched)
> > 
> >
> > This reads from the stream on every invocation. Since it's called a 
> > REST endpoint, that means the response is based on disk I/O ... can we just 
> > load these once on startup like other configuration properties?

This is fixed in the new patch


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review168320
---


On March 10, 2017, 3:34 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 10, 2017, 3:34 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr 
> Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md af962e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  df334c5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  8111a39 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/7/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Anita Jebaraj



> On March 10, 2017, 2:05 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 4356 (patched)
> > 
> >
> > Can you initialize this on the first invocation of this method? That 
> > way, if the black list file isn't defined, it doesn't have to go through 
> > the check over and over.

please refer to the new patch


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review168610
---


On March 10, 2017, 3:34 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 10, 2017, 3:34 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr 
> Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md af962e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  df334c5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  8111a39 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/7/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Anita Jebaraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/
---

(Updated March 10, 2017, 3:34 p.m.)


Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr 
Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi.


Bugs: AMBARI-20243
https://issues.apache.org/jira/browse/AMBARI-20243


Repository: ambari


Description
---

Currently all the details from the ambari.properties file is being returned by 
the API call.

Some of those information may not be utilized and hence an option can be 
provided to filter the properties

A ambari-blacklist.properties file can be created, the properties that are 
entered in the file, will be removed from the api call that returns the 
ambari.properties.


Diffs (updated)
-

  ambari-server/docs/configuration/index.md af962e1 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 df334c5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
 dadcf09 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 8111a39 


Diff: https://reviews.apache.org/r/57168/diff/7/

Changes: https://reviews.apache.org/r/57168/diff/6-7/


Testing
---

Added 1 test case
Ran mvn test


Thanks,

Anita Jebaraj

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57506/#review168620
---


Ship it!




Ship It!

- Robert Levas


On March 10, 2017, 8:53 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57506/
> ---
> 
> (Updated March 10, 2017, 8:53 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20394
> https://issues.apache.org/jira/browse/AMBARI-20394
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> No Content-Type HTTP header is set when downloading woff or ttf files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  a2441bd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java
>  85c47fc 
> 
> 
> Diff: https://reviews.apache.org/r/57506/diff/2/
> 
> 
> Testing
> ---
> 
> tested with curl:
>  curl -vv --user admin:admin --insecure 
> https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.woff?v=3.2.1 
>  curl -vv --user admin:admin --insecure 
> https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.ttf
>  
>  
> existing unittests ran with one irrelevant error:
> 
> --
> Failed tests:
> ERROR: test_start (test_metrics_grafana.TestMetricsGrafana)
> --
> Traceback (most recent call last):
>   File 
> "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1199, in patched
> return func(*args, **keywargs)
>   File 
> "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py",
>  line 47, in test_start
> target = RMFTestCase.TARGET_COMMON_SERVICES
>   File 
> "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
>  line 155, in executeScript
> method(RMFTestCase.env, *command_args)
>   File 
> "/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 58, in start
> create_grafana_admin_pwd()
>   File 
> "/Users/amagyar/development/ambari/ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
>  line 230, in create_grafana_admin_pwd
> host = params.ams_grafana_host.strip(),
> AttributeError: 'NoneType' object has no attribute 'strip'
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review168610
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 4356 (patched)


Can you initialize this on the first invocation of this method? That way, 
if the black list file isn't defined, it doesn't have to go through the check 
over and over.


- Jonathan Hurley


On March 8, 2017, 6:30 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 8, 2017, 6:30 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr 
> Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md af962e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  df334c5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  51114f8 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/6/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57506/
---

(Updated March 10, 2017, 1:53 p.m.)


Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, and 
Sebastian Toader.


Changes
---

unittest results


Bugs: AMBARI-20394
https://issues.apache.org/jira/browse/AMBARI-20394


Repository: ambari


Description
---

No Content-Type HTTP header is set when downloading woff or ttf files.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 a2441bd 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java
 85c47fc 


Diff: https://reviews.apache.org/r/57506/diff/2/


Testing (updated)
---

tested with curl:
 curl -vv --user admin:admin --insecure 
https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.woff?v=3.2.1 
 curl -vv --user admin:admin --insecure 
https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.ttf
 
 
existing unittests ran with one irrelevant error:

--
Failed tests:
ERROR: test_start (test_metrics_grafana.TestMetricsGrafana)
--
Traceback (most recent call last):
  File 
"/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py", 
line 1199, in patched
return func(*args, **keywargs)
  File 
"/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py",
 line 47, in test_start
target = RMFTestCase.TARGET_COMMON_SERVICES
  File 
"/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
 line 155, in executeScript
method(RMFTestCase.env, *command_args)
  File 
"/Users/amagyar/development/ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
 line 58, in start
create_grafana_admin_pwd()
  File 
"/Users/amagyar/development/ambari/ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py",
 line 230, in create_grafana_admin_pwd
host = params.ams_grafana_host.strip(),
AttributeError: 'NoneType' object has no attribute 'strip'


Thanks,

Attila Magyar

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Balázs Bence Sári


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57506/#review168609
---


Ship it!




Ship It!

- Balázs Bence Sári


On March 10, 2017, 12:36 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57506/
> ---
> 
> (Updated March 10, 2017, 12:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20394
> https://issues.apache.org/jira/browse/AMBARI-20394
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> No Content-Type HTTP header is set when downloading woff or ttf files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  a2441bd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java
>  85c47fc 
> 
> 
> Diff: https://reviews.apache.org/r/57506/diff/2/
> 
> 
> Testing
> ---
> 
> tested with curl:
>  curl -vv --user admin:admin --insecure 
> https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.woff?v=3.2.1 
>  curl -vv --user admin:admin --insecure 
> https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.ttf
>  
>  
> waiting for unit test results..
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57506/#review168608
---


Ship it!




Ship It!

- Sebastian Toader


On March 10, 2017, 1:36 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57506/
> ---
> 
> (Updated March 10, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20394
> https://issues.apache.org/jira/browse/AMBARI-20394
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> No Content-Type HTTP header is set when downloading woff or ttf files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  a2441bd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java
>  85c47fc 
> 
> 
> Diff: https://reviews.apache.org/r/57506/diff/2/
> 
> 
> Testing
> ---
> 
> tested with curl:
>  curl -vv --user admin:admin --insecure 
> https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.woff?v=3.2.1 
>  curl -vv --user admin:admin --insecure 
> https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.ttf
>  
>  
> waiting for unit test results..
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57508: AMBARI-20383.Not able to view the error log details on UI

2017-03-10 Thread belliraj hb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57508/#review168604
---


Ship it!




Ship It!

- belliraj hb


On March 10, 2017, 12:42 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57508/
> ---
> 
> (Updated March 10, 2017, 12:42 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20383
> https://issues.apache.org/jira/browse/AMBARI-20383
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by adding a extra check to check if the data nodes are not empty
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/validators/workflow-dag.js 
> 18da25b 
> 
> 
> Diff: https://reviews.apache.org/r/57508/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Review Request 57508: AMBARI-20383.Not able to view the error log details on UI

2017-03-10 Thread Padma Priya N


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57508/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and 
Pallav Kulshreshtha.


Bugs: AMBARI-20383
https://issues.apache.org/jira/browse/AMBARI-20383


Repository: ambari


Description
---

Fixed by adding a extra check to check if the data nodes are not empty


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/validators/workflow-dag.js 
18da25b 


Diff: https://reviews.apache.org/r/57508/diff/1/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57506/
---

(Updated March 10, 2017, 12:36 p.m.)


Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, and 
Sebastian Toader.


Changes
---

added unittest


Bugs: AMBARI-20394
https://issues.apache.org/jira/browse/AMBARI-20394


Repository: ambari


Description
---

No Content-Type HTTP header is set when downloading woff or ttf files.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 a2441bd 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java
 85c47fc 


Diff: https://reviews.apache.org/r/57506/diff/2/

Changes: https://reviews.apache.org/r/57506/diff/1-2/


Testing
---

tested with curl:
 curl -vv --user admin:admin --insecure 
https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.woff?v=3.2.1 
 curl -vv --user admin:admin --insecure 
https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.ttf
 
 
waiting for unit test results..


Thanks,

Attila Magyar

Review Request 57507: Diff tool shows additional line when comparing configs from custom config group

2017-03-10 Thread Oleg Nechiporenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57507/
---

Review request for Ambari and Jaimin Jetly.


Bugs: ambari-20388
https://issues.apache.org/jira/browse/ambari-20388


Repository: ambari


Description
---

- Create a custom config group for a service
- Update few properties and save to get a version for this custom group
- Add another property and save just to generate more config version
- Compare these 2 versions. Usually diff shows only the values from compared 
versions
- But looks like it shows the current value and the values in each version as 
well.
- In default group we dont see that extra line with the current value.


Diffs
-

  ambari-web/app/templates/common/configs/service_config_category.hbs 9890525 


Diff: https://reviews.apache.org/r/57507/diff/1/


Testing
---

20559 passing (23s)
  153 pending


Thanks,

Oleg Nechiporenko

Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57506/
---

Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, and 
Sebastian Toader.


Bugs: AMBARI-20394
https://issues.apache.org/jira/browse/AMBARI-20394


Repository: ambari


Description
---

No Content-Type HTTP header is set when downloading woff or ttf files.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 a2441bd 


Diff: https://reviews.apache.org/r/57506/diff/1/


Testing
---

tested with curl:
 curl -vv --user admin:admin --insecure 
https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.woff?v=3.2.1 
 curl -vv --user admin:admin --insecure 
https://c6401.ambari.apache.org:8443/font/fontawesome-webfont.ttf
 
 
waiting for unit test results..


Thanks,

Attila Magyar

Re: Review Request 57504: Fix typo in alert-definitions doc file

2017-03-10 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57504/#review168601
---


Ship it!




Ship It!

- Miklos Gergely


On March 10, 2017, 11:34 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57504/
> ---
> 
> (Updated March 10, 2017, 11:34 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, and Miklos 
> Gergely.
> 
> 
> Bugs: trunk
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed typo in alert-definitions file (change http to https)
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/alert-definitions.md 9785379 
> 
> 
> Diff: https://reviews.apache.org/r/57504/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures

2017-03-10 Thread DIPAYAN BHOWMICK


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57505/#review168600
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 10, 2017, 11:44 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57505/
> ---
> 
> (Updated March 10, 2017, 11:44 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20360
> https://issues.apache.org/jira/browse/AMBARI-20360
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added error message to show if workflow xml doesn't contain workflow-app tag, 
> similarly coordinator-app tag for coordinator xml and bundle-app tag for 
> bundle xml. And also added the check for maximum number of nodes to render 
> and shown the error message if it exceeds maximum.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> e94d51a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> c87ea99 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js
>  fdb4f5e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 37992be 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js
>  b3eed4b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
>  12d923c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 
> a076e3e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs
>  3cab194 
> 
> 
> Diff: https://reviews.apache.org/r/57505/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures

2017-03-10 Thread belliraj hb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57505/#review168599
---


Ship it!




Ship It!

- belliraj hb


On March 10, 2017, 11:44 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57505/
> ---
> 
> (Updated March 10, 2017, 11:44 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20360
> https://issues.apache.org/jira/browse/AMBARI-20360
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added error message to show if workflow xml doesn't contain workflow-app tag, 
> similarly coordinator-app tag for coordinator xml and bundle-app tag for 
> bundle xml. And also added the check for maximum number of nodes to render 
> and shown the error message if it exceeds maximum.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> e94d51a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> c87ea99 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js
>  fdb4f5e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 37992be 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js
>  b3eed4b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
>  12d923c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 
> a076e3e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs
>  3cab194 
> 
> 
> Diff: https://reviews.apache.org/r/57505/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures

2017-03-10 Thread Madhan Reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57505/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and 
Pallav Kulshreshtha.


Bugs: AMBARI-20360
https://issues.apache.org/jira/browse/AMBARI-20360


Repository: ambari


Description
---

Added error message to show if workflow xml doesn't contain workflow-app tag, 
similarly coordinator-app tag for coordinator xml and bundle-app tag for bundle 
xml. And also added the check for maximum number of nodes to render and shown 
the error message if it exceeds maximum.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
e94d51a 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
c87ea99 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js 
fdb4f5e 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
37992be 
  
contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js
 b3eed4b 
  
contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
 12d923c 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 
a076e3e 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs
 3cab194 


Diff: https://reviews.apache.org/r/57505/diff/1/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 57504: Fix typo in alert-definitions doc file

2017-03-10 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57504/#review168598
---


Ship it!




Ship It!

- Attila Magyar


On March 10, 2017, 11:34 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57504/
> ---
> 
> (Updated March 10, 2017, 11:34 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, and Miklos 
> Gergely.
> 
> 
> Bugs: trunk
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed typo in alert-definitions file (change http to https)
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/alert-definitions.md 9785379 
> 
> 
> Diff: https://reviews.apache.org/r/57504/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 57504: Fix typo in alert-definitions doc file

2017-03-10 Thread Attila Doroszlai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57504/#review168597
---


Ship it!




Ship It!

- Attila Doroszlai


On March 10, 2017, 12:34 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57504/
> ---
> 
> (Updated March 10, 2017, 12:34 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, and Miklos 
> Gergely.
> 
> 
> Bugs: trunk
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed typo in alert-definitions file (change http to https)
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/alert-definitions.md 9785379 
> 
> 
> Diff: https://reviews.apache.org/r/57504/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 57504: Fix typo in alert-definitions doc file

2017-03-10 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57504/
---

Review request for Ambari, Attila Doroszlai, Attila Magyar, and Miklos Gergely.


Bugs: trunk
https://issues.apache.org/jira/browse/trunk


Repository: ambari


Description
---

Fixed typo in alert-definitions file (change http to https)


Diffs
-

  ambari-server/docs/api/v1/alert-definitions.md 9785379 


Diff: https://reviews.apache.org/r/57504/diff/1/


Testing
---

done.


Thanks,

Oliver Szabo

Re: Review Request 57465: RU: Slider service check failed during rolling upgrade

2017-03-10 Thread Dmitro Lisnichenko



> On March 9, 2017, 9:16 p.m., Jonathan Hurley wrote:
> > I saw you removed `export HADOOP_CONF_DIR={{hadoop_conf_dir}}`. I'm 
> > guessing that since you moved SLIDER in the upgrade packs, it wasn't needed 
> > anymore. Still, seems like it should have it, no?

If Slider is restarted before service check, slider-env is generated correctly 
from template. So current template contents are fine


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57465/#review168497
---


On March 9, 2017, 7:59 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57465/
> ---
> 
> (Updated March 9, 2017, 7:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20380
> https://issues.apache.org/jira/browse/AMBARI-20380
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Partially fixed by AMBARI-20344, now final fix for Slider
> 
> During RU Slider Service check failed with exception:
> {code:java}
> 17/02/25 14:18:24 INFO service.AbstractService: Service 
> org.apache.hadoop.yarn.client.api.impl.YarnClientImpl failed in state 
> STARTED; cause: java.lang.RuntimeException: java.lang.RuntimeException: 
> java.lang.ClassNotFoundException: Class 
> org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not found
> java.lang.RuntimeException: java.lang.RuntimeException: 
> java.lang.ClassNotFoundException: Class 
> org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not found
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2227)
> at 
> org.apache.hadoop.yarn.client.RMProxy.createRMFailoverProxyProvider(RMProxy.java:160)
> at org.apache.hadoop.yarn.client.RMProxy.createRMProxy(RMProxy.java:93)
> at 
> org.apache.hadoop.yarn.client.ClientRMProxy.createRMProxy(ClientRMProxy.java:72)
> at 
> org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.serviceStart(YarnClientImpl.java:188)
> at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.mapred.ResourceMgrDelegate.serviceStart(ResourceMgrDelegate.java:109)
> at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.mapred.ResourceMgrDelegate.(ResourceMgrDelegate.java:98)
> at org.apache.hadoop.mapred.YARNRunner.(YARNRunner.java:112)
> at 
> org.apache.hadoop.mapred.YarnClientProtocolProvider.create(YarnClientProtocolProvider.java:34)
> at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:95)
> at org.apache.hadoop.mapreduce.Cluster.(Cluster.java:82)
> at org.apache.hadoop.mapreduce.Cluster.(Cluster.java:75)
> at org.apache.hadoop.mapreduce.Job$9.run(Job.java:1260)
> at org.apache.hadoop.mapreduce.Job$9.run(Job.java:1256)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:415)
> at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1709)
> at org.apache.hadoop.mapreduce.Job.connect(Job.java:1255)
> at org.apache.hadoop.mapreduce.Job.submit(Job.java:1284)
> at org.apache.hadoop.mapreduce.Job.waitForCompletion(Job.java:1308)
> at org.apache.hadoop.examples.WordCount.main(WordCount.java:87)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at 
> org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:71)
> at org.apache.hadoop.util.ProgramDriver.run(ProgramDriver.java:144)
> at org.apache.hadoop.examples.ExampleDriver.main(ExampleDriver.java:74)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
> Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: 
> Class org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not 
> found
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2195)
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2219)
> ... 35 more
> Caused by: java.lang.ClassNotFoundException: Class 
> org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not found
> at 
> org.apache.hadoop.conf.Configuration.getC

Re: Review Request 57465: RU: Slider service check failed during rolling upgrade

2017-03-10 Thread Dmitro Lisnichenko



> On March 9, 2017, 11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml
> > Line 463 (original)
> > 
> >
> > Is this because Slider has dependencies on Storm plugin?

no, because Slider has embedded YARN client, and it happens to use old binary 
with new YARN config after YARN client update


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57465/#review168516
---


On March 9, 2017, 7:59 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57465/
> ---
> 
> (Updated March 9, 2017, 7:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20380
> https://issues.apache.org/jira/browse/AMBARI-20380
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Partially fixed by AMBARI-20344, now final fix for Slider
> 
> During RU Slider Service check failed with exception:
> {code:java}
> 17/02/25 14:18:24 INFO service.AbstractService: Service 
> org.apache.hadoop.yarn.client.api.impl.YarnClientImpl failed in state 
> STARTED; cause: java.lang.RuntimeException: java.lang.RuntimeException: 
> java.lang.ClassNotFoundException: Class 
> org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not found
> java.lang.RuntimeException: java.lang.RuntimeException: 
> java.lang.ClassNotFoundException: Class 
> org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not found
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2227)
> at 
> org.apache.hadoop.yarn.client.RMProxy.createRMFailoverProxyProvider(RMProxy.java:160)
> at org.apache.hadoop.yarn.client.RMProxy.createRMProxy(RMProxy.java:93)
> at 
> org.apache.hadoop.yarn.client.ClientRMProxy.createRMProxy(ClientRMProxy.java:72)
> at 
> org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.serviceStart(YarnClientImpl.java:188)
> at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.mapred.ResourceMgrDelegate.serviceStart(ResourceMgrDelegate.java:109)
> at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.mapred.ResourceMgrDelegate.(ResourceMgrDelegate.java:98)
> at org.apache.hadoop.mapred.YARNRunner.(YARNRunner.java:112)
> at 
> org.apache.hadoop.mapred.YarnClientProtocolProvider.create(YarnClientProtocolProvider.java:34)
> at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:95)
> at org.apache.hadoop.mapreduce.Cluster.(Cluster.java:82)
> at org.apache.hadoop.mapreduce.Cluster.(Cluster.java:75)
> at org.apache.hadoop.mapreduce.Job$9.run(Job.java:1260)
> at org.apache.hadoop.mapreduce.Job$9.run(Job.java:1256)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:415)
> at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1709)
> at org.apache.hadoop.mapreduce.Job.connect(Job.java:1255)
> at org.apache.hadoop.mapreduce.Job.submit(Job.java:1284)
> at org.apache.hadoop.mapreduce.Job.waitForCompletion(Job.java:1308)
> at org.apache.hadoop.examples.WordCount.main(WordCount.java:87)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at 
> org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:71)
> at org.apache.hadoop.util.ProgramDriver.run(ProgramDriver.java:144)
> at org.apache.hadoop.examples.ExampleDriver.main(ExampleDriver.java:74)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
> Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: 
> Class org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not 
> found
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2195)
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2219)
> ... 35 more
> Caused by: java.lang.ClassNotFoundException: Class 
> org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not found
> at 
> org.

51 matches

Mail list logo