Re: Review Request 57451: The Installation of hbase-client failed

[zhangxiaolu zhangxiaolu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/
---

(Updated 四月 14, 2017, 4:52 a.m.)


Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Yusaku Sako.


Bugs: AMBARI-20368
https://issues.apache.org/jira/browse/AMBARI-20368


Repository: ambari


Description
---

The problem is caused by the wrong installation order, which means hbase-client 
will be installed before the installation of hdfs-client. Under such 
circumstance, installation of hdfs-client will fail because the hadoop-conf-dir 
does not exist. 
Two solutions can be provided to solve this problem:
1. Creating the hadoop-conf-dir in hbase.py;
2. Setting correct installation order in role_command_order.json;
Considering that hdfs-client may not beinstalled on the node especially when 
adding new host, therefore, in my opinion, the second choice would be more 
appropriate.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 20894ec 


Diff: https://reviews.apache.org/r/57451/diff/6/

Changes: https://reviews.apache.org/r/57451/diff/5-6/


Testing
---

done it


File Attachments


AMBARI-20368.patch
  
https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch


Thanks,

zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

[zhangxiaolu zhangxiaolu]

> On 四月 12, 2017, 4:35 p.m., Alejandro Fernandez wrote:
> >

In the trunk,the relative code about hadoop_conf_dir has been removed,and there 
is no problem , and I will cancle this jira.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171749
---


On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 四月 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Review Request 58445: AMBARI-20738 - Cannot add repo for additional OS to an existing HDP version

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58445/
---

Review request for Ambari, Jaimin Jetly and Xi Wang.


Bugs: AMBARI-20738
https://issues.apache.org/jira/browse/AMBARI-20738


Repository: ambari


Description
---

Fix repo update logic.
Remove redundant calls.


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
 c6ba241 


Diff: https://reviews.apache.org/r/58445/diff/1/


Testing
---

Manuall tested on live cluster. All unit tests passed.
PhantomJS 1.9.7 (Mac OS X): Executed 81 of 81 SUCCESS (0.182 secs / 0.436 secs)


Thanks,

Richard Zang

Re: Review Request 58409: get_value_from_jmx constantly prints exception message in retry mechanism, which brings bad user experience

[Yuanbo Liu]

> On April 13, 2017, 1:37 p.m., Di Li wrote:
> > Hello Yuan Bo,
> > 
> > Could you please 
> > 1. Also attach the patch to your JIRA
> > 2. Click Submit Patch button on your JIRA so HadoopQA can run a round of 
> > integration test ?

Sure


- Yuanbo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58409/#review171872
---


On April 13, 2017, 4:16 a.m., Yuanbo Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58409/
> ---
> 
> (Updated April 13, 2017, 4:16 a.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20754
> https://issues.apache.org/jira/browse/AMBARI-20754
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> get_value_from_jmx of jmx.py is used in getting NameNode HA state. As we 
> know, if the cluster is large, it takes a long time for Namenode to leave 
> safe mode when restarting Namenode, thus we use retry mechanism to invoke 
> get_value_from_jmx in case of getting wrong state. The problem is that, 
> get_value_from_jmx will print several exception message into std_error during 
> retrying, it confuses users because there're error messages in std_error, 
> while all the services restart successfully
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/jmx.py 
> 9a4ff5f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  665a8e4 
> 
> 
> Diff: https://reviews.apache.org/r/58409/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yuanbo Liu
> 
>

Review Request 58444: Log Feeder fill cluster name if it is not set

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58444/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-20766
https://issues.apache.org/jira/browse/AMBARI-20766


Repository: ambari


Description
---

If for some reason there is no cluster set for a log entry, set it to the 
actual cluster.


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
 9a9f973 


Diff: https://reviews.apache.org/r/58444/diff/1/


Testing
---

tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 58437: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58437/
---

(Updated April 13, 2017, 11:08 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated 'display name' and 'description' for 'apptimelineserver_heapsize'


Bugs: AMBARI-20763
https://issues.apache.org/jira/browse/AMBARI-20763


Repository: ambari


Description
---

In 2.6, update the following YARN configs related to ATS:

- **'yarn.timeline-service.entity-group-fs-store.app-cache-size'** on cluster 
initialization/creation based on host memory.
- **'apptimelineserver_heapsize'** on : (1). cluster initialization/creation 
and/or (2). when a change is detected in value for 
'yarn.timeline-service.entity-group-fs-store.app-cache-size', using formula:
   
  ats_heapsize = long(min(math.floor(host_mem/2), 
long(yarn_timeline_app_cache_size) * 500 + 3072))  // Value in MB


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
 d04c3c5 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
53ff007 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 8576dcc 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 5bfa1a9 


Diff: https://reviews.apache.org/r/58437/diff/2/

Changes: https://reviews.apache.org/r/58437/diff/1-2/


Testing
---

Yes, 

- Python UTs added.
- Tested on cluster.


Thanks,

Swapan Shridhar

Re: Review Request 58438: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58438/
---

(Updated April 13, 2017, 11:08 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated 'display name' and 'description' for 'apptimelineserver_heapsize'


Bugs: AMBARI-20763
https://issues.apache.org/jira/browse/AMBARI-20763


Repository: ambari


Description
---

In 2.6, update the following YARN configs related to ATS:

- **'yarn.timeline-service.entity-group-fs-store.app-cache-size'** on cluster 
initialization/creation based on host memory.
- **'apptimelineserver_heapsize'** on : (1). cluster initialization/creation 
and/or (2). when a change is detected in value for 
'yarn.timeline-service.entity-group-fs-store.app-cache-size', using formula:
   
  ats_heapsize = long(min(math.floor(host_mem/2), 
long(yarn_timeline_app_cache_size) * 500 + 3072))  // Value in MB


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 fc32001 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
 d04c3c5 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
7881917 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 4250681 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 5bfa1a9 


Diff: https://reviews.apache.org/r/58438/diff/2/

Changes: https://reviews.apache.org/r/58438/diff/1-2/


Testing
---

Yes, 

Python UTs added.
Tested on cluster.


Thanks,

Swapan Shridhar

Re: Review Request 58437: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58437/#review171957
---


Ship it!




Ship It!

- Sumit Mohanty


On April 13, 2017, 10:21 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58437/
> ---
> 
> (Updated April 13, 2017, 10:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20763
> https://issues.apache.org/jira/browse/AMBARI-20763
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In 2.6, update the following YARN configs related to ATS:
> 
> - **'yarn.timeline-service.entity-group-fs-store.app-cache-size'** on cluster 
> initialization/creation based on host memory.
> - **'apptimelineserver_heapsize'** on : (1). cluster initialization/creation 
> and/or (2). when a change is detected in value for 
> 'yarn.timeline-service.entity-group-fs-store.app-cache-size', using formula:
>
>   ats_heapsize = long(min(math.floor(host_mem/2), 
> long(yarn_timeline_app_cache_size) * 500 + 3072))  // Value in MB
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
>  d04c3c5 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 53ff007 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 42047d9 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 5bfa1a9 
> 
> 
> Diff: https://reviews.apache.org/r/58437/diff/1/
> 
> 
> Testing
> ---
> 
> Yes, 
> 
> - Python UTs added.
> - Tested on cluster.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 58433: Add more database options for beacon in stack advisor

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58433/#review171951
---


Ship it!




Ship It!

- Jaimin Jetly


On April 13, 2017, 10:08 p.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58433/
> ---
> 
> (Updated April 13, 2017, 10:08 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20762
> https://issues.apache.org/jira/browse/AMBARI-20762
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the configs/Database page of beacon, on selecting each database type, the 
> JDBC Driver Class and URL should be updated automatically. 
> 
> This part should be done in stack advisor.
> 
> (Beacon supports three db types : New derby, existed MySQL and existed Oracle 
> )
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 7881917ab0 
> 
> 
> Diff: https://reviews.apache.org/r/58433/diff/2/
> 
> 
> Testing
> ---
> 
> 20664 passing (27s)
>   128 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Review Request 58438: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58438/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-20763
https://issues.apache.org/jira/browse/AMBARI-20763


Repository: ambari


Description
---

In 2.6, update the following YARN configs related to ATS:

- **'yarn.timeline-service.entity-group-fs-store.app-cache-size'** on cluster 
initialization/creation based on host memory.
- **'apptimelineserver_heapsize'** on : (1). cluster initialization/creation 
and/or (2). when a change is detected in value for 
'yarn.timeline-service.entity-group-fs-store.app-cache-size', using formula:
   
  ats_heapsize = long(min(math.floor(host_mem/2), 
long(yarn_timeline_app_cache_size) * 500 + 3072))  // Value in MB


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 fc32001 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
 d04c3c5 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
7881917 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 4250681 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 5bfa1a9 


Diff: https://reviews.apache.org/r/58438/diff/1/


Testing
---

Yes, 

Python UTs added.
Tested on cluster.


Thanks,

Swapan Shridhar

Review Request 58437: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58437/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-20763
https://issues.apache.org/jira/browse/AMBARI-20763


Repository: ambari


Description
---

In 2.6, update the following YARN configs related to ATS:

- **'yarn.timeline-service.entity-group-fs-store.app-cache-size'** on cluster 
initialization/creation based on host memory.
- **'apptimelineserver_heapsize'** on : (1). cluster initialization/creation 
and/or (2). when a change is detected in value for 
'yarn.timeline-service.entity-group-fs-store.app-cache-size', using formula:
   
  ats_heapsize = long(min(math.floor(host_mem/2), 
long(yarn_timeline_app_cache_size) * 500 + 3072))  // Value in MB


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
 d04c3c5 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
53ff007 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 42047d9 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 5bfa1a9 


Diff: https://reviews.apache.org/r/58437/diff/1/


Testing
---

Yes, 

- Python UTs added.
- Tested on cluster.


Thanks,

Swapan Shridhar

Re: Review Request 58433: Add more database options for beacon in stack advisor

[Xi Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58433/
---

(Updated April 13, 2017, 3:08 p.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, and Yusaku Sako.


Bugs: AMBARI-20762
https://issues.apache.org/jira/browse/AMBARI-20762


Repository: ambari


Description
---

In the configs/Database page of beacon, on selecting each database type, the 
JDBC Driver Class and URL should be updated automatically. 

This part should be done in stack advisor.

(Beacon supports three db types : New derby, existed MySQL and existed Oracle )


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
7881917ab0 


Diff: https://reviews.apache.org/r/58433/diff/2/

Changes: https://reviews.apache.org/r/58433/diff/1-2/


Testing
---

20664 passing (27s)
  128 pending


Thanks,

Xi Wang

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

[Bharat Viswanadham]

> On April 13, 2017, 9:49 p.m., Alejandro Fernandez wrote:
> > Ship It!

Hi Alejandro Fernandez
Could you please help me in commiting this.


- Bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review171943
---


On April 13, 2017, 8:44 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> ---
> 
> (Updated April 13, 2017, 8:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and 
> Juanjo  Marron.
> 
> 
> Bugs: AMBARI-18865
> https://issues.apache.org/jira/browse/AMBARI-18865
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/56677/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 58431: Update zookeeper.connect description

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171944
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 13, 2017, 8:11 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> ---
> 
> (Updated April 13, 2017, 8:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20761
> https://issues.apache.org/jira/browse/AMBARI-20761
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update zookeeper.connect description
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/58431/diff/1/
> 
> 
> Testing
> ---
> 
> It is a document change. Changed the description.
> Tested it with install Kafka and zookeeper with change in the 
> zookeeper.connect to <>:<>/chroot/path and Kafka Broker is 
> successfully started.
> And tried running console consumer
> bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path 
> --from-beginning --topic ambari_service_check
> This also worked fine.
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review171943
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 13, 2017, 8:44 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> ---
> 
> (Updated April 13, 2017, 8:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and 
> Juanjo  Marron.
> 
> 
> Bugs: AMBARI-18865
> https://issues.apache.org/jira/browse/AMBARI-18865
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/56677/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Review Request 58433: Add more database options for beacon in stack advisor

[Xi Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58433/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, and Yusaku Sako.


Bugs: AMBARI-20762
https://issues.apache.org/jira/browse/AMBARI-20762


Repository: ambari


Description
---

In the configs/Database page of beacon, on selecting each database type, the 
JDBC Driver Class and URL should be updated automatically. 

This part should be done in stack advisor.

(Beacon supports three db types : New derby, existed MySQL and existed Oracle )


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
7881917ab0 


Diff: https://reviews.apache.org/r/58433/diff/1/


Testing
---

20664 passing (27s)
  128 pending


Thanks,

Xi Wang

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58356/#review171939
---


Ship it!




Ship It!

- Jayush Luniya


On April 13, 2017, 3:44 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58356/
> ---
> 
> (Updated April 13, 2017, 3:44 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
> Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20735
> https://issues.apache.org/jira/browse/AMBARI-20735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created checkstyle check to ensure either @ApiOperation or @ApiIgnore is 
> present on all REST API methods
> 
> 
> Diffs
> -
> 
>   ambari-server/checkstyle.xml bf7698760ac8ddba1d692bcd448c19d939dc 
>   ambari-server/pom.xml fbc2b9fd129dca0828624fe76e33616b6919f429 
>   ambari-server/src/main/assemblies/server.xml 
> 27835265f78a3a7aed37eaa544e25679eee8b400 
>   utility/checkstyle.xml PRE-CREATION 
>   utility/pom.xml 6f602068ca863fd99d537b88462487d9f28e9c6d 
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java 
> PRE-CREATION 
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>  PRE-CREATION 
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>  14d74867b81d58a35e732940ccb16f02d4e9b317 
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>  PRE-CREATION 
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58356/diff/2/
> 
> 
> Testing
> ---
> 
> Includes unit test for the new check.
> Also ran the check on ambari-server: produces 315 errors.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 58244: Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin

[Di Li]

> On April 7, 2017, 4:57 p.m., Di Li wrote:
> > Ship It!
> 
> Bharat Viswanadham wrote:
> Hi Di,
> Could you please help in commit these changes.

Please close this RB request as it has been pushed to trunk as 
https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=cfde36c077de31dda0802f983602f680afcbce29


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58244/#review171367
---


On April 7, 2017, 4:50 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58244/
> ---
> 
> (Updated April 7, 2017, 4:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20697
> https://issues.apache.org/jira/browse/AMBARI-20697
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 67532c5 
> 
> 
> Diff: https://reviews.apache.org/r/58244/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 56673: Perform Kinit on Kafka Start

[Di Li]

> On April 7, 2017, 12:48 p.m., Di Li wrote:
> > Ship It!
> 
> Bharat Viswanadham wrote:
> Hi Di,
> Could you please help in commit these changes.

Please close this request, as it has been pushed to trunk as 
https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=14c1ffd3288742354f17cbf49b6cebfee913a16f


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56673/#review171333
---


On April 7, 2017, 4:49 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56673/
> ---
> 
> (Updated April 7, 2017, 4:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Juanjo  Marron.
> 
> 
> Bugs: AMBARI-19996
> https://issues.apache.org/jira/browse/AMBARI-19996
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Perform Kinit on Kafka Start
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  0901730 
> 
> 
> Diff: https://reviews.apache.org/r/56673/diff/1/
> 
> 
> Testing
> ---
> 
> Kerberoized the cluster and then checked for kafka user the kinit has 
> performed or not.
> ran the command klist for kafka user and able to see cached ticket under 
> kafka user
> [root@idyll1 ~]# su kafka
> [kafka@idyll1 root]$ klist
> Ticket cache: FILE:/tmp/krb5cc_1004
> Default principal: kafka/idyll1.fyre.ibm@ibm.com
> 
> Valid starting ExpiresService principal
> 02/14/17 10:21:41  02/15/17 10:21:41  krbtgt/ibm@ibm.com
>   renew until 02/14/17 10:21:41
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

[Bharat Viswanadham]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/
---

(Updated April 13, 2017, 8:44 p.m.)


Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and 
Juanjo  Marron.


Bugs: AMBARI-18865
https://issues.apache.org/jira/browse/AMBARI-18865


Repository: ambari


Description
---

Updated to remove deprecated property and updated property in latest release


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 96b7750 


Diff: https://reviews.apache.org/r/56677/diff/2/


Testing
---


Thanks,

Bharat Viswanadham

Re: Review Request 56673: Perform Kinit on Kafka Start

[Bharat Viswanadham]

> On April 7, 2017, 12:48 p.m., Di Li wrote:
> > Ship It!

Hi Di,
Could you please help in commit these changes.


- Bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56673/#review171333
---


On April 7, 2017, 4:49 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56673/
> ---
> 
> (Updated April 7, 2017, 4:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Juanjo  Marron.
> 
> 
> Bugs: AMBARI-19996
> https://issues.apache.org/jira/browse/AMBARI-19996
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Perform Kinit on Kafka Start
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  0901730 
> 
> 
> Diff: https://reviews.apache.org/r/56673/diff/1/
> 
> 
> Testing
> ---
> 
> Kerberoized the cluster and then checked for kafka user the kinit has 
> performed or not.
> ran the command klist for kafka user and able to see cached ticket under 
> kafka user
> [root@idyll1 ~]# su kafka
> [kafka@idyll1 root]$ klist
> Ticket cache: FILE:/tmp/krb5cc_1004
> Default principal: kafka/idyll1.fyre.ibm@ibm.com
> 
> Valid starting ExpiresService principal
> 02/14/17 10:21:41  02/15/17 10:21:41  krbtgt/ibm@ibm.com
>   renew until 02/14/17 10:21:41
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 58431: Update zookeeper.connect description

[Bharat Viswanadham]

> On April 13, 2017, 7:54 p.m., Di Li wrote:
> > hello Bharat,
> > 
> > Could you please update the review board request with the Ambari JIRA ID , 
> > branch the issue applies, tests done, etc ?

Updated fields required.


- Bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171925
---


On April 13, 2017, 8:11 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> ---
> 
> (Updated April 13, 2017, 8:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20761
> https://issues.apache.org/jira/browse/AMBARI-20761
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update zookeeper.connect description
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/58431/diff/1/
> 
> 
> Testing
> ---
> 
> It is a document change. Changed the description.
> Tested it with install Kafka and zookeeper with change in the 
> zookeeper.connect to <>:<>/chroot/path and Kafka Broker is 
> successfully started.
> And tried running console consumer
> bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path 
> --from-beginning --topic ambari_service_check
> This also worked fine.
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 58431: Update zookeeper.connect description

[Bharat Viswanadham]

> On April 13, 2017, 8:26 p.m., Di Li wrote:
> > Ship It!

Hi Di,
Could you please help in commit these changes.


- Bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171929
---


On April 13, 2017, 8:11 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> ---
> 
> (Updated April 13, 2017, 8:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20761
> https://issues.apache.org/jira/browse/AMBARI-20761
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update zookeeper.connect description
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/58431/diff/1/
> 
> 
> Testing
> ---
> 
> It is a document change. Changed the description.
> Tested it with install Kafka and zookeeper with change in the 
> zookeeper.connect to <>:<>/chroot/path and Kafka Broker is 
> successfully started.
> And tried running console consumer
> bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path 
> --from-beginning --topic ambari_service_check
> This also worked fine.
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 58244: Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin

[Bharat Viswanadham]

> On April 7, 2017, 4:57 p.m., Di Li wrote:
> > Ship It!

Hi Di,
Could you please help in commit these changes.


- Bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58244/#review171367
---


On April 7, 2017, 4:50 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58244/
> ---
> 
> (Updated April 7, 2017, 4:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20697
> https://issues.apache.org/jira/browse/AMBARI-20697
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 67532c5 
> 
> 
> Diff: https://reviews.apache.org/r/58244/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 58417: Update docker volumes for Ambari logsearch integration test module

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58417/#review171930
---


Ship it!




Ship It!

- Robert Nettleton


On April 13, 2017, 12:11 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58417/
> ---
> 
> (Updated April 13, 2017, 12:11 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20756
> https://issues.apache.org/jira/browse/AMBARI-20756
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As logsearch-portal has been splitted to 2 differnet modules 
> (logsearch-server + logsearch-web) some of the volumes are not up to date in 
> the integration test framework.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
>  5f8f9bf 
> 
> 
> Diff: https://reviews.apache.org/r/58417/diff/2/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 58431: Update zookeeper.connect description

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171929
---


Ship it!




Ship It!

- Di Li


On April 13, 2017, 8:11 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> ---
> 
> (Updated April 13, 2017, 8:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20761
> https://issues.apache.org/jira/browse/AMBARI-20761
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update zookeeper.connect description
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/58431/diff/1/
> 
> 
> Testing
> ---
> 
> It is a document change. Changed the description.
> Tested it with install Kafka and zookeeper with change in the 
> zookeeper.connect to <>:<>/chroot/path and Kafka Broker is 
> successfully started.
> And tried running console consumer
> bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path 
> --from-beginning --topic ambari_service_check
> This also worked fine.
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 58431: Update zookeeper.connect description

[Bharat Viswanadham]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/
---

(Updated April 13, 2017, 8:11 p.m.)


Review request for Ambari, Alejandro Fernandez and Di Li.


Bugs: AMBARI-20761
https://issues.apache.org/jira/browse/AMBARI-20761


Repository: ambari


Description
---

Update zookeeper.connect description


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 96b7750 


Diff: https://reviews.apache.org/r/58431/diff/1/


Testing (updated)
---

It is a document change. Changed the description.
Tested it with install Kafka and zookeeper with change in the zookeeper.connect 
to <>:<>/chroot/path and Kafka Broker is successfully started.
And tried running console consumer
bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path 
--from-beginning --topic ambari_service_check
This also worked fine.


Thanks,

Bharat Viswanadham

Re: Review Request 58431: Update zookeeper.connect description

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171925
---



hello Bharat,

Could you please update the review board request with the Ambari JIRA ID , 
branch the issue applies, tests done, etc ?

- Di Li


On April 13, 2017, 7:37 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> ---
> 
> (Updated April 13, 2017, 7:37 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update zookeeper.connect description
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/58431/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Review Request 58431: Update zookeeper.connect description

[Bharat Viswanadham]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/
---

Review request for Ambari, Alejandro Fernandez and Di Li.


Repository: ambari


Description
---

Update zookeeper.connect description


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 96b7750 


Diff: https://reviews.apache.org/r/58431/diff/1/


Testing
---


Thanks,

Bharat Viswanadham

Re: Review Request 58429: After pam setup- Hive View user home test fails

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/#review171916
---



Can you add Vishal Ghugare to the review?

- Robert Levas


On April 13, 2017, 2:45 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58429/
> ---
> 
> (Updated April 13, 2017, 2:45 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Henning Kropp, and Robert Levas.
> 
> 
> Bugs: AMBARI-20760
> https://issues.apache.org/jira/browse/AMBARI-20760
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After setting up PAM, tried to login as PAM user and access hive view, user 
> home test fails with the error as in screen shot.
> 
> This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was 
> not incorporated in the code. Pasting the comment from Henning below.
> 
> Something we noticed is that in a secured cluster we have issues with the 
> views, getting the following exception for the Hive view as an example:
> 
> Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS, 
> infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to 
> validate proxy privilege of ambari for 
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
> .
> sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege 
> of ambari for 
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
>  serverProtocolVersion:null)
> 
> As you can see it tries to impersonte 
> "org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
>  Changing the UsernamePasswordAuthenticationToken from Principal to username 
> fixes this.
> 
> So instead of :
> 
> UsernamePasswordAuthenticationToken token = new 
> UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
> 
> We use:
> 
> UsernamePasswordAuthenticationToken token = new 
> UsernamePasswordAuthenticationToken(user.getUserName(), null, 
> userAuthorities);
> 
> What could potential also work is, overriding toString of the principal like:
> 
> Principal principal = new Principal() {
> @Override
> public String getName()
> { return user.getUserName(); }
> 
> @Override
> public String toString()
> { return user.getUserName().toString(); }
> 
> };
> 
> We did not test this!
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  ca7cd31 
> 
> 
> Diff: https://reviews.apache.org/r/58429/diff/1/
> 
> 
> Testing
> ---
> 
> Ran mvn test and also manually tested the scenario
> 
> 
> File Attachments
> 
> 
> error screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58425: Remove Server attribute from the HTTP response headers

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58425/#review171914
---


Ship it!




Ship It!

- Robert Levas


On April 13, 2017, 1:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58425/
> ---
> 
> (Updated April 13, 2017, 1:16 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20650
> https://issues.apache.org/jira/browse/AMBARI-20650
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the HTTP response header contains the Jetty version.
> Server:Jetty(8.1.19.v20160209)
> To follow best security practices, it would be good to avoid including this 
> information in the response headers.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  4e7af0c 
> 
> 
> Diff: https://reviews.apache.org/r/58425/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing. Verified that "Server" header is removed from the HTTP 
> response headers.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 58346: AMBARI-20733 /var/log/krb5kdc.log is growing rapidly on the KDC server

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58346/#review171912
---


Ship it!




Ship It!

- Robert Levas


On April 13, 2017, 8:29 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58346/
> ---
> 
> (Updated April 13, 2017, 8:29 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20733
> https://issues.apache.org/jira/browse/AMBARI-20733
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> kerberos statuses making call on every status command with fresh ticket 
> cache. Ignoring this check for now because it does not do anything for now 
> and need to be reimplemented in something more reliable.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 75880c6 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> a67e16e 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py ab46f96 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
> 8e5e9a3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 5fa9ec4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java
>  5591ae8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  8cd2804 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  01fbce2 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  7073de6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  3c62243 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  6d1dbc5 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  c4960a7 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  d2c8089 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  226e7fd5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  77820cc 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  924eea4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  4dabdbc 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9448fa6 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  1347f37 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  7ba1f96 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  0f1f438 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  be0d2ed 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/datanode.py
>  130c021 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_client.py
>  4dabdbc 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/journalnode.py
>  9448fa6 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
>  602dad7 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/nfsgateway.py
>  7ba1f96 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/snamenode.py
>  0f1f438 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
>  19a78c7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8b69e45 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  f6251e7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  46864c0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  93fa411 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_metastore.py
>  8b69e45 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server.py
>  f6251e7 
>   
> ambari-server/src/main/resources/common-servic

Re: Review Request 58429: After pam setup- Hive View user home test fails

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/
---

(Updated April 13, 2017, 6:45 p.m.)


Review request for Ambari, Attila Doroszlai, Henning Kropp, and Robert Levas.


Bugs: AMBARI-20760
https://issues.apache.org/jira/browse/AMBARI-20760


Repository: ambari


Description
---

After setting up PAM, tried to login as PAM user and access hive view, user 
home test fails with the error as in screen shot.

This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was 
not incorporated in the code. Pasting the comment from Henning below.

Something we noticed is that in a secured cluster we have issues with the 
views, getting the following exception for the Hive view as an example:

Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS, 
infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to validate 
proxy privilege of ambari for 
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
.
sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege of 
ambari for 
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
 serverProtocolVersion:null)

As you can see it tries to impersonte 
"org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
 Changing the UsernamePasswordAuthenticationToken from Principal to username 
fixes this.

So instead of :

UsernamePasswordAuthenticationToken token = new 
UsernamePasswordAuthenticationToken(principal, null, userAuthorities);

We use:

UsernamePasswordAuthenticationToken token = new 
UsernamePasswordAuthenticationToken(user.getUserName(), null, userAuthorities);

What could potential also work is, overriding toString of the principal like:

Principal principal = new Principal() {
@Override
public String getName()
{ return user.getUserName(); }

@Override
public String toString()
{ return user.getUserName().toString(); }

};

We did not test this!


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 ca7cd31 


Diff: https://reviews.apache.org/r/58429/diff/1/


Testing
---

Ran mvn test and also manually tested the scenario


File Attachments


error screenshot
  
https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG


Thanks,

Anita Jebaraj

Re: Review Request 58429: After pam setup- Hive View user home test fails

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/
---

(Updated April 13, 2017, 6:45 p.m.)


Review request for Ambari, Attila Doroszlai, Henning Kropp, and Robert Levas.


Bugs: AMBARI-20760
https://issues.apache.org/jira/browse/AMBARI-20760


Repository: ambari


Description
---

After setting up PAM, tried to login as PAM user and access hive view, user 
home test fails with the error as in screen shot.

This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was 
not incorporated in the code. Pasting the comment from Henning below.

Something we noticed is that in a secured cluster we have issues with the 
views, getting the following exception for the Hive view as an example:

Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS, 
infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to validate 
proxy privilege of ambari for 
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
.
sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege of 
ambari for 
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
 serverProtocolVersion:null)

As you can see it tries to impersonte 
"org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
 Changing the UsernamePasswordAuthenticationToken from Principal to username 
fixes this.

So instead of :

UsernamePasswordAuthenticationToken token = new 
UsernamePasswordAuthenticationToken(principal, null, userAuthorities);

We use:

UsernamePasswordAuthenticationToken token = new 
UsernamePasswordAuthenticationToken(user.getUserName(), null, userAuthorities);

What could potential also work is, overriding toString of the principal like:

Principal principal = new Principal() {
@Override
public String getName()
{ return user.getUserName(); }

@Override
public String toString()
{ return user.getUserName().toString(); }

};

We did not test this!


Testing
---

Ran mvn test and also manually tested the scenario


File Attachments (updated)


error screenshot
  
https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG


Thanks,

Anita Jebaraj

Review Request 58429: After pam setup- Hive View user home test fails

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/
---

Review request for Ambari, Attila Doroszlai, Henning Kropp, and Robert Levas.


Bugs: AMBARI-20760
https://issues.apache.org/jira/browse/AMBARI-20760


Repository: ambari


Description
---

After setting up PAM, tried to login as PAM user and access hive view, user 
home test fails with the error as in screen shot.

This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was 
not incorporated in the code. Pasting the comment from Henning below.

Something we noticed is that in a secured cluster we have issues with the 
views, getting the following exception for the Hive view as an example:

Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS, 
infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to validate 
proxy privilege of ambari for 
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
.
sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege of 
ambari for 
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
 serverProtocolVersion:null)

As you can see it tries to impersonte 
"org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
 Changing the UsernamePasswordAuthenticationToken from Principal to username 
fixes this.

So instead of :

UsernamePasswordAuthenticationToken token = new 
UsernamePasswordAuthenticationToken(principal, null, userAuthorities);

We use:

UsernamePasswordAuthenticationToken token = new 
UsernamePasswordAuthenticationToken(user.getUserName(), null, userAuthorities);

What could potential also work is, overriding toString of the principal like:

Principal principal = new Principal() {
@Override
public String getName()
{ return user.getUserName(); }

@Override
public String toString()
{ return user.getUserName().toString(); }

};

We did not test this!


Testing
---

Ran mvn test and also manually tested the scenario


Thanks,

Anita Jebaraj

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58415/#review171869
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
Lines 127-129 (patched)


This is in the wrong place in the Java file.


- Robert Levas


On April 13, 2017, 11:33 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58415/
> ---
> 
> (Updated April 13, 2017, 11:33 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20755
> https://issues.apache.org/jira/browse/AMBARI-20755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> Configuration types posted in the blueprint or in the cluster creation 
> template need to be validated before the cluster provisioning is started and 
> cluster resources are persisted in the database.
> This validation should be done when the topology configuration comes together 
> so that it's not modified and enhanced further.
> Currently the topology configuration is modified after the validation thus on 
> blueprint deployments the cluster provisioning may fail despite of the right 
> configuration.
> 
> Notes:
> - due to the nature of the topology validation, the validation logic and 
> management of the validators have been extracted to a specialized service 
> (before validators were attached to requests and the validation happened in 
> the constructor)
> - some unit test cases became unecessary due to the above change, i removed 
> them (and added other unit tests)
> - there are some formatting related hunks in the diff (i added them by 
> mistake)
> 
> The validators have been modified (as per internal discussions and test 
> results)
> - configuration types are considered invalid if they are not in the stack ( 
> regardless the services being deployed)
> - the hive database related validation checks for the mysql server in the 
> list of components, not in the list of services
> 
> The patch is a draft, i am still massaging  it (adding comments, cleaning 
> etc...)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
>  f24c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  1a14b01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  b5d2f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
>  e37c68d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  37fb7d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
>  2ac9950 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  392a53e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java
>  cbc6642 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ChainedTopologyValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
>  1351739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredPasswordValidator.java
>  591a124 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorService.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  dba4043 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  73a80f6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
>  48d1351 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  a691cbc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  98ba592 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  fc7ac27 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
>  3ea17b4 

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58423/#review171909
---


Ship it!




Ship It!

- Di Li


On April 13, 2017, 6:19 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58423/
> ---
> 
> (Updated April 13, 2017, 6:19 p.m.)
> 
> 
> Review request for Ambari, Di Li and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20757
> https://issues.apache.org/jira/browse/AMBARI-20757
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In order to see what has gone wrong, you need to drill down into the last 
> step until you find the service check that failed. Ideally there would be a 
> message above where they normally appear.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 4513775 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
> f6be5d1 
> 
> 
> Diff: https://reviews.apache.org/r/58423/diff/3/
> 
> 
> Testing
> ---
> 
> This was tested manually while testing upgrade.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58423/#review171908
---


Ship it!




Ship It!

- Sangeeta Ravindran


On April 13, 2017, 6:19 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58423/
> ---
> 
> (Updated April 13, 2017, 6:19 p.m.)
> 
> 
> Review request for Ambari, Di Li and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20757
> https://issues.apache.org/jira/browse/AMBARI-20757
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In order to see what has gone wrong, you need to drill down into the last 
> step until you find the service check that failed. Ideally there would be a 
> message above where they normally appear.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 4513775 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
> f6be5d1 
> 
> 
> Diff: https://reviews.apache.org/r/58423/diff/3/
> 
> 
> Testing
> ---
> 
> This was tested manually while testing upgrade.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58423/
---

(Updated April 13, 2017, 6:19 p.m.)


Review request for Ambari, Di Li and Sangeeta Ravindran.


Bugs: AMBARI-20757
https://issues.apache.org/jira/browse/AMBARI-20757


Repository: ambari


Description
---

In order to see what has gone wrong, you need to drill down into the last step 
until you find the service check that failed. Ideally there would be a message 
above where they normally appear.


Diffs (updated)
-

  ambari-web/app/messages.js 4513775 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
f6be5d1 


Diff: https://reviews.apache.org/r/58423/diff/3/

Changes: https://reviews.apache.org/r/58423/diff/2-3/


Testing
---

This was tested manually while testing upgrade.


Thanks,

Tim Thorpe

Re: Review Request 57610: Tokenize kerberos principal name appearing in kerberos rules in exported blueprint

[Amruta Borkar]

> On April 10, 2017, 8:54 p.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 3042 (patched)
> > 
> >
> > Caching these properties is a good idea, but I think we should be able 
> > to handle multi clusters, so keep theese properties separatly for each 
> > cluster and ideally these should be cached only for the time of export, 
> > since next time the state of the cluster may change. We don't have such 
> > filters yet, may be we can cache theese props in a HashMap by clusterId, in 
> > ThreadLocal and an init method to PropertyFilter where we can reset this 
> > map prior beginning the export.

Hello Sandor,
I modififed the patch to address this problem, could you please review it?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57610/#review171474
---


On April 13, 2017, 6:09 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57610/
> ---
> 
> (Updated April 13, 2017, 6:09 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Levas, Robert Nettleton, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-20366
> https://issues.apache.org/jira/browse/AMBARI-20366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If blueprint is exported from a kerberos enabled cluster Kerberos rules 
> export principal names which contain cluster name and Realm, this exports 
> existing cluster name and realm name as tokens and replaces those tokens with 
> new values of cluster name and realm during successive cluster deployments.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  bb771a54a6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java
>  13db5f8b56 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  dba40437ae 
> 
> 
> Diff: https://reviews.apache.org/r/57610/diff/3/
> 
> 
> Testing
> ---
> 
> Tested manually.
> Modified test cases.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 57610: Tokenize kerberos principal name appearing in kerberos rules in exported blueprint

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57610/
---

(Updated April 13, 2017, 6:09 p.m.)


Review request for Ambari, Di Li, Robert Levas, Robert Nettleton, and Sandor 
Magyari.


Bugs: AMBARI-20366
https://issues.apache.org/jira/browse/AMBARI-20366


Repository: ambari


Description
---

If blueprint is exported from a kerberos enabled cluster Kerberos rules export 
principal names which contain cluster name and Realm, this exports existing 
cluster name and realm name as tokens and replaces those tokens with new values 
of cluster name and realm during successive cluster deployments.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 bb771a54a6 
  
ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java
 13db5f8b56 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 dba40437ae 


Diff: https://reviews.apache.org/r/57610/diff/3/

Changes: https://reviews.apache.org/r/57610/diff/2-3/


Testing
---

Tested manually.
Modified test cases.


Thanks,

Amruta Borkar

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58423/
---

(Updated April 13, 2017, 6:07 p.m.)


Review request for Ambari, Di Li and Sangeeta Ravindran.


Bugs: AMBARI-20757
https://issues.apache.org/jira/browse/AMBARI-20757


Repository: ambari


Description
---

In order to see what has gone wrong, you need to drill down into the last step 
until you find the service check that failed. Ideally there would be a message 
above where they normally appear.


Diffs (updated)
-

  ambari-web/app/messages.js 4513775 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
f6be5d1 


Diff: https://reviews.apache.org/r/58423/diff/2/

Changes: https://reviews.apache.org/r/58423/diff/1-2/


Testing
---

This was tested manually while testing upgrade.


Thanks,

Tim Thorpe

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

[Sid Wagle]

> On April 13, 2017, 5:31 p.m., Aravindan Vijayan wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
> > Line 153 (original), 157 (patched)
> > 
> >
> > Is this needed after this change? 
> > 
> > How do we handle the case where the local monitor is down on some host, 
> > and part of the metrics will need to be aggregated at the collecor side and 
> > part of them have already been aggregated and written to 
> > METRIC_RECORD_MINUTE?

Lets handle this as a mode of operation. If monitor aggregation is enabled we 
do not do collector side 5 minute aggregation. If monitor is down we do not get 
metrics from that host. Lets add an enhancement Jira to handle situation where 
daemon metrics from a host are available per minute but aggregates are not, fo 
this scenario run a the aggregator with subset of metrics. This could be based 
on liveliness check of a monitor. More like a heartbeat ping. When we loose 
ping for > 1 min < 5 min we can aggregate metrics for that time period and 
hostId.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58424/#review171905
---


On April 13, 2017, 4:54 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58424/
> ---
> 
> (Updated April 13, 2017, 4:54 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-20758
> https://issues.apache.org/jira/browse/AMBARI-20758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Abstract Sink checks if there is local known monitor port available to write 
> (e.g.: 61888)
> Handshake / Ping to make sure its the monitor and is accepting writes
> Start sending metrics only to the monitor
> Monitor sends metrics at the global send interval (1 minute) with all the 
> granularity of the sink
> Monitor aggregates first interval (5 min) data and sends it every interval 
> seconds. (5 min)
> The monitor interface look the same as that of collector (http server: maybe 
> Flask)
> Security concerns need to be addressed as well. (https/spnego?)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java
>  942c0b4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  bb2f0a9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetrcisManagerTest.java
>  8ee6d00 
>   ambari-metrics/ambari-metrics-assembly/pom.xml a4b87de 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 
> 99a41c3 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  46f32f9 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregationResult.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricClusterAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricHostAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/SingleValuedTimelineMetric.java
>  8ecca54 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java
>  44c9d4a 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetricWithAggregatedValues.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetrics.java
>  383079a 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
>  0bed7d0 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java
>  18d973c 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  3fdf3f4 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
>  bd4ae6a 
>   
> ambari-metrics/ambari-metric

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58424/#review171905
---




ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
Line 153 (original), 157 (patched)


Is this needed after this change? 

How do we handle the case where the local monitor is down on some host, and 
part of the metrics will need to be aggregated at the collecor side and part of 
them have already been aggregated and written to METRIC_RECORD_MINUTE?


- Aravindan Vijayan


On April 13, 2017, 4:54 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58424/
> ---
> 
> (Updated April 13, 2017, 4:54 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-20758
> https://issues.apache.org/jira/browse/AMBARI-20758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Abstract Sink checks if there is local known monitor port available to write 
> (e.g.: 61888)
> Handshake / Ping to make sure its the monitor and is accepting writes
> Start sending metrics only to the monitor
> Monitor sends metrics at the global send interval (1 minute) with all the 
> granularity of the sink
> Monitor aggregates first interval (5 min) data and sends it every interval 
> seconds. (5 min)
> The monitor interface look the same as that of collector (http server: maybe 
> Flask)
> Security concerns need to be addressed as well. (https/spnego?)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java
>  942c0b4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  bb2f0a9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetrcisManagerTest.java
>  8ee6d00 
>   ambari-metrics/ambari-metrics-assembly/pom.xml a4b87de 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 
> 99a41c3 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  46f32f9 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregationResult.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricClusterAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricHostAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/SingleValuedTimelineMetric.java
>  8ecca54 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java
>  44c9d4a 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetricWithAggregatedValues.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetrics.java
>  383079a 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
>  0bed7d0 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java
>  18d973c 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  3fdf3f4 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
>  bd4ae6a 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  a112ef2 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  5777639 
>   ambari-metrics/ambari-metrics-host-aggregator/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
>  c0feed5 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58424/#review171904
---




ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
Line 498 (original), 498 (patched)


Yes I agree. 'localhost' can be the default first option added to the set 
of configured hosts.


- Aravindan Vijayan


On April 13, 2017, 4:54 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58424/
> ---
> 
> (Updated April 13, 2017, 4:54 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-20758
> https://issues.apache.org/jira/browse/AMBARI-20758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Abstract Sink checks if there is local known monitor port available to write 
> (e.g.: 61888)
> Handshake / Ping to make sure its the monitor and is accepting writes
> Start sending metrics only to the monitor
> Monitor sends metrics at the global send interval (1 minute) with all the 
> granularity of the sink
> Monitor aggregates first interval (5 min) data and sends it every interval 
> seconds. (5 min)
> The monitor interface look the same as that of collector (http server: maybe 
> Flask)
> Security concerns need to be addressed as well. (https/spnego?)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java
>  942c0b4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  bb2f0a9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetrcisManagerTest.java
>  8ee6d00 
>   ambari-metrics/ambari-metrics-assembly/pom.xml a4b87de 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 
> 99a41c3 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  46f32f9 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregationResult.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricClusterAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricHostAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/SingleValuedTimelineMetric.java
>  8ecca54 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java
>  44c9d4a 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetricWithAggregatedValues.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetrics.java
>  383079a 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
>  0bed7d0 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java
>  18d973c 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  3fdf3f4 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
>  bd4ae6a 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  a112ef2 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  5777639 
>   ambari-metrics/ambari-metrics-host-aggregator/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
>  c0feed5 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
>  9d492cb 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  9a55f10 
>   
> ambari-metrics/ambari-metrics-storm-si

Re: Review Request 58425: Remove Server attribute from the HTTP response headers

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58425/#review171903
---


Ship it!




Ship It!

- Tim Thorpe


On April 13, 2017, 5:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58425/
> ---
> 
> (Updated April 13, 2017, 5:16 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20650
> https://issues.apache.org/jira/browse/AMBARI-20650
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the HTTP response header contains the Jetty version.
> Server:Jetty(8.1.19.v20160209)
> To follow best security practices, it would be good to avoid including this 
> information in the response headers.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  4e7af0c 
> 
> 
> Diff: https://reviews.apache.org/r/58425/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing. Verified that "Server" header is removed from the HTTP 
> response headers.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 58425: Remove Server attribute from the HTTP response headers

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58425/#review171902
---


Ship it!




Ship It!

- Di Li


On April 13, 2017, 5:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58425/
> ---
> 
> (Updated April 13, 2017, 5:16 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20650
> https://issues.apache.org/jira/browse/AMBARI-20650
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the HTTP response header contains the Jetty version.
> Server:Jetty(8.1.19.v20160209)
> To follow best security practices, it would be good to avoid including this 
> information in the response headers.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  4e7af0c 
> 
> 
> Diff: https://reviews.apache.org/r/58425/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing. Verified that "Server" header is removed from the HTTP 
> response headers.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Review Request 58425: Remove Server attribute from the HTTP response headers

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58425/
---

Review request for Ambari, Di Li, Robert Levas, and Tim Thorpe.


Bugs: AMBARI-20650
https://issues.apache.org/jira/browse/AMBARI-20650


Repository: ambari


Description
---

Currently the HTTP response header contains the Jetty version.
Server:Jetty(8.1.19.v20160209)
To follow best security practices, it would be good to avoid including this 
information in the response headers.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 4e7af0c 


Diff: https://reviews.apache.org/r/58425/diff/1/


Testing
---

Manual Testing. Verified that "Server" header is removed from the HTTP response 
headers.


Thanks,

Sangeeta Ravindran

Review Request 58426: AMBARI-19149. Code cleanup: unresolved references in javadoc

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58426/
---

Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor 
Magyari, and Sebastian Toader.


Bugs: AMBARI-19149
https://issues.apache.org/jira/browse/AMBARI-19149


Repository: ambari


Description
---

Code changes sometimes leave dangling references in Javadoc comments.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
a46e6a2edc6357efa65620c3827b4075f0514978 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
 43c484c13f730d244b56c8a9ac11d707103e2292 
  
ambari-server/src/main/java/org/apache/ambari/server/api/query/JpaSortBuilder.java
 6d769457d45695557f3b66612db8dae1b77caf37 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RequestScheduleResourceDefinition.java
 6de5e25bbd384e30f5d9c0273161447467338885 
  
ambari-server/src/main/java/org/apache/ambari/server/api/rest/BootStrapResource.java
 4aad5305339a85773d00dd4b421d9a606c0c62a8 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java
 d3f88ec5c71fecf9e76233bb3249dd36559ebdeb 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 05f3e91c25018096ed0df17a9b3c81edc00c9310 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 6f592f0db56c43626404b301b8cfd4bac6b10224 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 27ac03e4932a743b1c64828429a2928dd5df855c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 511c8fb41f129024d5019284359ad0b22c77514b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 352aa2d3eb25b13b8a578e73310240a293c17ae5 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionDisabledEvent.java
 a3c6e6861dc6ec5d1ade21ad897ab56d42cc5dc6 
  
ambari-server/src/main/java/org/apache/ambari/server/events/jpa/EntityManagerCacheInvalidationEvent.java
 fe472b2f8997eb4d6d68e7cd37929c3bf3127460 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
 907e4d82306a4a3edc319c4a5166b80f951a50a0 
  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
ae07dc0f6fb1360ece3a896e3d86111c7d7a205c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionDAO.java 
6c6c3aed977a2fa5251b59b08a561c321f560956 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java
 e860c6470b44b2bd6f9005b2aaf142fca85a51da 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
5d53416035ffecb11dcda2082df3a4207be402e9 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
 63374877ee8cfdb7e16a2f88306588fec4a79f6d 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
 bea1d1900552f4338821bb38c4aea20b0c6284d8 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeGroupEntity.java
 4830e3b11bd955c38afe27f50491889b4fcaf26c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewURLEntity.java
 27cb8e286531e957e2c238c987d8e3d1de09ebd6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java
 c2778d38fcace9eea82df890844b7db2bdc68d83 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java
 e06d8f24a60c662a839c69fba9ea2e569b654e2d 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
dfe70728cd83070408e1e0d117b32c83c77b470a 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
c9619954923ea573a9d97e4178a6721860258bbf 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
543dadd3f9a4aebb80327be6c3c76eb924602f6a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java
 616bcdbf0ebc0ea25e86f472be55240b9e5293b7 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 b7cc4cd7bfcbe14803514753f7eed8d0dfa009c2 
  
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupFactory.java
 906d9483c598a51895f5118f12fa2f9b2ca7e125 
  
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
 89a03aa4d27e2e3a3e1197d9d7c1c43b746f9799 
  
ambari-server/src/main/java/org/apache/ambari/server/state/fsm/StateMachineFactory.java
 cc57f2c0d0ba6021f0c30a10fa8bb126f1a2d88d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 69399d6c140c2490b44b1e58a9a160513206bcdb 
  
ambari-server/src/

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58424/#review171899
---




ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
Line 498 (original), 498 (patched)


This should be conditional based on whether monitor is available.



ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py
Lines 12 (patched)


java_home should be puicked from env variable.



ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py
Lines 18 (patched)


Can the kill have a timeout? So we have kill handler trying to flush for 2 
secs before kill -9?



contrib/views/pig/src/main/java/org/apache/ambari/AggregatorWebService.java
Lines 1 (patched)


Why is this test code in contrib/views?


- Sid Wagle


On April 13, 2017, 4:54 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58424/
> ---
> 
> (Updated April 13, 2017, 4:54 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-20758
> https://issues.apache.org/jira/browse/AMBARI-20758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Abstract Sink checks if there is local known monitor port available to write 
> (e.g.: 61888)
> Handshake / Ping to make sure its the monitor and is accepting writes
> Start sending metrics only to the monitor
> Monitor sends metrics at the global send interval (1 minute) with all the 
> granularity of the sink
> Monitor aggregates first interval (5 min) data and sends it every interval 
> seconds. (5 min)
> The monitor interface look the same as that of collector (http server: maybe 
> Flask)
> Security concerns need to be addressed as well. (https/spnego?)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java
>  942c0b4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  bb2f0a9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetrcisManagerTest.java
>  8ee6d00 
>   ambari-metrics/ambari-metrics-assembly/pom.xml a4b87de 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 
> 99a41c3 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  46f32f9 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregationResult.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricClusterAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricHostAggregate.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/SingleValuedTimelineMetric.java
>  8ecca54 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java
>  44c9d4a 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetricWithAggregatedValues.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetrics.java
>  383079a 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
>  0bed7d0 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java
>  18d973c 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  3fdf3f4 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
>  bd4ae6a 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  a112ef2 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  5777639 
>

Re: Review Request 58371: AMBARI-20737 Able to hide the Use Public Repository option on Register Version page on Ambari Admin View

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58371/#review171898
---


Ship it!




Ship It!

- Sangeeta Ravindran


On April 11, 2017, 9:26 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58371/
> ---
> 
> (Updated April 11, 2017, 9:26 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sangeeta Ravindran, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20737
> https://issues.apache.org/jira/browse/AMBARI-20737
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Register Version UI page on Ambari Admin View shows two options related 
> to adding repo URLs: Use Public Repository and Use Local Repository.
> The Use Public Repository is disabled when no stack repos are marked as 
> "stack_default=false" ( meaning it;s from the stack/repo URL defined in the 
> "latest" section in the repoinfo.xml)
> When repoinfo.xml does not have the latest section, however, the Use Public 
> Repository should be hidden from the view as it'd be definitely no 
> non-default stacks, and the "Why is this disabled ?" explanation does not 
> make sense in this case.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  b3c27dc 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> e028906 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  3bee2a1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  352aa2d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  507c560 
> 
> 
> Diff: https://reviews.apache.org/r/58371/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests
> patched a trunk cluster with the change, when all repoinfo.xml from all 
> stacks do not have the "latest" section, the Use Public Repository radio 
> button is hidden. When at least one repoinfo.xml has the "latest" section, 
> the Use Public Repository radio button is shown.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 58424: Aggregate local metrics for minute aggregation time window

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58424/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-20758
https://issues.apache.org/jira/browse/AMBARI-20758


Repository: ambari


Description
---

Abstract Sink checks if there is local known monitor port available to write 
(e.g.: 61888)
Handshake / Ping to make sure its the monitor and is accepting writes
Start sending metrics only to the monitor
Monitor sends metrics at the global send interval (1 minute) with all the 
granularity of the sink
Monitor aggregates first interval (5 min) data and sends it every interval 
seconds. (5 min)
The monitor interface look the same as that of collector (http server: maybe 
Flask)
Security concerns need to be addressed as well. (https/spnego?)


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java
 942c0b4 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
 bb2f0a9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetrcisManagerTest.java
 8ee6d00 
  ambari-metrics/ambari-metrics-assembly/pom.xml a4b87de 
  ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 99a41c3 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 46f32f9 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregationResult.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricAggregate.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricClusterAggregate.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/MetricHostAggregate.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/SingleValuedTimelineMetric.java
 8ecca54 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java
 44c9d4a 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetricWithAggregatedValues.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetrics.java
 383079a 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
 0bed7d0 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java
 18d973c 
  
ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
 3fdf3f4 
  
ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
 bd4ae6a 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 a112ef2 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 5777639 
  ambari-metrics/ambari-metrics-host-aggregator/pom.xml PRE-CREATION 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
 c0feed5 
  
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
 9d492cb 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 9a55f10 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 60c1427 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 535fae0 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 f58f549 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 17c58f0 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 8b0d84b 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricSt

Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58423/
---

Review request for Ambari, Di Li and Sangeeta Ravindran.


Bugs: AMBARI-20757
https://issues.apache.org/jira/browse/AMBARI-20757


Repository: ambari


Description
---

In order to see what has gone wrong, you need to drill down into the last step 
until you find the service check that failed. Ideally there would be a message 
above where they normally appear.


Diffs
-

  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
a86048e 


Diff: https://reviews.apache.org/r/58423/diff/1/


Testing
---

This was tested manually while testing upgrade.


Thanks,

Tim Thorpe

Re: Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58152/#review171893
---


Ship it!




Ship It!

- Di Li


On April 13, 2017, 4:20 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58152/
> ---
> 
> (Updated April 13, 2017, 4:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20666
> https://issues.apache.org/jira/browse/AMBARI-20666
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In order to avoid issues with starting and stopping services, it would be 
> useful to trim any commas from the beginning or ending of the user and group 
> lists
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
>  4d0de7f 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/shared_initialization.py
>  320872e 
> 
> 
> Diff: https://reviews.apache.org/r/58152/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Also ran manual testing including running the code as a separate script:
> 
> import re
> 
> user_and_groups = ",users, group1,group2,"
> parts = re.split('\s', user_and_groups)
> if len(parts) == 1:
>   parts.append("")
> 
> users_list = parts[0].strip(",").split(",") if parts[0] else []
> groups_list = parts[1].strip(",").split(",") if parts[1] else []
> 
> print users_list
> print groups_list
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 58322: Small fixes in Log Search

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58322/
---

(Updated April 13, 2017, 4:23 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

add propert url for log4j.dtd in the log4j properties too + upgrade


Bugs: AMBARI-20727
https://issues.apache.org/jira/browse/AMBARI-20727


Repository: ambari


Description
---

Remove some unused codes, suppress some warnings with annotations, fix generics.


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-appender/pom.xml e14d576 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchApiSteps.java
 bcfc4db 
  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 5d6f8b6 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 
8a3d26d 
  ambari-logsearch/ambari-logsearch-server/pom.xml b505c12 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java
 d5e807b 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java
 124ce40 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java
 27a6705 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
 25e3271 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
 6b40cb5 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 9ce209b 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchAuthSuccessHandler.java
 cf9d200 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKrbFilter.java
 f4e70d7 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/model/JWTAuthenticationToken.java
 35175b6 
  ambari-logsearch/ambari-logsearch-server/src/main/resources/log4j.xml 547841a 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
 8a4afe9 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-log4j.xml.j2
 a818fe0 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-log4j.xml.j2
 63f9f0a 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
 fec041c 


Diff: https://reviews.apache.org/r/58322/diff/2/

Changes: https://reviews.apache.org/r/58322/diff/1-2/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58152/
---

(Updated April 13, 2017, 4:20 p.m.)


Review request for Ambari, Alejandro Fernandez and Di Li.


Changes
---

Fix for both 2.0.6 and 3.0 hooks


Bugs: AMBARI-20666
https://issues.apache.org/jira/browse/AMBARI-20666


Repository: ambari


Description
---

In order to avoid issues with starting and stopping services, it would be 
useful to trim any commas from the beginning or ending of the user and group 
lists


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
 4d0de7f 
  
ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/shared_initialization.py
 320872e 


Diff: https://reviews.apache.org/r/58152/diff/2/

Changes: https://reviews.apache.org/r/58152/diff/1-2/


Testing
---

mvn clean test

Also ran manual testing including running the code as a separate script:

import re

user_and_groups = ",users, group1,group2,"
parts = re.split('\s', user_and_groups)
if len(parts) == 1:
  parts.append("")

users_list = parts[0].strip(",").split(",") if parts[0] else []
groups_list = parts[1].strip(",").split(",") if parts[1] else []

print users_list
print groups_list


Thanks,

Tim Thorpe

Re: Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58152/#review171891
---


Ship it!




Might want to apply the same change to 
`ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py`.

- Attila Doroszlai


On April 13, 2017, 5:21 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58152/
> ---
> 
> (Updated April 13, 2017, 5:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20666
> https://issues.apache.org/jira/browse/AMBARI-20666
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In order to avoid issues with starting and stopping services, it would be 
> useful to trim any commas from the beginning or ending of the user and group 
> lists
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/shared_initialization.py
>  320872e 
> 
> 
> Diff: https://reviews.apache.org/r/58152/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Also ran manual testing including running the code as a separate script:
> 
> import re
> 
> user_and_groups = ",users, group1,group2,"
> parts = re.split('\s', user_and_groups)
> if len(parts) == 1:
>   parts.append("")
> 
> users_list = parts[0].strip(",").split(",") if parts[0] else []
> groups_list = parts[1].strip(",").split(",") if parts[1] else []
> 
> print users_list
> print groups_list
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 58420: AMBARI-20746 Change to warning log if Ambari doesn't have baseurls for Install Packages step before EU/RU

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58420/#review171889
---


Ship it!




Ship It!

- Tim Thorpe


On April 13, 2017, 3:59 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58420/
> ---
> 
> (Updated April 13, 2017, 3:59 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20746
> https://issues.apache.org/jira/browse/AMBARI-20746
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change to warning log if Ambari doesn't have baseurls for Install Packages 
> step before EU/RU. It currently prints out as an INFO that can be easily 
> ignored. Since we don't fail the Install Packages step when the baseurls are 
> empty, we should at least change the logging level to warning.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  92e72ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  8f2d4e6 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 112abe3 
> 
> 
> Diff: https://reviews.apache.org/r/58420/diff/2/
> 
> 
> Testing
> ---
> 
> patch a trunk cluster with the change, run Install step before the EU/RU
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58415/#review171888
---


Ship it!




Ship It!

- Attila Doroszlai


On April 13, 2017, 5:33 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58415/
> ---
> 
> (Updated April 13, 2017, 5:33 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20755
> https://issues.apache.org/jira/browse/AMBARI-20755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> Configuration types posted in the blueprint or in the cluster creation 
> template need to be validated before the cluster provisioning is started and 
> cluster resources are persisted in the database.
> This validation should be done when the topology configuration comes together 
> so that it's not modified and enhanced further.
> Currently the topology configuration is modified after the validation thus on 
> blueprint deployments the cluster provisioning may fail despite of the right 
> configuration.
> 
> Notes:
> - due to the nature of the topology validation, the validation logic and 
> management of the validators have been extracted to a specialized service 
> (before validators were attached to requests and the validation happened in 
> the constructor)
> - some unit test cases became unecessary due to the above change, i removed 
> them (and added other unit tests)
> - there are some formatting related hunks in the diff (i added them by 
> mistake)
> 
> The validators have been modified (as per internal discussions and test 
> results)
> - configuration types are considered invalid if they are not in the stack ( 
> regardless the services being deployed)
> - the hive database related validation checks for the mysql server in the 
> list of components, not in the list of services
> 
> The patch is a draft, i am still massaging  it (adding comments, cleaning 
> etc...)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
>  f24c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  1a14b01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  b5d2f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
>  e37c68d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  37fb7d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
>  2ac9950 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  392a53e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java
>  cbc6642 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ChainedTopologyValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
>  1351739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredPasswordValidator.java
>  591a124 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorService.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  dba4043 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  73a80f6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
>  48d1351 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  a691cbc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  98ba592 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  fc7ac27 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
>  3ea17b4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/RequiredPasswordValidatorTest.java
>  4c88247 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  2d5978b 
>   
> amb

Re: Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58152/#review171887
---


Ship it!




Ship It!

- Di Li


On April 13, 2017, 3:21 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58152/
> ---
> 
> (Updated April 13, 2017, 3:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20666
> https://issues.apache.org/jira/browse/AMBARI-20666
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In order to avoid issues with starting and stopping services, it would be 
> useful to trim any commas from the beginning or ending of the user and group 
> lists
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/shared_initialization.py
>  320872e 
> 
> 
> Diff: https://reviews.apache.org/r/58152/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Also ran manual testing including running the code as a separate script:
> 
> import re
> 
> user_and_groups = ",users, group1,group2,"
> parts = re.split('\s', user_and_groups)
> if len(parts) == 1:
>   parts.append("")
> 
> users_list = parts[0].strip(",").split(",") if parts[0] else []
> groups_list = parts[1].strip(",").split(",") if parts[1] else []
> 
> print users_list
> print groups_list
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 58420: AMBARI-20746 Change to warning log if Ambari doesn't have baseurls for Install Packages step before EU/RU

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58420/
---

(Updated April 13, 2017, 3:59 p.m.)


Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-20746
https://issues.apache.org/jira/browse/AMBARI-20746


Repository: ambari


Description
---

Change to warning log if Ambari doesn't have baseurls for Install Packages step 
before EU/RU. It currently prints out as an INFO that can be easily ignored. 
Since we don't fail the Install Packages step when the baseurls are empty, we 
should at least change the logging level to warning.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 92e72ed 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
 8f2d4e6 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
112abe3 


Diff: https://reviews.apache.org/r/58420/diff/2/

Changes: https://reviews.apache.org/r/58420/diff/1-2/


Testing
---

patch a trunk cluster with the change, run Install step before the EU/RU


Thanks,

Di Li

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58356/#review171884
---


Ship it!




Ship It!

- Jaimin Jetly


On April 13, 2017, 3:44 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58356/
> ---
> 
> (Updated April 13, 2017, 3:44 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
> Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20735
> https://issues.apache.org/jira/browse/AMBARI-20735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created checkstyle check to ensure either @ApiOperation or @ApiIgnore is 
> present on all REST API methods
> 
> 
> Diffs
> -
> 
>   ambari-server/checkstyle.xml bf7698760ac8ddba1d692bcd448c19d939dc 
>   ambari-server/pom.xml fbc2b9fd129dca0828624fe76e33616b6919f429 
>   ambari-server/src/main/assemblies/server.xml 
> 27835265f78a3a7aed37eaa544e25679eee8b400 
>   utility/checkstyle.xml PRE-CREATION 
>   utility/pom.xml 6f602068ca863fd99d537b88462487d9f28e9c6d 
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java 
> PRE-CREATION 
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>  PRE-CREATION 
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>  14d74867b81d58a35e732940ccb16f02d4e9b317 
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>  PRE-CREATION 
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58356/diff/2/
> 
> 
> Testing
> ---
> 
> Includes unit test for the new check.
> Also ran the check on ambari-server: produces 315 errors.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58356/#review171882
---


Ship it!




Ship It!

- Sebastian Toader


On April 13, 2017, 5:44 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58356/
> ---
> 
> (Updated April 13, 2017, 5:44 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
> Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20735
> https://issues.apache.org/jira/browse/AMBARI-20735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created checkstyle check to ensure either @ApiOperation or @ApiIgnore is 
> present on all REST API methods
> 
> 
> Diffs
> -
> 
>   ambari-server/checkstyle.xml bf7698760ac8ddba1d692bcd448c19d939dc 
>   ambari-server/pom.xml fbc2b9fd129dca0828624fe76e33616b6919f429 
>   ambari-server/src/main/assemblies/server.xml 
> 27835265f78a3a7aed37eaa544e25679eee8b400 
>   utility/checkstyle.xml PRE-CREATION 
>   utility/pom.xml 6f602068ca863fd99d537b88462487d9f28e9c6d 
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java 
> PRE-CREATION 
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>  PRE-CREATION 
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>  14d74867b81d58a35e732940ccb16f02d4e9b317 
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>  PRE-CREATION 
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58356/diff/2/
> 
> 
> Testing
> ---
> 
> Includes unit test for the new check.
> Also ran the check on ambari-server: produces 315 errors.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58356/
---

(Updated April 13, 2017, 5:44 p.m.)


Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
Oliver Szabo, Sumit Mohanty, and Sebastian Toader.


Changes
---

* Use `ImmutableSet.of` as suggested
* Remove unused imports
* Apply style checks to `utility` module


Bugs: AMBARI-20735
https://issues.apache.org/jira/browse/AMBARI-20735


Repository: ambari


Description
---

Created checkstyle check to ensure either @ApiOperation or @ApiIgnore is 
present on all REST API methods


Diffs (updated)
-

  ambari-server/checkstyle.xml bf7698760ac8ddba1d692bcd448c19d939dc 
  ambari-server/pom.xml fbc2b9fd129dca0828624fe76e33616b6919f429 
  ambari-server/src/main/assemblies/server.xml 
27835265f78a3a7aed37eaa544e25679eee8b400 
  utility/checkstyle.xml PRE-CREATION 
  utility/pom.xml 6f602068ca863fd99d537b88462487d9f28e9c6d 
  utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java 
PRE-CREATION 
  
utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
 PRE-CREATION 
  
utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
 14d74867b81d58a35e732940ccb16f02d4e9b317 
  
utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
 PRE-CREATION 
  
utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58356/diff/2/

Changes: https://reviews.apache.org/r/58356/diff/1-2/


Testing
---

Includes unit test for the new check.
Also ran the check on ambari-server: produces 315 errors.


Thanks,

Attila Doroszlai

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58415/
---

(Updated April 13, 2017, 3:33 p.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, Sandor Magyari, and 
Sebastian Toader.


Changes
---

Applied review notes.


Bugs: AMBARI-20755
https://issues.apache.org/jira/browse/AMBARI-20755


Repository: ambari


Description
---

Problem:
Configuration types posted in the blueprint or in the cluster creation template 
need to be validated before the cluster provisioning is started and cluster 
resources are persisted in the database.
This validation should be done when the topology configuration comes together 
so that it's not modified and enhanced further.
Currently the topology configuration is modified after the validation thus on 
blueprint deployments the cluster provisioning may fail despite of the right 
configuration.

Notes:
- due to the nature of the topology validation, the validation logic and 
management of the validators have been extracted to a specialized service 
(before validators were attached to requests and the validation happened in the 
constructor)
- some unit test cases became unecessary due to the above change, i removed 
them (and added other unit tests)
- there are some formatting related hunks in the diff (i added them by mistake)

The validators have been modified (as per internal discussions and test results)
- configuration types are considered invalid if they are not in the stack ( 
regardless the services being deployed)
- the hive database related validation checks for the mysql server in the list 
of components, not in the list of services

The patch is a draft, i am still massaging  it (adding comments, cleaning 
etc...)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
 f24c138 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 1a14b01 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
 b5d2f9d 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
 e37c68d 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
 37fb7d4 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
 2ac9950 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 392a53e 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java
 cbc6642 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ChainedTopologyValidator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
 1351739 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredPasswordValidator.java
 591a124 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorService.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 dba4043 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
 73a80f6 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
 48d1351 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
 a691cbc 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
 98ba592 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
 fc7ac27 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
 3ea17b4 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/RequiredPasswordValidatorTest.java
 4c88247 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 2d5978b 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
 745b01b 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58415/diff/2/

Changes: https://reviews.apache.org/r/58415/diff/1-2/


Testing
---

Unit tests ran against trunk. (some unrelatet pyhon tests failed though)
Manually tested on the local env. (Still need to do some testing)


Thanks,

Laszlo Puskas

Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58152/
---

Review request for Ambari, Alejandro Fernandez and Di Li.


Bugs: AMBARI-20666
https://issues.apache.org/jira/browse/AMBARI-20666


Repository: ambari


Description
---

In order to avoid issues with starting and stopping services, it would be 
useful to trim any commas from the beginning or ending of the user and group 
lists


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/shared_initialization.py
 320872e 


Diff: https://reviews.apache.org/r/58152/diff/1/


Testing
---

mvn clean test

Also ran manual testing including running the code as a separate script:

import re

user_and_groups = ",users, group1,group2,"
parts = re.split('\s', user_and_groups)
if len(parts) == 1:
  parts.append("")

users_list = parts[0].strip(",").split(",") if parts[0] else []
groups_list = parts[1].strip(",").split(",") if parts[1] else []

print users_list
print groups_list


Thanks,

Tim Thorpe

Review Request 58420: AMBARI-20746 Change to warning log if Ambari doesn't have baseurls for Install Packages step before EU/RU

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58420/
---

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-20746
https://issues.apache.org/jira/browse/AMBARI-20746


Repository: ambari


Description
---

Change to warning log if Ambari doesn't have baseurls for Install Packages step 
before EU/RU. It currently prints out as an INFO that can be easily ignored. 
Since we don't fail the Install Packages step when the baseurls are empty, we 
should at least change the logging level to warning.


Diffs
-

  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
112abe3 


Diff: https://reviews.apache.org/r/58420/diff/1/


Testing
---

patch a trunk cluster with the change, run Install step before the EU/RU


Thanks,

Di Li

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58415/#review171873
---




ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
Lines 41 (patched)


missing `<>`



ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
Lines 48-49 (patched)


missing <>



ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
Lines 51-56 (patched)


Can you please simplify this a bit?  Avoid the `retainAll` call, construct 
the `invalidConfigTypes` set (use `Sets.difference`), and check if it has any 
elements.



ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
Line 61 (original), 57 (patched)


unused import


- Attila Doroszlai


On April 13, 2017, 4:13 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58415/
> ---
> 
> (Updated April 13, 2017, 4:13 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20755
> https://issues.apache.org/jira/browse/AMBARI-20755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> Configuration types posted in the blueprint or in the cluster creation 
> template need to be validated before the cluster provisioning is started and 
> cluster resources are persisted in the database.
> This validation should be done when the topology configuration comes together 
> so that it's not modified and enhanced further.
> Currently the topology configuration is modified after the validation thus on 
> blueprint deployments the cluster provisioning may fail despite of the right 
> configuration.
> 
> Notes:
> - due to the nature of the topology validation, the validation logic and 
> management of the validators have been extracted to a specialized service 
> (before validators were attached to requests and the validation happened in 
> the constructor)
> - some unit test cases became unecessary due to the above change, i removed 
> them (and added other unit tests)
> - there are some formatting related hunks in the diff (i added them by 
> mistake)
> 
> The validators have been modified (as per internal discussions and test 
> results)
> - configuration types are considered invalid if they are not in the stack ( 
> regardless the services being deployed)
> - the hive database related validation checks for the mysql server in the 
> list of components, not in the list of services
> 
> The patch is a draft, i am still massaging  it (adding comments, cleaning 
> etc...)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
>  f24c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  1a14b01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  b5d2f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
>  e37c68d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  37fb7d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
>  2ac9950 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  392a53e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java
>  cbc6642 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ChainedTopologyValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
>  1351739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredPasswordValidator.java
>  591a124 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorService.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  dba4043 
>   
> ambari-server/src/test/j

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58356/#review171877
---




utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
Lines 36 (patched)


You could use here ImmutableSet.of()


- Sebastian Toader


On April 13, 2017, 3:48 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58356/
> ---
> 
> (Updated April 13, 2017, 3:48 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
> Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20735
> https://issues.apache.org/jira/browse/AMBARI-20735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created checkstyle check to ensure either @ApiOperation or @ApiIgnore is 
> present on all REST API methods
> 
> 
> Diffs
> -
> 
>   ambari-server/checkstyle.xml bf7698760ac8ddba1d692bcd448c19d939dc 
>   ambari-server/pom.xml fbc2b9fd129dca0828624fe76e33616b6919f429 
>   ambari-server/src/main/assemblies/server.xml 
> 27835265f78a3a7aed37eaa544e25679eee8b400 
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java 
> PRE-CREATION 
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>  PRE-CREATION 
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>  PRE-CREATION 
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58356/diff/1/
> 
> 
> Testing
> ---
> 
> Includes unit test for the new check.
> Also ran the check on ambari-server: produces 315 errors.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58415/
---

(Updated April 13, 2017, 2:13 p.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, Sandor Magyari, and 
Sebastian Toader.


Bugs: AMBARI-20755
https://issues.apache.org/jira/browse/AMBARI-20755


Repository: ambari


Description
---

Problem:
Configuration types posted in the blueprint or in the cluster creation template 
need to be validated before the cluster provisioning is started and cluster 
resources are persisted in the database.
This validation should be done when the topology configuration comes together 
so that it's not modified and enhanced further.
Currently the topology configuration is modified after the validation thus on 
blueprint deployments the cluster provisioning may fail despite of the right 
configuration.

Notes:
- due to the nature of the topology validation, the validation logic and 
management of the validators have been extracted to a specialized service 
(before validators were attached to requests and the validation happened in the 
constructor)
- some unit test cases became unecessary due to the above change, i removed 
them (and added other unit tests)
- there are some formatting related hunks in the diff (i added them by mistake)

The validators have been modified (as per internal discussions and test results)
- configuration types are considered invalid if they are not in the stack ( 
regardless the services being deployed)
- the hive database related validation checks for the mysql server in the list 
of components, not in the list of services

The patch is a draft, i am still massaging  it (adding comments, cleaning 
etc...)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
 f24c138 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 1a14b01 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
 b5d2f9d 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
 e37c68d 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
 37fb7d4 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
 2ac9950 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 392a53e 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java
 cbc6642 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ChainedTopologyValidator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
 1351739 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredPasswordValidator.java
 591a124 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorService.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 dba4043 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
 73a80f6 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
 48d1351 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
 a691cbc 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
 98ba592 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
 fc7ac27 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
 3ea17b4 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/RequiredPasswordValidatorTest.java
 4c88247 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 2d5978b 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
 745b01b 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58415/diff/1/


Testing
---

Unit tests ran against trunk. (some unrelatet pyhon tests failed though)
Manually tested on the local env. (Still need to do some testing)


Thanks,

Laszlo Puskas

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58208/#review171876
---


Ship it!




Ship It!

- Jonathan Hurley


On April 12, 2017, 8:57 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58208/
> ---
> 
> (Updated April 12, 2017, 8:57 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20682
> https://issues.apache.org/jira/browse/AMBARI-20682
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During a rolling upgrade (especially on a large, heavily used cluster), the 
> DataNodes do not shutdown immediately. However, they do de-register from the 
> NameNode which tricks Ambari into thinking that they are down.
> 
> Since the rolling upgrade uses a {{RESTART}} command, we attempt to start the 
> DataNode back up before the daemon has shutdown:
> 
> {code}
> 2017-03-14 05:00:25,602 - 
> call['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs hdfs://c1ha 
> -shutdownDatanode 0.0.0.0:8010 upgrade'] {'user': 'hdfs'}
> 2017-03-14 05:00:28,438 - call returned (0, 'Submitted a shutdown request to 
> datanode 0.0.0.0:8010')
> 2017-03-14 05:00:28,438 - 
> Execute['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs 
> hdfs://c1ha -D ipc.client.connect.max.retries=5 -D 
> ipc.client.connect.retry.interval=1000 -getDatanodeInfo 0.0.0.0:8010'] 
> {'tries': 1, 'user': 'hdfs'}
> 2017-03-14 05:00:35,976 - DataNode has successfully shutdown for upgrade.
> {code}
> 
> Even though ~ 6 seconds have passed, the daemon is still running as it 
> drains. Therefore, we attempt to start it which causes a NOOP.
> 
> Instead, we should also monitor for the PID.
> 
> -
> Now STOP command waits until component really dies. Motivation behind that 
> is: we don't want to execute START of still running component again (e.g. 
> during upgrade/RESTART)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 9a5da04 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_service.py
>  4716343 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  151e26c 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode_upgrade.py
>  b55237d 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/mysql_service.py
>  11bbdd8 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/postgresql_service.py
>  cc7b4cc 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 1c3c5b7 
> 
> 
> Diff: https://reviews.apache.org/r/58208/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test 
> and test on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58208/#review171874
---


Ship it!




Ship It!

- Nate Cole


On April 12, 2017, 8:57 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58208/
> ---
> 
> (Updated April 12, 2017, 8:57 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20682
> https://issues.apache.org/jira/browse/AMBARI-20682
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During a rolling upgrade (especially on a large, heavily used cluster), the 
> DataNodes do not shutdown immediately. However, they do de-register from the 
> NameNode which tricks Ambari into thinking that they are down.
> 
> Since the rolling upgrade uses a {{RESTART}} command, we attempt to start the 
> DataNode back up before the daemon has shutdown:
> 
> {code}
> 2017-03-14 05:00:25,602 - 
> call['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs hdfs://c1ha 
> -shutdownDatanode 0.0.0.0:8010 upgrade'] {'user': 'hdfs'}
> 2017-03-14 05:00:28,438 - call returned (0, 'Submitted a shutdown request to 
> datanode 0.0.0.0:8010')
> 2017-03-14 05:00:28,438 - 
> Execute['/usr/hdp/current/hadoop-hdfs-datanode/bin/hdfs dfsadmin -fs 
> hdfs://c1ha -D ipc.client.connect.max.retries=5 -D 
> ipc.client.connect.retry.interval=1000 -getDatanodeInfo 0.0.0.0:8010'] 
> {'tries': 1, 'user': 'hdfs'}
> 2017-03-14 05:00:35,976 - DataNode has successfully shutdown for upgrade.
> {code}
> 
> Even though ~ 6 seconds have passed, the daemon is still running as it 
> drains. Therefore, we attempt to start it which causes a NOOP.
> 
> Instead, we should also monitor for the PID.
> 
> -
> Now STOP command waits until component really dies. Motivation behind that 
> is: we don't want to execute START of still running component again (e.g. 
> during upgrade/RESTART)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 9a5da04 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_service.py
>  4716343 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  151e26c 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode_upgrade.py
>  b55237d 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/mysql_service.py
>  11bbdd8 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/postgresql_service.py
>  cc7b4cc 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 1c3c5b7 
> 
> 
> Diff: https://reviews.apache.org/r/58208/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test 
> and test on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58356/
---

Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
Oliver Szabo, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-20735
https://issues.apache.org/jira/browse/AMBARI-20735


Repository: ambari


Description
---

Created checkstyle check to ensure either @ApiOperation or @ApiIgnore is 
present on all REST API methods


Diffs
-

  ambari-server/checkstyle.xml bf7698760ac8ddba1d692bcd448c19d939dc 
  ambari-server/pom.xml fbc2b9fd129dca0828624fe76e33616b6919f429 
  ambari-server/src/main/assemblies/server.xml 
27835265f78a3a7aed37eaa544e25679eee8b400 
  utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java 
PRE-CREATION 
  
utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
 PRE-CREATION 
  
utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
 PRE-CREATION 
  
utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58356/diff/1/


Testing
---

Includes unit test for the new check.
Also ran the check on ambari-server: produces 315 errors.


Thanks,

Attila Doroszlai

Re: Review Request 58409: get_value_from_jmx constantly prints exception message in retry mechanism, which brings bad user experience

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58409/#review171872
---



Hello Yuan Bo,

Could you please 
1. Also attach the patch to your JIRA
2. Click Submit Patch button on your JIRA so HadoopQA can run a round of 
integration test ?

- Di Li


On April 13, 2017, 4:16 a.m., Yuanbo Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58409/
> ---
> 
> (Updated April 13, 2017, 4:16 a.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20754
> https://issues.apache.org/jira/browse/AMBARI-20754
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> get_value_from_jmx of jmx.py is used in getting NameNode HA state. As we 
> know, if the cluster is large, it takes a long time for Namenode to leave 
> safe mode when restarting Namenode, thus we use retry mechanism to invoke 
> get_value_from_jmx in case of getting wrong state. The problem is that, 
> get_value_from_jmx will print several exception message into std_error during 
> retrying, it confuses users because there're error messages in std_error, 
> while all the services restart successfully
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/jmx.py 
> 9a4ff5f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  665a8e4 
> 
> 
> Diff: https://reviews.apache.org/r/58409/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yuanbo Liu
> 
>

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58415/#review171871
---


Ship it!




Ship It!

- Sandor Magyari


On April 13, 2017, 10:33 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58415/
> ---
> 
> (Updated April 13, 2017, 10:33 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> Configuration types posted in the blueprint or in the cluster creation 
> template need to be validated before the cluster provisioning is started and 
> cluster resources are persisted in the database.
> This validation should be done when the topology configuration comes together 
> so that it's not modified and enhanced further.
> Currently the topology configuration is modified after the validation thus on 
> blueprint deployments the cluster provisioning may fail despite of the right 
> configuration.
> 
> Notes:
> - due to the nature of the topology validation, the validation logic and 
> management of the validators have been extracted to a specialized service 
> (before validators were attached to requests and the validation happened in 
> the constructor)
> - some unit test cases became unecessary due to the above change, i removed 
> them (and added other unit tests)
> - there are some formatting related hunks in the diff (i added them by 
> mistake)
> 
> The validators have been modified (as per internal discussions and test 
> results)
> - configuration types are considered invalid if they are not in the stack ( 
> regardless the services being deployed)
> - the hive database related validation checks for the mysql server in the 
> list of components, not in the list of services
> 
> The patch is a draft, i am still massaging  it (adding comments, cleaning 
> etc...)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
>  f24c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  1a14b01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  b5d2f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
>  e37c68d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  37fb7d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
>  2ac9950 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  392a53e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java
>  cbc6642 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ChainedTopologyValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
>  1351739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredPasswordValidator.java
>  591a124 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorService.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  dba4043 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  73a80f6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
>  48d1351 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  a691cbc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  98ba592 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  fc7ac27 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
>  3ea17b4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/RequiredPasswordValidatorTest.java
>  4c88247 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  2d5978b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceVal

Re: Review Request 58417: Update docker volumes for Ambari logsearch integration test module

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58417/#review171867
---


Ship it!




Ship It!

- Miklos Gergely


On April 13, 2017, 12:11 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58417/
> ---
> 
> (Updated April 13, 2017, 12:11 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20756
> https://issues.apache.org/jira/browse/AMBARI-20756
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As logsearch-portal has been splitted to 2 differnet modules 
> (logsearch-server + logsearch-web) some of the volumes are not up to date in 
> the integration test framework.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
>  5f8f9bf 
> 
> 
> Diff: https://reviews.apache.org/r/58417/diff/2/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58415/#review171866
---


Ship it!




Ship It!

- Sebastian Toader


On April 13, 2017, 12:33 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58415/
> ---
> 
> (Updated April 13, 2017, 12:33 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> Configuration types posted in the blueprint or in the cluster creation 
> template need to be validated before the cluster provisioning is started and 
> cluster resources are persisted in the database.
> This validation should be done when the topology configuration comes together 
> so that it's not modified and enhanced further.
> Currently the topology configuration is modified after the validation thus on 
> blueprint deployments the cluster provisioning may fail despite of the right 
> configuration.
> 
> Notes:
> - due to the nature of the topology validation, the validation logic and 
> management of the validators have been extracted to a specialized service 
> (before validators were attached to requests and the validation happened in 
> the constructor)
> - some unit test cases became unecessary due to the above change, i removed 
> them (and added other unit tests)
> - there are some formatting related hunks in the diff (i added them by 
> mistake)
> 
> The validators have been modified (as per internal discussions and test 
> results)
> - configuration types are considered invalid if they are not in the stack ( 
> regardless the services being deployed)
> - the hive database related validation checks for the mysql server in the 
> list of components, not in the list of services
> 
> The patch is a draft, i am still massaging  it (adding comments, cleaning 
> etc...)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
>  f24c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  1a14b01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  b5d2f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
>  e37c68d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  37fb7d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
>  2ac9950 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  392a53e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java
>  cbc6642 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ChainedTopologyValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
>  1351739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredPasswordValidator.java
>  591a124 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorService.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  dba4043 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  73a80f6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
>  48d1351 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  a691cbc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  98ba592 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  fc7ac27 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
>  3ea17b4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/RequiredPasswordValidatorTest.java
>  4c88247 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  2d5978b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceV

Re: Review Request 57451: The Installation of hbase-client failed

[zhangxiaolu zhangxiaolu]

> On 四月 12, 2017, 4:35 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 67 (patched)
> > 
> >
> > I've actually never seen this, so perhaps a more appropriate fix would 
> > be in HDFS Client instead.
> > HDFS Client itself should ensure that the hadoop conf dir exists.

Maybe we can take the Role Command Order rules to handle this scenario.
But I still think creating the config dir is better if not existing the hdfs's 
config dir.


- zhangxiaolu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57451/#review171749
---


On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57451/
> ---
> 
> (Updated 四月 10, 2017, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20368
> https://issues.apache.org/jira/browse/AMBARI-20368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is caused by the wrong installation order, which means 
> hbase-client will be installed before the installation of hdfs-client. Under 
> such circumstance, installation of hdfs-client will fail because the 
> hadoop-conf-dir does not exist. 
> Two solutions can be provided to solve this problem:
> 1. Creating the hadoop-conf-dir in hbase.py;
> 2. Setting correct installation order in role_command_order.json;
> Considering that hdfs-client may not beinstalled on the node especially when 
> adding new host, therefore, in my opinion, the second choice would be more 
> appropriate.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  8ad802e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> cffec06 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 42bc989 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 9bb0dd7 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 60022e1 
> 
> 
> Diff: https://reviews.apache.org/r/57451/diff/5/
> 
> 
> Testing
> ---
> 
> done it
> 
> 
> File Attachments
> 
> 
> AMBARI-20368.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 58346: AMBARI-20733 /var/log/krb5kdc.log is growing rapidly on the KDC server

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58346/
---

(Updated April 13, 2017, 12:29 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Changes
---

same as before, but removed stale code


Bugs: AMBARI-20733
https://issues.apache.org/jira/browse/AMBARI-20733


Repository: ambari


Description
---

kerberos statuses making call on every status command with fresh ticket cache. 
Ignoring this check for now because it does not do anything for now and need to 
be reimplemented in something more reliable.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 75880c6 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
a67e16e 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py ab46f96 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
8e5e9a3 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
5fa9ec4 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 
5591ae8 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 8cd2804 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
 01fbce2 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
 7073de6 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 3c62243 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
 6d1dbc5 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
 c4960a7 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
 d2c8089 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
 226e7fd5 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
 77820cc 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
 924eea4 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
 4dabdbc 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
 9448fa6 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 1347f37 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
 7ba1f96 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
 0f1f438 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 be0d2ed 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/datanode.py
 130c021 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_client.py
 4dabdbc 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/journalnode.py
 9448fa6 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
 602dad7 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/nfsgateway.py
 7ba1f96 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/snamenode.py
 0f1f438 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
 19a78c7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 8b69e45 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
 f6251e7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 46864c0 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
 93fa411 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_metastore.py
 8b69e45 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server.py
 f6251e7 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server_interactive.py
 46864c0 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_server.py
 93fa411 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
 c50c67b 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
 31e54e5 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 a8b2cf4 
  
amb

Re: Review Request 58417: Update docker volumes for Ambari logsearch integration test module

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58417/
---

(Updated April 13, 2017, 12:11 p.m.)


Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert 
Nettleton.


Changes
---

use correct volume for libs


Bugs: AMBARI-20756
https://issues.apache.org/jira/browse/AMBARI-20756


Repository: ambari


Description
---

As logsearch-portal has been splitted to 2 differnet modules (logsearch-server 
+ logsearch-web) some of the volumes are not up to date in the integration test 
framework.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
 5f8f9bf 


Diff: https://reviews.apache.org/r/58417/diff/2/

Changes: https://reviews.apache.org/r/58417/diff/1-2/


Testing
---

done


Thanks,

Oliver Szabo

Review Request 58417: Update docker volumes for Ambari logsearch integration test module

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58417/
---

Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert 
Nettleton.


Bugs: AMBARI-20756
https://issues.apache.org/jira/browse/AMBARI-20756


Repository: ambari


Description
---

As logsearch-portal has been splitted to 2 differnet modules (logsearch-server 
+ logsearch-web) some of the volumes are not up to date in the integration test 
framework.


Diffs
-

  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
 5f8f9bf 


Diff: https://reviews.apache.org/r/58417/diff/1/


Testing
---

done


Thanks,

Oliver Szabo

Re: Review Request 58409: get_value_from_jmx constantly prints exception message in retry mechanism, which brings bad user experience

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58409/#review171856
---


Ship it!




Ship It!

- Tim Thorpe


On April 13, 2017, 4:16 a.m., Yuanbo Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58409/
> ---
> 
> (Updated April 13, 2017, 4:16 a.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20754
> https://issues.apache.org/jira/browse/AMBARI-20754
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> get_value_from_jmx of jmx.py is used in getting NameNode HA state. As we 
> know, if the cluster is large, it takes a long time for Namenode to leave 
> safe mode when restarting Namenode, thus we use retry mechanism to invoke 
> get_value_from_jmx in case of getting wrong state. The problem is that, 
> get_value_from_jmx will print several exception message into std_error during 
> retrying, it confuses users because there're error messages in std_error, 
> while all the services restart successfully
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/jmx.py 
> 9a4ff5f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  665a8e4 
> 
> 
> Diff: https://reviews.apache.org/r/58409/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yuanbo Liu
> 
>

Re: Review Request 58416: Need to show decision conditions for decision node in Flow Graph tab

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58416/#review171855
---


Ship it!




Ship It!

- venkat sairam


On April 13, 2017, 10:42 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58416/
> ---
> 
> (Updated April 13, 2017, 10:42 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav 
> Kulshreshtha, and venkat sairam.
> 
> 
> Bugs: AMBARI-20719
> https://issues.apache.org/jira/browse/AMBARI-20719
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added the conditions to show up on mouse move in flow graph
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> e74c873 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
>  0c5257e 
> 
> 
> Diff: https://reviews.apache.org/r/58416/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 58416: Need to show decision conditions for decision node in Flow Graph tab

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58416/#review171853
---


Ship it!




Ship It!

- belliraj hb


On April 13, 2017, 10:42 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58416/
> ---
> 
> (Updated April 13, 2017, 10:42 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav 
> Kulshreshtha, and venkat sairam.
> 
> 
> Bugs: AMBARI-20719
> https://issues.apache.org/jira/browse/AMBARI-20719
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added the conditions to show up on mouse move in flow graph
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> e74c873 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
>  0c5257e 
> 
> 
> Diff: https://reviews.apache.org/r/58416/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 58416: Need to show decision conditions for decision node in Flow Graph tab

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58416/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav 
Kulshreshtha, and venkat sairam.


Bugs: AMBARI-20719
https://issues.apache.org/jira/browse/AMBARI-20719


Repository: ambari


Description
---

Added the conditions to show up on mouse move in flow graph


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
e74c873 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
 0c5257e 


Diff: https://reviews.apache.org/r/58416/diff/1/


Testing
---

Manual


Thanks,

Madhan Reddy

Review Request 58415: Topology configuration type validation prior to cluster creation

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58415/
---

Review request for Ambari, Attila Doroszlai, Robert Levas, Sandor Magyari, and 
Sebastian Toader.


Repository: ambari


Description
---

Problem:
Configuration types posted in the blueprint or in the cluster creation template 
need to be validated before the cluster provisioning is started and cluster 
resources are persisted in the database.
This validation should be done when the topology configuration comes together 
so that it's not modified and enhanced further.
Currently the topology configuration is modified after the validation thus on 
blueprint deployments the cluster provisioning may fail despite of the right 
configuration.

Notes:
- due to the nature of the topology validation, the validation logic and 
management of the validators have been extracted to a specialized service 
(before validators were attached to requests and the validation happened in the 
constructor)
- some unit test cases became unecessary due to the above change, i removed 
them (and added other unit tests)
- there are some formatting related hunks in the diff (i added them by mistake)

The validators have been modified (as per internal discussions and test results)
- configuration types are considered invalid if they are not in the stack ( 
regardless the services being deployed)
- the hive database related validation checks for the mysql server in the list 
of components, not in the list of services

The patch is a draft, i am still massaging  it (adding comments, cleaning 
etc...)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
 f24c138 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 1a14b01 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
 b5d2f9d 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
 e37c68d 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
 37fb7d4 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
 2ac9950 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 392a53e 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java
 cbc6642 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ChainedTopologyValidator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/HiveServiceValidator.java
 1351739 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredPasswordValidator.java
 591a124 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorService.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 dba4043 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
 73a80f6 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
 48d1351 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
 a691cbc 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
 98ba592 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
 fc7ac27 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
 3ea17b4 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/RequiredPasswordValidatorTest.java
 4c88247 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 2d5978b 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java
 745b01b 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidatorTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58415/diff/1/


Testing
---

Unit tests ran against trunk. (some unrelatet pyhon tests failed though)
Manually tested on the local env. (Still need to do some testing)


Thanks,

Laszlo Puskas

Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

[Qin Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58411/
---

Review request for Ambari.


Bugs: AMBARI-20726
https://issues.apache.org/jira/browse/AMBARI-20726


Repository: ambari


Description
---

Aggregate alert does not show status properly at Maintenance Mode change.

Steps to reproduce:
Install a cluster that has HBase with one regionserver installed.

Scenario 1:
1. Turn On Maintenance Mode on the RegionServer or on the RegionServer host or 
on the HBase service.
2. Stop the RegionServer after that.
3. No red alerts will show as expected.
   Percent RegionServers Available - OK affected: [0], total: [1]
4. Now Turn Off Maintenance Mode, still keep the RegionServer down.
   But Percent RegionServers Available alert will still show "OK" - "CRIT" is 
expected.

Scenario 2:
1) Stop the RegionServer - Red alert will show as expected.
   Percent RegionServers Available - CRIT affected: [1], total: [1]
2) Now Turn On Maintenance Mode - For RegionServer status, Red alert will be 
gone as expected.
   But Percent RegionServers Available alert will still show "CRIT" - "OK" is 
expected.
   
The fix is to fire an AggregateAlertRecalculateEvent to refresh aggregate alert 
at Maintenance Mode change time.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
 847a207 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 
d3ba2ac 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/AlertMaintenanceModeListenerTest.java
 bdc662a 


Diff: https://reviews.apache.org/r/58411/diff/1/


Testing
---

The fix has been manually tested via HDP UI.
The unit testcase AlertMaintenanceModeListenerTest.java has been updated to 
reflect the change.

testrun_ambari-server Results :
Tests run: 4977, Failures: 0, Errors: 0, Skipped: 39

The skipped testcases has nothing to do with the fix.


Thanks,

Qin Liu