Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

[Sangeeta Ravindran]

> On May 19, 2017, 2:56 p.m., Di Li wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js
> > Lines 150 (patched)
> > 
> >
> > nitpicking: remove console.log line.

Hi Di, I have removed the console.log statement. I also made on additional 
change to set the editableDisplayName to also be set based on the number of 
digits in the version.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59382/#review175503
---


On May 19, 2017, 5:23 a.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59382/
> ---
> 
> (Updated May 19, 2017, 5:23 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-21052
> https://issues.apache.org/jira/browse/AMBARI-21052
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the Register Version UI, the regex pattern for Version Number is currently 
> hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two 
> digits to be entered to make it a valid 4 digit stack version. If the stack 
> version dir has three digits, Register Version UI throws an error 
> mystack-x.x.x Invalid. The regex pattern should be based on the number of 
> digits supplied by the stack's version dir and should not be harcoded.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  69c35c0 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> fd2c6e5 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> b496987 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  fe08802 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js
>  81d3441 
> 
> 
> Diff: https://reviews.apache.org/r/59382/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> I updated the test case because $scope.subversionPattern has been removed as 
> part of this fix.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59382/
---

(Updated May 19, 2017, 9:16 p.m.)


Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-21052
https://issues.apache.org/jira/browse/AMBARI-21052


Repository: ambari


Description
---

In the Register Version UI, the regex pattern for Version Number is currently 
hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two 
digits to be entered to make it a valid 4 digit stack version. If the stack 
version dir has three digits, Register Version UI throws an error mystack-x.x.x 
Invalid. The regex pattern should be based on the number of digits supplied by 
the stack's version dir and should not be harcoded.


Diffs (updated)
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
 69c35c0 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
fd2c6e5 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
b496987 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
 fe08802 
  
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js
 81d3441 


Diff: https://reviews.apache.org/r/59382/diff/2/

Changes: https://reviews.apache.org/r/59382/diff/1-2/


Testing
---

Manual Testing.
I updated the test case because $scope.subversionPattern has been removed as 
part of this fix.


Thanks,

Sangeeta Ravindran

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

[Sangeeta Ravindran]

> On May 19, 2017, 8:23 a.m., Alexandr Antonenko wrote:
> > Ship It!

Thanks Alexandr. I also made on additional change to set the 
editableDisplayName to also be set based on the number of digits in the version.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59382/#review175475
---


On May 19, 2017, 5:23 a.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59382/
> ---
> 
> (Updated May 19, 2017, 5:23 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-21052
> https://issues.apache.org/jira/browse/AMBARI-21052
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the Register Version UI, the regex pattern for Version Number is currently 
> hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two 
> digits to be entered to make it a valid 4 digit stack version. If the stack 
> version dir has three digits, Register Version UI throws an error 
> mystack-x.x.x Invalid. The regex pattern should be based on the number of 
> digits supplied by the stack's version dir and should not be harcoded.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  69c35c0 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> fd2c6e5 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> b496987 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  fe08802 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js
>  81d3441 
> 
> 
> Diff: https://reviews.apache.org/r/59382/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> I updated the test case because $scope.subversionPattern has been removed as 
> part of this fix.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 59312: Log Search use POJOs for input configuration

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59312/#review175570
---




ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldDescriptorImpl.java
Lines 24 (patched)


that class is really needed? its an empty abstract class, 
MapFieldDescriptor interface should be able to replace this (where the abstact 
class is used)


- Oliver Szabo


On May 19, 2017, 7:31 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59312/
> ---
> 
> (Updated May 19, 2017, 7:31 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21033
> https://issues.apache.org/jira/browse/AMBARI-21033
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Instead of parsing the input configuration jsons in logfeeder the 
> configuration api should return POJOs with the input and filter descriptions
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-config-api/pom.xml 72fcc80 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
>  29a82a6 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
>  07921d0 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
>  6ef4b90 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/Conditions.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/Fields.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterGrokDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterJsonDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterKeyValueDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputFileBaseDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputFileDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputS3FileDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapDateDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldCopyDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldNameDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldValueDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/PostMapValues.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
>  fc3fe5b 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
>  346edb3 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 2c59a4a 
>   
> ambari-logsea

Review Request 59418: Add ability to sink Raw metrics to external system via Http

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59418/
---

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-21079
https://issues.apache.org/jira/browse/AMBARI-21079


Repository: ambari


Description
---

- Define interface to add MetricsSources to AMS
- Define sink interfaces
- Add caching layer to allow flush interval to be different from sink interval.


Diffs
-

  ambari-metrics/ambari-metrics-common/pom.xml 62ae75f 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsEhCacheSizeOfEngine.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
 1ca9c33 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 f984253 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 3b2a119 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 023465b 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java
 ba16b43 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java
 f904ebe 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/DefaultFSSinkProvider.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/ExternalMetricsSink.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/ExternalSinkProvider.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/HttpSinkProvider.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/DefaultInternalMetricsSourceProvider.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/InternalMetricsSource.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/InternalSourceProvider.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/RawMetricsSource.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricCacheKey.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricCacheValue.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricsCache.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricsCacheProvider.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricsCacheSizeOfEngine.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryServer.java
 3688630 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java
 611d82e 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java
 aae1d4b 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor

Re: Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59232/#review175568
---


Ship it!




Ship It!

- Robert Nettleton


On May 19, 2017, 4:36 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59232/
> ---
> 
> (Updated May 19, 2017, 4:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Nettleton, Sandor 
> Magyari, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20984
> https://issues.apache.org/jira/browse/AMBARI-20984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, if a user wants to use custom HDP repos during a blueprint 
> deployment, he has to update the repo URLs before hand via a REST API. The 
> JIRA here proposes a way to include stack repos in the blueprint as optional 
> fields so that when the fields exist, Ambari server will use the repos to 
> deploy a cluster. This eliminates the need for user to run a separate rest 
> api call before the actual blueprint deployment.
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  c655c62 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> 139a1ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  826e4e5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 
> 555192c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  f5cf498 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  c8d4d55 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  4c9815c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  1bdeb1b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java
>  0007acf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  0378753 
> 
> 
> Diff: https://reviews.apache.org/r/59232/diff/3/
> 
> 
> Testing
> ---
> 
> unit tests. patch a trunk cluster with the change and use  blueprint to 
> install a cluster.
> 
> The section to add to the bp for the repos is like the following.
> 
> override_strategy - ALWAYS_APPLY will override the existing repo info stored 
> in the metainfo table in the Ambari db. APPLY_WHEN_MISSING will only insert 
> repo info to the metainfo table if there is no such entries in the table yet.
> 
>   "settings" : [
> {
> "repository_settings" : [
>   {
> "override_strategy":"ALWAYS_APPLY",
> "operating_system":"redhat7",
> "repo_id":"HDP-2.6", 
> 
> "base_url":"http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos7/2.x/BUILDS/2.6.0.3-8";
>   },
>   {
> "override_strategy":"APPLY_WHEN_MISSING",
> "operating_system":"redhat7",
> "repo_id": "HDP-UTILS-1.1.0.21",
> "base_url": 
> "http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7";
>   }
> ]
> }
>   ],
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/
---

(Updated May 19, 2017, 8:08 p.m.)


Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

fill exception-status code map only once


Bugs: AMBARI-21071
https://issues.apache.org/jira/browse/AMBARI-21071


Repository: ambari


Description
---

- Added new rest endpoints to manage jobs & steps for infra-manager data/job 
processing
- Added some wrapper DTO classes to help jakson to serialize objects with 
cyclic dependency (some models are reimplemented which came from spring-batch 
admin manager project)
- Added exception mapper for generating the proper responses codes in case of 
internal exceptions.
- TODO: add unit tests for JobManager class


Diffs (updated)
-

  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
 656127e 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
 7310626 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java
 27fed40 


Diff: https://reviews.apache.org/r/59396/diff/3/

Changes: https://reviews.apache.org/r/59396/diff/2-3/


Testing
---

done.


Thanks,

Oliver Szabo

Re: Review Request 59416: AMBARI-21068 : Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59416/#review175565
---


Ship it!




Ship It!

- Sid Wagle


On May 19, 2017, 7:57 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59416/
> ---
> 
> (Updated May 19, 2017, 7:57 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21068
> https://issues.apache.org/jira/browse/AMBARI-21068
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed the changes to *.metrics2.properties.j2 files. Multi cluster support 
> for AMS can be enabled through manual changes in these files during 
> deployment.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  bcdc65a 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  7fe2861 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
>  211e9cd 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  e550024 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  20f60e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  425201c 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
>  6873c85 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
>  9729bbe 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
>  b876a3d 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
>  24535c5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
>  9076269 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2
>  9328f9f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2
>  9a7f9dc 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
>  e9fe024 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
>  bd7eb0c 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  1ada331 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2
>  51162e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  0501039 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2
>  5e1ebfd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml
>  fae61d3 
> 
> 
> Diff: https://reviews.apache.org/r/59416/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested 2.5.0 to 2.5.1 upgrade.
> mvn clean test on Ambari Metrics.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/#review175564
---


Ship it!




Ship It!

- Miklos Gergely


On May 19, 2017, 12:52 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59396/
> ---
> 
> (Updated May 19, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21071
> https://issues.apache.org/jira/browse/AMBARI-21071
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added new rest endpoints to manage jobs & steps for infra-manager data/job 
> processing
> - Added some wrapper DTO classes to help jakson to serialize objects with 
> cyclic dependency (some models are reimplemented which came from spring-batch 
> admin manager project)
> - Added exception mapper for generating the proper responses codes in case of 
> internal exceptions.
> - TODO: add unit tests for JobManager class
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
>  656127e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
>  7310626 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java
>  27fed40 
> 
> 
> Diff: https://reviews.apache.org/r/59396/diff/2/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/#review175563
---




ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java
Lines 59 (patched)


This map is always the same, thus it should be created as private static 
final constant, and initialized in a static block.


- Miklos Gergely


On May 19, 2017, 12:52 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59396/
> ---
> 
> (Updated May 19, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21071
> https://issues.apache.org/jira/browse/AMBARI-21071
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added new rest endpoints to manage jobs & steps for infra-manager data/job 
> processing
> - Added some wrapper DTO classes to help jakson to serialize objects with 
> cyclic dependency (some models are reimplemented which came from spring-batch 
> admin manager project)
> - Added exception mapper for generating the proper responses codes in case of 
> internal exceptions.
> - TODO: add unit tests for JobManager class
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
>  656127e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
>  7310626 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java
>  27fed40 
> 
> 
> Diff: https://reviews.apache.org/r/59396/diff/2/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 59416: AMBARI-21068 : Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59416/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-21068
https://issues.apache.org/jira/browse/AMBARI-21068


Repository: ambari


Description
---

Removed the changes to *.metrics2.properties.j2 files. Multi cluster support 
for AMS can be enabled through manual changes in these files during deployment.


Diffs
-

  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 bcdc65a 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 7fe2861 
  
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
 211e9cd 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 e550024 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 20f60e1 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 425201c 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
 6873c85 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
 9729bbe 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
 b876a3d 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
 24535c5 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
 9076269 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2
 9328f9f 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2
 9a7f9dc 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
 e9fe024 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
 bd7eb0c 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 1ada331 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2
 51162e8 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
 0501039 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2
 5e1ebfd 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml
 fae61d3 


Diff: https://reviews.apache.org/r/59416/diff/1/


Testing
---

Manually tested 2.5.0 to 2.5.1 upgrade.
mvn clean test on Ambari Metrics.


Thanks,

Aravindan Vijayan

Re: Review Request 59312: Log Search use POJOs for input configuration

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59312/
---

(Updated May 19, 2017, 7:31 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

Use global configs to determine input type if source is not present in the 
input element


Bugs: AMBARI-21033
https://issues.apache.org/jira/browse/AMBARI-21033


Repository: ambari


Description
---

Instead of parsing the input configuration jsons in logfeeder the configuration 
api should return POJOs with the input and filter descriptions


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-config-api/pom.xml 72fcc80 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
 29a82a6 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
 07921d0 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
 6ef4b90 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/Conditions.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/Fields.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterGrokDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterJsonDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterKeyValueDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputFileBaseDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputFileDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputS3FileDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapDateDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldCopyDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldNameDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldValueDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/PostMapValues.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
 fc3fe5b 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
 346edb3 
  ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 2c59a4a 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
 5e22374 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/ConditionsImpl.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FieldsImpl.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterAdapter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl

Re: Review Request 59401: Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59401/#review175541
---



Can we make this property optional so that ambari upgrade does not require HDFS 
restart?

- Sid Wagle


On May 19, 2017, 3:36 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59401/
> ---
> 
> (Updated May 19, 2017, 3:36 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-21068
> https://issues.apache.org/jira/browse/AMBARI-21068
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka logs indicate:
> [2017-05-19 03:42:17,105] FATAL  (kafka.Kafka$)
> java.lang.IllegalArgumentException: requirement failed: Missing required 
> property 'kafka.timeline.metrics.instanceId'
> at scala.Predef$.require(Predef.scala:233)
> at 
> kafka.utils.VerifiableProperties.getString(VerifiableProperties.scala:177)
> at 
> org.apache.hadoop.metrics2.sink.kafka.KafkaTimelineMetricsReporter.init(KafkaTimelineMetricsReporter.java:169)
> at 
> kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:66)
> at 
> kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:64)
> at 
> scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
> at 
> scala.collection.mutable.WrappedArray.foreach(WrappedArray.scala:34)
> at 
> kafka.metrics.KafkaMetricsReporter$.startReporters(KafkaMetricsReporter.scala:64)
> at 
> kafka.server.KafkaServerStartable$.fromProps(KafkaServerStartable.scala:27)
> at kafka.Kafka$.main(Kafka.scala:58)
> at kafka.Kafka.main(Kafka.scala)
> Did not see this property being added on ambari_upgrade_config_changes.json 
> file
> On a different upgrade path like fromAmbari-2.2.2.o to 2.5.1, this property 
> got added
> [root@ ambari-server]# cat 
> ambari_upgrade_config_changes_05-19-2017_00\:23\:28.json | grep -C4 
> kafka.timeline.metrics.instanceId
> "kafka-broker": {
>   "Added": {
> "kafka.timeline.metrics.hosts": "{{ams_collector_hosts}}",
> "kafka.timeline.metrics.set.instanceId": "{{set_instanceId}}",
> "kafka.timeline.metrics.instanceId": "{{cluster_name}}",
> "port": "6667"
>   },
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
>  146520f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java
>  4575998 
> 
> 
> Diff: https://reviews.apache.org/r/59401/diff/1/
> 
> 
> Testing
> ---
> 
> manual + unit tests
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 59401: Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59401/#review175532
---


Ship it!




Ship It!

- Sid Wagle


On May 19, 2017, 3:36 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59401/
> ---
> 
> (Updated May 19, 2017, 3:36 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-21068
> https://issues.apache.org/jira/browse/AMBARI-21068
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kafka logs indicate:
> [2017-05-19 03:42:17,105] FATAL  (kafka.Kafka$)
> java.lang.IllegalArgumentException: requirement failed: Missing required 
> property 'kafka.timeline.metrics.instanceId'
> at scala.Predef$.require(Predef.scala:233)
> at 
> kafka.utils.VerifiableProperties.getString(VerifiableProperties.scala:177)
> at 
> org.apache.hadoop.metrics2.sink.kafka.KafkaTimelineMetricsReporter.init(KafkaTimelineMetricsReporter.java:169)
> at 
> kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:66)
> at 
> kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:64)
> at 
> scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
> at 
> scala.collection.mutable.WrappedArray.foreach(WrappedArray.scala:34)
> at 
> kafka.metrics.KafkaMetricsReporter$.startReporters(KafkaMetricsReporter.scala:64)
> at 
> kafka.server.KafkaServerStartable$.fromProps(KafkaServerStartable.scala:27)
> at kafka.Kafka$.main(Kafka.scala:58)
> at kafka.Kafka.main(Kafka.scala)
> Did not see this property being added on ambari_upgrade_config_changes.json 
> file
> On a different upgrade path like fromAmbari-2.2.2.o to 2.5.1, this property 
> got added
> [root@ ambari-server]# cat 
> ambari_upgrade_config_changes_05-19-2017_00\:23\:28.json | grep -C4 
> kafka.timeline.metrics.instanceId
> "kafka-broker": {
>   "Added": {
> "kafka.timeline.metrics.hosts": "{{ams_collector_hosts}}",
> "kafka.timeline.metrics.set.instanceId": "{{set_instanceId}}",
> "kafka.timeline.metrics.instanceId": "{{cluster_name}}",
> "port": "6667"
>   },
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
>  146520f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java
>  4575998 
> 
> 
> Diff: https://reviews.apache.org/r/59401/diff/1/
> 
> 
> Testing
> ---
> 
> manual + unit tests
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/#review175529
---


Ship it!




Ship It!

- Robert Nettleton


On May 19, 2017, 12:52 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59396/
> ---
> 
> (Updated May 19, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21071
> https://issues.apache.org/jira/browse/AMBARI-21071
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added new rest endpoints to manage jobs & steps for infra-manager data/job 
> processing
> - Added some wrapper DTO classes to help jakson to serialize objects with 
> cyclic dependency (some models are reimplemented which came from spring-batch 
> admin manager project)
> - Added exception mapper for generating the proper responses codes in case of 
> internal exceptions.
> - TODO: add unit tests for JobManager class
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
>  656127e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
>  7310626 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java
>  27fed40 
> 
> 
> Diff: https://reviews.apache.org/r/59396/diff/2/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 59411: Cleanup temporary files needed for downloading client configurations response.

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59411/
---

Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, and 
Sebastian Toader.


Bugs: AMBARI-20596
https://issues.apache.org/jira/browse/AMBARI-20596


Repository: ambari


Description
---

While handling the REST API call used to request client configurations, some 
temporary files are created and never cleaned up.


Diffs
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
9eee5be 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 c390c86 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 463b3a1 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py b2636ab 


Diff: https://reviews.apache.org/r/59411/diff/1/


Testing
---

- created a cluster with YARN
- successfully downloaded and inspected YARN client configuration

existing unittests: PENDING


Thanks,

Attila Magyar

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175527
---


Ship it!




Ship It!

- Sangeeta Ravindran


On May 19, 2017, 5:01 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> ---
> 
> (Updated May 19, 2017, 5:01 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and 
> Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
> https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exported blueprint should include config-group changes, which should be 
> exported as host-group level configuration. New host-group will be created 
> for host having unique config-group.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> 
> 
> exported blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/
---

(Updated May 19, 2017, 5:01 p.m.)


Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and 
Sangeeta Ravindran.


Bugs: AMBARI-21050
https://issues.apache.org/jira/browse/AMBARI-21050


Repository: ambari


Description
---

Exported blueprint should include config-group changes, which should be 
exported as host-group level configuration. New host-group will be created for 
host having unique config-group.


Diffs (updated)
-

  ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
  ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 


Diff: https://reviews.apache.org/r/59373/diff/2/

Changes: https://reviews.apache.org/r/59373/diff/1-2/


Testing
---

Tested manually. Updated test cases.


File Attachments


exported blueprint
  
https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
exported cluster template
  
https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json


Thanks,

Amruta Borkar

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175524
---


Ship it!




Ship It!

- Robert Nettleton


On May 18, 2017, 6:27 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> ---
> 
> (Updated May 18, 2017, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and 
> Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
> https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exported blueprint should include config-group changes, which should be 
> exported as host-group level configuration. New host-group will be created 
> for host having unique config-group.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> 
> 
> exported blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59364: AMBARI-21053 Reverting Beacon stack advisor recommendation

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59364/#review175516
---


Ship it!




Ship It!

- Jayush Luniya


On May 18, 2017, 3:03 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59364/
> ---
> 
> (Updated May 18, 2017, 3:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, 
> Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21053
> https://issues.apache.org/jira/browse/AMBARI-21053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Beacon is an add-on-service installed via management pack. For services 
> installed via mpack need to use service advisor recommendation, which should 
> be provided in mpack.
> 
> Because of the stack_advisor code available, service_advisor.py code logic 
> from mpack is not getting executed.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 488562b 
> 
> 
> Diff: https://reviews.apache.org/r/59364/diff/1/
> 
> 
> Testing
> ---
> 
> Ran 273 tests in 7.202s
> 
> OK
> --
> Total run:1171
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 59401: Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59401/
---

(Updated Май 19, 2017, 3:36 п.п.)


Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-21068
https://issues.apache.org/jira/browse/AMBARI-21068


Repository: ambari


Description
---

Kafka logs indicate:
[2017-05-19 03:42:17,105] FATAL  (kafka.Kafka$)
java.lang.IllegalArgumentException: requirement failed: Missing required 
property 'kafka.timeline.metrics.instanceId'
at scala.Predef$.require(Predef.scala:233)
at 
kafka.utils.VerifiableProperties.getString(VerifiableProperties.scala:177)
at 
org.apache.hadoop.metrics2.sink.kafka.KafkaTimelineMetricsReporter.init(KafkaTimelineMetricsReporter.java:169)
at 
kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:66)
at 
kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:64)
at 
scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
at scala.collection.mutable.WrappedArray.foreach(WrappedArray.scala:34)
at 
kafka.metrics.KafkaMetricsReporter$.startReporters(KafkaMetricsReporter.scala:64)
at 
kafka.server.KafkaServerStartable$.fromProps(KafkaServerStartable.scala:27)
at kafka.Kafka$.main(Kafka.scala:58)
at kafka.Kafka.main(Kafka.scala)
Did not see this property being added on ambari_upgrade_config_changes.json file
On a different upgrade path like fromAmbari-2.2.2.o to 2.5.1, this property got 
added
[root@ ambari-server]# cat 
ambari_upgrade_config_changes_05-19-2017_00\:23\:28.json | grep -C4 
kafka.timeline.metrics.instanceId
"kafka-broker": {
  "Added": {
"kafka.timeline.metrics.hosts": "{{ams_collector_hosts}}",
"kafka.timeline.metrics.set.instanceId": "{{set_instanceId}}",
"kafka.timeline.metrics.instanceId": "{{cluster_name}}",
"port": "6667"
  },


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
 146520f 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java
 4575998 


Diff: https://reviews.apache.org/r/59401/diff/1/


Testing
---

manual + unit tests


Thanks,

Dmytro Sen

Re: Review Request 59151: Workflow Designer View: Provide sorting of workflows on dashboard

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59151/#review175504
---


Ship it!




Ship It!

- Di Li


On May 10, 2017, 6:33 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59151/
> ---
> 
> (Updated May 10, 2017, 6:33 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20972
> https://issues.apache.org/jira/browse/AMBARI-20972
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The workflows displayed on the worflow designer view dashboard are not 
> sortable. The ability to sort via Name, Status, User, Created Time, End Time 
> and jobId should be included
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 
> 01eb4ea 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
>  86ab5a5 
> 
> 
> Diff: https://reviews.apache.org/r/59151/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> File Attachments
> 
> 
> sort
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/10/325cfa3d-d3fb-43e8-8e9a-5d1315be299e__wfmSort.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59382/#review175503
---




ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js
Lines 150 (patched)


nitpicking: remove console.log line.


- Di Li


On May 19, 2017, 5:23 a.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59382/
> ---
> 
> (Updated May 19, 2017, 5:23 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-21052
> https://issues.apache.org/jira/browse/AMBARI-21052
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the Register Version UI, the regex pattern for Version Number is currently 
> hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two 
> digits to be entered to make it a valid 4 digit stack version. If the stack 
> version dir has three digits, Register Version UI throws an error 
> mystack-x.x.x Invalid. The regex pattern should be based on the number of 
> digits supplied by the stack's version dir and should not be harcoded.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  69c35c0 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> fd2c6e5 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> b496987 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  fe08802 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js
>  81d3441 
> 
> 
> Diff: https://reviews.apache.org/r/59382/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> I updated the test case because $scope.subversionPattern has been removed as 
> part of this fix.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175502
---




ambari-web/test/controllers/wizard/step8_test.js
Line 2346 (original), 2343 (patched)


minor: remove console.log from tests


- Di Li


On May 18, 2017, 6:27 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> ---
> 
> (Updated May 18, 2017, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and 
> Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
> https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exported blueprint should include config-group changes, which should be 
> exported as host-group level configuration. New host-group will be created 
> for host having unique config-group.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> 
> 
> exported blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Review Request 59401: Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59401/
---

Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-21075
https://issues.apache.org/jira/browse/AMBARI-21075


Repository: ambari


Description
---

Kafka logs indicate:
[2017-05-19 03:42:17,105] FATAL  (kafka.Kafka$)
java.lang.IllegalArgumentException: requirement failed: Missing required 
property 'kafka.timeline.metrics.instanceId'
at scala.Predef$.require(Predef.scala:233)
at 
kafka.utils.VerifiableProperties.getString(VerifiableProperties.scala:177)
at 
org.apache.hadoop.metrics2.sink.kafka.KafkaTimelineMetricsReporter.init(KafkaTimelineMetricsReporter.java:169)
at 
kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:66)
at 
kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:64)
at 
scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
at scala.collection.mutable.WrappedArray.foreach(WrappedArray.scala:34)
at 
kafka.metrics.KafkaMetricsReporter$.startReporters(KafkaMetricsReporter.scala:64)
at 
kafka.server.KafkaServerStartable$.fromProps(KafkaServerStartable.scala:27)
at kafka.Kafka$.main(Kafka.scala:58)
at kafka.Kafka.main(Kafka.scala)
Did not see this property being added on ambari_upgrade_config_changes.json file
On a different upgrade path like fromAmbari-2.2.2.o to 2.5.1, this property got 
added
[root@ ambari-server]# cat 
ambari_upgrade_config_changes_05-19-2017_00\:23\:28.json | grep -C4 
kafka.timeline.metrics.instanceId
"kafka-broker": {
  "Added": {
"kafka.timeline.metrics.hosts": "{{ams_collector_hosts}}",
"kafka.timeline.metrics.set.instanceId": "{{set_instanceId}}",
"kafka.timeline.metrics.instanceId": "{{cluster_name}}",
"port": "6667"
  },


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
 146520f 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java
 4575998 


Diff: https://reviews.apache.org/r/59401/diff/1/


Testing
---

manual + unit tests


Thanks,

Dmytro Sen

Re: Review Request 59400: Storm XML File has Invalid Characters Causing Exceptions on Server Startup

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59400/#review175500
---


Ship it!




Ship It!

- Nate Cole


On May 19, 2017, 10:22 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59400/
> ---
> 
> (Updated May 19, 2017, 10:22 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-21074
> https://issues.apache.org/jira/browse/AMBARI-21074
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Storm XML file has invalid characters causing parse errors on startup...
> 
> ```
> 19 May 2017 10:01:42,434 ERROR [main] ModuleFileUnmarshaller:141 - Cannot 
> parse 
> /var/lib/ambari-server/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
> 19 May 2017 10:01:42,435 ERROR [main] ModuleFileUnmarshaller:143 - The entity 
> name must immediately follow the '&' in the entity reference.
> org.xml.sax.SAXParseException; systemId: 
> file:/var/lib/ambari-server/resources/common-services/STORM/0.9.1/configuration/storm-env.xml;
>  lineNumber: 131; columnNumber: 64; The entity name must immediately follow 
> the '&' in the entity reference.
> at 
> com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
>  cfa33e2fc6 
> 
> 
> Diff: https://reviews.apache.org/r/59400/diff/1/
> 
> 
> Testing
> ---
> 
> Started Ambari
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 59400: Storm XML File has Invalid Characters Causing Exceptions on Server Startup

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59400/
---

Review request for Ambari and Nate Cole.


Bugs: AMBARI-21074
https://issues.apache.org/jira/browse/AMBARI-21074


Repository: ambari


Description
---

Storm XML file has invalid characters causing parse errors on startup...

```
19 May 2017 10:01:42,434 ERROR [main] ModuleFileUnmarshaller:141 - Cannot parse 
/var/lib/ambari-server/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
19 May 2017 10:01:42,435 ERROR [main] ModuleFileUnmarshaller:143 - The entity 
name must immediately follow the '&' in the entity reference.
org.xml.sax.SAXParseException; systemId: 
file:/var/lib/ambari-server/resources/common-services/STORM/0.9.1/configuration/storm-env.xml;
 lineNumber: 131; columnNumber: 64; The entity name must immediately follow the 
'&' in the entity reference.
at 
com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)
```


Diffs
-

  
ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
 cfa33e2fc6 


Diff: https://reviews.apache.org/r/59400/diff/1/


Testing
---

Started Ambari


Thanks,

Jonathan Hurley

Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59391/#review175494
---


Ship it!




Ship It!

- Oliver Szabo


On May 19, 2017, 9:41 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59391/
> ---
> 
> (Updated May 19, 2017, 9:41 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21063
> https://issues.apache.org/jira/browse/AMBARI-21063
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Annotated RequrstServices and request/response models with Swagger 
> annotations. Sub-resources are skipped as Swagger doesn't support them out of 
> the box in their current form.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
>  936b857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java
>  db9268b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
>  4028e35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  9704b33 
> 
> 
> Diff: https://reviews.apache.org/r/59391/diff/2/
> 
> 
> Testing
> ---
> 
> Unit tests pendig.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/
---

(Updated May 19, 2017, 12:52 p.m.)


Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

removed test code


Bugs: AMBARI-21071
https://issues.apache.org/jira/browse/AMBARI-21071


Repository: ambari


Description
---

- Added new rest endpoints to manage jobs & steps for infra-manager data/job 
processing
- Added some wrapper DTO classes to help jakson to serialize objects with 
cyclic dependency (some models are reimplemented which came from spring-batch 
admin manager project)
- Added exception mapper for generating the proper responses codes in case of 
internal exceptions.
- TODO: add unit tests for JobManager class


Diffs (updated)
-

  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
 656127e 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
 7310626 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java
 27fed40 


Diff: https://reviews.apache.org/r/59396/diff/2/

Changes: https://reviews.apache.org/r/59396/diff/1-2/


Testing
---

done.


Thanks,

Oliver Szabo

Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/
---

Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-21071
https://issues.apache.org/jira/browse/AMBARI-21071


Repository: ambari


Description
---

- Added new rest endpoints to manage jobs & steps for infra-manager data/job 
processing
- Added some wrapper DTO classes to help jakson to serialize objects with 
cyclic dependency (some models are reimplemented which came from spring-batch 
admin manager project)
- Added exception mapper for generating the proper responses codes in case of 
internal exceptions.
- TODO: add unit tests for JobManager class


Diffs
-

  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
 656127e 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
 7310626 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java
 27fed40 


Diff: https://reviews.apache.org/r/59396/diff/1/


Testing
---

done.


Thanks,

Oliver Szabo

Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59391/#review175492
---


Ship it!




Ship It!

- Sebastian Toader


On May 19, 2017, 11:41 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59391/
> ---
> 
> (Updated May 19, 2017, 11:41 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21063
> https://issues.apache.org/jira/browse/AMBARI-21063
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Annotated RequrstServices and request/response models with Swagger 
> annotations. Sub-resources are skipped as Swagger doesn't support them out of 
> the box in their current form.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
>  936b857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java
>  db9268b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
>  4028e35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  9704b33 
> 
> 
> Diff: https://reviews.apache.org/r/59391/diff/2/
> 
> 
> Testing
> ---
> 
> Unit tests pendig.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 59394: Race condition: webhdfs call mkdir /tmp/druid-indexing before /tmp making tmp not writable.

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59394/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-21070
https://issues.apache.org/jira/browse/AMBARI-21070


Repository: ambari


Description
---

Race condition: webhdfs call mkdir /tmp/druid-indexing before /tmp making tmp
not writable.

@HDP install through ambari , just at the step start components on host< > we
have some webhdfs operations in background which is creating HDFS directory
structures required for specific components like (/tmp, /tmp/hive /user/druid
/tmp/druid-indexing ...)

generally the expected order is getfileInfo : /tmp --> mkdir: /tmp
changePermission: /tmp to 777 (hdfs:hdfs) so that /tmp is accessible to all ,
hence hivemetastore able to create /tmp/hive(hive scratch directory)

But here in this case specific to druid install , most of the times mkdir of
/tmp/druid-indexing called before(actual /tmp creation) and thus /tmp is
having just default directory permission(755).

->So next call of getfileInfo : /tmp says already exist it will not further 
create and change permission

This made /tmp not accessible to write, So HiveServer process gets shutdown as
it unable to create/access /tmp/hive.

hdfs-audit log:




2017-05-12 06:39:51,067 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.26.3 cmd=getfileinfo src=/tmp/druid-indexing dst=null 
   perm=null   proto=webhdfs
2017-05-12 06:39:51,120 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.22.81cmd=contentSummary  src=/user/druid 
dst=nullperm=null   proto=webhdfs
2017-05-12 06:39:51,133 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.37.200   cmd=setPermission   src=/ats/active 
dst=nullperm=hdfs:hadoop:rwxr-xr-x  proto=webhdfs
2017-05-12 06:39:51,155 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.26.3 cmd=mkdirs  src=/tmp/druid-indexing dst=null 
   perm=hdfs:hdfs:rwxr-xr-xproto=webhdfs
2017-05-12 06:39:51,206 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.22.81cmd=listStatus  src=/user/druid dst=null 
   perm=null   proto=webhdfs
2017-05-12 06:39:51,235 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.37.200   cmd=setPermission   src=/ats/   
dst=nullperm=yarn:hadoop:rwxr-xr-x  proto=webhdfs
2017-05-12 06:39:51,249 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.26.3 cmd=setPermission   src=/tmp/druid-indexing 
dst=nullperm=hdfs:hdfs:rwxr-xr-xproto=webhdfs
2017-05-12 06:39:51,290 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.22.81cmd=listStatus  src=/user/druid/data
dst=nullperm=null   proto=webhdfs
2017-05-12 06:39:51,339 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.37.200   cmd=setPermission   src=/ats/active/ 
   dst=nullperm=hdfs:hadoop:rwxr-xr-x  proto=webhdfs
2017-05-12 06:39:51,341 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.26.3 cmd=setOwnersrc=/tmp/druid-indexing dst=null 
   perm=druid:hdfs:rwxr-xr-x   proto=webhdfs
2017-05-12 06:39:51,380 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.22.81cmd=setOwnersrc=/user/druid/data
dst=nullperm=druid:hdfs:rwxr-xr-x   proto=webhdfs
2017-05-12 06:39:51,431 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.37.200   cmd=setOwnersrc=/ats/active dst=null 
   perm=yarn:hadoop:rwxr-xr-x  proto=webhdfs
2017-05-12 06:39:51,526 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.37.200   cmd=setOwnersrc=/ats/   dst=null 
   perm=yarn:hadoop:rwxr-xr-x  proto=webhdfs
2017-05-12 06:39:51,580 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.32.12cmd=getfileinfo src=/apps/hbase/staging 
dst=nullperm=null   proto=webhdfs
2017-05-12 06:39:51,620 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.37.200   cmd=setOwnersrc=/ats/active/
dst=nullperm=yarn:hadoop:rwxr-xr-x  proto=webhdfs


2017-05-12 06:39:53,289 INFO FSNamesystem.audit: allowed=true   ugi=hdfs 
(auth:SIMPLE)  ip=/172.27.26.202   cmd=getfileinfo src=/tmpdst=null 
   perm=null   proto=webhdfs


We can see in the log accessing /tmp/druid-indexing at 06:39:51(hence
/tmp/have just 755 permission as per call), and accessing /tmp(getfileinfo) at
06:39:53, which returns /tmp already existing

Re: Review Request 59367: Run execution commands sent to /user/commands

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59367/#review175483
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Травень 18, 2017, 4:58 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59367/
> ---
> 
> (Updated Травень 18, 2017, 4:58 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-21056
> https://issues.apache.org/jira/browse/AMBARI-21056
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 441a01d 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 1eda5c2 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py fe48870 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py 7a97f3f 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py 
> PRE-CREATION 
>   ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py 
> a3798c6 
>   ambari-agent/src/main/python/ambari_agent/Constants.py 3fbb485 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8b8a8f9 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 57748a0 
>   ambari-agent/src/main/python/ambari_agent/InitializerModule.py e1b4ed7 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py ea6f895 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/CommandsEventListener.py 
> PRE-CREATION 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py
>  722ec3c 
>   ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 2b7e9bc 
>   ambari-agent/src/main/python/ambari_agent/main.py 29eb926 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
> cab8fe1 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/execution_commands.json
>  bf54b97 
> 
> 
> Diff: https://reviews.apache.org/r/59367/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59391/
---

(Updated May 19, 2017, 9:41 a.m.)


Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Bugs: AMBARI-21063
https://issues.apache.org/jira/browse/AMBARI-21063


Repository: ambari


Description
---

Annotated RequrstServices and request/response models with Swagger annotations. 
Sub-resources are skipped as Swagger doesn't support them out of the box in 
their current form.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
 936b857 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java
 db9268b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
 4028e35 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
 9704b33 


Diff: https://reviews.apache.org/r/59391/diff/2/

Changes: https://reviews.apache.org/r/59391/diff/1-2/


Testing
---

Unit tests pendig.


Thanks,

Balázs Bence Sári

Review Request 59391: Integrate RequestService resource and it's subresources with swagger

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59391/
---

Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Bugs: AMBARI-21063
https://issues.apache.org/jira/browse/AMBARI-21063


Repository: ambari


Description
---

Annotated RequrstServices and request/response models with Swagger annotations. 
Sub-resources are skipped as Swagger doesn't support them out of the box in 
their current form.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
 936b857 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java
 db9268b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
 4028e35 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
 9704b33 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
 a2b0a0c 


Diff: https://reviews.apache.org/r/59391/diff/1/


Testing
---

Unit tests pendig.


Thanks,

Balázs Bence Sári

Review Request 59393: Minimize config changes during ambari upgrade

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59393/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-21069
https://issues.apache.org/jira/browse/AMBARI-21069


Repository: ambari


Description
---

I've implemented a python script that compares stack folders between branches. 
It shows differences (between for example branch-2.5 and trunk) that affect 
ambari upgrade (e.g. add-on-ambari-upgrade changes)


Diffs
-

  dev-support/config-utils/diff_stack_properties.py PRE-CREATION 


Diff: https://reviews.apache.org/r/59393/diff/1/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175476
---


Ship it!




Ship It!

- Alexandr Antonenko


On May 18, 2017, 6:27 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> ---
> 
> (Updated May 18, 2017, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and 
> Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
> https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exported blueprint should include config-group changes, which should be 
> exported as host-group level configuration. New host-group will be created 
> for host having unique config-group.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> 
> 
> exported blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59382/#review175475
---


Ship it!




Ship It!

- Alexandr Antonenko


On May 19, 2017, 5:23 a.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59382/
> ---
> 
> (Updated May 19, 2017, 5:23 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-21052
> https://issues.apache.org/jira/browse/AMBARI-21052
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the Register Version UI, the regex pattern for Version Number is currently 
> hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two 
> digits to be entered to make it a valid 4 digit stack version. If the stack 
> version dir has three digits, Register Version UI throws an error 
> mystack-x.x.x Invalid. The regex pattern should be based on the number of 
> digits supplied by the stack's version dir and should not be harcoded.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  69c35c0 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> fd2c6e5 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> b496987 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  fe08802 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js
>  81d3441 
> 
> 
> Diff: https://reviews.apache.org/r/59382/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> I updated the test case because $scope.subversionPattern has been removed as 
> part of this fix.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>