Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

2017-05-20 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59391/#review175589
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
Lines 127 (patched)


leftover nickname (this is `RequestService`, not `ServiceService`)



ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
Line 104 (original), 155 (patched)


Why add `@Produces` for methods that return a sub-resource?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
Line 26 (original), 27 (patched)


The "dummy" interface `RequestPostRequest` also defines a 
`RequestResourceFilter`.  Is this one really an `ApiModel`?


- Attila Doroszlai


On May 19, 2017, 11:41 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59391/
> ---
> 
> (Updated May 19, 2017, 11:41 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21063
> https://issues.apache.org/jira/browse/AMBARI-21063
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Annotated RequrstServices and request/response models with Swagger 
> annotations. Sub-resources are skipped as Swagger doesn't support them out of 
> the box in their current form.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
>  936b857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java
>  db9268b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
>  4028e35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  9704b33 
> 
> 
> Diff: https://reviews.apache.org/r/59391/diff/2/
> 
> 
> Testing
> ---
> 
> Unit tests pendig.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-05-20 Thread Qin Liu 


> On May 18, 2017, 9:54 a.m., Dmytro Sen wrote:
> > Please check if changes from ambari-server/src/main/resources/stacks/HDP/* 
> > need to be duplicated for services that has been flattened for stack 3.0

Hi Dmytro,

Thank you for reviewing!

I was unable to test it with HDP 3.0 stack because I got Repository Base URL 
validation error "Attention: Please make sure all repository URLs are valid 
before proceeding" for 
http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/3.x/updates/3.0.0.0.


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59149/#review175364
---


On May 13, 2017, 8:56 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59149/
> ---
> 
> (Updated May 13, 2017, 8:56 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Robert Levas, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-19369
> https://issues.apache.org/jira/browse/AMBARI-19369
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> 
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Hadoop/hbase/kafka/storm sinks, clients of Ambari Metrics Collector, 
> currently do not support Kerberos HTTP SPNEGO authentication.
> 
> e.g., 
> /var/log/hadoop-yarn/yarn/yarn-yarn-timelineserver-.log:
> 2016-12-16 22:25:29,471 INFO timeline.HadoopTimelineMetricsSink 
> (AbstractTimelineMetricsSink.java:emitMetricsJson(169)) - Unable to POST 
> metrics to collector, http://metrics-collector:6188/ws/v1/timeline/metrics, 
> statusCode = 401
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 62ae75f 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  2c6fae2 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManager.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManagerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  db36db8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  91af58e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
>  fdde8f2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/templates/kafka_jaas.conf.j2
>  56c558d 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm_yaml_utils.py
>  9d78e71 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm_jaas.conf.j2
>  c22cb51 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3579fcb 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  2e1b208 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/pa

Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues

2017-05-20 Thread Richard Zang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59427/
---

Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-21082
https://issues.apache.org/jira/browse/AMBARI-21082


Repository: ambari


Description
---

Fix step indicator
Fix service selection click


Diffs
-

  ambari-web/app/styles/application.less 2fc1cf2 
  ambari-web/app/templates/wizard/step4.hbs 9f1d7df 
  ambari-web/app/views/wizard/step4_view.js 137b9f5 


Diff: https://reviews.apache.org/r/59427/diff/1/


Testing
---

Manually tested on live cluster, all unit tests passed.
  20699 passing (22s)
  128 pending


Thanks,

Richard Zang