Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard

2017-05-22 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review175751
---


Ship it!




Ship It!

- venkat sairam


On May 15, 2017, 7:07 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> ---
> 
> (Updated May 15, 2017, 7:07 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, Sangeeta Ravindran, and venkat sairam.
> 
> 
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the filters can be cleared only manually by removing the contents, 
> having a button to clear the filters on one click would be helpful.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  4bfb5fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  b9c6029 
> 
> 
> Diff: https://reviews.apache.org/r/58894/diff/3/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> File Attachments
> 
> 
> ClearFilters
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59475: Provide additional logging for config audit log

2017-05-22 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59475/#review175750
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Line 1704 (original), 1710 (patched)


These 2 lines look off, shouldn't these be logged as well?



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Line 1706 (original), 1712 (patched)


Lets add another line for changes configuration keys to indicate exact 
properties that were changed by the user.


- Sid Wagle


On May 23, 2017, 1:36 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59475/
> ---
> 
> (Updated May 23, 2017, 1:36 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21096
> https://issues.apache.org/jira/browse/AMBARI-21096
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Improve logging of ambari-config-changes.log to include names, timestamps, 
> and versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  25b12de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  cf6b717 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  c244107 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  228cf79 
> 
> 
> Diff: https://reviews.apache.org/r/59475/diff/1/
> 
> 
> Testing
> ---
> 
> Verified on live cluster
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues

2017-05-22 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59427/#review175744
---


Ship it!




Ship It!

- Jaimin Jetly


On May 23, 2017, 1:49 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59427/
> ---
> 
> (Updated May 23, 2017, 1:49 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21082
> https://issues.apache.org/jira/browse/AMBARI-21082
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix step indicator
> Fix service selection click
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 2fc1cf2 
>   ambari-web/app/templates/wizard/step4.hbs 9f1d7df 
>   ambari-web/app/views/wizard/step4_view.js 137b9f5 
> 
> 
> Diff: https://reviews.apache.org/r/59427/diff/3/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster, all unit tests passed.
>   20699 passing (22s)
>   128 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues

2017-05-22 Thread Richard Zang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59427/
---

(Updated May 23, 2017, 1:49 a.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Changes
---

update {{{}}} wrap to show links correctly


Bugs: AMBARI-21082
https://issues.apache.org/jira/browse/AMBARI-21082


Repository: ambari


Description
---

Fix step indicator
Fix service selection click


Diffs (updated)
-

  ambari-web/app/styles/application.less 2fc1cf2 
  ambari-web/app/templates/wizard/step4.hbs 9f1d7df 
  ambari-web/app/views/wizard/step4_view.js 137b9f5 


Diff: https://reviews.apache.org/r/59427/diff/3/

Changes: https://reviews.apache.org/r/59427/diff/2-3/


Testing
---

Manually tested on live cluster, all unit tests passed.
  20699 passing (22s)
  128 pending


Thanks,

Richard Zang

Review Request 59475: Provide additional logging for config audit log

2017-05-22 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59475/
---

Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Sid Wagle.


Bugs: AMBARI-21096
https://issues.apache.org/jira/browse/AMBARI-21096


Repository: ambari


Description
---

Improve logging of ambari-config-changes.log to include names, timestamps, and 
versions.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 25b12de 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
 cf6b717 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 c244107 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 228cf79 


Diff: https://reviews.apache.org/r/59475/diff/1/


Testing
---

Verified on live cluster


Thanks,

Alejandro Fernandez

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

2017-05-22 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
---

(Updated May 22, 2017, 8:51 p.m.)


Review request for Ambari and Alejandro Fernandez.


Repository: ambari


Description
---

AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.


Diffs
-

  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml
 1a5dde9c16 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
8b5c07dc90 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 5aa08c5369 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
d98bb53a2a 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
b3d19d42e1 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 4a2a502a20 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
1eb9836abb 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a29f74b668 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 8c659ee469 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
3054ca30c1 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
488562bf11 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
1610bb5580 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 1cdd184529 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
3e7e3d7f14 
  ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63 


Diff: https://reviews.apache.org/r/59459/diff/3/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues

2017-05-22 Thread Richard Zang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59427/
---

(Updated May 22, 2017, 8:46 p.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Changes
---

Pixel adjustment


Bugs: AMBARI-21082
https://issues.apache.org/jira/browse/AMBARI-21082


Repository: ambari


Description
---

Fix step indicator
Fix service selection click


Diffs (updated)
-

  ambari-web/app/styles/application.less 2fc1cf2 
  ambari-web/app/templates/wizard/step4.hbs 9f1d7df 
  ambari-web/app/views/wizard/step4_view.js 137b9f5 


Diff: https://reviews.apache.org/r/59427/diff/2/

Changes: https://reviews.apache.org/r/59427/diff/1-2/


Testing
---

Manually tested on live cluster, all unit tests passed.
  20699 passing (22s)
  128 pending


Thanks,

Richard Zang

Re: Review Request 59450: HDP 3.0 TP - create service definition for Zeppelin with configs, kerberos, widgets, etc

2017-05-22 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59450/#review175668
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 22, 2017, 2:32 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59450/
> ---
> 
> (Updated May 22, 2017, 2:32 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmytro Sen.
> 
> 
> Bugs: AMBARI-21088
> https://issues.apache.org/jira/browse/AMBARI-21088
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> create service definition for Zeppelin with configs, kerberos, widgets, etc
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/alerts.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-shiro-ini.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/alert_check_zeppelin.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/livy2_config_template.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/master.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/spark2_config_template.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/templates/input.config-zeppelin.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/role_command_order.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/ZEPPELIN/metainfo.xml
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59450/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59393: Minimize config changes during ambari upgrade

2017-05-22 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59393/#review175661
---




dev-support/config-utils/diff_stack_properties.py
Lines 65 (patched)


This may need to support a "recurisve" flag in order to compare HDP 2.6 
(which inherits from older stacks) vs HDP 3.0.


- Alejandro Fernandez


On May 19, 2017, 9:39 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59393/
> ---
> 
> (Updated May 19, 2017, 9:39 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21069
> https://issues.apache.org/jira/browse/AMBARI-21069
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've implemented a python script that compares stack folders between 
> branches. It shows differences (between for example branch-2.5 and trunk) 
> that affect ambari upgrade (e.g. add-on-ambari-upgrade changes)
> 
> 
> Diffs
> -
> 
>   dev-support/config-utils/diff_stack_properties.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59393/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 59416: AMBARI-21068 : Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

2017-05-22 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59416/#review175656
---




ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
Line 79 (original)


Storm, HBase, and a few other components have a new version for Hadoop 3.0 
in common-services that will need the same changes.


- Alejandro Fernandez


On May 19, 2017, 7:57 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59416/
> ---
> 
> (Updated May 19, 2017, 7:57 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21068
> https://issues.apache.org/jira/browse/AMBARI-21068
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed the changes to *.metrics2.properties.j2 files. Multi cluster support 
> for AMS can be enabled through manual changes in these files during 
> deployment.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  bcdc65a 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  7fe2861 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
>  211e9cd 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  e550024 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  20f60e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  425201c 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
>  6873c85 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
>  9729bbe 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
>  b876a3d 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
>  24535c5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
>  9076269 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2
>  9328f9f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2
>  9a7f9dc 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
>  e9fe024 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
>  bd7eb0c 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  1ada331 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2
>  51162e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  0501039 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2
>  5e1ebfd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml
>  fae61d3 
> 
> 
> Diff: https://reviews.apache.org/r/59416/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested 2.5.0 to 2.5.1 upgrade.
> mvn clean test on Ambari Metrics.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 59364: AMBARI-21053 Reverting Beacon stack advisor recommendation

2017-05-22 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59364/#review175655
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 18, 2017, 3:03 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59364/
> ---
> 
> (Updated May 18, 2017, 3:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, 
> Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21053
> https://issues.apache.org/jira/browse/AMBARI-21053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Beacon is an add-on-service installed via management pack. For services 
> installed via mpack need to use service advisor recommendation, which should 
> be provided in mpack.
> 
> Because of the stack_advisor code available, service_advisor.py code logic 
> from mpack is not getting executed.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 488562b 
> 
> 
> Diff: https://reviews.apache.org/r/59364/diff/1/
> 
> 
> Testing
> ---
> 
> Ran 273 tests in 7.202s
> 
> OK
> --
> Total run:1171
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 59452: HDP deploy from public repo failed

2017-05-22 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59452/#review175648
---


Ship it!




Ship It!

- Jonathan Hurley


On May 22, 2017, 11:47 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59452/
> ---
> 
> (Updated May 22, 2017, 11:47 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This left-off code breaks ambari-server setup
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari-server.py bd86df281a 
> 
> 
> Diff: https://reviews.apache.org/r/59452/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

2017-05-22 Thread Balázs Bence Sári 


> On May 20, 2017, 7:10 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
> > Line 26 (original), 27 (patched)
> > 
> >
> > The "dummy" interface `RequestPostRequest` also defines a 
> > `RequestResourceFilter`.  Is this one really an `ApiModel`?
> 
> Balázs Bence Sári wrote:
> Th top level RequestResourceFilter class doesn't encapsulate all 
> information contained by the schema, hence the new one.
> 
> Attila Doroszlai wrote:
> Yes, I understand that.  The question is whether we need the old one to 
> be an `ApiModel`.

I think no because the new one is used for schema generation.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59391/#review175589
---


On May 22, 2017, 11:41 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59391/
> ---
> 
> (Updated May 22, 2017, 11:41 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21063
> https://issues.apache.org/jira/browse/AMBARI-21063
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Annotated RequrstServices and request/response models with Swagger 
> annotations. Sub-resources are skipped as Swagger doesn't support them out of 
> the box in their current form.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
>  936b857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java
>  db9268b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
>  4028e35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  9704b33 
> 
> 
> Diff: https://reviews.apache.org/r/59391/diff/3/
> 
> 
> Testing
> ---
> 
> Unit tests pendig.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 59451: Add Log Feeder input config to HDP 3.0 hooks too

2017-05-22 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59451/#review175642
---


Ship it!




Ship It!

- Robert Nettleton


On May 22, 2017, 3:14 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59451/
> ---
> 
> (Updated May 22, 2017, 3:14 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21090
> https://issues.apache.org/jira/browse/AMBARI-21090
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 3.0 clusters need their input configs too
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/after-INSTALL/scripts/params.py
>  5dcd39b 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/after-INSTALL/scripts/shared_initialization.py
>  e9f2283 
> 
> 
> Diff: https://reviews.apache.org/r/59451/diff/1/
> 
> 
> Testing
> ---
> 
> done on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 59452: HDP deploy from public repo failed

2017-05-22 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59452/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-21091
https://issues.apache.org/jira/browse/AMBARI-21091


Repository: ambari


Description
---

This left-off code breaks ambari-server setup


Diffs
-

  ambari-server/src/main/python/ambari-server.py bd86df281a 


Diff: https://reviews.apache.org/r/59452/diff/1/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 59452: HDP deploy from public repo failed

2017-05-22 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59452/
---

(Updated May 22, 2017, 6:47 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-21091
https://issues.apache.org/jira/browse/AMBARI-21091


Repository: ambari


Description
---

This left-off code breaks ambari-server setup


Diffs
-

  ambari-server/src/main/python/ambari-server.py bd86df281a 


Diff: https://reviews.apache.org/r/59452/diff/1/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

2017-05-22 Thread Attila Doroszlai 


> On May 20, 2017, 9:10 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
> > Line 26 (original), 27 (patched)
> > 
> >
> > The "dummy" interface `RequestPostRequest` also defines a 
> > `RequestResourceFilter`.  Is this one really an `ApiModel`?
> 
> Balázs Bence Sári wrote:
> Th top level RequestResourceFilter class doesn't encapsulate all 
> information contained by the schema, hence the new one.

Yes, I understand that.  The question is whether we need the old one to be an 
`ApiModel`.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59391/#review175589
---


On May 22, 2017, 1:41 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59391/
> ---
> 
> (Updated May 22, 2017, 1:41 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21063
> https://issues.apache.org/jira/browse/AMBARI-21063
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Annotated RequrstServices and request/response models with Swagger 
> annotations. Sub-resources are skipped as Swagger doesn't support them out of 
> the box in their current form.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
>  936b857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java
>  db9268b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
>  4028e35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  9704b33 
> 
> 
> Diff: https://reviews.apache.org/r/59391/diff/3/
> 
> 
> Testing
> ---
> 
> Unit tests pendig.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 59451: Add Log Feeder input config to HDP 3.0 hooks too

2017-05-22 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59451/#review175638
---


Ship it!




Ship It!

- Oliver Szabo


On May 22, 2017, 3:14 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59451/
> ---
> 
> (Updated May 22, 2017, 3:14 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21090
> https://issues.apache.org/jira/browse/AMBARI-21090
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 3.0 clusters need their input configs too
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/after-INSTALL/scripts/params.py
>  5dcd39b 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/after-INSTALL/scripts/shared_initialization.py
>  e9f2283 
> 
> 
> Diff: https://reviews.apache.org/r/59451/diff/1/
> 
> 
> Testing
> ---
> 
> done on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 59451: Add Log Feeder input config to HDP 3.0 hooks too

2017-05-22 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59451/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-21090
https://issues.apache.org/jira/browse/AMBARI-21090


Repository: ambari


Description
---

HDP 3.0 clusters need their input configs too


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/3.0/hooks/after-INSTALL/scripts/params.py
 5dcd39b 
  
ambari-server/src/main/resources/stacks/HDP/3.0/hooks/after-INSTALL/scripts/shared_initialization.py
 e9f2283 


Diff: https://reviews.apache.org/r/59451/diff/1/


Testing
---

done on local cluster.


Thanks,

Miklos Gergely

Re: Review Request 59448: Infra manger: Add static data folder servlet endpoint

2017-05-22 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59448/#review175637
---


Ship it!




Ship It!

- Robert Nettleton


On May 22, 2017, 11:59 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59448/
> ---
> 
> (Updated May 22, 2017, 11:59 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21087
> https://issues.apache.org/jira/browse/AMBARI-21087
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add /files/* endpoint which can be displayed by the browser.
> The folder which is browsed can be configured through start cli parameter.
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
>  227bab4 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfraManagerConstants.java
>  11714f3 
> 
> 
> Diff: https://reviews.apache.org/r/59448/diff/1/
> 
> 
> Testing
> ---
> 
> done. (manually)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

2017-05-22 Thread Balázs Bence Sári 


> On May 20, 2017, 7:10 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
> > Line 26 (original), 27 (patched)
> > 
> >
> > The "dummy" interface `RequestPostRequest` also defines a 
> > `RequestResourceFilter`.  Is this one really an `ApiModel`?

Th top level RequestResourceFilter class doesn't encapsulate all information 
contained by the schema, hence the new one.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59391/#review175589
---


On May 22, 2017, 11:41 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59391/
> ---
> 
> (Updated May 22, 2017, 11:41 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21063
> https://issues.apache.org/jira/browse/AMBARI-21063
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Annotated RequrstServices and request/response models with Swagger 
> annotations. Sub-resources are skipped as Swagger doesn't support them out of 
> the box in their current form.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
>  936b857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java
>  db9268b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
>  4028e35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  9704b33 
> 
> 
> Diff: https://reviews.apache.org/r/59391/diff/3/
> 
> 
> Testing
> ---
> 
> Unit tests pendig.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 59450: HDP 3.0 TP - create service definition for Zeppelin with configs, kerberos, widgets, etc

2017-05-22 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59450/
---

Review request for Ambari, Alejandro Fernandez and Dmytro Sen.


Bugs: AMBARI-21088
https://issues.apache.org/jira/browse/AMBARI-21088


Repository: ambari


Description
---

create service definition for Zeppelin with configs, kerberos, widgets, etc


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-shiro-ini.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/kerberos.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/alert_check_zeppelin.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/livy2_config_template.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/master.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/spark2_config_template.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/templates/input.config-zeppelin.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/quicklinks/quicklinks.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/3.0/services/ZEPPELIN/metainfo.xml 
PRE-CREATION 


Diff: https://reviews.apache.org/r/59450/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 59393: Minimize config changes during ambari upgrade

2017-05-22 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59393/#review175635
---


Ship it!




Very nifty little tool!

- Jonathan Hurley


On May 19, 2017, 5:39 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59393/
> ---
> 
> (Updated May 19, 2017, 5:39 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21069
> https://issues.apache.org/jira/browse/AMBARI-21069
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've implemented a python script that compares stack folders between 
> branches. It shows differences (between for example branch-2.5 and trunk) 
> that affect ambari upgrade (e.g. add-on-ambari-upgrade changes)
> 
> 
> Diffs
> -
> 
>   dev-support/config-utils/diff_stack_properties.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59393/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-05-22 Thread Dmytro Sen 


> On Май 18, 2017, 9:54 д.п., Dmytro Sen wrote:
> > Please check if changes from ambari-server/src/main/resources/stacks/HDP/* 
> > need to be duplicated for services that has been flattened for stack 3.0
> 
> Qin Liu wrote:
> Hi Dmytro,
> 
> Thank you for reviewing!
> 
> I was unable to test it with HDP 3.0 stack because I got Repository Base 
> URL validation error "Attention: Please make sure all repository URLs are 
> valid before proceeding" for 
> http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/3.x/updates/3.0.0.0.

All services that has been flattened for AMBARI-19090 does not extend services 
from previous stacks, that's why they need the same changes that are done in 
hdp < 3.0.
I did the manual check and found few issue, please fix them:
Changes in hadoop-env.xml are also needed here 
stacks/HDP/3.0/services/HDFS/configuration/hadoop-env.xml 

Changes in hbase-env.xml are also needed in 
common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml

common-services/HBASE/0.96.0.2.0/package/templates/hbase_master_jaas.conf.j2 -> 
common-services/HBASE/2.0.0.3.0/package/templates/hbase_master_jaas.conf.j2

common-services/HBASE/0.96.0.2.0/package/templates/hbase_regionserver_jaas.conf.j2
 -> 
common-services/HBASE/2.0.0.3.0/package/templates/hbase_regionserver_jaas.conf.j2

stacks/HDP/2.2/services/YARN/configuration-mapred/mapred-env.xml -> 
stacks/HDP/3.0/services/YARN/configuration-mapred/mapred-env.xml

stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml -> 
common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59149/#review175364
---


On Май 13, 2017, 8:56 п.п., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59149/
> ---
> 
> (Updated Май 13, 2017, 8:56 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Robert Levas, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-19369
> https://issues.apache.org/jira/browse/AMBARI-19369
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> 
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Hadoop/hbase/kafka/storm sinks, clients of Ambari Metrics Collector, 
> currently do not support Kerberos HTTP SPNEGO authentication.
> 
> e.g., 
> /var/log/hadoop-yarn/yarn/yarn-yarn-timelineserver-.log:
> 2016-12-16 22:25:29,471 INFO timeline.HadoopTimelineMetricsSink 
> (AbstractTimelineMetricsSink.java:emitMetricsJson(169)) - Unable to POST 
> metrics to collector, http://metrics-collector:6188/ws/v1/timeline/metrics, 
> statusCode = 401
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 62ae75f 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  2c6fae2 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManager.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManagerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  db36db8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
>

Re: Review Request 59448: Infra manger: Add static data folder servlet endpoint

2017-05-22 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59448/#review175630
---


Ship it!




Ship It!

- Miklos Gergely


On May 22, 2017, 11:59 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59448/
> ---
> 
> (Updated May 22, 2017, 11:59 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21087
> https://issues.apache.org/jira/browse/AMBARI-21087
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add /files/* endpoint which can be displayed by the browser.
> The folder which is browsed can be configured through start cli parameter.
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
>  227bab4 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfraManagerConstants.java
>  11714f3 
> 
> 
> Diff: https://reviews.apache.org/r/59448/diff/1/
> 
> 
> Testing
> ---
> 
> done. (manually)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 59448: Infra manger: Add static data folder servlet endpoint

2017-05-22 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59448/
---

Review request for Ambari, Miklos Gergely and Robert Nettleton.


Bugs: AMBARI-21087
https://issues.apache.org/jira/browse/AMBARI-21087


Repository: ambari


Description
---

Add /files/* endpoint which can be displayed by the browser.
The folder which is browsed can be configured through start cli parameter.


Diffs
-

  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
 227bab4 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfraManagerConstants.java
 11714f3 


Diff: https://reviews.apache.org/r/59448/diff/1/


Testing
---

done. (manually)


Thanks,

Oliver Szabo

Re: Review Request 59442: Files view on IE 11- On Concatenating files or downloading, the concatenated or downloaded file occupies the entire UI.

2017-05-22 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59442/#review175628
---


Ship it!




Ship It!

- Gaurav Nagar


On May 22, 2017, 11:08 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59442/
> ---
> 
> (Updated May 22, 2017, 11:08 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-21084
> https://issues.apache.org/jira/browse/AMBARI-21084
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Content-Disposition have been changed from inline to attachment to fix issues 
> in IE while downlaoding files
> 
> 
> Diffs
> -
> 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
>  10b7c9e 
> 
> 
> Diff: https://reviews.apache.org/r/59442/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

2017-05-22 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59391/
---

(Updated May 22, 2017, 11:41 a.m.)


Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

Review comments


Bugs: AMBARI-21063
https://issues.apache.org/jira/browse/AMBARI-21063


Repository: ambari


Description
---

Annotated RequrstServices and request/response models with Swagger annotations. 
Sub-resources are skipped as Swagger doesn't support them out of the box in 
their current form.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
 936b857 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java
 db9268b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java
 4028e35 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
 9704b33 


Diff: https://reviews.apache.org/r/59391/diff/3/

Changes: https://reviews.apache.org/r/59391/diff/2-3/


Testing
---

Unit tests pendig.


Thanks,

Balázs Bence Sári

Re: Review Request 59442: Files view on IE 11- On Concatenating files or downloading, the concatenated or downloaded file occupies the entire UI.

2017-05-22 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59442/#review175625
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 22, 2017, 11:08 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59442/
> ---
> 
> (Updated May 22, 2017, 11:08 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-21084
> https://issues.apache.org/jira/browse/AMBARI-21084
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Content-Disposition have been changed from inline to attachment to fix issues 
> in IE while downlaoding files
> 
> 
> Diffs
> -
> 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
>  10b7c9e 
> 
> 
> Diff: https://reviews.apache.org/r/59442/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 59445: Hive view 2.0 does not work on IE 11 browser

2017-05-22 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59445/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and 
venkat sairam.


Bugs: AMBARI-21086
https://issues.apache.org/jira/browse/AMBARI-21086


Repository: ambari


Description
---

Added browser pollyfill.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/ember-cli-build.js 01682e7 
  contrib/views/hive20/src/main/resources/ui/vendor/browser-pollyfills.js 
PRE-CREATION 


Diff: https://reviews.apache.org/r/59445/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 59444: Hive view 1.5 does not work in Safari8 and IE11

2017-05-22 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59444/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and 
venkat sairam.


Bugs: AMBARI-20812
https://issues.apache.org/jira/browse/AMBARI-20812


Repository: ambari


Description
---

Added browser pollyfills.


Diffs
-

  contrib/views/hive-next/src/main/resources/ui/hive-web/Brocfile.js 318d1f8 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/vendor/browser-pollyfills.js
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59444/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 59442: Files view on IE 11- On Concatenating files or downloading, the concatenated or downloaded file occupies the entire UI.

2017-05-22 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59442/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21084
https://issues.apache.org/jira/browse/AMBARI-21084


Repository: ambari


Description
---

Content-Disposition have been changed from inline to attachment to fix issues 
in IE while downlaoding files


Diffs
-

  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
 10b7c9e 


Diff: https://reviews.apache.org/r/59442/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam

Re: Review Request 59312: Log Search use POJOs for input configuration

2017-05-22 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59312/
---

(Updated May 22, 2017, 10:28 a.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

Removed unnecessary class MapFieldDescriptorImpl, and fixed docker test configs


Bugs: AMBARI-21033
https://issues.apache.org/jira/browse/AMBARI-21033


Repository: ambari


Description
---

Instead of parsing the input configuration jsons in logfeeder the configuration 
api should return POJOs with the input and filter descriptions


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-config-api/pom.xml 72fcc80 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
 29a82a6 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
 07921d0 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
 6ef4b90 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/Conditions.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/Fields.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterGrokDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterJsonDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterKeyValueDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputFileBaseDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputFileDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputS3FileDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapDateDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldCopyDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldNameDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldValueDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/PostMapValues.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
 fc3fe5b 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
 346edb3 
  ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 2c59a4a 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
 5e22374 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/ConditionsImpl.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FieldsImpl.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterAdapter.java
 PRE-CREATION

Review Request 59440: Specify the script directly in alert target for script-based alert dispatchers

2017-05-22 Thread yao lei 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59440/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Richard Zang, 
and Yusaku Sako.


Bugs: AMBARI-20739
https://issues.apache.org/jira/browse/AMBARI-20739


Repository: ambari


Description
---

Although we can create the alert target of type ALERT_SCRIPT by web ui, we 
still need access to ambari.properties to add the new script and then restart 
ambari server to make this function take effect.
It is better specify the script directly in alert target rather than in 
ambari.properties.In this way,we also don't need to restart ambari server.

So now on web ui we will two ways to configure the script location for 
script-based alert dispatchers:
1.By script dispatch property (ambari.dispatch-property.script).This is already 
supported in previous ambari release.
Please see 
https://cwiki.apache.org/confluence/display/AMBARI/Creating+a+Script-based+Alert+Dispatcher+-+2.4.0

2.By script filename(ambari.dispatch-property.script.filename).
This new way will lookup the script by filename in script directory,default in 
/var/lib/ambari-server/resources/scripts.
We can change the directory in ambari.properties by 
ambari.dispatch-property.script.directory property.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
 d65a11d 
  
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcherTest.java
 68e7d02 
  
ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js 
df15513 
  ambari-web/app/messages.js 0c15a19 
  ambari-web/app/templates/main/alerts/create_alert_notification.hbs 7ec5b1e 
  ambari-web/app/utils/validator.js c069724 
  
ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
 0d58afa 


Diff: https://reviews.apache.org/r/59440/diff/1/


Testing
---

Unit Tests
1.cd ambari-web & mvn test
  21212 passing (32s)
  128 pending

2.cd ambari-server & mvn test
  Results :
  Failed tests: 
 ExportBlueprintRequestTest.testExport_noConfigs:138 expected:<3> but 
was:<4>
  Tests run: 4990, Failures: 1, Errors: 0, Skipped: 39
 

Test Cases

Case 1:
a.Write a shell script named foo.sh and put it in the directory 
/var/lib/ambari-server/resources/scripts,its content is as following:

#!/bin/bash
logFile=/var/log/ambari-server/log_script_filename.log
definitionName=$1
definitionLabel=$2
serviceName=$3
alertState=$4 
alertText=$5
alertTimestamp=$6
hostname=$7
echo received $# parameters:  $definitionName, $definitionLabel, $serviceName, 
$alertState ,$alertText ,$alertTimestamp, $hostname  >> $logFile

b.Create an alert target of type ALERT_SCRIPT on web ui and set Script Filename 
with foo.sh.
c.Stop or start any service , wait for a moment, we can see the log in 
/var/ambari-server/log_script_filename.log


Case 2:
a.Add 
ambari.dispatch-property.script.directory=/var/lib/ambari-server/resources/scripts/alerts
 to ambari.properties and move foo.sh to this directory.
b.Restart ambari-server and delete /var/ambari-server/log_script_filename.log
c.Stop or start any service, wait for a moment, we can see the log in 
/var/ambari-server/log_script_filename.log


Case 3:
a.Modify previous alert target on web ui and set Script Dispatch Property with  
com.mycompany.dispatch.shell.script
b.Write a shell script named foo2.sh and put it in directory 
/var/lib/ambari-server/resources/scripts too,its content is as following:

#!/bin/bash
logFile=/var/log/ambari-server/log_script_dispatch_property.log
definitionName=$1
definitionLabel=$2
serviceName=$3
alertState=$4 
alertText=$5
alertTimestamp=$6
hostname=$7

b.Add 
com.mycompany.dispatch.shell.script=/var/lib/ambari-server/resources/scripts/foo2.sh
 to ambari.properties.
c.Restart ambari-server and delete /var/ambari-server/log_script_filename.log
d.Stop or start any service,wait for a moment, we should see log in 
/var/ambari-server/log_script_filename.log and 
/var/log/ambari-server/log_script_dispatch_property.log is not exited.


Case 4:
a.Modify previous target and set Script Filename with empty
b.Delete /var/ambari-server/log_script_filename.log
c.Stop or start any service , wait for a moment, we should see log in 
/var/log/ambari-server/log_script_dispatch_property.log and 
/var/ambari-server/log_script_filename.log is not exited any more.


Thanks,

yao lei