Re: Review Request 59648: Add a flag to indicate NN restart is rolling

[Vitalyi Brodetskyi]

> On Червень 14, 2017, 6:46 після полудня, Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
> > Lines 329 (patched)
> > 
> >
> > Is there any way we can recommend a higher value for larger clusters 
> > with a bigger FS image?
> > 
> > Perhaps this is something we can calculate on-the-fly

The goal of this jira was to give ability for user set custom timeout for 
rolling restart and exit from NN safemode, and now user can do that via API or 
configs.sh (to update cluster-env). I think it will be hard to calculate how 
much time NN needs to exit safemode on current cluster. Sid said that it takes 
40-60 minutes for large clusters on customer side, so i set max value. If 
that's not enough user can change it. To my mind it will be enough for almost 
all users.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59648/#review177936
---


On Червень 14, 2017, 6:22 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59648/
> ---
> 
> (Updated Червень 14, 2017, 6:22 після полудня)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21148
> https://issues.apache.org/jira/browse/AMBARI-21148
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If restart is rolling stack script should wait for NN to be out of safemode 
> with large timeout.
> Rolling indicates its an HDFS level restart so NN restart needs to be up and 
> accepting requests before we move on.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  07f6e30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8d262e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  60665f7 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
> 9930148 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  aa34dc0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  65cd378 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  e88dbdd 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
>  a0ed658 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
>  a42ca79 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_linux.py
>  58bb65f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  733b10d 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml 
> a79e904 
> 
> 
> Diff: https://reviews.apache.org/r/59648/diff/4/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59956/#review177964
---


Ship it!




Ship It!

- Jonathan Hurley


On June 14, 2017, 5:22 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59956/
> ---
> 
> (Updated June 14, 2017, 5:22 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21147
> https://issues.apache.org/jira/browse/AMBARI-21147
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Database Access Layer to Support New Database Schema for Improved User 
> Account Management.  
> 
> * Update `org.apache.ambari.server.orm.entities.UserEntity`
> * Update `org.apache.ambari.server.orm.dao.UserDAO`
> * Add `org.apache.ambari.server.orm.entities.UserAuthenticationEntity`
> * Add `org.apache.ambari.server.orm.dao.UserAuthenticationDAO`
> 
> Note: Some changes will be revisited when updating the different 
> authentication processes to work with the improved user account management 
> code.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/generated/index.html 7ea4297b99 
>   ambari-server/docs/api/generated/swagger.json d7d54a510f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  fb06e6d8a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  807bded873 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8d262e269b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  aeba739a6d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  f3c2ec871b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  391213858e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequest.java
>  40818c8f48 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
>  5afacb70ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b35b2a8612 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
>  389f0b2bf2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  614f7abda1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
>  c5c36e9942 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 
> ce47c4c38c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
>  9011eaecec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilter.java
>  195c55afa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AuthenticationMethodNotAllowedException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
>  1e4f6ead08 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationProperties.java
>  09422e51e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
>  ce9a79023d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  b7ff297ce5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java
>  d38d44c16f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  37d5d49c37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  373552e6e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariUserAuthorizationFilter.java
>  95e90b3e49 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java
>  64d5e6124f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/User.java
>  bff1fd2a16 
>   
> 

Re: Review Request 60098: Add Kerberos HTTP SPNEGO authentication support to Accumulo

[Qin Liu]

> On June 14, 2017, 9:32 p.m., Robert Levas wrote:
> > Ship It!

Hi Robert, Thank you so much for your quick response!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60098/#review177957
---


On June 14, 2017, 9:24 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60098/
> ---
> 
> (Updated June 14, 2017, 9:24 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Robert Levas.
> 
> 
> Bugs: AMBARI-21230
> https://issues.apache.org/jira/browse/AMBARI-21230
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> 
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Accumulo sinks, clients of Ambari Metrics Collector, currently do not support 
> Kerberos HTTP SPNEGO authentication.
> 
> e.g., /var/log/accumulo/tserver_.debug.log:
> 2017-06-06 23:07:39,918 [timeline.HadoopTimelineMetricsSink] INFO : Received 
> WWW-Authentication header:Negotiate, for URL: 
> http://:6188/ws/v1/timeline/metrics
> 2017-06-06 23:07:39,927 [timeline.HadoopTimelineMetricsSink] INFO : No live 
> collector to send metrics to. Metrics to be sent will be discarded. This 
> message will be skipped for the next 20 times.
> 
> In addition, this JIRA is going to fix the following sink connection 
> exception which will lead to miss one metrics submission right after 
> WWW-Authentication negociate:
> 
> 2017-06-06 14:30:19,722 ERROR [timeline] impl.MetricsSinkAdapter: Got sink 
> exception, retry in 602ms
> java.lang.IllegalStateException: Already connected
> at 
> sun.net.www.protocol.http.HttpURLConnection.setRequestProperty(HttpURLConnection.java:3053)
> at 
> org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetricsJson(AbstractTimelineMetricsSink.java:201)
> at 
> org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:302)
> at 
> org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:352)
> at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:186)
> at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
> at 
> org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
> at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:134)
> at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)
> 2017-06-06 14:30:28,781 INFO  [timeline] timeline.HadoopTimelineMetricsSink: 
> Using cached app cookie for 
> URL:http://:6188/ws/v1/timeline/metrics
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  644d978 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
>  1e5eb54 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
>  f65b68a 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  5d21514 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/accumulo_jaas.conf.j2
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60098/diff/1/
> 
> 
> Testing
> ---
> 
> The fix has passed the existing testcases. 
> The fix has been manually tested via HDP/trunk.
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 60045: Add validation and recommendation if hive user value is different than hive

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60045/#review177956
---


Ship it!




Ship It!

- Sid Wagle


On June 13, 2017, 11:57 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60045/
> ---
> 
> (Updated June 13, 2017, 11:57 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-21237
> https://issues.apache.org/jira/browse/AMBARI-21237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> By default yarn.nodemanager.kill-escape.user is set to hive the default 
> username for Hive. When custom hive user is used the above property should be 
> modified via stack advisor and also validation error must be reported if the 
> value is not correct.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml
>  cab0e65 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 9cd4acf 
> 
> 
> Diff: https://reviews.apache.org/r/60045/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

[Robert Levas]

> On June 12, 2017, 10:06 a.m., Laszlo Puskas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
> > Lines 97 (patched)
> > 
> >
> > I think cascading should be removed here (AFAIK there were some issues 
> > where cascading was interfering with some DAO logic)
> 
> Robert Levas wrote:
> Cascade seems to be used a few lines up in this file...
> ```
>   @OneToMany(mappedBy = "user", cascade = CascadeType.ALL)
>   private Set memberEntities = new HashSet<>();
> ```
> 
> Other than that, a quick search in the source code reveals 72 occurances 
> of this, 42 instances are of `CascadeType.ALL`.
> 
> So far my tests seem to work ok.
> 
> Sebastian Toader wrote:
> There was already an attempt to remove the Cascadings. I guess these are 
> left overs.
> 
> Robert Levas wrote:
> What is the alternative to cascading?  If I remove a user, I will need to 
> add code in the DAO to first remove the user authentication records?
> 
> Jonathan Hurley wrote:
> I don't have problems with cascading as long as the entity relationships 
> are setup correctly for it. In many places, they are not and we need to rely 
> on the DAO to do the work. Maintaining these methods seems to be a source of 
> bugs, so if the entities here can be cascaded correctly, then I don't see why 
> it would be a problem.

The entity relationship is set up properly:

```
CONSTRAINT FK_user_authentication_users FOREIGN KEY (user_id) REFERENCES 
users(user_id)
```

So how do we want to proceed?  Laszlo?


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59956/#review177610
---


On June 14, 2017, 5:22 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59956/
> ---
> 
> (Updated June 14, 2017, 5:22 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21147
> https://issues.apache.org/jira/browse/AMBARI-21147
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Database Access Layer to Support New Database Schema for Improved User 
> Account Management.  
> 
> * Update `org.apache.ambari.server.orm.entities.UserEntity`
> * Update `org.apache.ambari.server.orm.dao.UserDAO`
> * Add `org.apache.ambari.server.orm.entities.UserAuthenticationEntity`
> * Add `org.apache.ambari.server.orm.dao.UserAuthenticationDAO`
> 
> Note: Some changes will be revisited when updating the different 
> authentication processes to work with the improved user account management 
> code.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/generated/index.html 7ea4297b99 
>   ambari-server/docs/api/generated/swagger.json d7d54a510f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  fb06e6d8a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  807bded873 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8d262e269b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  aeba739a6d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  f3c2ec871b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  391213858e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequest.java
>  40818c8f48 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
>  5afacb70ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b35b2a8612 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
>  389f0b2bf2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  614f7abda1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
>  c5c36e9942 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 
> ce47c4c38c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
>  9011eaecec 

Re: Review Request 60098: Add Kerberos HTTP SPNEGO authentication support to Accumulo

[Qin Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60098/
---

(Updated June 14, 2017, 9:24 p.m.)


Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Robert Levas.


Bugs: AMBARI-21230
https://issues.apache.org/jira/browse/AMBARI-21230


Repository: ambari


Description (updated)
---

This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
authenticate".

In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
Accumulo sinks, clients of Ambari Metrics Collector, currently do not support 
Kerberos HTTP SPNEGO authentication.

e.g., /var/log/accumulo/tserver_.debug.log:
2017-06-06 23:07:39,918 [timeline.HadoopTimelineMetricsSink] INFO : Received 
WWW-Authentication header:Negotiate, for URL: 
http://:6188/ws/v1/timeline/metrics
2017-06-06 23:07:39,927 [timeline.HadoopTimelineMetricsSink] INFO : No live 
collector to send metrics to. Metrics to be sent will be discarded. This 
message will be skipped for the next 20 times.

In addition, this JIRA is going to fix the following sink connection exception 
which will lead to miss one metrics submission right after WWW-Authentication 
negociate:

2017-06-06 14:30:19,722 ERROR [timeline] impl.MetricsSinkAdapter: Got sink 
exception, retry in 602ms
java.lang.IllegalStateException: Already connected
at 
sun.net.www.protocol.http.HttpURLConnection.setRequestProperty(HttpURLConnection.java:3053)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetricsJson(AbstractTimelineMetricsSink.java:201)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:302)
at 
org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:352)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:186)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
at 
org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:134)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)
2017-06-06 14:30:28,781 INFO  [timeline] timeline.HadoopTimelineMetricsSink: 
Using cached app cookie for 
URL:http://:6188/ws/v1/timeline/metrics


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 644d978 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
 1e5eb54 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
 f65b68a 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 5d21514 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/accumulo_jaas.conf.j2
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60098/diff/1/


Testing
---

The fix has passed the existing testcases. 
The fix has been manually tested via HDP/trunk.


Thanks,

Qin Liu

Review Request 60098: Add Kerberos HTTP SPNEGO authentication support to Accumulo

[Qin Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60098/
---

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Robert Levas.


Summary (updated)
-

Add Kerberos HTTP SPNEGO authentication support to Accumulo


Bugs: AMBARI-21230
https://issues.apache.org/jira/browse/AMBARI-21230


Repository: ambari


Description (updated)
---

This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
authenticate".

In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
Accumulo sinks, clients of Ambari Metrics Collector, currently do not support 
Kerberos HTTP SPNEGO authentication.

e.g., /var/log/accumulo/tserver_.debug.log:
2017-06-06 23:07:39,918 [timeline.HadoopTimelineMetricsSink] INFO : Received 
WWW-Authentication header:Negotiate, for URL: 
http://:6188/ws/v1/timeline/metrics
2017-06-06 23:07:39,927 [timeline.HadoopTimelineMetricsSink] INFO : No live 
collector to send metrics to. Metrics to be sent will be discarded. This 
message will be skipped for the next 20 times.

In addition, this JIRA is going to fix the following sink connection exception 
which will lead to miss one metrics submission right after WWW-
Authentication negociate:

2017-06-06 14:30:19,722 ERROR [timeline] impl.MetricsSinkAdapter: Got sink 
exception, retry in 602ms
java.lang.IllegalStateException: Already connected
at 
sun.net.www.protocol.http.HttpURLConnection.setRequestProperty(HttpURLConnection.java:3053)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetricsJson(AbstractTimelineMetricsSink.java:201)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:302)
at 
org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:352)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:186)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
at 
org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:134)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)
2017-06-06 14:30:28,781 INFO  [timeline] timeline.HadoopTimelineMetricsSink: 
Using cached app cookie for 
URL:http://:6188/ws/v1/timeline/metrics


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 644d978 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
 1e5eb54 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
 f65b68a 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 5d21514 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/accumulo_jaas.conf.j2
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60098/diff/1/


Testing (updated)
---

The fix has passed the existing testcases. 
The fix has been manually tested via HDP/trunk.


Thanks,

Qin Liu

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59956/
---

(Updated June 14, 2017, 5:22 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-21147
https://issues.apache.org/jira/browse/AMBARI-21147


Repository: ambari


Description
---

Update Database Access Layer to Support New Database Schema for Improved User 
Account Management.  

* Update `org.apache.ambari.server.orm.entities.UserEntity`
* Update `org.apache.ambari.server.orm.dao.UserDAO`
* Add `org.apache.ambari.server.orm.entities.UserAuthenticationEntity`
* Add `org.apache.ambari.server.orm.dao.UserAuthenticationDAO`

Note: Some changes will be revisited when updating the different authentication 
processes to work with the improved user account management code.


Diffs (updated)
-

  ambari-server/docs/api/generated/index.html 7ea4297b99 
  ambari-server/docs/api/generated/swagger.json d7d54a510f 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 fb06e6d8a5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 807bded873 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 8d262e269b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 aeba739a6d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 f3c2ec871b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 391213858e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequest.java
 40818c8f48 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
 5afacb70ef 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 b35b2a8612 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
 389f0b2bf2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
 614f7abda1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
 c5c36e9942 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 
ce47c4c38c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
 9011eaecec 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilter.java
 195c55afa5 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AuthenticationMethodNotAllowedException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
 1e4f6ead08 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationProperties.java
 09422e51e3 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
 ce9a79023d 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
 b7ff297ce5 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java
 d38d44c16f 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
 37d5d49c37 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 373552e6e1 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariUserAuthorizationFilter.java
 95e90b3e49 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java
 64d5e6124f 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/User.java
 bff1fd2a16 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
 aabd368aeb 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 9cdde8fe4d 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/internal/AmbariInternalAuthenticationProvider.java
 383e8fac87 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/AuthenticationJwtUserNotFoundException.java
 f18af101a2 
  

Re: Review Request 60086: AMBARI-21246. Build creates tarball twice

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60086/#review177953
---



Nice one

- Andrew Onischuk


On June 14, 2017, 3:12 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60086/
> ---
> 
> (Updated June 14, 2017, 3:12 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Oliver Szabo, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21246
> https://issues.apache.org/jira/browse/AMBARI-21246
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Override inherited `execution` instead of defining new one.
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml c1cb056ac64d1c4d7a863ffb527dd0186cbed1ea 
>   ambari-server/pom.xml ac78595d8665fc90c15c4638e583b72b42f5a19f 
> 
> 
> Diff: https://reviews.apache.org/r/60086/diff/1/
> 
> 
> Testing
> ---
> 
> Built time is reduced from:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean 
> package
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  7.937 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.038 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.618 
> s]
> [INFO] utility  SUCCESS [  1.881 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.738 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  4.212 
> s]
> [INFO] Service Advisor  SUCCESS [  0.497 
> s]
> [INFO] Ambari Server .. SUCCESS [03:20 
> min]
> [INFO] Ambari Agent ... SUCCESS [01:15 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 04:53 min
> ```
> 
> to:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean 
> package
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  6.490 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.055 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.777 
> s]
> [INFO] utility  SUCCESS [  2.110 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.933 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  6.133 
> s]
> [INFO] Service Advisor  SUCCESS [  0.691 
> s]
> [INFO] Ambari Server .. SUCCESS [02:44 
> min]
> [INFO] Ambari Agent ... SUCCESS [01:08 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 04:12 min
> ```
> 
> `tar.gz` is built exactly once:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean 
> package
> ...
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ 
> ambari-server ---
> [INFO] Reading assembly descriptor: src/main/assemblies/server.xml
> ...
> [INFO] Building tar : 
> ambari-server/target/ambari-server-2.0.0.0-SNAPSHOT-dist.tar.gz
> ...
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ 
> ambari-agent ---
> [INFO] Reading assembly descriptor: src/packages/tarball/all.xml
> ...
> [INFO] Building tar : ambari-agent/target/ambari-agent-2.0.0.0-SNAPSHOT.tar.gz
> ```
> 
> `tar.gz` can be skipped:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests 
> -DassemblyPhase=none clean package
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  7.720 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.039 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.584 
> s]
> [INFO] utility  SUCCESS [  2.085 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.723 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  4.682 
> s]
> [INFO] Service Advisor  SUCCESS [  0.480 
> s]
> [INFO] Ambari Server .. SUCCESS [01:15 
> min]
> [INFO] Ambari Agent 

Re: Review Request 60033: Ambari data purging

[Sebastian Toader]

> On June 14, 2017, 8:53 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
> > Line 944 (original), 945 (patched)
> > 
> >
> > Can you describe how the cleanup is done?
> > If the user selects a date that falls in the middle so that some tasks 
> > in the same request are before and others after, what happens?
> > Does it delete records from the upgrade table?
> > Does it delete records from the topology* tables?
> > Does it delete records from alert history?

For detail of what records are being deleted see 
https://issues.apache.org/jira/browse/AMBARI-20687 which is the original 
implementation. The deletion of Alert history was already covered in a previous 
Ambari version through https://issues.apache.org/jira/browse/AMBARI-15133


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60033/#review177937
---


On June 13, 2017, 6:43 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60033/
> ---
> 
> (Updated June 13, 2017, 6:43 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo 
> Puskas, Robert Levas, Sandor Magyari, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20749
> https://issues.apache.org/jira/browse/AMBARI-20749
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding a couple of  fixes to 
> https://issues.apache.org/jira/browse/AMBARI-20687 and renaming the 
> db-cleanup functionality to db-purge-history
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server 7044096 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  70c3661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java
>  788290b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupService.java
>  880207c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java
>  29a9041 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  b9e1fab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 38c0977 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  eea8032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  32a38da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  3a72aed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  37830b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  1536b80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  2954863 
>   ambari-server/src/main/python/ambari-server.py 235ef95 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py 6e16bc5 
>   ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java
>  7de5aae 
> 
> 
> Diff: https://reviews.apache.org/r/60033/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> ambari-server db-purge-history --cluster-name cl1 --from-date 2017-06-13
> 
> Verified that all request related records except the ones that belong to 
> upgrade were purged.
> 
> 
> Unit tests:
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.811 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.004 
> s]
> [INFO] Ambari Views ... SUCCESS [  3.824 
> s]
> [INFO] utility  SUCCESS [  1.411 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.387 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.708 
> s]
> [INFO] Ambari Server .. SUCCESS [33:10 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:25 min
> [INFO] Finished at: 2017-06-12T23:20:03+02:00
> [INFO] Final Memory: 56M/389M
> [INFO] 
> 

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59956/#review177947
---


Ship it!




Ship It!

- Sebastian Toader


On June 12, 2017, 7:15 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59956/
> ---
> 
> (Updated June 12, 2017, 7:15 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21147
> https://issues.apache.org/jira/browse/AMBARI-21147
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Database Access Layer to Support New Database Schema for Improved User 
> Account Management.  
> 
> * Update `org.apache.ambari.server.orm.entities.UserEntity`
> * Update `org.apache.ambari.server.orm.dao.UserDAO`
> * Add `org.apache.ambari.server.orm.entities.UserAuthenticationEntity`
> * Add `org.apache.ambari.server.orm.dao.UserAuthenticationDAO`
> 
> Note: Some changes will be revisited when updating the different 
> authentication processes to work with the improved user account management 
> code.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/generated/index.html 7ea4297b99 
>   ambari-server/docs/api/generated/swagger.json d7d54a510f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  fb06e6d8a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  807bded873 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  eb64030e45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  aeba739a6d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  f3c2ec871b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  391213858e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequest.java
>  40818c8f48 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
>  5afacb70ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b35b2a8612 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
>  389f0b2bf2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  614f7abda1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
>  c5c36e9942 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 
> ce47c4c38c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
>  9011eaecec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilter.java
>  195c55afa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AuthenticationMethodNotAllowedException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
>  1e4f6ead08 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationProperties.java
>  09422e51e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
>  ce9a79023d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  b7ff297ce5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java
>  d38d44c16f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  37d5d49c37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  373552e6e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariUserAuthorizationFilter.java
>  95e90b3e49 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java
>  64d5e6124f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/User.java
>  bff1fd2a16 
>   
> 

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

[Oliver Szabo]

> On June 14, 2017, 3:16 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> > Lines 1467 (patched)
> > 
> >
> > Are there other places where you need to use this? Like from 
> > AmbariManagementControllerImpl or the Action command helper?

no we only need that where we added java_home to the hostLevelParams before (at 
stage creation, luckily we are doing that only that place where I added, I did 
not find anything else where we filling the jdk_name or java_home).


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59954/#review177903
---


On June 14, 2017, 7:15 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59954/
> ---
> 
> (Updated June 14, 2017, 7:15 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Robert 
> Nettleton, Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21099
> https://issues.apache.org/jira/browse/AMBARI-21099
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Requirements:
> - ambari should drop JDK 7 support for ambari-server and ambari-managed 
> services (infra, ams, logsearch), so force to use jdk8
> - HDP 2.x should be still able to use JDK 1.7
> Changes in ambari setup:
> 1. First the usual ambari setup
> 
> Choose JDK for Ambari and Stack services:
> [1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
> [2] Oracle JDK 1.7 + Java Cryptography Extension (JCE) Policy Files 7
> [3] Custom JDK
> 
> 2. If JDK 7 is picked, that cannot be used for ambari (only for the stack 
> services)
> 
> JDK 7 is detected (JDK 8 required for ambari-server), install JDK 8 as well:
> [1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
> [3] Custom JDK
> 
> 
> (this commands can be used is silent mode: ambari-server setup 
> --java-home=... --stack-java-home=...)
> 
> After the commands are executed, the following properties would appear in 
> ambari.properties
> 
> stack.java.home=/usr/jdk64/jdk1.7.0_67
> stack.jdk.name=jdk-7u67linux-x64.tar.gz
> stack.jce.name=UnlimitedJCEPolicyJDK7.zip
> 
> During command.json generating, commandParameters would be filled with proper 
> ambari jdk,jce info (different for infra/logsearch/ams from other services) - 
> not hostLevelParams, as multiple command could use the same hostLevelParams 
> (like start all services: that can start zookeeper and ams as well with the 
> same hostLevelParams)
> 
> On ambari-upgrade, ambari process wont be able to start with jdk7 so it will 
> be required to run ambari-server setup first (you can skip the first change 
> jdk part, but then the user will see its needed to setup a different jdk for 
> ambari)
> 
> In the future, it will be recommended to do the JDK upgrade before upgrading 
> to HDP 3.0 (to avoid some issues during HDP upgrade)
> 
> next step: 
> - add function to ambari common to validate jdk version (inorder to fail 
> starting any service which require jdk 8)
> 
> open question:
> - there can be a more flexible solution to include different jdks in ambari 
> (based on jdk releases list) and send all of them in the command.json, and 
> chose the proper one for different services. also that can cause some issues 
> with custom jdks (adding a name to custom ones?), and also because the jdk 
> names can be anything, we would need to validate/get the jdk version during 
> sending a command to the agent. all of this work has done about to support 
> older version of HDP, so im not sure about to create a flexible solution at 
> all, as managing multiple JDKs can be really hard for a customer, so i would 
> not recommend to use multiple ones.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 2394264 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  60df8cf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  fb06e6d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  1b0e0e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  07f6e30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8d262e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  21cf16c 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
> 9930148 
>   

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59954/
---

(Updated June 14, 2017, 7:15 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Robert 
Nettleton, Sumit Mohanty, Sebastian Toader, and Sid Wagle.


Changes
---

extend jdk docs


Bugs: AMBARI-21099
https://issues.apache.org/jira/browse/AMBARI-21099


Repository: ambari


Description
---

Requirements:
- ambari should drop JDK 7 support for ambari-server and ambari-managed 
services (infra, ams, logsearch), so force to use jdk8
- HDP 2.x should be still able to use JDK 1.7
Changes in ambari setup:
1. First the usual ambari setup

Choose JDK for Ambari and Stack services:
[1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
[2] Oracle JDK 1.7 + Java Cryptography Extension (JCE) Policy Files 7
[3] Custom JDK

2. If JDK 7 is picked, that cannot be used for ambari (only for the stack 
services)

JDK 7 is detected (JDK 8 required for ambari-server), install JDK 8 as well:
[1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
[3] Custom JDK


(this commands can be used is silent mode: ambari-server setup --java-home=... 
--stack-java-home=...)

After the commands are executed, the following properties would appear in 
ambari.properties

stack.java.home=/usr/jdk64/jdk1.7.0_67
stack.jdk.name=jdk-7u67linux-x64.tar.gz
stack.jce.name=UnlimitedJCEPolicyJDK7.zip

During command.json generating, commandParameters would be filled with proper 
ambari jdk,jce info (different for infra/logsearch/ams from other services) - 
not hostLevelParams, as multiple command could use the same hostLevelParams 
(like start all services: that can start zookeeper and ams as well with the 
same hostLevelParams)

On ambari-upgrade, ambari process wont be able to start with jdk7 so it will be 
required to run ambari-server setup first (you can skip the first change jdk 
part, but then the user will see its needed to setup a different jdk for ambari)

In the future, it will be recommended to do the JDK upgrade before upgrading to 
HDP 3.0 (to avoid some issues during HDP upgrade)

next step: 
- add function to ambari common to validate jdk version (inorder to fail 
starting any service which require jdk 8)

open question:
- there can be a more flexible solution to include different jdks in ambari 
(based on jdk releases list) and send all of them in the command.json, and 
chose the proper one for different services. also that can cause some issues 
with custom jdks (adding a name to custom ones?), and also because the jdk 
names can be anything, we would need to validate/get the jdk version during 
sending a command to the agent. all of this work has done about to support 
older version of HDP, so im not sure about to create a flexible solution at 
all, as managing multiple JDKs can be really hard for a customer, so i would 
not recommend to use multiple ones.


Diffs (updated)
-

  ambari-server/docs/configuration/index.md 2394264 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 60df8cf 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 fb06e6d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 1b0e0e0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 07f6e30 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 8d262e2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 21cf16c 
  ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
9930148 
  ambari-server/src/main/python/ambari-server.py d84e833 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 
  ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 6eb3ba8 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 b8c14f4 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 36c4598 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 d26df33 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 6738c5c 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 094d239 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 85eb796 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 4052d1d 
  

Re: Review Request 60076: Improve Zeppelin startup time

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60076/#review177938
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 14, 2017, 11:14 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60076/
> ---
> 
> (Updated June 14, 2017, 11:14 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21243
> https://issues.apache.org/jira/browse/AMBARI-21243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently Zeppelin takes more than 1 minute to start. The bulk of the time 
> during startup is spent with waiting on interpreter.json.
> 
> So the idea of this patch is to have interpeter.json cached, and apply it 
> does not exists.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/interpreter_json_template.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  3d516b0c68 
> 
> 
> Diff: https://reviews.apache.org/r/60076/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 59648: Add a flag to indicate NN restart is rolling

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59648/#review177936
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
Lines 329 (patched)


Is there any way we can recommend a higher value for larger clusters with a 
bigger FS image?

Perhaps this is something we can calculate on-the-fly


- Alejandro Fernandez


On June 14, 2017, 6:22 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59648/
> ---
> 
> (Updated June 14, 2017, 6:22 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21148
> https://issues.apache.org/jira/browse/AMBARI-21148
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If restart is rolling stack script should wait for NN to be out of safemode 
> with large timeout.
> Rolling indicates its an HDFS level restart so NN restart needs to be up and 
> accepting requests before we move on.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  07f6e30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8d262e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  60665f7 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
> 9930148 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  aa34dc0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  65cd378 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  e88dbdd 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
>  a0ed658 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
>  a42ca79 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_linux.py
>  58bb65f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  733b10d 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml 
> a79e904 
> 
> 
> Diff: https://reviews.apache.org/r/59648/diff/4/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60055: Support revert for patch upgrades

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60055/#review177933
---


Ship it!




Ship It!

- Jonathan Hurley


On June 14, 2017, 12:35 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60055/
> ---
> 
> (Updated June 14, 2017, 12:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21241
> https://issues.apache.org/jira/browse/AMBARI-21241
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Entails adding an option to specify a previous upgrade to revert.  Checks to 
> make sure it's only a patch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a66db3c008 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
>  c8c9f9ed2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
>  ea8fb372dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  60665f7b2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  43b2e088d7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  e70f1ce8b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
>  8a4820d7f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  3ecf64dc0c 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e34140593a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ce8736e62d 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ace3738d2c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5899179aba 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 6164b2de5c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 52d2b87c74 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  a37e4f5d12 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  014ab4223f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  921322b68c 
>   ambari-server/src/test/resources/hbase_version_test.xml 58c87015b5 
> 
> 
> Diff: https://reviews.apache.org/r/60055/diff/3/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:08 min
> [INFO] Finished at: 2017-06-13T17:18:07-04:00
> [INFO] Final Memory: 73M/673M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 59648: Add a flag to indicate NN restart is rolling

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59648/
---

(Updated Червень 14, 2017, 6:22 після полудня)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-21148
https://issues.apache.org/jira/browse/AMBARI-21148


Repository: ambari


Description
---

If restart is rolling stack script should wait for NN to be out of safemode 
with large timeout.
Rolling indicates its an HDFS level restart so NN restart needs to be up and 
accepting requests before we move on.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 07f6e30 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 8d262e2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 60665f7 
  ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
9930148 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 aa34dc0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 65cd378 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 e88dbdd 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
 a0ed658 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
 a42ca79 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_linux.py
 58bb65f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
733b10d 
  ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml 
a79e904 


Diff: https://reviews.apache.org/r/59648/diff/4/

Changes: https://reviews.apache.org/r/59648/diff/3-4/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 59648: Add a flag to indicate NN restart is rolling

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59648/
---

(Updated Червень 14, 2017, 6 після полудня)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-21148
https://issues.apache.org/jira/browse/AMBARI-21148


Repository: ambari


Description
---

If restart is rolling stack script should wait for NN to be out of safemode 
with large timeout.
Rolling indicates its an HDFS level restart so NN restart needs to be up and 
accepting requests before we move on.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 07f6e30 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 8d262e2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 60665f7 
  ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
9930148 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 aa34dc0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 65cd378 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 e88dbdd 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
733b10d 
  ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml 
a79e904 


Diff: https://reviews.apache.org/r/59648/diff/3/

Changes: https://reviews.apache.org/r/59648/diff/2-3/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

[Robert Levas]

> On June 13, 2017, 9:11 a.m., Attila Magyar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
> > Lines 98 (patched)
> > 
> >
> > Can't we just initialize Collections like this to empty collections 
> > (instead of null)? This would make most of the null checks unnecessary.

Fixing.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59956/#review177734
---


On June 12, 2017, 1:15 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59956/
> ---
> 
> (Updated June 12, 2017, 1:15 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21147
> https://issues.apache.org/jira/browse/AMBARI-21147
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Database Access Layer to Support New Database Schema for Improved User 
> Account Management.  
> 
> * Update `org.apache.ambari.server.orm.entities.UserEntity`
> * Update `org.apache.ambari.server.orm.dao.UserDAO`
> * Add `org.apache.ambari.server.orm.entities.UserAuthenticationEntity`
> * Add `org.apache.ambari.server.orm.dao.UserAuthenticationDAO`
> 
> Note: Some changes will be revisited when updating the different 
> authentication processes to work with the improved user account management 
> code.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/generated/index.html 7ea4297b99 
>   ambari-server/docs/api/generated/swagger.json d7d54a510f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  fb06e6d8a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  807bded873 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  eb64030e45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  aeba739a6d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  f3c2ec871b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  391213858e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequest.java
>  40818c8f48 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
>  5afacb70ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b35b2a8612 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
>  389f0b2bf2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  614f7abda1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
>  c5c36e9942 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 
> ce47c4c38c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
>  9011eaecec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilter.java
>  195c55afa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AuthenticationMethodNotAllowedException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
>  1e4f6ead08 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationProperties.java
>  09422e51e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
>  ce9a79023d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  b7ff297ce5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java
>  d38d44c16f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  37d5d49c37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  373552e6e1 

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

[Robert Levas]

> On June 14, 2017, 11:46 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
> > Lines 43 (patched)
> > 
> >
> > Should this PK be a Long?

Probably... copy/paste issue from UserEntity...

``` 
  @RequiresSession
  public UserEntity findByPK(Integer userPK) {
return entityManagerProvider.get().find(UserEntity.class, userPK);
  }
```

Fixing.


> On June 14, 2017, 11:46 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
> > Lines 49 (patched)
> > 
> >
> > Can you make this a NamedQuery in the UserAuthenticationEntity?

Fixing.


> On June 14, 2017, 11:46 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
> > Lines 79 (patched)
> > 
> >
> > remove(merge()) ? Is this necessary? Seems like the merge would only 
> > keep entities consistent before the removal if you did something like 
> > change a collection. I wouldn't think you'd need to do this.

Another copy/paste issue

```
  @Transactional
  public void remove(UserEntity user) {
entityManagerProvider.get().remove(merge(user));
entityManagerProvider.get().getEntityManagerFactory().getCache().evictAll();
  }
```

Fixing.


> On June 14, 2017, 11:46 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
> > Lines 80 (patched)
> > 
> >
> > Why do you need to evict from the cache here? Since you're going 
> > through the entity for this, JPA should know to clean the shared caches 
> > correctly. I only would think this is necessary if you use JPQL to remove 
> > entities.

Seems like there may have been caching issues... but maybe only related to 
views?  See [AMBARI-7152](https://issues.apache.org/jira/browse/AMBARI-7152). 
Fixing.


> On June 14, 2017, 11:46 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java
> > Lines 118 (patched)
> > 
> >
> > Can you do the lowercase() in the entity instead? This way you don't 
> > need to remember to do it.

Fixing.


> On June 14, 2017, 11:46 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
> > Lines 73-76 (patched)
> > 
> >
> > Always initialized, but not enforced to be non-null.

Fixing...  Seems like there is no real need to set update and create time.  I 
will remove those.


> On June 14, 2017, 11:46 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
> > Lines 142-156 (patched)
> > 
> >
> > Any reason you didn't use EqualsBuilder here instead?

`EqualsBuilder` is new to me.  Fixing.


> On June 14, 2017, 11:46 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
> > Lines 76-83 (patched)
> > 
> >
> > Are these all nullable? The default when not specified is true.

`consecutive_failures` is not nullable, but the others are.  Fixing.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59956/#review177909
---


On June 12, 2017, 1:15 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59956/
> ---
> 
> (Updated June 12, 2017, 1:15 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21147
> https://issues.apache.org/jira/browse/AMBARI-21147
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Database Access Layer to Support New Database Schema for Improved User 
> Account Management.  
> 
> * Update `org.apache.ambari.server.orm.entities.UserEntity`
> * Update `org.apache.ambari.server.orm.dao.UserDAO`
> * Add `org.apache.ambari.server.orm.entities.UserAuthenticationEntity`
> * Add `org.apache.ambari.server.orm.dao.UserAuthenticationDAO`
> 
> Note: Some 

Re: Review Request 60092: Infra Manager: Use custom serializer for execution contexts of job & steps

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60092/#review177921
---


Ship it!




Ship It!

- Robert Nettleton


On June 14, 2017, 4:42 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60092/
> ---
> 
> (Updated June 14, 2017, 4:42 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21247
> https://issues.apache.org/jira/browse/AMBARI-21247
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Obtaining execution context of jobs/steps is not working as the framework 
> uses an XStreamExecutionContextStringSerializer by default, which cannot be 
> deserialized properly. Use an another serializer for that.
> 
> Also edit execution contexts and the exit desription of the dummy job.
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
>  95f87f5 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java
>  9a78706 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyJobListener.java
>  0bbfb55 
> 
> 
> Diff: https://reviews.apache.org/r/60092/diff/3/
> 
> 
> Testing
> ---
> 
> done, manually
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59951/
---

(Updated June 14, 2017, 4:44 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Changes
---

Fixed review issues.
Fixed a bug in metadata syncing.
Removed KafkaProducer usage in HBaseTimelineMetricService since it is causing 
deployment issues.


Bugs: AMBARI-21214
https://issues.apache.org/jira/browse/AMBARI-21214


Repository: ambari


Description
---

Presently AMS stores (metricName, hostname, serverTime, appId, instanceId) for 
every row. Although this makes SQL query easy to write, it adds duplication 
when storing it in the Regions memory. The plan is to have a unique integer ID 
for an application-instance metric on a host and use that as a lookup table 
with a write through cache when inserting or reading data in the METRIC_RECORD 
table.

WORK DONE
Added new logic for UUID management
Integrated the UUID management into metadata manager. 
Added UUID handling into write, read and aggregate paths. 

TODO
Fix downsampling use case for UUID change.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/SingleValuedTimelineMetric.java
 8ecca54 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java
 edace52 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetricMetadata.java
 727becc 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricsService.java
 f962f44 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 15b0bb8 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 de33bd1 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
 d052d54 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
 1446ec2 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AbstractTimelineAggregator.java
 cb131d3 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineClusterMetric.java
 b7d9110 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricAggregatorFactory.java
 2eb3553 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricAppAggregator.java
 9eaf456 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java
 74d4013 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 34b1f9b 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricHostAggregator.java
 a17433b 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java
 672f85f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricHostMetadata.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataKey.java
 504b502 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java
 8a71756 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataSync.java
 6d519f6 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/Condition.java
 9aa64bd 
  

Re: Review Request 60092: Infra Manager: Use custom serializer for execution contexts of job & steps

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60092/
---

(Updated June 14, 2017, 4:42 p.m.)


Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, and 
Sebastian Toader.


Changes
---

made bean from serializer


Bugs: AMBARI-21247
https://issues.apache.org/jira/browse/AMBARI-21247


Repository: ambari


Description
---

Obtaining execution context of jobs/steps is not working as the framework uses 
an XStreamExecutionContextStringSerializer by default, which cannot be 
deserialized properly. Use an another serializer for that.

Also edit execution contexts and the exit desription of the dummy job.


Diffs (updated)
-

  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
 95f87f5 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java
 9a78706 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyJobListener.java
 0bbfb55 


Diff: https://reviews.apache.org/r/60092/diff/3/

Changes: https://reviews.apache.org/r/60092/diff/2-3/


Testing
---

done, manually


Thanks,

Oliver Szabo

Re: Review Request 60055: Support revert for patch upgrades

[Jonathan Hurley]

> On June 14, 2017, 12:32 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
> > Lines 289 (patched)
> > 
> >
> > are we also going to support revert of SERVICE type upgrades?
> 
> Nate Cole wrote:
> No.  SERVICE upgrades are one-direction just like full RU.

No, only PATCH.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60055/#review177917
---


On June 14, 2017, 12:35 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60055/
> ---
> 
> (Updated June 14, 2017, 12:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21241
> https://issues.apache.org/jira/browse/AMBARI-21241
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Entails adding an option to specify a previous upgrade to revert.  Checks to 
> make sure it's only a patch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a66db3c008 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
>  c8c9f9ed2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
>  ea8fb372dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  60665f7b2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  43b2e088d7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  e70f1ce8b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
>  8a4820d7f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  3ecf64dc0c 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e34140593a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ce8736e62d 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ace3738d2c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5899179aba 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 6164b2de5c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 52d2b87c74 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  a37e4f5d12 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  014ab4223f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  921322b68c 
>   ambari-server/src/test/resources/hbase_version_test.xml 58c87015b5 
> 
> 
> Diff: https://reviews.apache.org/r/60055/diff/3/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:08 min
> [INFO] Finished at: 2017-06-13T17:18:07-04:00
> [INFO] Final Memory: 73M/673M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 60055: Support revert for patch upgrades

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60055/
---

(Updated June 14, 2017, 12:35 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
Jonathan Hurley.


Changes
---

Update for comment on making the direction DOWNGRADE instead of UPGRADE.


Bugs: AMBARI-21241
https://issues.apache.org/jira/browse/AMBARI-21241


Repository: ambari


Description
---

Entails adding an option to specify a previous upgrade to revert.  Checks to 
make sure it's only a patch.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
 a66db3c008 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
 c8c9f9ed2b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
 ea8fb372dc 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 60665f7b2b 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
 43b2e088d7 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 e70f1ce8b2 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
 8a4820d7f4 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
3ecf64dc0c 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e34140593a 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ce8736e62d 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ace3738d2c 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5899179aba 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6164b2de5c 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 52d2b87c74 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
 a37e4f5d12 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 014ab4223f 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 921322b68c 
  ambari-server/src/test/resources/hbase_version_test.xml 58c87015b5 


Diff: https://reviews.apache.org/r/60055/diff/3/

Changes: https://reviews.apache.org/r/60055/diff/2-3/


Testing
---

Manual.  Automated:

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 25:08 min
[INFO] Finished at: 2017-06-13T17:18:07-04:00
[INFO] Final Memory: 73M/673M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 60055: Support revert for patch upgrades

[Nate Cole]

> On June 14, 2017, 12:32 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
> > Lines 289 (patched)
> > 
> >
> > are we also going to support revert of SERVICE type upgrades?

No.  SERVICE upgrades are one-direction just like full RU.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60055/#review177917
---


On June 13, 2017, 5:19 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60055/
> ---
> 
> (Updated June 13, 2017, 5:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21241
> https://issues.apache.org/jira/browse/AMBARI-21241
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Entails adding an option to specify a previous upgrade to revert.  Checks to 
> make sure it's only a patch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a66db3c008 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
>  c8c9f9ed2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
>  ea8fb372dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  60665f7b2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  43b2e088d7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  e70f1ce8b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
>  8a4820d7f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  3ecf64dc0c 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e34140593a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ce8736e62d 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ace3738d2c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5899179aba 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 6164b2de5c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 52d2b87c74 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  a37e4f5d12 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  014ab4223f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  921322b68c 
>   ambari-server/src/test/resources/hbase_version_test.xml 58c87015b5 
> 
> 
> Diff: https://reviews.apache.org/r/60055/diff/2/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:08 min
> [INFO] Finished at: 2017-06-13T17:18:07-04:00
> [INFO] Final Memory: 73M/673M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 60055: Support revert for patch upgrades

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60055/#review177917
---




ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
Lines 289 (patched)


are we also going to support revert of SERVICE type upgrades?


- Dmitro Lisnichenko


On June 14, 2017, 12:19 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60055/
> ---
> 
> (Updated June 14, 2017, 12:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21241
> https://issues.apache.org/jira/browse/AMBARI-21241
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Entails adding an option to specify a previous upgrade to revert.  Checks to 
> make sure it's only a patch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a66db3c008 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
>  c8c9f9ed2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
>  ea8fb372dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  60665f7b2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  43b2e088d7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  e70f1ce8b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
>  8a4820d7f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  3ecf64dc0c 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e34140593a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ce8736e62d 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ace3738d2c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5899179aba 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 6164b2de5c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 52d2b87c74 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  a37e4f5d12 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  014ab4223f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  921322b68c 
>   ambari-server/src/test/resources/hbase_version_test.xml 58c87015b5 
> 
> 
> Diff: https://reviews.apache.org/r/60055/diff/2/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:08 min
> [INFO] Finished at: 2017-06-13T17:18:07-04:00
> [INFO] Final Memory: 73M/673M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 60092: Infra Manager: Use custom serializer for execution contexts of job & steps

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60092/#review177916
---


Ship it!




Ship It!

- Sebastian Toader


On June 14, 2017, 6:25 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60092/
> ---
> 
> (Updated June 14, 2017, 6:25 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21247
> https://issues.apache.org/jira/browse/AMBARI-21247
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Obtaining execution context of jobs/steps is not working as the framework 
> uses an XStreamExecutionContextStringSerializer by default, which cannot be 
> deserialized properly. Use an another serializer for that.
> 
> Also edit execution contexts and the exit desription of the dummy job.
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
>  95f87f5 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java
>  9a78706 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyJobListener.java
>  0bbfb55 
> 
> 
> Diff: https://reviews.apache.org/r/60092/diff/2/
> 
> 
> Testing
> ---
> 
> done, manually
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60092: Infra Manager: Use custom serializer for execution contexts of job & steps

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60092/
---

(Updated June 14, 2017, 4:25 p.m.)


Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, and 
Sebastian Toader.


Changes
---

use Jackson2ExecutionContextStringSerializer as that is recommended for java 
config


Bugs: AMBARI-21247
https://issues.apache.org/jira/browse/AMBARI-21247


Repository: ambari


Description
---

Obtaining execution context of jobs/steps is not working as the framework uses 
an XStreamExecutionContextStringSerializer by default, which cannot be 
deserialized properly. Use an another serializer for that.

Also edit execution contexts and the exit desription of the dummy job.


Diffs (updated)
-

  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
 95f87f5 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java
 9a78706 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyJobListener.java
 0bbfb55 


Diff: https://reviews.apache.org/r/60092/diff/2/

Changes: https://reviews.apache.org/r/60092/diff/1-2/


Testing
---

done, manually


Thanks,

Oliver Szabo

Re: Review Request 60086: AMBARI-21246. Build creates tarball twice

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60086/#review177914
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 14, 2017, 6:12 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60086/
> ---
> 
> (Updated June 14, 2017, 6:12 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Oliver Szabo, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21246
> https://issues.apache.org/jira/browse/AMBARI-21246
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Override inherited `execution` instead of defining new one.
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml c1cb056ac64d1c4d7a863ffb527dd0186cbed1ea 
>   ambari-server/pom.xml ac78595d8665fc90c15c4638e583b72b42f5a19f 
> 
> 
> Diff: https://reviews.apache.org/r/60086/diff/1/
> 
> 
> Testing
> ---
> 
> Built time is reduced from:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean 
> package
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  7.937 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.038 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.618 
> s]
> [INFO] utility  SUCCESS [  1.881 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.738 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  4.212 
> s]
> [INFO] Service Advisor  SUCCESS [  0.497 
> s]
> [INFO] Ambari Server .. SUCCESS [03:20 
> min]
> [INFO] Ambari Agent ... SUCCESS [01:15 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 04:53 min
> ```
> 
> to:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean 
> package
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  6.490 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.055 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.777 
> s]
> [INFO] utility  SUCCESS [  2.110 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.933 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  6.133 
> s]
> [INFO] Service Advisor  SUCCESS [  0.691 
> s]
> [INFO] Ambari Server .. SUCCESS [02:44 
> min]
> [INFO] Ambari Agent ... SUCCESS [01:08 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 04:12 min
> ```
> 
> `tar.gz` is built exactly once:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean 
> package
> ...
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ 
> ambari-server ---
> [INFO] Reading assembly descriptor: src/main/assemblies/server.xml
> ...
> [INFO] Building tar : 
> ambari-server/target/ambari-server-2.0.0.0-SNAPSHOT-dist.tar.gz
> ...
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ 
> ambari-agent ---
> [INFO] Reading assembly descriptor: src/packages/tarball/all.xml
> ...
> [INFO] Building tar : ambari-agent/target/ambari-agent-2.0.0.0-SNAPSHOT.tar.gz
> ```
> 
> `tar.gz` can be skipped:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests 
> -DassemblyPhase=none clean package
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  7.720 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.039 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.584 
> s]
> [INFO] utility  SUCCESS [  2.085 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.723 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  4.682 
> s]
> [INFO] Service Advisor  SUCCESS [  0.480 
> s]
> [INFO] Ambari Server .. SUCCESS [01:15 
> min]
> [INFO] Ambari 

Review Request 60092: Infra Manager: Use custom serializer for execution contexts of job & steps

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60092/
---

Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, and 
Sebastian Toader.


Bugs: AMBARI-21247
https://issues.apache.org/jira/browse/AMBARI-21247


Repository: ambari


Description
---

Obtaining execution context of jobs/steps is not working as the framework uses 
an XStreamExecutionContextStringSerializer by default, which cannot be 
deserialized properly. Use an another serializer for that.

Also edit execution contexts and the exit desription of the dummy job.


Diffs
-

  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
 95f87f5 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java
 9a78706 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyJobListener.java
 0bbfb55 


Diff: https://reviews.apache.org/r/60092/diff/1/


Testing
---

done, manually


Thanks,

Oliver Szabo

Re: Review Request 60081: Improve error message for Blueprints deployment with incorrect credential type

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60081/#review177907
---


Ship it!




Ship It!

- Robert Nettleton


On June 14, 2017, 12:37 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60081/
> ---
> 
> (Updated June 14, 2017, 12:37 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, 
> Robert Levas, Robert Nettleton, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21242
> https://issues.apache.org/jira/browse/AMBARI-21242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed the exeption text to list valid credential types.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  2c95806 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  e0735be 
> 
> 
> Diff: https://reviews.apache.org/r/60081/diff/1/
> 
> 
> Testing
> ---
> 
> - Tested the change manually
> - Modified existing unit test for the API
> - Run all unit tests in ambari-server, no errors.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

[Jonathan Hurley]

> On June 12, 2017, 10:06 a.m., Laszlo Puskas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
> > Lines 97 (patched)
> > 
> >
> > I think cascading should be removed here (AFAIK there were some issues 
> > where cascading was interfering with some DAO logic)
> 
> Robert Levas wrote:
> Cascade seems to be used a few lines up in this file...
> ```
>   @OneToMany(mappedBy = "user", cascade = CascadeType.ALL)
>   private Set memberEntities = new HashSet<>();
> ```
> 
> Other than that, a quick search in the source code reveals 72 occurances 
> of this, 42 instances are of `CascadeType.ALL`.
> 
> So far my tests seem to work ok.
> 
> Sebastian Toader wrote:
> There was already an attempt to remove the Cascadings. I guess these are 
> left overs.
> 
> Robert Levas wrote:
> What is the alternative to cascading?  If I remove a user, I will need to 
> add code in the DAO to first remove the user authentication records?

I don't have problems with cascading as long as the entity relationships are 
setup correctly for it. In many places, they are not and we need to rely on the 
DAO to do the work. Maintaining these methods seems to be a source of bugs, so 
if the entities here can be cascaded correctly, then I don't see why it would 
be a problem.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59956/#review177610
---


On June 12, 2017, 1:15 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59956/
> ---
> 
> (Updated June 12, 2017, 1:15 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21147
> https://issues.apache.org/jira/browse/AMBARI-21147
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Database Access Layer to Support New Database Schema for Improved User 
> Account Management.  
> 
> * Update `org.apache.ambari.server.orm.entities.UserEntity`
> * Update `org.apache.ambari.server.orm.dao.UserDAO`
> * Add `org.apache.ambari.server.orm.entities.UserAuthenticationEntity`
> * Add `org.apache.ambari.server.orm.dao.UserAuthenticationDAO`
> 
> Note: Some changes will be revisited when updating the different 
> authentication processes to work with the improved user account management 
> code.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/generated/index.html 7ea4297b99 
>   ambari-server/docs/api/generated/swagger.json d7d54a510f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  fb06e6d8a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  807bded873 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  eb64030e45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  aeba739a6d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  f3c2ec871b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  391213858e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequest.java
>  40818c8f48 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
>  5afacb70ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b35b2a8612 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
>  389f0b2bf2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  614f7abda1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
>  c5c36e9942 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 
> ce47c4c38c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
>  9011eaecec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilter.java
>  195c55afa5 
>   
> 

Re: Review Request 60047: Principal placeholder replacement in kerberos.json doesn't work with blueprint installs

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60047/#review177904
---


Ship it!




Ship It!

- Robert Levas


On June 13, 2017, 8:42 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60047/
> ---
> 
> (Updated June 13, 2017, 8:42 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21236
> https://issues.apache.org/jira/browse/AMBARI-21236
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kerberos principal placeholders like
> sasl:${principals/YARN/RESOURCEMANAGER/resource_manager_rm|principalPrimary()}:rwcda
> are not getting replaced if the cluster is created with blueprints 
> (kerberos=enabled).
> 
> I moved the logic that populates the replacemap with kerberos principals to a 
> different place.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  802c93d 
> 
> 
> Diff: https://reviews.apache.org/r/60047/diff/1/
> 
> 
> Testing
> ---
> 
> - created a cluster with blueprint (kerberos=enabled)
> - checked yarn-site.xml and zookeeper ACLs
> 
> existing tests: Tests run: 4982, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59954/#review177903
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 735-757 (original), 735-757 (patched)


So, these can now be either for both Ambari and stack services or just for 
Ambari if the stack services use something different. Maybe we should change 
the descriptions to make that clearer.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
Lines 1467 (patched)


Are there other places where you need to use this? Like from 
AmbariManagementControllerImpl or the Action command helper?


- Jonathan Hurley


On June 13, 2017, 10:44 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59954/
> ---
> 
> (Updated June 13, 2017, 10:44 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Robert 
> Nettleton, Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21099
> https://issues.apache.org/jira/browse/AMBARI-21099
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Requirements:
> - ambari should drop JDK 7 support for ambari-server and ambari-managed 
> services (infra, ams, logsearch), so force to use jdk8
> - HDP 2.x should be still able to use JDK 1.7
> Changes in ambari setup:
> 1. First the usual ambari setup
> 
> Choose JDK for Ambari and Stack services:
> [1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
> [2] Oracle JDK 1.7 + Java Cryptography Extension (JCE) Policy Files 7
> [3] Custom JDK
> 
> 2. If JDK 7 is picked, that cannot be used for ambari (only for the stack 
> services)
> 
> JDK 7 is detected (JDK 8 required for ambari-server), install JDK 8 as well:
> [1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
> [3] Custom JDK
> 
> 
> (this commands can be used is silent mode: ambari-server setup 
> --java-home=... --stack-java-home=...)
> 
> After the commands are executed, the following properties would appear in 
> ambari.properties
> 
> stack.java.home=/usr/jdk64/jdk1.7.0_67
> stack.jdk.name=jdk-7u67linux-x64.tar.gz
> stack.jce.name=UnlimitedJCEPolicyJDK7.zip
> 
> During command.json generating, commandParameters would be filled with proper 
> ambari jdk,jce info (different for infra/logsearch/ams from other services) - 
> not hostLevelParams, as multiple command could use the same hostLevelParams 
> (like start all services: that can start zookeeper and ams as well with the 
> same hostLevelParams)
> 
> On ambari-upgrade, ambari process wont be able to start with jdk7 so it will 
> be required to run ambari-server setup first (you can skip the first change 
> jdk part, but then the user will see its needed to setup a different jdk for 
> ambari)
> 
> In the future, it will be recommended to do the JDK upgrade before upgrading 
> to HDP 3.0 (to avoid some issues during HDP upgrade)
> 
> next step: 
> - add function to ambari common to validate jdk version (inorder to fail 
> starting any service which require jdk 8)
> 
> open question:
> - there can be a more flexible solution to include different jdks in ambari 
> (based on jdk releases list) and send all of them in the command.json, and 
> chose the proper one for different services. also that can cause some issues 
> with custom jdks (adding a name to custom ones?), and also because the jdk 
> names can be anything, we would need to validate/get the jdk version during 
> sending a command to the agent. all of this work has done about to support 
> older version of HDP, so im not sure about to create a flexible solution at 
> all, as managing multiple JDKs can be really hard for a customer, so i would 
> not recommend to use multiple ones.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 2394264 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  60df8cf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  fb06e6d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  1b0e0e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  07f6e30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8d262e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  21cf16c 
>   

Re: Review Request 60048: Kafka userprincipal to shortname is not using AUTH_TO_LOCAL rules for authorization

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60048/#review177902
---


Fix it, then Ship it!




Ship It!


ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java
Lines 671 (patched)


The naming convention is to use the plural form of this... `COMMAS`.


- Robert Levas


On June 13, 2017, 9:18 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60048/
> ---
> 
> (Updated June 13, 2017, 9:18 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-21238
> https://issues.apache.org/jira/browse/AMBARI-21238
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> add comma separated rules to sasl.kerberos.principal.to.local.rules property 
> of server.properties
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java
>  33c8f3b 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/kerberos.json
>  eb31ad6 
>   ambari-server/src/main/resources/common-services/KAFKA/0.10.0/kerberos.json 
> eb31ad6 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 7500891 
>   
> contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/services/KAFKA/kerberos.json
>  e1e6461 
> 
> 
> Diff: https://reviews.apache.org/r/60048/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 60086: AMBARI-21246. Build creates tarball twice

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60086/#review177901
---


Ship it!




Ship It!

- Sebastian Toader


On June 14, 2017, 5:12 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60086/
> ---
> 
> (Updated June 14, 2017, 5:12 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Oliver Szabo, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21246
> https://issues.apache.org/jira/browse/AMBARI-21246
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Override inherited `execution` instead of defining new one.
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml c1cb056ac64d1c4d7a863ffb527dd0186cbed1ea 
>   ambari-server/pom.xml ac78595d8665fc90c15c4638e583b72b42f5a19f 
> 
> 
> Diff: https://reviews.apache.org/r/60086/diff/1/
> 
> 
> Testing
> ---
> 
> Built time is reduced from:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean 
> package
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  7.937 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.038 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.618 
> s]
> [INFO] utility  SUCCESS [  1.881 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.738 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  4.212 
> s]
> [INFO] Service Advisor  SUCCESS [  0.497 
> s]
> [INFO] Ambari Server .. SUCCESS [03:20 
> min]
> [INFO] Ambari Agent ... SUCCESS [01:15 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 04:53 min
> ```
> 
> to:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean 
> package
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  6.490 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.055 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.777 
> s]
> [INFO] utility  SUCCESS [  2.110 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.933 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  6.133 
> s]
> [INFO] Service Advisor  SUCCESS [  0.691 
> s]
> [INFO] Ambari Server .. SUCCESS [02:44 
> min]
> [INFO] Ambari Agent ... SUCCESS [01:08 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 04:12 min
> ```
> 
> `tar.gz` is built exactly once:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean 
> package
> ...
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ 
> ambari-server ---
> [INFO] Reading assembly descriptor: src/main/assemblies/server.xml
> ...
> [INFO] Building tar : 
> ambari-server/target/ambari-server-2.0.0.0-SNAPSHOT-dist.tar.gz
> ...
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ 
> ambari-agent ---
> [INFO] Reading assembly descriptor: src/packages/tarball/all.xml
> ...
> [INFO] Building tar : ambari-agent/target/ambari-agent-2.0.0.0-SNAPSHOT.tar.gz
> ```
> 
> `tar.gz` can be skipped:
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests 
> -DassemblyPhase=none clean package
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  7.720 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.039 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.584 
> s]
> [INFO] utility  SUCCESS [  2.085 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.723 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  4.682 
> s]
> [INFO] Service Advisor  SUCCESS [  0.480 
> s]
> [INFO] Ambari Server .. SUCCESS [01:15 
> min]
> [INFO] Ambari Agent 

Review Request 60086: AMBARI-21246. Build creates tarball twice

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60086/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Oliver Szabo, 
and Sebastian Toader.


Bugs: AMBARI-21246
https://issues.apache.org/jira/browse/AMBARI-21246


Repository: ambari


Description
---

Override inherited `execution` instead of defining new one.


Diffs
-

  ambari-agent/pom.xml c1cb056ac64d1c4d7a863ffb527dd0186cbed1ea 
  ambari-server/pom.xml ac78595d8665fc90c15c4638e583b72b42f5a19f 


Diff: https://reviews.apache.org/r/60086/diff/1/


Testing
---

Built time is reduced from:

```
$ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean package
...
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main  SUCCESS [  7.937 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.038 s]
[INFO] Ambari Views ... SUCCESS [  1.618 s]
[INFO] utility  SUCCESS [  1.881 s]
[INFO] ambari-metrics . SUCCESS [  0.738 s]
[INFO] Ambari Metrics Common .. SUCCESS [  4.212 s]
[INFO] Service Advisor  SUCCESS [  0.497 s]
[INFO] Ambari Server .. SUCCESS [03:20 min]
[INFO] Ambari Agent ... SUCCESS [01:15 min]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 04:53 min
```

to:

```
$ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean package
...
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main  SUCCESS [  6.490 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.055 s]
[INFO] Ambari Views ... SUCCESS [  1.777 s]
[INFO] utility  SUCCESS [  2.110 s]
[INFO] ambari-metrics . SUCCESS [  0.933 s]
[INFO] Ambari Metrics Common .. SUCCESS [  6.133 s]
[INFO] Service Advisor  SUCCESS [  0.691 s]
[INFO] Ambari Server .. SUCCESS [02:44 min]
[INFO] Ambari Agent ... SUCCESS [01:08 min]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 04:12 min
```

`tar.gz` is built exactly once:

```
$ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean package
...
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ 
ambari-server ---
[INFO] Reading assembly descriptor: src/main/assemblies/server.xml
...
[INFO] Building tar : 
ambari-server/target/ambari-server-2.0.0.0-SNAPSHOT-dist.tar.gz
...
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ 
ambari-agent ---
[INFO] Reading assembly descriptor: src/packages/tarball/all.xml
...
[INFO] Building tar : ambari-agent/target/ambari-agent-2.0.0.0-SNAPSHOT.tar.gz
```

`tar.gz` can be skipped:

```
$ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests 
-DassemblyPhase=none clean package
...
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main  SUCCESS [  7.720 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.039 s]
[INFO] Ambari Views ... SUCCESS [  1.584 s]
[INFO] utility  SUCCESS [  2.085 s]
[INFO] ambari-metrics . SUCCESS [  0.723 s]
[INFO] Ambari Metrics Common .. SUCCESS [  4.682 s]
[INFO] Service Advisor  SUCCESS [  0.480 s]
[INFO] Ambari Server .. SUCCESS [01:15 min]
[INFO] Ambari Agent ... SUCCESS [ 14.341 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:47 min
```


Thanks,

Attila Doroszlai

Re: Review Request 60078: AMBARI-21190 Populate urlauth filesystem schemes in Ranger hive plugin

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60078/#review177899
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/ranger-hive-security.xml
Lines 1-33 (patched)


This file and the new property already exist at the common-services level; 
why add it here too? It should just inherit from common-services.


- Jonathan Hurley


On June 14, 2017, 9:37 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60078/
> ---
> 
> (Updated June 14, 2017, 9:37 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-21190
> https://issues.apache.org/jira/browse/AMBARI-21190
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> populate ranger.plugin.hive.urlauth.filesystem.schemes default value to 
> hdfs:,file:,wasb:,adl:
> 1) it will be better if we keep default value of 
> ranger.plugin.hive.urlauth.filesystem.schemes=hdfs:,file:,wasb:,adl:, if it 
> does not harm to have all of the fs values in this properly it will be good 
> to add them.
> 2) it will be good to add this properly in advanced-ranger-hive-security
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-security.xml
>  d98bc21 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-ugsync-site.xml
>  439c495 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0.3.0/configuration/ranger-ugsync-site.xml
>  2c62851 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/ranger-hive-security.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 1610bb5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  1cdd184 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 3e7e3d7 
> 
> 
> Diff: https://reviews.apache.org/r/60078/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Ranger Install + Enabled Hive Plugin.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59954/#review177900
---


Ship it!




Ship It!

- Robert Levas


On June 13, 2017, 10:44 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59954/
> ---
> 
> (Updated June 13, 2017, 10:44 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Robert 
> Nettleton, Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21099
> https://issues.apache.org/jira/browse/AMBARI-21099
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Requirements:
> - ambari should drop JDK 7 support for ambari-server and ambari-managed 
> services (infra, ams, logsearch), so force to use jdk8
> - HDP 2.x should be still able to use JDK 1.7
> Changes in ambari setup:
> 1. First the usual ambari setup
> 
> Choose JDK for Ambari and Stack services:
> [1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
> [2] Oracle JDK 1.7 + Java Cryptography Extension (JCE) Policy Files 7
> [3] Custom JDK
> 
> 2. If JDK 7 is picked, that cannot be used for ambari (only for the stack 
> services)
> 
> JDK 7 is detected (JDK 8 required for ambari-server), install JDK 8 as well:
> [1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
> [3] Custom JDK
> 
> 
> (this commands can be used is silent mode: ambari-server setup 
> --java-home=... --stack-java-home=...)
> 
> After the commands are executed, the following properties would appear in 
> ambari.properties
> 
> stack.java.home=/usr/jdk64/jdk1.7.0_67
> stack.jdk.name=jdk-7u67linux-x64.tar.gz
> stack.jce.name=UnlimitedJCEPolicyJDK7.zip
> 
> During command.json generating, commandParameters would be filled with proper 
> ambari jdk,jce info (different for infra/logsearch/ams from other services) - 
> not hostLevelParams, as multiple command could use the same hostLevelParams 
> (like start all services: that can start zookeeper and ams as well with the 
> same hostLevelParams)
> 
> On ambari-upgrade, ambari process wont be able to start with jdk7 so it will 
> be required to run ambari-server setup first (you can skip the first change 
> jdk part, but then the user will see its needed to setup a different jdk for 
> ambari)
> 
> In the future, it will be recommended to do the JDK upgrade before upgrading 
> to HDP 3.0 (to avoid some issues during HDP upgrade)
> 
> next step: 
> - add function to ambari common to validate jdk version (inorder to fail 
> starting any service which require jdk 8)
> 
> open question:
> - there can be a more flexible solution to include different jdks in ambari 
> (based on jdk releases list) and send all of them in the command.json, and 
> chose the proper one for different services. also that can cause some issues 
> with custom jdks (adding a name to custom ones?), and also because the jdk 
> names can be anything, we would need to validate/get the jdk version during 
> sending a command to the agent. all of this work has done about to support 
> older version of HDP, so im not sure about to create a flexible solution at 
> all, as managing multiple JDKs can be really hard for a customer, so i would 
> not recommend to use multiple ones.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 2394264 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  60df8cf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  fb06e6d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  1b0e0e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  07f6e30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8d262e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  21cf16c 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
> 9930148 
>   ambari-server/src/main/python/ambari-server.py d84e833 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  6eb3ba8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  b8c14f4 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  36c4598 
>   
> 

Re: Review Request 60033: Ambari data purging

[Robert Levas]

> On June 14, 2017, 10:54 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
> > Line 949 (original), 950 (patched)
> > 
> >
> > We are losing task order here. Does that make a difference?
> 
> Sebastian Toader wrote:
> Order doesn't matter. What matters is to have unique ids in the 
> collection.

Thanks for the clarification


> On June 14, 2017, 10:54 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
> > Line 276 (original), 276 (patched)
> > 
> >
> > Request order is being lost.  Could this cause an issue?
> 
> Sebastian Toader wrote:
> Order doesn't matter. What matters is to have unique ids in the 
> collection.

Thanks for the clarification


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60033/#review177894
---


On June 13, 2017, 12:43 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60033/
> ---
> 
> (Updated June 13, 2017, 12:43 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo 
> Puskas, Robert Levas, Sandor Magyari, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20749
> https://issues.apache.org/jira/browse/AMBARI-20749
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding a couple of  fixes to 
> https://issues.apache.org/jira/browse/AMBARI-20687 and renaming the 
> db-cleanup functionality to db-purge-history
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server 7044096 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  70c3661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java
>  788290b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupService.java
>  880207c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java
>  29a9041 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  b9e1fab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 38c0977 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  eea8032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  32a38da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  3a72aed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  37830b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  1536b80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  2954863 
>   ambari-server/src/main/python/ambari-server.py 235ef95 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py 6e16bc5 
>   ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java
>  7de5aae 
> 
> 
> Diff: https://reviews.apache.org/r/60033/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> ambari-server db-purge-history --cluster-name cl1 --from-date 2017-06-13
> 
> Verified that all request related records except the ones that belong to 
> upgrade were purged.
> 
> 
> Unit tests:
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.811 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.004 
> s]
> [INFO] Ambari Views ... SUCCESS [  3.824 
> s]
> [INFO] utility  SUCCESS [  1.411 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.387 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.708 
> s]
> [INFO] Ambari Server .. SUCCESS [33:10 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:25 min
> [INFO] Finished at: 2017-06-12T23:20:03+02:00
> [INFO] Final Memory: 56M/389M
> [INFO] 
> 

Re: Review Request 60081: Improve error message for Blueprints deployment with incorrect credential type

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60081/#review177897
---


Ship it!




Ship It!

- Robert Levas


On June 14, 2017, 8:37 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60081/
> ---
> 
> (Updated June 14, 2017, 8:37 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, 
> Robert Levas, Robert Nettleton, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21242
> https://issues.apache.org/jira/browse/AMBARI-21242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed the exeption text to list valid credential types.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  2c95806 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  e0735be 
> 
> 
> Diff: https://reviews.apache.org/r/60081/diff/1/
> 
> 
> Testing
> ---
> 
> - Tested the change manually
> - Modified existing unit test for the API
> - Run all unit tests in ambari-server, no errors.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 60033: Ambari data purging

[Sebastian Toader]

> On June 14, 2017, 4:54 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
> > Line 949 (original), 950 (patched)
> > 
> >
> > We are losing task order here. Does that make a difference?

Order doesn't matter. What matters is to have unique ids in the collection.


> On June 14, 2017, 4:54 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
> > Line 276 (original), 276 (patched)
> > 
> >
> > Request order is being lost.  Could this cause an issue?

Order doesn't matter. What matters is to have unique ids in the collection.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60033/#review177894
---


On June 13, 2017, 6:43 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60033/
> ---
> 
> (Updated June 13, 2017, 6:43 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo 
> Puskas, Robert Levas, Sandor Magyari, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20749
> https://issues.apache.org/jira/browse/AMBARI-20749
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding a couple of  fixes to 
> https://issues.apache.org/jira/browse/AMBARI-20687 and renaming the 
> db-cleanup functionality to db-purge-history
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server 7044096 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  70c3661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java
>  788290b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupService.java
>  880207c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java
>  29a9041 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  b9e1fab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 38c0977 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  eea8032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  32a38da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  3a72aed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  37830b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  1536b80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  2954863 
>   ambari-server/src/main/python/ambari-server.py 235ef95 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py 6e16bc5 
>   ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java
>  7de5aae 
> 
> 
> Diff: https://reviews.apache.org/r/60033/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> ambari-server db-purge-history --cluster-name cl1 --from-date 2017-06-13
> 
> Verified that all request related records except the ones that belong to 
> upgrade were purged.
> 
> 
> Unit tests:
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.811 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.004 
> s]
> [INFO] Ambari Views ... SUCCESS [  3.824 
> s]
> [INFO] utility  SUCCESS [  1.411 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.387 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.708 
> s]
> [INFO] Ambari Server .. SUCCESS [33:10 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:25 min
> [INFO] Finished at: 2017-06-12T23:20:03+02:00
> [INFO] Final Memory: 56M/389M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 60033: Ambari data purging

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60033/#review177894
---


Fix it, then Ship it!




Ship It!


ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
Line 949 (original), 950 (patched)


We are losing task order here. Does that make a difference?



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
Line 276 (original), 276 (patched)


Request order is being lost.  Could this cause an issue?


- Robert Levas


On June 13, 2017, 12:43 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60033/
> ---
> 
> (Updated June 13, 2017, 12:43 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo 
> Puskas, Robert Levas, Sandor Magyari, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20749
> https://issues.apache.org/jira/browse/AMBARI-20749
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding a couple of  fixes to 
> https://issues.apache.org/jira/browse/AMBARI-20687 and renaming the 
> db-cleanup functionality to db-purge-history
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server 7044096 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  70c3661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java
>  788290b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupService.java
>  880207c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java
>  29a9041 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  b9e1fab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 38c0977 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  eea8032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  32a38da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  3a72aed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  37830b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  1536b80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  2954863 
>   ambari-server/src/main/python/ambari-server.py 235ef95 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py 6e16bc5 
>   ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java
>  7de5aae 
> 
> 
> Diff: https://reviews.apache.org/r/60033/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> ambari-server db-purge-history --cluster-name cl1 --from-date 2017-06-13
> 
> Verified that all request related records except the ones that belong to 
> upgrade were purged.
> 
> 
> Unit tests:
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.811 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.004 
> s]
> [INFO] Ambari Views ... SUCCESS [  3.824 
> s]
> [INFO] utility  SUCCESS [  1.411 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.387 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.708 
> s]
> [INFO] Ambari Server .. SUCCESS [33:10 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:25 min
> [INFO] Finished at: 2017-06-12T23:20:03+02:00
> [INFO] Final Memory: 56M/389M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 60055: Support revert for patch upgrades

[Nate Cole]

> On June 14, 2017, 10:45 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
> > Lines 321-323 (patched)
> > 
> >
> > Very interesting - although I don't have an issue with this 
> > specifically, I'm curious if we should have a discussion around the 
> > direction of a patch revert. Is there an advantage in the orchestration 
> > ordering if we do it as an UPGRADE (as opposed to the reverse orchestration 
> > of a DOWNGRADE)?
> > 
> > If we did it as a normal downgrade, then we get some built-in logic 
> > (like you can't downgrade a downgrade).

Checking now.


> On June 14, 2017, 10:45 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Lines 816 (patched)
> > 
> >
> > Can you update https://issues.apache.org/jira/browse/AMBARI-21169 with 
> > this new column?

Will do.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60055/#review177890
---


On June 13, 2017, 5:19 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60055/
> ---
> 
> (Updated June 13, 2017, 5:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21241
> https://issues.apache.org/jira/browse/AMBARI-21241
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Entails adding an option to specify a previous upgrade to revert.  Checks to 
> make sure it's only a patch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a66db3c008 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
>  c8c9f9ed2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
>  ea8fb372dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  60665f7b2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  43b2e088d7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  e70f1ce8b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
>  8a4820d7f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  3ecf64dc0c 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e34140593a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ce8736e62d 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ace3738d2c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5899179aba 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 6164b2de5c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 52d2b87c74 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  a37e4f5d12 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  014ab4223f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  921322b68c 
>   ambari-server/src/test/resources/hbase_version_test.xml 58c87015b5 
> 
> 
> Diff: https://reviews.apache.org/r/60055/diff/2/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:08 min
> [INFO] Finished at: 2017-06-13T17:18:07-04:00
> [INFO] Final Memory: 73M/673M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 60055: Support revert for patch upgrades

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60055/#review177890
---




ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
Lines 380-394 (patched)


Do you envision other types here? If not, would it be easier to use the 
boolean instead?



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
Lines 321-323 (patched)


Very interesting - although I don't have an issue with this specifically, 
I'm curious if we should have a discussion around the direction of a patch 
revert. Is there an advantage in the orchestration ordering if we do it as an 
UPGRADE (as opposed to the reverse orchestration of a DOWNGRADE)?

If we did it as a normal downgrade, then we get some built-in logic (like 
you can't downgrade a downgrade).



ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 816 (patched)


Can you update https://issues.apache.org/jira/browse/AMBARI-21169 with this 
new column?


- Jonathan Hurley


On June 13, 2017, 5:19 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60055/
> ---
> 
> (Updated June 13, 2017, 5:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21241
> https://issues.apache.org/jira/browse/AMBARI-21241
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Entails adding an option to specify a previous upgrade to revert.  Checks to 
> make sure it's only a patch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a66db3c008 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
>  c8c9f9ed2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
>  ea8fb372dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  60665f7b2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
>  43b2e088d7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  e70f1ce8b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
>  8a4820d7f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  3ecf64dc0c 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e34140593a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ce8736e62d 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ace3738d2c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5899179aba 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 6164b2de5c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 52d2b87c74 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  a37e4f5d12 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  014ab4223f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  921322b68c 
>   ambari-server/src/test/resources/hbase_version_test.xml 58c87015b5 
> 
> 
> Diff: https://reviews.apache.org/r/60055/diff/2/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:08 min
> [INFO] Finished at: 2017-06-13T17:18:07-04:00
> [INFO] Final Memory: 73M/673M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 60078: AMBARI-21190 Populate urlauth filesystem schemes in Ranger hive plugin

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60078/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Jonathan 
Hurley.


Bugs: AMBARI-21190
https://issues.apache.org/jira/browse/AMBARI-21190


Repository: ambari


Description
---

populate ranger.plugin.hive.urlauth.filesystem.schemes default value to 
hdfs:,file:,wasb:,adl:
1) it will be better if we keep default value of 
ranger.plugin.hive.urlauth.filesystem.schemes=hdfs:,file:,wasb:,adl:, if it 
does not harm to have all of the fs values in this properly it will be good to 
add them.
2) it will be good to add this properly in advanced-ranger-hive-security


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-security.xml
 d98bc21 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-ugsync-site.xml
 439c495 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0.3.0/configuration/ranger-ugsync-site.xml
 2c62851 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/ranger-hive-security.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
1610bb5 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 1cdd184 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
3e7e3d7 


Diff: https://reviews.apache.org/r/60078/diff/1/


Testing
---

Tested Ranger Install + Enabled Hive Plugin.


Thanks,

Mugdha Varadkar

Review Request 60084: Send information about agentEnv only if it changed.

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60084/
---

Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-21245
https://issues.apache.org/jira/browse/AMBARI-21245


Repository: ambari


Description
---

Currently the information about agent (umask, processes, links, mounts) is
send with heartbeats.

Move to sending via a separate endpoint /reports/host_status and send it only
once its value changed.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4cef88b 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 3d480ca 
  ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py d0f6801 
  ambari-agent/src/main/python/ambari_agent/Constants.py 8fafca1 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
2350504 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py e54c0c1 
  ambari-agent/src/main/python/ambari_agent/HostInfo.py 4b7bfd7 
  ambari-agent/src/main/python/ambari_agent/HostStatusReporter.py PRE-CREATION 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py 88c8b91 
  ambari-agent/src/main/python/ambari_agent/Register.py 4c4bf32 
  ambari-agent/src/main/python/ambari_agent/Utils.py de073bb 
  ambari-agent/src/main/python/ambari_agent/main.py a1a98e8 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 9d57261 


Diff: https://reviews.apache.org/r/60084/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 60033: Ambari data purging

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60033/#review177884
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Червень 13, 2017, 4:43 до полудня, Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60033/
> ---
> 
> (Updated Червень 13, 2017, 4:43 до полудня)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo 
> Puskas, Robert Levas, Sandor Magyari, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20749
> https://issues.apache.org/jira/browse/AMBARI-20749
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding a couple of  fixes to 
> https://issues.apache.org/jira/browse/AMBARI-20687 and renaming the 
> db-cleanup functionality to db-purge-history
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server 7044096 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  70c3661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java
>  788290b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupService.java
>  880207c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java
>  29a9041 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  b9e1fab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 38c0977 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  eea8032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  32a38da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  3a72aed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  37830b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  1536b80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  2954863 
>   ambari-server/src/main/python/ambari-server.py 235ef95 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py 6e16bc5 
>   ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java
>  7de5aae 
> 
> 
> Diff: https://reviews.apache.org/r/60033/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> ambari-server db-purge-history --cluster-name cl1 --from-date 2017-06-13
> 
> Verified that all request related records except the ones that belong to 
> upgrade were purged.
> 
> 
> Unit tests:
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.811 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.004 
> s]
> [INFO] Ambari Views ... SUCCESS [  3.824 
> s]
> [INFO] utility  SUCCESS [  1.411 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.387 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.708 
> s]
> [INFO] Ambari Server .. SUCCESS [33:10 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:25 min
> [INFO] Finished at: 2017-06-12T23:20:03+02:00
> [INFO] Final Memory: 56M/389M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 60033: Ambari data purging

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60033/#review177883
---


Ship it!




Ship It!

- Laszlo Puskas


On June 13, 2017, 4:43 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60033/
> ---
> 
> (Updated June 13, 2017, 4:43 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo 
> Puskas, Robert Levas, Sandor Magyari, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20749
> https://issues.apache.org/jira/browse/AMBARI-20749
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding a couple of  fixes to 
> https://issues.apache.org/jira/browse/AMBARI-20687 and renaming the 
> db-cleanup functionality to db-purge-history
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server 7044096 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  70c3661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java
>  788290b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupService.java
>  880207c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java
>  29a9041 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  b9e1fab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 38c0977 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  eea8032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  32a38da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  3a72aed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  37830b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  1536b80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  2954863 
>   ambari-server/src/main/python/ambari-server.py 235ef95 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py 6e16bc5 
>   ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java
>  7de5aae 
> 
> 
> Diff: https://reviews.apache.org/r/60033/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> ambari-server db-purge-history --cluster-name cl1 --from-date 2017-06-13
> 
> Verified that all request related records except the ones that belong to 
> upgrade were purged.
> 
> 
> Unit tests:
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.811 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.004 
> s]
> [INFO] Ambari Views ... SUCCESS [  3.824 
> s]
> [INFO] utility  SUCCESS [  1.411 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.387 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.708 
> s]
> [INFO] Ambari Server .. SUCCESS [33:10 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:25 min
> [INFO] Finished at: 2017-06-12T23:20:03+02:00
> [INFO] Final Memory: 56M/389M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 60081: Improve error message for Blueprints deployment with incorrect credential type

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60081/#review177881
---


Ship it!




Ship It!

- Laszlo Puskas


On June 14, 2017, 12:37 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60081/
> ---
> 
> (Updated June 14, 2017, 12:37 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, 
> Robert Levas, Robert Nettleton, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21242
> https://issues.apache.org/jira/browse/AMBARI-21242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed the exeption text to list valid credential types.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  2c95806 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  e0735be 
> 
> 
> Diff: https://reviews.apache.org/r/60081/diff/1/
> 
> 
> Testing
> ---
> 
> - Tested the change manually
> - Modified existing unit test for the API
> - Run all unit tests in ambari-server, no errors.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 60081: Improve error message for Blueprints deployment with incorrect credential type

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60081/
---

Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, 
Robert Levas, Robert Nettleton, Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-21242
https://issues.apache.org/jira/browse/AMBARI-21242


Repository: ambari


Description
---

Changed the exeption text to list valid credential types.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 2c95806 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
 e0735be 


Diff: https://reviews.apache.org/r/60081/diff/1/


Testing
---

- Tested the change manually
- Modified existing unit test for the API
- Run all unit tests in ambari-server, no errors.


Thanks,

Balázs Bence Sári

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/
---

(Updated June 14, 2017, 12:21 p.m.)


Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

Fix review comment


Bugs: AMBARI-21207
https://issues.apache.org/jira/browse/AMBARI-21207


Repository: ambari


Description
---

Wrote a custom SwaggerReader in the utility project that handles nested API's. 
There is currently one nested API which is annotated for swagger: 
org.apache.ambari.server.api.services.ServiceService (nested under 
ClusterService). Using the custom reader operation paths and parameters are 
generated correctly for the nested API.


Diffs (updated)
-

  ambari-project/pom.xml 9bb2e26 
  ambari-server/pom.xml a1cd239 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 f61fb2a 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 a28c4aa 
  utility/pom.xml 918080e 
  utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
PRE-CREATION 
  utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
PRE-CREATION 
  utility/src/test/resources/log4j.properties PRE-CREATION 


Diff: https://reviews.apache.org/r/59929/diff/5/

Changes: https://reviews.apache.org/r/59929/diff/4-5/


Testing
---

Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
tests for the ambari-server and utility projects, no errors or failures.


Thanks,

Balázs Bence Sári

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59954/#review177880
---


Ship it!




Ship It!

- Nate Cole


On June 13, 2017, 10:44 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59954/
> ---
> 
> (Updated June 13, 2017, 10:44 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Robert 
> Nettleton, Sumit Mohanty, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21099
> https://issues.apache.org/jira/browse/AMBARI-21099
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Requirements:
> - ambari should drop JDK 7 support for ambari-server and ambari-managed 
> services (infra, ams, logsearch), so force to use jdk8
> - HDP 2.x should be still able to use JDK 1.7
> Changes in ambari setup:
> 1. First the usual ambari setup
> 
> Choose JDK for Ambari and Stack services:
> [1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
> [2] Oracle JDK 1.7 + Java Cryptography Extension (JCE) Policy Files 7
> [3] Custom JDK
> 
> 2. If JDK 7 is picked, that cannot be used for ambari (only for the stack 
> services)
> 
> JDK 7 is detected (JDK 8 required for ambari-server), install JDK 8 as well:
> [1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
> [3] Custom JDK
> 
> 
> (this commands can be used is silent mode: ambari-server setup 
> --java-home=... --stack-java-home=...)
> 
> After the commands are executed, the following properties would appear in 
> ambari.properties
> 
> stack.java.home=/usr/jdk64/jdk1.7.0_67
> stack.jdk.name=jdk-7u67linux-x64.tar.gz
> stack.jce.name=UnlimitedJCEPolicyJDK7.zip
> 
> During command.json generating, commandParameters would be filled with proper 
> ambari jdk,jce info (different for infra/logsearch/ams from other services) - 
> not hostLevelParams, as multiple command could use the same hostLevelParams 
> (like start all services: that can start zookeeper and ams as well with the 
> same hostLevelParams)
> 
> On ambari-upgrade, ambari process wont be able to start with jdk7 so it will 
> be required to run ambari-server setup first (you can skip the first change 
> jdk part, but then the user will see its needed to setup a different jdk for 
> ambari)
> 
> In the future, it will be recommended to do the JDK upgrade before upgrading 
> to HDP 3.0 (to avoid some issues during HDP upgrade)
> 
> next step: 
> - add function to ambari common to validate jdk version (inorder to fail 
> starting any service which require jdk 8)
> 
> open question:
> - there can be a more flexible solution to include different jdks in ambari 
> (based on jdk releases list) and send all of them in the command.json, and 
> chose the proper one for different services. also that can cause some issues 
> with custom jdks (adding a name to custom ones?), and also because the jdk 
> names can be anything, we would need to validate/get the jdk version during 
> sending a command to the agent. all of this work has done about to support 
> older version of HDP, so im not sure about to create a flexible solution at 
> all, as managing multiple JDKs can be really hard for a customer, so i would 
> not recommend to use multiple ones.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 2394264 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  60df8cf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  fb06e6d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  1b0e0e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  07f6e30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8d262e2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  21cf16c 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
> 9930148 
>   ambari-server/src/main/python/ambari-server.py d84e833 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  6eb3ba8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  b8c14f4 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  36c4598 
>   
> 

Re: Review Request 60033: Ambari data purging

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60033/#review177879
---


Ship it!




Ship It!

- Attila Doroszlai


On June 13, 2017, 6:43 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60033/
> ---
> 
> (Updated June 13, 2017, 6:43 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo 
> Puskas, Robert Levas, Sandor Magyari, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20749
> https://issues.apache.org/jira/browse/AMBARI-20749
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding a couple of  fixes to 
> https://issues.apache.org/jira/browse/AMBARI-20687 and renaming the 
> db-cleanup functionality to db-purge-history
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server 7044096 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  70c3661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java
>  788290b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupService.java
>  880207c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java
>  29a9041 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  b9e1fab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 38c0977 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  eea8032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  32a38da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  3a72aed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  37830b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  1536b80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  2954863 
>   ambari-server/src/main/python/ambari-server.py 235ef95 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py 6e16bc5 
>   ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java
>  7de5aae 
> 
> 
> Diff: https://reviews.apache.org/r/60033/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> ambari-server db-purge-history --cluster-name cl1 --from-date 2017-06-13
> 
> Verified that all request related records except the ones that belong to 
> upgrade were purged.
> 
> 
> Unit tests:
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.811 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.004 
> s]
> [INFO] Ambari Views ... SUCCESS [  3.824 
> s]
> [INFO] utility  SUCCESS [  1.411 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.387 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.708 
> s]
> [INFO] Ambari Server .. SUCCESS [33:10 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:25 min
> [INFO] Finished at: 2017-06-12T23:20:03+02:00
> [INFO] Final Memory: 56M/389M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 60076: Improve Zeppelin startup time

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60076/#review177878
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On June 14, 2017, 11:14 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60076/
> ---
> 
> (Updated June 14, 2017, 11:14 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21243
> https://issues.apache.org/jira/browse/AMBARI-21243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently Zeppelin takes more than 1 minute to start. The bulk of the time 
> during startup is spent with waiting on interpreter.json.
> 
> So the idea of this patch is to have interpeter.json cached, and apply it 
> does not exists.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/interpreter_json_template.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  3d516b0c68 
> 
> 
> Diff: https://reviews.apache.org/r/60076/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 60077: Add https support to local metrics aggregator application

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60077/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-21244
https://issues.apache.org/jira/browse/AMBARI-21244


Repository: ambari


Description
---

Add https support to local metrics aggregator application


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java
 39526a5 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 644d978 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/AbstractTimelineMetricSinkTest.java
 ce2cf79 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
 f0174d5 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java
 4eb75eb 
  
ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
 6277907 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 a290ced 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 30c5c23 
  ambari-metrics/ambari-metrics-host-aggregator/pom.xml 24432dd 
  
ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatorApplication.java
 1e5cc82 
  
ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractMetricPublisher.java
 5af115f 
  
ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregatedMetricsPublisher.java
 c8dffab 
  
ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/RawMetricsPublisher.java
 89addb7 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py
 ba05e9b 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 d1429ed 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
77b8c23 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 
035c833 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py
 7a9fbec 
  
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
 6f5e9e0 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 d408e1a 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 ff72f24 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 5b75065 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 4d5a229 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 7dec18f 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 5d21514 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
 e59ba11 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 1b085f6 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
 f49d47d 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 b8c14f4 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
 978b795 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 b7dee50 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
 0e0c9aa 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
 c476019 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 d45aea6 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
 7368ffe 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
 f245365 
  

Re: Review Request 60076: Improve Zeppelin startup time

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60076/#review177877
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 14, 2017, 11:14 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60076/
> ---
> 
> (Updated June 14, 2017, 11:14 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21243
> https://issues.apache.org/jira/browse/AMBARI-21243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently Zeppelin takes more than 1 minute to start. The bulk of the time 
> during startup is spent with waiting on interpreter.json.
> 
> So the idea of this patch is to have interpeter.json cached, and apply it 
> does not exists.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/interpreter_json_template.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  3d516b0c68 
> 
> 
> Diff: https://reviews.apache.org/r/60076/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 60076: Improve Zeppelin startup time

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60076/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and 
Sumit Mohanty.


Bugs: AMBARI-21243
https://issues.apache.org/jira/browse/AMBARI-21243


Repository: ambari


Description
---

Currently Zeppelin takes more than 1 minute to start. The bulk of the time 
during startup is spent with waiting on interpreter.json.

So the idea of this patch is to have interpeter.json cached, and apply it does 
not exists.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/interpreter_json_template.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 3d516b0c68 


Diff: https://reviews.apache.org/r/60076/diff/1/


Testing
---

Manually on CentOS 6


Thanks,

Prabhjyot Singh

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/#review177876
---


Fix it, then Ship it!





ambari-project/pom.xml
Lines 36 (patched)


Should be 1.7.20


- Attila Doroszlai


On June 14, 2017, 12:38 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59929/
> ---
> 
> (Updated June 14, 2017, 12:38 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21207
> https://issues.apache.org/jira/browse/AMBARI-21207
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Wrote a custom SwaggerReader in the utility project that handles nested 
> API's. There is currently one nested API which is annotated for swagger: 
> org.apache.ambari.server.api.services.ServiceService (nested under 
> ClusterService). Using the custom reader operation paths and parameters are 
> generated correctly for the nested API.
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 9bb2e26 
>   ambari-server/pom.xml a1cd239 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  f61fb2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  a28c4aa 
>   utility/pom.xml 918080e 
>   utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
> PRE-CREATION 
>   
> utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
> PRE-CREATION 
>   utility/src/test/resources/log4j.properties PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59929/diff/4/
> 
> 
> Testing
> ---
> 
> Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
> tests for the ambari-server and utility projects, no errors or failures.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/
---

(Updated June 14, 2017, 10:38 a.m.)


Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

Rebased patch


Bugs: AMBARI-21207
https://issues.apache.org/jira/browse/AMBARI-21207


Repository: ambari


Description
---

Wrote a custom SwaggerReader in the utility project that handles nested API's. 
There is currently one nested API which is annotated for swagger: 
org.apache.ambari.server.api.services.ServiceService (nested under 
ClusterService). Using the custom reader operation paths and parameters are 
generated correctly for the nested API.


Diffs (updated)
-

  ambari-project/pom.xml 9bb2e26 
  ambari-server/pom.xml a1cd239 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 f61fb2a 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 a28c4aa 
  utility/pom.xml 918080e 
  utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java 
PRE-CREATION 
  utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java 
PRE-CREATION 
  utility/src/test/resources/log4j.properties PRE-CREATION 


Diff: https://reviews.apache.org/r/59929/diff/4/

Changes: https://reviews.apache.org/r/59929/diff/3-4/


Testing
---

Tested Swagger API generation manually. Wrote new unit tests. Run all unit 
tests for the ambari-server and utility projects, no errors or failures.


Thanks,

Balázs Bence Sári

Re: Review Request 60033: Ambari data purging

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60033/#review177871
---


Ship it!




Ship It!

- Sandor Magyari


On June 13, 2017, 4:43 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60033/
> ---
> 
> (Updated June 13, 2017, 4:43 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo 
> Puskas, Robert Levas, Sandor Magyari, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20749
> https://issues.apache.org/jira/browse/AMBARI-20749
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding a couple of  fixes to 
> https://issues.apache.org/jira/browse/AMBARI-20687 and renaming the 
> db-cleanup functionality to db-purge-history
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server 7044096 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  70c3661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java
>  788290b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupService.java
>  880207c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java
>  29a9041 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  b9e1fab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 38c0977 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  eea8032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  32a38da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  3a72aed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  37830b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  1536b80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  2954863 
>   ambari-server/src/main/python/ambari-server.py 235ef95 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py 6e16bc5 
>   ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java
>  7de5aae 
> 
> 
> Diff: https://reviews.apache.org/r/60033/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> ambari-server db-purge-history --cluster-name cl1 --from-date 2017-06-13
> 
> Verified that all request related records except the ones that belong to 
> upgrade were purged.
> 
> 
> Unit tests:
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.811 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.004 
> s]
> [INFO] Ambari Views ... SUCCESS [  3.824 
> s]
> [INFO] utility  SUCCESS [  1.411 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.387 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.708 
> s]
> [INFO] Ambari Server .. SUCCESS [33:10 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:25 min
> [INFO] Finished at: 2017-06-12T23:20:03+02:00
> [INFO] Final Memory: 56M/389M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 60033: Ambari data purging

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60033/#review177870
---


Ship it!




Ship It!

- Sandor Magyari


On June 13, 2017, 4:43 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60033/
> ---
> 
> (Updated June 13, 2017, 4:43 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo 
> Puskas, Robert Levas, Sandor Magyari, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20749
> https://issues.apache.org/jira/browse/AMBARI-20749
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding a couple of  fixes to 
> https://issues.apache.org/jira/browse/AMBARI-20687 and renaming the 
> db-cleanup functionality to db-purge-history
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server 7044096 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  70c3661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java
>  788290b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupService.java
>  880207c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java
>  29a9041 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  b9e1fab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 38c0977 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
>  eea8032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java
>  32a38da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java
>  3a72aed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java
>  37830b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java
>  1536b80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java
>  2954863 
>   ambari-server/src/main/python/ambari-server.py 235ef95 
>   ambari-server/src/main/python/ambari_server/dbCleanup.py 6e16bc5 
>   ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java
>  7de5aae 
> 
> 
> Diff: https://reviews.apache.org/r/60033/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> ambari-server db-purge-history --cluster-name cl1 --from-date 2017-06-13
> 
> Verified that all request related records except the ones that belong to 
> upgrade were purged.
> 
> 
> Unit tests:
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.811 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.004 
> s]
> [INFO] Ambari Views ... SUCCESS [  3.824 
> s]
> [INFO] utility  SUCCESS [  1.411 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.387 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.708 
> s]
> [INFO] Ambari Server .. SUCCESS [33:10 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:25 min
> [INFO] Finished at: 2017-06-12T23:20:03+02:00
> [INFO] Final Memory: 56M/389M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 60050: AMBARI-21240. Some topology request data retained after host removed

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60050/#review177866
---




ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
Lines 133-140 (patched)


This bit should be factored out into a separate method which than can 
commonly used from ClustersImpl as well.


- Sebastian Toader


On June 13, 2017, 6:22 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60050/
> ---
> 
> (Updated June 13, 2017, 6:22 p.m.)
> 
> 
> Review request for Ambari, Sandor Magyari, Sumit Mohanty, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21240
> https://issues.apache.org/jira/browse/AMBARI-21240
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove orphaned `topology_logical_request` and `topology_request`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  e0a496509e9256d5ca550e7dd79ae0cd0fb5882b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
>  a8b202e31b390f483d6ed1aee470179f519388a8 
> 
> 
> Diff: https://reviews.apache.org/r/60050/diff/1/
> 
> 
> Testing
> ---
> 
> Functional test:
> 
>  * up/downscale by 1 host (verify topology request is removed)
>  * upscale by 2 hosts, downscale by 1 host (verify topology request is 
> retained)
>  * upscale by 2 hosts with 1 pending, downscale by 1 host (verify topology 
> request is retained)
>  * upscale by 3 hosts with 1 pending, remove pending host assignments (verify 
> topology request is retained)
>  * upscale by 3 hosts with 3 pending, remove pending host assignments (verify 
> topology request is removed)
>  * restart Ambari Server (verify no database error reported)
> 
> Unit tests:
> 
> ```
> Tests run: 4982, Failures: 0, Errors: 0, Skipped: 39
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>