date:20170707

Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-07 Thread Prabhjyot Singh



> On July 7, 2017, 10:52 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
> > Line 98 (original), 98 (patched)
> > 
> >
> > How will this impact existing installs?

Installation will happen without any problem, it's just that this variable is 
renamed (Ref: 
https://github.com/apache/zeppelin/blob/master/conf/zeppelin-env.sh.template#L59),
 and when user wants to use this feature it may cause confusion.


- Prabhjyot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review179891
---


On July 7, 2017, 12:22 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 12:22 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-07 Thread Prabhjyot Singh



> On July 7, 2017, 2:22 p.m., venkat sairam wrote:
> > Where is the value exported used in the application?

This is consumed by Zeppelin server.
Ref: 
https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/KerberosInterpreter.java#L79


- Prabhjyot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review179855
---


On July 7, 2017, 12:22 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 12:22 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/#review179959
---


Ship it!




Ship It!

- Sid Wagle


On July 7, 2017, 9:48 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60709/
> ---
> 
> (Updated July 7, 2017, 9:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush 
> Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21430
> https://issues.apache.org/jira/browse/AMBARI-21430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, the stack tools:
> 
> - {{cluster-env/stack_features}}
> - {{cluster-env/stack_tools}}
> - {{cluster-env/stack_root}}
> 
> Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
> sets of stack tools from co-existing. Although Ambari doesn't support more 
> than a single stack in 2.x, we do support upgrades from one stack vendor to 
> another. Therefore, we need this support to send the right tools on the 
> commands.
> 
> This will involve the following work:
> - Changing the existing stack tools/features/root to have a stack name as the 
> key in the JSON
> - Altering the existing {{cluster-env}} tools on upgrade
> - Ensuring that the stack tools/features for a repository's stack exist when 
> distributing that stack
> - Changing any Python code which references the stack tools (stack_tools.py, 
> alerts, etc)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2b3df5f2da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 04928de595 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  fc66f53e11 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
>  3681eda976 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  d556b603a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  061cdf7207 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  64e0b14cfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  0dacb568c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13114dd772 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  106d7c85b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  0ab8180027 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  32df7d3819 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  98d1899776 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  0e9fe741d0 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 
> 4c5834f83b 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> f8755c911f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
>  93c79481f0 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  4627e731c5 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
>  fdbbdf96bc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  a79e904cdf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  878645b62a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
> d1aab4bba8 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml
>  7df00eea8e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json
>  e9e0ed219c 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
> 535b9d9e0d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  1c2f33ecfe 
>   ambari-server/src/test/python/common-services/configs/hawq_default.json 
> 79864a9525 
>   ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py 0d47061945 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json 
> a1d930c5c1 
>   a

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/#review179956
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 7, 2017, 9:48 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60709/
> ---
> 
> (Updated July 7, 2017, 9:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush 
> Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21430
> https://issues.apache.org/jira/browse/AMBARI-21430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, the stack tools:
> 
> - {{cluster-env/stack_features}}
> - {{cluster-env/stack_tools}}
> - {{cluster-env/stack_root}}
> 
> Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
> sets of stack tools from co-existing. Although Ambari doesn't support more 
> than a single stack in 2.x, we do support upgrades from one stack vendor to 
> another. Therefore, we need this support to send the right tools on the 
> commands.
> 
> This will involve the following work:
> - Changing the existing stack tools/features/root to have a stack name as the 
> key in the JSON
> - Altering the existing {{cluster-env}} tools on upgrade
> - Ensuring that the stack tools/features for a repository's stack exist when 
> distributing that stack
> - Changing any Python code which references the stack tools (stack_tools.py, 
> alerts, etc)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2b3df5f2da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 04928de595 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  fc66f53e11 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
>  3681eda976 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  d556b603a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  061cdf7207 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  64e0b14cfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  0dacb568c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13114dd772 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  106d7c85b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  0ab8180027 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  32df7d3819 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  98d1899776 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  0e9fe741d0 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 
> 4c5834f83b 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> f8755c911f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
>  93c79481f0 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  4627e731c5 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
>  fdbbdf96bc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  a79e904cdf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  878645b62a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
> d1aab4bba8 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml
>  7df00eea8e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json
>  e9e0ed219c 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
> 535b9d9e0d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  1c2f33ecfe 
>   ambari-server/src/test/python/common-services/configs/hawq_default.json 
> 79864a9525 
>   ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py 0d47061945 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json 
> a1d930c

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/#review179950
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 2935-2974 (patched)


New method here basically says "I don't care if you supplied any of the 
stack features/tools - they are read-only and I'm getting them from the stack"

This prevents the need to change existing BPs that users have created.


- Jonathan Hurley


On July 7, 2017, 5:48 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60709/
> ---
> 
> (Updated July 7, 2017, 5:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush 
> Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21430
> https://issues.apache.org/jira/browse/AMBARI-21430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, the stack tools:
> 
> - {{cluster-env/stack_features}}
> - {{cluster-env/stack_tools}}
> - {{cluster-env/stack_root}}
> 
> Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
> sets of stack tools from co-existing. Although Ambari doesn't support more 
> than a single stack in 2.x, we do support upgrades from one stack vendor to 
> another. Therefore, we need this support to send the right tools on the 
> commands.
> 
> This will involve the following work:
> - Changing the existing stack tools/features/root to have a stack name as the 
> key in the JSON
> - Altering the existing {{cluster-env}} tools on upgrade
> - Ensuring that the stack tools/features for a repository's stack exist when 
> distributing that stack
> - Changing any Python code which references the stack tools (stack_tools.py, 
> alerts, etc)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2b3df5f2da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 04928de595 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  fc66f53e11 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
>  3681eda976 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  d556b603a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  061cdf7207 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  64e0b14cfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  0dacb568c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13114dd772 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  106d7c85b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  0ab8180027 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  32df7d3819 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  98d1899776 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  0e9fe741d0 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 
> 4c5834f83b 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> f8755c911f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
>  93c79481f0 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  4627e731c5 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
>  fdbbdf96bc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  a79e904cdf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  878645b62a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
> d1aab4bba8 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml
>  7df00eea8e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json
>  e9e0ed219c 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
> 535b9d9e0d

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/
---

(Updated July 7, 2017, 5:48 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush 
Luniya, Nate Cole, and Sid Wagle.


Changes
---

Updated the BP config processor to use the values from the stack since they are 
read only. This prevents the need to change existing BPs. Updated tests to pass.


Bugs: AMBARI-21430
https://issues.apache.org/jira/browse/AMBARI-21430


Repository: ambari


Description
---

Currently, the stack tools:

- {{cluster-env/stack_features}}
- {{cluster-env/stack_tools}}
- {{cluster-env/stack_root}}

Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
sets of stack tools from co-existing. Although Ambari doesn't support more than 
a single stack in 2.x, we do support upgrades from one stack vendor to another. 
Therefore, we need this support to send the right tools on the commands.

This will involve the following work:
- Changing the existing stack tools/features/root to have a stack name as the 
key in the JSON
- Altering the existing {{cluster-env}} tools on upgrade
- Ensuring that the stack tools/features for a repository's stack exist when 
distributing that stack
- Changing any Python code which references the stack tools (stack_tools.py, 
alerts, etc)


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 2b3df5f2da 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
 02ae62daf3 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
04928de595 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 fc66f53e11 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
 3681eda976 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 d556b603a8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 061cdf7207 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 64e0b14cfe 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 0dacb568c2 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
13114dd772 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 106d7c85b3 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
 0ab8180027 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
 32df7d3819 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
 98d1899776 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
 0e9fe741d0 
  ambari-server/src/main/resources/host_scripts/alert_disk_space.py 4c5834f83b 
  ambari-server/src/main/resources/host_scripts/alert_version_select.py 
f8755c911f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
 93c79481f0 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
 4627e731c5 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
 fdbbdf96bc 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
a79e904cdf 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 878645b62a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
d1aab4bba8 
  
ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml 
7df00eea8e 
  
ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json 
e9e0ed219c 
  ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
535b9d9e0d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
 1c2f33ecfe 
  ambari-server/src/test/python/common-services/configs/hawq_default.json 
79864a9525 
  ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py 0d47061945 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json 
a1d930c5c1 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 
f959b1fd5d 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json 
05cb78a42b 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 
4e7d8573d2 
  ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json 
abe84abe47 
  ambari-server/src/test/python/stacks/2.6/confi

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-07 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/#review179939
---




ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
Lines 444 (patched)


Just do this,

remove_wal_dir = default('/configurations/hbase-env/remove_wal_dir', False)


- Alejandro Fernandez


On July 7, 2017, 7:34 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60691/
> ---
> 
> (Updated July 7, 2017, 7:34 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21420
> https://issues.apache.org/jira/browse/AMBARI-21420
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. 
> HBase master appeared as if it had started according to the Ambari action log 
> but later crashed with error:
> 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] 
> master.HMaster: Failed to become active masterjava.io.IOException: The 
> procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure 
> must be accessible and have an empty constructorat 
> org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at
>  org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
>  
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
>  org.apach
 e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
> Attach one or more files to this issue
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a1003dc 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  43c6036 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60691/diff/3/
> 
> 
> Testing
> ---
> 
> will be tested in the integration tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60715: AMBARI-21421 EU upgrade pack to update Hive and Yarn properties to remove IOP/BigSQL properties

2017-07-07 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60715/#review179937
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 7, 2017, 7:16 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60715/
> ---
> 
> (Updated July 7, 2017, 7:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21421
> https://issues.apache.org/jira/browse/AMBARI-21421
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> IOP Yarn has property "" that requires Spark Shuffle Jar. HDP does not have 
> this jar. The property needs to be removed during EU.
> BigSQL also inserts a property to hive-site that causes Hive to crash 
> during/post EU due to the unique BigSQL upgrade/migrate process (that 
> requires BigSQL to be removed before EU). This property needs to be removed 
> as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60715/diff/1/
> 
> 
> Testing
> ---
> 
> integrated tests during EU
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/#review179934
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 7, 2017, 6:31 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60709/
> ---
> 
> (Updated July 7, 2017, 6:31 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush 
> Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21430
> https://issues.apache.org/jira/browse/AMBARI-21430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, the stack tools:
> 
> - {{cluster-env/stack_features}}
> - {{cluster-env/stack_tools}}
> - {{cluster-env/stack_root}}
> 
> Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
> sets of stack tools from co-existing. Although Ambari doesn't support more 
> than a single stack in 2.x, we do support upgrades from one stack vendor to 
> another. Therefore, we need this support to send the right tools on the 
> commands.
> 
> This will involve the following work:
> - Changing the existing stack tools/features/root to have a stack name as the 
> key in the JSON
> - Altering the existing {{cluster-env}} tools on upgrade
> - Ensuring that the stack tools/features for a repository's stack exist when 
> distributing that stack
> - Changing any Python code which references the stack tools (stack_tools.py, 
> alerts, etc)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2b3df5f2da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 04928de595 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  fc66f53e11 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
>  3681eda976 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  d556b603a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  64e0b14cfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  0dacb568c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13114dd772 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  0ab8180027 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  32df7d3819 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  98d1899776 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  0e9fe741d0 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 
> 4c5834f83b 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> f8755c911f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
>  93c79481f0 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  4627e731c5 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
>  fdbbdf96bc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  a79e904cdf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  878645b62a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
> d1aab4bba8 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml
>  7df00eea8e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json
>  e9e0ed219c 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
> 535b9d9e0d 
> 
> 
> Diff: https://reviews.apache.org/r/60709/diff/2/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Alejandro Fernandez



> On July 7, 2017, 5:29 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py
> > Lines 558 (patched)
> > 
> >
> > We should not default to one particular stack over another
> 
> Jonathan Hurley wrote:
> I totally agree. However, this was the original code that was there and 
> removing it could expose all sorts of weirdo cracks. Something that we can't 
> afford right now. Are you OK with us keeping this (since it's the way it was) 
> and opening a Jira to track it?

Sure, let's add a Jira for any miscellaneous items.


> On July 7, 2017, 5:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
> > Lines 104 (patched)
> > 
> >
> > I believe this should be called on ambari server start instead of this 
> > particular Ambari Upgrade.
> 
> Jonathan Hurley wrote:
> This is a specific issue to Ambari 2.5.2 since it changes the value of 
> what was on Ambari 2.5.1 and earlier. These properties are read-only (as 
> defined in the clsuter-env.xml) and are not exposed anywhere for changing. 
> That's why I put it on the upgrade. That's why I isolated it to the upgrade. 
> Do you really feel strongly that we need to put it on a server start? 
> 99.99% of the time, it won't be needed, right?

Server start could address any fixes in the stack_features.json. But again, 
this can be miscellaneous improvements after we get the critical path working.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/#review179892
---


On July 7, 2017, 6:31 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60709/
> ---
> 
> (Updated July 7, 2017, 6:31 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush 
> Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21430
> https://issues.apache.org/jira/browse/AMBARI-21430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, the stack tools:
> 
> - {{cluster-env/stack_features}}
> - {{cluster-env/stack_tools}}
> - {{cluster-env/stack_root}}
> 
> Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
> sets of stack tools from co-existing. Although Ambari doesn't support more 
> than a single stack in 2.x, we do support upgrades from one stack vendor to 
> another. Therefore, we need this support to send the right tools on the 
> commands.
> 
> This will involve the following work:
> - Changing the existing stack tools/features/root to have a stack name as the 
> key in the JSON
> - Altering the existing {{cluster-env}} tools on upgrade
> - Ensuring that the stack tools/features for a repository's stack exist when 
> distributing that stack
> - Changing any Python code which references the stack tools (stack_tools.py, 
> alerts, etc)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2b3df5f2da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 04928de595 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  fc66f53e11 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
>  3681eda976 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  d556b603a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  64e0b14cfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  0dacb568c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13114dd772 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  0ab8180027 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  32df7d3819 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  98d1899776 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  0e9fe741d0 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 
> 4c5834f83b 
>   ambari-server/src/main

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-07 Thread Di Li



> On July 7, 2017, 5 p.m., Jonathan Hurley wrote:
> > I don't know enough about HBase internals - is removing the write-ahead log 
> > safe - especially during a complex upgrade? Isn't it like a last line of 
> > defense in case something goes very wrong?
> 
> Di Li wrote:
> yes, this is indeed the last resort as it's either removing the wal dir 
> or having HBase master dead in the water. HBase JIRA 
> https://issues.apache.org/jira/browse/HBASE-14783 is for the issue, but it is 
> still open. IOP uses this remove wal dir approach to deal with downgrading 
> from 4.2.5 to 4.1. The patch here is a port of the internal logic for the 
> migration use case.
> 
> It's either this patch (automated during EU) or a manual step post EU.
> 
> Di Li wrote:
> Forgot to mention that I am OK either way A) automated during EU or B) a 
> manual step post EU.
> 
> Jonathan Hurley wrote:
> Yeah - I'm just wondering if we should open an item for fixing this 
> correctly? Is there any other way aside from deleting it? Will Hbase provide 
> a script to run on startup which fixes it?

I don't really know any other ways, I am afraid. The feedback from our HBase 
team was the removal of the wal dir thus the logic shown in the patch. I would 
also prefer a fix on the HBase side to deal with the issue.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/#review179888
---


On July 7, 2017, 7:34 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60691/
> ---
> 
> (Updated July 7, 2017, 7:34 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21420
> https://issues.apache.org/jira/browse/AMBARI-21420
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. 
> HBase master appeared as if it had started according to the Ambari action log 
> but later crashed with error:
> 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] 
> master.HMaster: Failed to become active masterjava.io.IOException: The 
> procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure 
> must be accessible and have an empty constructorat 
> org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at
>  org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
>  
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
>  org.apach
 e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
> Attach one or more files to this issue
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a1003dc 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  43c6036 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60691/diff/3/
> 
> 
> Testing
> ---
> 
> will be tested in the integration tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-07 Thread Jonathan Hurley



> On July 7, 2017, 1 p.m., Jonathan Hurley wrote:
> > I don't know enough about HBase internals - is removing the write-ahead log 
> > safe - especially during a complex upgrade? Isn't it like a last line of 
> > defense in case something goes very wrong?
> 
> Di Li wrote:
> yes, this is indeed the last resort as it's either removing the wal dir 
> or having HBase master dead in the water. HBase JIRA 
> https://issues.apache.org/jira/browse/HBASE-14783 is for the issue, but it is 
> still open. IOP uses this remove wal dir approach to deal with downgrading 
> from 4.2.5 to 4.1. The patch here is a port of the internal logic for the 
> migration use case.
> 
> It's either this patch (automated during EU) or a manual step post EU.
> 
> Di Li wrote:
> Forgot to mention that I am OK either way A) automated during EU or B) a 
> manual step post EU.

Yeah - I'm just wondering if we should open an item for fixing this correctly? 
Is there any other way aside from deleting it? Will Hbase provide a script to 
run on startup which fixes it?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/#review179888
---


On July 7, 2017, 3:34 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60691/
> ---
> 
> (Updated July 7, 2017, 3:34 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21420
> https://issues.apache.org/jira/browse/AMBARI-21420
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. 
> HBase master appeared as if it had started according to the Ambari action log 
> but later crashed with error:
> 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] 
> master.HMaster: Failed to become active masterjava.io.IOException: The 
> procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure 
> must be accessible and have an empty constructorat 
> org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at
>  org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
>  
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
>  org.apach
 e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
> Attach one or more files to this issue
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a1003dc 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  43c6036 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60691/diff/3/
> 
> 
> Testing
> ---
> 
> will be tested in the integration tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-07 Thread Di Li



> On July 7, 2017, 5 p.m., Jonathan Hurley wrote:
> > I don't know enough about HBase internals - is removing the write-ahead log 
> > safe - especially during a complex upgrade? Isn't it like a last line of 
> > defense in case something goes very wrong?

yes, this is indeed the last resort as it's either removing the wal dir or 
having HBase master dead in the water. HBase JIRA 
https://issues.apache.org/jira/browse/HBASE-14783 is for the issue, but it is 
still open. IOP uses this remove wal dir approach to deal with downgrading from 
4.2.5 to 4.1. The patch here is a port of the internal logic for the migration 
use case.

It's either this patch (automated during EU) or a manual step post EU.


> On July 7, 2017, 5 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
> > Lines 41-43 (patched)
> > 
> >
> > Do we need to worry about running this with kinit if Kerberized? If 
> > not, you can drop this issue.

My tests showed  that it worked on a secured cluster, dropping the issue for 
now.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/#review179888
---


On July 7, 2017, 1:15 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60691/
> ---
> 
> (Updated July 7, 2017, 1:15 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21420
> https://issues.apache.org/jira/browse/AMBARI-21420
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. 
> HBase master appeared as if it had started according to the Ambari action log 
> but later crashed with error:
> 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] 
> master.HMaster: Failed to become active masterjava.io.IOException: The 
> procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure 
> must be accessible and have an empty constructorat 
> org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at
>  org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
>  
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
>  org.apach
 e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
> Attach one or more files to this issue
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a1003dc 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  43c6036 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60691/diff/2/
> 
> 
> Testing
> ---
> 
> will be tested in the integration tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-07 Thread Di Li



> On July 7, 2017, 5 p.m., Jonathan Hurley wrote:
> > I don't know enough about HBase internals - is removing the write-ahead log 
> > safe - especially during a complex upgrade? Isn't it like a last line of 
> > defense in case something goes very wrong?
> 
> Di Li wrote:
> yes, this is indeed the last resort as it's either removing the wal dir 
> or having HBase master dead in the water. HBase JIRA 
> https://issues.apache.org/jira/browse/HBASE-14783 is for the issue, but it is 
> still open. IOP uses this remove wal dir approach to deal with downgrading 
> from 4.2.5 to 4.1. The patch here is a port of the internal logic for the 
> migration use case.
> 
> It's either this patch (automated during EU) or a manual step post EU.

Forgot to mention that I am OK either way A) automated during EU or B) a manual 
step post EU.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/#review179888
---


On July 7, 2017, 7:34 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60691/
> ---
> 
> (Updated July 7, 2017, 7:34 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21420
> https://issues.apache.org/jira/browse/AMBARI-21420
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. 
> HBase master appeared as if it had started according to the Ambari action log 
> but later crashed with error:
> 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] 
> master.HMaster: Failed to become active masterjava.io.IOException: The 
> procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure 
> must be accessible and have an empty constructorat 
> org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at
>  org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
>  
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
>  org.apach
 e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
> Attach one or more files to this issue
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a1003dc 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  43c6036 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60691/diff/3/
> 
> 
> Testing
> ---
> 
> will be tested in the integration tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-07 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/
---

(Updated July 7, 2017, 7:34 p.m.)


Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21420
https://issues.apache.org/jira/browse/AMBARI-21420


Repository: ambari


Description
---

HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. HBase 
master appeared as if it had started according to the Ambari action log but 
later crashed with error:
2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] master.HMaster: 
Failed to become active masterjava.io.IOException: The procedure class 
org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure must be 
accessible and have an empty constructorat 
org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at 
org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
 
org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
 
org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
 
org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
 org.apache.
 hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
Attach one or more files to this issue
Attachments


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
 a1003dc 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 43c6036 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
 6597055 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
 af87794 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
 6597055 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
 af87794 


Diff: https://reviews.apache.org/r/60691/diff/3/

Changes: https://reviews.apache.org/r/60691/diff/2-3/


Testing
---

will be tested in the integration tests.


Thanks,

Di Li

Review Request 60715: AMBARI-21421 EU upgrade pack to update Hive and Yarn properties to remove IOP/BigSQL properties

2017-07-07 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60715/
---

Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21421
https://issues.apache.org/jira/browse/AMBARI-21421


Repository: ambari


Description
---

IOP Yarn has property "" that requires Spark Shuffle Jar. HDP does not have 
this jar. The property needs to be removed during EU.
BigSQL also inserts a property to hive-site that causes Hive to crash 
during/post EU due to the unique BigSQL upgrade/migrate process (that requires 
BigSQL to be removed before EU). This property needs to be removed as well.


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
 6597055 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
 af87794 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
 6597055 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
 af87794 


Diff: https://reviews.apache.org/r/60715/diff/1/


Testing
---

integrated tests during EU


Thanks,

Di Li

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/
---

(Updated July 7, 2017, 2:31 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush 
Luniya, Nate Cole, and Sid Wagle.


Bugs: AMBARI-21430
https://issues.apache.org/jira/browse/AMBARI-21430


Repository: ambari


Description
---

Currently, the stack tools:

- {{cluster-env/stack_features}}
- {{cluster-env/stack_tools}}
- {{cluster-env/stack_root}}

Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
sets of stack tools from co-existing. Although Ambari doesn't support more than 
a single stack in 2.x, we do support upgrades from one stack vendor to another. 
Therefore, we need this support to send the right tools on the commands.

This will involve the following work:
- Changing the existing stack tools/features/root to have a stack name as the 
key in the JSON
- Altering the existing {{cluster-env}} tools on upgrade
- Ensuring that the stack tools/features for a repository's stack exist when 
distributing that stack
- Changing any Python code which references the stack tools (stack_tools.py, 
alerts, etc)


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 2b3df5f2da 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
 02ae62daf3 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
04928de595 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 fc66f53e11 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
 3681eda976 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 d556b603a8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 64e0b14cfe 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 0dacb568c2 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
13114dd772 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
 0ab8180027 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
 32df7d3819 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
 98d1899776 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
 0e9fe741d0 
  ambari-server/src/main/resources/host_scripts/alert_disk_space.py 4c5834f83b 
  ambari-server/src/main/resources/host_scripts/alert_version_select.py 
f8755c911f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
 93c79481f0 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
 4627e731c5 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
 fdbbdf96bc 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
a79e904cdf 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 878645b62a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
d1aab4bba8 
  
ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml 
7df00eea8e 
  
ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json 
e9e0ed219c 
  ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
535b9d9e0d 


Diff: https://reviews.apache.org/r/60709/diff/2/

Changes: https://reviews.apache.org/r/60709/diff/1-2/


Testing
---

PENDING


Thanks,

Jonathan Hurley

Re: Review Request 60711: Assigning hosts concurrently to same config group may fail with "org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Config group already exist'

2017-07-07 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60711/#review179897
---


Ship it!




Ship It!

- Attila Magyar


On July 7, 2017, 5 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60711/
> ---
> 
> (Updated July 7, 2017, 5 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-21427
> https://issues.apache.org/jira/browse/AMBARI-21427
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM:
> Assigning hosts concurrently to the same config group may fail due to a race 
> condition causing the config group to be created twice:
> 
> ```
> 05 Jul 2017 18:50:44,742  INFO [pool-5-thread-2] 
> RegisterWithConfigGroupTask:45 - HostRequest: Executing CONFIGURE task for 
> host: w1.internal
> 
> 05 Jul 2017 18:50:44,884 ERROR [pool-5-thread-2] AmbariContext:655 - Failed 
> to create new configuration group: 
> org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: 
> Config group already exists with the same name and tag, clusterName = 
> mycluster, groupName = myblueprint:group1, tag = HDFS
> 05 Jul 2017 18:50:44,885 ERROR [pool-5-thread-2] AmbariContext:342 - Unable 
> to register config group for host: 
> java.lang.RuntimeException: Failed to create new configuration group: 
> org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: 
> Config group already exists with the same name and tag, clusterName = 
> mycluster, groupName = myblueprint:group1, tag = HDFS
> at 
> org.apache.ambari.server.topology.AmbariContext.createConfigGroupsAndRegisterHost(AmbariContext.java:656)
> at 
> org.apache.ambari.server.topology.AmbariContext.registerHostWithConfigGroup(AmbariContext.java:339)
> at 
> org.apache.ambari.server.topology.tasks.RegisterWithConfigGroupTask.runTask(RegisterWithConfigGroupTask.java:46)
> at 
> org.apache.ambari.server.topology.tasks.TopologyHostTask.run(TopologyHostTask.java:51)
> at 
> org.apache.ambari.server.topology.HostOfferResponse$1.run(HostOfferResponse.java:83)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: 
> org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: 
> Config group already exists with the same name and tag, clusterName = 
> mycluster, groupName = myblueprint:group1, tag = HDFS
> at 
> org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:282)
> at 
> org.apache.ambari.server.controller.internal.ConfigGroupResourceProvider.createResources(ConfigGroupResourceProvider.java:276)
> at 
> org.apache.ambari.server.topology.AmbariContext.createConfigGroupsAndRegisterHost(AmbariContext.java:653)
> ... 7 more
> ```
> 
> SOLUTION:
> Synchronize the verification of the config group existence and creation of a 
> config group with the same name.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0467b9b 
> 
> 
> Diff: https://reviews.apache.org/r/60711/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> Created a cluster using Blueprint with configurations specified in the host 
> groups to trigger config group creation.
> ambari.properties included ```topology.task.creation.parallel=true``` to 
> trigger parallel host assignment to config groups.
> 
> 
> Unit tests:
> Failed tests: 
>   
> RestMetricsPropertyProviderTest.testRestMetricsPropertyProviderAsAdministrator:222->testPopulateResourcesMany:457
>  expected:<400> but was:<121>
> 
> Tests run: 4797, Failures: 1, Errors: 0, Skipped: 35
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [ 53.583 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.012 
> s]
> [INFO] Ambari Views ... SUCCESS [  5.241 
> s]
> [INFO] ambari-utility . SUCCESS [  7.855 
> s]
> [INFO] ambari-metrics . SUCCESS [  1.334 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [ 10.795 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.886 
> s]
> [INFO] Ambari Server .. FAILURE [  01:05 
> h]
> [INFO] 
> ---

Re: Review Request 60711: Assigning hosts concurrently to same config group may fail with "org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Config group already exist'

2017-07-07 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60711/#review179896
---


Ship it!




Ship It!

- Robert Levas


On July 7, 2017, 1 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60711/
> ---
> 
> (Updated July 7, 2017, 1 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-21427
> https://issues.apache.org/jira/browse/AMBARI-21427
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM:
> Assigning hosts concurrently to the same config group may fail due to a race 
> condition causing the config group to be created twice:
> 
> ```
> 05 Jul 2017 18:50:44,742  INFO [pool-5-thread-2] 
> RegisterWithConfigGroupTask:45 - HostRequest: Executing CONFIGURE task for 
> host: w1.internal
> 
> 05 Jul 2017 18:50:44,884 ERROR [pool-5-thread-2] AmbariContext:655 - Failed 
> to create new configuration group: 
> org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: 
> Config group already exists with the same name and tag, clusterName = 
> mycluster, groupName = myblueprint:group1, tag = HDFS
> 05 Jul 2017 18:50:44,885 ERROR [pool-5-thread-2] AmbariContext:342 - Unable 
> to register config group for host: 
> java.lang.RuntimeException: Failed to create new configuration group: 
> org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: 
> Config group already exists with the same name and tag, clusterName = 
> mycluster, groupName = myblueprint:group1, tag = HDFS
> at 
> org.apache.ambari.server.topology.AmbariContext.createConfigGroupsAndRegisterHost(AmbariContext.java:656)
> at 
> org.apache.ambari.server.topology.AmbariContext.registerHostWithConfigGroup(AmbariContext.java:339)
> at 
> org.apache.ambari.server.topology.tasks.RegisterWithConfigGroupTask.runTask(RegisterWithConfigGroupTask.java:46)
> at 
> org.apache.ambari.server.topology.tasks.TopologyHostTask.run(TopologyHostTask.java:51)
> at 
> org.apache.ambari.server.topology.HostOfferResponse$1.run(HostOfferResponse.java:83)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: 
> org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: 
> Config group already exists with the same name and tag, clusterName = 
> mycluster, groupName = myblueprint:group1, tag = HDFS
> at 
> org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:282)
> at 
> org.apache.ambari.server.controller.internal.ConfigGroupResourceProvider.createResources(ConfigGroupResourceProvider.java:276)
> at 
> org.apache.ambari.server.topology.AmbariContext.createConfigGroupsAndRegisterHost(AmbariContext.java:653)
> ... 7 more
> ```
> 
> SOLUTION:
> Synchronize the verification of the config group existence and creation of a 
> config group with the same name.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0467b9b 
> 
> 
> Diff: https://reviews.apache.org/r/60711/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing:
> Created a cluster using Blueprint with configurations specified in the host 
> groups to trigger config group creation.
> ambari.properties included ```topology.task.creation.parallel=true``` to 
> trigger parallel host assignment to config groups.
> 
> 
> Unit tests:
> Failed tests: 
>   
> RestMetricsPropertyProviderTest.testRestMetricsPropertyProviderAsAdministrator:222->testPopulateResourcesMany:457
>  expected:<400> but was:<121>
> 
> Tests run: 4797, Failures: 1, Errors: 0, Skipped: 35
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [ 53.583 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.012 
> s]
> [INFO] Ambari Views ... SUCCESS [  5.241 
> s]
> [INFO] ambari-utility . SUCCESS [  7.855 
> s]
> [INFO] ambari-metrics . SUCCESS [  1.334 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [ 10.795 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.886 
> s]
> [INFO] Ambari Server .. FAILURE [  01:05 
> h]
> [INFO] 
>

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Jonathan Hurley



> On July 7, 2017, 1:29 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py
> > Lines 558 (patched)
> > 
> >
> > We should not default to one particular stack over another

I totally agree. However, this was the original code that was there and 
removing it could expose all sorts of weirdo cracks. Something that we can't 
afford right now. Are you OK with us keeping this (since it's the way it was) 
and opening a Jira to track it?


> On July 7, 2017, 1:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
> > Lines 104 (patched)
> > 
> >
> > I believe this should be called on ambari server start instead of this 
> > particular Ambari Upgrade.

This is a specific issue to Ambari 2.5.2 since it changes the value of what was 
on Ambari 2.5.1 and earlier. These properties are read-only (as defined in the 
clsuter-env.xml) and are not exposed anywhere for changing. That's why I put it 
on the upgrade. That's why I isolated it to the upgrade. Do you really feel 
strongly that we need to put it on a server start? 99.99% of the time, it 
won't be needed, right?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/#review179892
---


On July 7, 2017, 12:52 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60709/
> ---
> 
> (Updated July 7, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush 
> Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21430
> https://issues.apache.org/jira/browse/AMBARI-21430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, the stack tools:
> 
> - {{cluster-env/stack_features}}
> - {{cluster-env/stack_tools}}
> - {{cluster-env/stack_root}}
> 
> Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
> sets of stack tools from co-existing. Although Ambari doesn't support more 
> than a single stack in 2.x, we do support upgrades from one stack vendor to 
> another. Therefore, we need this support to send the right tools on the 
> commands.
> 
> This will involve the following work:
> - Changing the existing stack tools/features/root to have a stack name as the 
> key in the JSON
> - Altering the existing {{cluster-env}} tools on upgrade
> - Ensuring that the stack tools/features for a repository's stack exist when 
> distributing that stack
> - Changing any Python code which references the stack tools (stack_tools.py, 
> alerts, etc)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2b3df5f2da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 04928de595 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  64e0b14cfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13114dd772 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  0ab8180027 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  32df7d3819 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  98d1899776 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  0e9fe741d0 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 
> 4c5834f83b 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> f8755c911f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
>  93c79481f0 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  4627e731c5 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
>  fdbbdf96bc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  a79e904cdf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  878645b62a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
> d1aab4bba8 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/configuration/clust

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/#review179892
---




ambari-common/src/main/python/resource_management/libraries/script/script.py
Lines 558 (patched)


We should not default to one particular stack over another



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
Lines 1008 (patched)


Nice



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
Lines 104 (patched)


I believe this should be called on ambari server start instead of this 
particular Ambari Upgrade.


- Alejandro Fernandez


On July 7, 2017, 4:52 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60709/
> ---
> 
> (Updated July 7, 2017, 4:52 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush 
> Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21430
> https://issues.apache.org/jira/browse/AMBARI-21430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, the stack tools:
> 
> - {{cluster-env/stack_features}}
> - {{cluster-env/stack_tools}}
> - {{cluster-env/stack_root}}
> 
> Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
> sets of stack tools from co-existing. Although Ambari doesn't support more 
> than a single stack in 2.x, we do support upgrades from one stack vendor to 
> another. Therefore, we need this support to send the right tools on the 
> commands.
> 
> This will involve the following work:
> - Changing the existing stack tools/features/root to have a stack name as the 
> key in the JSON
> - Altering the existing {{cluster-env}} tools on upgrade
> - Ensuring that the stack tools/features for a repository's stack exist when 
> distributing that stack
> - Changing any Python code which references the stack tools (stack_tools.py, 
> alerts, etc)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2b3df5f2da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 04928de595 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  64e0b14cfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13114dd772 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  0ab8180027 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  32df7d3819 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  98d1899776 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  0e9fe741d0 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 
> 4c5834f83b 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> f8755c911f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
>  93c79481f0 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  4627e731c5 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
>  fdbbdf96bc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  a79e904cdf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  878645b62a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
> d1aab4bba8 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml
>  7df00eea8e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json
>  e9e0ed219c 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
> 535b9d9e0d 
> 
> 
> Diff: https://reviews.apache.org/r/60709/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-07 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review179891
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
Line 98 (original), 98 (patched)


How will this impact existing installs?


- Alejandro Fernandez


On July 7, 2017, 6:52 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-07 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/#review179890
---




ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
Lines 446 (patched)


This still has a bug, I believe default("someconfig") will actually return 
the boolean, but if not defined you're setting the default to the string 
"false", so the type will be different.

Once you do convert to str() in the next line, the case will be different, 
and finally, you cannot compare the string to the boolean true in the following 
line.


- Alejandro Fernandez


On July 7, 2017, 1:15 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60691/
> ---
> 
> (Updated July 7, 2017, 1:15 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21420
> https://issues.apache.org/jira/browse/AMBARI-21420
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. 
> HBase master appeared as if it had started according to the Ambari action log 
> but later crashed with error:
> 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] 
> master.HMaster: Failed to become active masterjava.io.IOException: The 
> procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure 
> must be accessible and have an empty constructorat 
> org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at
>  org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
>  
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
>  org.apach
 e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
> Attach one or more files to this issue
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a1003dc 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  43c6036 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60691/diff/2/
> 
> 
> Testing
> ---
> 
> will be tested in the integration tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/#review179888
---


Fix it, then Ship it!




I don't know enough about HBase internals - is removing the write-ahead log 
safe - especially during a complex upgrade? Isn't it like a last line of 
defense in case something goes very wrong?


ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
Lines 41-43 (patched)


Do we need to worry about running this with kinit if Kerberized? If not, 
you can drop this issue.



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
Lines 442 (patched)


What's being formatted here?


- Jonathan Hurley


On July 7, 2017, 9:15 a.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60691/
> ---
> 
> (Updated July 7, 2017, 9:15 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21420
> https://issues.apache.org/jira/browse/AMBARI-21420
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. 
> HBase master appeared as if it had started according to the Ambari action log 
> but later crashed with error:
> 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] 
> master.HMaster: Failed to become active masterjava.io.IOException: The 
> procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure 
> must be accessible and have an empty constructorat 
> org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at
>  org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
>  
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
>  org.apach
 e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
> Attach one or more files to this issue
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a1003dc 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  43c6036 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60691/diff/2/
> 
> 
> Testing
> ---
> 
> will be tested in the integration tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 60711: Assigning hosts concurrently to same config group may fail with "org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Config group already exist'

2017-07-07 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60711/
---

Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, and 
Sandor Magyari.


Bugs: AMBARI-21427
https://issues.apache.org/jira/browse/AMBARI-21427


Repository: ambari


Description
---

PROBLEM:
Assigning hosts concurrently to the same config group may fail due to a race 
condition causing the config group to be created twice:

```
05 Jul 2017 18:50:44,742  INFO [pool-5-thread-2] RegisterWithConfigGroupTask:45 
- HostRequest: Executing CONFIGURE task for host: w1.internal

05 Jul 2017 18:50:44,884 ERROR [pool-5-thread-2] AmbariContext:655 - Failed to 
create new configuration group: 
org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Config 
group already exists with the same name and tag, clusterName = mycluster, 
groupName = myblueprint:group1, tag = HDFS
05 Jul 2017 18:50:44,885 ERROR [pool-5-thread-2] AmbariContext:342 - Unable to 
register config group for host: 
java.lang.RuntimeException: Failed to create new configuration group: 
org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Config 
group already exists with the same name and tag, clusterName = mycluster, 
groupName = myblueprint:group1, tag = HDFS
at 
org.apache.ambari.server.topology.AmbariContext.createConfigGroupsAndRegisterHost(AmbariContext.java:656)
at 
org.apache.ambari.server.topology.AmbariContext.registerHostWithConfigGroup(AmbariContext.java:339)
at 
org.apache.ambari.server.topology.tasks.RegisterWithConfigGroupTask.runTask(RegisterWithConfigGroupTask.java:46)
at 
org.apache.ambari.server.topology.tasks.TopologyHostTask.run(TopologyHostTask.java:51)
at 
org.apache.ambari.server.topology.HostOfferResponse$1.run(HostOfferResponse.java:83)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Caused by: 
org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Config 
group already exists with the same name and tag, clusterName = mycluster, 
groupName = myblueprint:group1, tag = HDFS
at 
org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:282)
at 
org.apache.ambari.server.controller.internal.ConfigGroupResourceProvider.createResources(ConfigGroupResourceProvider.java:276)
at 
org.apache.ambari.server.topology.AmbariContext.createConfigGroupsAndRegisterHost(AmbariContext.java:653)
... 7 more
```

SOLUTION:
Synchronize the verification of the config group existence and creation of a 
config group with the same name.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 0467b9b 


Diff: https://reviews.apache.org/r/60711/diff/1/


Testing
---

Manual testing:
Created a cluster using Blueprint with configurations specified in the host 
groups to trigger config group creation.
ambari.properties included ```topology.task.creation.parallel=true``` to 
trigger parallel host assignment to config groups.


Unit tests:
Failed tests: 
  
RestMetricsPropertyProviderTest.testRestMetricsPropertyProviderAsAdministrator:222->testPopulateResourcesMany:457
 expected:<400> but was:<121>

Tests run: 4797, Failures: 1, Errors: 0, Skipped: 35

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main  SUCCESS [ 53.583 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.012 s]
[INFO] Ambari Views ... SUCCESS [  5.241 s]
[INFO] ambari-utility . SUCCESS [  7.855 s]
[INFO] ambari-metrics . SUCCESS [  1.334 s]
[INFO] Ambari Metrics Common .. SUCCESS [ 10.795 s]
[INFO] Ambari Service Advisor . SUCCESS [  0.886 s]
[INFO] Ambari Server .. FAILURE [  01:05 h]
[INFO] 


One metrics test failed and is not related to this change.


Thanks,

Sebastian Toader

Re: Review Request 60655: AMBARI-21405. Create custom action to force-remove packages

2017-07-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60655/#review179887
---


Ship it!




Ship It!

- Jonathan Hurley


On July 6, 2017, 2:32 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60655/
> ---
> 
> (Updated July 6, 2017, 2:32 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21405
> https://issues.apache.org/jira/browse/AMBARI-21405
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Add option in `Package` resource to remove package while leaving its 
> dependencies installed
> * Add custom action `force_remove_packages`
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 
> 66227c66a7768aa044f30a1c76d782c5101be678 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
>  21de1839c853794f252a4cb2265b89549a802d88 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/apt.py
>  d095173f07c46842b6e9e38dc933e06a3e43a749 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/choco.py
>  db552964279f509de90d2fde884bfc0fea12f7b0 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
>  ea10a8601430b62bbe216848e1d26a5e8bc16927 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
>  265c1626873bfb98196f102e73bb2dbedee94c80 
>   
> ambari-common/src/main/python/resource_management/core/resources/packaging.py 
> e3adc30f46abd3f33670f817421d88270b3e7ade 
>   
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
>  0f502568ddfb5da7d5574b2e33c6a354c37d9697 
>   
> ambari-server/src/main/resources/custom_actions/scripts/force_remove_packages.py
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60655/diff/2/
> 
> 
> Testing
> ---
> 
> Tested custom action as part of cross-stack upgrade on CentOS7.
> 
> Manually tested custom action on Debian 7.6:
> 
> ```
> $ curl -X POST -d '{ "RequestInfo": { "action": "force_remove_packages", 
> "parameters": { "package_list": "vim-common" } } }' 
> http://localhost:8080/api/v1/clusters/TEST/requests
> 
> output.txt:
> 2017-07-05 12:29:59,400 - Package['vim-common'] {'action': ['remove'], 
> 'remove_with_dependencies': False}
> 2017-07-05 12:29:59,411 - Removing package vim-common ('/usr/bin/dpkg 
> --remove --ignore-depends vim-common vim-common')
> 2017-07-05 12:30:00,702 - Removed vim-common
> 
> $ apt-get install vim
> ...
> vim is already the newest version.
> You might want to run 'apt-get -f install' to correct these:
> The following packages have unmet dependencies:
>  vim : Depends: vim-common (= 2:7.3.547-7+deb7u3) but it is not going to be 
> installed
> ```
> 
> New unit tests for `Package` in `ambari-agent`:
> 
> ```
> Ran 456 tests in 38.256s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60698: AMBARI-21424. BigInsight stack upgrade XML files should prevent downgrade

2017-07-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60698/#review179886
---


Ship it!




Ship It!

- Jonathan Hurley


On July 6, 2017, 10:20 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60698/
> ---
> 
> (Updated July 6, 2017, 10:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21424
> https://issues.apache.org/jira/browse/AMBARI-21424
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added `downgrade-allowed` tag.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af877944aa2c9ffe5b110d949a14a7c0e824f0aa 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af877944aa2c9ffe5b110d949a14a7c0e824f0aa 
> 
> 
> Diff: https://reviews.apache.org/r/60698/diff/1/
> 
> 
> Testing
> ---
> 
> Manual test on local cluster.
> 
> Upgrade pack-related unit tests pass:
> 
> ```
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.456 sec - 
> in org.apache.ambari.server.state.stack.ConfigUpgradePackTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.759 sec - 
> in org.apache.ambari.server.state.stack.ConfigUpgradeValidityTest
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.386 sec - 
> in org.apache.ambari.server.state.stack.UpgradePackTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.437 sec - 
> in org.apache.ambari.server.state.stack.UpgradePackParsingTest
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/#review179885
---



It has been brought up that this change to blueprints may be too difficult to 
adapt to. I'm investigating adding logic to the BP processor to adjust the 
stack tools/features if they are specified in the old format. However, that 
will be a separate Jira from this.

- Jonathan Hurley


On July 7, 2017, 12:52 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60709/
> ---
> 
> (Updated July 7, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush 
> Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21430
> https://issues.apache.org/jira/browse/AMBARI-21430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, the stack tools:
> 
> - {{cluster-env/stack_features}}
> - {{cluster-env/stack_tools}}
> - {{cluster-env/stack_root}}
> 
> Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
> sets of stack tools from co-existing. Although Ambari doesn't support more 
> than a single stack in 2.x, we do support upgrades from one stack vendor to 
> another. Therefore, we need this support to send the right tools on the 
> commands.
> 
> This will involve the following work:
> - Changing the existing stack tools/features/root to have a stack name as the 
> key in the JSON
> - Altering the existing {{cluster-env}} tools on upgrade
> - Ensuring that the stack tools/features for a repository's stack exist when 
> distributing that stack
> - Changing any Python code which references the stack tools (stack_tools.py, 
> alerts, etc)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2b3df5f2da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 04928de595 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  64e0b14cfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13114dd772 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  0ab8180027 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  32df7d3819 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  98d1899776 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  0e9fe741d0 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 
> 4c5834f83b 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> f8755c911f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
>  93c79481f0 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  4627e731c5 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
>  fdbbdf96bc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  a79e904cdf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  878645b62a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
> d1aab4bba8 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml
>  7df00eea8e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json
>  e9e0ed219c 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
> 535b9d9e0d 
> 
> 
> Diff: https://reviews.apache.org/r/60709/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 60655: AMBARI-21405. Create custom action to force-remove packages

2017-07-07 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60655/#review179883
---


Ship it!




Ship It!

- Sid Wagle


On July 6, 2017, 6:32 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60655/
> ---
> 
> (Updated July 6, 2017, 6:32 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21405
> https://issues.apache.org/jira/browse/AMBARI-21405
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Add option in `Package` resource to remove package while leaving its 
> dependencies installed
> * Add custom action `force_remove_packages`
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 
> 66227c66a7768aa044f30a1c76d782c5101be678 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
>  21de1839c853794f252a4cb2265b89549a802d88 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/apt.py
>  d095173f07c46842b6e9e38dc933e06a3e43a749 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/choco.py
>  db552964279f509de90d2fde884bfc0fea12f7b0 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
>  ea10a8601430b62bbe216848e1d26a5e8bc16927 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
>  265c1626873bfb98196f102e73bb2dbedee94c80 
>   
> ambari-common/src/main/python/resource_management/core/resources/packaging.py 
> e3adc30f46abd3f33670f817421d88270b3e7ade 
>   
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
>  0f502568ddfb5da7d5574b2e33c6a354c37d9697 
>   
> ambari-server/src/main/resources/custom_actions/scripts/force_remove_packages.py
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60655/diff/2/
> 
> 
> Testing
> ---
> 
> Tested custom action as part of cross-stack upgrade on CentOS7.
> 
> Manually tested custom action on Debian 7.6:
> 
> ```
> $ curl -X POST -d '{ "RequestInfo": { "action": "force_remove_packages", 
> "parameters": { "package_list": "vim-common" } } }' 
> http://localhost:8080/api/v1/clusters/TEST/requests
> 
> output.txt:
> 2017-07-05 12:29:59,400 - Package['vim-common'] {'action': ['remove'], 
> 'remove_with_dependencies': False}
> 2017-07-05 12:29:59,411 - Removing package vim-common ('/usr/bin/dpkg 
> --remove --ignore-depends vim-common vim-common')
> 2017-07-05 12:30:00,702 - Removed vim-common
> 
> $ apt-get install vim
> ...
> vim is already the newest version.
> You might want to run 'apt-get -f install' to correct these:
> The following packages have unmet dependencies:
>  vim : Depends: vim-common (= 2:7.3.547-7+deb7u3) but it is not going to be 
> installed
> ```
> 
> New unit tests for `Package` in `ambari-agent`:
> 
> ```
> Ran 456 tests in 38.256s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60695: Add REST end point for the documentation of the Log Feeder shipper properties

2017-07-07 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60695/#review179882
---


Ship it!




Ship It!

- Robert Nettleton


On July 7, 2017, 12:30 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60695/
> ---
> 
> (Updated July 7, 2017, 12:30 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21423
> https://issues.apache.org/jira/browse/AMBARI-21423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a REST API end point similar to the property description endpoint which 
> provides info about the fields of the shipper configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/ShipperConfigElementDescription.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/ShipperConfigTypeDescription.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/ConditionsImpl.java
>  8bbff8f 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FieldsImpl.java
>  68cd0e2 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterDescriptorImpl.java
>  4e11715 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterGrokDescriptorImpl.java
>  995f76b 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterKeyValueDescriptorImpl.java
>  8e89990 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputConfigImpl.java
>  a4eba8e 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputDescriptorImpl.java
>  54b4b9b 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputFileBaseDescriptorImpl.java
>  51c7ec8 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputS3FileDescriptorImpl.java
>  277a57c 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapAnonymizeDescriptorImpl.java
>  5fdbbab 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapDateDescriptorImpl.java
>  2e54e7a 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldCopyDescriptorImpl.java
>  4a8d746 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldDescriptorImpl.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldNameDescriptorImpl.java
>  bd32018 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldValueDescriptorImpl.java
>  599e152 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/PostMapValuesAdapter.java
>  3c21fd8 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/filter.md 129279b 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/input.md 661eeb8 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/postMapValues.md 7ec439a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterJSONTest.java
>  7abf177 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ShipperConfigDescriptionStorage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  6d1382d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java
>  f6d0449 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apac

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/#review179877
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
Lines 338-346 (original), 345-353 (patched)


Why are we dancing around this - the request MUST HAVE THE RIGHT PIECES WE 
NEED!



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
Line 351 (original), 361-368 (patched)


So, when distributing the HDP stack, we ensure that the HDP stack tools 
exist. If you installed your cluster with BigInsights, then you'd only have the 
BI stack tools right now.


- Jonathan Hurley


On July 7, 2017, 11:46 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60709/
> ---
> 
> (Updated July 7, 2017, 11:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-21430
> https://issues.apache.org/jira/browse/AMBARI-21430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, the stack tools:
> 
> - {{cluster-env/stack_features}}
> - {{cluster-env/stack_tools}}
> - {{cluster-env/stack_root}}
> 
> Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
> sets of stack tools from co-existing. Although Ambari doesn't support more 
> than a single stack in 2.x, we do support upgrades from one stack vendor to 
> another. Therefore, we need this support to send the right tools on the 
> commands.
> 
> This will involve the following work:
> - Changing the existing stack tools/features/root to have a stack name as the 
> key in the JSON
> - Altering the existing {{cluster-env}} tools on upgrade
> - Ensuring that the stack tools/features for a repository's stack exist when 
> distributing that stack
> - Changing any Python code which references the stack tools (stack_tools.py, 
> alerts, etc)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2b3df5f2da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 04928de595 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  64e0b14cfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13114dd772 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  0ab8180027 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  32df7d3819 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  98d1899776 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  0e9fe741d0 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 
> 4c5834f83b 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> f8755c911f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
>  93c79481f0 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  4627e731c5 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
>  fdbbdf96bc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  a79e904cdf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  878645b62a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
> d1aab4bba8 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml
>  7df00eea8e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json
>  e9e0ed219c 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
> 535b9d9e0d 
> 
> 
> Diff: https://reviews.apache.org/r/60709/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.


Bugs: AMBARI-21430
https://issues.apache.org/jira/browse/AMBARI-21430


Repository: ambari


Description
---

Currently, the stack tools:

- {{cluster-env/stack_features}}
- {{cluster-env/stack_tools}}
- {{cluster-env/stack_root}}

Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 
sets of stack tools from co-existing. Although Ambari doesn't support more than 
a single stack in 2.x, we do support upgrades from one stack vendor to another. 
Therefore, we need this support to send the right tools on the commands.

This will involve the following work:
- Changing the existing stack tools/features/root to have a stack name as the 
key in the JSON
- Altering the existing {{cluster-env}} tools on upgrade
- Ensuring that the stack tools/features for a repository's stack exist when 
distributing that stack
- Changing any Python code which references the stack tools (stack_tools.py, 
alerts, etc)


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 2b3df5f2da 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
 02ae62daf3 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
04928de595 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 64e0b14cfe 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
13114dd772 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
 0ab8180027 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
 32df7d3819 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
 98d1899776 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
 0e9fe741d0 
  ambari-server/src/main/resources/host_scripts/alert_disk_space.py 4c5834f83b 
  ambari-server/src/main/resources/host_scripts/alert_version_select.py 
f8755c911f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
 93c79481f0 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
 4627e731c5 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
 fdbbdf96bc 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
a79e904cdf 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 878645b62a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json 
d1aab4bba8 
  
ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml 
7df00eea8e 
  
ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json 
e9e0ed219c 
  ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
535b9d9e0d 


Diff: https://reviews.apache.org/r/60709/diff/1/


Testing
---

PENDING


Thanks,

Jonathan Hurley

Re: Review Request 60708: Log Search UI: implement dynamic loading of options for filters

2017-07-07 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60708/#review179873
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Июль 7, 2017, 2:54 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60708/
> ---
> 
> (Updated Июль 7, 2017, 2:54 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-21429
> https://issues.apache.org/jira/browse/AMBARI-21429
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Options for logs list filters should be loaded dynamically based on real 
> application data.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 65139db 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.spec.ts
>  b1b691c 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.spec.ts
>  8828390 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts
>  8291572 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts
>  652b864 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts
>  ea3d780 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts
>  5cfe4cc 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts 
> d5f8881 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.spec.ts
>  a8dc017 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts
>  ce451d3 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/http-client.service.ts
>  4ab85e5 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-settings.service.ts
>  faed254 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-state.service.ts
>  49dfa77 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/audit-logs.service.ts
>  a50c68d 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/bar-graphs.service.ts
>  b3b955a 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/clusters.service.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/components.service.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/filters.service.ts
>  a06852c 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/graphs.service.ts
>  0abd910 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/nodes.service.ts
>  4e47609 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/reducers.service.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/service-logs.service.ts
>  ab77138 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/user-configs.service.ts
>  36cfd5f 
>   ambari-logsearch/ambari-logsearch-web-new/src/assets/mock-data.ts 732e8d3 
> 
> 
> Diff: https://reviews.apache.org/r/60708/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 46 of 46 SUCCESS (1.22 secs / 1.185 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 60708: Log Search UI: implement dynamic loading of options for filters

2017-07-07 Thread Andrii Babiichuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60708/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-21429
https://issues.apache.org/jira/browse/AMBARI-21429


Repository: ambari


Description
---

Options for logs list filters should be loaded dynamically based on real 
application data.


Diffs
-

  ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 65139db 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.spec.ts
 b1b691c 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.spec.ts
 8828390 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts
 8291572 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts
 652b864 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts
 ea3d780 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts
 5cfe4cc 
  ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts 
d5f8881 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.spec.ts
 a8dc017 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts 
ce451d3 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/http-client.service.ts
 4ab85e5 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-settings.service.ts
 faed254 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-state.service.ts
 49dfa77 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/audit-logs.service.ts
 a50c68d 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/bar-graphs.service.ts
 b3b955a 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/clusters.service.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/components.service.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/filters.service.ts
 a06852c 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/graphs.service.ts
 0abd910 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/nodes.service.ts
 4e47609 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/reducers.service.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/service-logs.service.ts
 ab77138 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/user-configs.service.ts
 36cfd5f 
  ambari-logsearch/ambari-logsearch-web-new/src/assets/mock-data.ts 732e8d3 


Diff: https://reviews.apache.org/r/60708/diff/1/


Testing
---

Executed 46 of 46 SUCCESS (1.22 secs / 1.185 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 60683: Fix execution/custom_commands/custom_actions/service_checks. Send clusterHostInfo

2017-07-07 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60683/
---

(Updated July 7, 2017, 1:54 p.m.)


Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-21415
https://issues.apache.org/jira/browse/AMBARI-21415


Repository: ambari


Description
---

.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py f2fc253 
  ambari-agent/src/main/python/ambari_agent/ClusterCache.py a3b84ad 
  ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py f138c57 
  ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py ff526e3 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
6389878 
  ambari-agent/src/main/python/ambari_agent/FileCache.py 3bff613 
  ambari-agent/src/main/python/ambari_agent/HostInfo.py b6db1f2 
  ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 19f163e 
  ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 
19a1d32 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 26c40b3 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_after_registration.json
 c1aba28 


Diff: https://reviews.apache.org/r/60683/diff/3/

Changes: https://reviews.apache.org/r/60683/diff/2-3/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-07 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/
---

(Updated July 7, 2017, 9:30 a.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20861
https://issues.apache.org/jira/browse/AMBARI-20861


Repository: ambari


Description
---

Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
on the authentication sources related to an Ambari user account.

Add the following entry points:

- `/api/v1/users/:USER_ID`
-- Get a user
-- Modify a user

- `/api/v1/users/:USERNAME/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

- `/api/v1/users/:USER_ID/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USER_ID/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

Update the following entry points, ensuring backwards compatibility where 
possible:

- `/api/v1/users`
-- List all users
-- Add a new user
-- Backward compatibility: Set password should create or update the appropriate 
user_authentication record.


Diffs (updated)
-

  ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
  ambari-server/docs/api/v1/index.md da05d75bc3 
  ambari-server/docs/api/v1/user-create.md PRE-CREATION 
  ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/user-get.md PRE-CREATION 
  ambari-server/docs/api/v1/user-list.md PRE-CREATION 
  ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/user-update.md PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 96e288fee0 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
 b228c82aa9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 25d12c7dd6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 2454bf7694 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
 bcb3aaf3e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 595b7f996f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
 45b733b042 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 362b4e631c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 5ecff52ab2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 ffb8e6dd16 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 de12a1669f 
  ambari-server/src/main/resources/properties.json 11ca7f678a 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/UserResourceDefinitionTest.java
 024b118a9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
 3becc02aa8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java
 db7548f077 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 4530d40ce4 
  
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
 43d56cd473 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authoriza

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-07 Thread Di Li



> On July 6, 2017, 9:44 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
> > Lines 446 (patched)
> > 
> >
> > I believe default() will already convert the string "true" or "false" 
> > into the boolean True or False.
> > 
> > If not, then the 3rd line here has a bug since it should compare it to 
> > "true"

This is to make sure the script checks value true/false (case insentive). 
Otherwise the check becomes falsy vs truthy as people can set  value to 
something like "yes/no", or even just a non-empty string.

Yes, the logic has a bug, I missed the quotes.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/#review179830
---


On July 6, 2017, 9:08 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60691/
> ---
> 
> (Updated July 6, 2017, 9:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21420
> https://issues.apache.org/jira/browse/AMBARI-21420
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. 
> HBase master appeared as if it had started according to the Ambari action log 
> but later crashed with error:
> 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] 
> master.HMaster: Failed to become active masterjava.io.IOException: The 
> procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure 
> must be accessible and have an empty constructorat 
> org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at
>  org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
>  
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
>  org.apach
 e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
> Attach one or more files to this issue
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a1003dc 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  43c6036 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  419e5dd 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  c4737c9 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  419e5dd 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  c4737c9 
> 
> 
> Diff: https://reviews.apache.org/r/60691/diff/1/
> 
> 
> Testing
> ---
> 
> will be tested in the integration tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-07 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/
---

(Updated July 7, 2017, 1:15 p.m.)


Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21420
https://issues.apache.org/jira/browse/AMBARI-21420


Repository: ambari


Description
---

HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. HBase 
master appeared as if it had started according to the Ambari action log but 
later crashed with error:
2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] master.HMaster: 
Failed to become active masterjava.io.IOException: The procedure class 
org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure must be 
accessible and have an empty constructorat 
org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at 
org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
 
org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
 
org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
 
org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
 org.apache.
 hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
Attach one or more files to this issue
Attachments


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
 a1003dc 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 43c6036 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
 6597055 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
 af87794 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
 6597055 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
 af87794 


Diff: https://reviews.apache.org/r/60691/diff/2/

Changes: https://reviews.apache.org/r/60691/diff/1-2/


Testing
---

will be tested in the integration tests.


Thanks,

Di Li

Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-07 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20861
https://issues.apache.org/jira/browse/AMBARI-20861


Repository: ambari


Description
---

Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
on the authentication sources related to an Ambari user account.

Add the following entry points:

- `/api/v1/users/:USER_ID`
-- Get a user
-- Modify a user

- `/api/v1/users/:USERNAME/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

- `/api/v1/users/:USER_ID/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USER_ID/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

Update the following entry points, ensuring backwards compatibility where 
possible:

- `/api/v1/users`
-- List all users
-- Add a new user
-- Backward compatibility: Set password should create or update the appropriate 
user_authentication record.


Diffs
-

  ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
  ambari-server/docs/api/v1/index.md da05d75bc3 
  ambari-server/docs/api/v1/user-create.md PRE-CREATION 
  ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/user-get.md PRE-CREATION 
  ambari-server/docs/api/v1/user-list.md PRE-CREATION 
  ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/user-update.md PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 96e288fee0 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
 b228c82aa9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 25d12c7dd6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 2454bf7694 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
 bcb3aaf3e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 595b7f996f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
 45b733b042 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 362b4e631c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 5ecff52ab2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 ffb8e6dd16 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 de12a1669f 
  ambari-server/src/main/resources/properties.json 11ca7f678a 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/UserResourceDefinitionTest.java
 024b118a9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
 3becc02aa8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java
 db7548f077 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 4530d40ce4 
  
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
 43d56cd473 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 e049b4e83b 


Diff: https

Re: Review Request 60689: Upgrade Infra Solr version from 5.5.2 to 6.6.x

2017-07-07 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60689/#review179860
---


Ship it!




Ship It!

- Miklos Gergely


On July 6, 2017, 6:41 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60689/
> ---
> 
> (Updated July 6, 2017, 6:41 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21400
> https://issues.apache.org/jira/browse/AMBARI-21400
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - upgrade solr version to 6.6.0
> - update custom solr start script (add 6.6.0 custom changes)
> - add new solr client command (--remove-admin-handlers) -> its required for 
> solr 6, using AdminHandlers class was deprecated in Solr 5, in Solr 6, it 
> does not exists, so throws runtime expection in solr node. This command will 
> run before solr starts.
> - handle ambari upgrade scenario
> 
> (note: this change does not contain index migration changes, there will be a 
> command for that as well, but that should be some manual step)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  1c5432b 
>   ambari-infra/ambari-infra-assembly/src/main/resources/solr bf504d9 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java
>  e3a1e79 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java
>  9479679 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/RemoveAdminHandlersCommand.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/SetClusterPropertyZkCommand.java
>  34597c6 
>   
> ambari-infra/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java
>  ee84969 
>   ambari-infra/pom.xml 4f5c29c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/audit_logs/conf/solrconfig.xml
>  7af91df 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/hadoop_logs/conf/solrconfig.xml
>  59f778f 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/history/conf/solrconfig.xml
>  8244a08 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
>  d99694b 
>   ambari-logsearch/docker/Dockerfile 2b8fd5d 
>   ambari-logsearch/docker/bin/start.sh 28ebf65 
>   ambari-logsearch/pom.xml 82943e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  5fdc885 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  5f547f3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  f3dbcf3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2
>  63879e7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2
>  b6a4d1d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  a342baa 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> 87304cd 
> 
> 
> Diff: https://reviews.apache.org/r/60689/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests done. + manual testing, there are some more use cases ...
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60695: Add REST end point for the documentation of the Log Feeder shipper properties

2017-07-07 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60695/#review179859
---


Ship it!




Ship It!

- Oliver Szabo


On July 7, 2017, 12:30 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60695/
> ---
> 
> (Updated July 7, 2017, 12:30 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21423
> https://issues.apache.org/jira/browse/AMBARI-21423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a REST API end point similar to the property description endpoint which 
> provides info about the fields of the shipper configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/ShipperConfigElementDescription.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/ShipperConfigTypeDescription.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/ConditionsImpl.java
>  8bbff8f 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FieldsImpl.java
>  68cd0e2 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterDescriptorImpl.java
>  4e11715 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterGrokDescriptorImpl.java
>  995f76b 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterKeyValueDescriptorImpl.java
>  8e89990 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputConfigImpl.java
>  a4eba8e 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputDescriptorImpl.java
>  54b4b9b 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputFileBaseDescriptorImpl.java
>  51c7ec8 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputS3FileDescriptorImpl.java
>  277a57c 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapAnonymizeDescriptorImpl.java
>  5fdbbab 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapDateDescriptorImpl.java
>  2e54e7a 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldCopyDescriptorImpl.java
>  4a8d746 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldDescriptorImpl.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldNameDescriptorImpl.java
>  bd32018 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldValueDescriptorImpl.java
>  599e152 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/PostMapValuesAdapter.java
>  3c21fd8 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/filter.md 129279b 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/input.md 661eeb8 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/postMapValues.md 7ec439a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterJSONTest.java
>  7abf177 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ShipperConfigDescriptionStorage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  6d1382d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java
>  f6d0449 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/a

Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-07 Thread venkat sairam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review179855
---



Where is the value exported used in the application?

- venkat sairam


On July 7, 2017, 6:52 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-07 Thread Prabhjyot Singh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
venkat sairam.


Bugs: AMBARI-21426
https://issues.apache.org/jira/browse/AMBARI-21426


Repository: ambari


Description
---

With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed to 
KERBEROS_REFRESH_INTERVAL.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
 4032b2c45d 


Diff: https://reviews.apache.org/r/60702/diff/1/


Testing
---

Manually on centOS 6.6


Thanks,

Prabhjyot Singh

43 matches

Mail list logo