Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-24 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61083/#review181318
---


Ship it!




Ship It!

- Mugdha Varadkar


On July 24, 2017, 2:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61083/
> ---
> 
> (Updated July 24, 2017, 2:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21563
> https://issues.apache.org/jira/browse/AMBARI-21563
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas use user groups synced in hadoopUGI for authentication and 
> authorization process for LDAP/Kerberos type.
> As core-site.xml was available in HBase conf which is in Atlas classpath and 
> so core.site.xml configs were available. But now as core-site.xml is not 
> available in Hbase conf, to fix this issue hadoop core-site.xml need to be 
> copied to Atlas conf directory by Ambari.
> 
> PS: Attached patch is applicable for trunk branch, patch for branch-2.5 is 
> attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  d424f5b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3ed469a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  31cf0c8 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> 6e1a52e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> d1d8b7f 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 539bef5 
> 
> 
> Diff: https://reviews.apache.org/r/61083/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on CentOS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-24 Thread Chandana Mirashi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/
---

(Updated July 25, 2017, 12:53 a.m.)


Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.


Changes
---

Updated Patch with requested changes.


Bugs: AMBARI-21325
https://issues.apache.org/jira/browse/AMBARI-21325


Repository: ambari


Description
---

Add quicklink support through Knox.
Changes:
1. Add new json properties knox_url, knox_path, supports_knox
   a. knox_url: template to be used for urls that are proxied through Knox 
   b. knox_path: Knox gateway path that will be added to the proxy url.
   c. supports_knox: whether link will be redirected through Knox
2. Add above json properties to quicklinks.json
3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
SPARKUI services to Knox topology template.
4. Automate protocol and port added to Knox topology file. Based on whether SSL 
is enabled for the services listed above, the port and protocol in 
params_linux.py will be updated.
5. Update quick_view_link_view.js so that when Knox is installed and 
support_knox is true, quicklink url follows knox url template specified in the 
quicklinks.json for the service/component.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
1d2e712 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 4558069 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
 5568122 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
 a4216e3 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
 81e7cbe 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
 36f71b5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
 0aca8e3 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
 df4c1b4 
  ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
  ambari-web/app/views/common/quick_view_link_view.js e39f230 


Diff: https://reviews.apache.org/r/61043/diff/2/

Changes: https://reviews.apache.org/r/61043/diff/1-2/


Testing
---

1. ambari-server: mvn test
2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
3. ambari-web: mvn test
 21213 passing (54s)
 128 pending


Thanks,

Chandana Mirashi

Re: Review Request 61050: AMBARI-21555 Hive restart fails to restart MySQL after Ambari upgrade against IOP 4.2.5

2017-07-24 Thread Di Li 


> On July 24, 2017, 9:06 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
> > Lines 310 (patched)
> > 
> >
> > MySQL shouldn't be restarted prior to the EU.
> > I would prefer to have this be in the EU config packs.

Hello Alejandro, as Tim had explained to Sumit

"""
Hi Sumit, Currently the flag is added during EU (AMBARI-21351) to handle both 
IOP 4.2 and 4.2.5. We also need this flag to be added during Ambari upgrade for 
IOP 4.2.5 to restart MySQL prior to the EU (IOP 4.2 is self-contained, thus not 
need this flag for restarting MySQL)
"""

The restart of Hive prior to EU is necessary because the service gets marked as 
needing an restart post Ambari upgrade against IOP 4.2.5. If you skip 
restarting it, upgrade precheck will throw a service check hasn't run error.

Upgrade pack already has the change to deal with both IOP 4.2.0 and IOp 4.2.5. 
This change here is specially for IOP 4.2.5. This flag will exist on a migrated 
cluster for as long as HDP yet to support MariaDB (where HDP uses mysql.d 
deamon instead)


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61050/#review181265
---


On July 21, 2017, 8:18 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61050/
> ---
> 
> (Updated July 21, 2017, 8:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sid Wagle, 
> and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21555
> https://issues.apache.org/jira/browse/AMBARI-21555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> IOP uses MariaDB instead of MySQL when a cluster is on RedHat 7. HDP 
> 2.6/Ambari 2.5.2 is yet to support MariaDB. A special flag is introduced to 
> switch daemon type for migrated clusters. Currently the flag is added during 
> EU (AMBARI-21351) to handle both IOP 4.2 and 4.2.5. We also need this flag to 
> be added during Ambari upgrade for IOP 4.2.5 to restart MySQL ( IOP 4.2 is 
> self-contained, thus not need this flag for restarting MySQL)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  ea1b034 
> 
> 
> Diff: https://reviews.apache.org/r/61050/diff/1/
> 
> 
> Testing
> ---
> 
> patch cluster with ambari-server jar, run ambari-server upgrade, verify 
> mariadb_redhat_support=true got added to hive-env post ambari upgrade.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 61050: AMBARI-21555 Hive restart fails to restart MySQL after Ambari upgrade against IOP 4.2.5

2017-07-24 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61050/#review181265
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
Lines 310 (patched)


MySQL shouldn't be restarted prior to the EU.
I would prefer to have this be in the EU config packs.


- Alejandro Fernandez


On July 21, 2017, 8:18 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61050/
> ---
> 
> (Updated July 21, 2017, 8:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sid Wagle, 
> and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21555
> https://issues.apache.org/jira/browse/AMBARI-21555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> IOP uses MariaDB instead of MySQL when a cluster is on RedHat 7. HDP 
> 2.6/Ambari 2.5.2 is yet to support MariaDB. A special flag is introduced to 
> switch daemon type for migrated clusters. Currently the flag is added during 
> EU (AMBARI-21351) to handle both IOP 4.2 and 4.2.5. We also need this flag to 
> be added during Ambari upgrade for IOP 4.2.5 to restart MySQL ( IOP 4.2 is 
> self-contained, thus not need this flag for restarting MySQL)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
>  ea1b034 
> 
> 
> Diff: https://reviews.apache.org/r/61050/diff/1/
> 
> 
> Testing
> ---
> 
> patch cluster with ambari-server jar, run ambari-server upgrade, verify 
> mariadb_redhat_support=true got added to hive-env post ambari upgrade.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 61036: Ambari upgrade should update unique constraints

2017-07-24 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61036/#review181242
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 21, 2017, 3:12 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61036/
> ---
> 
> (Updated July 21, 2017, 3:12 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21549
> https://issues.apache.org/jira/browse/AMBARI-21549
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When upgrading Ambari from 2.2.2 to 2.5 it was discovered that if a unique 
> constraint is modified between Ambari versions, then we do not update the 
> unique constraint.
> 
> For example:
> *Ambari 2.2.2*
> https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql#L661
> {code}
> ALTER TABLE users ADD CONSTRAINT UNQ_users_0 UNIQUE (user_name, ldap_user);
> {code}
> 
> *Ambari-2.4.0*
> https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
> {code}
> CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type))
> {code}
> 
> Whenever after upgrading from Ambari 2.2.2 to Ambari 2.5.0, the unique 
> constraint is not updated.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> 03136984ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 38d60e9a4a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  6cda590d37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  cd7ae459f7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
>  947ba2e30c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  2590d1c995 
> 
> 
> Diff: https://reviews.apache.org/r/61036/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 61079: AMBARI-21559. Alert definition paths should be updated on upgrade

2017-07-24 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61079/#review181241
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 24, 2017, 12:01 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61079/
> ---
> 
> (Updated July 24, 2017, 12:01 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21559
> https://issues.apache.org/jira/browse/AMBARI-21559
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update script paths during Ambari upgrade.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  2d13cbaa764dfdf8338f0fcd2aaf48083515f825 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  e8c986b9a51ad557f1f600ff77ad89fc38f5707c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
>  acbb881264ae2c89a371063f57214e42c7ca7001 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractFinalUpgradeCatalog.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java
>  1ac011862bff70742e99d627068225617d73d66d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  af2a7d1cce7cfbc590415fff431be2d6d7308078 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpdateAlertScriptPaths.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  bc1c19af6d637af5d2284f65fe05fa7f53bc4f90 
> 
> 
> Diff: https://reviews.apache.org/r/61079/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.  No alerts are skipped due to non-existent 
> scripts.
> 
> ```
> 24 Jul 2017 11:17:54,753  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named namenode_ha_health from 
> 'HDFS/2.7.2.4.2/package/alerts/alert_ha_namenode_health.py' to 
> 'BigInsights/4.2/services/HDFS/package/alerts/alert_ha_namenode_health.py'
> 24 Jul 2017 11:17:54,753  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named upgrade_finalized_state from 
> 'HDFS/2.7.2.4.2/package/alerts/alert_upgrade_finalized.py' to 
> 'BigInsights/4.2/services/HDFS/package/alerts/alert_upgrade_finalized.py'
> 24 Jul 2017 11:17:54,753  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named datanode_unmounted_data_dir from 
> 'HDFS/2.7.2.4.2/package/alerts/alert_datanode_unmounted_data_dir.py' to 
> 'BigInsights/4.2/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py'
> 24 Jul 2017 11:17:54,754  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named namenode_last_checkpoint from 
> 'HDFS/2.7.2.4.2/package/alerts/alert_checkpoint_time.py' to 
> 'BigInsights/4.2/services/HDFS/package/alerts/alert_checkpoint_time.py'
> 24 Jul 2017 11:17:54,754  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named flume_agent_status from 
> 'FLUME/1.6.0.4.2/package/alerts/alert_flume_agent_status.py' to 
> 'BigInsights/4.2/services/FLUME/package/alerts/alert_flume_agent_status.py'
> 24 Jul 2017 11:17:54,754  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named ams_metrics_monitor_process from 
> 'AMBARI_METRICS/0.1.0.4.1/package/alerts/alert_ambari_metrics_monitor.py' to 
> 'BigInsights/4.2/services/AMBARI_METRICS/package/alerts/alert_ambari_metrics_monitor.py'
> ```
> 
> Existing unit tests:
> 
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests run: 5003, Failures: 0, Errors: 0, Skipped: 39
> ...
> Total run:1162
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-24 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61083/#review181238
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 24, 2017, 2:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61083/
> ---
> 
> (Updated July 24, 2017, 2:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21563
> https://issues.apache.org/jira/browse/AMBARI-21563
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas use user groups synced in hadoopUGI for authentication and 
> authorization process for LDAP/Kerberos type.
> As core-site.xml was available in HBase conf which is in Atlas classpath and 
> so core.site.xml configs were available. But now as core-site.xml is not 
> available in Hbase conf, to fix this issue hadoop core-site.xml need to be 
> copied to Atlas conf directory by Ambari.
> 
> PS: Attached patch is applicable for trunk branch, patch for branch-2.5 is 
> attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  d424f5b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3ed469a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  31cf0c8 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> 6e1a52e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> d1d8b7f 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 539bef5 
> 
> 
> Diff: https://reviews.apache.org/r/61083/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on CentOS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-24 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/#review181237
---




ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
Lines 190 (patched)


Nitpick, style seems a bit off. put a space after the "if" and use braces 
even for a single line in the if- block.



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
Lines 170 (patched)


use "is not None"



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
Lines 172 (patched)


Can just reverse this to avoid the "not".
hdfs_scheme = "https" if hdfs_https_on else "http"



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
Lines 220 (patched)


Use "is not None"



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
Lines 286 (patched)


Also check that the length is > 0



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
Lines 295 (patched)


Check that length is > 0



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
Lines 305 (patched)


default(..., default_value) will work even if the keys don't exist in the 
dictionary.



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
Lines 315 (patched)


Style seems off, spaces before and after "="



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
Lines 323 (patched)


use "is None"



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
Lines 327 (patched)


Same comment regarding use of default()


- Alejandro Fernandez


On July 21, 2017, 6:57 p.m., Chandana Mirashi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61043/
> ---
> 
> (Updated July 21, 2017, 6:57 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21325
> https://issues.apache.org/jira/browse/AMBARI-21325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add quicklink support through Knox.
> Changes:
> 1. Add new json properties knox_url, knox_path, supports_knox
>a. knox_url: template to be used for urls that are proxied through Knox 
>b. knox_path: Knox gateway path that will be added to the proxy url.
>c. supports_knox: whether link will be redirected through Knox
> 2. Add above json properties to quicklinks.json
> 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
> SPARKUI services to Knox topology template.
> 4. Automate protocol and port added to Knox topology file. Based on whether 
> SSL is enabled for the services listed above, the port and protocol in 
> params_linux.py will be updated.
> 5. Update quick_view_link_view.js so that when Knox is installed and 
> support_knox is true, quicklink url follows knox url template specified in 
> the quicklinks.json for the service/component.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  1d2e712 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  4558069 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
>  81e7cbe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
>  0aca8e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  df4c1b4 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
>   ambari-web/app/views/common/quick_view_link_view.js e39f230 
> 
> 
> Diff: https:/

Re: Review Request 61086: RU: Hive service check was failed during RU

2017-07-24 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61086/#review181236
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Липень 24, 2017, 5:55 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61086/
> ---
> 
> (Updated Липень 24, 2017, 5:55 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21566
> https://issues.apache.org/jira/browse/AMBARI-21566
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster: 172.22.117.104:8080 - nats11-46-vdms-erm16tofnsec-s11 - 48h  
> Job: 
> 
> Std.err
> 
> 
> 
> 
> Exception in thread Thread-4:
> Traceback (most recent call last):
>   File "/usr/lib64/python2.6/threading.py", line 532, in __bootstrap_inner
> self.run()
>   File "/usr/lib64/python2.6/threading.py", line 736, in run
> self.function(*self.args, **self.kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 383, in _on_timeout
> terminate_process(proc, terminate_strategy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/signal_utils.py", 
> line 48, in terminate_process
> kill_process_tree(proc)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/signal_utils.py", 
> line 91, in kill_process_tree
> shell.checked_call(["bash", kill_tree_script, str(proc.pid), 
> str(signal.SIGKILL)])
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> result = function(command, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> tries=tries, try_sleep=try_sleep, 
> timeout_kill_strategy=timeout_kill_strategy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> result = _call(command, **kwargs_copy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> raise ExecutionFailed(err_msg, code, out, err)
> ExecutionFailed: Execution of 'bash 
> /usr/lib/python2.6/site-packages/resource_management/core/files/killtree.sh 
> 6363 9' returned 1. kill: top: invalid signal
> Try `kill --help' for more information.
> 
> Exception in thread Thread-5:
> Traceback (most recent call last):
>   File "/usr/lib64/python2.6/threading.py", line 532, in __bootstrap_inner
> self.run()
>   File "/usr/lib64/python2.6/threading.py", line 736, in run
> self.function(*self.args, **self.kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 383, in _on_timeout
> terminate_process(proc, terminate_strategy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/signal_utils.py", 
> line 48, in terminate_process
> kill_process_tree(proc)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/signal_utils.py", 
> line 91, in kill_process_tree
> shell.checked_call(["bash", kill_tree_script, str(proc.pid), 
> str(signal.SIGKILL)])
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> result = function(command, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> tries=tries, try_sleep=try_sleep, 
> timeout_kill_strategy=timeout_kill_strategy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> result = _call(command, **kwargs_copy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> raise ExecutionFailed(err_msg, code, out, err)
> ExecutionFailed: Execution of 'bash 
> /usr/lib/python2.6/site-packages/resource_management/core/files/killtree.sh 
> 8306 9' returned 1. kill: top: invalid signal
> Try `kill --help' for more information.
> 
> Exception in thread Thread-6:
> Traceback (most recent call last):
>   File "/usr/lib64/python2.6/threading.py", line 532, in __bootstrap_inner
> self.run()
>   File "/usr/lib64/python2.6/threading.py", line 736, in run
> self.function(*self.args, **self.kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 383, in _on_timeout
> terminate_process(proc, terminate_strategy)
>

Review Request 61086: RU: Hive service check was failed during RU

2017-07-24 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61086/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-21566
https://issues.apache.org/jira/browse/AMBARI-21566


Repository: ambari


Description
---

Cluster: 172.22.117.104:8080 - nats11-46-vdms-erm16tofnsec-s11 - 48h  
Job: 

Std.err




Exception in thread Thread-4:
Traceback (most recent call last):
  File "/usr/lib64/python2.6/threading.py", line 532, in __bootstrap_inner
self.run()
  File "/usr/lib64/python2.6/threading.py", line 736, in run
self.function(*self.args, **self.kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 383, 
in _on_timeout
terminate_process(proc, terminate_strategy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/signal_utils.py", 
line 48, in terminate_process
kill_process_tree(proc)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/signal_utils.py", 
line 91, in kill_process_tree
shell.checked_call(["bash", kill_tree_script, str(proc.pid), 
str(signal.SIGKILL)])
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
result = function(command, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
tries=tries, try_sleep=try_sleep, 
timeout_kill_strategy=timeout_kill_strategy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 150, 
in _call_wrapper
result = _call(command, **kwargs_copy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 303, 
in _call
raise ExecutionFailed(err_msg, code, out, err)
ExecutionFailed: Execution of 'bash 
/usr/lib/python2.6/site-packages/resource_management/core/files/killtree.sh 
6363 9' returned 1. kill: top: invalid signal
Try `kill --help' for more information.

Exception in thread Thread-5:
Traceback (most recent call last):
  File "/usr/lib64/python2.6/threading.py", line 532, in __bootstrap_inner
self.run()
  File "/usr/lib64/python2.6/threading.py", line 736, in run
self.function(*self.args, **self.kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 383, 
in _on_timeout
terminate_process(proc, terminate_strategy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/signal_utils.py", 
line 48, in terminate_process
kill_process_tree(proc)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/signal_utils.py", 
line 91, in kill_process_tree
shell.checked_call(["bash", kill_tree_script, str(proc.pid), 
str(signal.SIGKILL)])
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
result = function(command, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
tries=tries, try_sleep=try_sleep, 
timeout_kill_strategy=timeout_kill_strategy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 150, 
in _call_wrapper
result = _call(command, **kwargs_copy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 303, 
in _call
raise ExecutionFailed(err_msg, code, out, err)
ExecutionFailed: Execution of 'bash 
/usr/lib/python2.6/site-packages/resource_management/core/files/killtree.sh 
8306 9' returned 1. kill: top: invalid signal
Try `kill --help' for more information.

Exception in thread Thread-6:
Traceback (most recent call last):
  File "/usr/lib64/python2.6/threading.py", line 532, in __bootstrap_inner
self.run()
  File "/usr/lib64/python2.6/threading.py", line 736, in run
self.function(*self.args, **self.kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 383, 
in _on_timeout
terminate_process(proc, terminate_strategy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/signal_utils.py", 
line 48, in terminate_process
kill_process_tree(proc)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/signal_utils.py", 
line 91, in kill_process_tree
shell.checked_call(["bash", kill_tree_script, str(proc.pid), 
str(signal.SIGKILL)])
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
result = function(command, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
tries=t

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-24 Thread Juanjo Marron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/#review181235
---


Ship it!




It looks good to me. It is similar to the change set included as part of IOP 
supporting QuickLinks through Knox.
Can we make sure all the tests run by HadoopQA pass, even if they are not 
related to this change?

- Juanjo  Marron


On July 21, 2017, 6:57 p.m., Chandana Mirashi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61043/
> ---
> 
> (Updated July 21, 2017, 6:57 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21325
> https://issues.apache.org/jira/browse/AMBARI-21325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add quicklink support through Knox.
> Changes:
> 1. Add new json properties knox_url, knox_path, supports_knox
>a. knox_url: template to be used for urls that are proxied through Knox 
>b. knox_path: Knox gateway path that will be added to the proxy url.
>c. supports_knox: whether link will be redirected through Knox
> 2. Add above json properties to quicklinks.json
> 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
> SPARKUI services to Knox topology template.
> 4. Automate protocol and port added to Knox topology file. Based on whether 
> SSL is enabled for the services listed above, the port and protocol in 
> params_linux.py will be updated.
> 5. Update quick_view_link_view.js so that when Knox is installed and 
> support_knox is true, quicklink url follows knox url template specified in 
> the quicklinks.json for the service/component.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  1d2e712 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  4558069 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
>  81e7cbe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
>  0aca8e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  df4c1b4 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
>   ambari-web/app/views/common/quick_view_link_view.js e39f230 
> 
> 
> Diff: https://reviews.apache.org/r/61043/diff/1/
> 
> 
> Testing
> ---
> 
> 1. ambari-server: mvn test
> 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
> 3. ambari-web: mvn test
>  21213 passing (54s)
>  128 pending
> 
> 
> Thanks,
> 
> Chandana Mirashi
> 
>

Re: Review Request 61074: Restart due to Stale configurations leads to an internal system exception

2017-07-24 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61074/#review181231
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
Lines 1086 (patched)


Shouldn't it `return`, too?  Otherwise what prevents the exception a few 
lines later?


- Attila Doroszlai


On July 24, 2017, 9:32 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61074/
> ---
> 
> (Updated July 24, 2017, 9:32 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21551
> https://issues.apache.org/jira/browse/AMBARI-21551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While performing RBAC API tests, found the following:
> POST call: 
> {code}
> http://:8080/api/v1/clusters/cl1/requests
> {"RequestInfo":{"command":"RESTART","context":"Restart all required 
> services","operation_level":"host_component"},"Requests/resource_filters":[{"hosts_predicate":"HostRoles/stale_configs=true"}]}
> {code}
> Returns:
> {code}
> {
> "status" : 500,
> message" : "An internal system exception occurred: Command execution cannot 
> proceed without a resource filter."
> }
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  0b140e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  a8f7638 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  d243e73 
> 
> 
> Diff: https://reviews.apache.org/r/61074/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 61074: Restart due to Stale configurations leads to an internal system exception

2017-07-24 Thread Dmytro Sen 


> On Июль 24, 2017, 4:55 п.п., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
> > Lines 455 (patched)
> > 
> >
> > This looks like a hack to me. Can we have the validation check for 
> > existence of the resource filter in the params? Can that be done with 
> > minimal extra code?

That's a hack, as for me it's to late for refactor for 2.5.2.
It's not enough to check if resource filter exists in the request, we also 
should check the it doesn't return emptry set of resources. If it's empty, 
we're getting the error in description.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61074/#review181227
---


On Июль 24, 2017, 7:32 д.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61074/
> ---
> 
> (Updated Июль 24, 2017, 7:32 д.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21551
> https://issues.apache.org/jira/browse/AMBARI-21551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While performing RBAC API tests, found the following:
> POST call: 
> {code}
> http://:8080/api/v1/clusters/cl1/requests
> {"RequestInfo":{"command":"RESTART","context":"Restart all required 
> services","operation_level":"host_component"},"Requests/resource_filters":[{"hosts_predicate":"HostRoles/stale_configs=true"}]}
> {code}
> Returns:
> {code}
> {
> "status" : 500,
> message" : "An internal system exception occurred: Command execution cannot 
> proceed without a resource filter."
> }
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  0b140e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  a8f7638 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  d243e73 
> 
> 
> Diff: https://reviews.apache.org/r/61074/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 61074: Restart due to Stale configurations leads to an internal system exception

2017-07-24 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61074/#review181227
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
Lines 455 (patched)


This looks like a hack to me. Can we have the validation check for 
existence of the resource filter in the params? Can that be done with minimal 
extra code?


- Sid Wagle


On July 24, 2017, 7:32 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61074/
> ---
> 
> (Updated July 24, 2017, 7:32 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21551
> https://issues.apache.org/jira/browse/AMBARI-21551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While performing RBAC API tests, found the following:
> POST call: 
> {code}
> http://:8080/api/v1/clusters/cl1/requests
> {"RequestInfo":{"command":"RESTART","context":"Restart all required 
> services","operation_level":"host_component"},"Requests/resource_filters":[{"hosts_predicate":"HostRoles/stale_configs=true"}]}
> {code}
> Returns:
> {code}
> {
> "status" : 500,
> message" : "An internal system exception occurred: Command execution cannot 
> proceed without a resource filter."
> }
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  0b140e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  a8f7638 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  d243e73 
> 
> 
> Diff: https://reviews.apache.org/r/61074/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-24 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61083/#review181221
---




ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
Lines 210 (patched)


Why do we need to delete?


- Jayush Luniya


On July 24, 2017, 2:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61083/
> ---
> 
> (Updated July 24, 2017, 2:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21563
> https://issues.apache.org/jira/browse/AMBARI-21563
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas use user groups synced in hadoopUGI for authentication and 
> authorization process for LDAP/Kerberos type.
> As core-site.xml was available in HBase conf which is in Atlas classpath and 
> so core.site.xml configs were available. But now as core-site.xml is not 
> available in Hbase conf, to fix this issue hadoop core-site.xml need to be 
> copied to Atlas conf directory by Ambari.
> 
> PS: Attached patch is applicable for trunk branch, patch for branch-2.5 is 
> attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  d424f5b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3ed469a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  31cf0c8 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> 6e1a52e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> d1d8b7f 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 539bef5 
> 
> 
> Diff: https://reviews.apache.org/r/61083/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on CentOS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-24 Thread Vishal Suvagia via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61083/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.


Bugs: AMBARI-21563
https://issues.apache.org/jira/browse/AMBARI-21563


Repository: ambari


Description
---

Atlas use user groups synced in hadoopUGI for authentication and authorization 
process for LDAP/Kerberos type.
As core-site.xml was available in HBase conf which is in Atlas classpath and so 
core.site.xml configs were available. But now as core-site.xml is not available 
in Hbase conf, to fix this issue hadoop core-site.xml need to be copied to 
Atlas conf directory by Ambari.

PS: Attached patch is applicable for trunk branch, patch for branch-2.5 is 
attached on Apache JIRA.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 c74e029 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 d424f5b 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 3ed469a 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 31cf0c8 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
6e1a52e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
d1d8b7f 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 539bef5 


Diff: https://reviews.apache.org/r/61083/diff/1/


Testing
---

Verified with installation on CentOS 6.


Thanks,

Vishal Suvagia

Re: Review Request 61079: AMBARI-21559. Alert definition paths should be updated on upgrade

2017-07-24 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61079/#review181215
---




ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
Lines 1179 (patched)


That's an interesting check ... I wouldn't have thought to ensure that both 
were of type SCRIPT - I don't think we've ever had an alert change types and 
keep the same name.

Let's keep it, of course - just pointing it out :)



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
Lines 1183 (patched)


This makes me a little nervous. I'm not going to hold up the review for it, 
though. Is there any way that we could only update the script paths and not the 
rest of the alert? What if they've customized some parameters?


- Jonathan Hurley


On July 24, 2017, 8:01 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61079/
> ---
> 
> (Updated July 24, 2017, 8:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21559
> https://issues.apache.org/jira/browse/AMBARI-21559
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update script paths during Ambari upgrade.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  2d13cbaa764dfdf8338f0fcd2aaf48083515f825 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  e8c986b9a51ad557f1f600ff77ad89fc38f5707c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
>  acbb881264ae2c89a371063f57214e42c7ca7001 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractFinalUpgradeCatalog.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java
>  1ac011862bff70742e99d627068225617d73d66d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  af2a7d1cce7cfbc590415fff431be2d6d7308078 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpdateAlertScriptPaths.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  bc1c19af6d637af5d2284f65fe05fa7f53bc4f90 
> 
> 
> Diff: https://reviews.apache.org/r/61079/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.  No alerts are skipped due to non-existent 
> scripts.
> 
> ```
> 24 Jul 2017 11:17:54,753  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named namenode_ha_health from 
> 'HDFS/2.7.2.4.2/package/alerts/alert_ha_namenode_health.py' to 
> 'BigInsights/4.2/services/HDFS/package/alerts/alert_ha_namenode_health.py'
> 24 Jul 2017 11:17:54,753  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named upgrade_finalized_state from 
> 'HDFS/2.7.2.4.2/package/alerts/alert_upgrade_finalized.py' to 
> 'BigInsights/4.2/services/HDFS/package/alerts/alert_upgrade_finalized.py'
> 24 Jul 2017 11:17:54,753  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named datanode_unmounted_data_dir from 
> 'HDFS/2.7.2.4.2/package/alerts/alert_datanode_unmounted_data_dir.py' to 
> 'BigInsights/4.2/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py'
> 24 Jul 2017 11:17:54,754  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named namenode_last_checkpoint from 
> 'HDFS/2.7.2.4.2/package/alerts/alert_checkpoint_time.py' to 
> 'BigInsights/4.2/services/HDFS/package/alerts/alert_checkpoint_time.py'
> 24 Jul 2017 11:17:54,754  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named flume_agent_status from 
> 'FLUME/1.6.0.4.2/package/alerts/alert_flume_agent_status.py' to 
> 'BigInsights/4.2/services/FLUME/package/alerts/alert_flume_agent_status.py'
> 24 Jul 2017 11:17:54,754  INFO [main] AmbariMetaInfo:1186 - Updating script 
> path for the alert named ams_metrics_monitor_process from 
> 'AMBARI_METRICS/0.1.0.4.1/package/alerts/alert_ambari_metrics_monitor.py' to 
> 'BigInsights/4.2/services/AMBARI_METRICS/package/alerts/alert_ambari_metrics_monitor.py'
> ```
> 
> Existing unit tests:
> 
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests run: 5003, Failures: 0, Errors: 0, Skipped: 39
> ...
> Total run:1162
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 61074: Restart due to Stale configurations leads to an internal system exception

2017-07-24 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61074/#review181214
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Липень 24, 2017, 7:32 до полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61074/
> ---
> 
> (Updated Липень 24, 2017, 7:32 до полудня)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21551
> https://issues.apache.org/jira/browse/AMBARI-21551
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While performing RBAC API tests, found the following:
> POST call: 
> {code}
> http://:8080/api/v1/clusters/cl1/requests
> {"RequestInfo":{"command":"RESTART","context":"Restart all required 
> services","operation_level":"host_component"},"Requests/resource_filters":[{"hosts_predicate":"HostRoles/stale_configs=true"}]}
> {code}
> Returns:
> {code}
> {
> "status" : 500,
> message" : "An internal system exception occurred: Command execution cannot 
> proceed without a resource filter."
> }
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  0b140e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  a8f7638 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  d243e73 
> 
> 
> Diff: https://reviews.apache.org/r/61074/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 60995: Namenode restart - PID file delete happens before the call to check status

2017-07-24 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60995/#review181209
---


Ship it!




Ship It!

- Nate Cole


On July 21, 2017, 11:23 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60995/
> ---
> 
> (Updated July 21, 2017, 11:23 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21532
> https://issues.apache.org/jira/browse/AMBARI-21532
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PID file delete happens before the call to check status.
> 
> {code}
> ...
> 2017-07-06 00:03:21,004 - 
> File['/var/run/hadoop/hdfs/hadoop-hdfs-namenode.pid'] {'action': ['delete']}
> 2017-07-06 00:05:21,103 - Waiting for actual component stop
> 2017-07-06 00:05:21,104 - Pid file 
> /var/run/hadoop/hdfs/hadoop-hdfs-namenode.pid is empty or does not exist
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py
>  7961f008ca 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 2b374c5cff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  d861ba93a5 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/utils.py
>  53774c661a 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/utils.py
>  7dcbca8d5b 
> 
> 
> Diff: https://reviews.apache.org/r/60995/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 61036: Ambari upgrade should update unique constraints

2017-07-24 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61036/#review181208
---


Ship it!




Ship It!

- Nate Cole


On July 21, 2017, 11:12 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61036/
> ---
> 
> (Updated July 21, 2017, 11:12 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21549
> https://issues.apache.org/jira/browse/AMBARI-21549
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When upgrading Ambari from 2.2.2 to 2.5 it was discovered that if a unique 
> constraint is modified between Ambari versions, then we do not update the 
> unique constraint.
> 
> For example:
> *Ambari 2.2.2*
> https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql#L661
> {code}
> ALTER TABLE users ADD CONSTRAINT UNQ_users_0 UNIQUE (user_name, ldap_user);
> {code}
> 
> *Ambari-2.4.0*
> https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
> {code}
> CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type))
> {code}
> 
> Whenever after upgrading from Ambari 2.2.2 to Ambari 2.5.0, the unique 
> constraint is not updated.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> 03136984ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 38d60e9a4a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  6cda590d37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  cd7ae459f7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
>  947ba2e30c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  2590d1c995 
> 
> 
> Diff: https://reviews.apache.org/r/61036/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 61080: AMBARI-21561. NameNode Last Checkpoint alert: global name PERCENT_WARNING is not defined

2017-07-24 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61080/#review181206
---


Ship it!




Ship It!

- Jonathan Hurley


On July 24, 2017, 9:01 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61080/
> ---
> 
> (Updated July 24, 2017, 9:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21561
> https://issues.apache.org/jira/browse/AMBARI-21561
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed leftover undefined variables.  `percent_warning` and 
> `percent_critical` are initialized later.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/alerts/alert_checkpoint_time.py
>  2a29d1a03eec1ae4eac388d26abc18e010ac13df 
> 
> 
> Diff: https://reviews.apache.org/r/61080/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster, _NameNode Last Checkpoint_ alert runs successfully.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 61080: AMBARI-21561. NameNode Last Checkpoint alert: global name PERCENT_WARNING is not defined

2017-07-24 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61080/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty, 
and Sid Wagle.


Bugs: AMBARI-21561
https://issues.apache.org/jira/browse/AMBARI-21561


Repository: ambari


Description
---

Removed leftover undefined variables.  `percent_warning` and `percent_critical` 
are initialized later.


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/alerts/alert_checkpoint_time.py
 2a29d1a03eec1ae4eac388d26abc18e010ac13df 


Diff: https://reviews.apache.org/r/61080/diff/1/


Testing
---

Tested on local cluster, _NameNode Last Checkpoint_ alert runs successfully.


Thanks,

Attila Doroszlai

Review Request 61079: AMBARI-21559. Alert definition paths should be updated on upgrade

2017-07-24 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61079/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty, 
and Sid Wagle.


Bugs: AMBARI-21559
https://issues.apache.org/jira/browse/AMBARI-21559


Repository: ambari


Description
---

Update script paths during Ambari upgrade.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 2d13cbaa764dfdf8338f0fcd2aaf48083515f825 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 e8c986b9a51ad557f1f600ff77ad89fc38f5707c 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
 acbb881264ae2c89a371063f57214e42c7ca7001 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractFinalUpgradeCatalog.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java
 1ac011862bff70742e99d627068225617d73d66d 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 af2a7d1cce7cfbc590415fff431be2d6d7308078 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpdateAlertScriptPaths.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 bc1c19af6d637af5d2284f65fe05fa7f53bc4f90 


Diff: https://reviews.apache.org/r/61079/diff/1/


Testing
---

Tested manually on local cluster.  No alerts are skipped due to non-existent 
scripts.

```
24 Jul 2017 11:17:54,753  INFO [main] AmbariMetaInfo:1186 - Updating script 
path for the alert named namenode_ha_health from 
'HDFS/2.7.2.4.2/package/alerts/alert_ha_namenode_health.py' to 
'BigInsights/4.2/services/HDFS/package/alerts/alert_ha_namenode_health.py'
24 Jul 2017 11:17:54,753  INFO [main] AmbariMetaInfo:1186 - Updating script 
path for the alert named upgrade_finalized_state from 
'HDFS/2.7.2.4.2/package/alerts/alert_upgrade_finalized.py' to 
'BigInsights/4.2/services/HDFS/package/alerts/alert_upgrade_finalized.py'
24 Jul 2017 11:17:54,753  INFO [main] AmbariMetaInfo:1186 - Updating script 
path for the alert named datanode_unmounted_data_dir from 
'HDFS/2.7.2.4.2/package/alerts/alert_datanode_unmounted_data_dir.py' to 
'BigInsights/4.2/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py'
24 Jul 2017 11:17:54,754  INFO [main] AmbariMetaInfo:1186 - Updating script 
path for the alert named namenode_last_checkpoint from 
'HDFS/2.7.2.4.2/package/alerts/alert_checkpoint_time.py' to 
'BigInsights/4.2/services/HDFS/package/alerts/alert_checkpoint_time.py'
24 Jul 2017 11:17:54,754  INFO [main] AmbariMetaInfo:1186 - Updating script 
path for the alert named flume_agent_status from 
'FLUME/1.6.0.4.2/package/alerts/alert_flume_agent_status.py' to 
'BigInsights/4.2/services/FLUME/package/alerts/alert_flume_agent_status.py'
24 Jul 2017 11:17:54,754  INFO [main] AmbariMetaInfo:1186 - Updating script 
path for the alert named ams_metrics_monitor_process from 
'AMBARI_METRICS/0.1.0.4.1/package/alerts/alert_ambari_metrics_monitor.py' to 
'BigInsights/4.2/services/AMBARI_METRICS/package/alerts/alert_ambari_metrics_monitor.py'
```

Existing unit tests:

```
$ mvn -am -pl ambari-server clean test
...
Tests run: 5003, Failures: 0, Errors: 0, Skipped: 39
...
Total run:1162
Total errors:0
Total failures:0
OK
...
[INFO] BUILD SUCCESS
```


Thanks,

Attila Doroszlai

Review Request 61074: Restart due to Stale configurations leads to an internal system exception

2017-07-24 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61074/
---

Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-21551
https://issues.apache.org/jira/browse/AMBARI-21551


Repository: ambari


Description
---

While performing RBAC API tests, found the following:
POST call: 
{code}
http://:8080/api/v1/clusters/cl1/requests
{"RequestInfo":{"command":"RESTART","context":"Restart all required 
services","operation_level":"host_component"},"Requests/resource_filters":[{"hosts_predicate":"HostRoles/stale_configs=true"}]}
{code}
Returns:
{code}
{
"status" : 500,
message" : "An internal system exception occurred: Command execution cannot 
proceed without a resource filter."
}
{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 0b140e4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
 a8f7638 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
 d243e73 


Diff: https://reviews.apache.org/r/61074/diff/1/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 60999: Add host doesn't fully add a node when include/exclude files are used

2017-07-24 Thread Dmytro Sen 


> On Июль 20, 2017, 6:55 п.п., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Lines 3367 (patched)
> > 
> >
> > Can you please add comments why we need to track this separately?
> 
> Dmytro Sen wrote:
> For simpler maintenance.
> 
> Sid Wagle wrote:
> I meant adding code comments.

It's in the code.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60999/#review181074
---


On Июль 21, 2017, 11 д.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60999/
> ---
> 
> (Updated Июль 21, 2017, 11 д.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21345
> https://issues.apache.org/jira/browse/AMBARI-21345
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Additional patch to solve naming issues
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  0b140e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  44943c7 
> 
> 
> Diff: https://reviews.apache.org/r/60999/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>