Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61490/#review182361
---


Fix it, then Ship it!




Ship It!


ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
Line 249 (original), 255 (patched)


could we put here some usefull information about request and kind of error 
occurs?


- Dmytro Grinenko


On Aug. 8, 2017, 3:48 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61490/
> ---
> 
> (Updated Aug. 8, 2017, 3:48 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21677
> https://issues.apache.org/jira/browse/AMBARI-21677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With {{PATCH}} and {{SERVICE}} style upgrades, many of the upgrade pre-checks 
> would flag issues related to services or hosts which may not be a part of the 
> upgrade. If the upgrade is not a full-stack upgrade, then warnings and errors 
> related to services which are not part of the upgrade should be ignored.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  4f8a39d8a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  04b73fa160 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java
>  c41ad207a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
>  226d82c049 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
>  d60433d141 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  a77d72b520 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
>  28d7d7884a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> 8feb77a8dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
>  c2ef4ad337 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheck.java
>  ea20a5535b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
>  2b1c62ede2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  8cd935bf1f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  613c5fc431 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  7c84e5c630 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/KafkaKerberosCheck.java
>  69721d9e3c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheck.java
>  06ca1629ce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
>  ec4ed09da4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerSSLConfigCheck.java
>  02f6559fe4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  0dbb1b5da1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
>  08f4fd8eed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java
>  3970e9e698 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java
>  38a6702b2e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheck.java
>  35be754bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java
>  5dadcddc20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  d838f6a20e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java
>  77605c1835 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
>  b5435f1830 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java
>  9dd4877ae6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  ba4b61e078 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
>  8f15479a24 
>   
> 

Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61490/
---

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-21677
https://issues.apache.org/jira/browse/AMBARI-21677


Repository: ambari


Description
---

With {{PATCH}} and {{SERVICE}} style upgrades, many of the upgrade pre-checks 
would flag issues related to services or hosts which may not be a part of the 
upgrade. If the upgrade is not a full-stack upgrade, then warnings and errors 
related to services which are not part of the upgrade should be ignored.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 4f8a39d8a5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
 04b73fa160 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java
 c41ad207a5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
 226d82c049 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java
 d60433d141 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
 a77d72b520 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
 28d7d7884a 
  ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
8feb77a8dd 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
 c2ef4ad337 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheck.java
 ea20a5535b 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
 2b1c62ede2 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
 8cd935bf1f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
 613c5fc431 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
 7c84e5c630 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/KafkaKerberosCheck.java
 69721d9e3c 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheck.java
 06ca1629ce 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
 ec4ed09da4 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
 a55a1481d6 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerSSLConfigCheck.java
 02f6559fe4 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
 0dbb1b5da1 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
 08f4fd8eed 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java
 3970e9e698 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java
 38a6702b2e 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheck.java
 35be754bdf 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java
 5dadcddc20 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 d838f6a20e 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java
 77605c1835 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
 b5435f1830 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java
 9dd4877ae6 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
 ba4b61e078 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
 8f15479a24 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
 a96ca6c4a3 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/KafkaKerberosCheckTest.java
 41962f9594 


Diff: https://reviews.apache.org/r/61490/diff/1/


Testing
---

PENDING


Thanks,

Jonathan Hurley

Re: Review Request 61481: HDFS namenode rpc and connection load metrics are not showing

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61481/#review182339
---


Ship it!




Ship It!

- Aravindan Vijayan


On Aug. 7, 2017, 10:47 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61481/
> ---
> 
> (Updated Aug. 7, 2017, 10:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, Dmytro 
> Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21644
> https://issues.apache.org/jira/browse/AMBARI-21644
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After upgrading from IOP 4.2 to HDP 2.6 with Ambari 2.5.2, there are two 
> metrics widget don't show the right results.
> Namenode RPC and Namenode Connection Load graph don't show any data. This 
> might be caused by different implementation to fetch metrics data for those 
> two graphs in IOP.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/alerts.json
>  90401e6 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-env.xml
>  45f9880 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-grafana-env.xml
>  eaafc6b 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-grafana-ini.xml
>  3c87ab1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-env.xml
>  00d396c 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-log4j.xml
>  4eea14f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-policy.xml
>  13726a2 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-security-site.xml
>  64799c1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-site.xml
>  bf62b8e 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-log4j.xml
>  3735e6c 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-logsearch-conf.xml
>  72d44db 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-site.xml
>  b9f534e 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-ssl-client.xml
>  cac39de 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-ssl-server.xml
>  5d2745f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/kerberos.json
>  03c3f93 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/metainfo.xml
>  5002459 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/metrics.json
>  c12e09a 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/alerts/alert_ambari_metrics_monitor.py
>  fa44a7f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/hbaseSmokeVerify.sh
>  5c320c0 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/AMBARI_METRICS.txt
>  6693503 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/FLUME.txt
>  b3bfec3 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HBASE.txt
>  0067403 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HDFS.txt
>  84576e9 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HOST.txt
>  4b759c6 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/KAFKA.txt
>  1e2017c 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/STORM.txt
>  04bca00 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/YARN.txt
>  ce04228 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/__init__.py
>  5561e10 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/ams.py
>  7b1a824 
>   
> 

Re: Review Request 61481: HDFS namenode rpc and connection load metrics are not showing

[Sid Wagle]

> On Aug. 7, 2017, 9:13 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
> > Line 334 (original), 334 (patched)
> > 
> >
> > Also change in the hooks for HDP 3.0

Attaching separate batch for trunk.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61481/#review182326
---


On Aug. 7, 2017, 10:47 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61481/
> ---
> 
> (Updated Aug. 7, 2017, 10:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, Dmytro 
> Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21644
> https://issues.apache.org/jira/browse/AMBARI-21644
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After upgrading from IOP 4.2 to HDP 2.6 with Ambari 2.5.2, there are two 
> metrics widget don't show the right results.
> Namenode RPC and Namenode Connection Load graph don't show any data. This 
> might be caused by different implementation to fetch metrics data for those 
> two graphs in IOP.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/alerts.json
>  90401e6 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-env.xml
>  45f9880 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-grafana-env.xml
>  eaafc6b 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-grafana-ini.xml
>  3c87ab1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-env.xml
>  00d396c 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-log4j.xml
>  4eea14f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-policy.xml
>  13726a2 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-security-site.xml
>  64799c1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-site.xml
>  bf62b8e 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-log4j.xml
>  3735e6c 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-logsearch-conf.xml
>  72d44db 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-site.xml
>  b9f534e 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-ssl-client.xml
>  cac39de 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-ssl-server.xml
>  5d2745f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/kerberos.json
>  03c3f93 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/metainfo.xml
>  5002459 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/metrics.json
>  c12e09a 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/alerts/alert_ambari_metrics_monitor.py
>  fa44a7f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/hbaseSmokeVerify.sh
>  5c320c0 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/AMBARI_METRICS.txt
>  6693503 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/FLUME.txt
>  b3bfec3 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HBASE.txt
>  0067403 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HDFS.txt
>  84576e9 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HOST.txt
>  4b759c6 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/KAFKA.txt
>  1e2017c 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/STORM.txt
>  04bca00 
>   
> 

Re: Review Request 61481: HDFS namenode rpc and connection load metrics are not showing

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61481/
---

(Updated Aug. 7, 2017, 10:47 p.m.)


Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, Dmytro Sen, 
and Sumit Mohanty.


Changes
---

Addressed comment for branch will do a separate change from trunk.


Bugs: AMBARI-21644
https://issues.apache.org/jira/browse/AMBARI-21644


Repository: ambari


Description
---

After upgrading from IOP 4.2 to HDP 2.6 with Ambari 2.5.2, there are two 
metrics widget don't show the right results.
Namenode RPC and Namenode Connection Load graph don't show any data. This might 
be caused by different implementation to fetch metrics data for those two 
graphs in IOP.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/alerts.json
 90401e6 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-env.xml
 45f9880 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-grafana-env.xml
 eaafc6b 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-grafana-ini.xml
 3c87ab1 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-env.xml
 00d396c 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-log4j.xml
 4eea14f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-policy.xml
 13726a2 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-security-site.xml
 64799c1 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-site.xml
 bf62b8e 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-log4j.xml
 3735e6c 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-logsearch-conf.xml
 72d44db 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-site.xml
 b9f534e 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-ssl-client.xml
 cac39de 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-ssl-server.xml
 5d2745f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/kerberos.json
 03c3f93 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/metainfo.xml
 5002459 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/metrics.json
 c12e09a 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/alerts/alert_ambari_metrics_monitor.py
 fa44a7f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/hbaseSmokeVerify.sh
 5c320c0 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/AMBARI_METRICS.txt
 6693503 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/FLUME.txt
 b3bfec3 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HBASE.txt
 0067403 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HDFS.txt
 84576e9 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HOST.txt
 4b759c6 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/KAFKA.txt
 1e2017c 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/STORM.txt
 04bca00 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/YARN.txt
 ce04228 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/__init__.py
 5561e10 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/ams.py
 7b1a824 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/ams_service.py
 0726802 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/functions.py
 140c24c 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/hbase.py
 16d741f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/hbase_master.py
 b769a0d 

Re: Review Request 61481: HDFS namenode rpc and connection load metrics are not showing

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61481/
---

(Updated Aug. 7, 2017, 10:42 p.m.)


Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, Dmytro Sen, 
and Sumit Mohanty.


Changes
---

Fixed BI 4.2 AMBARI_METRICS by poiniting it to common-services.


Bugs: AMBARI-21644
https://issues.apache.org/jira/browse/AMBARI-21644


Repository: ambari


Description
---

After upgrading from IOP 4.2 to HDP 2.6 with Ambari 2.5.2, there are two 
metrics widget don't show the right results.
Namenode RPC and Namenode Connection Load graph don't show any data. This might 
be caused by different implementation to fetch metrics data for those two 
graphs in IOP.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/alerts.json
 90401e6 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-env.xml
 45f9880 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-grafana-env.xml
 eaafc6b 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-grafana-ini.xml
 3c87ab1 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-env.xml
 00d396c 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-log4j.xml
 4eea14f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-policy.xml
 13726a2 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-security-site.xml
 64799c1 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-hbase-site.xml
 bf62b8e 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-log4j.xml
 3735e6c 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-logsearch-conf.xml
 72d44db 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-site.xml
 b9f534e 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-ssl-client.xml
 cac39de 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/configuration/ams-ssl-server.xml
 5d2745f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/kerberos.json
 03c3f93 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/metainfo.xml
 5002459 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/metrics.json
 c12e09a 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/alerts/alert_ambari_metrics_monitor.py
 fa44a7f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/hbaseSmokeVerify.sh
 5c320c0 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/AMBARI_METRICS.txt
 6693503 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/FLUME.txt
 b3bfec3 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HBASE.txt
 0067403 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HDFS.txt
 84576e9 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/HOST.txt
 4b759c6 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/KAFKA.txt
 1e2017c 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/STORM.txt
 04bca00 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/files/service-metrics/YARN.txt
 ce04228 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/__init__.py
 5561e10 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/ams.py
 7b1a824 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/ams_service.py
 0726802 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/functions.py
 140c24c 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/hbase.py
 16d741f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/AMBARI_METRICS/package/scripts/hbase_master.py
 b769a0d 
  

Re: Review Request 61481: HDFS namenode rpc and connection load metrics are not showing

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61481/#review182326
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
Line 334 (original), 334 (patched)


Also change in the hooks for HDP 3.0


- Alejandro Fernandez


On Aug. 7, 2017, 9:10 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61481/
> ---
> 
> (Updated Aug. 7, 2017, 9:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, Dmytro 
> Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21644
> https://issues.apache.org/jira/browse/AMBARI-21644
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After upgrading from IOP 4.2 to HDP 2.6 with Ambari 2.5.2, there are two 
> metrics widget don't show the right results.
> Namenode RPC and Namenode Connection Load graph don't show any data. This 
> might be caused by different implementation to fetch metrics data for those 
> two graphs in IOP.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-START/templates/hadoop-metrics2.properties.j2
>  31bf1c6 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/widgets.json
>  85082d0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  c2714e2 
> 
> 
> Diff: https://reviews.apache.org/r/61481/diff/2/
> 
> 
> Testing
> ---
> 
> Unit test pass.
> Manual verification in progress.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 61481: HDFS namenode rpc and connection load metrics are not showing

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61481/
---

(Updated Aug. 7, 2017, 9:10 p.m.)


Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, Dmytro Sen, 
and Sumit Mohanty.


Changes
---

fix for ValueError


Bugs: AMBARI-21644
https://issues.apache.org/jira/browse/AMBARI-21644


Repository: ambari


Description
---

After upgrading from IOP 4.2 to HDP 2.6 with Ambari 2.5.2, there are two 
metrics widget don't show the right results.
Namenode RPC and Namenode Connection Load graph don't show any data. This might 
be caused by different implementation to fetch metrics data for those two 
graphs in IOP.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-START/templates/hadoop-metrics2.properties.j2
 31bf1c6 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/widgets.json
 85082d0 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 c2714e2 


Diff: https://reviews.apache.org/r/61481/diff/2/

Changes: https://reviews.apache.org/r/61481/diff/1-2/


Testing
---

Unit test pass.
Manual verification in progress.


Thanks,

Sid Wagle

Review Request 61481: HDFS namenode rpc and connection load metrics are not showing

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61481/
---

Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, Dmytro Sen, 
and Sumit Mohanty.


Bugs: AMBARI-21644
https://issues.apache.org/jira/browse/AMBARI-21644


Repository: ambari


Description
---

After upgrading from IOP 4.2 to HDP 2.6 with Ambari 2.5.2, there are two 
metrics widget don't show the right results.
Namenode RPC and Namenode Connection Load graph don't show any data. This might 
be caused by different implementation to fetch metrics data for those two 
graphs in IOP.


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-START/templates/hadoop-metrics2.properties.j2
 31bf1c6 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/widgets.json
 85082d0 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 c2714e2 


Diff: https://reviews.apache.org/r/61481/diff/1/


Testing
---

Unit test pass.
Manual verification in progress.


Thanks,

Sid Wagle

Re: Review Request 61479: Add Secure Flag to Cookie / JSESSIONID in Zeppelin

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61479/#review182316
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 7, 2017, 8:07 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61479/
> ---
> 
> (Updated Aug. 7, 2017, 8:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21675
> https://issues.apache.org/jira/browse/AMBARI-21675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The secure flag attribute must be set on session cookies containing session 
> tokens for Zeppelin Application
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  971e4af1c6 
> 
> 
> Diff: https://reviews.apache.org/r/61479/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 61479: Add Secure Flag to Cookie / JSESSIONID in Zeppelin

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61479/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
venkat sairam.


Bugs: AMBARI-21675
https://issues.apache.org/jira/browse/AMBARI-21675


Repository: ambari


Description
---

The secure flag attribute must be set on session cookies containing session 
tokens for Zeppelin Application


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
 971e4af1c6 


Diff: https://reviews.apache.org/r/61479/diff/1/


Testing
---

Manually tested on CentOS6


Thanks,

Prabhjyot Singh

Re: Review Request 61462: Update Orchestration to support MAINT

[Jonathan Hurley]

> On Aug. 7, 2017, 2:17 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
> > Lines 931 (patched)
> > 
> >
> > Typo in orchestration

Do you cut/paste the code into a Google Doc and run spellcheck? :)

Thanks for the review! I'll fix the typo...


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61462/#review182301
---


On Aug. 7, 2017, 11:04 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61462/
> ---
> 
> (Updated Aug. 7, 2017, 11:04 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-21672
> https://issues.apache.org/jira/browse/AMBARI-21672
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update orchestration to support VDF types of {{MAINT}}.
> * Type {{PATCH}} and type {{MAINT}} should be treated the same for 
> orchestration.
> * If the available services loop has a {{release-version}} then use that to 
> determine if a service should be included in orchestration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  c5b8269547 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java
>  e2bb27ed5b 
> 
> 
> Diff: https://reviews.apache.org/r/61462/diff/2/
> 
> 
> Testing
> ---
> 
> Tests run: 4524, Failures: 0, Errors: 0, Skipped: 32
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:08 min
> [INFO] Finished at: 2017-08-07T12:54:08-04:00
> [INFO] Final Memory: 77M/1015M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 61461: Log Search cleanup: all configurations should be spring managed

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61461/
---

(Updated Aug. 7, 2017, 7:13 p.m.)


Review request for Ambari, Attila Magyar, Robert Nettleton, and Sebastian 
Toader.


Changes
---

remove "test" code


Bugs: AMBARI-21670
https://issues.apache.org/jira/browse/AMBARI-21670


Repository: ambari


Description
---

Some properties (like used port or protocol) for Log Search were not managed by 
Spring. Those were loaded by PropertiesHelper -> that is not the proper way to 
do it. To make the whole application managed by Spring, it affects the servlet 
definitions as well.

Also the patch contains a lot of cleanups.

Changes:
- introduce spring boot in order to get rid of managing glasshish, jakson, 
spring dependencies togather.
- use /static/ folder for static web files intead of webapps/apps (also static 
content will be handled outside of jersey filter)
- move logsearch-env/logsearch_protocol and logsearch_ui_port to 
logsearch.properties -> add a new property for SSL port.
- get rid of SSLUtil, use SSLConfigurer bean instead of it.
- get rid of Ldap authentication (not used) in Log Search
- update stack code (protocol + port changes)
- manage pid file by spring boot application (wont be needed to create the pid 
file in run.sh script)
- add some new config objects
- update to jetty 9.4
- pom.xml cleanup (get rid of non used profile)


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-logfeeder/build.properties 46979e5 
  ambari-logsearch/ambari-logsearch-server/build.properties 1cd118a 
  ambari-logsearch/ambari-logsearch-server/pom.xml 4db1f61 
  ambari-logsearch/ambari-logsearch-server/run.sh ea89947 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 b1517df 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
 df00c15 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
 a018dda 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
 3505fe2 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/XMLPropertiesHelper.java
 690a60f 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
 1e61f22 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
 756252d 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchConfigMapHolder.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchJerseyResourceConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchServletConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSpnegoConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSslConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 5207dd0 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/StaticResourceConfiguration.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java
 23b7430 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SslConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
 b0b893f 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/WebUtil.java
 36865ad 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
 ec3075c 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/listener/LogSearchSessionListener.java
 9fa5c80 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapProperties.java
 82e71fe 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapPropertyName.java
 370c94b 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapUtil.java
 6248e74 
  

Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61453/#review182306
---



What OS'es was this tested on?

- Alejandro Fernandez


On Aug. 7, 2017, 10:45 a.m., Aman Poonia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61453/
> ---
> 
> (Updated Aug. 7, 2017, 10:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-21634
> https://issues.apache.org/jira/browse/AMBARI-21634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make sure Ambari also considers NIS users
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 5f96df5b7a 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 027a0a885c 
> 
> 
> Diff: https://reviews.apache.org/r/61453/diff/1/
> 
> 
> Testing
> ---
> 
> Changed the TestHostInfo.py to include one valid and one invalid user. Also 
> tried it with NIS users and it works as expected.
> 
> 
> Thanks,
> 
> Aman Poonia
> 
>

Re: Review Request 61461: Log Search cleanup: all configurations should be spring managed

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61461/#review182305
---


Ship it!




Ship It!

- Robert Nettleton


On Aug. 7, 2017, 4:03 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61461/
> ---
> 
> (Updated Aug. 7, 2017, 4:03 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21670
> https://issues.apache.org/jira/browse/AMBARI-21670
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some properties (like used port or protocol) for Log Search were not managed 
> by Spring. Those were loaded by PropertiesHelper -> that is not the proper 
> way to do it. To make the whole application managed by Spring, it affects the 
> servlet definitions as well.
> 
> Also the patch contains a lot of cleanups.
> 
> Changes:
> - introduce spring boot in order to get rid of managing glasshish, jakson, 
> spring dependencies togather.
> - use /static/ folder for static web files intead of webapps/apps (also 
> static content will be handled outside of jersey filter)
> - move logsearch-env/logsearch_protocol and logsearch_ui_port to 
> logsearch.properties -> add a new property for SSL port.
> - get rid of SSLUtil, use SSLConfigurer bean instead of it.
> - get rid of Ldap authentication (not used) in Log Search
> - update stack code (protocol + port changes)
> - manage pid file by spring boot application (wont be needed to create the 
> pid file in run.sh script)
> - add some new config objects
> - update to jetty 9.4
> - pom.xml cleanup (get rid of non used profile)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/build.properties 46979e5 
>   ambari-logsearch/ambari-logsearch-server/build.properties 1cd118a 
>   ambari-logsearch/ambari-logsearch-server/pom.xml 4db1f61 
>   ambari-logsearch/ambari-logsearch-server/run.sh ea89947 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  b1517df 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  df00c15 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  a018dda 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
>  3505fe2 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/XMLPropertiesHelper.java
>  690a60f 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  1e61f22 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  756252d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchConfigMapHolder.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchJerseyResourceConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchServletConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSpnegoConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSslConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  5207dd0 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/StaticResourceConfiguration.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java
>  23b7430 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SslConfigurer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
>  b0b893f 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/WebUtil.java
>  36865ad 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
>  ec3075c 
>   
> 

Re: Review Request 61462: Update Orchestration to support MAINT

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61462/#review182301
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
Lines 931 (patched)


Typo in orchestration


- Alejandro Fernandez


On Aug. 7, 2017, 3:04 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61462/
> ---
> 
> (Updated Aug. 7, 2017, 3:04 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-21672
> https://issues.apache.org/jira/browse/AMBARI-21672
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update orchestration to support VDF types of {{MAINT}}.
> * Type {{PATCH}} and type {{MAINT}} should be treated the same for 
> orchestration.
> * If the available services loop has a {{release-version}} then use that to 
> determine if a service should be included in orchestration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  c5b8269547 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java
>  e2bb27ed5b 
> 
> 
> Diff: https://reviews.apache.org/r/61462/diff/2/
> 
> 
> Testing
> ---
> 
> Tests run: 4524, Failures: 0, Errors: 0, Skipped: 32
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:08 min
> [INFO] Finished at: 2017-08-07T12:54:08-04:00
> [INFO] Final Memory: 77M/1015M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 61462: Update Orchestration to support MAINT

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61462/#review182296
---


Ship it!




Ship It!

- Nate Cole


On Aug. 7, 2017, 11:04 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61462/
> ---
> 
> (Updated Aug. 7, 2017, 11:04 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-21672
> https://issues.apache.org/jira/browse/AMBARI-21672
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update orchestration to support VDF types of {{MAINT}}.
> * Type {{PATCH}} and type {{MAINT}} should be treated the same for 
> orchestration.
> * If the available services loop has a {{release-version}} then use that to 
> determine if a service should be included in orchestration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  c5b8269547 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java
>  e2bb27ed5b 
> 
> 
> Diff: https://reviews.apache.org/r/61462/diff/2/
> 
> 
> Testing
> ---
> 
> Tests run: 4524, Failures: 0, Errors: 0, Skipped: 32
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:08 min
> [INFO] Finished at: 2017-08-07T12:54:08-04:00
> [INFO] Final Memory: 77M/1015M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 60403: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

[Qin Liu]

> On July 5, 2017, 6:38 p.m., Robert Levas wrote:
> > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
> > Lines 33 (patched)
> > 
> >
> > Would it be possible to use 
> > `resource_management.libraries.functions.curl_krb_request.curl_krb_request` 
> > instead?
> 
> Qin Liu wrote:
> Hi Robert, 
> Thank you so much for your review! I just came back from vacation and 
> will re-visit it ASAP.

Hi Robert,

Sorry for the delay!

I think spnego_kerberos_auth is better choice than curl_krb_request for metrics 
monitor because it will have better performance:
1. Metrics monitor curently uses the same cached HTTP connection for every POST 
call while curl_krb_request will make different HTTP connection for each call
2. Metrics monitor can take advantage of the same cached HTTP connection for 
every POST call by using spnego_kerberos_auth  
3. With spnego_kerberos_auth, metrics monitor will use cookie in memory while 
curl_krb_request uses cookie cache in disk

curl_krb_request can be better choice for alert monitors due to the nature of 
alerts - should be on different connection for each call.


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60403/#review179673
---


On June 23, 2017, 10:49 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60403/
> ---
> 
> (Updated June 23, 2017, 10:49 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Di Li, Dmytro Sen, Robert 
> Levas, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-17898
> https://issues.apache.org/jira/browse/AMBARI-17898
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Ambari Metrics Monitor, a client of Ambari Metrics Collector, currently does 
> not support Kerberos HTTP SPNEGO authentication.
> /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
> 2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
> http://metrics-collector:6188/ws/v1/timeline/metrics
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
> server. HTTP Error 401: Authentication required
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 7fe7397 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  d1429ed 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 77b8c23 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
>  4056ae3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
>  51f541f 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
>  9031b46 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  f49d47d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  b8c14f4 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  b7dee50 
> 
> 
> Diff: https://reviews.apache.org/r/60403/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Unit tests passed
> 2. manually tested with HDP/trunk
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 61459: Expose via API whether a service will participate in an upgrade

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61459/#review182286
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 7, 2017, 2 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61459/
> ---
> 
> (Updated Aug. 7, 2017, 2 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21671
> https://issues.apache.org/jira/browse/AMBARI-21671
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add to the ClusterResourceProvider a structure that shows which services of 
> the cluster will be in the upgrade.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  ed509b7a5c 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> b151278e76 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> e2956cac9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ClusterVersionSummary.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ServiceVersionSummary.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  f48c7238bd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  89e8016f12 
>   ambari-server/src/test/resources/version_definition_test_maint.xml 
> ac21045137 
>   ambari-server/src/test/resources/version_definition_test_maint_partial.xml 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61459/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4465, Failures: 0, Errors: 0, Skipped: 30
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 22:33.890s
> [INFO] Finished at: Mon Aug 07 10:31:36 EDT 2017
> [INFO] Final Memory: 57M/677M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 61456: Create a topic to send alert_definitions

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61456/#review182285
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 7, 2017, 11:45 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61456/
> ---
> 
> (Updated Aug. 7, 2017, 11:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-21667
> https://issues.apache.org/jira/browse/AMBARI-21667
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 6c1d29c 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 9507c9d 
>   ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 
> PRE-CREATION 
>   ambari-agent/src/main/python/ambari_agent/Constants.py 17ed2be 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 85840d0 
>   ambari-agent/src/main/python/ambari_agent/InitializerModule.py 6ef4a04 
>   ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b75b540 
>   ambari-agent/src/main/python/ambari_agent/alerts/collector.py adc7f47 
>   ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 803bdc6 
>   ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1e32718 
>   ambari-agent/src/main/python/ambari_agent/alerts/recovery_alert.py 3092a39 
>   ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 945a222 
>   ambari-agent/src/main/python/ambari_agent/apscheduler/threadpool.py d6624cc 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py
>  PRE-CREATION 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/HostLevelParamsEventListener.py
>  5aee634 
>   ambari-agent/src/main/python/ambari_agent/main.py 56962d3 
>   ambari-agent/src/test/python/ambari_agent/BaseStompServerTestCase.py 
> 5db53c8 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
> 88f1e69 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61456/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 61461: Log Search cleanup: all configurations should be spring managed

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61461/#review182283
---


Ship it!




Ship It!

- Sebastian Toader


On Aug. 7, 2017, 6:03 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61461/
> ---
> 
> (Updated Aug. 7, 2017, 6:03 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21670
> https://issues.apache.org/jira/browse/AMBARI-21670
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some properties (like used port or protocol) for Log Search were not managed 
> by Spring. Those were loaded by PropertiesHelper -> that is not the proper 
> way to do it. To make the whole application managed by Spring, it affects the 
> servlet definitions as well.
> 
> Also the patch contains a lot of cleanups.
> 
> Changes:
> - introduce spring boot in order to get rid of managing glasshish, jakson, 
> spring dependencies togather.
> - use /static/ folder for static web files intead of webapps/apps (also 
> static content will be handled outside of jersey filter)
> - move logsearch-env/logsearch_protocol and logsearch_ui_port to 
> logsearch.properties -> add a new property for SSL port.
> - get rid of SSLUtil, use SSLConfigurer bean instead of it.
> - get rid of Ldap authentication (not used) in Log Search
> - update stack code (protocol + port changes)
> - manage pid file by spring boot application (wont be needed to create the 
> pid file in run.sh script)
> - add some new config objects
> - update to jetty 9.4
> - pom.xml cleanup (get rid of non used profile)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/build.properties 46979e5 
>   ambari-logsearch/ambari-logsearch-server/build.properties 1cd118a 
>   ambari-logsearch/ambari-logsearch-server/pom.xml 4db1f61 
>   ambari-logsearch/ambari-logsearch-server/run.sh ea89947 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  b1517df 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  df00c15 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  a018dda 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
>  3505fe2 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/XMLPropertiesHelper.java
>  690a60f 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  1e61f22 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  756252d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchConfigMapHolder.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchJerseyResourceConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchServletConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSpnegoConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSslConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  5207dd0 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/StaticResourceConfiguration.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java
>  23b7430 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SslConfigurer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
>  b0b893f 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/WebUtil.java
>  36865ad 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
>  ec3075c 
>   
> 

Re: Review Request 61461: Log Search cleanup: all configurations should be spring managed

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61461/
---

(Updated Aug. 7, 2017, 4:03 p.m.)


Review request for Ambari, Attila Magyar, Robert Nettleton, and Sebastian 
Toader.


Changes
---

removed tab


Bugs: AMBARI-21670
https://issues.apache.org/jira/browse/AMBARI-21670


Repository: ambari


Description
---

Some properties (like used port or protocol) for Log Search were not managed by 
Spring. Those were loaded by PropertiesHelper -> that is not the proper way to 
do it. To make the whole application managed by Spring, it affects the servlet 
definitions as well.

Also the patch contains a lot of cleanups.

Changes:
- introduce spring boot in order to get rid of managing glasshish, jakson, 
spring dependencies togather.
- use /static/ folder for static web files intead of webapps/apps (also static 
content will be handled outside of jersey filter)
- move logsearch-env/logsearch_protocol and logsearch_ui_port to 
logsearch.properties -> add a new property for SSL port.
- get rid of SSLUtil, use SSLConfigurer bean instead of it.
- get rid of Ldap authentication (not used) in Log Search
- update stack code (protocol + port changes)
- manage pid file by spring boot application (wont be needed to create the pid 
file in run.sh script)
- add some new config objects
- update to jetty 9.4
- pom.xml cleanup (get rid of non used profile)


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-logfeeder/build.properties 46979e5 
  ambari-logsearch/ambari-logsearch-server/build.properties 1cd118a 
  ambari-logsearch/ambari-logsearch-server/pom.xml 4db1f61 
  ambari-logsearch/ambari-logsearch-server/run.sh ea89947 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 b1517df 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
 df00c15 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
 a018dda 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
 3505fe2 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/XMLPropertiesHelper.java
 690a60f 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
 1e61f22 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
 756252d 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchConfigMapHolder.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchJerseyResourceConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchServletConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSpnegoConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSslConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 5207dd0 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/StaticResourceConfiguration.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java
 23b7430 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SslConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
 b0b893f 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/WebUtil.java
 36865ad 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
 ec3075c 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/listener/LogSearchSessionListener.java
 9fa5c80 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapProperties.java
 82e71fe 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapPropertyName.java
 370c94b 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapUtil.java
 6248e74 
  

Re: Review Request 61462: Update Orchestration to support MAINT

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61462/#review182281
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Aug. 7, 2017, 6:04 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61462/
> ---
> 
> (Updated Aug. 7, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-21672
> https://issues.apache.org/jira/browse/AMBARI-21672
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update orchestration to support VDF types of {{MAINT}}.
> * Type {{PATCH}} and type {{MAINT}} should be treated the same for 
> orchestration.
> * If the available services loop has a {{release-version}} then use that to 
> determine if a service should be included in orchestration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  c5b8269547 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java
>  e2bb27ed5b 
> 
> 
> Diff: https://reviews.apache.org/r/61462/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 61461: Log Search cleanup: all configurations should be spring managed

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61461/
---

Review request for Ambari, Attila Magyar, Robert Nettleton, and Sebastian 
Toader.


Bugs: AMBARI-21670
https://issues.apache.org/jira/browse/AMBARI-21670


Repository: ambari


Description
---

Some properties (like used port or protocol) for Log Search were not managed by 
Spring. Those were loaded by PropertiesHelper -> that is not the proper way to 
do it. To make the whole application managed by Spring, it affects the servlet 
definitions as well.

Also the patch contains a lot of cleanups.

Changes:
- introduce spring boot in order to get rid of managing glasshish, jakson, 
spring dependencies togather.
- use /static/ folder for static web files intead of webapps/apps (also static 
content will be handled outside of jersey filter)
- move logsearch-env/logsearch_protocol and logsearch_ui_port to 
logsearch.properties -> add a new property for SSL port.
- get rid of SSLUtil, use SSLConfigurer bean instead of it.
- get rid of Ldap authentication (not used) in Log Search
- update stack code (protocol + port changes)
- manage pid file by spring boot application (wont be needed to create the pid 
file in run.sh script)
- add some new config objects
- update to jetty 9.4
- pom.xml cleanup (get rid of non used profile)


Diffs
-

  ambari-logsearch/ambari-logsearch-logfeeder/build.properties 46979e5 
  ambari-logsearch/ambari-logsearch-server/build.properties 1cd118a 
  ambari-logsearch/ambari-logsearch-server/pom.xml 4db1f61 
  ambari-logsearch/ambari-logsearch-server/run.sh ea89947 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 b1517df 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
 df00c15 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
 a018dda 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
 3505fe2 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/XMLPropertiesHelper.java
 690a60f 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
 1e61f22 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
 756252d 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchConfigMapHolder.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchJerseyResourceConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchServletConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSpnegoConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSslConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 5207dd0 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/StaticResourceConfiguration.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java
 23b7430 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SslConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
 b0b893f 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/WebUtil.java
 36865ad 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
 ec3075c 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/listener/LogSearchSessionListener.java
 9fa5c80 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapProperties.java
 82e71fe 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapPropertyName.java
 370c94b 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapUtil.java
 6248e74 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAbstractAuthenticationProvider.java
 1c7bf3b 
  

Review Request 61462: Update Orchestration to support MAINT

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61462/
---

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-21672
https://issues.apache.org/jira/browse/AMBARI-21672


Repository: ambari


Description
---

Update orchestration to support VDF types of {{MAINT}}.
* Type {{PATCH}} and type {{MAINT}} should be treated the same for 
orchestration.
* If the available services loop has a {{release-version}} then use that to 
determine if a service should be included in orchestration.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
c5b8269547 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java
 e2bb27ed5b 


Diff: https://reviews.apache.org/r/61462/diff/1/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Re: Review Request 61459: Expose via API whether a service will participate in an upgrade

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61459/#review182275
---


Ship it!




Ship It!

- Jonathan Hurley


On Aug. 7, 2017, 10 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61459/
> ---
> 
> (Updated Aug. 7, 2017, 10 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21671
> https://issues.apache.org/jira/browse/AMBARI-21671
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add to the ClusterResourceProvider a structure that shows which services of 
> the cluster will be in the upgrade.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  ed509b7a5c 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> b151278e76 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> e2956cac9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ClusterVersionSummary.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ServiceVersionSummary.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  f48c7238bd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  89e8016f12 
>   ambari-server/src/test/resources/version_definition_test_maint.xml 
> ac21045137 
>   ambari-server/src/test/resources/version_definition_test_maint_partial.xml 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61459/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 61459: Expose via API whether a service will participate in an upgrade

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61459/#review182273
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Aug. 7, 2017, 5 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61459/
> ---
> 
> (Updated Aug. 7, 2017, 5 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21671
> https://issues.apache.org/jira/browse/AMBARI-21671
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add to the ClusterResourceProvider a structure that shows which services of 
> the cluster will be in the upgrade.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  ed509b7a5c 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> b151278e76 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> e2956cac9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ClusterVersionSummary.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ServiceVersionSummary.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  f48c7238bd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  89e8016f12 
>   ambari-server/src/test/resources/version_definition_test_maint.xml 
> ac21045137 
>   ambari-server/src/test/resources/version_definition_test_maint_partial.xml 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61459/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 61459: Expose via API whether a service will participate in an upgrade

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61459/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-21671
https://issues.apache.org/jira/browse/AMBARI-21671


Repository: ambari


Description
---

Add to the ClusterResourceProvider a structure that shows which services of the 
cluster will be in the upgrade.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 ed509b7a5c 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
b151278e76 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
e2956cac9f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/ClusterVersionSummary.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/ServiceVersionSummary.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 f48c7238bd 
  
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
 89e8016f12 
  ambari-server/src/test/resources/version_definition_test_maint.xml ac21045137 
  ambari-server/src/test/resources/version_definition_test_maint_partial.xml 
PRE-CREATION 


Diff: https://reviews.apache.org/r/61459/diff/1/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Review Request 61456: Create a topic to send alert_definitions

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61456/
---

Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-21667
https://issues.apache.org/jira/browse/AMBARI-21667


Repository: ambari


Description
---


Diffs
-

  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 6c1d29c 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 9507c9d 
  ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 
PRE-CREATION 
  ambari-agent/src/main/python/ambari_agent/Constants.py 17ed2be 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 85840d0 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py 6ef4a04 
  ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b75b540 
  ambari-agent/src/main/python/ambari_agent/alerts/collector.py adc7f47 
  ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 803bdc6 
  ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1e32718 
  ambari-agent/src/main/python/ambari_agent/alerts/recovery_alert.py 3092a39 
  ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 945a222 
  ambari-agent/src/main/python/ambari_agent/apscheduler/threadpool.py d6624cc 
  
ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py
 PRE-CREATION 
  
ambari-agent/src/main/python/ambari_agent/listeners/HostLevelParamsEventListener.py
 5aee634 
  ambari-agent/src/main/python/ambari_agent/main.py 56962d3 
  ambari-agent/src/test/python/ambari_agent/BaseStompServerTestCase.py 5db53c8 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 88f1e69 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61456/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users

[Aman Poonia]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61453/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-21634
https://issues.apache.org/jira/browse/AMBARI-21634


Repository: ambari


Description
---

Make sure Ambari also considers NIS users


Diffs
-

  ambari-agent/src/main/python/ambari_agent/HostInfo.py 5f96df5b7a 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 027a0a885c 


Diff: https://reviews.apache.org/r/61453/diff/1/


Testing
---

Changed the TestHostInfo.py to include one valid and one invalid user. Also 
tried it with NIS users and it works as expected.


Thanks,

Aman Poonia

Re: Review Request 61447: AMBARI-21607. HIVE_AUX_JARS_PATH points to wrong location

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61447/#review182264
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 6, 2017, 11:17 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61447/
> ---
> 
> (Updated Aug. 6, 2017, 11:17 a.m.)
> 
> 
> Review request for Ambari, Di Li, Eric Yang, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21607
> https://issues.apache.org/jira/browse/AMBARI-21607
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove references to `hbase_lib`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  566bcd6f121d22efe58b5778181c93c4a1acf133 
> 
> 
> Diff: https://reviews.apache.org/r/61447/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster upgrade from IOP 4.2:
> 
> ```
> Replaced hive-env/content containing "# Set HIVE_AUX_JARS_PATH
> export HIVE_AUX_JARS_PATH={{hbase_lib}}/hbase-client.jar,\
> {{hbase_lib}}/hbase-common.jar,\
> {{hbase_lib}}/hbase-hadoop2-compat.jar,\
> {{hbase_lib}}/hbase-prefix-tree.jar,\
> {{hbase_lib}}/hbase-protocol.jar,\
> {{hbase_lib}}/hbase-server.jar,\
> {{hbase_lib}}/htrace-core-3.1.0-incubating.jar,\
> ${HIVE_AUX_JARS_PATH}" with ""
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>