Review Request 62364: Set tez.runtime.shuffle.ssl.enable=false in Ambari for HSI

2017-09-15 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62364/
---

Review request for Ambari, Dmytro Grinenko, Jayush Luniya, Swapan Shridhar, and 
Sid Wagle.


Bugs: AMBARI-21973
https://issues.apache.org/jira/browse/AMBARI-21973


Repository: ambari


Description
---

Add tez.runtime.shuffle.ssl.enable=false to tez-interactive-site.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
 c1a42b0 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
75a8782 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 07bc8a4 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 850f725 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
9a42098 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
ea58559 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
c67e4cf 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 b49fdbf 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
af885e1 


Diff: https://reviews.apache.org/r/62364/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

2017-09-15 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review185494
---


Ship it!




Ship It!

- Nate Cole


On Sept. 15, 2017, 11:58 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61994/
> ---
> 
> (Updated Sept. 15, 2017, 11:58 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21856
> https://issues.apache.org/jira/browse/AMBARI-21856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that Ambari is using the reponame name field as the 
> distribution when it creates the repo definition file. Since both of these 
> repos use same distribution (which is a common Debian pattern), they collide.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  32b8038 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  858a55f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  89dc126 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  0735e27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  88ece8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  e81d1af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  bad8195 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> d43bdfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  854f03f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
>  5e1d5d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  17ded10 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  8427a1d 
>   ambari-server/src/main/resources/custom_actions/scripts/update_repo.py 
> 9f2107d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  058c45b 
>   ambari-server/src/main/resources/version_definition.xsd 832d7f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
>  18e2d3f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json f337f41 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
>  082d200 
> 
> 
> Diff: https://reviews.apache.org/r/61994/diff/5/
> 
> 
> Testing
> ---
> 
> test will be fixed after solution will be approved
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

2017-09-15 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/
---

(Updated Вер. 15, 2017, 3:58 після полудня)


Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.


Bugs: AMBARI-21856
https://issues.apache.org/jira/browse/AMBARI-21856


Repository: ambari


Description
---

The problem is that Ambari is using the reponame name field as the distribution 
when it creates the repo definition file. Since both of these repos use same 
distribution (which is a common Debian pattern), they collide.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
 32b8038 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
 858a55f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 89dc126 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
 0735e27 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 88ece8f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 e81d1af 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
 bad8195 
  ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
d43bdfa 
  
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 
854f03f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
 5e1d5d3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
 17ded10 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
 8427a1d 
  ambari-server/src/main/resources/custom_actions/scripts/update_repo.py 
9f2107d 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
 058c45b 
  ambari-server/src/main/resources/version_definition.xsd 832d7f9 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
 18e2d3f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
 3a7b19b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json f337f41 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
 082d200 


Diff: https://reviews.apache.org/r/61994/diff/5/

Changes: https://reviews.apache.org/r/61994/diff/4-5/


Testing
---

test will be fixed after solution will be approved


Thanks,

Vitalyi Brodetskyi

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-15 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/
---

(Updated Sept. 15, 2017, 10:34 a.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian Toader.


Changes
---

Replaced custom validation code with a JSON schema validator.


Bugs: AMBARI-21938
https://issues.apache.org/jira/browse/AMBARI-21938


Repository: ambari


Description
---

Validate kerberos.json files to ensure they meet the expected schema.


Diffs (updated)
-

  ambari-server/pom.xml 29a820a329 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
 0d1da9c743 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
 5658133c9b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
 768a17e3b3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
 0eb3733584 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
 911723b80b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java
 a17caadda0 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
 74254e3fe3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
 5da33997ab 
  ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
c9d8c91372 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java
 0f1dd55044 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
 09699c6fd6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
 e891fdea4e 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
 7fb56248e5 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelperTest.java
 44812de55d 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
 d11962b9a3 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
 8cdb39e02e 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
 b84223f421 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
 e4d3c90767 
  ambari-server/src/test/resources/kerberos_descriptor_schema.json PRE-CREATION 


Diff: https://reviews.apache.org/r/62290/diff/3/

Changes: https://reviews.apache.org/r/62290/diff/2-3/


Testing
---

Ensured the following unit tests passed:

- org.apache.ambari.server.stack.KerberosDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest


Thanks,

Robert Levas

Re: Review Request 62351: AMBARI-21910 Ranger Usersync config to support nested group evaluation for LDAP Sync source property

2017-09-15 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62351/#review185489
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
Lines 621-658 (patched)


This will cause Ranger configurations to change during upgrade, which will 
require a restart. We typically don't do this during Ambari upgrades since it 
would lead to extra downtime. These settings can be configured manually after 
upgrading Ambari, no?

Also - we shouldn't be referring to stacks by name and version. This kind 
of tight coupling is what we're trying to get away from. You should, instead, 
query the current cluster stack to see if it supports those properties.


- Jonathan Hurley


On Sept. 15, 2017, 8:41 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62351/
> ---
> 
> (Updated Sept. 15, 2017, 8:41 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-21910
> https://issues.apache.org/jira/browse/AMBARI-21910
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of RANGER-1735, we are supporting nested groups in ranger usersync. 
> For this, introduced one new property 
> "ranger.usersync.ldap.grouphierarchylevels". The value should be an integer 
> with default value as 0. This property should be under Ranger --> Configs --> 
> Ranger User Info --> Group Configs tab.
> This property can be enabled with a flag labelled as "Sync Nested Groups". 
> 1. Default value for this flag is "No"
> 2. This flag is always shown under Group Configs (even when "Enable group 
> Sync" is set to "No")
> 3. If this flag is set to "No", then the value for 
> ranger.usersync.ldap.grouphierarchylevels is hidden and is set to "0". 
> 4. If this flag is set to "Yes", then 
> ranger.usersync.ldap.grouphierarchylevels is shown and allowed to set any 
> integer greater than 0.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  a56bda2 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
>  627216e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-ugsync-site.xml
>  a994856 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
>  8068a38 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  e363c8d 
> 
> 
> Diff: https://reviews.apache.org/r/62351/diff/1/
> 
> 
> Testing
> ---
> 
> Test Fresh Installs.
> Ambari upgrade with stack 2.6.
> Unit Test passed for UpgradeCatalog260Test.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 62245: Auto fix enhancement to remove more than 1 selected configs

2017-09-15 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62245/#review185487
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 15, 2017, 9:35 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62245/
> ---
> 
> (Updated Sept. 15, 2017, 9:35 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21935
> https://issues.apache.org/jira/browse/AMBARI-21935
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Sometimes Ambari is coming up with issues like more than 1 selected configs.
> 
> Error:
> {noformat}
> ERROR - You have config(s), in cluster BMOHDPQA01, that is(are) selected more 
> than once in clusterconfigmapping table: 
> falcon-startup.properties,zoo.cfg,zeppelin-config,zookeeper-log4j,tagsync-application-properties,storm-worker-log4j,hive-log4j2,admin-properties,oozie-env,ssl-server,hadoop-policy,infra-solr-log4j,oozie-log4j,core-site,mahout-log4j,kafka-broker,pig-log4j,livy-env,zeppelin-env,hive-log4j,slider-client,tez-env,storm-env,ranger-storm-plugin-properties,oozie-site,falcon-env,beeline-log4j2,ranger-storm-policymgr-ssl,falcon-runtime.properties,ranger-storm-security,hbase-policy,ams-env,capacity-scheduler,webhcat-log4j,atlas-log4j,livy-log4j-properties,spark-metrics-properties,hbase-env,ranger-atlas-security,flume-env,sqoop-atlas-application.properties,admin-log4j,hiveserver2-interactive-site,ranger-tagsync-site,application-properties,ranger-kafka-policymgr-ssl,ranger-admin-site,ranger-env,ranger-storm-audit,ranger-hbase-policymgr-ssl,hdfs-log4j
> {noformat}
> 
> It is very difficult to fix these kind of issues with queries. including auto 
> fix for this will be very helpful.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  575485bd54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
> a23b914f34 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
>  9bf03b343f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  6c6c00f947 
> 
> 
> Diff: https://reviews.apache.org/r/62245/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> live check on cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 62354: Exception was thrown while starting Patch Rolling/Express Upgrade when upgrade failure tolerance option is selected

2017-09-15 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62354/#review185488
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 15, 2017, 9:16 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62354/
> ---
> 
> (Updated Sept. 15, 2017, 9:16 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21967
> https://issues.apache.org/jira/browse/AMBARI-21967
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Missed a situation where the service-check merging logic failed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> e6ca728ee6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  5dfbc53b8f 
> 
> 
> Diff: https://reviews.apache.org/r/62354/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4902, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:26.167s
> [INFO] Finished at: Fri Sep 15 09:41:32 EDT 2017
> [INFO] Final Memory: 109M/1943M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62356: Log Feeder should not support german month names

2017-09-15 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62356/#review185486
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 15, 2017, 1:27 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62356/
> ---
> 
> (Updated Sept. 15, 2017, 1:27 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21968
> https://issues.apache.org/jira/browse/AMBARI-21968
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Feeder grok patterns currently support german month names too. This has 
> almost no usefulness at all, as there are no german language logs, and we 
> don't even support german day names, but it may cause errors as the März 
> contains a ä character which may lead to encoding related errors.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/grok-patterns 
> 920f521 
> 
> 
> Diff: https://reviews.apache.org/r/62356/diff/1/
> 
> 
> Testing
> ---
> 
> Done.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62245: Auto fix enhancement to remove more than 1 selected configs

2017-09-15 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62245/
---

(Updated Sept. 15, 2017, 4:35 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Summary (updated)
-

Auto fix enhancement to remove more than 1 selected configs


Bugs: AMBARI-21935
https://issues.apache.org/jira/browse/AMBARI-21935


Repository: ambari


Description
---

Sometimes Ambari is coming up with issues like more than 1 selected configs.

Error:
{noformat}
ERROR - You have config(s), in cluster BMOHDPQA01, that is(are) selected more 
than once in clusterconfigmapping table: 
falcon-startup.properties,zoo.cfg,zeppelin-config,zookeeper-log4j,tagsync-application-properties,storm-worker-log4j,hive-log4j2,admin-properties,oozie-env,ssl-server,hadoop-policy,infra-solr-log4j,oozie-log4j,core-site,mahout-log4j,kafka-broker,pig-log4j,livy-env,zeppelin-env,hive-log4j,slider-client,tez-env,storm-env,ranger-storm-plugin-properties,oozie-site,falcon-env,beeline-log4j2,ranger-storm-policymgr-ssl,falcon-runtime.properties,ranger-storm-security,hbase-policy,ams-env,capacity-scheduler,webhcat-log4j,atlas-log4j,livy-log4j-properties,spark-metrics-properties,hbase-env,ranger-atlas-security,flume-env,sqoop-atlas-application.properties,admin-log4j,hiveserver2-interactive-site,ranger-tagsync-site,application-properties,ranger-kafka-policymgr-ssl,ranger-admin-site,ranger-env,ranger-storm-audit,ranger-hbase-policymgr-ssl,hdfs-log4j
{noformat}

It is very difficult to fix these kind of issues with queries. including auto 
fix for this will be very helpful.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 575485bd54 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
a23b914f34 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
 9bf03b343f 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 6c6c00f947 


Diff: https://reviews.apache.org/r/62245/diff/3/


Testing
---

mvn clean test
live check on cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 62354: Exception was thrown while starting Patch Rolling/Express Upgrade when upgrade failure tolerance option is selected

2017-09-15 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62354/#review185484
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 15, 2017, 4:16 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62354/
> ---
> 
> (Updated Sept. 15, 2017, 4:16 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21967
> https://issues.apache.org/jira/browse/AMBARI-21967
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Missed a situation where the service-check merging logic failed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> e6ca728ee6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  5dfbc53b8f 
> 
> 
> Diff: https://reviews.apache.org/r/62354/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62356: Log Feeder should not support german month names

2017-09-15 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62356/#review185482
---


Ship it!




Ship It!

- Oliver Szabo


On Sept. 15, 2017, 1:27 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62356/
> ---
> 
> (Updated Sept. 15, 2017, 1:27 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21968
> https://issues.apache.org/jira/browse/AMBARI-21968
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Feeder grok patterns currently support german month names too. This has 
> almost no usefulness at all, as there are no german language logs, and we 
> don't even support german day names, but it may cause errors as the März 
> contains a ä character which may lead to encoding related errors.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/grok-patterns 
> 920f521 
> 
> 
> Diff: https://reviews.apache.org/r/62356/diff/1/
> 
> 
> Testing
> ---
> 
> Done.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 62356: Log Feeder should not support german month names

2017-09-15 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62356/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-21968
https://issues.apache.org/jira/browse/AMBARI-21968


Repository: ambari


Description
---

Log Feeder grok patterns currently support german month names too. This has 
almost no usefulness at all, as there are no german language logs, and we don't 
even support german day names, but it may cause errors as the März contains a ä 
character which may lead to encoding related errors.


Diffs
-

  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/grok-patterns 
920f521 


Diff: https://reviews.apache.org/r/62356/diff/1/


Testing
---

Done.


Thanks,

Miklos Gergely

Review Request 62354: Exception was thrown while starting Patch Rolling/Express Upgrade when upgrade failure tolerance option is selected

2017-09-15 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62354/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-21967
https://issues.apache.org/jira/browse/AMBARI-21967


Repository: ambari


Description
---

Missed a situation where the service-check merging logic failed.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
e6ca728ee6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 5dfbc53b8f 


Diff: https://reviews.apache.org/r/62354/diff/1/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

2017-09-15 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review185479
---




ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
Lines 132-133 (original), 134-135 (patched)


There should be some python tests surrounding this new functionality to 
confirm the contents of the repo file.



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
Lines 49 (patched)


remove print debug statement or use Logger.debug


- Nate Cole


On Sept. 14, 2017, 6:47 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61994/
> ---
> 
> (Updated Sept. 14, 2017, 6:47 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21856
> https://issues.apache.org/jira/browse/AMBARI-21856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that Ambari is using the reponame name field as the 
> distribution when it creates the repo definition file. Since both of these 
> repos use same distribution (which is a common Debian pattern), they collide.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  32b8038 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  858a55f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  c78d88d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  0735e27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  88ece8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  e81d1af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  bad8195 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> d43bdfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  854f03f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
>  5e1d5d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  17ded10 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  8427a1d 
>   ambari-server/src/main/resources/custom_actions/scripts/update_repo.py 
> 9f2107d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  058c45b 
>   ambari-server/src/main/resources/version_definition.xsd 832d7f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
>  18e2d3f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
> 
> 
> Diff: https://reviews.apache.org/r/61994/diff/4/
> 
> 
> Testing
> ---
> 
> test will be fixed after solution will be approved
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62348: branch-2.6 Builds Fail With Forked VM Error On Tests

2017-09-15 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62348/#review185471
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Вер. 15, 2017, 6:59 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62348/
> ---
> 
> (Updated Вер. 15, 2017, 6:59 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21964
> https://issues.apache.org/jira/browse/AMBARI-21964
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All 2.6 builds are failing even though tests report as passing. With each run,
> it's a different test that seems to cause the problem, so it's not consistent.
> 
> 
> 
> 
> [INFO] Results:
> [INFO] 
> [WARNING] Tests run: 4802, Failures: 0, Errors: 0, Skipped: 35
> 
> 
> This seems to be due to a surefire problem with the JVMs created for the
> tests:
> 
> 
> 
> 
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly 
> saying goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd 
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server && 
> /usr/local/asfpackages/java/jdk1.7.0_80/jre/bin/java -Xmx1024m 
> -XX:MaxPermSize=512m -Xms512m -jar 
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire/surefirebooter1775364586569779113.jar
>  
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire
>  2017-08-23T14-58-45_595-jvmRun1 surefire5302937670169703589tmp 
> surefire_3565051269905631767801tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.agent.TestHeartbeatHandler
> [ERROR] ExecutionException The forked VM terminated without properly 
> saying goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd 
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server && 
> /usr/local/asfpackages/java/jdk1.7.0_80/jre/bin/java -Xmx1024m 
> -XX:MaxPermSize=512m -Xms512m -jar 
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire/surefirebooter4243280705420804420.jar
>  
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire
>  2017-08-23T14-58-45_595-jvmRun4 surefire5453334563682547339tmp 
> surefire_3586448350854680944601tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.agent.TestHeartbeatMonitor
> [ERROR] ExecutionException The forked VM terminated without properly 
> saying goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd 
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server && 
> /usr/local/asfpackages/java/jdk1.7.0_80/jre/bin/java -Xmx1024m 
> -XX:MaxPermSize=512m -Xms512m -jar 
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire/surefirebooter7638123946663578882.jar
>  
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire
>  2017-08-23T14-58-45_595-jvmRun2 surefire5447207613794558892tmp 
> surefire_359575380127168860507tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.agent.HeartbeatProcessorTest
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: 
> ExecutionException The forked VM terminated without properly saying goodbye. 
> VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd 
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server && 
> /usr/local/asfpackages/java/jdk1.7.0_80/jre/bin/java -Xmx1024m 
> -XX:MaxPermSize=512m -Xms512m -jar 
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire/surefirebooter1775364586569779113.jar
>  
> /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire
>  2017-08-23T14-58-45_595-jvmRun1 surefire5302937670169703589tmp 
> surefire_3565051269905631767801tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] Crashed tests:
> [ERROR] org.apache.ambari.server.agent.TestHeartbeatHandler
> [ERROR] ExecutionException The forked VM terminated without properly 
> saying goodbye. VM crash or