Re: Review Request 62454: Could not copy tez tarball to HDFS during prepare upgrade (EU)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62454/#review185827
---
Ship it!
Ship It!
- Jonathan Hurley
On Sept. 20, 2017, 4:51 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62454/
> ---
>
> (Updated Sept. 20, 2017, 4:51 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-22011
> https://issues.apache.org/jira/browse/AMBARI-22011
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The lookup of versions was failing because a property is no longer being
> passed. Use the UpgradeSummary structure to check for versions. New
> behavior is consistent with older versions of Ambari.
>
> 2017-09-19 11:42:05,742 - Before starting Stack Upgrade, check if tez tarball
> has been copied to HDFS.
> 2017-09-19 11:42:05,742 - Stack version 2.6.0.0 is sufficient to check if
> need to copy tez.tar.gz to HDFS.
> 2017-09-19 11:42:05,742 - Called copy_to_hdfs tarball: tez
> 2017-09-19 11:42:05,743 - Stack Feature Version Info: Cluster Stack=2.6,
> Command Stack=None, Command Version=2.5.3.0-37, Upgrade Direction=upgrade ->
> 2.5.3.0-37
> 2017-09-19 11:42:05,743 - Skipping stack-select on RU_EXECUTE_TASKS because
> it does not exist in the stack-select package structure.
> 2017-09-19 11:42:05,743 - Unable to determine the current version of the
> component for this command; unable to copy the tarball
> 2017-09-19 11:42:05,743 - Cannot copy tez tarball to HDFS because stack
> version could be be determined.
> 2017-09-19 11:42:05,743 - Cannot copy tez tarball to HDFS because stack
> version could be be determined.
> 2017-09-19 11:42:05,744 - Could not copy tarball tez due to a missing or
> incorrect parameter.
> 2017-09-19 11:42:05,744 - Could not copy tarball tez due to a missing or
> incorrect parameter.
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py",
> line 58, in
> TezPreUpgrade().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 327, in execute
> method(env)
> File
> "/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py",
> line 55, in prepare
> raise Fail("Could not copy tez tarball to HDFS.")
> resource_management.core.exceptions.Fail: Could not copy tez tarball to HDFS.
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
> e0dd96de1e
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
> 64e1cc1c94
>
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie.py
> 8bdfe46230
>
>
> Diff: https://reviews.apache.org/r/62454/diff/2/
>
>
> Testing
> ---
>
> Manual EU including Tez succeeded. We have no direct tests of copy_tarballs
> so only manual verification.
>
>
> Thanks,
>
> Nate Cole
>
>
Review Request 62454: Could not copy tez tarball to HDFS during prepare upgrade (EU)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62454/
---
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-22011
https://issues.apache.org/jira/browse/AMBARI-22011
Repository: ambari
Description
---
The lookup of versions was failing because a property is no longer being
passed. Use the UpgradeSummary structure to check for versions. New behavior
is consistent with older versions of Ambari.
2017-09-19 11:42:05,742 - Before starting Stack Upgrade, check if tez tarball
has been copied to HDFS.
2017-09-19 11:42:05,742 - Stack version 2.6.0.0 is sufficient to check if need
to copy tez.tar.gz to HDFS.
2017-09-19 11:42:05,742 - Called copy_to_hdfs tarball: tez
2017-09-19 11:42:05,743 - Stack Feature Version Info: Cluster Stack=2.6,
Command Stack=None, Command Version=2.5.3.0-37, Upgrade Direction=upgrade ->
2.5.3.0-37
2017-09-19 11:42:05,743 - Skipping stack-select on RU_EXECUTE_TASKS because it
does not exist in the stack-select package structure.
2017-09-19 11:42:05,743 - Unable to determine the current version of the
component for this command; unable to copy the tarball
2017-09-19 11:42:05,743 - Cannot copy tez tarball to HDFS because stack version
could be be determined.
2017-09-19 11:42:05,743 - Cannot copy tez tarball to HDFS because stack version
could be be determined.
2017-09-19 11:42:05,744 - Could not copy tarball tez due to a missing or
incorrect parameter.
2017-09-19 11:42:05,744 - Could not copy tarball tez due to a missing or
incorrect parameter.
Traceback (most recent call last):
File
"/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py",
line 58, in
TezPreUpgrade().execute()
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 327, in execute
method(env)
File
"/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py",
line 55, in prepare
raise Fail("Could not copy tez tarball to HDFS.")
resource_management.core.exceptions.Fail: Could not copy tez tarball to HDFS.
Diffs
-
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
e0dd96de1e
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
64e1cc1c94
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie.py
8bdfe46230
Diff: https://reviews.apache.org/r/62454/diff/1/
Testing
---
Manual EU including Tez succeeded. We have no direct tests of copy_tarballs so
only manual verification.
Thanks,
Nate Cole
Re: Review Request 62448: Addition of service component after patching a service still keeps the component at base version
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62448/
---
(Updated Sept. 20, 2017, 3:59 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-22007
https://issues.apache.org/jira/browse/AMBARI-22007
Repository: ambari
Description
---
This bug will affect adding components to hosts where other versions of the
component was already installed. It occurs because Storm was already installed
on the machine you added the Supervisor to and the symlinks were already
created with the older version.
Example:
{code:title=After Patch, Before Adding Supervisor}
/usr/hdp/current/storm-client -> /usr/hdp/2.6.0.3-8/storm
/usr/hdp/current/storm-nimbus -> /usr/hdp/2.6.0.3-8/storm
/usr/hdp/current/storm-supervisor -> /usr/hdp/2.6.0.0-102/storm
{code}
The installation of any Storm component causes the symlink for
{{storm-supervisor}} to also get created. However, when the upgrade was
applied, it didn't upgrade supervisor on this machine since it technically
wasn't installed there (at least as far as Ambari is concerned).
Any other test which follows this pattern will fail until I can fix this.
However, adding a branch new host should work correctly and install the new
version.
Diffs (updated)
-
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
9fbb42bec5
ambari-common/src/main/python/resource_management/libraries/script/script.py
59401669f8
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
135171391f
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
3c15d92948
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
e1da8131ea
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
aa298944fe
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
b812476d31
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
72269f0f7c
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
3ab28e9a5c
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
afd3d1d6a5
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 796d9b2d7a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c0026013c0
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql d78c1c78c6
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 90f1397b94
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql c4bb76314b
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f7aa912ec
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
cd8b499e1e
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
ddff0e9560
ambari-server/src/test/python/TestVersionSelectUtil.py 38798e2b70
Diff: https://reviews.apache.org/r/62448/diff/3/
Changes: https://reviews.apache.org/r/62448/diff/2-3/
Testing (updated)
---
mvn clean test
Patch Upgrade follow by adding components
New cluster deployment via UI using ambiguous repo
Thanks,
Jonathan Hurley
Re: Review Request 62452: Incorrect symlink for storm after patch upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62452/#review185821 --- Ship it! Ship It! - Nate Cole On Sept. 20, 2017, 3:53 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62452/ > --- > > (Updated Sept. 20, 2017, 3:53 p.m.) > > > Review request for Ambari, Nate Cole and Robert Levas. > > > Bugs: AMBARI-22010 > https://issues.apache.org/jira/browse/AMBARI-22010 > > > Repository: ambari > > > Description > --- > > Essentially, Ambari doesn't have a "storm-client", so we have to make sure > that if slaves are on a host without a master, storm-client gets bumped to > the new version as well. > > > Diffs > - > > > ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_packages.json > 930b4ca318 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json > ec35f2b4ab > > > Diff: https://reviews.apache.org/r/62452/diff/1/ > > > Testing > --- > > Manual Storm Upgrade... > > > Thanks, > > Jonathan Hurley > >
Re: Review Request 62448: Addition of service component after patching a service still keeps the component at base version
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62448/#review185820
---
Ship it!
Ship It!
- Nate Cole
On Sept. 20, 2017, 1:20 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62448/
> ---
>
> (Updated Sept. 20, 2017, 1:20 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-22007
> https://issues.apache.org/jira/browse/AMBARI-22007
>
>
> Repository: ambari
>
>
> Description
> ---
>
> This bug will affect adding components to hosts where other versions of the
> component was already installed. It occurs because Storm was already
> installed on the machine you added the Supervisor to and the symlinks were
> already created with the older version.
>
> Example:
> {code:title=After Patch, Before Adding Supervisor}
> /usr/hdp/current/storm-client -> /usr/hdp/2.6.0.3-8/storm
> /usr/hdp/current/storm-nimbus -> /usr/hdp/2.6.0.3-8/storm
> /usr/hdp/current/storm-supervisor -> /usr/hdp/2.6.0.0-102/storm
> {code}
>
> The installation of any Storm component causes the symlink for
> {{storm-supervisor}} to also get created. However, when the upgrade was
> applied, it didn't upgrade supervisor on this machine since it technically
> wasn't installed there (at least as far as Ambari is concerned).
>
> Any other test which follows this pattern will fail until I can fix this.
> However, adding a branch new host should work correctly and install the new
> version.
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> 9fbb42bec5
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py
> 99184d1fbc
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
> 1b04d62408
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> d14b92f465
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
> e1da8131ea
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
> a377350fc0
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
> aa298944fe
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
> b812476d31
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
> 04dfe7a61e
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
> c6a85d0c04
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> 6b78dd6fd0
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql cea350c70b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 6bb903fef7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 543aee167a
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 276cd2a184
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql
> ea2c927b31
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 90014b61aa
>
>
> Diff: https://reviews.apache.org/r/62448/diff/2/
>
>
> Testing
> ---
>
> PENDING...
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Review Request 62452: Incorrect symlink for storm after patch upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62452/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-22010 https://issues.apache.org/jira/browse/AMBARI-22010 Repository: ambari Description --- Essentially, Ambari doesn't have a "storm-client", so we have to make sure that if slaves are on a host without a master, storm-client gets bumped to the new version as well. Diffs - ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_packages.json 930b4ca318 ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json ec35f2b4ab Diff: https://reviews.apache.org/r/62452/diff/1/ Testing --- Manual Storm Upgrade... Thanks, Jonathan Hurley
Review Request 62449: Kerberos identity references should use the "reference" attribute
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62449/
---
Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy,
Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
Bugs: AMBARI-21919
https://issues.apache.org/jira/browse/AMBARI-21919
Repository: ambari
Description
---
Kerberos identity references should use the "reference" attribute rather than
rely on the "name" attribute to indicate the identity descriptor references
some other identity descriptor.
Either method should work on the backend, however the UI appears to not fully
handle the "named" reference properly.
The solution is to change
```
{
"name": "/HDFS/NAMENODE/namenode_nn",
"principal": {
"configuration":
"ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
},
"keytab": {
"configuration":
"ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
}
}
```
by changing the "name" attribute to "reference" and adding a new "name"
reference with a unique name relative to the scope of the identity descriptor.
For example:
```
{
"name":"hdfs_namenode_namenode_nn"
"reference": "/HDFS/NAMENODE/namenode_nn",
"principal": {
"configuration":
"ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
},
"keytab": {
"configuration":
"ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
}
}
```
# NOTE:
My apologies for the large patch. However, most of the changes are to
`kerberos.json` files where there are one or more changes like:
```
"name": "/HDFS/NAMENODE/namenode_nn",
```
to
```
"name": "hdfs_namenode_namenode_nn"
"reference": "/HDFS/NAMENODE/namenode_nn",
```
There are also a few other file changes, related to upgrading to Ambari 2.6.0,
that may be more interesting to review:
-
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
-
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
-
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
- ambari-server/src/main/resources/kerberos_descriptor_schema.json
-
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
Diffs
-
ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
a555bb5b90
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
85d4f69ed8
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
a1d373bad6
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
0b9f2c4c98
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
7e3f449b74
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/kerberos.json
94b1b14f8c
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
a6afda5fbe
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json
4fe4d3272f
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
e136bcf8e6
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/kerberos.json
7d10ccc667
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json
08af720165
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json
4ed6b7871d
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
63e929883c
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/kerberos.json
011921b192
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json
1cf1603d47
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json
b5acf92f3f
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json
c34026ae81
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/kerberos.json
af1130dbd1
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/kerberos.json
b4d0018e8e
ambari-server/src/main/resources/common-services/KAFKA/0.10.0/kerberos.json
b4d0018e8e
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json
247a602c71
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/kerberos.json
6ab76106b6
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/kerberos.json
6ab76106b6
ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/kerberos.json
2d8aa0dc52
Review Request 62448: Addition of service component after patching a service still keeps the component at base version
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62448/
---
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-22007
https://issues.apache.org/jira/browse/AMBARI-22007
Repository: ambari
Description
---
This bug will affect adding components to hosts where other versions of the
component was already installed. It occurs because Storm was already installed
on the machine you added the Supervisor to and the symlinks were already
created with the older version.
Example:
{code:title=After Patch, Before Adding Supervisor}
/usr/hdp/current/storm-client -> /usr/hdp/2.6.0.3-8/storm
/usr/hdp/current/storm-nimbus -> /usr/hdp/2.6.0.3-8/storm
/usr/hdp/current/storm-supervisor -> /usr/hdp/2.6.0.0-102/storm
{code}
The installation of any Storm component causes the symlink for
{{storm-supervisor}} to also get created. However, when the upgrade was
applied, it didn't upgrade supervisor on this machine since it technically
wasn't installed there (at least as far as Ambari is concerned).
Any other test which follows this pattern will fail until I can fix this.
However, adding a branch new host should work correctly and install the new
version.
Diffs
-
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
9fbb42bec5
ambari-common/src/main/python/resource_management/libraries/script/script.py
99184d1fbc
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
1b04d62408
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
d14b92f465
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
e1da8131ea
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
a377350fc0
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
aa298944fe
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
b812476d31
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
04dfe7a61e
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
c6a85d0c04
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
6b78dd6fd0
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql cea350c70b
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 6bb903fef7
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 543aee167a
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 276cd2a184
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql ea2c927b31
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 90014b61aa
Diff: https://reviews.apache.org/r/62448/diff/1/
Testing
---
PENDING...
Thanks,
Jonathan Hurley
Re: Review Request 62440: Log Search UI: implement grouping of service logs by day
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62440/#review185792 --- Ship it! Ship It! - Aleksandr Kovalenko On Сен. 20, 2017, 2:05 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62440/ > --- > > (Updated Сен. 20, 2017, 2:05 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22006 > https://issues.apache.org/jira/browse/AMBARI-22006 > > > Repository: ambari > > > Description > --- > > Service logs in list should be grouped in list by day of occurrence. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html > 888c524 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less > 91d796f > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts > 6d73dcb > ambari-logsearch/ambari-logsearch-web/src/app/mock-data.ts f23139b > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > 2d3f640 > ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.ts > 0f90ba3 > ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json e7126f0 > > > Diff: https://reviews.apache.org/r/62440/diff/1/ > > > Testing > --- > > Executed 86 of 86 SUCCESS (2.25 secs / 2.213 secs) > > > Thanks, > > Andrii Babiichuk > >
Review Request 62440: Log Search UI: implement grouping of service logs by day
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62440/ --- Review request for Ambari and Aleksandr Kovalenko. Bugs: AMBARI-22006 https://issues.apache.org/jira/browse/AMBARI-22006 Repository: ambari Description --- Service logs in list should be grouped in list by day of occurrence. Diffs - ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html 888c524 ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less 91d796f ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts 6d73dcb ambari-logsearch/ambari-logsearch-web/src/app/mock-data.ts f23139b ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 2d3f640 ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.ts 0f90ba3 ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json e7126f0 Diff: https://reviews.apache.org/r/62440/diff/1/ Testing --- Executed 86 of 86 SUCCESS (2.25 secs / 2.213 secs) Thanks, Andrii Babiichuk
Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints
> On Sept. 19, 2017, 4:44 p.m., Jonathan Hurley wrote:
> > Do you plan to include the ability to extract constraint names from tables
> > in this review? It's marked currently as preview...
>
> Dmitro Lisnichenko wrote:
> Yes. It's not a very simple thing, just wanted to make sure that we want
> it (otherwise, current patch would be enough)
Do we have to extract them? Can we drop them all then recreate them with the
right names?
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62413/#review185731
---
On Sept. 19, 2017, 12:17 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62413/
> ---
>
> (Updated Sept. 19, 2017, 12:17 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21998
> https://issues.apache.org/jira/browse/AMBARI-21998
>
>
> Repository: ambari
>
>
> Description
> ---
>
> During Ambari upgrade from 2.2.2 to 2.5 I discovered that some UNIQUE
> constraints are definned without name in older Ambari versions, and then
> altered by name in UpgadeCatalogs/newer DDLs.
>
> For example:
> Ambari 2.2.2
> https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
> {code} UNIQUE (ldap_user, user_name));{code}
> Ambari-2.4.0
> https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
> {code} CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type)){code}
>
> As a result, during upgrade from Ambari 2.2.2 to Ambari 2.5.0, the stale
> unique constraint with default name is not deleted.
> That will reproduce on Postgres for any upgrade path that includes these
> versions.
>
> {code}ambari=# \d+ users
> Table "ambari.users"
> Column |Type | Modifiers
> | Storage | Description
> ---+-++--+-
> user_id | integer | not null
>| plain|
> principal_id | bigint | not null
>| plain|
> ldap_user | integer | not null default 0
>| plain|
> user_name | character varying(255) | not null
>| extended |
> create_time | timestamp without time zone | default now()
>| plain|
> user_password | character varying(255) |
>| extended |
> active| integer | not null default 1
>| plain|
> active_widget_layouts | character varying(1024) | default NULL::character
> varying| extended |
> user_type | character varying(255) | default
> 'LOCAL'::character varying | extended |
> Indexes:
> "users_pkey" PRIMARY KEY, btree (user_id)
> "unq_users_0" UNIQUE, btree (user_name, user_type)
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name)
> Foreign-key constraints:
> "fk_users_principal_id" FOREIGN KEY (principal_id) REFERENCES
> adminprincipal(principal_id)
> Referenced by:
> TABLE "members" CONSTRAINT "fk_members_user_id" FOREIGN KEY (user_id)
> REFERENCES users(user_id)
> Has OIDs: no
>
> {code}
>
> Now we have two constraints here
> "unq_users_0" UNIQUE, btree (user_name, user_type)
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name) <- WRONG
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> afd3d1d6a5
>
>
> Diff: https://reviews.apache.org/r/62413/diff/1/
>
>
> Testing
> ---
>
> tests on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 62351: AMBARI-21910 Ranger Usersync config to support nested group evaluation for LDAP Sync source property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62351/ --- (Updated Sept. 20, 2017, 11:38 a.m.) Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy. Changes --- Removed config update logic from ambari-upgrade and added it during stack upgrade(2.6.x to 2.6.y) Testing done: - Test EU upgrade from 2.6.x to 2.6.y - Unit test report: mvn -DskipPythonTests -Drat.skip -Dtest=RangerUsersyncConfigCalculationTest test [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.ambari.server.serveraction.upgrades.RangerUsersyncConfigCalculationTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.694 s - in org.apache.ambari.server.serveraction.upgrades.RangerUsersyncConfigCalculationTest [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server --- [INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'. [INFO] [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server --- [INFO] skipping execute as per configuraion [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server --- [INFO] Starting audit... Audit done. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:01 min [INFO] Finished at: 2017-09-20T10:44:09+00:00 [INFO] Final Memory: 60M/870M [INFO] Bugs: AMBARI-21910 https://issues.apache.org/jira/browse/AMBARI-21910 Repository: ambari Description --- As part of RANGER-1735, we are supporting nested groups in ranger usersync. For this, introduced one new property "ranger.usersync.ldap.grouphierarchylevels". The value should be an integer with default value as 0. This property should be under Ranger --> Configs --> Ranger User Info --> Group Configs tab. This property can be enabled with a flag labelled as "Sync Nested Groups". 1. Default value for this flag is "No" 2. This flag is always shown under Group Configs (even when "Enable group Sync" is set to "No") 3. If this flag is set to "No", then the value for ranger.usersync.ldap.grouphierarchylevels is hidden and is set to "0". 4. If this flag is set to "Yes", then ranger.usersync.ldap.grouphierarchylevels is shown and allowed to set any integer greater than 0. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerUsersyncConfigCalculation.java PRE-CREATION ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml 627216e ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-ugsync-site.xml a994856 ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json 8068a38 ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 535ac2e ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 74271cc ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerUsersyncConfigCalculationTest.java PRE-CREATION Diff: https://reviews.apache.org/r/62351/diff/2/ Changes: https://reviews.apache.org/r/62351/diff/1-2/ Testing --- Test Fresh Installs. Ambari upgrade with stack 2.6. Unit Test passed for UpgradeCatalog260Test. Thanks, Mugdha Varadkar
Re: Review Request 62433: Log Search UI: implement 'Excluded' filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62433/#review185784 --- Ship it! Ship It! - Andrii Tkach On Sept. 20, 2017, 10:11 a.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62433/ > --- > > (Updated Sept. 20, 2017, 10:11 a.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-22004 > https://issues.apache.org/jira/browse/AMBARI-22004 > > > Repository: ambari > > > Description > --- > > Add logs filtering by excluded string value. On click on the control element, > focus moves to search box where the user can add excluded keywords. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html > a16b205 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.less > 55699b4 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts > c5845b3 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts > 5800190 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts > 22e4fca > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > fb40a1c > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > 644048f > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts > c57c11d > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html > 64e15dc > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less > cccf5d5 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts > 82c455e > > ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts > 380f030 > ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less > 8dba5b3 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts > ff0ee37 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.ts > a8235fa > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > cf82ff6 > > > Diff: https://reviews.apache.org/r/62433/diff/1/ > > > Testing > --- > > Executed 86 of 86 SUCCESS (1.858 secs / 1.832 secs) > > > Thanks, > > Andrii Babiichuk > >
Review Request 62433: Log Search UI: implement 'Excluded' filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62433/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-22004 https://issues.apache.org/jira/browse/AMBARI-22004 Repository: ambari Description --- Add logs filtering by excluded string value. On click on the control element, focus moves to search box where the user can add excluded keywords. Diffs - ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html a16b205 ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.less 55699b4 ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts c5845b3 ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts 5800190 ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts 22e4fca ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html fb40a1c ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts 644048f ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts c57c11d ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html 64e15dc ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less cccf5d5 ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts 82c455e ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts 380f030 ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less 8dba5b3 ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts ff0ee37 ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.ts a8235fa ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts cf82ff6 Diff: https://reviews.apache.org/r/62433/diff/1/ Testing --- Executed 86 of 86 SUCCESS (1.858 secs / 1.832 secs) Thanks, Andrii Babiichuk
Re: Review Request 62429: Ambari Unit Tests Fail In trunk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62429/#review185780
---
Ship it!
Ship It!
- Pallav Kulshreshtha
On Sept. 20, 2017, 7:09 a.m., Prabhjyot Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62429/
> ---
>
> (Updated Sept. 20, 2017, 7:09 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya,
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
>
>
> Bugs: AMBARI-22002
> https://issues.apache.org/jira/browse/AMBARI-22002
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The following unit tests are failing trunk builds:
> https://builds.apache.org/job/Ambari-trunk-Commit/8095/consoleFull
>
> OK
> --
> Failed tests:
> ERROR: test_configure_default (test_zeppelin_master.TestZeppelinMaster)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-common/src/test/python/mock/mock.py",
> line 1199, in patched
> return func(*args, **keywargs)
> File
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py",
> line 145, in test_configure_default
> target = RMFTestCase.TARGET_COMMON_SERVICES
> File
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
> line 126, in executeScript
> raise RuntimeError("Cannot load class %s from %s: %s" % (classname,
> norm_path, err.message))
>
>
> Diffs
> -
>
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py
> 9a28e686f5
>
>
> Diff: https://reviews.apache.org/r/62429/diff/1/
>
>
> Testing
> ---
>
> Tested locally
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 62429: Ambari Unit Tests Fail In trunk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62429/#review185779
---
Ship it!
Ship It!
- venkat sairam
On Sept. 20, 2017, 7:09 a.m., Prabhjyot Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62429/
> ---
>
> (Updated Sept. 20, 2017, 7:09 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya,
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
>
>
> Bugs: AMBARI-22002
> https://issues.apache.org/jira/browse/AMBARI-22002
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The following unit tests are failing trunk builds:
> https://builds.apache.org/job/Ambari-trunk-Commit/8095/consoleFull
>
> OK
> --
> Failed tests:
> ERROR: test_configure_default (test_zeppelin_master.TestZeppelinMaster)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-common/src/test/python/mock/mock.py",
> line 1199, in patched
> return func(*args, **keywargs)
> File
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py",
> line 145, in test_configure_default
> target = RMFTestCase.TARGET_COMMON_SERVICES
> File
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
> line 126, in executeScript
> raise RuntimeError("Cannot load class %s from %s: %s" % (classname,
> norm_path, err.message))
>
>
> Diffs
> -
>
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py
> 9a28e686f5
>
>
> Diff: https://reviews.apache.org/r/62429/diff/1/
>
>
> Testing
> ---
>
> Tested locally
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 62431: Ambari schema upgrade failure as views destination path dir already exists
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62431/#review185777 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 20, 2017, 8:15 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62431/ > --- > > (Updated Вер. 20, 2017, 8:15 до полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22003 > https://issues.apache.org/jira/browse/AMBARI-22003 > > > Repository: ambari > > > Description > --- > > Upgrade path from 2.5.10 to 2.6.0.0-107 > Error seen from the output of "ambari-server upgrade --verbose" > > > > > [ERROR STREAM] > > Traceback (most recent call last): > File "/usr/sbin/ambari-server.py", line 950, in > mainBody() > File "/usr/sbin/ambari-server.py", line 920, in mainBody > main(options, args, parser) > File "/usr/sbin/ambari-server.py", line 872, in main > action_obj.execute() > File "/usr/sbin/ambari-server.py", line 78, in execute > self.fn(*self.args, **self.kwargs) > File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", > line 271, in upgrade > shutil.move(file, root_views_dir) > File "/usr/lib64/python2.6/shutil.py", line 250, in move > raise Error, "Destination path '%s' already exists" % real_dst > shutil.Error: Destination path > '/var/lib/ambari-server/resources/views/work/../work' already exists > > [EXIT CODE] > > > Diffs > - > > ambari-server/src/main/python/ambari_server/serverUpgrade.py a10841d > > > Diff: https://reviews.apache.org/r/62431/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Review Request 62431: Ambari schema upgrade failure as views destination path dir already exists
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62431/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-22003 https://issues.apache.org/jira/browse/AMBARI-22003 Repository: ambari Description --- Upgrade path from 2.5.10 to 2.6.0.0-107 Error seen from the output of "ambari-server upgrade --verbose" [ERROR STREAM] Traceback (most recent call last): File "/usr/sbin/ambari-server.py", line 950, in mainBody() File "/usr/sbin/ambari-server.py", line 920, in mainBody main(options, args, parser) File "/usr/sbin/ambari-server.py", line 872, in main action_obj.execute() File "/usr/sbin/ambari-server.py", line 78, in execute self.fn(*self.args, **self.kwargs) File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", line 271, in upgrade shutil.move(file, root_views_dir) File "/usr/lib64/python2.6/shutil.py", line 250, in move raise Error, "Destination path '%s' already exists" % real_dst shutil.Error: Destination path '/var/lib/ambari-server/resources/views/work/../work' already exists [EXIT CODE] Diffs - ambari-server/src/main/python/ambari_server/serverUpgrade.py a10841d Diff: https://reviews.apache.org/r/62431/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk
Re: Review Request 62429: Ambari Unit Tests Fail In trunk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62429/
---
(Updated Sept. 20, 2017, 12:39 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit
Choudhary, Sumit Mohanty, and venkat sairam.
Bugs: AMBARI-22002
https://issues.apache.org/jira/browse/AMBARI-22002
Repository: ambari
Description (updated)
---
The following unit tests are failing trunk builds:
https://builds.apache.org/job/Ambari-trunk-Commit/8095/consoleFull
OK
--
Failed tests:
ERROR: test_configure_default (test_zeppelin_master.TestZeppelinMaster)
--
Traceback (most recent call last):
File
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-common/src/test/python/mock/mock.py",
line 1199, in patched
return func(*args, **keywargs)
File
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py",
line 145, in test_configure_default
target = RMFTestCase.TARGET_COMMON_SERVICES
File
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
line 126, in executeScript
raise RuntimeError("Cannot load class %s from %s: %s" % (classname,
norm_path, err.message))
Diffs
-
ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py
9a28e686f5
Diff: https://reviews.apache.org/r/62429/diff/1/
Testing
---
Tested locally
Thanks,
Prabhjyot Singh
Review Request 62429: Ambari Unit Tests Fail In trunk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62429/ --- Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam. Bugs: AMBARI-22002 https://issues.apache.org/jira/browse/AMBARI-22002 Repository: ambari Description --- The following unit tests are failing trunk builds: https://builds.apache.org/job/Ambari-trunk-Commit/8095/consoleFull RuntimeError: Cannot load class Master from ZEPPELIN/0.6.0.2.5/package/scripts/master.py: Diffs - ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 9a28e686f5 Diff: https://reviews.apache.org/r/62429/diff/1/ Testing --- Tested locally Thanks, Prabhjyot Singh
