Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187159
---




ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py
Line 2318 (original)


Can't we move the test code to 
ambari-server/src/test/python/common-services/AMBARI_METRICS/test_service_advisor.py?

See 
https://github.com/apache/ambari/blob/trunk/ambari-server/src/test/python/common-services/LOGSEARCH/test_service_advisor.py


- Jayush Luniya


On Oct. 4, 2017, 9:03 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Oct. 4, 2017, 9:03 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 5307176 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 2dc1738 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 65b23b0 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> d6b572e 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/
---

(Updated Жов. 4, 2017, 9:03 після полудня)


Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
Radhakrishnan, and Sid Wagle.


Bugs: AMBARI-22124
https://issues.apache.org/jira/browse/AMBARI-22124


Repository: ambari


Description
---

We need to move AMS specific logic in the stack advisors to service advisor.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
 a2e31cc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
5307176 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
2dc1738 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
65b23b0 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py d6b572e 


Diff: https://reviews.apache.org/r/62756/diff/3/

Changes: https://reviews.apache.org/r/62756/diff/2-3/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 62778: AMBARI-22137 - Different stack versions should be able to link to different extension versions

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62778/
---

Review request for Ambari, Di Li, Jonathan Hurley, and Jayush Luniya.


Bugs: AMBARI-22137
https://issues.apache.org/jira/browse/AMBARI-22137


Repository: ambari


Description
---

Currently if you have extension version 0.1 linked to HDP 2.5, you can't link 
extension version 0.2 to HDP 2.6.

Attempting to make that link will fail with an exception stating that the 
services included in extension version 0.2 are already in HDP 2.6 (inherited 
from HDP 2.5 via the 0.1 version of the extension).


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
 2dd6f12 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionHelper.java 
86e532a 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
6dc2b93 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java
 20c8f40 
  ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml 0d37b3e 
  ambari-server/src/test/resources/extensions/EXT/0.3/metainfo.xml d827314 
  ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/repos/repoinfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HBASE/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/configuration/global.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/configuration/hadoop-env.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/configuration/hbase-site.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/configuration/hdfs-log4j.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/configuration/hdfs-site.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/package/dummy-script.py
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HIVE/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/MAPREDUCE/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/ZOOKEEPER/metainfo.xml
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62778/diff/1/


Testing
---

Manual testing with different extension and stack versions.

mvn test -DskipPythonTests 
-Dtest=StackManagerCommonServicesTest,StackManagerTest,StackManagerMiscTest,StackManagerExtensionTest


Thanks,

Tim Thorpe

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Jayush Luniya]

> On Oct. 4, 2017, 12:54 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
> > Lines 21 (patched)
> > 
> >
> > Can we also remove the duplicate code in HDP stack advisors?
> 
> Vitalyi Brodetskyi wrote:
> Which code i should remove? If you are talking about all AMS methods 
> (recommendations and validations), i don't think we can remove them. As of 
> now, only HDP 3.0 work with service advisors, all other stacks work with 
> stack advisor.

No support for service advisor was add a while back. We already have LOGSEARCH, 
AMBARI_INFRA, NIFI that define service advisors. 

See 
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/service_advisor.py

The default stack advisor has installation hooks to call individual service 
advisors
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/stack_advisor.py#L765

Can you try and see?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187037
---


On Oct. 4, 2017, 8:26 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Oct. 4, 2017, 8:26 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

[Attila Doroszlai]

> On Oct. 4, 2017, 5:18 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
> > Lines 42-43 (original), 42-43 (patched)
> > 
> >
> > This type of change from a set to a dictionary is very risky at this 
> > point for 2.6.  Is there anyway to just fix the apt code for this?
> > 
> > In addition, make sure you run this through CI in order to make sure 
> > acceptance tests won't go crazy.

I doubt this breaks anything.  It seems `use_repos` has been "dead code" for at 
least 2 years: it was broken on Debian/Ubuntu since May 2015 and nobody 
noticed, until AMBARI-22076 introduced code that started using it.

We could probably check the OS in the OS-agnostic code and pass different sets 
in each case.  Sounds like an ugly hack to me.


> On Oct. 4, 2017, 5:18 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/core/providers/package/apt.py
> > Lines 351 (patched)
> > 
> >
> > This % syntax is old, we typically use string.format()

This line is old code, just moved around a bit.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62764/#review187101
---


On Oct. 4, 2017, 4:32 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62764/
> ---
> 
> (Updated Oct. 4, 2017, 4:32 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22127
> https://issues.apache.org/jira/browse/AMBARI-22127
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to pass both repo IDs and repo file names via `use_repos`, because 
> Debian/Ubuntu selects specific repos by file name, while RedHat/SuSE by repo 
> ID.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 
> 49e3adf6782021977ff3edce850da35e3adc7116 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
>  94047571b5113716ee041e890fea559b4ce263ee 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/apt.py
>  f6a5538a30cf86eb4125ff088a1a8ca24c5adece 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/choco.py
>  db552964279f509de90d2fde884bfc0fea12f7b0 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
>  a4a55da7c9c5e9ac554d91edd19e9cb668615671 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
>  5b8e5ab94091bf181e97defd6a13dea4e3a46863 
>   
> ambari-common/src/main/python/resource_management/core/resources/packaging.py 
> e3adc30f46abd3f33670f817421d88270b3e7ade 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  f1074ee7b3748cfedb3e1a813be52df894cff97f 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> dcf354447756d2e1c826feb8515cfe3b9711f19d 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
> 0f303bee541ea3ac06fadb67eb44f5aab97fa1d5 
> 
> 
> Diff: https://reviews.apache.org/r/62764/diff/1/
> 
> 
> Testing
> ---
> 
> Tested package installation (both pre-upgrade "Install Version" and regular 
> "Add Service") on Debian 7.6 and CentOS 6.4.
> 
> Unit tests pass (both branch-2.6 and trunk):
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -DskipSurefireTests test
> ...
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> ...
> Ran 453 tests in 137.865s
> 
> OK
> ...
> [INFO] Ambari Server .. SUCCESS [01:28 
> min]
> [INFO] Ambari Agent ... SUCCESS [02:21 
> min]
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62622: AMBARI-22016 - changeToSecureUid.sh might collide with existing user if it is not a local user

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62622/#review187105
---


Ship it!




Ship It!

- Nate Cole


On Sept. 27, 2017, 1:22 p.m., Aman Poonia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62622/
> ---
> 
> (Updated Sept. 27, 2017, 1:22 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22016
> https://issues.apache.org/jira/browse/AMBARI-22016
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> changeToSecureUid.sh might collide with existing user if it is not a local 
> user
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/files/changeToSecureUid.sh
>  a6b8b77dae 
> 
> 
> Diff: https://reviews.apache.org/r/62622/diff/1/
> 
> 
> Testing
> ---
> 
> tested on centos 6 and 7 and on ubuntu
> 
> 
> Thanks,
> 
> Aman Poonia
> 
>

Re: Review Request 62656: When the cluster is kerberoed, the config's group of hbase and kafka is root, Maybe should be user.group be better.

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62656/#review187103
---



Are there any tests covering this?

- Nate Cole


On Sept. 28, 2017, 5:05 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62656/
> ---
> 
> (Updated Sept. 28, 2017, 5:05 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Alejandro Fernandez, Denys 
> Buzhor, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Richard 
> Zang, Srimanth Gunturi, Sid Wagle, Vitalyi Brodetskyi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22078
> https://issues.apache.org/jira/browse/AMBARI-22078
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When the cluster is kerberoed, the config's group is root,Maybe should be 
> user.group be better.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  cec6b2a 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase.py
>  fced4fc 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/kafka.py
>  3f9d109 
> 
> 
> Diff: https://reviews.apache.org/r/62656/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 62656: When the cluster is kerberoed, the config's group of hbase and kafka is root, Maybe should be user.group be better.

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62656/#review187104
---


Ship it!




Ship It!

- Nate Cole


On Sept. 28, 2017, 5:05 a.m., zhangxiaolu zhangxiaolu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62656/
> ---
> 
> (Updated Sept. 28, 2017, 5:05 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Alejandro Fernandez, Denys 
> Buzhor, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Richard 
> Zang, Srimanth Gunturi, Sid Wagle, Vitalyi Brodetskyi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22078
> https://issues.apache.org/jira/browse/AMBARI-22078
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When the cluster is kerberoed, the config's group is root,Maybe should be 
> user.group be better.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  cec6b2a 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/scripts/hbase.py
>  fced4fc 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/kafka.py
>  3f9d109 
> 
> 
> Diff: https://reviews.apache.org/r/62656/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> zhangxiaolu zhangxiaolu
> 
>

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62764/#review187101
---




ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
Lines 42-43 (original), 42-43 (patched)


This type of change from a set to a dictionary is very risky at this point 
for 2.6.  Is there anyway to just fix the apt code for this?

In addition, make sure you run this through CI in order to make sure 
acceptance tests won't go crazy.



ambari-common/src/main/python/resource_management/core/providers/package/apt.py
Lines 351 (patched)


This % syntax is old, we typically use string.format()


- Nate Cole


On Oct. 4, 2017, 10:32 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62764/
> ---
> 
> (Updated Oct. 4, 2017, 10:32 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22127
> https://issues.apache.org/jira/browse/AMBARI-22127
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to pass both repo IDs and repo file names via `use_repos`, because 
> Debian/Ubuntu selects specific repos by file name, while RedHat/SuSE by repo 
> ID.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 
> 49e3adf6782021977ff3edce850da35e3adc7116 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
>  94047571b5113716ee041e890fea559b4ce263ee 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/apt.py
>  f6a5538a30cf86eb4125ff088a1a8ca24c5adece 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/choco.py
>  db552964279f509de90d2fde884bfc0fea12f7b0 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
>  a4a55da7c9c5e9ac554d91edd19e9cb668615671 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
>  5b8e5ab94091bf181e97defd6a13dea4e3a46863 
>   
> ambari-common/src/main/python/resource_management/core/resources/packaging.py 
> e3adc30f46abd3f33670f817421d88270b3e7ade 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  f1074ee7b3748cfedb3e1a813be52df894cff97f 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> dcf354447756d2e1c826feb8515cfe3b9711f19d 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
> 0f303bee541ea3ac06fadb67eb44f5aab97fa1d5 
> 
> 
> Diff: https://reviews.apache.org/r/62764/diff/1/
> 
> 
> Testing
> ---
> 
> Tested package installation (both pre-upgrade "Install Version" and regular 
> "Add Service") on Debian 7.6 and CentOS 6.4.
> 
> Unit tests pass (both branch-2.6 and trunk):
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -DskipSurefireTests test
> ...
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> ...
> Ran 453 tests in 137.865s
> 
> OK
> ...
> [INFO] Ambari Server .. SUCCESS [01:28 
> min]
> [INFO] Ambari Agent ... SUCCESS [02:21 
> min]
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62744: Alerts for OneFS mpack

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/#review187100
---



As part of this review, I think we need to change how the 
AmbariServerAlertService creates its threadpool for the AlertRunnables:


  /**
   * The executor to use to run all {@link Runnable} alert classes.
   */
  private final ScheduledExecutorService m_scheduledExecutorService = 
Executors.newScheduledThreadPool(3);


Can you convert this into a configuration property? With the ability to add 
Server-side alerts, we need this thread pool to be bigger.

- Jonathan Hurley


On Oct. 4, 2017, 4:16 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62744/
> ---
> 
> (Updated Oct. 4, 2017, 4:16 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22115
> https://issues.apache.org/jira/browse/AMBARI-22115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is part of AMBARI-22115. We need to define alerts on JMX metrics which 
> are pulled from a cluster that is not necessarily managed by Ambari. 
> Therefore alerts can't run on ambari-agent host. I introduced a new SERVER 
> type alert called JmxServerSideAlert that can pull the jmx metrics from a 
> arbitrary url. The url comes from the alerts.json and it may contain 
> placeholders like ${hdfs-site/dfs.namenode.http-address}. This works 
> similarly than the Python class MetricAlert.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
>  81d72fb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 5d2ecc6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  93801d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
>  11eee05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  4aeba45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
>  c58867a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62744/diff/4/
> 
> 
> Testing
> ---
> 
> Used the following alerts.json to test it
> 
> {   
>   "ONEFS":{
> "service": [
>   { 
> "name": "onefs_namenode_cpu",
> "label": "OneFS NameNode Host CPU Utilization",
> "description": "This host-level alert is triggered if CPU utilization 
> of the NameNode exceeds certain warning and critical thresholds. It checks 
> the NameNode JMX Servlet for the SystemCPULoad property. The threshold values 
> are in percent.",
> "interval": 1,
> "help_url": 
> "https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat";,
> "scope": "HOST",
> "enabled": true,
> "source": {
>   "type": "SERVER",
>   "class": "org.apache.ambari.server.alerts.JmxServerSideAlert",
>   "uri": {
> "http": "${hdfs-site/dfs.namenode.http-address}",
> "https": "${hdfs-site/dfs.namenode.https-address}",
> "https_property": "${hdfs-site/dfs.http.policy}",
> "https_property_value": "HTTPS_ONLY",
> "connection_timeout": 5.0
>   },
>   "reporting": {
> "ok": {
>   "text": "{1} CPU, load {0,number,percent}"
> },
> "warning": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 5
> },
> "critical": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 20
> },
> "units" : "%",
> "type": "PERCENT"
>},
>"jmx": {
>  "property_list": [
>   "java.lang:type=OperatingSystem/SystemCpuLoad",
>   "java.lang:type=OperatingSystem/AvailableProcessors"
>  ]
>}
>   }
>   }
> ]
>   }
> }
> 1,1   Top
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62764/#review187097
---



As part of this review, I think we need to change how the 
AmbariServerAlertService creates its threadpool for the AlertRunnables:

```
  /**
   * The executor to use to run all {@link Runnable} alert classes.
   */
  private final ScheduledExecutorService m_scheduledExecutorService = 
Executors.newScheduledThreadPool(3);
```

Can you convert this into a configuration property?

- Jonathan Hurley


On Oct. 4, 2017, 10:32 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62764/
> ---
> 
> (Updated Oct. 4, 2017, 10:32 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22127
> https://issues.apache.org/jira/browse/AMBARI-22127
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to pass both repo IDs and repo file names via `use_repos`, because 
> Debian/Ubuntu selects specific repos by file name, while RedHat/SuSE by repo 
> ID.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 
> 49e3adf6782021977ff3edce850da35e3adc7116 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
>  94047571b5113716ee041e890fea559b4ce263ee 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/apt.py
>  f6a5538a30cf86eb4125ff088a1a8ca24c5adece 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/choco.py
>  db552964279f509de90d2fde884bfc0fea12f7b0 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
>  a4a55da7c9c5e9ac554d91edd19e9cb668615671 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
>  5b8e5ab94091bf181e97defd6a13dea4e3a46863 
>   
> ambari-common/src/main/python/resource_management/core/resources/packaging.py 
> e3adc30f46abd3f33670f817421d88270b3e7ade 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  f1074ee7b3748cfedb3e1a813be52df894cff97f 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> dcf354447756d2e1c826feb8515cfe3b9711f19d 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
> 0f303bee541ea3ac06fadb67eb44f5aab97fa1d5 
> 
> 
> Diff: https://reviews.apache.org/r/62764/diff/1/
> 
> 
> Testing
> ---
> 
> Tested package installation (both pre-upgrade "Install Version" and regular 
> "Add Service") on Debian 7.6 and CentOS 6.4.
> 
> Unit tests pass (both branch-2.6 and trunk):
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -DskipSurefireTests test
> ...
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> ...
> Ran 453 tests in 137.865s
> 
> OK
> ...
> [INFO] Ambari Server .. SUCCESS [01:28 
> min]
> [INFO] Ambari Agent ... SUCCESS [02:21 
> min]
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

[Jonathan Hurley]

> On Oct. 4, 2017, 11:06 a.m., Jonathan Hurley wrote:
> > As part of this review, I think we need to change how the 
> > AmbariServerAlertService creates its threadpool for the AlertRunnables:
> > 
> > ```
> >   /**
> >* The executor to use to run all {@link Runnable} alert classes.
> >*/
> >   private final ScheduledExecutorService m_scheduledExecutorService = 
> > Executors.newScheduledThreadPool(3);
> > ```
> > 
> > Can you convert this into a configuration property?

OMG - wrong review - Sorry! Ignore.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62764/#review187097
---


On Oct. 4, 2017, 10:32 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62764/
> ---
> 
> (Updated Oct. 4, 2017, 10:32 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22127
> https://issues.apache.org/jira/browse/AMBARI-22127
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to pass both repo IDs and repo file names via `use_repos`, because 
> Debian/Ubuntu selects specific repos by file name, while RedHat/SuSE by repo 
> ID.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 
> 49e3adf6782021977ff3edce850da35e3adc7116 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
>  94047571b5113716ee041e890fea559b4ce263ee 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/apt.py
>  f6a5538a30cf86eb4125ff088a1a8ca24c5adece 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/choco.py
>  db552964279f509de90d2fde884bfc0fea12f7b0 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
>  a4a55da7c9c5e9ac554d91edd19e9cb668615671 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
>  5b8e5ab94091bf181e97defd6a13dea4e3a46863 
>   
> ambari-common/src/main/python/resource_management/core/resources/packaging.py 
> e3adc30f46abd3f33670f817421d88270b3e7ade 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  f1074ee7b3748cfedb3e1a813be52df894cff97f 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> dcf354447756d2e1c826feb8515cfe3b9711f19d 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
> 0f303bee541ea3ac06fadb67eb44f5aab97fa1d5 
> 
> 
> Diff: https://reviews.apache.org/r/62764/diff/1/
> 
> 
> Testing
> ---
> 
> Tested package installation (both pre-upgrade "Install Version" and regular 
> "Add Service") on Debian 7.6 and CentOS 6.4.
> 
> Unit tests pass (both branch-2.6 and trunk):
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -DskipSurefireTests test
> ...
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> ...
> Ran 453 tests in 137.865s
> 
> OK
> ...
> [INFO] Ambari Server .. SUCCESS [01:28 
> min]
> [INFO] Ambari Agent ... SUCCESS [02:21 
> min]
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187096
---


Ship it!




Ship It!

- Nate Cole


On Oct. 4, 2017, 9:19 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 4, 2017, 9:19 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 395687da23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62764/
---

(Updated Oct. 4, 2017, 4:32 p.m.)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
Hurley, Nate Cole, and Sebastian Toader.


Bugs: AMBARI-22127
https://issues.apache.org/jira/browse/AMBARI-22127


Repository: ambari


Description
---

Need to pass both repo IDs and repo file names via `use_repos`, because 
Debian/Ubuntu selects specific repos by file name, while RedHat/SuSE by repo ID.


Diffs
-

  ambari-agent/src/test/python/resource_management/TestPackageResource.py 
49e3adf6782021977ff3edce850da35e3adc7116 
  
ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
 94047571b5113716ee041e890fea559b4ce263ee 
  
ambari-common/src/main/python/resource_management/core/providers/package/apt.py 
f6a5538a30cf86eb4125ff088a1a8ca24c5adece 
  
ambari-common/src/main/python/resource_management/core/providers/package/choco.py
 db552964279f509de90d2fde884bfc0fea12f7b0 
  
ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
 a4a55da7c9c5e9ac554d91edd19e9cb668615671 
  
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
 5b8e5ab94091bf181e97defd6a13dea4e3a46863 
  ambari-common/src/main/python/resource_management/core/resources/packaging.py 
e3adc30f46abd3f33670f817421d88270b3e7ade 
  
ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
 f1074ee7b3748cfedb3e1a813be52df894cff97f 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
dcf354447756d2e1c826feb8515cfe3b9711f19d 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
0f303bee541ea3ac06fadb67eb44f5aab97fa1d5 


Diff: https://reviews.apache.org/r/62764/diff/1/


Testing (updated)
---

Tested package installation (both pre-upgrade "Install Version" and regular 
"Add Service") on Debian 7.6 and CentOS 6.4.

Unit tests pass (both branch-2.6 and trunk):

```
$ mvn -am -pl ambari-agent,ambari-server -DskipSurefireTests test
...
Total run:1192
Total errors:0
Total failures:0
OK
...
Ran 453 tests in 137.865s

OK
...
[INFO] Ambari Server .. SUCCESS [01:28 min]
[INFO] Ambari Agent ... SUCCESS [02:21 min]
```


Thanks,

Attila Doroszlai

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

[Robert Levas]

> On Oct. 3, 2017, 7:57 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 2775-2780 (patched)
> > 
> >
> > Can you also generate the new markdown file and include it in this 
> > patch?

I always forget to do this.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187029
---


On Oct. 4, 2017, 9:19 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 4, 2017, 9:19 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 395687da23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/
---

(Updated Oct. 4, 2017, 9:19 a.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian 
Toader.


Changes
---

Regenerated the configiration index.md file.


Bugs: AMBARI-21220
https://issues.apache.org/jira/browse/AMBARI-21220


Repository: ambari


Description
---

Update Local Authentication process to work with improved user management 
facility


Diffs (updated)
-

  ambari-server/docs/configuration/index.md 395687da23 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 3099bc0857 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 21ab757e1c 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
 2a894374d1 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
 2a2e397439 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 2dedc9e6ca 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
 fea7fb978e 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
 fb4ebf93e4 


Diff: https://reviews.apache.org/r/62757/diff/2/

Changes: https://reviews.apache.org/r/62757/diff/1-2/


Testing
---

Manually tested

Local test results: PASSED


Thanks,

Robert Levas

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62754/#review187088
---


Ship it!




Ship It!

- Nate Cole


On Oct. 3, 2017, 5:11 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62754/
> ---
> 
> (Updated Oct. 3, 2017, 5:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22123
> https://issues.apache.org/jira/browse/AMBARI-22123
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Essentially, the symlinking was doing a quick-exit if the 
> /etc//conf directory already existed. However, it might have been 
> created by another RPM and not the component we actually care about.
> 
> The refactor here did two things:
> - Invokes conf-select on the necessary packages
> - Combined most of the logic between conf_select.select(...) and 
> conf_select.convert_conf_directories_to_symlinks(...)
> - Removed legacy code from back in the pre-HDP 2.3 days
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  86821bf47a 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 3ace3b1570 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py
>  0727970adb 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py
>  0727970adb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
>  20fd48de15 
>   ambari-server/src/test/python/TestAmbariServer.py 5db79137ee 
>   ambari-server/src/test/python/TestMpacks.py fd30bf6f88 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py
>  92f5011978 
>   ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 
> 2eeec46b4a 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py
>  3d9bfd7c3e 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py
>  b88f3858a7 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py
>  31b083bd0d 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py
>  2df001cf21 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py
>  34687c453b 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py
>  4ec6aa788f 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py
>  34c683ab2f 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py
>  424157b128 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py
>  b235cad164 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py
>  71c7bc17a2 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py
>  4d65a404a2 
> 
> 
> Diff: https://reviews.apache.org/r/62754/diff/3/
> 
> 
> Testing
> ---
> 
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 57.162 s
> [INFO] Finished at: 2017-10-03T23:04:47-04:00
> [INFO] Final Memory: 19M/491M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62771: Agent UT fail on trunk

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62771/#review187087
---


Ship it!




Ship It!

- Dmytro Sen


On Oct. 4, 2017, 12:55 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62771/
> ---
> 
> (Updated Oct. 4, 2017, 12:55 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22130
> https://issues.apache.org/jira/browse/AMBARI-22130
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Traceback (most recent call last):
>   File "unitTests.py", line 188, in 
> main()
>   File "unitTests.py", line 142, in main
> suite = all_tests_suite(test_mask)
>   File "unitTests.py", line 130, in all_tests_suite
> suite = unittest.TestLoader().loadTestsFromNames(tests_list)
>   File "/usr/lib/python2.7/unittest/loader.py", line 130, in 
> loadTestsFromNames
> suites = [self.loadTestsFromName(name, module) for name in names]
>   File "/usr/lib/python2.7/unittest/loader.py", line 91, in 
> loadTestsFromName
> module = __import__('.'.join(parts_copy))
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-agent/src/test/python/ambari_agent/TestSecurity.py",
>  line 38, in 
> from ambari_agent import ProcessHelper, main
> ImportError: cannot import name ProcessHelper
> 
> Traceback (most recent call last):
>   File "unitTests.py", line 188, in 
> main()
>   File "unitTests.py", line 142, in main
> suite = all_tests_suite(test_mask)
>   File "unitTests.py", line 130, in all_tests_suite
> suite = unittest.TestLoader().loadTestsFromNames(tests_list)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/loader.py",
>  line 130, in loadTestsFromNames
> suites = [self.loadTestsFromName(name, module) for name in names]
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/loader.py",
>  line 91, in loadTestsFromName
> module = __import__('.'.join(parts_copy))
>   File "ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py", 
> line 28, in 
> from ambari_agent import StatusCheck
> ImportError: cannot import name StatusCheck
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py 930c8458a9 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 504ca08e07 
>   ambari-agent/src/test/python/ambari_agent/TestSecurity.py c9a7fbe865 
> 
> 
> Diff: https://reviews.apache.org/r/62771/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 62771: Agent UT fail on trunk

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62771/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-22130
https://issues.apache.org/jira/browse/AMBARI-22130


Repository: ambari


Description
---

Traceback (most recent call last):
  File "unitTests.py", line 188, in 
main()
  File "unitTests.py", line 142, in main
suite = all_tests_suite(test_mask)
  File "unitTests.py", line 130, in all_tests_suite
suite = unittest.TestLoader().loadTestsFromNames(tests_list)
  File "/usr/lib/python2.7/unittest/loader.py", line 130, in 
loadTestsFromNames
suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib/python2.7/unittest/loader.py", line 91, in 
loadTestsFromName
module = __import__('.'.join(parts_copy))
  File 
"/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-agent/src/test/python/ambari_agent/TestSecurity.py",
 line 38, in 
from ambari_agent import ProcessHelper, main
ImportError: cannot import name ProcessHelper

Traceback (most recent call last):
  File "unitTests.py", line 188, in 
main()
  File "unitTests.py", line 142, in main
suite = all_tests_suite(test_mask)
  File "unitTests.py", line 130, in all_tests_suite
suite = unittest.TestLoader().loadTestsFromNames(tests_list)
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/loader.py",
 line 130, in loadTestsFromNames
suites = [self.loadTestsFromName(name, module) for name in names]
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/loader.py",
 line 91, in loadTestsFromName
module = __import__('.'.join(parts_copy))
  File "ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py", line 
28, in 
from ambari_agent import StatusCheck
ImportError: cannot import name StatusCheck


Diffs
-

  ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py 930c8458a9 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 504ca08e07 
  ambari-agent/src/test/python/ambari_agent/TestSecurity.py c9a7fbe865 


Diff: https://reviews.apache.org/r/62771/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62770: Log Search UI: reorganize classes structure

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62770/#review187085
---


Ship it!




Ship It!

- Andrii Tkach


On Oct. 4, 2017, 12:44 p.m., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62770/
> ---
> 
> (Updated Oct. 4, 2017, 12:44 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-22129
> https://issues.apache.org/jira/browse/AMBARI-22129
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Locate model classes and other ones in one directory to avoid confusion, 
> since model classes can be used not only in storage-related code.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.class.ts
>  d3d7d95 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.class.ts
>  dee5d98 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts 
> 1aaaecc 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-settings.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log-field.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/bar-graph.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/common-entry.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/count.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/filter.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/graph.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log-field.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log-field.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/solr-collection-state.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/user-config.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts
>  3727abb 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.class.ts
>  83c3261 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.spec.ts
>  efa2459 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts
>  2e2113f 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.class.ts
>  864b689 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.class.ts
>  da05cee 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.class.ts
>  15c05fb 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts
>  43d79f8 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/c

Re: Review Request 62770: Log Search UI: reorganize classes structure

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62770/#review187086
---


Ship it!




Ship It!

- Andrii Tkach


On Oct. 4, 2017, 12:44 p.m., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62770/
> ---
> 
> (Updated Oct. 4, 2017, 12:44 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-22129
> https://issues.apache.org/jira/browse/AMBARI-22129
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Locate model classes and other ones in one directory to avoid confusion, 
> since model classes can be used not only in storage-related code.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.class.ts
>  d3d7d95 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.class.ts
>  dee5d98 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts 
> 1aaaecc 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-settings.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log-field.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/bar-graph.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/common-entry.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/count.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/filter.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/graph.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log-field.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log-field.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/models/solr-collection-state.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/user-config.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts
>  3727abb 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.class.ts
>  83c3261 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.spec.ts
>  efa2459 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts
>  2e2113f 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.class.ts
>  864b689 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.class.ts
>  da05cee 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.class.ts
>  15c05fb 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts
>  43d79f8 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/c

Review Request 62770: Log Search UI: reorganize classes structure

[Andrii Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62770/
---

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-22129
https://issues.apache.org/jira/browse/AMBARI-22129


Repository: ambari


Description
---

Locate model classes and other ones in one directory to avoid confusion, since 
model classes can be used not only in storage-related code.


Diffs
-

  
ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.class.ts
 d3d7d95 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.class.ts
 dee5d98 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts 
1aaaecc 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-settings.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log-field.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/bar-graph.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/common-entry.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/count.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/filter.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/graph.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log-field.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log-field.ts
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log.ts 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/models/solr-collection-state.ts
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/user-config.ts 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts
 3727abb 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.class.ts
 83c3261 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.ts 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.spec.ts
 efa2459 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts
 2e2113f 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.class.ts
 864b689 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.class.ts
 da05cee 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.class.ts
 15c05fb 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts
 43d79f8 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.ts
 656c901 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts
 1481583 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
 c345c81 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.ts
 467de98 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts
 7345288 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts
 c94b967 
  
ambari-logsearch

Re: Review Request 62766: Log Search UI: add event bars for Components list item

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62766/#review187082
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Окт. 4, 2017, 11:10 д.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62766/
> ---
> 
> (Updated Окт. 4, 2017, 11:10 д.п.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-22128
> https://issues.apache.org/jira/browse/AMBARI-22128
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Every item of Components filter control should include the bar which reflects 
> the ratio between events of different types for the corresponding component. 
> Should be similar to Hosts filter.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
>  fc3dac8 
>   ambari-logsearch/ambari-logsearch-web/src/app/models/node.model.ts 2891d142 
>   ambari-logsearch/ambari-logsearch-web/src/app/models/store.model.ts a6a084f 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.ts
>  c49f40f 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.spec.ts
>  e3f731e 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
> 0fff75d 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.ts 
> 44a5f6a 
> 
> 
> Diff: https://reviews.apache.org/r/62766/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 91 of 91 SUCCESS (2.144 secs / 2.103 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 62766: Log Search UI: add event bars for Components list item

[Andrii Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62766/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-22128
https://issues.apache.org/jira/browse/AMBARI-22128


Repository: ambari


Description
---

Every item of Components filter control should include the bar which reflects 
the ratio between events of different types for the corresponding component. 
Should be similar to Hosts filter.


Diffs
-

  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
 fc3dac8 
  ambari-logsearch/ambari-logsearch-web/src/app/models/node.model.ts 2891d142 
  ambari-logsearch/ambari-logsearch-web/src/app/models/store.model.ts a6a084f 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.ts
 c49f40f 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.spec.ts
 e3f731e 
  ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
0fff75d 
  ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.ts 
44a5f6a 


Diff: https://reviews.apache.org/r/62766/diff/1/


Testing
---

Executed 91 of 91 SUCCESS (2.144 secs / 2.103 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62754/#review187081
---


Ship it!




Ship It!

- Dmytro Grinenko


On Oct. 3, 2017, 9:11 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62754/
> ---
> 
> (Updated Oct. 3, 2017, 9:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22123
> https://issues.apache.org/jira/browse/AMBARI-22123
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Essentially, the symlinking was doing a quick-exit if the 
> /etc//conf directory already existed. However, it might have been 
> created by another RPM and not the component we actually care about.
> 
> The refactor here did two things:
> - Invokes conf-select on the necessary packages
> - Combined most of the logic between conf_select.select(...) and 
> conf_select.convert_conf_directories_to_symlinks(...)
> - Removed legacy code from back in the pre-HDP 2.3 days
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  86821bf47a 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 3ace3b1570 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py
>  0727970adb 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py
>  0727970adb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
>  20fd48de15 
>   ambari-server/src/test/python/TestAmbariServer.py 5db79137ee 
>   ambari-server/src/test/python/TestMpacks.py fd30bf6f88 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py
>  92f5011978 
>   ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 
> 2eeec46b4a 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py
>  3d9bfd7c3e 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py
>  b88f3858a7 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py
>  31b083bd0d 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py
>  2df001cf21 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py
>  34687c453b 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py
>  4ec6aa788f 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py
>  34c683ab2f 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py
>  424157b128 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py
>  b235cad164 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py
>  71c7bc17a2 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py
>  4d65a404a2 
> 
> 
> Diff: https://reviews.apache.org/r/62754/diff/3/
> 
> 
> Testing
> ---
> 
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 57.162 s
> [INFO] Finished at: 2017-10-03T23:04:47-04:00
> [INFO] Final Memory: 19M/491M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62754/#review187080
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 4, 2017, 12:11 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62754/
> ---
> 
> (Updated Oct. 4, 2017, 12:11 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22123
> https://issues.apache.org/jira/browse/AMBARI-22123
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Essentially, the symlinking was doing a quick-exit if the 
> /etc//conf directory already existed. However, it might have been 
> created by another RPM and not the component we actually care about.
> 
> The refactor here did two things:
> - Invokes conf-select on the necessary packages
> - Combined most of the logic between conf_select.select(...) and 
> conf_select.convert_conf_directories_to_symlinks(...)
> - Removed legacy code from back in the pre-HDP 2.3 days
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  86821bf47a 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 3ace3b1570 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py
>  0727970adb 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py
>  0727970adb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
>  20fd48de15 
>   ambari-server/src/test/python/TestAmbariServer.py 5db79137ee 
>   ambari-server/src/test/python/TestMpacks.py fd30bf6f88 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py
>  92f5011978 
>   ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 
> 2eeec46b4a 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py
>  3d9bfd7c3e 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py
>  b88f3858a7 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py
>  31b083bd0d 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py
>  2df001cf21 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py
>  34687c453b 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py
>  4ec6aa788f 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py
>  34c683ab2f 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py
>  424157b128 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py
>  b235cad164 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py
>  71c7bc17a2 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py
>  4d65a404a2 
> 
> 
> Diff: https://reviews.apache.org/r/62754/diff/3/
> 
> 
> Testing
> ---
> 
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 57.162 s
> [INFO] Finished at: 2017-10-03T23:04:47-04:00
> [INFO] Final Memory: 19M/491M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62764/#review187078
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 4, 2017, 1:02 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62764/
> ---
> 
> (Updated Oct. 4, 2017, 1:02 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22127
> https://issues.apache.org/jira/browse/AMBARI-22127
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to pass both repo IDs and repo file names via `use_repos`, because 
> Debian/Ubuntu selects specific repos by file name, while RedHat/SuSE by repo 
> ID.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 
> 49e3adf6782021977ff3edce850da35e3adc7116 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
>  94047571b5113716ee041e890fea559b4ce263ee 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/apt.py
>  f6a5538a30cf86eb4125ff088a1a8ca24c5adece 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/choco.py
>  db552964279f509de90d2fde884bfc0fea12f7b0 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
>  a4a55da7c9c5e9ac554d91edd19e9cb668615671 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
>  5b8e5ab94091bf181e97defd6a13dea4e3a46863 
>   
> ambari-common/src/main/python/resource_management/core/resources/packaging.py 
> e3adc30f46abd3f33670f817421d88270b3e7ade 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  f1074ee7b3748cfedb3e1a813be52df894cff97f 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> dcf354447756d2e1c826feb8515cfe3b9711f19d 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
> 0f303bee541ea3ac06fadb67eb44f5aab97fa1d5 
> 
> 
> Diff: https://reviews.apache.org/r/62764/diff/1/
> 
> 
> Testing
> ---
> 
> Tested package installation (both pre-upgrade "Install Version" and regular 
> "Add Service") on Debian 7.6 and CentOS 6.4.
> 
> Unit tests (on `branch-2.6`):
> 
> ```
> $ mvn -am -pl ambari-agent,ambari-server -DskipSurefireTests test
> ...
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> ...
> Ran 453 tests in 137.865s
> 
> OK
> ...
> [INFO] Ambari Server .. SUCCESS [01:28 
> min]
> [INFO] Ambari Agent ... SUCCESS [02:21 
> min]
> ```
> 
> Unit tests of Ambari Agent on `trunk` are wrong due to an unrelated change.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62764/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
Hurley, Nate Cole, and Sebastian Toader.


Bugs: AMBARI-22127
https://issues.apache.org/jira/browse/AMBARI-22127


Repository: ambari


Description
---

Need to pass both repo IDs and repo file names via `use_repos`, because 
Debian/Ubuntu selects specific repos by file name, while RedHat/SuSE by repo ID.


Diffs
-

  ambari-agent/src/test/python/resource_management/TestPackageResource.py 
49e3adf6782021977ff3edce850da35e3adc7116 
  
ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
 94047571b5113716ee041e890fea559b4ce263ee 
  
ambari-common/src/main/python/resource_management/core/providers/package/apt.py 
f6a5538a30cf86eb4125ff088a1a8ca24c5adece 
  
ambari-common/src/main/python/resource_management/core/providers/package/choco.py
 db552964279f509de90d2fde884bfc0fea12f7b0 
  
ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
 a4a55da7c9c5e9ac554d91edd19e9cb668615671 
  
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
 5b8e5ab94091bf181e97defd6a13dea4e3a46863 
  ambari-common/src/main/python/resource_management/core/resources/packaging.py 
e3adc30f46abd3f33670f817421d88270b3e7ade 
  
ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
 f1074ee7b3748cfedb3e1a813be52df894cff97f 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
dcf354447756d2e1c826feb8515cfe3b9711f19d 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
0f303bee541ea3ac06fadb67eb44f5aab97fa1d5 


Diff: https://reviews.apache.org/r/62764/diff/1/


Testing
---

Tested package installation (both pre-upgrade "Install Version" and regular 
"Add Service") on Debian 7.6 and CentOS 6.4.

Unit tests (on `branch-2.6`):

```
$ mvn -am -pl ambari-agent,ambari-server -DskipSurefireTests test
...
Total run:1192
Total errors:0
Total failures:0
OK
...
Ran 453 tests in 137.865s

OK
...
[INFO] Ambari Server .. SUCCESS [01:28 min]
[INFO] Ambari Agent ... SUCCESS [02:21 min]
```

Unit tests of Ambari Agent on `trunk` are wrong due to an unrelated change.


Thanks,

Attila Doroszlai

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187069
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 3, 2017, 10:23 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 3, 2017, 10:23 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Vitalyi Brodetskyi]

> On Жов. 4, 2017, 12:54 до полудня, Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
> > Lines 21 (patched)
> > 
> >
> > Can we also remove the duplicate code in HDP stack advisors?

Which code i should remove? If you are talking about all AMS methods 
(recommendations and validations), i don't think we can remove them. As of now, 
only HDP 3.0 work with service advisors, all other stacks work with stack 
advisor.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187037
---


On Жов. 4, 2017, 8:26 до полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Жов. 4, 2017, 8:26 до полудня)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Vitalyi Brodetskyi]

> On Жов. 4, 2017, 12:49 до полудня, Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
> > Line 77 (original), 77 (patched)
> > 
> >
> > Is this change to ATLAS service advisor supposed to be part of the 
> > patch?

Just found this little part of missed code during work on service advisor for 
AMS. Decided to add it here because change is trivial.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187036
---


On Жов. 4, 2017, 8:26 до полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Жов. 4, 2017, 8:26 до полудня)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/
---

(Updated Жов. 4, 2017, 8:26 до полудня)


Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
Radhakrishnan, and Sid Wagle.


Bugs: AMBARI-22124
https://issues.apache.org/jira/browse/AMBARI-22124


Repository: ambari


Description
---

We need to move AMS specific logic in the stack advisors to service advisor.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
 a2e31cc 


Diff: https://reviews.apache.org/r/62756/diff/2/

Changes: https://reviews.apache.org/r/62756/diff/1-2/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 62744: Alerts for OneFS mpack

[Attila Magyar]

> On Oct. 3, 2017, 5:34 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
> > Lines 20-21 (patched)
> > 
> >
> > This is a funny looking import.  Use java.util.Collections directly.
> 
> Attila Magyar wrote:
> is there a particular reason for this or just aesthetics?

I've just realized what you meant, misunderstood your comment at first. Fixed 
the import.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/#review186980
---


On Oct. 4, 2017, 8:16 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62744/
> ---
> 
> (Updated Oct. 4, 2017, 8:16 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22115
> https://issues.apache.org/jira/browse/AMBARI-22115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is part of AMBARI-22115. We need to define alerts on JMX metrics which 
> are pulled from a cluster that is not necessarily managed by Ambari. 
> Therefore alerts can't run on ambari-agent host. I introduced a new SERVER 
> type alert called JmxServerSideAlert that can pull the jmx metrics from a 
> arbitrary url. The url comes from the alerts.json and it may contain 
> placeholders like ${hdfs-site/dfs.namenode.http-address}. This works 
> similarly than the Python class MetricAlert.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
>  81d72fb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 5d2ecc6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  93801d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
>  11eee05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  4aeba45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
>  c58867a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62744/diff/3/
> 
> 
> Testing
> ---
> 
> Used the following alerts.json to test it
> 
> {   
>   "ONEFS":{
> "service": [
>   { 
> "name": "onefs_namenode_cpu",
> "label": "OneFS NameNode Host CPU Utilization",
> "description": "This host-level alert is triggered if CPU utilization 
> of the NameNode exceeds certain warning and critical thresholds. It checks 
> the NameNode JMX Servlet for the SystemCPULoad property. The threshold values 
> are in percent.",
> "interval": 1,
> "help_url": 
> "https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat";,
> "scope": "HOST",
> "enabled": true,
> "source": {
>   "type": "SERVER",
>   "class": "org.apache.ambari.server.alerts.JmxServerSideAlert",
>   "uri": {
> "http": "${hdfs-site/dfs.namenode.http-address}",
> "https": "${hdfs-site/dfs.namenode.https-address}",
> "https_property": "${hdfs-site/dfs.http.policy}",
> "https_property_value": "HTTPS_ONLY",
> "connection_timeout": 5.0
>   },
>   "reporting": {
> "ok": {
>   "text": "{1} CPU, load {0,number,percent}"
> },
> "warning": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 5
> },
> "critical": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 20
> },
> "units" : "%",
> "type": "PERCENT"
>},
>"jmx": {
>  "property_list": [
>   "java.lang:type=OperatingSystem/SystemCpuLoad",
>   "java.lang:type=OperatingSystem/AvailableProcessors"
>  ]
>}
>   }
>   }
> ]
>   }
> }
> 1,1   Top
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 62744: Alerts for OneFS mpack

[Attila Magyar]

> On Oct. 3, 2017, 11:48 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
> > Lines 83 (patched)
> > 
> >
> > It's interesting to use the MetricsRetrievalService here. This service 
> > was created for use with the web client since it polls every few seconds. 
> > We figured it's better to respond quickly with metric data that migth be a 
> > few seconds old.
> > 
> > In this case, the alert only runs once every X minutes, so it's going 
> > to always be working with data that was retrieved X minutes ago. 
> > 
> > Is that the desired behavior?

Is there any other service that can provide real time data or should I write my 
own?


> On Oct. 3, 2017, 11:48 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
> > Lines 225-231 (patched)
> > 
> >
> > Do you need to worry about the SKIPPED state here?

I don't think skipped alerts will reach that point, but I added a case to 
handle them gracefully.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/#review187025
---


On Oct. 4, 2017, 8:16 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62744/
> ---
> 
> (Updated Oct. 4, 2017, 8:16 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22115
> https://issues.apache.org/jira/browse/AMBARI-22115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is part of AMBARI-22115. We need to define alerts on JMX metrics which 
> are pulled from a cluster that is not necessarily managed by Ambari. 
> Therefore alerts can't run on ambari-agent host. I introduced a new SERVER 
> type alert called JmxServerSideAlert that can pull the jmx metrics from a 
> arbitrary url. The url comes from the alerts.json and it may contain 
> placeholders like ${hdfs-site/dfs.namenode.http-address}. This works 
> similarly than the Python class MetricAlert.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
>  81d72fb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 5d2ecc6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  93801d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
>  11eee05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  4aeba45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
>  c58867a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62744/diff/2/
> 
> 
> Testing
> ---
> 
> Used the following alerts.json to test it
> 
> {   
>   "ONEFS":{
> "service": [
>   { 
> "name": "onefs_namenode_cpu",
> "label": "OneFS NameNode Host CPU Utilization",
> "description": "This host-level alert is triggered if CPU utilization 
> of the NameNode exceeds certain warning and critical thresholds. It checks 
> the NameNode JMX Servlet for the SystemCPULoad property. The threshold values 
> are in percent.",
> "interval": 1,
> "help_url": 
> "https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat";,
> "scope": "HOST",
> "enabled": true,
> "source": {
>   "type": "SERVER",
>   "class": "org.apache.ambari.server.alerts.JmxServerSideAlert",
>   "uri": {
> "http": "${hdfs-site/dfs.namenode.http-address}",
> "https": "${hdfs-site/dfs.namenode.https-address}",
> "https_property": "${hdfs-site/dfs.http.policy}",
> "https_property_value": "HTTPS_ONLY",
> "connection_timeout": 5.0
>   },
>   "reporting": {
> "ok": {
>   "text": "{1} CPU, load {0,number,percent}"
> },
> "warning"

Re: Review Request 62744: Alerts for OneFS mpack

[Attila Magyar]

> On Oct. 3, 2017, 5:34 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
> > Lines 20-21 (patched)
> > 
> >
> > This is a funny looking import.  Use java.util.Collections directly.

is there a particular reason for this or just aesthetics?


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/#review186980
---


On Oct. 4, 2017, 8:16 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62744/
> ---
> 
> (Updated Oct. 4, 2017, 8:16 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22115
> https://issues.apache.org/jira/browse/AMBARI-22115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is part of AMBARI-22115. We need to define alerts on JMX metrics which 
> are pulled from a cluster that is not necessarily managed by Ambari. 
> Therefore alerts can't run on ambari-agent host. I introduced a new SERVER 
> type alert called JmxServerSideAlert that can pull the jmx metrics from a 
> arbitrary url. The url comes from the alerts.json and it may contain 
> placeholders like ${hdfs-site/dfs.namenode.http-address}. This works 
> similarly than the Python class MetricAlert.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
>  81d72fb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 5d2ecc6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  93801d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
>  11eee05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  4aeba45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
>  c58867a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62744/diff/2/
> 
> 
> Testing
> ---
> 
> Used the following alerts.json to test it
> 
> {   
>   "ONEFS":{
> "service": [
>   { 
> "name": "onefs_namenode_cpu",
> "label": "OneFS NameNode Host CPU Utilization",
> "description": "This host-level alert is triggered if CPU utilization 
> of the NameNode exceeds certain warning and critical thresholds. It checks 
> the NameNode JMX Servlet for the SystemCPULoad property. The threshold values 
> are in percent.",
> "interval": 1,
> "help_url": 
> "https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat";,
> "scope": "HOST",
> "enabled": true,
> "source": {
>   "type": "SERVER",
>   "class": "org.apache.ambari.server.alerts.JmxServerSideAlert",
>   "uri": {
> "http": "${hdfs-site/dfs.namenode.http-address}",
> "https": "${hdfs-site/dfs.namenode.https-address}",
> "https_property": "${hdfs-site/dfs.http.policy}",
> "https_property_value": "HTTPS_ONLY",
> "connection_timeout": 5.0
>   },
>   "reporting": {
> "ok": {
>   "text": "{1} CPU, load {0,number,percent}"
> },
> "warning": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 5
> },
> "critical": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 20
> },
> "units" : "%",
> "type": "PERCENT"
>},
>"jmx": {
>  "property_list": [
>   "java.lang:type=OperatingSystem/SystemCpuLoad",
>   "java.lang:type=OperatingSystem/AvailableProcessors"
>  ]
>}
>   }
>   }
> ]
>   }
> }
> 1,1   Top
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 62744: Alerts for OneFS mpack

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/
---

(Updated Oct. 4, 2017, 8:16 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.


Changes
---

address some reviewer comments


Bugs: AMBARI-22115
https://issues.apache.org/jira/browse/AMBARI-22115


Repository: ambari


Description
---

This is part of AMBARI-22115. We need to define alerts on JMX metrics which are 
pulled from a cluster that is not necessarily managed by Ambari. Therefore 
alerts can't run on ambari-agent host. I introduced a new SERVER type alert 
called JmxServerSideAlert that can pull the jmx metrics from a arbitrary url. 
The url comes from the alerts.json and it may contain placeholders like 
${hdfs-site/dfs.namenode.http-address}. This works similarly than the Python 
class MetricAlert.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
 81d72fb 
  ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 5d2ecc6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java 
93801d5 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
 11eee05 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java 
4aeba45 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
 c58867a 
  
ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62744/diff/2/

Changes: https://reviews.apache.org/r/62744/diff/1-2/


Testing
---

Used the following alerts.json to test it

{   
  "ONEFS":{
"service": [
  { 
"name": "onefs_namenode_cpu",
"label": "OneFS NameNode Host CPU Utilization",
"description": "This host-level alert is triggered if CPU utilization 
of the NameNode exceeds certain warning and critical thresholds. It checks the 
NameNode JMX Servlet for the SystemCPULoad property. The threshold values are 
in percent.",
"interval": 1,
"help_url": 
"https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat";,
"scope": "HOST",
"enabled": true,
"source": {
  "type": "SERVER",
  "class": "org.apache.ambari.server.alerts.JmxServerSideAlert",
  "uri": {
"http": "${hdfs-site/dfs.namenode.http-address}",
"https": "${hdfs-site/dfs.namenode.https-address}",
"https_property": "${hdfs-site/dfs.http.policy}",
"https_property_value": "HTTPS_ONLY",
"connection_timeout": 5.0
  },
  "reporting": {
"ok": {
  "text": "{1} CPU, load {0,number,percent}"
},
"warning": {
  "text": "{1} CPU, load {0,number,percent}",
  "value": 5
},
"critical": {
  "text": "{1} CPU, load {0,number,percent}",
  "value": 20
},
"units" : "%",
"type": "PERCENT"
   },
   "jmx": {
 "property_list": [
  "java.lang:type=OperatingSystem/SystemCpuLoad",
  "java.lang:type=OperatingSystem/AvailableProcessors"
 ]
   }
  }
  }
]
  }
}
1,1   Top


Thanks,

Attila Magyar