date:20171010

Review Request 62883: Zeppelin start fails due to permission denied error during kinit

2017-10-10 Thread Prabhjyot Singh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62883/
---

Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22199
https://issues.apache.org/jira/browse/AMBARI-22199


Repository: ambari


Description
---

Zeppelin fails to come up with following error in ambari stderr logs, on 
kerberos enabled enviornment.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 d615d06d5a 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
3064880632 


Diff: https://reviews.apache.org/r/62883/diff/1/


Testing
---

Tested manually


Thanks,

Prabhjyot Singh

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-10 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/#review187631
---




ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
Lines 25 (patched)


RootClusterSettingsResourceDefinition



ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceLevelClusterSettingRequest.java
Lines 22 (patched)


RootClusterSettingRequest?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
Line 31 (original)


Why do we need to remove StackConfigurationResponse()?



ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
Lines 78 (patched)


RootClusterSetting


- Jayush Luniya


On Oct. 11, 2017, 5:27 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62802/
> ---
> 
> (Updated Oct. 11, 2017, 5:27 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Following done as part of this JIRA:**
> 
> - Move all non-stack specific configs in **cluster-env.xml** to 
> **cluster-settings.xml**.
> - For example **cluster-env/security_enabled** is a cluster setting and 
> shouldn't be associated with any **stack/mpack**. 
> {code}
>   
> security_enabled
> false
> Hadoop Security
> 
>   
> {code}
> 
> - Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml** 
> which includes all the read only cluster specific settings.
> 
> 
> - **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings
> 
> 
> **Followup work :**
> 
> - **AMBARI-22197** takes care of removing **cluster-env.xml** and associated 
> code and API once we have **AMBARI-22198** completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ConfigurationNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  7431f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  fd15105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  67d3a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  f2c4c52 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  c56483d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceLevelClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
>  fb31c19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
>  ea67207 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
>  d33b5cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  0c5a579 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  f8feef2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
>  6f5b0f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
>  819507b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  a364c4c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.jav

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-10 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/#review187629
---




ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
Lines 777 (patched)


PropertyNotFoundException instead?



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
Lines 778 (patched)


Remove cluster-settings.xml hardcodings. Use constant instead.



ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
Lines 53 (patched)


Rename to RootClusterSettingService()? 

Lets reserve ClusterSettingService for 
api/v1/clusters//settings



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 1 (patched)


Rename to RootClusterSettingsResourceProvider?


- Jayush Luniya


On Oct. 11, 2017, 5:27 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62802/
> ---
> 
> (Updated Oct. 11, 2017, 5:27 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Following done as part of this JIRA:**
> 
> - Move all non-stack specific configs in **cluster-env.xml** to 
> **cluster-settings.xml**.
> - For example **cluster-env/security_enabled** is a cluster setting and 
> shouldn't be associated with any **stack/mpack**. 
> {code}
>   
> security_enabled
> false
> Hadoop Security
> 
>   
> {code}
> 
> - Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml** 
> which includes all the read only cluster specific settings.
> 
> 
> - **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings
> 
> 
> **Followup work :**
> 
> - **AMBARI-22197** takes care of removing **cluster-env.xml** and associated 
> code and API once we have **AMBARI-22198** completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ConfigurationNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  7431f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  fd15105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  67d3a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  f2c4c52 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  c56483d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceLevelClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
>  fb31c19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
>  ea67207 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
>  d33b5cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  0c5a579 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  f8feef2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
>  6f5b0f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
>  819507b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-10 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/
---

(Updated Oct. 11, 2017, 5:27 a.m.)


Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Changes
---

Updated Summary.


Summary (updated)
-

AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.


Bugs: AMBARI-22196
https://issues.apache.org/jira/browse/AMBARI-22196


Repository: ambari


Description
---

**Following done as part of this JIRA:**

- Move all non-stack specific configs in **cluster-env.xml** to 
**cluster-settings.xml**.
- For example **cluster-env/security_enabled** is a cluster setting and 
shouldn't be associated with any **stack/mpack**. 
{code}
  
security_enabled
false
Hadoop Security

  
{code}

- Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml** 
which includes all the read only cluster specific settings.


- **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings


**Followup work :**

- **AMBARI-22197** takes care of removing **cluster-env.xml** and associated 
code and API once we have **AMBARI-22198** completed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/ConfigurationNotFoundException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 7431f9d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 fd15105 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
 67d3a15 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 f2c4c52 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 e9fa8db 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 c56483d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceLevelClusterSettingRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
 fb31c19 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
 ea67207 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
 d33b5cb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 0c5a579 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
 f8feef2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
 6f5b0f8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
 819507b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 a364c4c 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
bb7fcbe 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
63c850e 
  ambari-server/src/main/resources/cluster-settings.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/62802/diff/1/


Testing
---

API testing:

**Get all cluster-settings**

**http://:/api/v1/cluster_settings/**

{
"href": "http://172.22.102.6:8080/api/v1/cluster_settings/";,
"items": [
{
"href": 
"http://172.22.102.6:8080/api/v1/cluster_settings/agent_mounts_ignore_list";,
"ClusterSettingsInfo": {
"property_name": "agent_mounts_ignore_list"
}
},
{
"href": 
"http://172.22.102.6:8080/api/v1/cluster_settings/alerts_repeat_tolerance";,
"ClusterSettingsInfo": {
"property_name": "alerts_repeat_tolerance"
}
},
...
...
}


**Get specific cluster-setting**

**http://:/api/v1/cluster_settings/agent_mounts_ignore_list

{
"href": 
"http://172.22.102.6:8080/api/v1/cluster_settings/agent_mounts_ignore_list";,
"ClusterSettingsInfo": {
"final": "false",
"property_depends_on": [],
"property

Re: Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

2017-10-10 Thread Jonathan Hurley



> On Oct. 10, 2017, 5:07 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
> > Lines 343-344 (patched)
> > 
> >
> > Ewww

Just following the Ambari Anti-Pattern :) ... OK, OK - let me make a POJO :)


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62871/#review187589
---


On Oct. 10, 2017, 4:42 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62871/
> ---
> 
> (Updated Oct. 10, 2017, 4:42 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-22194
> https://issues.apache.org/jira/browse/AMBARI-22194
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as HDP, do not support service-level upgrades for some 
> services since they have hard coded dependencies with other services which 
> might not be in the upgrade. 
> 
> For example, if YARN is configured to use Tez, then an upgrade of YARN or Tez 
> must also include Tez or YARN respectively. This is because the path is hard 
> coded inside of YARN to use its version and cannot be changed via any 
> external environment variable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  d54e8a176a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  314ab83718 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
> 442bf0be12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  a2fb44199f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java
>  954f705e9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  c17f5e90f9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  2db0a74195 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  092bd0bd88 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java
>  671648ab71 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java
>  206b4519c1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentExistsInRepoCheckTest.java
>  ede1daacff 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentsInstallationCheckTest.java
>  4ae33f8bbf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ConfigurationMergeCheckTest.java
>  df7bd1fb70 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DruidHighAvailabilityCheckTest.java
>  e90931bc11 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheckTest.java
>  7a1fca3161 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HiveNotRollingWarningTest.java
>  3b0c900991 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HostsHeartbeatCheckTest.java
>  daf2e4cb76 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheckTest.java
>  8afa1eaf89 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java
>  5539618c28 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/InstallPackagesCheckTest.java
>  cdfbb0a790 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/KafkaKerberosCheckTest.java
>  9a95c42327 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java
>  fc322b3d91 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RangerAuditDbCheckTest.java
>  ec91e483b3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RangerPasswordCheckTest.java
>  f9569c3820 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RangerSSLConfigCheckTest.java
>  af016b01e0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheckTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheckTest.java
>  5d0ca5f03d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheckTest.java
>  65776519c8 
>   
> ambari-server/src/

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-10 Thread Jayush Luniya



> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
> > Line 248 (original), 246 (patched)
> > 
> >
> > Should now be getName() instead of getServiceDisplayName() since we 
> > updated the semantics to (service_name, service_type)
> 
> Nate Cole wrote:
> What is this (service_name, service_type) you speak of?  I would hope 
> we're keeping display (ZooKeeper) vs name (ZOOKEEPER).  Are you saying 
> there's yet a 3rd service identifier?  metainfo.xml already has a  
> element, and that's for things like HCFS (Hadoop Compliant File System) - 
> what is that going to be called in this new world?
> 
> Jayush Luniya wrote:
> @Nate
> service_name = ZK1, service_type = ZOOKEEPER for creating multiple 
> instances. The service display name remains ZooKeeper in the stack 
> definition. From UI perspective we have to see how we display this. Jaimin 
> suggested displaying this as "ZooKeeper" for the default instance and 
> "ZooKeeper (ZK1)" for 2nd instance and above.
> 
> The service type in service definition will be termed service category.
> 
> Nate Cole wrote:
> @Jayush,
> 
> That seems overly complicated.  Why not use the service group name, as 
> in:  ():  eg "ZooKeeper (Core)".  You still end 
> up with a trifecta of display, name, service_group_name.  Changing name to 
> NOT be the service name will be extremely confusing to those used to the v1 
> API.

Oh the default is service_name = service_type = ZOOKEEPER so old semantics will 
remain the same.

One of the requirement was to not add limitation that a service group can have 
only a single service instance.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
---


On Oct. 10, 2017, 8:09 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 10, 2017, 8:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 44d76afcd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  6b32d4c75e 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 62802: clusterSettingsCode10thoctWithCHanges_ReadOnlyConfigurationResponse.patch

2017-10-10 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/
---

Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Bugs: AMBARI-22196
https://issues.apache.org/jira/browse/AMBARI-22196


Repository: ambari


Description
---

**Following done as part of this JIRA:**

- Move all non-stack specific configs in **cluster-env.xml** to 
**cluster-settings.xml**.
- For example **cluster-env/security_enabled** is a cluster setting and 
shouldn't be associated with any **stack/mpack**. 
{code}
  
security_enabled
false
Hadoop Security

  
{code}

- Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml** 
which includes all the read only cluster specific settings.


- **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings


**Followup work :**

- **AMBARI-22197** takes care of removing **cluster-env.xml** and associated 
code and API once we have **AMBARI-22198** completed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/ConfigurationNotFoundException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 7431f9d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 fd15105 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
 67d3a15 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 f2c4c52 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 e9fa8db 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 c56483d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceLevelClusterSettingRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
 fb31c19 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
 ea67207 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
 d33b5cb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 0c5a579 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
 f8feef2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
 6f5b0f8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
 819507b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 a364c4c 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
bb7fcbe 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
63c850e 
  ambari-server/src/main/resources/cluster-settings.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/62802/diff/1/


Testing
---

API testing:

**Get all cluster-settings**

**http://:/api/v1/cluster_settings/**

{
"href": "http://172.22.102.6:8080/api/v1/cluster_settings/";,
"items": [
{
"href": 
"http://172.22.102.6:8080/api/v1/cluster_settings/agent_mounts_ignore_list";,
"ClusterSettingsInfo": {
"property_name": "agent_mounts_ignore_list"
}
},
{
"href": 
"http://172.22.102.6:8080/api/v1/cluster_settings/alerts_repeat_tolerance";,
"ClusterSettingsInfo": {
"property_name": "alerts_repeat_tolerance"
}
},
...
...
}


**Get specific cluster-setting**

**http://:/api/v1/cluster_settings/agent_mounts_ignore_list

{
"href": 
"http://172.22.102.6:8080/api/v1/cluster_settings/agent_mounts_ignore_list";,
"ClusterSettingsInfo": {
"final": "false",
"property_depends_on": [],
"property_description": "Comma separated list of the mounts which would be 
ignored by Ambari during property values suggestion by Stack Advisor",
"property_name": "agent_mounts_ignore_list",
"pr

Re: Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

2017-10-10 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62871/#review187589
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
Lines 343-344 (patched)


Ewww


- Nate Cole


On Oct. 10, 2017, 4:42 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62871/
> ---
> 
> (Updated Oct. 10, 2017, 4:42 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-22194
> https://issues.apache.org/jira/browse/AMBARI-22194
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as HDP, do not support service-level upgrades for some 
> services since they have hard coded dependencies with other services which 
> might not be in the upgrade. 
> 
> For example, if YARN is configured to use Tez, then an upgrade of YARN or Tez 
> must also include Tez or YARN respectively. This is because the path is hard 
> coded inside of YARN to use its version and cannot be changed via any 
> external environment variable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  d54e8a176a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  314ab83718 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
> 442bf0be12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  a2fb44199f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java
>  954f705e9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  c17f5e90f9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  2db0a74195 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  092bd0bd88 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java
>  671648ab71 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java
>  206b4519c1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentExistsInRepoCheckTest.java
>  ede1daacff 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentsInstallationCheckTest.java
>  4ae33f8bbf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ConfigurationMergeCheckTest.java
>  df7bd1fb70 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DruidHighAvailabilityCheckTest.java
>  e90931bc11 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheckTest.java
>  7a1fca3161 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HiveNotRollingWarningTest.java
>  3b0c900991 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HostsHeartbeatCheckTest.java
>  daf2e4cb76 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheckTest.java
>  8afa1eaf89 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java
>  5539618c28 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/InstallPackagesCheckTest.java
>  cdfbb0a790 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/KafkaKerberosCheckTest.java
>  9a95c42327 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java
>  fc322b3d91 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RangerAuditDbCheckTest.java
>  ec91e483b3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RangerPasswordCheckTest.java
>  f9569c3820 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RangerSSLConfigCheckTest.java
>  af016b01e0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheckTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheckTest.java
>  5d0ca5f03d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheckTest.java
>  65776519c8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheckTest.java
>  a8569cc61f 
>   
> ambari-server/src/test/java/org/apache/ambar

Re: Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

2017-10-10 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62871/
---

(Updated Oct. 10, 2017, 4:42 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-22194
https://issues.apache.org/jira/browse/AMBARI-22194


Repository: ambari


Description
---

Some stacks, such as HDP, do not support service-level upgrades for some 
services since they have hard coded dependencies with other services which 
might not be in the upgrade. 

For example, if YARN is configured to use Tez, then an upgrade of YARN or Tez 
must also include Tez or YARN respectively. This is because the path is hard 
coded inside of YARN to use its version and cannot be changed via any external 
environment variable.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 d54e8a176a 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 314ab83718 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheck.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
442bf0be12 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 a2fb44199f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java 
954f705e9f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 c17f5e90f9 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
 2db0a74195 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
 092bd0bd88 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java
 671648ab71 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java
 206b4519c1 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentExistsInRepoCheckTest.java
 ede1daacff 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentsInstallationCheckTest.java
 4ae33f8bbf 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ConfigurationMergeCheckTest.java
 df7bd1fb70 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DruidHighAvailabilityCheckTest.java
 e90931bc11 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheckTest.java
 7a1fca3161 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/HiveNotRollingWarningTest.java
 3b0c900991 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/HostsHeartbeatCheckTest.java
 daf2e4cb76 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheckTest.java
 8afa1eaf89 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java
 5539618c28 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/InstallPackagesCheckTest.java
 cdfbb0a790 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/KafkaKerberosCheckTest.java
 9a95c42327 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java
 fc322b3d91 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/RangerAuditDbCheckTest.java
 ec91e483b3 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/RangerPasswordCheckTest.java
 f9569c3820 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/RangerSSLConfigCheckTest.java
 af016b01e0 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheckTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheckTest.java
 5d0ca5f03d 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheckTest.java
 65776519c8 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheckTest.java
 a8569cc61f 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheckTest.java
 c7e8fd63f1 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java
 b252ec56b0 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheckTest.java
 96eefc1cb8 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
 7cf0a38b87 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheckTest.java
 331223d0e6 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/StormShutdownWarningTest.java
 1441256719 
  
ambari-server/src/test/java/org/apache/ambari/server/state/CheckHelperTest.java 
27b248f2a8 


Diff: http

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-10 Thread Madhuvanthi Radhakrishnan



> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Line 2445 (original), 2445 (patched)
> > 
> >
> > I dont quite understand why we are iterating over all services to get 
> > the serviceType. For now this workaround is ok, but let's file a follow up 
> > JIRA for this to understand the logic correctly here.

I have opened a follow up jira.


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
---


On Oct. 10, 2017, 8:09 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 10, 2017, 8:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 44d76afcd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  6b32d4c75e 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

2017-10-10 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62871/#review187579
---


Ship it!




Ship It!

- Robert Levas


On Oct. 10, 2017, 3:44 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62871/
> ---
> 
> (Updated Oct. 10, 2017, 3:44 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-22194
> https://issues.apache.org/jira/browse/AMBARI-22194
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as HDP, do not support service-level upgrades for some 
> services since they have hard coded dependencies with other services which 
> might not be in the upgrade. 
> 
> For example, if YARN is configured to use Tez, then an upgrade of YARN or Tez 
> must also include Tez or YARN respectively. This is because the path is hard 
> coded inside of YARN to use its version and cannot be changed via any 
> external environment variable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  d54e8a176a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  314ab83718 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CompatibleServicesInUpgradeCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
> 442bf0be12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  a2fb44199f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java
>  954f705e9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  c17f5e90f9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  2db0a74195 
> 
> 
> Diff: https://reviews.apache.org/r/62871/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing of an install / upgrade with and without services which 
> require dependencies. 
> 
> UNIT TESTS PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-10 Thread Madhuvanthi Radhakrishnan



> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
> > Line 616 (original), 619 (patched)
> > 
> >
> > Here 
> > Case 1: oldStack would be null if there are no services still added to 
> > the cluster. 
> > Case 2: oldStack will be set to the stack id of the last service in the 
> > list of cluster services. 
> > 
> > So the logic here looks wrong.
> > 
> > I guess the logic to get stackProperties will go away once we break 
> > down cluster-env to cluster-settings and stack-settings.

Ok. I will remove this change and revisit it later.


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
---


On Oct. 10, 2017, 4:58 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 10, 2017, 4:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  ec4d383dee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 44d76afcd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  6b32d4c75e 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-10 Thread Madhuvanthi Radhakrishnan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/
---

(Updated Oct. 10, 2017, 8:09 p.m.)


Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan Shridhar.


Changes
---

Incorporated a few review comments


Bugs: AMBARI-22181
https://issues.apache.org/jira/browse/AMBARI-22181


Repository: ambari


Description
---

Remove cluster-stackid dependency related to Configs


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 6726d30e80 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 d0dd7e0d9c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 e9fa8db0d1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 29f8e2acbd 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
bb7fcbed3d 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
44d76afcd8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
 cf556609a4 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
8f9d8e1b0b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 6b32d4c75e 


Diff: https://reviews.apache.org/r/62856/diff/2/

Changes: https://reviews.apache.org/r/62856/diff/1-2/


Testing
---

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 11:01 min
[INFO] Finished at: 2017-10-09T21:40:34-07:00
[INFO] Final Memory: 359M/1174M
[INFO] 


Thanks,

Madhuvanthi Radhakrishnan

Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

2017-10-10 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62871/
---

Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-22194
https://issues.apache.org/jira/browse/AMBARI-22194


Repository: ambari


Description
---

Some stacks, such as HDP, do not support service-level upgrades for some 
services since they have hard coded dependencies with other services which 
might not be in the upgrade. 

For example, if YARN is configured to use Tez, then an upgrade of YARN or Tez 
must also include Tez or YARN respectively. This is because the path is hard 
coded inside of YARN to use its version and cannot be changed via any external 
environment variable.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 d54e8a176a 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 314ab83718 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CompatibleServicesInUpgradeCheck.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
442bf0be12 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 a2fb44199f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java 
954f705e9f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 c17f5e90f9 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
 2db0a74195 


Diff: https://reviews.apache.org/r/62871/diff/1/


Testing
---

Manual testing of an install / upgrade with and without services which require 
dependencies. 

UNIT TESTS PENDING...


Thanks,

Jonathan Hurley

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-10 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187565
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Line 2445 (original), 2445 (patched)


The logic is that we don't have a way to quickly identify the service whose 
type is HCFS.  Since (in the "old" days anyway) you can have only one service 
that is HCFS, we need to find the one that has a type and set dfs_type on the 
command.

I agree that it should be visited to see if removing it will break anything 
else.


- Nate Cole


On Oct. 10, 2017, 12:58 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 10, 2017, 12:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  ec4d383dee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 44d76afcd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  6b32d4c75e 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-10 Thread Nate Cole



> On Oct. 10, 2017, 3:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
> > Line 248 (original), 246 (patched)
> > 
> >
> > Should now be getName() instead of getServiceDisplayName() since we 
> > updated the semantics to (service_name, service_type)
> 
> Nate Cole wrote:
> What is this (service_name, service_type) you speak of?  I would hope 
> we're keeping display (ZooKeeper) vs name (ZOOKEEPER).  Are you saying 
> there's yet a 3rd service identifier?  metainfo.xml already has a  
> element, and that's for things like HCFS (Hadoop Compliant File System) - 
> what is that going to be called in this new world?
> 
> Jayush Luniya wrote:
> @Nate
> service_name = ZK1, service_type = ZOOKEEPER for creating multiple 
> instances. The service display name remains ZooKeeper in the stack 
> definition. From UI perspective we have to see how we display this. Jaimin 
> suggested displaying this as "ZooKeeper" for the default instance and 
> "ZooKeeper (ZK1)" for 2nd instance and above.
> 
> The service type in service definition will be termed service category.

@Jayush,

That seems overly complicated.  Why not use the service group name, as in: 
 ():  eg "ZooKeeper (Core)".  You still end up 
with a trifecta of display, name, service_group_name.  Changing name to NOT be 
the service name will be extremely confusing to those used to the v1 API.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
---


On Oct. 10, 2017, 12:58 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 10, 2017, 12:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  ec4d383dee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 44d76afcd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  6b32d4c75e 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-10 Thread Madhuvanthi Radhakrishnan



> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> > Line 664 (original), 664 (patched)
> > 
> >
> > We have to look at references to this function and see how the 
> > servicesMap is populated. 
> > 
> > For example in configHelper.createUserGroupMap() we will end up 
> > creating user to group mapping only for a single mpack instead of multiple 
> > mpacks.

Hi Jayush,
The reason I went ahead with the change was that all the references to this and 
its overloaded counterpart populates servicesMap based on a stackId that is 
obtained from either a service or a serviceComponent. So it seemed that it is 
not coming from the cluster's stackid.
For eg:
AmbariManagementControllerImpl
StackId stackId = scHost.getServiceComponent().getDesiredStackId();
StackInfo stackInfo = ambariMetaInfo.getStack(stackId.getStackName(),
stackId.getStackVersion());
Map servicesMap = 
ambariMetaInfo.getServices(stackInfo.getName(), stackInfo.getVersion());
Map> userGroupsMap = configHelper.createUserGroupsMap(
  cluster, clusterDesiredConfigs, servicesMap, stackProperties);
  
public Map> createUserGroupsMap(
Cluster cluster, Map desiredConfigs,
Map servicesMap, Set stackProperties) 
throws AmbariException {


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
---


On Oct. 10, 2017, 4:58 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 10, 2017, 4:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  ec4d383dee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 44d76afcd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  6b32d4c75e 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-10 Thread Jayush Luniya



> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
> > Line 248 (original), 246 (patched)
> > 
> >
> > Should now be getName() instead of getServiceDisplayName() since we 
> > updated the semantics to (service_name, service_type)
> 
> Nate Cole wrote:
> What is this (service_name, service_type) you speak of?  I would hope 
> we're keeping display (ZooKeeper) vs name (ZOOKEEPER).  Are you saying 
> there's yet a 3rd service identifier?  metainfo.xml already has a  
> element, and that's for things like HCFS (Hadoop Compliant File System) - 
> what is that going to be called in this new world?

@Nate
service_name = ZK1, service_type = ZOOKEEPER for creating multiple instances. 
The service display name remains ZooKeeper in the stack definition. From UI 
perspective we have to see how we display this. Jaimin suggested displaying 
this as "ZooKeeper" for the default instance and "ZooKeeper (ZK1)" for 2nd 
instance and above.

The service type in service definition will be termed service category.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
---


On Oct. 10, 2017, 4:58 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 10, 2017, 4:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  ec4d383dee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 44d76afcd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  6b32d4c75e 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 62866: Make hive server create directories related to replication

2017-10-10 Thread Eugene Chekanskiy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62866/
---

Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Bugs: AMBARI-22188
https://issues.apache.org/jira/browse/AMBARI-22188


Repository: ambari


Description
---

make sure that hive directories needed by replication is created on hive server 
start if configured


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 8e176b69ac 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 1d68ef4217 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py
 e7e92ec985 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py
 f6b676b65e 


Diff: https://reviews.apache.org/r/62866/diff/1/


Testing
---

mvn clean test, cluster deploy


Thanks,

Eugene Chekanskiy

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

2017-10-10 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187538
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
Lines 600-601 (original), 601-604 (patched)


Depending on when in the upgrade this configure action runs, this could 
either be the old or the new repo.


- Jonathan Hurley


On Oct. 10, 2017, 12:58 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 10, 2017, 12:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  ec4d383dee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 44d76afcd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  6b32d4c75e 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-10 Thread Nate Cole



> On Oct. 9, 2017, 10:15 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
> > Lines 149 (patched)
> > 
> >
> > Should we move this around the switch statement in case anymore case's 
> > are added in the future which should also be skipped?

I was thinking an if/continue before the switch - there's no other code after 
that.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62851/#review187486
---


On Oct. 9, 2017, 5:19 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62851/
> ---
> 
> (Updated Oct. 9, 2017, 5:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22178
> https://issues.apache.org/jira/browse/AMBARI-22178
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The HostVersionOutOfSyncListener is incorrectly setting ALL other 
> host_version records to OUT_OF_SYNC other than what the newly-added component 
> is for.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
>  78744613ed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
>  076190a47d 
> 
> 
> Diff: https://reviews.apache.org/r/62851/diff/1/
> 
> 
> Testing
> ---
> 
> Manual added host and added new service to verify records.  Unit tests 
> pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62808: hadooplzo package installation failed on devdeploys

2017-10-10 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62808/#review187515
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 10, 2017, 11:05 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62808/
> ---
> 
> (Updated Жов. 10, 2017, 11:05 до полудня)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22160
> https://issues.apache.org/jira/browse/AMBARI-22160
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Packages which installed via install_packages used different code to get 
> package version than the one used to get versions of packages during start 
> (e.g. lzo).
> I merged them into a single method.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> a1fd1f37f1 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 370b776914 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 7091298cbc 
> 
> 
> Diff: https://reviews.apache.org/r/62808/diff/4/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 62808: hadooplzo package installation failed on devdeploys

2017-10-10 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62808/
---

(Updated Oct. 10, 2017, 11:05 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Vitalyi Brodetskyi.


Bugs: AMBARI-22160
https://issues.apache.org/jira/browse/AMBARI-22160


Repository: ambari


Description
---

Packages which installed via install_packages used different code to get 
package version than the one used to get versions of packages during start 
(e.g. lzo).
I merged them into a single method.


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
a1fd1f37f1 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
370b776914 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 7091298cbc 


Diff: https://reviews.apache.org/r/62808/diff/3/

Changes: https://reviews.apache.org/r/62808/diff/2-3/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-10 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62851/#review187510
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 10, 2017, 12:19 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62851/
> ---
> 
> (Updated Oct. 10, 2017, 12:19 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22178
> https://issues.apache.org/jira/browse/AMBARI-22178
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The HostVersionOutOfSyncListener is incorrectly setting ALL other 
> host_version records to OUT_OF_SYNC other than what the newly-added component 
> is for.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
>  78744613ed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
>  076190a47d 
> 
> 
> Diff: https://reviews.apache.org/r/62851/diff/1/
> 
> 
> Testing
> ---
> 
> Manual added host and added new service to verify records.  Unit tests 
> pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62848: Not able to perform revert after deleting the upgraded service

2017-10-10 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62848/#review187509
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 9, 2017, 10:06 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62848/
> ---
> 
> (Updated Oct. 9, 2017, 10:06 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22166
> https://issues.apache.org/jira/browse/AMBARI-22166
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After deleting a service, you can't revert a PATCH or MAINT upgrade. This is 
> because we iterate over all prior services when creating the upgrade context 
> for the reversion.
> 
> STR:
> - Install ZK, HDFS, and Storm
> - Upgrade ZK and Storm using a PATCH or MAINT VDF
> - Remove Storm
> - Revert the prior patch
> 
> ```
> 09 Oct 2017 10:02:59,142 ERROR [ambari-client-thread-22258] 
> AbstractResourceProvider:285 - Caught AmbariException when creating a resource
> org.apache.ambari.server.ServiceNotFoundException: Service not found, 
> clusterName=cl1, serviceName=ATLAS
>   at 
> org.apache.ambari.server.state.cluster.ClusterImpl.getService(ClusterImpl.java:863)
>   at 
> org.apache.ambari.server.state.UpgradeContext.(UpgradeContext.java:403)
>   at 
> org.apache.ambari.server.state.UpgradeContext$$FastClassByGuice$$6e2e5fe5.newInstance()
>   at 
> com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40)
>   at 
> com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:60)
>   at 
> com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85)
>   at 
> com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254)
>   at 
> com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978)
>   at 
> com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1024)
>   at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974)
>   at 
> com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632)
>   at com.sun.proxy.$Proxy31.create(Unknown Source)
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  9f31ab8a62 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java
>  5cf9a4c859 
> 
> 
> Diff: https://reviews.apache.org/r/62848/diff/2/
> 
> 
> Testing
> ---
> 
> Manual reversion of a PATCH after removing a service.
> 
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4915, Failures: 0, Errors: 0, Skipped: 34
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 62883: Zeppelin start fails due to permission denied error during kinit

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

Re: Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

Review Request 62802: clusterSettingsCode10thoctWithCHanges_ReadOnlyConfigurationResponse.patch

Re: Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

Re: Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

Re: Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

Review Request 62866: Make hive server create directories related to replication

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

Re: Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

Re: Review Request 62808: hadooplzo package installation failed on devdeploys

Re: Review Request 62808: hadooplzo package installation failed on devdeploys

Re: Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

Re: Review Request 62848: Not able to perform revert after deleting the upgraded service

25 matches

Site Navigation

Mail list logo

Footer information