Re: Review Request 63027: Allow wildcard for log directory folder in the path component of Logfeeder input

2017-10-18 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63027/
---

(Updated Oct. 18, 2017, 9:19 a.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

- too much wait for wait intervals
- do some recommended changes by Miklos


Bugs: AMBARI-21145
https://issues.apache.org/jira/browse/AMBARI-21145


Repository: ambari


Description
---

Allow wildcards for handling log directories. Using ant library for this. (on 
trunk, the solution will be JDK 8 based, so its a temporal hack for 2.6.1, for 
trunk some classes have cleaned up, so the implementation there will be 
different)

The idea is if we have a folder pattern, we will craete a thread group, and 
there will be different threads for every matching input (now only for tail 
file)

Also there is 2 new thread introduced:
- one which checks is the monitored file too old, if it is, stop the thread for 
that (detach)
- an another one which checks there is any new file available (like log files 
with date patterns in its name), and if it is, update the monitoring thread 
with that (log path upgrade)

Introduced some new configuration as well for inputs:
- path_update_interval_min: the period in minutes for checking new files 
(default: 5,  based on detach values, its possible that a new input wont be 
monitored)
- detach_interval_min: the period in minutes for checking which files are too 
old (default: 300)
- detach_time_min: the period in minutes when we flag a file is too old 
(default: 2000)

Also fix an issue which cause that we cannot use grok field names more deeply 
(use deep_extract param for this one in grok filter) and i updated the docker 
container as well to make it work with branch-2.6 (and use different version 
for container in order to keep that)


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 7e2da70 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 9f54d8a 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
 3737839 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFileDetachMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFilePathUpdateMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
 0ece637 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
 ffd6cec 
  ambari-logsearch/docker/Dockerfile dfa1462 
  ambari-logsearch/docker/logsearch-docker.sh a2df90f 


Diff: https://reviews.apache.org/r/63027/diff/2/

Changes: https://reviews.apache.org/r/63027/diff/1-2/


Testing
---

done, no UTs here, FTs are in progress


Thanks,

Oliver Szabo

Re: Review Request 63027: Allow wildcard for log directory folder in the path component of Logfeeder input

2017-10-18 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63027/
---

(Updated Oct. 18, 2017, 9:24 a.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

change FileUtils getInputFiles method name


Bugs: AMBARI-21145
https://issues.apache.org/jira/browse/AMBARI-21145


Repository: ambari


Description
---

Allow wildcards for handling log directories. Using ant library for this. (on 
trunk, the solution will be JDK 8 based, so its a temporal hack for 2.6.1, for 
trunk some classes have cleaned up, so the implementation there will be 
different)

The idea is if we have a folder pattern, we will craete a thread group, and 
there will be different threads for every matching input (now only for tail 
file)

Also there is 2 new thread introduced:
- one which checks is the monitored file too old, if it is, stop the thread for 
that (detach)
- an another one which checks there is any new file available (like log files 
with date patterns in its name), and if it is, update the monitoring thread 
with that (log path upgrade)

Introduced some new configuration as well for inputs:
- path_update_interval_min: the period in minutes for checking new files 
(default: 5,  based on detach values, its possible that a new input wont be 
monitored)
- detach_interval_min: the period in minutes for checking which files are too 
old (default: 300)
- detach_time_min: the period in minutes when we flag a file is too old 
(default: 2000)

Also fix an issue which cause that we cannot use grok field names more deeply 
(use deep_extract param for this one in grok filter) and i updated the docker 
container as well to make it work with branch-2.6 (and use different version 
for container in order to keep that)


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 7e2da70 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 9f54d8a 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
 3737839 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFileDetachMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFilePathUpdateMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
 0ece637 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
 ffd6cec 
  ambari-logsearch/docker/Dockerfile dfa1462 
  ambari-logsearch/docker/logsearch-docker.sh a2df90f 


Diff: https://reviews.apache.org/r/63027/diff/3/

Changes: https://reviews.apache.org/r/63027/diff/2-3/


Testing
---

done, no UTs here, FTs are in progress


Thanks,

Oliver Szabo

Re: Review Request 63027: Allow wildcard for log directory folder in the path component of Logfeeder input

2017-10-18 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63027/
---

(Updated Oct. 18, 2017, 9:38 a.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

- getting regex log file path fix


Bugs: AMBARI-21145
https://issues.apache.org/jira/browse/AMBARI-21145


Repository: ambari


Description
---

Allow wildcards for handling log directories. Using ant library for this. (on 
trunk, the solution will be JDK 8 based, so its a temporal hack for 2.6.1, for 
trunk some classes have cleaned up, so the implementation there will be 
different)

The idea is if we have a folder pattern, we will craete a thread group, and 
there will be different threads for every matching input (now only for tail 
file)

Also there is 2 new thread introduced:
- one which checks is the monitored file too old, if it is, stop the thread for 
that (detach)
- an another one which checks there is any new file available (like log files 
with date patterns in its name), and if it is, update the monitoring thread 
with that (log path upgrade)

Introduced some new configuration as well for inputs:
- path_update_interval_min: the period in minutes for checking new files 
(default: 5,  based on detach values, its possible that a new input wont be 
monitored)
- detach_interval_min: the period in minutes for checking which files are too 
old (default: 300)
- detach_time_min: the period in minutes when we flag a file is too old 
(default: 2000)

Also fix an issue which cause that we cannot use grok field names more deeply 
(use deep_extract param for this one in grok filter) and i updated the docker 
container as well to make it work with branch-2.6 (and use different version 
for container in order to keep that)


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 7e2da70 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 9f54d8a 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
 3737839 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFileDetachMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFilePathUpdateMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
 0ece637 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
 ffd6cec 
  ambari-logsearch/docker/Dockerfile dfa1462 
  ambari-logsearch/docker/logsearch-docker.sh a2df90f 


Diff: https://reviews.apache.org/r/63027/diff/4/

Changes: https://reviews.apache.org/r/63027/diff/3-4/


Testing
---

done, no UTs here, FTs are in progress


Thanks,

Oliver Szabo

Re: Review Request 63027: Allow wildcard for log directory folder in the path component of Logfeeder input

2017-10-18 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63027/
---

(Updated Oct. 18, 2017, 9:57 a.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

set multi folder value on init


Bugs: AMBARI-21145
https://issues.apache.org/jira/browse/AMBARI-21145


Repository: ambari


Description
---

Allow wildcards for handling log directories. Using ant library for this. (on 
trunk, the solution will be JDK 8 based, so its a temporal hack for 2.6.1, for 
trunk some classes have cleaned up, so the implementation there will be 
different)

The idea is if we have a folder pattern, we will craete a thread group, and 
there will be different threads for every matching input (now only for tail 
file)

Also there is 2 new thread introduced:
- one which checks is the monitored file too old, if it is, stop the thread for 
that (detach)
- an another one which checks there is any new file available (like log files 
with date patterns in its name), and if it is, update the monitoring thread 
with that (log path upgrade)

Introduced some new configuration as well for inputs:
- path_update_interval_min: the period in minutes for checking new files 
(default: 5,  based on detach values, its possible that a new input wont be 
monitored)
- detach_interval_min: the period in minutes for checking which files are too 
old (default: 300)
- detach_time_min: the period in minutes when we flag a file is too old 
(default: 2000)

Also fix an issue which cause that we cannot use grok field names more deeply 
(use deep_extract param for this one in grok filter) and i updated the docker 
container as well to make it work with branch-2.6 (and use different version 
for container in order to keep that)


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 7e2da70 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
 41a1fa5 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 9f54d8a 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
 3737839 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFileDetachMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFilePathUpdateMonitor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
 0ece637 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
 ffd6cec 
  ambari-logsearch/docker/Dockerfile dfa1462 
  ambari-logsearch/docker/logsearch-docker.sh a2df90f 


Diff: https://reviews.apache.org/r/63027/diff/5/

Changes: https://reviews.apache.org/r/63027/diff/4-5/


Testing
---

done, no UTs here, FTs are in progress


Thanks,

Oliver Szabo

Re: Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

2017-10-18 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62923/#review188479
---


Ship it!




Ship It!

- Nate Cole


On Oct. 12, 2017, 2:20 a.m., Yussuf Shaikh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62923/
> ---
> 
> (Updated Oct. 12, 2017, 2:20 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22200
> https://issues.apache.org/jira/browse/AMBARI-22200
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to add a new function in ambari-server Configuration class to read a 
> property from file read.
> This is required for reading custom properties added to the ambari.properties 
> file from backend (eg:python script) without restarting the server.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  1b4d741 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  1b8de79 
> 
> 
> Diff: https://reviews.apache.org/r/62923/diff/1/
> 
> 
> Testing
> ---
> 
> all tests pass on ambari-server
> 
> 
> Thanks,
> 
> Yussuf Shaikh
> 
>

Re: Review Request 63071: A bunch of services fail to start

2017-10-18 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63071/#review188484
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 17, 2017, 11:32 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63071/
> ---
> 
> (Updated Жов. 17, 2017, 11:32 до полудня)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-22251
> https://issues.apache.org/jira/browse/AMBARI-22251
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Test full stack deployment and find services which fail to
> install/start/service_check.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py 
> af11cc534e 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8813243030 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  12356ed3b3 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  aed635e329 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  e039606ae4 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/params.py
>  b01884c6ec 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/status_params.py
>  6590478aa3 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  afbbb5f38a 
>   
> ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/params.py
>  8cb7a0b6a5 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
>  79bfd62a0e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  58b44c424a 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  3b4ab30382 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_linux.py
>  fff1167c18 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  c733ddbfeb 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py
>  c18e422c0a 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/params.py
>  937c4b572d 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  e46ce7831d 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/params.py
>  0f2acca3bb 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/status_params.py
>  8a840fb3c2 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  16c59ca061 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/params_linux.py
>  b12ffefb45 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/params_windows.py
>  631146d2e1 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/status_params.py
>  699d9a847e 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
>  64d7c5a8ec 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
>  b090e9885f 
>   
> ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/package/scripts/params.py
>  1e968a3d0d 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/package/scripts/params.py
>  156db10f6d 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  63cee09b7c 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/params.py
>  1d36a75c8c 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  2d6469cca9 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/params_linux.py
>  664c582262 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/status_params.py
>  7d97203e51 
>   
> ambari-server/src/main/resources/common-services/SUPERSET/0.15.0/package/scripts/params.py
>  df0d9fd980 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
>  a1faf772a3 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_windows.py
>  a1faf772a3 
>   
> ambari-server/src/main/resources/commo

Re: Review Request 63051: Add service group dependencies

2017-10-18 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/#review188485
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 17, 2017, 8:38 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63051/
> ---
> 
> (Updated Жов. 17, 2017, 8:38 після полудня)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add table servicegroupdependencies
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
>  53c3d1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  7f8facb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 9850462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
>  7146bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  735a946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fcc07b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63051/diff/2/
> 
> 
> Testing
> ---
> 
> Will fix tests after patch approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63051: Add service group dependencies

2017-10-18 Thread Vitalyi Brodetskyi 


> On Жов. 18, 2017, 1:43 після полудня, Vitalyi Brodetskyi wrote:
> > Ship It!

Wrong review request)))


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/#review188485
---


On Жов. 17, 2017, 8:38 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63051/
> ---
> 
> (Updated Жов. 17, 2017, 8:38 після полудня)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add table servicegroupdependencies
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
>  53c3d1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  7f8facb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 9850462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
>  7146bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  735a946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fcc07b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63051/diff/2/
> 
> 
> Testing
> ---
> 
> Will fix tests after patch approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63027: Allow wildcard for log directory folder in the path component of Logfeeder input

2017-10-18 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63027/#review188495
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 18, 2017, 9:57 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63027/
> ---
> 
> (Updated Oct. 18, 2017, 9:57 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21145
> https://issues.apache.org/jira/browse/AMBARI-21145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow wildcards for handling log directories. Using ant library for this. (on 
> trunk, the solution will be JDK 8 based, so its a temporal hack for 2.6.1, 
> for trunk some classes have cleaned up, so the implementation there will be 
> different)
> 
> The idea is if we have a folder pattern, we will craete a thread group, and 
> there will be different threads for every matching input (now only for tail 
> file)
> 
> Also there is 2 new thread introduced:
> - one which checks is the monitored file too old, if it is, stop the thread 
> for that (detach)
> - an another one which checks there is any new file available (like log files 
> with date patterns in its name), and if it is, update the monitoring thread 
> with that (log path upgrade)
> 
> Introduced some new configuration as well for inputs:
> - path_update_interval_min: the period in minutes for checking new files 
> (default: 5,  based on detach values, its possible that a new input wont be 
> monitored)
> - detach_interval_min: the period in minutes for checking which files are too 
> old (default: 300)
> - detach_time_min: the period in minutes when we flag a file is too old 
> (default: 2000)
> 
> Also fix an issue which cause that we cannot use grok field names more deeply 
> (use deep_extract param for this one in grok filter) and i updated the docker 
> container as well to make it work with branch-2.6 (and use different version 
> for container in order to keep that)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  7e2da70 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
>  41a1fa5 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  9f54d8a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  3737839 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFileDetachMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFilePathUpdateMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
>  0ece637 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
>  ffd6cec 
>   ambari-logsearch/docker/Dockerfile dfa1462 
>   ambari-logsearch/docker/logsearch-docker.sh a2df90f 
> 
> 
> Diff: https://reviews.apache.org/r/63027/diff/5/
> 
> 
> Testing
> ---
> 
> done, no UTs here, FTs are in progress
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63051: Add service group dependencies

2017-10-18 Thread Myroslav Papirkovskyy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/#review188496
---




ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
Lines 29 (patched)


It will be nice to replace map with POJO:
Something like Set will make whole patch easier to read 
and remove hardcoded key names.


- Myroslav Papirkovskyy


On Жов. 17, 2017, 11:38 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63051/
> ---
> 
> (Updated Жов. 17, 2017, 11:38 після полудня)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add table servicegroupdependencies
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
>  53c3d1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  7f8facb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 9850462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
>  7146bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  735a946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fcc07b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63051/diff/2/
> 
> 
> Testing
> ---
> 
> Will fix tests after patch approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 63111: Mahout service check failure after patch upgrade

2017-10-18 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63111/
---

Review request for Ambari and Jonathan Hurley.


Bugs: AMBARI-22265
https://issues.apache.org/jira/browse/AMBARI-22265


Repository: ambari


Description
---

There is a dependency of MR2 for Mahout.  Adding this dependency for validation 
purposes until the stack folks can work it out.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
 b8655d7729 


Diff: https://reviews.apache.org/r/63111/diff/1/


Testing
---

Manual verification.


Thanks,

Nate Cole

Re: Review Request 63111: Mahout service check failure after patch upgrade

2017-10-18 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63111/#review188525
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 18, 2017, 11:42 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63111/
> ---
> 
> (Updated Oct. 18, 2017, 11:42 a.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22265
> https://issues.apache.org/jira/browse/AMBARI-22265
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There is a dependency of MR2 for Mahout.  Adding this dependency for 
> validation purposes until the stack folks can work it out.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  b8655d7729 
> 
> 
> Diff: https://reviews.apache.org/r/63111/diff/1/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 63118: Log Search server does not handle proxies properly

2017-10-18 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63118/
---

Review request for Ambari, Miklos Gergely and Robert Nettleton.


Bugs: AMBARI-22266
https://issues.apache.org/jira/browse/AMBARI-22266


Repository: ambari


Description
---

If logsearch running behind a proxy and the address is not on root, UI cannot 
be accessed/handled properly.

(like: localhost:61888 can be accessed through localhost:8080/logsearch/)

Regarding to that issue, there are some backend changes that required:
- form login filter needs to be removed, as we have are custom login entripoint 
already (that form login filter is basically the same, so we had 2 different 
filter on each other, which did the same)
- add useForward (configurable) to our login entrypoint, to make it possible to 
send redirects through proxies properly
- on logout: add useReferer, which can be used if logsearch is behind a proxy, 
it can use the referer location instead of the root one.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
 54cc10c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 2f9cba4 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchLogoutSuccessHandler.java
 c20e383 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
 1831697 


Diff: https://reviews.apache.org/r/63118/diff/1/


Testing
---

done, works with both proxies and without proxies (for proxies there should be 
some ui changes as well)


Thanks,

Oliver Szabo

Review Request 63123: Version registration failure during patch upgrade + Debian + Oracle run

2017-10-18 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63123/
---

Review request for Ambari and Nate Cole.


Repository: ambari


Description
---

Oracle doesn't allow DISTINCT on clob fields...

```
SELECT DISTINCT 
  t0.repo_version_id, t0.display_name, t0.hidden, t0.legacy, t0.repositories, 
t0.resolved, t0.repo_type, t0.version, t0.version_url, 
  t0.version_xml, t0.version_xsd, t0.parent_id, t0.stack_id 
FROM repo_version t0, servicedesiredstate t1 
WHERE ((t1.desired_repo_version_id IN ?) AND (t0.repo_version_id = 
t1.desired_repo_version_id))
```

```
WARN [ambari-client-thread-17969] ServletHandler:561 - Error Processing URI: 
/api/v1/version_definitions - (javax.persistence.PersistenceException) 
Exception [EclipseLink-4002] (Eclipse Persistence Services - 
2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
Internal Exception: java.sql.SQLSyntaxErrorException: ORA-00932: inconsistent 
datatypes: expected - got CLOB
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 edfe4944b6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
 0124d3e71c 


Diff: https://reviews.apache.org/r/63123/diff/1/


Testing
---

PENDING...


Thanks,

Jonathan Hurley

Re: Review Request 63123: Version registration failure during patch upgrade + Debian + Oracle run

2017-10-18 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63123/#review188576
---


Ship it!




Ship It!

- Nate Cole


On Oct. 18, 2017, 4:47 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63123/
> ---
> 
> (Updated Oct. 18, 2017, 4:47 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Oracle doesn't allow DISTINCT on clob fields...
> 
> ```
> SELECT DISTINCT 
>   t0.repo_version_id, t0.display_name, t0.hidden, t0.legacy, t0.repositories, 
> t0.resolved, t0.repo_type, t0.version, t0.version_url, 
>   t0.version_xml, t0.version_xsd, t0.parent_id, t0.stack_id 
> FROM repo_version t0, servicedesiredstate t1 
> WHERE ((t1.desired_repo_version_id IN ?) AND (t0.repo_version_id = 
> t1.desired_repo_version_id))
> ```
> 
> ```
> WARN [ambari-client-thread-17969] ServletHandler:561 - Error Processing URI: 
> /api/v1/version_definitions - (javax.persistence.PersistenceException) 
> Exception [EclipseLink-4002] (Eclipse Persistence Services - 
> 2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
> Internal Exception: java.sql.SQLSyntaxErrorException: ORA-00932: inconsistent 
> datatypes: expected - got CLOB
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  edfe4944b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
>  0124d3e71c 
> 
> 
> Diff: https://reviews.apache.org/r/63123/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 63118: Log Search server does not handle proxies properly

2017-10-18 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63118/#review188580
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 18, 2017, 6:47 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63118/
> ---
> 
> (Updated Oct. 18, 2017, 6:47 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22266
> https://issues.apache.org/jira/browse/AMBARI-22266
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If logsearch running behind a proxy and the address is not on root, UI cannot 
> be accessed/handled properly.
> 
> (like: localhost:61888 can be accessed through localhost:8080/logsearch/)
> 
> Regarding to that issue, there are some backend changes that required:
> - form login filter needs to be removed, as we have are custom login 
> entripoint already (that form login filter is basically the same, so we had 2 
> different filter on each other, which did the same)
> - add useForward (configurable) to our login entrypoint, to make it possible 
> to send redirects through proxies properly
> - on logout: add useReferer, which can be used if logsearch is behind a 
> proxy, it can use the referer location instead of the root one.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
>  54cc10c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  2f9cba4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchLogoutSuccessHandler.java
>  c20e383 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
>  1831697 
> 
> 
> Diff: https://reviews.apache.org/r/63118/diff/1/
> 
> 
> Testing
> ---
> 
> done, works with both proxies and without proxies (for proxies there should 
> be some ui changes as well)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63051: Add service group dependencies

2017-10-18 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/
---

(Updated Жов. 18, 2017, 11:59 після полудня)


Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
Shridhar.


Bugs: AMBARI-22249
https://issues.apache.org/jira/browse/AMBARI-22249


Repository: ambari


Description
---

Add table servicegroupdependencies


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
 53c3d1e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
 147650c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
 2e935af 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
 7f8facb 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
8fd878e 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
9850462 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
 7146bdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
 735a946 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 fcc07b6 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 0434728 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 


Diff: https://reviews.apache.org/r/63051/diff/3/

Changes: https://reviews.apache.org/r/63051/diff/2-3/


Testing
---

Will fix tests after patch approve


Thanks,

Vitalyi Brodetskyi

Review Request 63138: Update Spark2 log4j default settings to latest

2017-10-18 Thread Saisai Shao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63138/
---

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-22260
https://issues.apache.org/jira/browse/AMBARI-22260


Repository: ambari


Description
---

Update Ambari Spark2 log4j related configurations.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
d138d6017c 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 8012c90b0b 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
7c43948ba3 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/spark2-log4j-properties.xml
 PRE-CREATION 


Diff: https://reviews.apache.org/r/63138/diff/1/


Testing
---

Manually verification on refresh install of HDP 2.6 and upgrade from HDP 2.5.


Thanks,

Saisai Shao

Re: Review Request 63118: Log Search server does not handle proxies properly

2017-10-18 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63118/#review188641
---


Ship it!




Ship It!

- Miklos Gergely


On Oct. 18, 2017, 6:47 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63118/
> ---
> 
> (Updated Oct. 18, 2017, 6:47 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22266
> https://issues.apache.org/jira/browse/AMBARI-22266
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If logsearch running behind a proxy and the address is not on root, UI cannot 
> be accessed/handled properly.
> 
> (like: localhost:61888 can be accessed through localhost:8080/logsearch/)
> 
> Regarding to that issue, there are some backend changes that required:
> - form login filter needs to be removed, as we have are custom login 
> entripoint already (that form login filter is basically the same, so we had 2 
> different filter on each other, which did the same)
> - add useForward (configurable) to our login entrypoint, to make it possible 
> to send redirects through proxies properly
> - on logout: add useReferer, which can be used if logsearch is behind a 
> proxy, it can use the referer location instead of the root one.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
>  54cc10c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  2f9cba4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchLogoutSuccessHandler.java
>  c20e383 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
>  1831697 
> 
> 
> Diff: https://reviews.apache.org/r/63118/diff/1/
> 
> 
> Testing
> ---
> 
> done, works with both proxies and without proxies (for proxies there should 
> be some ui changes as well)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>