Re: Review Request 63196: Avoid Log Feeder NPEs for logs of services not present on the node, but present on the cluster

2017-10-23 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63196/#review188937
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 21, 2017, 12:58 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63196/
> ---
> 
> (Updated Oct. 21, 2017, 12:58 a.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Oliver Szabo, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22281
> https://issues.apache.org/jira/browse/AMBARI-22281
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Due to a bug Log Feeders throw NPEs while searching for logs of services 
> which are not present on the node, but present on the cluster.
> 
> The problem was caused by the fact that File.listFiles(FileFilter) returns 
> null if the file it's called on is not an existing directory, and 
> Arrays.sort() throws an NPE if it's argument is null.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  e24a7aa 
> 
> 
> Diff: https://reviews.apache.org/r/63196/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 63219: Update Kerberos Authentication process to work with improved user management facility

2017-10-23 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63219/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian 
Toader.


Bugs: AMBARI-21223
https://issues.apache.org/jira/browse/AMBARI-21223


Repository: ambari


Description
---

Update Kerberos Authentication process to work with improved user management 
facility


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 205debc169 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 c4e5ccee44 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 fb78629983 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
 71fa175d36 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
 3ffa3e8f08 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java
 672444eba3 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
 261b94e6e8 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationProperties.java
 3e31e0d381 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java
 824fbdf8b7 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 a268467045 
  ambari-server/src/main/python/ambari-server.py 8fcde77ee4 
  ambari-server/src/main/python/ambari_server/kerberos_setup.py 74b2d3e39f 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 2b78f791aa 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
 f109c6875f 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
 49e8a8f4ee 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilterTest.java
 debfaf68a9 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsServiceTest.java
 c6ee706c21 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java
 6908c559ce 


Diff: https://reviews.apache.org/r/63219/diff/1/


Testing
---

Manually tested

# Local test results:  PENDING

# Jenkins test results:  PENDING


Thanks,

Robert Levas

Re: Review Request 63219: Update Kerberos Authentication process to work with improved user management facility

2017-10-23 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63219/#review188942
---




ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 1471-1476 (original)


Removing this since the concept of a user type is gone.  

Previously, Ambari allowed for multiple user accounts where the username 
was the same, but different (login) types - LOCAL, LDAP, etc In Ambari 
3.0.0, a user has an account and one or more authentication modes - LOCAL, 
LDAP, PAM, KERBEROS, etc...



ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
Line 58 (original)


Moved to `org.apache.ambari.server.security.authorization.Users` for better 
code reuse.



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
Lines 206 (patched)


Moved from 
`org.apache.ambari.server.security.authentication.AmbariAuthenticationProvider` 
for better code reuse.



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
Line 1245 (original)


Forgot to remove this when working on AMBARI-21217 (which has been 
comnitted)



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
Line 1326 (original)


Forgot to remove this when working on AMBARI-21221 (which has been 
comnitted)


- Robert Levas


On Oct. 23, 2017, 11:25 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63219/
> ---
> 
> (Updated Oct. 23, 2017, 11:25 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21223
> https://issues.apache.org/jira/browse/AMBARI-21223
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Kerberos Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  205debc169 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  c4e5ccee44 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  fb78629983 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  71fa175d36 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  3ffa3e8f08 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java
>  672444eba3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
>  261b94e6e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationProperties.java
>  3e31e0d381 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java
>  824fbdf8b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  a268467045 
>   ambari-server/src/main/python/ambari-server.py 8fcde77ee4 
>   ambari-server/src/main/python/ambari_server/kerberos_setup.py 74b2d3e39f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  2b78f791aa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
>  f109c6875f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  49e8a8f4ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilterTest.java
>  debfaf68a9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsServiceTest.java
>  c6ee706c21 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java
>  6908c559ce 
> 
> 
> Diff: https://reviews.apache.org/r/63219/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results:  PENDING
> 
> # Jenkins test results:  P

Re: Review Request 63219: Update Kerberos Authentication process to work with improved user management facility

2017-10-23 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63219/#review188943
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 23, 2017, 5:25 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63219/
> ---
> 
> (Updated Oct. 23, 2017, 5:25 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21223
> https://issues.apache.org/jira/browse/AMBARI-21223
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Kerberos Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  205debc169 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  c4e5ccee44 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  fb78629983 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  71fa175d36 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  3ffa3e8f08 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java
>  672444eba3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
>  261b94e6e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationProperties.java
>  3e31e0d381 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java
>  824fbdf8b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  a268467045 
>   ambari-server/src/main/python/ambari-server.py 8fcde77ee4 
>   ambari-server/src/main/python/ambari_server/kerberos_setup.py 74b2d3e39f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  2b78f791aa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
>  f109c6875f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  49e8a8f4ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilterTest.java
>  debfaf68a9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsServiceTest.java
>  c6ee706c21 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java
>  6908c559ce 
> 
> 
> Diff: https://reviews.apache.org/r/63219/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results:  PENDING
> 
> # Jenkins test results:  PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 63219: Update Kerberos Authentication process to work with improved user management facility

2017-10-23 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63219/
---

(Updated Oct. 23, 2017, 11:53 a.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian 
Toader.


Bugs: AMBARI-21223
https://issues.apache.org/jira/browse/AMBARI-21223


Repository: ambari


Description
---

Update Kerberos Authentication process to work with improved user management 
facility


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 205debc169 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 c4e5ccee44 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 fb78629983 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
 71fa175d36 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
 3ffa3e8f08 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java
 672444eba3 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
 261b94e6e8 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationProperties.java
 3e31e0d381 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java
 824fbdf8b7 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 a268467045 
  ambari-server/src/main/python/ambari-server.py 8fcde77ee4 
  ambari-server/src/main/python/ambari_server/kerberos_setup.py 74b2d3e39f 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 2b78f791aa 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
 f109c6875f 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
 49e8a8f4ee 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilterTest.java
 debfaf68a9 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsServiceTest.java
 c6ee706c21 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java
 6908c559ce 


Diff: https://reviews.apache.org/r/63219/diff/1/


Testing (updated)
---

Manually tested

# Local test results:  

```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 27:37 min
[INFO] Finished at: 2017-10-23T11:52:03-04:00
[INFO] Final Memory: 99M/2060M
[INFO] 
```

# Jenkins test results:  PENDING


Thanks,

Robert Levas

Re: Review Request 63219: Update Kerberos Authentication process to work with improved user management facility

2017-10-23 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63219/#review188962
---


Ship it!




Ship It!

- Nate Cole


On Oct. 23, 2017, 11:53 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63219/
> ---
> 
> (Updated Oct. 23, 2017, 11:53 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21223
> https://issues.apache.org/jira/browse/AMBARI-21223
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Kerberos Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  205debc169 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  c4e5ccee44 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  fb78629983 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  71fa175d36 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  3ffa3e8f08 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java
>  672444eba3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
>  261b94e6e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationProperties.java
>  3e31e0d381 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java
>  824fbdf8b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  a268467045 
>   ambari-server/src/main/python/ambari-server.py 8fcde77ee4 
>   ambari-server/src/main/python/ambari_server/kerberos_setup.py 74b2d3e39f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  2b78f791aa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
>  f109c6875f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  49e8a8f4ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilterTest.java
>  debfaf68a9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsServiceTest.java
>  c6ee706c21 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java
>  6908c559ce 
> 
> 
> Diff: https://reviews.apache.org/r/63219/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results:  
> 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 27:37 min
> [INFO] Finished at: 2017-10-23T11:52:03-04:00
> [INFO] Final Memory: 99M/2060M
> [INFO] 
> 
> ```
> 
> # Jenkins test results:  PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

2017-10-23 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62923/#review188964
---



Please close this review if it has been pushed.  If you need someone to do it, 
please ask on the JIRA.

- Nate Cole


On Oct. 12, 2017, 2:20 a.m., Yussuf Shaikh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62923/
> ---
> 
> (Updated Oct. 12, 2017, 2:20 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22200
> https://issues.apache.org/jira/browse/AMBARI-22200
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to add a new function in ambari-server Configuration class to read a 
> property from file read.
> This is required for reading custom properties added to the ambari.properties 
> file from backend (eg:python script) without restarting the server.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  1b4d741 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  1b8de79 
> 
> 
> Diff: https://reviews.apache.org/r/62923/diff/1/
> 
> 
> Testing
> ---
> 
> all tests pass on ambari-server
> 
> 
> Thanks,
> 
> Yussuf Shaikh
> 
>

Review Request 63222: PU: Could not install version when only build changes

2017-10-23 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63222/
---

Review request for Ambari and Jonathan Hurley.


Bugs: AMBARI-22292
https://issues.apache.org/jira/browse/AMBARI-22292


Repository: ambari


Description
---

Version comparison was not taking into account the build number.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 a20658304f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 7944de8e8c 
  ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java 
d3d859258d 
  
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
 8433518691 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java
 5141dc0fbf 


Diff: https://reviews.apache.org/r/63222/diff/1/


Testing
---

Manual.  Unit tests pending.


Thanks,

Nate Cole

Re: Review Request 63222: PU: Could not install version when only build changes

2017-10-23 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63222/#review188970
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 23, 2017, 2:04 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63222/
> ---
> 
> (Updated Oct. 23, 2017, 2:04 p.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22292
> https://issues.apache.org/jira/browse/AMBARI-22292
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Version comparison was not taking into account the build number.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  a20658304f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  7944de8e8c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java 
> d3d859258d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  8433518691 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java
>  5141dc0fbf 
> 
> 
> Diff: https://reviews.apache.org/r/63222/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Unit tests pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-10-23 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63205/#review188978
---




ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
Lines 1065 (patched)


Rename to {stackName}/versions/{stackVersion}/settings instead?


- Jayush Luniya


On Oct. 22, 2017, 11:46 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63205/
> ---
> 
> (Updated Oct. 22, 2017, 11:46 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22198
> https://issues.apache.org/jira/browse/AMBARI-22198
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This JIRA work assumes the following things to be present in the stack (3.0 
> onwards) coming from the mpack (as there is no inheritance in stacks, given 
> the flat stack structure coming from mpacks):
> 
> - **settings.xml** file in 
> **/var/lib/ambari-server/resources/stacks///configuration**
> 
> - **stack_features.json**, **stack_packages.json** and **stack_tools.json** 
> present in 
> **/var/lib/ambari-server/resources/stacks///properties/**
>  directory.
> 
> 
> Above work is done as part of JIRA : AMBARI-22285
> 
> 
> --
> 
> 
> **Work done in this Rveiew Request:**
> 
> - Implement the new read only 
> http://:/api/v1/stacks//versions//stack_settings
>  API.
> It serves the following settings : **stack_features**, **stack_name**, 
> **stack_packages**, **stack_root** and **stack_tools**.
> 
> - Renaming of files for Cluster Settings related code (work done in  
> AMBARI-22196).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootStackSettingsResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  2bb450b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
>  d77b347 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  aef7fc1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  ce61497 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  28b5c28 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootStackSettingsResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
>  4cb6cd9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
>  fcda654 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManagerFactory.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 878415b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 07d28ce 
> 
> 
> Diff: https://reviews.apache.org/r/63205/diff/1/
> 
> 
> Testing
> ---
> 
> **Testing on 2.6 stack** (stack version in general has no effect on what we 
> are testing here)
> 
> 
> - **GET http://:/api/v1/stacks/HDP/versions/2.6/stack_settings**
> 
> 
> {
>   "href" : "http://:/api/v1/stacks/HDP/versions/2.6/stack_settings",
>   "items" : [
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/stack_settings/stack_features",
>   "StackSettingsInfo" : {
> "property_name" : "stack_features",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/stack_settings/stack_name",
>   "StackSettingsInfo" : {
> "property_name" : "stack_name",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/stack_settings/stack_packages",
>   "StackSettingsInfo" : {
>

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-10-23 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63205/
---

(Updated Oct. 24, 2017, 1:55 a.m.)


Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Changes
---

Changed API name from :

- "http://:/api/v1/stacks/HDP/versions/2.6/stack_settings", to
 
- "http://:/api/v1/stacks/HDP/versions/2.6/settings".


Bugs: AMBARI-22198
https://issues.apache.org/jira/browse/AMBARI-22198


Repository: ambari


Description (updated)
---

This JIRA work assumes the following things to be present in the stack (3.0 
onwards) coming from the mpack (as there is no inheritance in stacks, given the 
flat stack structure coming from mpacks):

- **settings.xml** file in 
**/var/lib/ambari-server/resources/stacks///configuration**

- **stack_features.json**, **stack_packages.json** and **stack_tools.json** 
present in 
**/var/lib/ambari-server/resources/stacks///properties/**
 directory.


Above work is done as part of JIRA : AMBARI-22285


--


**Work done in this Rveiew Request:**

- Implement the new read only 
http://:/api/v1/stacks//versions//settings 
API.
It serves the following settings : **stack_features**, **stack_name**, 
**stack_packages**, **stack_root** and **stack_tools**.

- Renaming of files for Cluster Settings related code (work done in  
AMBARI-22196).


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 737b9b4 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootStackSettingsResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 2bb450b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
 d77b347 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
 aef7fc1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 ce61497 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 28b5c28 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 3117186 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 b8c1674 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootStackSettingsResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 6a76fff 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
 4cb6cd9 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
 fcda654 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManagerFactory.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
878415b 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
07d28ce 


Diff: https://reviews.apache.org/r/63205/diff/2/

Changes: https://reviews.apache.org/r/63205/diff/1-2/


Testing (updated)
---

**Testing on 2.6 stack** (stack version in general has no effect on what we are 
testing here)


- **GET http://:/api/v1/stacks/HDP/versions/2.6/settings**


{
  "href" : "http://:/api/v1/stacks/HDP/versions/2.6/settings",
  "items" : [
{
  "href" : 
"http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_features",
  "StackSettingsInfo" : {
"property_name" : "stack_features",
"stack_name" : "HDP",
"stack_version" : "2.6"
  }
},
{
  "href" : 
"http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_name",
  "StackSettingsInfo" : {
"property_name" : "stack_name",
"stack_name" : "HDP",
"stack_version" : "2.6"
  }
},
{
  "href" : 
"http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_packages",
  "StackSettingsInfo" : {
"property_name" : "stack_packages",
"stack_name" : "HDP",
"stack_version" : "2.6"
  }
},
{
  "href" : 
"http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_root",
  "StackSettingsInfo" : {
"property_name" : "stack_root",
"stack_name" : "HDP",
"stack_version" : "2.6"
  }
},
{
  "href" : 
"http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_tools",
  "StackSettingsInfo" : {
"property_name" : "stack_tools",
"stack_name" : "HDP",
"stack_version" : "2.6"
  }
}
  ]
}


- **GET 
http://:/api/v1/sta

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-10-23 Thread Swapan Shridhar 


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63205/#review188978
---


On Oct. 24, 2017, 1:55 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63205/
> ---
> 
> (Updated Oct. 24, 2017, 1:55 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22198
> https://issues.apache.org/jira/browse/AMBARI-22198
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This JIRA work assumes the following things to be present in the stack (3.0 
> onwards) coming from the mpack (as there is no inheritance in stacks, given 
> the flat stack structure coming from mpacks):
> 
> - **settings.xml** file in 
> **/var/lib/ambari-server/resources/stacks///configuration**
> 
> - **stack_features.json**, **stack_packages.json** and **stack_tools.json** 
> present in 
> **/var/lib/ambari-server/resources/stacks///properties/**
>  directory.
> 
> 
> Above work is done as part of JIRA : AMBARI-22285
> 
> 
> --
> 
> 
> **Work done in this Rveiew Request:**
> 
> - Implement the new read only 
> http://:/api/v1/stacks//versions//settings 
> API.
> It serves the following settings : **stack_features**, **stack_name**, 
> **stack_packages**, **stack_root** and **stack_tools**.
> 
> - Renaming of files for Cluster Settings related code (work done in  
> AMBARI-22196).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootStackSettingsResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  2bb450b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
>  d77b347 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  aef7fc1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  ce61497 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  28b5c28 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootStackSettingsResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
>  4cb6cd9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
>  fcda654 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManagerFactory.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 878415b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 07d28ce 
> 
> 
> Diff: https://reviews.apache.org/r/63205/diff/2/
> 
> 
> Testing
> ---
> 
> **Testing on 2.6 stack** (stack version in general has no effect on what we 
> are testing here)
> 
> 
> - **GET http://:/api/v1/stacks/HDP/versions/2.6/settings**
> 
> 
> {
>   "href" : "http://:/api/v1/stacks/HDP/versions/2.6/settings",
>   "items" : [
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_features",
>   "StackSettingsInfo" : {
> "property_name" : "stack_features",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_name",
>   "StackSettingsInfo" : {
> "property_name" : "stack_name",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_packages",
>   "StackSettingsInfo" : {
> "property_name" : "stack_packages",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_root",
>   "StackSettingsInfo" : {
> "property_name" : "s

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-10-23 Thread Swapan Shridhar 


> On Oct. 23, 2017, 7:09 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
> > Lines 1065 (patched)
> > 
> >
> > Rename to {stackName}/versions/{stackVersion}/settings instead?

Updated.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63205/#review188978
---


On Oct. 24, 2017, 1:55 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63205/
> ---
> 
> (Updated Oct. 24, 2017, 1:55 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22198
> https://issues.apache.org/jira/browse/AMBARI-22198
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This JIRA work assumes the following things to be present in the stack (3.0 
> onwards) coming from the mpack (as there is no inheritance in stacks, given 
> the flat stack structure coming from mpacks):
> 
> - **settings.xml** file in 
> **/var/lib/ambari-server/resources/stacks///configuration**
> 
> - **stack_features.json**, **stack_packages.json** and **stack_tools.json** 
> present in 
> **/var/lib/ambari-server/resources/stacks///properties/**
>  directory.
> 
> 
> Above work is done as part of JIRA : AMBARI-22285
> 
> 
> --
> 
> 
> **Work done in this Rveiew Request:**
> 
> - Implement the new read only 
> http://:/api/v1/stacks//versions//settings 
> API.
> It serves the following settings : **stack_features**, **stack_name**, 
> **stack_packages**, **stack_root** and **stack_tools**.
> 
> - Renaming of files for Cluster Settings related code (work done in  
> AMBARI-22196).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootStackSettingsResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  2bb450b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
>  d77b347 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  aef7fc1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  ce61497 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  28b5c28 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootStackSettingsResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
>  4cb6cd9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
>  fcda654 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManagerFactory.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 878415b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 07d28ce 
> 
> 
> Diff: https://reviews.apache.org/r/63205/diff/2/
> 
> 
> Testing
> ---
> 
> **Testing on 2.6 stack** (stack version in general has no effect on what we 
> are testing here)
> 
> 
> - **GET http://:/api/v1/stacks/HDP/versions/2.6/settings**
> 
> 
> {
>   "href" : "http://:/api/v1/stacks/HDP/versions/2.6/settings",
>   "items" : [
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_features",
>   "StackSettingsInfo" : {
> "property_name" : "stack_features",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_name",
>   "StackSettingsInfo" : {
> "property_name" : "stack_name",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settin