Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-07 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/
---

(Updated Nov. 7, 2017, 11:59 p.m.)


Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Changes
---

- Removed Event creation/removal for Cluster Setting.
- Changed primary key as cluster setting Id only, which is unique.


Bugs: AMBARI-22366
https://issues.apache.org/jira/browse/AMBARI-22366


Repository: ambari


Description
---

AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
(/clusters/{clusterName}/settings).

**Background:** AMBARI-22196 did the following : 
 (1). Refactoring work of moving all cluster related configs/settings in 
cluster-env to "cluster-settings" files.
 (2). Implementing READ only API to access *cluster-settings* file *setting(s)* 
: *http://:/api/v1/cluster_settings/ *

- This was done to separate cluster related configs from stack related configs.

**This JIRA implements the following :**

- POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
  *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
   -- the cluster settings would be initially read from the above mentioned 
read-only API : *http://:/api/v1/cluster_settings/*. 

- Further, added cluster *settings* as a sub-resource of *cluster* resource.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
 e5680dd 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 6096fa5 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 92f50f4 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 358b1bf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 370f735 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 3db55d4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 20f4864 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
 147650c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 9050e3d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 c219d23 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
 2e935af 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 bd6d7bb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
 abbf709 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
 3b74e69 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
5ba61b7 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSetting.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
 7737c0d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 e896d0e 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 19e23c5 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b1990df 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 015d6ac 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d3c7ff6 
  ambari-server/src/main/resources/Amba

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-07 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190398
---


Ship it!




Ship It!

- Madhuvanthi Radhakrishnan


On Nov. 7, 2017, 11:59 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
> 
> (Updated Nov. 7, 2017, 11:59 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
> (/clusters/{clusterName}/settings).
> 
> **Background:** AMBARI-22196 did the following : 
>  (1). Refactoring work of moving all cluster related configs/settings in 
> cluster-env to "cluster-settings" files.
>  (2). Implementing READ only API to access *cluster-settings* file 
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
> 
> - This was done to separate cluster related configs from stack related 
> configs.
> 
> **This JIRA implements the following :**
> 
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
>   *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
>-- the cluster settings would be initially read from the above mentioned 
> read-only API : *http://:/api/v1/cluster_settings/*. 
> 
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e5680dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  6096fa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  92f50f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  358b1bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  370f735 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3db55d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  20f4864 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  9050e3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  c219d23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  bd6d7bb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
>  abbf709 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  3b74e69 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 5ba61b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSetting.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceG

Re: Review Request 63656: Disable auto config of interpreter.json at the time of installation

2017-11-07 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63656/#review190427
---


Ship it!




Ship It!

- Gaurav Nagar


On Nov. 8, 2017, 6:03 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63656/
> ---
> 
> (Updated Nov. 8, 2017, 6:03 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22373
> https://issues.apache.org/jira/browse/AMBARI-22373
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should not configure interpreter.json if 
> zeppelin.interpreter.config.upgrade is set to false even at the time of 
> installation
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  6ccdfbafcb 
> 
> 
> Diff: https://reviews.apache.org/r/63656/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 63656: Disable auto config of interpreter.json at the time of installation

2017-11-07 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63656/#review190424
---


Ship it!




Ship It!

- venkat sairam


On Nov. 8, 2017, 6:03 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63656/
> ---
> 
> (Updated Nov. 8, 2017, 6:03 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22373
> https://issues.apache.org/jira/browse/AMBARI-22373
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should not configure interpreter.json if 
> zeppelin.interpreter.config.upgrade is set to false even at the time of 
> installation
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  6ccdfbafcb 
> 
> 
> Diff: https://reviews.apache.org/r/63656/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 63656: Disable auto config of interpreter.json at the time of installation

2017-11-07 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63656/
---

Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22373
https://issues.apache.org/jira/browse/AMBARI-22373


Repository: ambari


Description
---

Ambari should not configure interpreter.json if 
zeppelin.interpreter.config.upgrade is set to false even at the time of 
installation


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 6ccdfbafcb 


Diff: https://reviews.apache.org/r/63656/diff/1/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-07 Thread Swapan Shridhar 


> On Nov. 6, 2017, 8:06 p.m., Madhuvanthi Radhakrishnan wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java
> > Lines 138 (patched)
> > 
> >
> > Hi,
> > Do we need to create events for Cluster Setting creation?

Fixed. Removed.


> On Nov. 6, 2017, 8:06 p.m., Madhuvanthi Radhakrishnan wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql
> > Lines 179 (patched)
> > 
> >
> > Hi,
> > I guess we can have just id to be the primary key. Another uniquness 
> > will be cluster_id + setting_name in case of multi-cluster scenario.
> > Thanks.

Fixed.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190208
---


On Nov. 7, 2017, 11:59 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
> 
> (Updated Nov. 7, 2017, 11:59 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
> (/clusters/{clusterName}/settings).
> 
> **Background:** AMBARI-22196 did the following : 
>  (1). Refactoring work of moving all cluster related configs/settings in 
> cluster-env to "cluster-settings" files.
>  (2). Implementing READ only API to access *cluster-settings* file 
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
> 
> - This was done to separate cluster related configs from stack related 
> configs.
> 
> **This JIRA implements the following :**
> 
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
>   *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
>-- the cluster settings would be initially read from the above mentioned 
> read-only API : *http://:/api/v1/cluster_settings/*. 
> 
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e5680dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  6096fa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  92f50f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  358b1bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  370f735 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3db55d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  20f4864 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  9050e3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  c219d23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  bd6d7bb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
>  abbf709 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntit

Review Request 63653: Add service group dependencies

2017-11-07 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63653/
---

Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, Madhuvanthi 
Radhakrishnan, and Swapan Shridhar.


Bugs: AMBARI-22249
https://issues.apache.org/jira/browse/AMBARI-22249


Repository: ambari


Description
---

Added id column for service group dependency.
Tested and fixed cross cluster mapping
Did some code cleanup

P.S. I've added changes only for postgres .sql file. After First review, if 
main part is ok, i will add changes and test other dbs.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
 0638a06 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java
 e9cf937 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
 78610d2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java
 63e78d6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupDependencyEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
 1bcdd80 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
2193c3a 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
3d59c96 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
 7737c0d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 881f172 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql dfef1ce 
  ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5 


Diff: https://reviews.apache.org/r/63653/diff/1/


Testing
---


Thanks,

Vitalyi Brodetskyi

Review Request 63640: AMBARI-22378 BI 4.2.5 repoinfo misses the redhat-ppc7 section

2017-11-07 Thread Di Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63640/
---

Review request for Ambari, Jonathan Hurley and Tim Thorpe.


Bugs: AMBARI-22378
https://issues.apache.org/jira/browse/AMBARI-22378


Repository: ambari


Description
---

BI 4.2.5 repoinfo misses the redhat-ppc7 section, where it currently only has a 
redhat6 and a redhat7 section.


Diffs
-

  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/repos/repoinfo.xml 
d1b155d 


Diff: https://reviews.apache.org/r/63640/diff/1/


Testing
---

manually tested it by patching an Ambari 2.6.0 cluster with changes


Thanks,

Di Li

Re: Review Request 63617: Log Feeder should be able to run locally with dockerized dev env by default

2017-11-07 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63617/#review190326
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 7, 2017, 1:38 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63617/
> ---
> 
> (Updated Nov. 7, 2017, 1:38 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22364
> https://issues.apache.org/jira/browse/AMBARI-22364
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Run logfeeder locally, requirements:
> - some changes in run logsearch configs (add --monitor flag, set workspace 
> folder)
> 
> logfeeder.properties work with docker environment
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/README.md 5a64daf 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml b1b6ece 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/.gitignore
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/logs/service_sample.txt
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/global.config.json
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/input.config-sample.json
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/output.config-sample.json
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 
> 8d5174e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
>  74ea0ef 
> 
> 
> Diff: https://reviews.apache.org/r/63617/diff/1/
> 
> 
> Testing
> ---
> 
> done with docker-compose commands
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63618: Multiple issue with handling unexcepted situations

2017-11-07 Thread Andrew Onischuk 


> On Nov. 7, 2017, 3:14 p.m., Attila Doroszlai wrote:
> > ambari-agent/src/main/python/ambari_agent/ClusterCache.py
> > Lines 99-100 (original), 103-106 (patched)
> > 
> >
> > `persist_cache()` will write possibly obsolete `self.hash`, not the new 
> > one.  Should pass `cache_hash` as argument now that the order is reversed.

Nice find.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63618/#review190309
---


On Nov. 7, 2017, 1:48 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63618/
> ---
> 
> (Updated Nov. 7, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-22375
> https://issues.apache.org/jira/browse/AMBARI-22375
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * If on_update_cache fails cache should be discard
>   * loggers should log messages during initialization of classes
>   * hash of cache should only updated if saving/processing it was sucessful
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterCache.py b924420f8b 
>   ambari-agent/src/main/python/ambari_agent/InitializerModule.py 2c8021844f 
>   ambari-agent/src/main/python/ambari_agent/main.py 3948290519 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
> 2154fca8d3 
> 
> 
> Diff: https://reviews.apache.org/r/63618/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63595: Remove HADOOP_HOME From Environment For Daemons

2017-11-07 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63595/#review190312
---


Ship it!




Ship It!

- Nate Cole


On Nov. 6, 2017, 4:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63595/
> ---
> 
> (Updated Nov. 6, 2017, 4:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22370
> https://issues.apache.org/jira/browse/AMBARI-22370
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The wrapper scripts for services should be setting {{HADOOP_HOME}} correctly 
> regardless of whether or not an upgrade is taking place. There are many spots 
> which we current override this value and pass it in:
> 
> - Either via the Python files and setting the {{environment}}
> - Or by setting it in configuration files
> 
> This should be removed since we must rely on correct {{HADOOP_HOME}} to be 
> set by the wrapper scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  d8f3d374f5 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  f6f678fa89 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  933515b01b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  eaf95ad5db 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  646090ac27 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py
>  a79b593ce8 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
>  400c87c828 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py
>  4d636855c3 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  12edc6924f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
> f9480eeaff 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 7f2ed464dc 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py fad99f6496 
>   
> ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 
> b80476cab2 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 4951c7e2ec 
> 
> 
> Diff: https://reviews.apache.org/r/63595/diff/1/
> 
> 
> Testing
> ---
> 
> OK
> --
> Total run:1193
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 63618: Multiple issue with handling unexcepted situations

2017-11-07 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63618/#review190309
---


Fix it, then Ship it!





ambari-agent/src/main/python/ambari_agent/ClusterCache.py
Lines 78 (patched)


The cache still may end up in a partially updated state, since this does 
not clear it, just a local variable.



ambari-agent/src/main/python/ambari_agent/ClusterCache.py
Lines 99-100 (original), 103-106 (patched)


`persist_cache()` will write possibly obsolete `self.hash`, not the new 
one.  Should pass `cache_hash` as argument now that the order is reversed.


- Attila Doroszlai


On Nov. 7, 2017, 2:48 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63618/
> ---
> 
> (Updated Nov. 7, 2017, 2:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-22375
> https://issues.apache.org/jira/browse/AMBARI-22375
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * If on_update_cache fails cache should be discard
>   * loggers should log messages during initialization of classes
>   * hash of cache should only updated if saving/processing it was sucessful
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterCache.py b924420f8b 
>   ambari-agent/src/main/python/ambari_agent/InitializerModule.py 2c8021844f 
>   ambari-agent/src/main/python/ambari_agent/main.py 3948290519 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
> 2154fca8d3 
> 
> 
> Diff: https://reviews.apache.org/r/63618/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63617: Log Feeder should be able to run locally with dockerized dev env by default

2017-11-07 Thread Krisztian Kasa 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63617/#review190307
---


Ship it!




Ship It!

- Krisztian Kasa


On Nov. 7, 2017, 1:38 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63617/
> ---
> 
> (Updated Nov. 7, 2017, 1:38 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22364
> https://issues.apache.org/jira/browse/AMBARI-22364
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Run logfeeder locally, requirements:
> - some changes in run logsearch configs (add --monitor flag, set workspace 
> folder)
> 
> logfeeder.properties work with docker environment
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/README.md 5a64daf 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml b1b6ece 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/.gitignore
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/logs/service_sample.txt
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/global.config.json
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/input.config-sample.json
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/output.config-sample.json
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 
> 8d5174e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
>  74ea0ef 
> 
> 
> Diff: https://reviews.apache.org/r/63617/diff/1/
> 
> 
> Testing
> ---
> 
> done with docker-compose commands
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63624: Log Search UI: add navigation to first and last page

2017-11-07 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63624/#review190308
---


Ship it!




Ship It!

- Andrii Tkach


On Nov. 7, 2017, 3:01 p.m., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63624/
> ---
> 
> (Updated Nov. 7, 2017, 3:01 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-22376
> https://issues.apache.org/jira/browse/AMBARI-22376
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Pagination controls block should contain links to the first and last page.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.html
>  c227a2b 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.spec.ts
>  489f79c 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.ts
>  c71844c 
> 
> 
> Diff: https://reviews.apache.org/r/63624/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 121 of 121 SUCCESS (3.552 secs / 3.496 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 63624: Log Search UI: add navigation to first and last page

2017-11-07 Thread Andrii Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63624/
---

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-22376
https://issues.apache.org/jira/browse/AMBARI-22376


Repository: ambari


Description
---

Pagination controls block should contain links to the first and last page.


Diffs
-

  
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.html
 c227a2b 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.spec.ts
 489f79c 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.ts
 c71844c 


Diff: https://reviews.apache.org/r/63624/diff/1/


Testing
---

Executed 121 of 121 SUCCESS (3.552 secs / 3.496 secs)


Thanks,

Andrii Babiichuk

Review Request 63618: Multiple issue with handling unexcepted situations

2017-11-07 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63618/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-22375
https://issues.apache.org/jira/browse/AMBARI-22375


Repository: ambari


Description
---

* If on_update_cache fails cache should be discard
  * loggers should log messages during initialization of classes
  * hash of cache should only updated if saving/processing it was sucessful


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ClusterCache.py b924420f8b 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py 2c8021844f 
  ambari-agent/src/main/python/ambari_agent/main.py 3948290519 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
2154fca8d3 


Diff: https://reviews.apache.org/r/63618/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 63617: Log Feeder should be able to run locally with dockerized dev env by default

2017-11-07 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63617/
---

Review request for Ambari, Krisztian Kasa and Robert Nettleton.


Bugs: AMBARI-22364
https://issues.apache.org/jira/browse/AMBARI-22364


Repository: ambari


Description
---

Run logfeeder locally, requirements:
- some changes in run logsearch configs (add --monitor flag, set workspace 
folder)

logfeeder.properties work with docker environment


Diffs
-

  ambari-logsearch/ambari-logsearch-logfeeder/README.md 5a64daf 
  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml b1b6ece 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/.gitignore
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/logs/service_sample.txt
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/global.config.json
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/input.config-sample.json
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/output.config-sample.json
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 
8d5174e 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
 74ea0ef 


Diff: https://reviews.apache.org/r/63617/diff/1/


Testing
---

done with docker-compose commands


Thanks,

Oliver Szabo

Re: Review Request 63595: Remove HADOOP_HOME From Environment For Daemons

2017-11-07 Thread Jonathan Hurley 


> On Nov. 7, 2017, 6:10 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
> > Line 119 (original), 119 (patched)
> > 
> >
> >
> 
> Dmitro Lisnichenko wrote:
> will it be a case during upgrade/downgrade: hadoop_conf_dir = 
> format('{stack_root}/current/hadoop-client/conf')?

No, it shouldn't be. /etc/hadoop/conf should aways point to hadoop-client/conf 
anyway. This just makes it clearer that it's using current/hadoop-client. 
Functionally, it should be no different.


> On Nov. 7, 2017, 6:10 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
> > Line 107 (original)
> > 
> >
> > is it intended to remove env passed here?

Yes - it only had hadoop home in it:

environ = {
'HADOOP_HOME': params.hadoop_home
  }

No reason to pass an empty dictionary...


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63595/#review190288
---


On Nov. 6, 2017, 4:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63595/
> ---
> 
> (Updated Nov. 6, 2017, 4:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22370
> https://issues.apache.org/jira/browse/AMBARI-22370
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The wrapper scripts for services should be setting {{HADOOP_HOME}} correctly 
> regardless of whether or not an upgrade is taking place. There are many spots 
> which we current override this value and pass it in:
> 
> - Either via the Python files and setting the {{environment}}
> - Or by setting it in configuration files
> 
> This should be removed since we must rely on correct {{HADOOP_HOME}} to be 
> set by the wrapper scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  d8f3d374f5 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  f6f678fa89 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  933515b01b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  eaf95ad5db 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  646090ac27 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py
>  a79b593ce8 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
>  400c87c828 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py
>  4d636855c3 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  12edc6924f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
> f9480eeaff 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 7f2ed464dc 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py fad99f6496 
>   
> ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 
> b80476cab2 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 4951c7e2ec 
> 
> 
> Diff: https://reviews.apache.org/r/63595/diff/1/
> 
> 
> Testing
> ---
> 
> OK
> --
> Total run:1193
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 63616: Log Search UI: button with caret doesn't toggle dropdown is some cases

2017-11-07 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63616/#review190297
---


Ship it!




Ship It!

- Andrii Tkach


On Nov. 7, 2017, 1:27 p.m., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63616/
> ---
> 
> (Updated Nov. 7, 2017, 1:27 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-22374
> https://issues.apache.org/jira/browse/AMBARI-22374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If user clicks in the gap between icon and caret, dropdown isn't toggled.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.html
>  ca70927 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.less
>  615db24 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts
>  0aa7c7e 
> 
> 
> Diff: https://reviews.apache.org/r/63616/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 109 of 109 SUCCESS (3.186 secs / 3.147 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 63616: Log Search UI: button with caret doesn't toggle dropdown is some cases

2017-11-07 Thread Andrii Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63616/
---

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-22374
https://issues.apache.org/jira/browse/AMBARI-22374


Repository: ambari


Description
---

If user clicks in the gap between icon and caret, dropdown isn't toggled.


Diffs
-

  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.html
 ca70927 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.less
 615db24 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts
 0aa7c7e 


Diff: https://reviews.apache.org/r/63616/diff/1/


Testing
---

Executed 109 of 109 SUCCESS (3.186 secs / 3.147 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 63595: Remove HADOOP_HOME From Environment For Daemons

2017-11-07 Thread Dmitro Lisnichenko 


> On Nov. 7, 2017, 1:10 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
> > Line 119 (original), 119 (patched)
> > 
> >
> >

will it be a case during upgrade/downgrade: hadoop_conf_dir = 
format('{stack_root}/current/hadoop-client/conf')?


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63595/#review190288
---


On Nov. 6, 2017, 11:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63595/
> ---
> 
> (Updated Nov. 6, 2017, 11:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22370
> https://issues.apache.org/jira/browse/AMBARI-22370
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The wrapper scripts for services should be setting {{HADOOP_HOME}} correctly 
> regardless of whether or not an upgrade is taking place. There are many spots 
> which we current override this value and pass it in:
> 
> - Either via the Python files and setting the {{environment}}
> - Or by setting it in configuration files
> 
> This should be removed since we must rely on correct {{HADOOP_HOME}} to be 
> set by the wrapper scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  d8f3d374f5 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  f6f678fa89 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  933515b01b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  eaf95ad5db 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  646090ac27 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py
>  a79b593ce8 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
>  400c87c828 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py
>  4d636855c3 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  12edc6924f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
> f9480eeaff 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 7f2ed464dc 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py fad99f6496 
>   
> ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 
> b80476cab2 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 4951c7e2ec 
> 
> 
> Diff: https://reviews.apache.org/r/63595/diff/1/
> 
> 
> Testing
> ---
> 
> OK
> --
> Total run:1193
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 63595: Remove HADOOP_HOME From Environment For Daemons

2017-11-07 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63595/#review190288
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
Line 119 (original), 119 (patched)






ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
Line 107 (original)


is it intended to remove env passed here?


- Dmitro Lisnichenko


On Nov. 6, 2017, 11:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63595/
> ---
> 
> (Updated Nov. 6, 2017, 11:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22370
> https://issues.apache.org/jira/browse/AMBARI-22370
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The wrapper scripts for services should be setting {{HADOOP_HOME}} correctly 
> regardless of whether or not an upgrade is taking place. There are many spots 
> which we current override this value and pass it in:
> 
> - Either via the Python files and setting the {{environment}}
> - Or by setting it in configuration files
> 
> This should be removed since we must rely on correct {{HADOOP_HOME}} to be 
> set by the wrapper scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  d8f3d374f5 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  f6f678fa89 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  933515b01b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  eaf95ad5db 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  646090ac27 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py
>  a79b593ce8 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
>  400c87c828 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py
>  4d636855c3 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  12edc6924f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
> f9480eeaff 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 7f2ed464dc 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py fad99f6496 
>   
> ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 
> b80476cab2 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 4951c7e2ec 
> 
> 
> Diff: https://reviews.apache.org/r/63595/diff/1/
> 
> 
> Testing
> ---
> 
> OK
> --
> Total run:1193
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>